<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201604] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201604">201604</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-06-02 11:40:02 -0700 (Thu, 02 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>SVG content renders in incorrect vertical position when padding-left is not specified
https://bugs.webkit.org/show_bug.cgi?id=158234
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-06-02
Reviewed by Darin Adler.
Source/WebCore:
Fix the optimization in RenderSVGRoot::buildLocalToBorderBoxTransform().
Use LayoutSize::isZero() instead of LayoutSize::isEmpty() to decide whether
there is borderAndPadding applied or not.
Test: svg/custom/svg-root-padding-individual.html
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):
LayoutTests:
Make sure the SVG root element is positioned correctly when either the sum
of its (leftPadding + rightPadding) or the sum of its (topPadding + bottomPadding)
is equal to zero.
* svg/custom/svg-root-padding-individual-expected.html: Added.
* svg/custom/svg-root-padding-individual.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingsvgRenderSVGRootcpp">trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestssvgcustomsvgrootpaddingindividualexpectedhtml">trunk/LayoutTests/svg/custom/svg-root-padding-individual-expected.html</a></li>
<li><a href="#trunkLayoutTestssvgcustomsvgrootpaddingindividualhtml">trunk/LayoutTests/svg/custom/svg-root-padding-individual.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (201603 => 201604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-06-02 18:17:47 UTC (rev 201603)
+++ trunk/LayoutTests/ChangeLog 2016-06-02 18:40:02 UTC (rev 201604)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-06-02 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ SVG content renders in incorrect vertical position when padding-left is not specified
+ https://bugs.webkit.org/show_bug.cgi?id=158234
+
+ Reviewed by Darin Adler.
+
+ Make sure the SVG root element is positioned correctly when either the sum
+ of its (leftPadding + rightPadding) or the sum of its (topPadding + bottomPadding)
+ is equal to zero.
+
+ * svg/custom/svg-root-padding-individual-expected.html: Added.
+ * svg/custom/svg-root-padding-individual.html: Added.
+
</ins><span class="cx"> 2016-06-02 Adam Bergkvist <adam.bergkvist@ericsson.com>
</span><span class="cx">
</span><span class="cx"> WebRTC: Update RTCPeerConnection.addTrack() to create (or reuse) an RTCRtpTransceiver
</span></span></pre></div>
<a id="trunkLayoutTestssvgcustomsvgrootpaddingindividualexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/custom/svg-root-padding-individual-expected.html (0 => 201604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/svg-root-padding-individual-expected.html (rev 0)
+++ trunk/LayoutTests/svg/custom/svg-root-padding-individual-expected.html 2016-06-02 18:40:02 UTC (rev 201604)
</span><span class="lines">@@ -0,0 +1,25 @@
</span><ins>+<!DOCTYPE html>
+<style>
+ .inner-box {
+ width: 100px;
+ height: 100px;
+ background-color: green;
+ position: relative;
+ }
+ .position-left-100 {
+ left: 100px;
+ }
+ .position-top-100 {
+ top: 100px;
+ }
+ .container-box {
+ width: 200px;
+ height: 200px;
+ }
+</style>
+<div class="container-box">
+ <div class="inner-box position-top-100"></div>
+</div>
+<div class="container-box">
+ <div class="inner-box position-left-100"></div>
+</div>
</ins></span></pre></div>
<a id="trunkLayoutTestssvgcustomsvgrootpaddingindividualhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/svg/custom/svg-root-padding-individual.html (0 => 201604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/svg/custom/svg-root-padding-individual.html (rev 0)
+++ trunk/LayoutTests/svg/custom/svg-root-padding-individual.html 2016-06-02 18:40:02 UTC (rev 201604)
</span><span class="lines">@@ -0,0 +1,27 @@
</span><ins>+<!DOCTYPE html>
+<style>
+ .inner-box {
+ width: 100px;
+ height: 100px;
+ }
+ .padding-left-100 {
+ padding: 100px 0 0 0;
+ }
+ .padding-top-100 {
+ padding: 0 0 0 100px;
+ }
+ .container-box {
+ width: 200px;
+ height: 200px;
+ }
+</style>
+<div class="container-box">
+ <svg class="inner-box padding-left-100">
+ <rect width="100%" height="100%" fill="green"/>
+ </svg>
+</div>
+<div class="container-box">
+ <svg class="inner-box padding-top-100">
+ <rect width="100%" height="100%" fill="green"/>
+ </svg>
+</div>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (201603 => 201604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-06-02 18:17:47 UTC (rev 201603)
+++ trunk/Source/WebCore/ChangeLog 2016-06-02 18:40:02 UTC (rev 201604)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-06-02 Said Abou-Hallawa <sabouhallawa@apple.com>
+
+ SVG content renders in incorrect vertical position when padding-left is not specified
+ https://bugs.webkit.org/show_bug.cgi?id=158234
+
+ Reviewed by Darin Adler.
+
+ Fix the optimization in RenderSVGRoot::buildLocalToBorderBoxTransform().
+ Use LayoutSize::isZero() instead of LayoutSize::isEmpty() to decide whether
+ there is borderAndPadding applied or not.
+
+ Test: svg/custom/svg-root-padding-individual.html
+
+ * rendering/svg/RenderSVGRoot.cpp:
+ (WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):
+
</ins><span class="cx"> 2016-06-02 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Overhaul cross-thread use of ResourceRequest, ResourceResponse, and ResourceError.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingsvgRenderSVGRootcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp (201603 => 201604)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2016-06-02 18:17:47 UTC (rev 201603)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2016-06-02 18:40:02 UTC (rev 201604)
</span><span class="lines">@@ -331,7 +331,7 @@
</span><span class="cx"> SVGPoint translate = svgSVGElement().currentTranslate();
</span><span class="cx"> LayoutSize borderAndPadding(borderLeft() + paddingLeft(), borderTop() + paddingTop());
</span><span class="cx"> m_localToBorderBoxTransform = svgSVGElement().viewBoxToViewTransform(contentWidth() / scale, contentHeight() / scale);
</span><del>- if (borderAndPadding.isEmpty() && scale == 1 && translate == SVGPoint::zero())
</del><ins>+ if (borderAndPadding.isZero() && scale == 1 && translate == SVGPoint::zero())
</ins><span class="cx"> return;
</span><span class="cx"> m_localToBorderBoxTransform = AffineTransform(scale, 0, 0, scale, borderAndPadding.width() + translate.x(), borderAndPadding.height() + translate.y()) * m_localToBorderBoxTransform;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>