<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201566] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201566">201566</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-06-01 13:32:57 -0700 (Wed, 01 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/201488">r201488</a>.
https://bugs.webkit.org/show_bug.cgi?id=158268
Caused 23% regression on JetStream's crypto-md5 (Requested by
rniwa on #webkit).
Reverted changeset:
"[ESNext] Support trailing commas in function param lists"
https://bugs.webkit.org/show_bug.cgi?id=158020
http://trac.webkit.org/changeset/201488</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjsparsersyntaxcheckexpectedtxt">trunk/LayoutTests/js/parser-syntax-check-expected.txt</a></li>
<li><a href="#trunkLayoutTestsjsscripttestsparsersyntaxcheckjs">trunk/LayoutTests/js/script-tests/parser-syntax-check.js</a></li>
<li><a href="#trunkLayoutTestssputnikConformance13_Function_DefinitionS13_A5html">trunk/LayoutTests/sputnik/Conformance/13_Function_Definition/S13_A5.html</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserParsercpp">trunk/Source/JavaScriptCore/parser/Parser.cpp</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoretestsstresstrailingcommainfunctionparamtersjs">trunk/Source/JavaScriptCore/tests/stress/trailing-comma-in-function-paramters.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (201565 => 201566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-06-01 20:15:23 UTC (rev 201565)
+++ trunk/LayoutTests/ChangeLog 2016-06-01 20:32:57 UTC (rev 201566)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-06-01 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r201488.
+ https://bugs.webkit.org/show_bug.cgi?id=158268
+
+ Caused 23% regression on JetStream's crypto-md5 (Requested by
+ rniwa on #webkit).
+
+ Reverted changeset:
+
+ "[ESNext] Support trailing commas in function param lists"
+ https://bugs.webkit.org/show_bug.cgi?id=158020
+ http://trac.webkit.org/changeset/201488
+
</ins><span class="cx"> 2016-06-01 Nael Ouedraogo <nael.ouedraogo@crf.canon.fr>
</span><span class="cx">
</span><span class="cx"> POST request on a blob resource should return a "network error" instead of HTTP 500 response
</span></span></pre></div>
<a id="trunkLayoutTestsjsparsersyntaxcheckexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/parser-syntax-check-expected.txt (201565 => 201566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/parser-syntax-check-expected.txt 2016-06-01 20:15:23 UTC (rev 201565)
+++ trunk/LayoutTests/js/parser-syntax-check-expected.txt 2016-06-01 20:32:57 UTC (rev 201566)
</span><span class="lines">@@ -137,8 +137,8 @@
</span><span class="cx"> PASS Invalid: "function f() { a(5 }"
</span><span class="cx"> PASS Invalid: "a(5,"
</span><span class="cx"> PASS Invalid: "function f() { a(5, }"
</span><del>-PASS Valid: "a(5,)" with ReferenceError
-PASS Valid: "function f() { a(5,) }"
</del><ins>+PASS Invalid: "a(5,)"
+PASS Invalid: "function f() { a(5,) }"
</ins><span class="cx"> PASS Invalid: "a(5,6"
</span><span class="cx"> PASS Invalid: "function f() { a(5,6 }"
</span><span class="cx"> PASS Valid: "a(b[7], c <d> e.l, new a() > b)" with ReferenceError
</span><span class="lines">@@ -172,8 +172,8 @@
</span><span class="cx"> PASS Invalid: "function f() { function () {} }"
</span><span class="cx"> PASS Invalid: "function f(a b) {}"
</span><span class="cx"> PASS Invalid: "function f() { function f(a b) {} }"
</span><del>-PASS Valid: "function f(a,) {}"
-PASS Valid: "function f() { function f(a,) {} }"
</del><ins>+PASS Invalid: "function f(a,) {}"
+PASS Invalid: "function f() { function f(a,) {} }"
</ins><span class="cx"> PASS Invalid: "function f(a,"
</span><span class="cx"> PASS Invalid: "function f() { function f(a, }"
</span><span class="cx"> PASS Invalid: "function f(a, 1) {}"
</span></span></pre></div>
<a id="trunkLayoutTestsjsscripttestsparsersyntaxcheckjs"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/script-tests/parser-syntax-check.js (201565 => 201566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/script-tests/parser-syntax-check.js 2016-06-01 20:15:23 UTC (rev 201565)
+++ trunk/LayoutTests/js/script-tests/parser-syntax-check.js 2016-06-01 20:32:57 UTC (rev 201566)
</span><span class="lines">@@ -147,7 +147,7 @@
</span><span class="cx"> invalid("a(");
</span><span class="cx"> invalid("a(5");
</span><span class="cx"> invalid("a(5,");
</span><del>-valid("a(5,)");
</del><ins>+invalid("a(5,)");
</ins><span class="cx"> invalid("a(5,6");
</span><span class="cx"> valid ("a(b[7], c <d> e.l, new a() > b)");
</span><span class="cx"> invalid("a(b[5)");
</span><span class="lines">@@ -167,7 +167,7 @@
</span><span class="cx"> valid ("function f(a,b) {}");
</span><span class="cx"> invalid("function () {}");
</span><span class="cx"> invalid("function f(a b) {}");
</span><del>-valid("function f(a,) {}");
</del><ins>+invalid("function f(a,) {}");
</ins><span class="cx"> invalid("function f(a,");
</span><span class="cx"> invalid("function f(a, 1) {}");
</span><span class="cx"> valid ("function g(arguments, eval) {}");
</span></span></pre></div>
<a id="trunkLayoutTestssputnikConformance13_Function_DefinitionS13_A5html"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/sputnik/Conformance/13_Function_Definition/S13_A5.html (201565 => 201566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/sputnik/Conformance/13_Function_Definition/S13_A5.html 2016-06-01 20:15:23 UTC (rev 201565)
+++ trunk/LayoutTests/sputnik/Conformance/13_Function_Definition/S13_A5.html 2016-06-01 20:32:57 UTC (rev 201566)
</span><span class="lines">@@ -100,11 +100,11 @@
</span><span class="cx"> //////////////////////////////////////////////////////////////////////////////
</span><span class="cx"> //CHECK#3
</span><span class="cx"> try{
</span><del>- eval("function __func(arg1, arg2, arg3,,){return arguments.length;}");
- testFailed('#3: eval("function __func(arg1, arg2, arg3,,){return arguments.length;}") lead to throwing exception')
</del><ins>+ eval("function __func(arg1, arg2, arg3,){return arguments.length;}");
+ testFailed('#3: eval("function __func(arg1, arg2, arg3,){return arguments.length;}") lead to throwing exception')
</ins><span class="cx"> } catch(e){
</span><span class="cx"> if(!(e instanceof SyntaxError)){
</span><del>- testFailed('#3.1: eval("function __func(arg1, arg2, arg3,,){return arguments.length;}") lead to throwing exception of SyntaxError. Actual: exception is '+e);
</del><ins>+ testFailed('#3.1: eval("function __func(arg1, arg2, arg3,){return arguments.length;}") lead to throwing exception of SyntaxError. Actual: exception is '+e);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> //
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (201565 => 201566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-06-01 20:15:23 UTC (rev 201565)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-06-01 20:32:57 UTC (rev 201566)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-06-01 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r201488.
+ https://bugs.webkit.org/show_bug.cgi?id=158268
+
+ Caused 23% regression on JetStream's crypto-md5 (Requested by
+ rniwa on #webkit).
+
+ Reverted changeset:
+
+ "[ESNext] Support trailing commas in function param lists"
+ https://bugs.webkit.org/show_bug.cgi?id=158020
+ http://trac.webkit.org/changeset/201488
+
</ins><span class="cx"> 2016-05-31 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><span class="cx"> Dictionary property access should be fast
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/Parser.cpp (201565 => 201566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/Parser.cpp 2016-06-01 20:15:23 UTC (rev 201565)
+++ trunk/Source/JavaScriptCore/parser/Parser.cpp 2016-06-01 20:32:57 UTC (rev 201566)
</span><span class="lines">@@ -1746,9 +1746,6 @@
</span><span class="cx"> TreeDestructuringPattern parameter = 0;
</span><span class="cx"> TreeExpression defaultValue = 0;
</span><span class="cx">
</span><del>- if (match(CLOSEPAREN))
- break;
-
</del><span class="cx"> if (match(DOTDOTDOT)) {
</span><span class="cx"> next();
</span><span class="cx"> failIfFalse(matchSpecIdentifier(), "Rest parameter '...' should be followed by a variable identifier");
</span><span class="lines">@@ -3829,9 +3826,6 @@
</span><span class="cx"> JSTokenLocation argumentLocation(tokenLocation());
</span><span class="cx"> next(TreeBuilder::DontBuildStrings);
</span><span class="cx">
</span><del>- if (match(CLOSEPAREN))
- break;
-
</del><span class="cx"> TreeExpression arg = parseArgument(context, argType);
</span><span class="cx"> propagateError();
</span><span class="cx"> semanticFailIfTrue(match(DOTDOTDOT), "The '...' operator should come before the target expression");
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstresstrailingcommainfunctionparamtersjs"></a>
<div class="delfile"><h4>Deleted: trunk/Source/JavaScriptCore/tests/stress/trailing-comma-in-function-paramters.js (201565 => 201566)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/trailing-comma-in-function-paramters.js 2016-06-01 20:15:23 UTC (rev 201565)
+++ trunk/Source/JavaScriptCore/tests/stress/trailing-comma-in-function-paramters.js 2016-06-01 20:32:57 UTC (rev 201566)
</span><span class="lines">@@ -1,63 +0,0 @@
</span><del>-function test(result, expected, message) {
- if (result !== expected)
- throw "Error: " + message + ". was: " + result + " wanted: " + expected;
-}
-
-function evalWithThrow(text) {
- var result;
- try {
- result = eval(text);
- } catch (error) {
- return error.toString();
- }
- return result;
-}
-
-test(evalWithThrow('typeof function(,){ return a; }'), 'SyntaxError: Unexpected token \',\'. Expected a parameter pattern or a \')\' in parameter list.');
-test(evalWithThrow('typeof function(a,,){ return a; }'), 'SyntaxError: Unexpected token \',\'. Expected a parameter pattern or a \')\' in parameter list.');
-test(evalWithThrow('function a(a, ...last,){ return; }'), 'SyntaxError: Unexpected token \',\'. Rest parameter should be the last parameter in a function declaration.');
-test(eval('typeof function(a,){ return a; }'), 'function');
-test(eval('typeof function(a, b,){ return a + b; }'), 'function');
-test(eval('typeof function(a, b, c, ){ return a + b + c; }'), 'function');
-
-test(evalWithThrow('typeof ((,)=>{ return a; })'), 'SyntaxError: Unexpected token \',\'');
-test(evalWithThrow('typeof ((a,,)=>{ return a; })'), 'SyntaxError: Unexpected token \',\'');
-test(evalWithThrow('typeof ((a, ...last,)=>{ return a; })'), 'SyntaxError: Unexpected token \'...\'');
-test(eval('typeof ((a,)=>{ return a; })'), 'function');
-test(eval('typeof ((a, b,)=>{ return a + b; })'), 'function');
-test(eval('typeof ((a, b, c)=>{ return a + b + c; })'), 'function');
-
-test(evalWithThrow('typeof ((,)=>a)'), 'SyntaxError: Unexpected token \',\'');
-test(evalWithThrow('typeof ((a,,)=>a)'), 'SyntaxError: Unexpected token \',\'');
-test(evalWithThrow('(a,...last,)=>0;'), 'SyntaxError: Unexpected token \'...\'');
-test(eval('typeof ((a,)=>a)'), 'function');
-test(eval('typeof ((a, b,)=>a + b)'), 'function');
-test(eval('typeof ((a, b, c)=>a + b + c)'), 'function');
-
-test(evalWithThrow('typeof ((,)=>a)'), 'SyntaxError: Unexpected token \',\'');
-test(evalWithThrow('typeof ((a,,)=>a)'), 'SyntaxError: Unexpected token \',\'');
-test(evalWithThrow('(a,...last,)=>0;'), 'SyntaxError: Unexpected token \'...\'');
-test(eval('typeof ((a,)=>a)'), 'function');
-test(eval('typeof ((a, b,)=>a + b)'), 'function');
-test(eval('typeof ((a, b, c)=>a + b + c)'), 'function');
-
-test(evalWithThrow('typeof function(a = "x0",,){ return a; }'), 'SyntaxError: Unexpected token \',\'. Expected a parameter pattern or a \')\' in parameter list.');
-test(evalWithThrow('typeof function(a = "x0",...last,){ return a; }'), 'SyntaxError: Unexpected token \',\'. Rest parameter should be the last parameter in a function declaration.');
-test(eval('typeof function(a = "x0",){ return a; }'), 'function');
-test(eval('typeof function(a = "x1", b = "y1",){ return a + b; }'), 'function');
-test(eval('typeof function(a = "x2", b = "y2", c = "z3"){ return a + b + c; }'), 'function');
-
-test(evalWithThrow('(function(a){ return a; })(,)'), 'SyntaxError: Unexpected token \',\'');
-test(evalWithThrow('(function(a){ return a; })("A",,)'), 'SyntaxError: Unexpected token \',\'');
-test(eval('(function(a){ return a; })("A",)'), 'A');
-test(eval('(function(a, b,){ return a + b; })("A", "B",)'), 'AB');
-test(eval('(function(a, b, c){ return a + b + c; })("A", "B", "C",)'), 'ABC');
-
-test(eval('(function(a){ return arguments.length; })("A",)'), 1);
-test(eval('(function(a, b,){ return arguments.length; })("A", "B",)'), 2);
-test(eval('(function(a, b, c){ return arguments.length; })("A", "B", "C",)'), 3);
-test(eval('(function(a,) { }).length'), 1);
-test(eval('(function(a, b, ) { }).length'), 2);
-test(eval('(function(a, b, c, ) { }).length'), 3);
-
-
</del></span></pre>
</div>
</div>
</body>
</html>