<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201450] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201450">201450</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-05-27 06:51:02 -0700 (Fri, 27 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Video play glyph not visible if initially invisible when contained in a "-webkit-overflow-scrolling: touch" container
https://bugs.webkit.org/show_bug.cgi?id=158146
<rdar://problem/25816307>
Patch by Antoine Quint <graouts@apple.com> on 2016-05-27
Reviewed by Dean Jackson.
Source/WebCore:
We now force the <video> controls play glyph into being composited due to webkit.org/b/158147. In most scenarios,
this element gets composited anyway, this is just to ensure that this happens in all cases until we get the
general fix for webkit.org/b/158147.
Test: platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html
* Modules/mediacontrols/mediaControlsiOS.css:
(video::-webkit-media-controls-start-playback-button .webkit-media-controls-start-playback-glyph):
LayoutTests:
Testing that on iOS the play glyph for <video> controls when play button would be initially invisible when contained
in a scrollable container is indeed composited.
* platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container-expected.txt: Added.
* platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsiOScss">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li>trunk/LayoutTests/platform/ios-simulator/media/</li>
<li><a href="#trunkLayoutTestsplatformiossimulatormediavideoplayglyphcompositedoutsideoverflowscrollingtouchcontainerexpectedtxt">trunk/LayoutTests/platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatormediavideoplayglyphcompositedoutsideoverflowscrollingtouchcontainerhtml">trunk/LayoutTests/platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (201449 => 201450)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-05-27 07:18:41 UTC (rev 201449)
+++ trunk/LayoutTests/ChangeLog 2016-05-27 13:51:02 UTC (rev 201450)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-05-27 Antoine Quint <graouts@apple.com>
+
+ Video play glyph not visible if initially invisible when contained in a "-webkit-overflow-scrolling: touch" container
+ https://bugs.webkit.org/show_bug.cgi?id=158146
+ <rdar://problem/25816307>
+
+ Reviewed by Dean Jackson.
+
+ Testing that on iOS the play glyph for <video> controls when play button would be initially invisible when contained
+ in a scrollable container is indeed composited.
+
+ * platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container-expected.txt: Added.
+ * platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html: Added.
+
</ins><span class="cx"> 2016-05-26 Yoav Weiss <yoav@yoav.ws>
</span><span class="cx">
</span><span class="cx"> Preload single download tests.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatormediavideoplayglyphcompositedoutsideoverflowscrollingtouchcontainerexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container-expected.txt (0 => 201450)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container-expected.txt 2016-05-27 13:51:02 UTC (rev 201450)
</span><span class="lines">@@ -0,0 +1,55 @@
</span><ins>+
+(GraphicsLayer
+ (anchor 0.00 0.00)
+ (bounds 800.00 600.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 800.00 600.00)
+ (contentsOpaque 1)
+ (children 1
+ (GraphicsLayer
+ (position 8.00 8.00)
+ (bounds 300.00 300.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 300.00 300.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 300.00 677.00)
+ (drawsContent 1)
+ (children 1
+ (GraphicsLayer
+ (bounds 300.00 672.00)
+ (children 1
+ (GraphicsLayer
+ (position 114.00 300.00)
+ (bounds 72.00 72.00)
+ (children 2
+ (GraphicsLayer
+ (bounds 72.00 72.00)
+ (drawsContent 1)
+ (mask layer)
+ (GraphicsLayer
+ (bounds 72.00 72.00)
+ )
+ )
+ (GraphicsLayer
+ (bounds 72.00 72.00)
+ (opacity 0.60)
+ (drawsContent 1)
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+)
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatormediavideoplayglyphcompositedoutsideoverflowscrollingtouchcontainerhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html (0 => 201450)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html 2016-05-27 13:51:02 UTC (rev 201450)
</span><span class="lines">@@ -0,0 +1,32 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<meta name="viewport" content="width=device-width" />
+<style>
+
+ .scrolling {
+ width: 300px;
+ height: 300px;
+ overflow-y: scroll;
+ -webkit-overflow-scrolling: touch;
+ }
+
+ video {
+ width: 300px;
+ height: 672px;
+ }
+
+</style>
+</head>
+<body>
+ <div class="scrolling">
+ <video controls poster="data:image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs=">
+ </div>
+ <pre id="console"></pre>
+ <script>
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ document.getElementById("console").appendChild(document.createTextNode(window.internals.layerTreeAsText(document)));
+ }
+ </script>
+</body>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (201449 => 201450)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-27 07:18:41 UTC (rev 201449)
+++ trunk/Source/WebCore/ChangeLog 2016-05-27 13:51:02 UTC (rev 201450)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-05-27 Antoine Quint <graouts@apple.com>
+
+ Video play glyph not visible if initially invisible when contained in a "-webkit-overflow-scrolling: touch" container
+ https://bugs.webkit.org/show_bug.cgi?id=158146
+ <rdar://problem/25816307>
+
+ Reviewed by Dean Jackson.
+
+ We now force the <video> controls play glyph into being composited due to webkit.org/b/158147. In most scenarios,
+ this element gets composited anyway, this is just to ensure that this happens in all cases until we get the
+ general fix for webkit.org/b/158147.
+
+ Test: platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html
+
+ * Modules/mediacontrols/mediaControlsiOS.css:
+ (video::-webkit-media-controls-start-playback-button .webkit-media-controls-start-playback-glyph):
+
</ins><span class="cx"> 2016-05-26 Yoav Weiss <yoav@yoav.ws>
</span><span class="cx">
</span><span class="cx"> Preload single download tests.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsiOScss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css (201449 => 201450)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2016-05-27 07:18:41 UTC (rev 201449)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css 2016-05-27 13:51:02 UTC (rev 201450)
</span><span class="lines">@@ -243,6 +243,8 @@
</span><span class="cx"> background-repeat: no-repeat;
</span><span class="cx"> background-position: 50% 50%;
</span><span class="cx"> background-size: 100% 100%;
</span><ins>+ /* FIXME This is an ad-hoc fix until we fix the real compositing issue tracked by webkit.org/b/158147 */
+ will-change: opacity;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> video::-webkit-media-controls-start-playback-button .webkit-media-controls-start-playback-glyph.active {
</span></span></pre>
</div>
</div>
</body>
</html>