<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201391] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201391">201391</a></dd>
<dt>Author</dt> <dd>keith_miller@apple.com</dd>
<dt>Date</dt> <dd>2016-05-25 11:31:39 -0700 (Wed, 25 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
https://bugs.webkit.org/show_bug.cgi?id=158077
Reviewed by Mark Lam.
Since we didn't have JSBench in the tree before we needed to lookup the path to it from
benchmark config file. That's no longer the case so we should just fix it in the script.
* Scripts/run-jsc-benchmarks:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsrunjscbenchmarks">trunk/Tools/Scripts/run-jsc-benchmarks</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (201390 => 201391)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-05-25 18:20:26 UTC (rev 201390)
+++ trunk/Tools/ChangeLog 2016-05-25 18:31:39 UTC (rev 201391)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-05-25 Keith Miller <keith_miller@apple.com>
+
+ run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
+ https://bugs.webkit.org/show_bug.cgi?id=158077
+
+ Reviewed by Mark Lam.
+
+ Since we didn't have JSBench in the tree before we needed to lookup the path to it from
+ benchmark config file. That's no longer the case so we should just fix it in the script.
+
+ * Scripts/run-jsc-benchmarks:
+
</ins><span class="cx"> 2016-05-24 Aakash Jain <aakash_jain@apple.com>
</span><span class="cx">
</span><span class="cx"> Reorganize dashboard code: move code from _timeIntervalString to base class
</span></span></pre></div>
<a id="trunkToolsScriptsrunjscbenchmarks"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/run-jsc-benchmarks (201390 => 201391)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/run-jsc-benchmarks 2016-05-25 18:20:26 UTC (rev 201390)
+++ trunk/Tools/Scripts/run-jsc-benchmarks 2016-05-25 18:31:39 UTC (rev 201391)
</span><span class="lines">@@ -43,12 +43,14 @@
</span><span class="cx"> raise unless SCRIPT_PATH.dirname.dirname.basename.to_s == "Tools"
</span><span class="cx">
</span><span class="cx"> OPENSOURCE_PATH = SCRIPT_PATH.dirname.dirname.dirname
</span><ins>+PERFORMANCETESTS_PATH = OPENSOURCE_PATH + "PerformanceTests"
</ins><span class="cx">
</span><del>-SUNSPIDER_PATH = OPENSOURCE_PATH + "PerformanceTests" + "SunSpider" + "tests" + "sunspider-1.0"
-LONGSPIDER_PATH = OPENSOURCE_PATH + "PerformanceTests" + "LongSpider"
-V8_PATH = OPENSOURCE_PATH + "PerformanceTests" + "SunSpider" + "tests" + "v8-v6"
</del><ins>+SUNSPIDER_PATH = PERFORMANCETESTS_PATH + "SunSpider" + "tests" + "sunspider-1.0"
+LONGSPIDER_PATH = PERFORMANCETESTS_PATH + "LongSpider"
+V8_PATH = PERFORMANCETESTS_PATH + "SunSpider" + "tests" + "v8-v6"
</ins><span class="cx"> JSREGRESS_PATH = OPENSOURCE_PATH + "LayoutTests" + "js" + "regress" + "script-tests"
</span><del>-OCTANE_WRAPPER_PATH = OPENSOURCE_PATH + "PerformanceTests" + "Octane" + "wrappers"
</del><ins>+OCTANE_WRAPPER_PATH = PERFORMANCETESTS_PATH + "Octane" + "wrappers"
+JSBENCH_PATH = PERFORMANCETESTS_PATH + "JSBench"
</ins><span class="cx">
</span><span class="cx"> TEMP_PATH = OPENSOURCE_PATH + "BenchmarkTemp"
</span><span class="cx">
</span><span class="lines">@@ -2860,7 +2862,6 @@
</span><span class="cx"> DSPJS_JSLINUX_PATH = pathname_if_exist(config["DSPJSLinuxPath"])
</span><span class="cx"> DSPJS_AMMOJS_ASMJS_PATH = pathname_if_exist(config["DSPJSAmmoJSAsmJSPath"])
</span><span class="cx"> DSPJS_AMMOJS_REGULAR_PATH = pathname_if_exist(config["DSPJSAmmoJSRegularPath"])
</span><del>- JSBENCH_PATH = pathname_if_exist(config["JSBenchPath"])
</del><span class="cx"> KRAKEN_PATH = pathname_if_exist(config["KrakenPath"])
</span><span class="cx">
</span><span class="cx"> # If the --dont-copy-vms option was passed, it overrides the --force-vm-copy option.
</span></span></pre>
</div>
</div>
</body>
</html>