<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201333] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201333">201333</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-05-24 09:50:26 -0700 (Tue, 24 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use auto for some of our lambda function parameters
https://bugs.webkit.org/show_bug.cgi?id=158001
Reviewed by Darin Adler.
Use auto for some of our lambda function parameters now that we build with c++14.
Source/WebCore:
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::buffered):
(WebCore::MediaSource::monitorSourceBuffers):
(WebCore::MediaSource::endOfStream):
* Modules/mediasource/SampleMap.cpp:
(WebCore::PresentationOrderSampleMap::findSamplesWithinPresentationRangeFromEnd):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::removeAll):
* css/MediaList.cpp:
(WebCore::MediaQuerySet::remove):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::removeListener):
* dom/Document.cpp:
(WebCore::Document::validateAutoSizingNodes):
* dom/Element.cpp:
(WebCore::Element::detachAttrNodeFromElementWithValue):
* dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliverAllMutations):
* dom/Node.cpp:
(WebCore::Node::unregisterMutationObserver):
* html/LinkIconCollector.cpp:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL):
* page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::sortedTrackListForMenu):
* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu):
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::clear):
* platform/graphics/FontCascade.cpp:
(WebCore::pruneUnreferencedEntriesFromFontCascadeCache):
* platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::pruneSystemFallbacks):
* platform/graphics/PathUtilities.cpp:
(WebCore::addIntersectionPoints):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
* platform/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::initElements):
* svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendLigatureSubtable):
(WebCore::SVGToOTFFontConverter::finishAppendingKERNSubtable):
Source/WebKit2:
* DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::didGetRecord):
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::fetchDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::clearDiskCacheEntries):
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):
* NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::registerLoad):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveEntryFromStorage):
(WebKit::NetworkCache::SpeculativeLoadManager::revalidateEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry):
* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::removeFromPendingWriteOperations):
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
* Shared/API/Cocoa/_WKRemoteObjectInterface.mm:
(-[_WKRemoteObjectInterface debugDescription]):
* UIProcess/API/C/WKApplicationCacheManager.cpp:
(WKApplicationCacheManagerGetApplicationCacheOrigins):
* UIProcess/API/C/WKKeyValueStorageManager.cpp:
(WKKeyValueStorageManagerGetKeyValueStorageOrigins):
(WKKeyValueStorageManagerGetStorageDetailsByOrigin):
* UIProcess/API/C/WKResourceCacheManager.cpp:
(WKResourceCacheManagerGetCacheOrigins):
* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):
* UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
(WebKit::WebUserContentControllerProxy::removeAllUserMessageHandlers):
* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::removeAnimationForKey):
Source/WTF:
* wtf/BubbleSort.h:
(WTF::bubbleSort):
Tools:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::willDestroyPage):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtfBubbleSorth">trunk/Source/WTF/wtf/BubbleSort.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediasourceMediaSourcecpp">trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediasourceSampleMapcpp">trunk/Source/WebCore/Modules/mediasource/SampleMap.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsSerializedScriptValuecpp">trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSValueListcpp">trunk/Source/WebCore/css/CSSValueList.cpp</a></li>
<li><a href="#trunkSourceWebCorecssMediaListcpp">trunk/Source/WebCore/css/MediaList.cpp</a></li>
<li><a href="#trunkSourceWebCorecssMediaQuerycpp">trunk/Source/WebCore/css/MediaQuery.cpp</a></li>
<li><a href="#trunkSourceWebCorecssMediaQueryMatchercpp">trunk/Source/WebCore/css/MediaQueryMatcher.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomMutationObservercpp">trunk/Source/WebCore/dom/MutationObserver.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNodecpp">trunk/Source/WebCore/dom/Node.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlLinkIconCollectorcpp">trunk/Source/WebCore/html/LinkIconCollector.cpp</a></li>
<li><a href="#trunkSourceWebCoreinspectorInspectorIndexedDBAgentcpp">trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp</a></li>
<li><a href="#trunkSourceWebCoreloaderResourceLoadercpp">trunk/Source/WebCore/loader/ResourceLoader.cpp</a></li>
<li><a href="#trunkSourceWebCorepageCaptionUserPreferencescpp">trunk/Source/WebCore/page/CaptionUserPreferences.cpp</a></li>
<li><a href="#trunkSourceWebCorepageCaptionUserPreferencesMediaAFcpp">trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp</a></li>
<li><a href="#trunkSourceWebCorepageanimationAnimationControllercpp">trunk/Source/WebCore/page/animation/AnimationController.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsFontCascadecpp">trunk/Source/WebCore/platform/graphics/FontCascade.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsFontCascadeFontscpp">trunk/Source/WebCore/platform/graphics/FontCascadeFonts.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsPathUtilitiescpp">trunk/Source/WebCore/platform/graphics/PathUtilities.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicsavfoundationobjcMediaPlayerPrivateMediaStreamAVFObjCmm">trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicstexmapTextureMapperGLcpp">trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformmacHIDGamepadcpp">trunk/Source/WebCore/platform/mac/HIDGamepad.cpp</a></li>
<li><a href="#trunkSourceWebCoresvgSVGToOTFFontConversioncpp">trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkConnectionToWebProcesscpp">trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkProcesscpp">trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcessNetworkResourceLoadercpp">trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesscacheNetworkCacheSpeculativeLoadcpp">trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesscacheNetworkCacheSpeculativeLoadManagercpp">trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesscacheNetworkCacheStoragecpp">trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp</a></li>
<li><a href="#trunkSourceWebKit2NetworkProcesscocoaNetworkSessionCocoamm">trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm</a></li>
<li><a href="#trunkSourceWebKit2SharedAPICocoa_WKRemoteObjectInterfacemm">trunk/Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKApplicationCacheManagercpp">trunk/Source/WebKit2/UIProcess/API/C/WKApplicationCacheManager.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKKeyValueStorageManagercpp">trunk/Source/WebKit2/UIProcess/API/C/WKKeyValueStorageManager.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKResourceCacheManagercpp">trunk/Source/WebKit2/UIProcess/API/C/WKResourceCacheManager.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICocoaWKWebsiteDataStoremm">trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessUserContentWebUserContentControllerProxycpp">trunk/Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemotecpp">trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckerscpppy">trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py</a></li>
<li><a href="#trunkToolsScriptswebkitpystylecheckerscpp_unittestpy">trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py</a></li>
<li><a href="#trunkToolsWebKitTestRunnerInjectedBundleInjectedBundlecpp">trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WTF/ChangeLog 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-05-24 Chris Dumez <cdumez@apple.com>
+
+ Use auto for some of our lambda function parameters
+ https://bugs.webkit.org/show_bug.cgi?id=158001
+
+ Reviewed by Darin Adler.
+
+ Use auto for some of our lambda function parameters now that we build with c++14.
+
+ * wtf/BubbleSort.h:
+ (WTF::bubbleSort):
+
</ins><span class="cx"> 2016-05-23 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Speed up move of vectors of POD types that have an inline buffer
</span></span></pre></div>
<a id="trunkSourceWTFwtfBubbleSorth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/BubbleSort.h (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/BubbleSort.h 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WTF/wtf/BubbleSort.h 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -89,8 +89,7 @@
</span><span class="cx"> {
</span><span class="cx"> bubbleSort(
</span><span class="cx"> begin, end,
</span><del>- [] (const typename std::iterator_traits<IteratorType>::value_type& left,
- const typename std::iterator_traits<IteratorType>::value_type& right) -> bool {
</del><ins>+ [](auto& left, auto& right) {
</ins><span class="cx"> return left < right;
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/ChangeLog 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -1,3 +1,65 @@
</span><ins>+2016-05-24 Chris Dumez <cdumez@apple.com>
+
+ Use auto for some of our lambda function parameters
+ https://bugs.webkit.org/show_bug.cgi?id=158001
+
+ Reviewed by Darin Adler.
+
+ Use auto for some of our lambda function parameters now that we build with c++14.
+
+ * Modules/mediasource/MediaSource.cpp:
+ (WebCore::MediaSource::buffered):
+ (WebCore::MediaSource::monitorSourceBuffers):
+ (WebCore::MediaSource::endOfStream):
+ * Modules/mediasource/SampleMap.cpp:
+ (WebCore::PresentationOrderSampleMap::findSamplesWithinPresentationRangeFromEnd):
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::ariaSelectedRows):
+ * bindings/js/SerializedScriptValue.cpp:
+ (WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDB):
+ * css/CSSValueList.cpp:
+ (WebCore::CSSValueList::removeAll):
+ * css/MediaList.cpp:
+ (WebCore::MediaQuerySet::remove):
+ * css/MediaQuery.cpp:
+ (WebCore::MediaQuery::MediaQuery):
+ * css/MediaQueryMatcher.cpp:
+ (WebCore::MediaQueryMatcher::removeListener):
+ * dom/Document.cpp:
+ (WebCore::Document::validateAutoSizingNodes):
+ * dom/Element.cpp:
+ (WebCore::Element::detachAttrNodeFromElementWithValue):
+ * dom/MutationObserver.cpp:
+ (WebCore::MutationObserver::deliverAllMutations):
+ * dom/Node.cpp:
+ (WebCore::Node::unregisterMutationObserver):
+ * html/LinkIconCollector.cpp:
+ * inspector/InspectorIndexedDBAgent.cpp:
+ (WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
+ * loader/ResourceLoader.cpp:
+ (WebCore::ResourceLoader::loadDataURL):
+ * page/CaptionUserPreferences.cpp:
+ (WebCore::CaptionUserPreferences::sortedTrackListForMenu):
+ * page/CaptionUserPreferencesMediaAF.cpp:
+ (WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu):
+ * page/animation/AnimationController.cpp:
+ (WebCore::AnimationControllerPrivate::clear):
+ * platform/graphics/FontCascade.cpp:
+ (WebCore::pruneUnreferencedEntriesFromFontCascadeCache):
+ * platform/graphics/FontCascadeFonts.cpp:
+ (WebCore::FontCascadeFonts::pruneSystemFallbacks):
+ * platform/graphics/PathUtilities.cpp:
+ (WebCore::addIntersectionPoints):
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
+ * platform/graphics/texmap/TextureMapperGL.cpp:
+ (WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
+ * platform/mac/HIDGamepad.cpp:
+ (WebCore::HIDGamepad::initElements):
+ * svg/SVGToOTFFontConversion.cpp:
+ (WebCore::SVGToOTFFontConverter::appendLigatureSubtable):
+ (WebCore::SVGToOTFFontConverter::finishAppendingKERNSubtable):
+
</ins><span class="cx"> 2016-05-24 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r196629): Safari can get into a state where switching Reader theme doesn't apply to the webpage
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediasourceMediaSourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -141,7 +141,7 @@
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<PlatformTimeRanges> MediaSource::buffered() const
</span><span class="cx"> {
</span><del>- if (m_buffered && m_activeSourceBuffers->length() && std::all_of(m_activeSourceBuffers->begin(), m_activeSourceBuffers->end(), [] (RefPtr<SourceBuffer>& buffer) { return !buffer->isBufferedDirty(); }))
</del><ins>+ if (m_buffered && m_activeSourceBuffers->length() && std::all_of(m_activeSourceBuffers->begin(), m_activeSourceBuffers->end(), [](auto& buffer) { return !buffer->isBufferedDirty(); }))
</ins><span class="cx"> return std::make_unique<PlatformTimeRanges>(*m_buffered);
</span><span class="cx">
</span><span class="cx"> m_buffered = std::make_unique<PlatformTimeRanges>();
</span><span class="lines">@@ -264,7 +264,7 @@
</span><span class="cx"> // playback position:
</span><span class="cx"> auto begin = m_activeSourceBuffers->begin();
</span><span class="cx"> auto end = m_activeSourceBuffers->end();
</span><del>- if (std::all_of(begin, end, [](RefPtr<SourceBuffer>& sourceBuffer) {
</del><ins>+ if (std::all_of(begin, end, [](auto& sourceBuffer) {
</ins><span class="cx"> return !sourceBuffer->hasCurrentTime();
</span><span class="cx"> })) {
</span><span class="cx"> // 1. Set the HTMLMediaElement.readyState attribute to HAVE_METADATA.
</span><span class="lines">@@ -278,7 +278,7 @@
</span><span class="cx">
</span><span class="cx"> // ↳ If buffered for all objects in activeSourceBuffers contain TimeRanges that include the current
</span><span class="cx"> // playback position and enough data to ensure uninterrupted playback:
</span><del>- if (std::all_of(begin, end, [](RefPtr<SourceBuffer>& sourceBuffer) {
</del><ins>+ if (std::all_of(begin, end, [](auto& sourceBuffer) {
</ins><span class="cx"> return sourceBuffer->hasFutureTime() && sourceBuffer->canPlayThrough();
</span><span class="cx"> })) {
</span><span class="cx"> // 1. Set the HTMLMediaElement.readyState attribute to HAVE_ENOUGH_DATA.
</span><span class="lines">@@ -295,7 +295,7 @@
</span><span class="cx">
</span><span class="cx"> // ↳ If buffered for all objects in activeSourceBuffers contain a TimeRange that includes
</span><span class="cx"> // the current playback position and some time beyond the current playback position, then run the following steps:
</span><del>- if (std::all_of(begin, end, [](RefPtr<SourceBuffer>& sourceBuffer) {
</del><ins>+ if (std::all_of(begin, end, [](auto& sourceBuffer) {
</ins><span class="cx"> return sourceBuffer->hasFutureTime();
</span><span class="cx"> })) {
</span><span class="cx"> // 1. Set the HTMLMediaElement.readyState attribute to HAVE_FUTURE_DATA.
</span><span class="lines">@@ -426,7 +426,7 @@
</span><span class="cx">
</span><span class="cx"> // 2. If the updating attribute equals true on any SourceBuffer in sourceBuffers, then throw an
</span><span class="cx"> // INVALID_STATE_ERR exception and abort these steps.
</span><del>- if (std::any_of(m_sourceBuffers->begin(), m_sourceBuffers->end(), [](RefPtr<SourceBuffer>& sourceBuffer) { return sourceBuffer->updating(); })) {
</del><ins>+ if (std::any_of(m_sourceBuffers->begin(), m_sourceBuffers->end(), [](auto& sourceBuffer) { return sourceBuffer->updating(); })) {
</ins><span class="cx"> ec = INVALID_STATE_ERR;
</span><span class="cx"> return;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediasourceSampleMapcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediasource/SampleMap.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediasource/SampleMap.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/Modules/mediasource/SampleMap.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -244,11 +244,11 @@
</span><span class="cx">
</span><span class="cx"> PresentationOrderSampleMap::iterator_range PresentationOrderSampleMap::findSamplesWithinPresentationRangeFromEnd(const MediaTime& beginTime, const MediaTime& endTime)
</span><span class="cx"> {
</span><del>- reverse_iterator rangeEnd = std::find_if(rbegin(), rend(), [&beginTime] (PresentationOrderSampleMap::MapType::value_type value) {
</del><ins>+ reverse_iterator rangeEnd = std::find_if(rbegin(), rend(), [&beginTime](auto& value) {
</ins><span class="cx"> return value.second->presentationTime() <= beginTime;
</span><span class="cx"> });
</span><span class="cx">
</span><del>- reverse_iterator rangeStart = std::find_if(rbegin(), rangeEnd, [&endTime] (PresentationOrderSampleMap::MapType::value_type value) {
</del><ins>+ reverse_iterator rangeStart = std::find_if(rbegin(), rangeEnd, [&endTime](auto& value) {
</ins><span class="cx"> return value.second->presentationTime() <= endTime;
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityRenderObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -3245,7 +3245,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Get all the rows.
</span><del>- auto rowsIteration = [&](const AccessibilityChildrenVector& rows) {
</del><ins>+ auto rowsIteration = [&](auto& rows) {
</ins><span class="cx"> for (auto& row : rows) {
</span><span class="cx"> if (row->isSelected()) {
</span><span class="cx"> result.append(row);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsSerializedScriptValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -2802,7 +2802,7 @@
</span><span class="cx"> ASSERT(hasBlobURLs());
</span><span class="cx">
</span><span class="cx"> RefPtr<SerializedScriptValue> protectedThis(this);
</span><del>- blobRegistry().writeBlobsToTemporaryFiles(m_blobURLs, [completionHandler = WTFMove(completionHandler), this, protectedThis = WTFMove(protectedThis)](const Vector<String>& blobFilePaths) {
</del><ins>+ blobRegistry().writeBlobsToTemporaryFiles(m_blobURLs, [completionHandler = WTFMove(completionHandler), this, protectedThis = WTFMove(protectedThis)](auto& blobFilePaths) {
</ins><span class="cx"> ASSERT(isMainThread());
</span><span class="cx">
</span><span class="cx"> if (blobFilePaths.isEmpty()) {
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSValueListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSValueList.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSValueList.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/css/CSSValueList.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -60,7 +60,7 @@
</span><span class="cx"> if (!value)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- return m_values.removeAllMatching([value] (const Ref<CSSValue>& current) {
</del><ins>+ return m_values.removeAllMatching([value](auto& current) {
</ins><span class="cx"> return current->equals(*value);
</span><span class="cx"> }) > 0;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssMediaListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/MediaList.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/MediaList.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/css/MediaList.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -186,7 +186,7 @@
</span><span class="cx"> if (!parsedQuery)
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- return m_queries.removeFirstMatching([&parsedQuery] (const std::unique_ptr<MediaQuery>& query) {
</del><ins>+ return m_queries.removeFirstMatching([&parsedQuery](auto& query) {
</ins><span class="cx"> return *query == *parsedQuery;
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssMediaQuerycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/MediaQuery.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/MediaQuery.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/css/MediaQuery.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -83,7 +83,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- std::sort(m_expressions->begin(), m_expressions->end(), [](const std::unique_ptr<MediaQueryExp>& a, const std::unique_ptr<MediaQueryExp>& b) {
</del><ins>+ std::sort(m_expressions->begin(), m_expressions->end(), [](auto& a, auto& b) {
</ins><span class="cx"> return codePointCompare(a->serialize(), b->serialize()) < 0;
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssMediaQueryMatchercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/MediaQueryMatcher.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/MediaQueryMatcher.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/css/MediaQueryMatcher.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -131,7 +131,7 @@
</span><span class="cx"> if (!m_document)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- m_listeners.removeFirstMatching([listener, query] (const std::unique_ptr<Listener>& current) {
</del><ins>+ m_listeners.removeFirstMatching([listener, query](auto& current) {
</ins><span class="cx"> return *current->listener() == *listener && current->query() == query;
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -5299,7 +5299,7 @@
</span><span class="cx"> // candidate size.
</span><span class="cx"> value->adjustNodeSizes();
</span><span class="cx"> }
</span><del>- m_textAutoSizedNodes.removeIf([] (TextAutoSizingMap::KeyValuePairType& keyAndValue) {
</del><ins>+ m_textAutoSizedNodes.removeIf([](auto& keyAndValue) {
</ins><span class="cx"> return !keyAndValue.value->numNodes();
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/dom/Element.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -3194,7 +3194,7 @@
</span><span class="cx"> attrNode->detachFromElementWithValue(value);
</span><span class="cx">
</span><span class="cx"> auto& attrNodeList = *attrNodeListForElement(*this);
</span><del>- bool found = attrNodeList.removeFirstMatching([attrNode] (const RefPtr<Attr>& attribute) {
</del><ins>+ bool found = attrNodeList.removeFirstMatching([attrNode](auto& attribute) {
</ins><span class="cx"> return attribute->qualifiedName() == attrNode->qualifiedName();
</span><span class="cx"> });
</span><span class="cx"> ASSERT_UNUSED(found, found);
</span></span></pre></div>
<a id="trunkSourceWebCoredomMutationObservercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MutationObserver.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MutationObserver.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/dom/MutationObserver.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -244,7 +244,7 @@
</span><span class="cx"> Vector<RefPtr<MutationObserver>> observers;
</span><span class="cx"> copyToVector(activeMutationObservers(), observers);
</span><span class="cx"> activeMutationObservers().clear();
</span><del>- std::sort(observers.begin(), observers.end(), [](const RefPtr<MutationObserver>& lhs, const RefPtr<MutationObserver>& rhs) {
</del><ins>+ std::sort(observers.begin(), observers.end(), [](auto& lhs, auto& rhs) {
</ins><span class="cx"> return lhs->m_priority < rhs->m_priority;
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Node.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Node.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/dom/Node.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -2086,7 +2086,7 @@
</span><span class="cx"> if (!registry)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- registry->removeFirstMatching([registration] (const std::unique_ptr<MutationObserverRegistration>& current) {
</del><ins>+ registry->removeFirstMatching([registration](auto& current) {
</ins><span class="cx"> return current.get() == registration;
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlLinkIconCollectorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/LinkIconCollector.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/LinkIconCollector.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/html/LinkIconCollector.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -107,7 +107,7 @@
</span><span class="cx"> icons.append({ url, iconType, iconSize });
</span><span class="cx"> }
</span><span class="cx">
</span><del>- std::sort(icons.begin(), icons.end(), [](const LinkIconCollector::Icon& a, const LinkIconCollector::Icon& b) {
</del><ins>+ std::sort(icons.begin(), icons.end(), [](auto& a, auto& b) {
</ins><span class="cx"> return compareIcons(a, b) < 0;
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreinspectorInspectorIndexedDBAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -600,7 +600,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> RefPtr<RequestDatabaseNamesCallback> callback = WTFMove(requestCallback);
</span><del>- idbFactory->getAllDatabaseNames(*topOrigin, *openingOrigin, [callback](const Vector<String>& databaseNames) {
</del><ins>+ idbFactory->getAllDatabaseNames(*topOrigin, *openingOrigin, [callback](auto& databaseNames) {
</ins><span class="cx"> if (!callback->isActive())
</span><span class="cx"> return;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreloaderResourceLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/loader/ResourceLoader.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -253,7 +253,7 @@
</span><span class="cx"> if (auto* scheduledPairs = m_frame->page()->scheduledRunLoopPairs())
</span><span class="cx"> scheduleContext.scheduledPairs = *scheduledPairs;
</span><span class="cx"> #endif
</span><del>- DataURLDecoder::decode(url, scheduleContext, [protectedThis, url] (Optional<DataURLDecoder::Result> decodeResult) {
</del><ins>+ DataURLDecoder::decode(url, scheduleContext, [protectedThis, url](auto decodeResult) {
</ins><span class="cx"> if (protectedThis->reachedTerminalState())
</span><span class="cx"> return;
</span><span class="cx"> if (!decodeResult) {
</span></span></pre></div>
<a id="trunkSourceWebCorepageCaptionUserPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/CaptionUserPreferences.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/CaptionUserPreferences.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/page/CaptionUserPreferences.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -221,7 +221,7 @@
</span><span class="cx"> tracksForMenu.append(track);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- std::sort(tracksForMenu.begin(), tracksForMenu.end(), [](const RefPtr<TextTrack>& a, const RefPtr<TextTrack>& b) {
</del><ins>+ std::sort(tracksForMenu.begin(), tracksForMenu.end(), [](auto& a, auto& b) {
</ins><span class="cx"> return codePointCompare(trackDisplayName(a.get()), trackDisplayName(b.get())) < 0;
</span><span class="cx"> });
</span><span class="cx">
</span><span class="lines">@@ -256,7 +256,7 @@
</span><span class="cx"> tracksForMenu.append(track);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- std::sort(tracksForMenu.begin(), tracksForMenu.end(), [](const RefPtr<AudioTrack>& a, const RefPtr<AudioTrack>& b) {
</del><ins>+ std::sort(tracksForMenu.begin(), tracksForMenu.end(), [](auto& a, auto& b) {
</ins><span class="cx"> return codePointCompare(trackDisplayName(a.get()), trackDisplayName(b.get())) < 0;
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageCaptionUserPreferencesMediaAFcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -838,7 +838,7 @@
</span><span class="cx"> tracksForMenu.append(track);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- std::sort(tracksForMenu.begin(), tracksForMenu.end(), [](const RefPtr<AudioTrack>& a, const RefPtr<AudioTrack>& b) {
</del><ins>+ std::sort(tracksForMenu.begin(), tracksForMenu.end(), [](auto& a, auto& b) {
</ins><span class="cx"> return codePointCompare(trackDisplayName(a.get()), trackDisplayName(b.get())) < 0;
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorepageanimationAnimationControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/animation/AnimationController.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/animation/AnimationController.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/page/animation/AnimationController.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -107,8 +107,8 @@
</span><span class="cx"> return info.element == element;
</span><span class="cx"> });
</span><span class="cx">
</span><del>- m_elementChangesToDispatch.removeAllMatching([element] (const Ref<Element>& currElement) {
- return &currElement.get() == element;
</del><ins>+ m_elementChangesToDispatch.removeAllMatching([element](auto& currentElement) {
+ return currentElement.ptr() == element;
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> // Return false if we didn't do anything OR we are suspended (so we don't try to
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsFontCascadecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -250,7 +250,7 @@
</span><span class="cx">
</span><span class="cx"> void pruneUnreferencedEntriesFromFontCascadeCache()
</span><span class="cx"> {
</span><del>- fontCascadeCache().removeIf([](FontCascadeCache::KeyValuePairType& entry) {
</del><ins>+ fontCascadeCache().removeIf([](auto& entry) {
</ins><span class="cx"> return entry.value->fonts.get().hasOneRef();
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsFontCascadeFontscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/FontCascadeFonts.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/FontCascadeFonts.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/platform/graphics/FontCascadeFonts.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -454,7 +454,7 @@
</span><span class="cx"> // Mutable glyph pages may reference fallback fonts.
</span><span class="cx"> if (m_cachedPageZero.isMixedFont())
</span><span class="cx"> m_cachedPageZero = { };
</span><del>- m_cachedPages.removeIf([](decltype(m_cachedPages)::KeyValuePairType& keyAndValue) {
</del><ins>+ m_cachedPages.removeIf([](auto& keyAndValue) {
</ins><span class="cx"> return keyAndValue.value.isMixedFont();
</span><span class="cx"> });
</span><span class="cx"> m_systemFallbackFontSet.clear();
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsPathUtilitiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/PathUtilities.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/PathUtilities.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/platform/graphics/PathUtilities.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -134,7 +134,7 @@
</span><span class="cx"> intersectionPoints.append(graph.findOrCreateNode(intersectionPoint));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- std::sort(intersectionPoints.begin(), intersectionPoints.end(), [edgeA] (FloatPointGraph::Node* a, FloatPointGraph::Node* b) {
</del><ins>+ std::sort(intersectionPoints.begin(), intersectionPoints.end(), [edgeA](auto* a, auto* b) {
</ins><span class="cx"> return FloatPoint(*edgeA.first - *b).lengthSquared() > FloatPoint(*edgeA.first - *a).lengthSquared();
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicsavfoundationobjcMediaPlayerPrivateMediaStreamAVFObjCmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -531,14 +531,14 @@
</span><span class="cx"> MediaStreamTrackPrivateVector currentTracks = m_mediaStreamPrivate->tracks();
</span><span class="cx"> bool selectedVideoTrackChanged = false;
</span><span class="cx">
</span><del>- std::function<void(RefPtr<AudioTrackPrivateMediaStream>, int)> enableAudioTrack = [this](RefPtr<AudioTrackPrivateMediaStream> track, int index)
</del><ins>+ std::function<void(RefPtr<AudioTrackPrivateMediaStream>, int)> enableAudioTrack = [this](auto track, int index)
</ins><span class="cx"> {
</span><span class="cx"> track->setTrackIndex(index);
</span><span class="cx"> track->setEnabled(track->streamTrack()->enabled() && !track->streamTrack()->muted());
</span><span class="cx"> };
</span><span class="cx"> updateTracksOfType(m_audioTrackMap, RealtimeMediaSource::Audio, currentTracks, &AudioTrackPrivateMediaStream::create, m_player, &MediaPlayer::removeAudioTrack, &MediaPlayer::addAudioTrack, enableAudioTrack);
</span><span class="cx">
</span><del>- std::function<void(RefPtr<VideoTrackPrivateMediaStream>, int)> enableVideoTrack = [this, &selectedVideoTrackChanged](RefPtr<VideoTrackPrivateMediaStream> track, int index)
</del><ins>+ std::function<void(RefPtr<VideoTrackPrivateMediaStream>, int)> enableVideoTrack = [this, &selectedVideoTrackChanged](auto track, int index)
</ins><span class="cx"> {
</span><span class="cx"> bool wasSelected = track->selected();
</span><span class="cx"> track->setTrackIndex(index);
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicstexmapTextureMapperGLcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -88,8 +88,8 @@
</span><span class="cx"> ~SharedGLData()
</span><span class="cx"> {
</span><span class="cx"> ASSERT(std::any_of(contextDataMap().begin(), contextDataMap().end(),
</span><del>- [this](GLContextDataMap::KeyValuePairType& entry) { return entry.value == this; }));
- contextDataMap().removeIf([this] (GLContextDataMap::KeyValuePairType& entry) { return entry.value == this; });
</del><ins>+ [this](auto& entry) { return entry.value == this; }));
+ contextDataMap().removeIf([this](auto& entry) { return entry.value == this; });
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformmacHIDGamepadcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/mac/HIDGamepad.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/mac/HIDGamepad.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/platform/mac/HIDGamepad.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -74,7 +74,7 @@
</span><span class="cx"> initElementsFromArray(elements.get());
</span><span class="cx">
</span><span class="cx"> // Buttons are specified to appear highest priority first in the array.
</span><del>- std::sort(m_buttons.begin(), m_buttons.end(), [](const std::unique_ptr<HIDGamepadButton>& a, const std::unique_ptr<HIDGamepadButton>& b) {
</del><ins>+ std::sort(m_buttons.begin(), m_buttons.end(), [](auto& a, auto& b) {
</ins><span class="cx"> return a->priority < b->priority;
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoresvgSVGToOTFFontConversioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -754,7 +754,7 @@
</span><span class="cx"> }
</span><span class="cx"> if (ligaturePairs.size() > std::numeric_limits<uint16_t>::max())
</span><span class="cx"> ligaturePairs.clear();
</span><del>- std::sort(ligaturePairs.begin(), ligaturePairs.end(), [](const LigaturePair& lhs, const LigaturePair& rhs) {
</del><ins>+ std::sort(ligaturePairs.begin(), ligaturePairs.end(), [](auto& lhs, auto& rhs) {
</ins><span class="cx"> return lhs.first[0] < rhs.first[0];
</span><span class="cx"> });
</span><span class="cx"> Vector<size_t> overlappingFirstGlyphSegmentLengths;
</span><span class="lines">@@ -1078,7 +1078,7 @@
</span><span class="cx">
</span><span class="cx"> size_t SVGToOTFFontConverter::finishAppendingKERNSubtable(Vector<KerningData> kerningData, uint16_t coverage)
</span><span class="cx"> {
</span><del>- std::sort(kerningData.begin(), kerningData.end(), [](const KerningData& a, const KerningData& b) {
</del><ins>+ std::sort(kerningData.begin(), kerningData.end(), [](auto& a, auto& b) {
</ins><span class="cx"> return a.glyph1 < b.glyph1 || (a.glyph1 == b.glyph1 && a.glyph2 < b.glyph2);
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -1,3 +1,54 @@
</span><ins>+2016-05-24 Chris Dumez <cdumez@apple.com>
+
+ Use auto for some of our lambda function parameters
+ https://bugs.webkit.org/show_bug.cgi?id=158001
+
+ Reviewed by Darin Adler.
+
+ Use auto for some of our lambda function parameters now that we build with c++14.
+
+ * DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
+ (WebKit::WebIDBConnectionToClient::didGetRecord):
+ * NetworkProcess/NetworkConnectionToWebProcess.cpp:
+ (WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles):
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::fetchDiskCacheEntries):
+ (WebKit::NetworkProcess::fetchWebsiteData):
+ (WebKit::clearDiskCacheEntries):
+ * NetworkProcess/NetworkResourceLoader.cpp:
+ (WebKit::NetworkResourceLoader::retrieveCacheEntry):
+ (WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
+ * NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
+ (WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):
+ * NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
+ (WebKit::NetworkCache::SpeculativeLoadManager::registerLoad):
+ (WebKit::NetworkCache::SpeculativeLoadManager::retrieveEntryFromStorage):
+ (WebKit::NetworkCache::SpeculativeLoadManager::revalidateEntry):
+ (WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):
+ (WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry):
+ * NetworkProcess/cache/NetworkCacheStorage.cpp:
+ (WebKit::NetworkCache::Storage::removeFromPendingWriteOperations):
+ * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+ (-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
+ (-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
+ * Shared/API/Cocoa/_WKRemoteObjectInterface.mm:
+ (-[_WKRemoteObjectInterface debugDescription]):
+ * UIProcess/API/C/WKApplicationCacheManager.cpp:
+ (WKApplicationCacheManagerGetApplicationCacheOrigins):
+ * UIProcess/API/C/WKKeyValueStorageManager.cpp:
+ (WKKeyValueStorageManagerGetKeyValueStorageOrigins):
+ (WKKeyValueStorageManagerGetStorageDetailsByOrigin):
+ * UIProcess/API/C/WKResourceCacheManager.cpp:
+ (WKResourceCacheManagerGetCacheOrigins):
+ * UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
+ (-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):
+ * UIProcess/UserContent/WebUserContentControllerProxy.cpp:
+ (WebKit::WebUserContentControllerProxy::removeAllUserScripts):
+ (WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
+ (WebKit::WebUserContentControllerProxy::removeAllUserMessageHandlers):
+ * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
+ (WebKit::PlatformCALayerRemote::removeAnimationForKey):
+
</ins><span class="cx"> 2016-05-23 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Assertion failure for Reflect.get with Proxy and primitive value as explicit receiver
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkConnectionToWebProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -317,7 +317,7 @@
</span><span class="cx"> for (auto& file : fileReferences)
</span><span class="cx"> file->prepareForFileAccess();
</span><span class="cx">
</span><del>- NetworkBlobRegistry::singleton().writeBlobsToTemporaryFiles(blobURLs, [this, protector, requestIdentifier, fileReferences](const Vector<String>& fileNames) {
</del><ins>+ NetworkBlobRegistry::singleton().writeBlobsToTemporaryFiles(blobURLs, [this, protector, requestIdentifier, fileReferences](auto& fileNames) {
</ins><span class="cx"> for (auto& file : fileReferences)
</span><span class="cx"> file->revokeFileAccess();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkProcesscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -314,7 +314,7 @@
</span><span class="cx"> if (NetworkCache::singleton().isEnabled()) {
</span><span class="cx"> auto* originsAndSizes = new HashMap<RefPtr<SecurityOrigin>, uint64_t>();
</span><span class="cx">
</span><del>- NetworkCache::singleton().traverse([fetchOptions, completionHandler, originsAndSizes](const NetworkCache::Cache::TraversalEntry *traversalEntry) {
</del><ins>+ NetworkCache::singleton().traverse([fetchOptions, completionHandler, originsAndSizes](auto* traversalEntry) {
</ins><span class="cx"> if (!traversalEntry) {
</span><span class="cx"> Vector<WebsiteData::Entry> entries;
</span><span class="cx">
</span><span class="lines">@@ -379,7 +379,7 @@
</span><span class="cx"> WebsiteData m_websiteData;
</span><span class="cx"> };
</span><span class="cx">
</span><del>- RefPtr<CallbackAggregator> callbackAggregator = adoptRef(new CallbackAggregator([this, callbackID](WebsiteData websiteData) {
</del><ins>+ RefPtr<CallbackAggregator> callbackAggregator = adoptRef(new CallbackAggregator([this, callbackID] (WebsiteData websiteData) {
</ins><span class="cx"> parentProcessConnection()->send(Messages::NetworkProcessProxy::DidFetchWebsiteData(callbackID, websiteData), 0);
</span><span class="cx"> }));
</span><span class="cx">
</span><span class="lines">@@ -389,7 +389,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (websiteDataTypes.contains(WebsiteDataType::DiskCache)) {
</span><del>- fetchDiskCacheEntries(sessionID, fetchOptions, [callbackAggregator](Vector<WebsiteData::Entry> entries) {
</del><ins>+ fetchDiskCacheEntries(sessionID, fetchOptions, [callbackAggregator](auto entries) {
</ins><span class="cx"> callbackAggregator->m_websiteData.entries.appendVector(entries);
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="lines">@@ -432,8 +432,7 @@
</span><span class="cx">
</span><span class="cx"> auto* cacheKeysToDelete = new Vector<NetworkCache::Key>;
</span><span class="cx">
</span><del>- NetworkCache::singleton().traverse([completionHandler, originsToDelete, cacheKeysToDelete](const NetworkCache::Cache::TraversalEntry *traversalEntry) {
-
</del><ins>+ NetworkCache::singleton().traverse([completionHandler, originsToDelete, cacheKeysToDelete](auto* traversalEntry) {
</ins><span class="cx"> if (traversalEntry) {
</span><span class="cx"> if (originsToDelete->contains(SecurityOrigin::create(traversalEntry->entry.response().url())))
</span><span class="cx"> cacheKeysToDelete->append(traversalEntry->entry.key());
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcessNetworkResourceLoadercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -165,7 +165,7 @@
</span><span class="cx"> ASSERT(canUseCache(request));
</span><span class="cx">
</span><span class="cx"> RefPtr<NetworkResourceLoader> loader(this);
</span><del>- NetworkCache::singleton().retrieve(request, { m_parameters.webPageID, m_parameters.webFrameID }, [loader, request](std::unique_ptr<NetworkCache::Entry> entry) {
</del><ins>+ NetworkCache::singleton().retrieve(request, { m_parameters.webPageID, m_parameters.webFrameID }, [loader, request](auto entry) {
</ins><span class="cx"> if (loader->hasOneRef()) {
</span><span class="cx"> // The loader has been aborted and is only held alive by this lambda.
</span><span class="cx"> return;
</span><span class="lines">@@ -516,7 +516,7 @@
</span><span class="cx"> // Keep the connection alive.
</span><span class="cx"> RefPtr<NetworkConnectionToWebProcess> connection(&connectionToWebProcess());
</span><span class="cx"> RefPtr<NetworkResourceLoader> loader(this);
</span><del>- NetworkCache::singleton().store(m_networkLoad->currentRequest(), m_response, WTFMove(m_bufferedDataForCache), [loader, connection](NetworkCache::MappedBody& mappedBody) {
</del><ins>+ NetworkCache::singleton().store(m_networkLoad->currentRequest(), m_response, WTFMove(m_bufferedDataForCache), [loader, connection](auto& mappedBody) {
</ins><span class="cx"> #if ENABLE(SHAREABLE_RESOURCE)
</span><span class="cx"> if (mappedBody.shareableResourceHandle.isNull())
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesscacheNetworkCacheSpeculativeLoadcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -105,7 +105,7 @@
</span><span class="cx"> void SpeculativeLoad::didFinishLoading(double finishTime)
</span><span class="cx"> {
</span><span class="cx"> if (!m_cacheEntryForValidation && m_bufferedDataForCache)
</span><del>- m_cacheEntryForValidation = NetworkCache::singleton().store(m_originalRequest, m_response, WTFMove(m_bufferedDataForCache), [](NetworkCache::MappedBody& mappedBody) { });
</del><ins>+ m_cacheEntryForValidation = NetworkCache::singleton().store(m_originalRequest, m_response, WTFMove(m_bufferedDataForCache), [](auto& mappedBody) { });
</ins><span class="cx">
</span><span class="cx"> didComplete();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesscacheNetworkCacheSpeculativeLoadManagercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -409,7 +409,7 @@
</span><span class="cx">
</span><span class="cx"> void SpeculativeLoadManager::retrieveEntryFromStorage(const Key& key, const RetrieveCompletionHandler& completionHandler)
</span><span class="cx"> {
</span><del>- m_storage.retrieve(key, static_cast<unsigned>(ResourceLoadPriority::Medium), [completionHandler](std::unique_ptr<Storage::Record> record) {
</del><ins>+ m_storage.retrieve(key, static_cast<unsigned>(ResourceLoadPriority::Medium), [completionHandler](auto record) {
</ins><span class="cx"> if (!record) {
</span><span class="cx"> completionHandler(nullptr);
</span><span class="cx"> return false;
</span><span class="lines">@@ -537,7 +537,7 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(storageKey.type() == "resource");
</span><span class="cx"> auto subresourcesStorageKey = makeSubresourcesKey(storageKey);
</span><del>- m_storage.retrieve(subresourcesStorageKey, static_cast<unsigned>(ResourceLoadPriority::Medium), [completionHandler](std::unique_ptr<Storage::Record> record) {
</del><ins>+ m_storage.retrieve(subresourcesStorageKey, static_cast<unsigned>(ResourceLoadPriority::Medium), [completionHandler](auto record) {
</ins><span class="cx"> if (!record) {
</span><span class="cx"> completionHandler(nullptr);
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesscacheNetworkCacheStoragecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -526,7 +526,7 @@
</span><span class="cx"> void Storage::removeFromPendingWriteOperations(const Key& key)
</span><span class="cx"> {
</span><span class="cx"> while (true) {
</span><del>- auto found = m_pendingWriteOperations.findIf([&key](const std::unique_ptr<WriteOperation>& operation) {
</del><ins>+ auto found = m_pendingWriteOperations.findIf([&key](auto& operation) {
</ins><span class="cx"> return operation->record.key == key;
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2NetworkProcesscocoaNetworkSessionCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -123,7 +123,7 @@
</span><span class="cx"> auto storedCredentials = _withCredentials ? WebCore::StoredCredentials::AllowStoredCredentials : WebCore::StoredCredentials::DoNotAllowStoredCredentials;
</span><span class="cx"> if (auto* networkDataTask = _session->dataTaskForIdentifier(task.taskIdentifier, storedCredentials)) {
</span><span class="cx"> auto completionHandlerCopy = Block_copy(completionHandler);
</span><del>- networkDataTask->willPerformHTTPRedirection(response, request, [completionHandlerCopy, taskIdentifier](const WebCore::ResourceRequest& request) {
</del><ins>+ networkDataTask->willPerformHTTPRedirection(response, request, [completionHandlerCopy, taskIdentifier](auto& request) {
</ins><span class="cx"> LOG(NetworkSession, "%llu willPerformHTTPRedirection completionHandler (%s)", taskIdentifier, request.url().string().utf8().data());
</span><span class="cx"> completionHandlerCopy(request.nsURLRequest(WebCore::UpdateHTTPBody));
</span><span class="cx"> Block_release(completionHandlerCopy);
</span><span class="lines">@@ -142,7 +142,7 @@
</span><span class="cx"> auto storedCredentials = _withCredentials ? WebCore::StoredCredentials::AllowStoredCredentials : WebCore::StoredCredentials::DoNotAllowStoredCredentials;
</span><span class="cx"> if (auto* networkDataTask = _session->dataTaskForIdentifier(taskIdentifier, storedCredentials)) {
</span><span class="cx"> auto completionHandlerCopy = Block_copy(completionHandler);
</span><del>- networkDataTask->willPerformHTTPRedirection(WebCore::synthesizeRedirectResponseIfNecessary([task currentRequest], request, nil), request, [completionHandlerCopy, taskIdentifier](const WebCore::ResourceRequest& request) {
</del><ins>+ networkDataTask->willPerformHTTPRedirection(WebCore::synthesizeRedirectResponseIfNecessary([task currentRequest], request, nil), request, [completionHandlerCopy, taskIdentifier](auto& request) {
</ins><span class="cx"> LOG(NetworkSession, "%llu _schemeUpgraded completionHandler (%s)", taskIdentifier, request.url().string().utf8().data());
</span><span class="cx"> completionHandlerCopy(request.nsURLRequest(WebCore::UpdateHTTPBody));
</span><span class="cx"> Block_release(completionHandlerCopy);
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedAPICocoa_WKRemoteObjectInterfacemm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -210,11 +210,11 @@
</span><span class="cx"> {
</span><span class="cx"> auto result = adoptNS([[NSMutableString alloc] initWithFormat:@"<%@: %p; protocol = \"%@\"; identifier = \"%@\"\n", NSStringFromClass(self.class), self, _identifier.get(), NSStringFromProtocol(_protocol)]);
</span><span class="cx">
</span><del>- auto descriptionForClasses = [](const Vector<HashSet<Class>>& allowedClasses) {
</del><ins>+ auto descriptionForClasses = [](auto& allowedClasses) {
</ins><span class="cx"> auto result = adoptNS([[NSMutableString alloc] initWithString:@"["]);
</span><span class="cx"> bool needsComma = false;
</span><span class="cx">
</span><del>- auto descriptionForArgument = [](const HashSet<Class>& allowedArgumentClasses) {
</del><ins>+ auto descriptionForArgument = [](auto& allowedArgumentClasses) {
</ins><span class="cx"> auto result = adoptNS([[NSMutableString alloc] initWithString:@"{"]);
</span><span class="cx">
</span><span class="cx"> Vector<Class> orderedArgumentClasses;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKApplicationCacheManagercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKApplicationCacheManager.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKApplicationCacheManager.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKApplicationCacheManager.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx"> void WKApplicationCacheManagerGetApplicationCacheOrigins(WKApplicationCacheManagerRef applicationCacheManager, void* context, WKApplicationCacheManagerGetApplicationCacheOriginsFunction callback)
</span><span class="cx"> {
</span><span class="cx"> auto& websiteDataStore = toImpl(reinterpret_cast<WKWebsiteDataStoreRef>(applicationCacheManager))->websiteDataStore();
</span><del>- websiteDataStore.fetchData(WebsiteDataType::OfflineWebApplicationCache, { }, [context, callback](Vector<WebsiteDataRecord> dataRecords) {
</del><ins>+ websiteDataStore.fetchData(WebsiteDataType::OfflineWebApplicationCache, { }, [context, callback](auto dataRecords) {
</ins><span class="cx"> Vector<RefPtr<API::Object>> securityOrigins;
</span><span class="cx"> for (const auto& dataRecord : dataRecords) {
</span><span class="cx"> for (const auto& origin : dataRecord.origins)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKKeyValueStorageManagercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKKeyValueStorageManager.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKKeyValueStorageManager.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKKeyValueStorageManager.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -69,7 +69,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- storageManager->getLocalStorageOrigins([context, callback](HashSet<RefPtr<WebCore::SecurityOrigin>>&& securityOrigins) {
</del><ins>+ storageManager->getLocalStorageOrigins([context, callback](auto&& securityOrigins) {
</ins><span class="cx"> Vector<RefPtr<API::Object>> webSecurityOrigins;
</span><span class="cx"> webSecurityOrigins.reserveInitialCapacity(securityOrigins.size());
</span><span class="cx"> for (auto& origin : securityOrigins)
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- storageManager->getLocalStorageOriginDetails([context, callback](Vector<LocalStorageDatabaseTracker::OriginDetails> storageDetails) {
</del><ins>+ storageManager->getLocalStorageOriginDetails([context, callback](auto storageDetails) {
</ins><span class="cx"> HashMap<String, RefPtr<API::Object>> detailsMap;
</span><span class="cx"> Vector<RefPtr<API::Object>> result;
</span><span class="cx"> result.reserveInitialCapacity(storageDetails.size());
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKResourceCacheManagercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKResourceCacheManager.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKResourceCacheManager.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKResourceCacheManager.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -52,7 +52,7 @@
</span><span class="cx"> void WKResourceCacheManagerGetCacheOrigins(WKResourceCacheManagerRef cacheManager, void* context, WKResourceCacheManagerGetCacheOriginsFunction callback)
</span><span class="cx"> {
</span><span class="cx"> auto& websiteDataStore = toImpl(reinterpret_cast<WKWebsiteDataStoreRef>(cacheManager))->websiteDataStore();
</span><del>- websiteDataStore.fetchData(toWebsiteDataTypes(WKResourceCachesToClearAll), { }, [context, callback](Vector<WebsiteDataRecord> dataRecords) {
</del><ins>+ websiteDataStore.fetchData(toWebsiteDataTypes(WKResourceCachesToClearAll), { }, [context, callback](auto dataRecords) {
</ins><span class="cx"> Vector<RefPtr<API::Object>> securityOrigins;
</span><span class="cx"> for (const auto& dataRecord : dataRecords) {
</span><span class="cx"> for (const auto& origin : dataRecord.origins)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICocoaWKWebsiteDataStoremm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStore.mm 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -153,7 +153,7 @@
</span><span class="cx"> if (options & _WKWebsiteDataStoreFetchOptionComputeSizes)
</span><span class="cx"> fetchOptions |= WebKit::WebsiteDataFetchOption::ComputeSizes;
</span><span class="cx">
</span><del>- _websiteDataStore->websiteDataStore().fetchData(WebKit::toWebsiteDataTypes(dataTypes), fetchOptions, [completionHandlerCopy](Vector<WebKit::WebsiteDataRecord> websiteDataRecords) {
</del><ins>+ _websiteDataStore->websiteDataStore().fetchData(WebKit::toWebsiteDataTypes(dataTypes), fetchOptions, [completionHandlerCopy](auto websiteDataRecords) {
</ins><span class="cx"> Vector<RefPtr<API::Object>> elements;
</span><span class="cx"> elements.reserveInitialCapacity(websiteDataRecords.size());
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessUserContentWebUserContentControllerProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -189,7 +189,7 @@
</span><span class="cx"> for (WebProcessProxy* process : m_processes)
</span><span class="cx"> process->connection()->send(Messages::WebUserContentController::RemoveAllUserScripts({ world.identifier() }), m_identifier);
</span><span class="cx">
</span><del>- unsigned userScriptsRemoved = m_userScripts->removeAllOfTypeMatching<API::UserScript>([&] (const RefPtr<API::UserScript>& userScript) -> bool {
</del><ins>+ unsigned userScriptsRemoved = m_userScripts->removeAllOfTypeMatching<API::UserScript>([&](const auto& userScript) {
</ins><span class="cx"> return &userScript->userContentWorld() == &world;
</span><span class="cx"> });
</span><span class="cx">
</span><span class="lines">@@ -244,7 +244,7 @@
</span><span class="cx"> for (WebProcessProxy* process : m_processes)
</span><span class="cx"> process->connection()->send(Messages::WebUserContentController::RemoveAllUserStyleSheets({ world.identifier() }), m_identifier);
</span><span class="cx">
</span><del>- unsigned userStyleSheetsRemoved = m_userStyleSheets->removeAllOfTypeMatching<API::UserStyleSheet>([&] (const RefPtr<API::UserStyleSheet>& userStyleSheet) -> bool {
</del><ins>+ unsigned userStyleSheetsRemoved = m_userStyleSheets->removeAllOfTypeMatching<API::UserStyleSheet>([&](const auto& userStyleSheet) {
</ins><span class="cx"> return &userStyleSheet->userContentWorld() == &world;
</span><span class="cx"> });
</span><span class="cx">
</span><span class="lines">@@ -310,7 +310,7 @@
</span><span class="cx"> process->connection()->send(Messages::WebUserContentController::RemoveAllUserScriptMessageHandlers({ world.identifier() }), m_identifier);
</span><span class="cx">
</span><span class="cx"> unsigned numberRemoved = 0;
</span><del>- m_scriptMessageHandlers.removeIf([&](HashMap<uint64_t, RefPtr<WebScriptMessageHandler>>::KeyValuePairType& entry) {
</del><ins>+ m_scriptMessageHandlers.removeIf([&](auto& entry) {
</ins><span class="cx"> if (&entry.value->userContentWorld() == &world) {
</span><span class="cx"> ++numberRemoved;
</span><span class="cx"> return true;
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPagemacPlatformCALayerRemotecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -350,7 +350,7 @@
</span><span class="cx"> void PlatformCALayerRemote::removeAnimationForKey(const String& key)
</span><span class="cx"> {
</span><span class="cx"> if (m_animations.remove(key)) {
</span><del>- m_properties.addedAnimations.removeFirstMatching([&key] (const std::pair<String, PlatformCAAnimationRemote::Properties>& pair) {
</del><ins>+ m_properties.addedAnimations.removeFirstMatching([&key](auto& pair) {
</ins><span class="cx"> return pair.first == key;
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Tools/ChangeLog 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-05-24 Chris Dumez <cdumez@apple.com>
+
+ Use auto for some of our lambda function parameters
+ https://bugs.webkit.org/show_bug.cgi?id=158001
+
+ Reviewed by Darin Adler.
+
+ Use auto for some of our lambda function parameters now that we build with c++14.
+
+ * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+ (WTR::InjectedBundle::willDestroyPage):
+
</ins><span class="cx"> 2016-05-23 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> check-webkit-style gets flags std::literals::chrono_literals as bad naming.
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckerscpppy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -2433,6 +2433,7 @@
</span><span class="cx"> elif (search(r'\)\s*(((const|override)\s*)*\s*)?{\s*$', line)
</span><span class="cx"> and line.count('(') == line.count(')')
</span><span class="cx"> and not search(r'(\s*(if|for|while|switch|NS_ENUM|@synchronized)|} @catch)\b', line)
</span><ins>+ and line.find("](") < 0
</ins><span class="cx"> and not match(r'\s+[A-Z_][A-Z_0-9]+\b', line)):
</span><span class="cx"> error(line_number, 'whitespace/braces', 4,
</span><span class="cx"> 'Place brace on its own line for function definitions.')
</span></span></pre></div>
<a id="trunkToolsScriptswebkitpystylecheckerscpp_unittestpy"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -1769,6 +1769,10 @@
</span><span class="cx"> '}\n',
</span><span class="cx"> '')
</span><span class="cx"> self.assert_multi_line_lint(
</span><ins>+ '[]() {\n'
+ '}\n',
+ '')
+ self.assert_multi_line_lint(
</ins><span class="cx"> 'if (condition\n'
</span><span class="cx"> ' && condition2\n'
</span><span class="cx"> ' && condition3) {\n'
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (201332 => 201333)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2016-05-24 16:46:44 UTC (rev 201332)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2016-05-24 16:50:26 UTC (rev 201333)
</span><span class="lines">@@ -109,7 +109,7 @@
</span><span class="cx">
</span><span class="cx"> void InjectedBundle::willDestroyPage(WKBundlePageRef page)
</span><span class="cx"> {
</span><del>- m_pages.removeFirstMatching([page] (const std::unique_ptr<InjectedBundlePage>& current) {
</del><ins>+ m_pages.removeFirstMatching([page](auto& current) {
</ins><span class="cx"> return current->page() == page;
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>