<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201355] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201355">201355</a></dd>
<dt>Author</dt> <dd>adachan@apple.com</dd>
<dt>Date</dt> <dd>2016-05-24 14:48:20 -0700 (Tue, 24 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Only set overflow:hidden on -webkit-media-controls when the placeholder is showing.
https://bugs.webkit.org/show_bug.cgi?id=157975
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/mac/controls-panel-not-clipped-out.html
overflow:hidden was added to clip out content contained in -webkit-media-controls
that sticks out of the bounds of that container when the inlinePlaybackPlaceholder
is showing. However, that style also clips out things that we want to show when the
inlinePlaybackPlaceholder is not showing. For example, the volume slider or the
controls panel when the video element's height is too short.
To fix that, we only set overflow:hidden on -webkit-media-controls when the
inlinePlaybackPlaceholder is visible.
* Modules/mediacontrols/mediaControlsApple.css:
(::-webkit-media-controls):
(::-webkit-media-controls.placeholder-showing):
Set overflow:hidden only when the placeholder is showing.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handlePresentationModeChange):
Add the placeholderShowing class to -webkit-media-controls only when the
inlinePlaybackPlaceholder is not hidden.
LayoutTests:
This is a Mac only test. The media controls panel should still be visible
even if the media element's height is very short.
* TestExpectations:
* media/mac/controls-panel-not-clipped-out-expected.html: Added.
* media/mac/controls-panel-not-clipped-out.html: Added.
* platform/mac/TestExpectations:
* platform/mac/media/media-document-audio-repaint-expected.txt:
* platform/mac/media/video-zoom-controls-expected.txt:
Rebaseline tests.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacTestExpectations">trunk/LayoutTests/platform/mac/TestExpectations</a></li>
<li><a href="#trunkLayoutTestsplatformmacmediamediadocumentaudiorepaintexpectedtxt">trunk/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacmediavideozoomcontrolsexpectedtxt">trunk/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsApplecss">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css</a></li>
<li><a href="#trunkSourceWebCoreModulesmediacontrolsmediaControlsApplejs">trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li>trunk/LayoutTests/media/mac/</li>
<li><a href="#trunkLayoutTestsmediamaccontrolspanelnotclippedoutexpectedhtml">trunk/LayoutTests/media/mac/controls-panel-not-clipped-out-expected.html</a></li>
<li><a href="#trunkLayoutTestsmediamaccontrolspanelnotclippedouthtml">trunk/LayoutTests/media/mac/controls-panel-not-clipped-out.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (201354 => 201355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-05-24 21:38:50 UTC (rev 201354)
+++ trunk/LayoutTests/ChangeLog 2016-05-24 21:48:20 UTC (rev 201355)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-05-24 Ada Chan <adachan@apple.com>
+
+ Only set overflow:hidden on -webkit-media-controls when the placeholder is showing.
+ https://bugs.webkit.org/show_bug.cgi?id=157975
+
+ Reviewed by Eric Carlson.
+
+ This is a Mac only test. The media controls panel should still be visible
+ even if the media element's height is very short.
+
+ * TestExpectations:
+ * media/mac/controls-panel-not-clipped-out-expected.html: Added.
+ * media/mac/controls-panel-not-clipped-out.html: Added.
+ * platform/mac/TestExpectations:
+
+ * platform/mac/media/media-document-audio-repaint-expected.txt:
+ * platform/mac/media/video-zoom-controls-expected.txt:
+ Rebaseline tests.
+
</ins><span class="cx"> 2016-05-24 Adam Bergkvist <adam.bergkvist@ericsson.com>
</span><span class="cx">
</span><span class="cx"> WebRTC: RTCIceCandidate: Make attributes readonly (and update constructor arg)
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (201354 => 201355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations 2016-05-24 21:38:50 UTC (rev 201354)
+++ trunk/LayoutTests/TestExpectations 2016-05-24 21:48:20 UTC (rev 201355)
</span><span class="lines">@@ -21,6 +21,7 @@
</span><span class="cx"> fast/events/ios [ Skip ]
</span><span class="cx"> fast/events/touch/ios [ Skip ]
</span><span class="cx"> fast/scrolling/ios [ Skip ]
</span><ins>+media/mac [ Skip ]
</ins><span class="cx">
</span><span class="cx"> fast/forms/attributed-strings.html [ Skip ]
</span><span class="cx"> fast/scrolling/latching [ Skip ]
</span></span></pre></div>
<a id="trunkLayoutTestsmediamaccontrolspanelnotclippedoutexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/mac/controls-panel-not-clipped-out-expected.html (0 => 201355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/mac/controls-panel-not-clipped-out-expected.html (rev 0)
+++ trunk/LayoutTests/media/mac/controls-panel-not-clipped-out-expected.html 2016-05-24 21:48:20 UTC (rev 201355)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+<div style="position: relative; height: 100px; width: 200px">
+ <audio controls style="height: 60px; width: 200px; position: absolute; bottom: 0;"></audio>
+</div>
</ins></span></pre></div>
<a id="trunkLayoutTestsmediamaccontrolspanelnotclippedouthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/media/mac/controls-panel-not-clipped-out.html (0 => 201355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/media/mac/controls-panel-not-clipped-out.html (rev 0)
+++ trunk/LayoutTests/media/mac/controls-panel-not-clipped-out.html 2016-05-24 21:48:20 UTC (rev 201355)
</span><span class="lines">@@ -0,0 +1,3 @@
</span><ins>+<div style="position: relative; height: 100px; width: 200px">
+ <audio controls style="height: 1px; width: 200px; position: absolute; bottom: 0;"></audio>
+</div>
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/TestExpectations (201354 => 201355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/TestExpectations 2016-05-24 21:38:50 UTC (rev 201354)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2016-05-24 21:48:20 UTC (rev 201355)
</span><span class="lines">@@ -10,6 +10,7 @@
</span><span class="cx"> displaylists [ Pass ]
</span><span class="cx"> editing/mac [ Pass ]
</span><span class="cx"> fast/scrolling/latching [ Pass ]
</span><ins>+media/mac [ Pass ]
</ins><span class="cx">
</span><span class="cx"> fast/forms/search/search-padding-cancel-results-buttons.html [ Pass ]
</span><span class="cx"> fast/forms/search/search-results-hidden-crash.html [ Pass ]
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacmediamediadocumentaudiorepaintexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt (201354 => 201355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt 2016-05-24 21:38:50 UTC (rev 201354)
+++ trunk/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt 2016-05-24 21:48:20 UTC (rev 201355)
</span><span class="lines">@@ -21,13 +21,38 @@
</span><span class="cx"> RenderVideo {VIDEO} at (40,164) size 300x2
</span><span class="cx"> layer at (40,165) size 300x1
</span><span class="cx"> RenderFlexibleBox {DIV} at (0,0) size 300x1
</span><del>- layer at (40,121) size 300x45 backgroundClip at (40,165) size 300x1 clip at (40,165) size 300x1
</del><ins>+ layer at (40,121) size 300x45
</ins><span class="cx"> RenderFlexibleBox {DIV} at (0,-44) size 300x45
</span><del>- layer at (40,121) size 300x45 backgroundClip at (40,165) size 300x1 clip at (40,165) size 300x1 isolatesBlending
</del><ins>+ layer at (40,121) size 300x45 isolatesBlending
</ins><span class="cx"> RenderBlock (positioned) {DIV} at (0,0) size 300x45
</span><del>- layer at (40,121) size 300x45 backgroundClip at (40,165) size 300x1 clip at (40,165) size 300x1
</del><ins>+ layer at (40,121) size 300x45
</ins><span class="cx"> RenderBlock (positioned) {DIV} at (0,0) size 300x45 [bgcolor=#1E1E1E73]
</span><del>- layer at (40,121) size 300x45 backgroundClip at (40,165) size 300x1 clip at (40,165) size 300x1 blendMode: lighten
</del><ins>+ layer at (40,121) size 300x45 blendMode: lighten
</ins><span class="cx"> RenderBlock (positioned) {DIV} at (0,0) size 300x45 [bgcolor=#292929]
</span><del>- layer at (318,141) size 14x25 backgroundClip at (40,165) size 300x1 clip at (40,165) size 300x1
</del><ins>+ layer at (48,146) size 12x15 blendMode: plus-lighter
+ RenderButton {BUTTON} at (8,25) size 12x15 [color=#FFFFFF]
+ layer at (76,145) size 16x15 blendMode: plus-lighter
+ RenderButton {BUTTON} at (36,24) size 16x16 [color=#FFFFFF]
+ layer at (100,145) size 210x17
+ RenderFlexibleBox {DIV} at (60,24) size 210x17
+ layer at (108,146) size 32x13 blendMode: plus-lighter
+ RenderFlexibleBox {DIV} at (8,2) size 32x13 [color=#FFFFFF]
+ RenderBlock (anonymous) at (2,0) size 30x13
+ RenderText {#text} at (0,0) size 30x13
+ text run at (0,0) width 30: "00:00"
+ layer at (150,145) size 105x17
+ RenderFlexibleBox {DIV} at (50,0) size 105x17
+ layer at (150,145) size 105x17 blendMode: plus-lighter
+ RenderSlider {INPUT} at (0,0) size 105x17 [color=#909090]
+ RenderFlexibleBox {DIV} at (0,0) size 105x17
+ RenderBlock {DIV} at (0,1) size 105x15
+ RenderBlock {DIV} at (50,0) size 4x15
+ layer at (265,146) size 37x13 blendMode: plus-lighter
+ RenderFlexibleBox {DIV} at (165,2) size 37x13 [color=#FFFFFF]
+ RenderBlock (anonymous) at (0,0) size 35x13
+ RenderText {#text} at (0,0) size 35x13
+ text run at (0,0) width 35: "-00:00"
+ layer at (318,141) size 14x25
</ins><span class="cx"> RenderFlexibleBox {DIV} at (278,20) size 14x25
</span><ins>+ layer at (318,146) size 14x15 blendMode: plus-lighter
+ RenderButton {BUTTON} at (0,5) size 14x15 [color=#FFFFFF]
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformmacmediavideozoomcontrolsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt (201354 => 201355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt 2016-05-24 21:38:50 UTC (rev 201354)
+++ trunk/LayoutTests/platform/mac/media/video-zoom-controls-expected.txt 2016-05-24 21:48:20 UTC (rev 201355)
</span><span class="lines">@@ -12,17 +12,17 @@
</span><span class="cx"> RenderFlexibleBox {DIV} at (0,0) size 240x180
</span><span class="cx"> layer at (57,198) size 240x67
</span><span class="cx"> RenderFlexibleBox {DIV} at (0,112) size 240x68
</span><del>-layer at (57,198) size 240x68 backgroundClip at (57,85) size 240x180 clip at (57,85) size 240x180 isolatesBlending
</del><ins>+layer at (57,198) size 240x68 isolatesBlending
</ins><span class="cx"> RenderBlock (positioned) {DIV} at (0,0) size 240x68
</span><del>-layer at (57,198) size 240x68 backgroundClip at (57,85) size 240x180 clip at (57,85) size 240x180
</del><ins>+layer at (57,198) size 240x68
</ins><span class="cx"> RenderBlock (positioned) {DIV} at (0,0) size 240x68 [bgcolor=#1E1E1E73]
</span><del>-layer at (57,198) size 240x68 backgroundClip at (57,85) size 240x180 clip at (57,85) size 240x180 blendMode: lighten
</del><ins>+layer at (57,198) size 240x68 blendMode: lighten
</ins><span class="cx"> RenderBlock (positioned) {DIV} at (0,0) size 240x68 [bgcolor=#292929]
</span><span class="cx"> layer at (69,235) size 18x22 blendMode: plus-lighter
</span><span class="cx"> RenderButton {BUTTON} at (12,37) size 18x23 [color=#FFFFFF]
</span><span class="cx"> layer at (111,234) size 24x22 blendMode: plus-lighter
</span><span class="cx"> RenderButton {BUTTON} at (54,36) size 24x24 [color=#FFFFFF]
</span><del>-layer at (221,228) size 21x38 backgroundClip at (57,85) size 240x180 clip at (57,85) size 240x180
</del><ins>+layer at (221,228) size 21x38
</ins><span class="cx"> RenderFlexibleBox {DIV} at (163,30) size 22x38
</span><span class="cx"> layer at (221,235) size 21x22 blendMode: plus-lighter
</span><span class="cx"> RenderButton {BUTTON} at (0,7) size 21x23 [color=#FFFFFF]
</span><span class="lines">@@ -32,21 +32,21 @@
</span><span class="cx"> RenderVideo {VIDEO} at (45,298) size 240x180
</span><span class="cx"> layer at (57,310) size 240x180
</span><span class="cx"> RenderFlexibleBox {DIV} at (0,0) size 240x180
</span><del>-layer at (57,423) size 240x67 backgroundClip at (74,291) size 240x180 clip at (74,291) size 240x180
</del><ins>+layer at (57,423) size 240x67
</ins><span class="cx"> RenderFlexibleBox {DIV} at (0,112) size 240x68
</span><del>-layer at (57,423) size 240x68 backgroundClip at (74,291) size 240x180 clip at (74,291) size 240x180 isolatesBlending
</del><ins>+layer at (57,423) size 240x68 isolatesBlending
</ins><span class="cx"> RenderBlock (positioned) {DIV} at (0,0) size 240x68
</span><del>-layer at (57,423) size 240x68 backgroundClip at (74,291) size 240x180 clip at (74,291) size 240x180
</del><ins>+layer at (57,423) size 240x68
</ins><span class="cx"> RenderBlock (positioned) {DIV} at (0,0) size 240x68 [bgcolor=#1E1E1E73]
</span><del>-layer at (57,423) size 240x68 backgroundClip at (74,291) size 240x180 clip at (74,291) size 240x180 blendMode: lighten
</del><ins>+layer at (57,423) size 240x68 blendMode: lighten
</ins><span class="cx"> RenderBlock (positioned) {DIV} at (0,0) size 240x68 [bgcolor=#292929]
</span><del>-layer at (69,460) size 18x22 backgroundClip at (74,291) size 240x180 clip at (74,291) size 240x180 blendMode: plus-lighter
</del><ins>+layer at (69,460) size 18x22 blendMode: plus-lighter
</ins><span class="cx"> RenderButton {BUTTON} at (12,37) size 18x23 [color=#FFFFFF]
</span><del>-layer at (111,459) size 24x22 backgroundClip at (74,291) size 240x180 clip at (74,291) size 240x180 blendMode: plus-lighter
</del><ins>+layer at (111,459) size 24x22 blendMode: plus-lighter
</ins><span class="cx"> RenderButton {BUTTON} at (54,36) size 24x24 [color=#FFFFFF]
</span><del>-layer at (221,453) size 21x38 backgroundClip at (74,291) size 240x180 clip at (74,291) size 240x180
</del><ins>+layer at (221,453) size 21x38
</ins><span class="cx"> RenderFlexibleBox {DIV} at (163,30) size 22x38
</span><del>-layer at (221,460) size 21x22 backgroundClip at (74,291) size 240x180 clip at (74,291) size 240x180 blendMode: plus-lighter
</del><ins>+layer at (221,460) size 21x22 blendMode: plus-lighter
</ins><span class="cx"> RenderButton {BUTTON} at (0,7) size 21x23 [color=#FFFFFF]
</span><del>-layer at (266,460) size 21x22 backgroundClip at (74,291) size 240x180 clip at (74,291) size 240x180 blendMode: plus-lighter
</del><ins>+layer at (266,460) size 21x22 blendMode: plus-lighter
</ins><span class="cx"> RenderButton {BUTTON} at (208,37) size 22x23 [color=#FFFFFF]
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (201354 => 201355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-24 21:38:50 UTC (rev 201354)
+++ trunk/Source/WebCore/ChangeLog 2016-05-24 21:48:20 UTC (rev 201355)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2016-05-23 Ada Chan <adachan@apple.com>
+
+ Only set overflow:hidden on -webkit-media-controls when the placeholder is showing.
+ https://bugs.webkit.org/show_bug.cgi?id=157975
+
+ Reviewed by Eric Carlson.
+
+ Test: media/mac/controls-panel-not-clipped-out.html
+
+ overflow:hidden was added to clip out content contained in -webkit-media-controls
+ that sticks out of the bounds of that container when the inlinePlaybackPlaceholder
+ is showing. However, that style also clips out things that we want to show when the
+ inlinePlaybackPlaceholder is not showing. For example, the volume slider or the
+ controls panel when the video element's height is too short.
+
+ To fix that, we only set overflow:hidden on -webkit-media-controls when the
+ inlinePlaybackPlaceholder is visible.
+
+ * Modules/mediacontrols/mediaControlsApple.css:
+ (::-webkit-media-controls):
+ (::-webkit-media-controls.placeholder-showing):
+ Set overflow:hidden only when the placeholder is showing.
+
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.handlePresentationModeChange):
+ Add the placeholderShowing class to -webkit-media-controls only when the
+ inlinePlaybackPlaceholder is not hidden.
+
</ins><span class="cx"> 2016-05-24 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed, rolling out r201341.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsApplecss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css (201354 => 201355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2016-05-24 21:38:50 UTC (rev 201354)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2016-05-24 21:48:20 UTC (rev 201355)
</span><span class="lines">@@ -59,6 +59,9 @@
</span><span class="cx"> font: -webkit-small-control;
</span><span class="cx"> white-space: nowrap;
</span><span class="cx"> -webkit-font-smoothing: subpixel-antialiased;
</span><ins>+}
+
+::-webkit-media-controls.placeholder-showing {
</ins><span class="cx"> overflow: hidden;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediacontrolsmediaControlsApplejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (201354 => 201355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2016-05-24 21:38:50 UTC (rev 201354)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2016-05-24 21:48:20 UTC (rev 201355)
</span><span class="lines">@@ -115,6 +115,7 @@
</span><span class="cx"> down: 'down',
</span><span class="cx"> out: 'out',
</span><span class="cx"> pictureInPictureButton: 'picture-in-picture-button',
</span><ins>+ placeholderShowing: 'placeholder-showing',
</ins><span class="cx"> },
</span><span class="cx"> KeyCodes: {
</span><span class="cx"> enter: 13,
</span><span class="lines">@@ -872,6 +873,11 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ if (this.controls.inlinePlaybackPlaceholder.classList.contains(this.ClassNames.hidden))
+ this.base.classList.remove(this.ClassNames.placeholderShowing);
+ else
+ this.base.classList.add(this.ClassNames.placeholderShowing);
+
</ins><span class="cx"> this.updateControls();
</span><span class="cx"> this.updateCaptionContainer();
</span><span class="cx"> this.resetHideControlsTimer();
</span></span></pre>
</div>
</div>
</body>
</html>