<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201130] trunk/LayoutTests</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201130">201130</a></dd>
<dt>Author</dt> <dd>yoav@yoav.ws</dd>
<dt>Date</dt> <dd>2016-05-19 01:08:30 -0700 (Thu, 19 May 2016)</dd>
</dl>

<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/200887">r200887</a>): LayoutTest http/tests/performance/performance-resource-timing-cached-entries.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=157816

Reviewed by Alexey Proskuryakov.

Mark the test as flaky, and add console logs to try to figure out the cause for flakiness.

* TestExpectations: Mark the test as flaky.
* http/tests/performance/performance-resource-timing-cached-entries.html: Add prints to better identify the flakiness root cause.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsTestExpectations">trunk/LayoutTests/TestExpectations</a></li>
<li><a href="#trunkLayoutTestshttptestsperformanceperformanceresourcetimingcachedentriesexpectedtxt">trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt</a></li>
<li><a href="#trunkLayoutTestshttptestsperformanceperformanceresourcetimingcachedentrieshtml">trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (201129 => 201130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog        2016-05-19 07:32:48 UTC (rev 201129)
+++ trunk/LayoutTests/ChangeLog        2016-05-19 08:08:30 UTC (rev 201130)
</span><span class="lines">@@ -1,3 +1,15 @@
</span><ins>+2016-05-19  Yoav Weiss  &lt;yoav@yoav.ws&gt;
+
+        REGRESSION (r200887): LayoutTest http/tests/performance/performance-resource-timing-cached-entries.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=157816
+
+        Reviewed by Alexey Proskuryakov.
+
+        Mark the test as flaky, and add console logs to try to figure out the cause for flakiness.
+
+        * TestExpectations: Mark the test as flaky.
+        * http/tests/performance/performance-resource-timing-cached-entries.html: Add prints to better identify the flakiness root cause.
+
</ins><span class="cx"> 2016-05-18  Jer Noble  &lt;jer.noble@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         webkitEnterFullscreen() does not require a user gesture when RequireUserGestureForAudioRateChange is set.
</span><span class="lines">@@ -2677,7 +2689,7 @@
</span><span class="cx">         Unreviewed test gardening.
</span><span class="cx"> 
</span><span class="cx">         Remove failure expectation for passing tests, move some to more specific ports, and remove expectations
</span><del>-                for tests that are no longer in the tree.
</del><ins>+        for tests that are no longer in the tree.
</ins><span class="cx"> 
</span><span class="cx">         * platform/ios-simulator-wk1/TestExpectations:
</span><span class="cx">         * platform/ios-simulator-wk2/TestExpectations:
</span><span class="lines">@@ -4215,9 +4227,9 @@
</span><span class="cx"> 
</span><span class="cx">         Unreviewed test gardening.
</span><span class="cx"> 
</span><del>-                I evaluated all of the unexpected passes from ios-simulator-wk2 and removed failure
-                expectations where appropriate. Some of the tests only pass on wk2, so some expectations
-                were moved to the ios-simulator-wk1 file.
</del><ins>+        I evaluated all of the unexpected passes from ios-simulator-wk2 and removed failure
+        expectations where appropriate. Some of the tests only pass on wk2, so some expectations
+        were moved to the ios-simulator-wk1 file.
</ins><span class="cx"> 
</span><span class="cx">         * platform/ios-simulator-wk1/TestExpectations:
</span><span class="cx">         * platform/ios-simulator-wk2/TestExpectations:
</span></span></pre></div>
<a id="trunkLayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/TestExpectations (201129 => 201130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/TestExpectations        2016-05-19 07:32:48 UTC (rev 201129)
+++ trunk/LayoutTests/TestExpectations        2016-05-19 08:08:30 UTC (rev 201130)
</span><span class="lines">@@ -978,3 +978,6 @@
</span><span class="cx"> webkit.org/b/156631 fast/text/font-face-javascript.html [ Pass Crash Failure ]
</span><span class="cx"> 
</span><span class="cx"> webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]
</span><ins>+
+webkit.org/b/157816 http/tests/performance/performance-resource-timing-cached-entries.html [ Pass Failure ]
+
</ins></span></pre></div>
<a id="trunkLayoutTestshttptestsperformanceperformanceresourcetimingcachedentriesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt (201129 => 201130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt        2016-05-19 07:32:48 UTC (rev 201129)
+++ trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt        2016-05-19 08:08:30 UTC (rev 201130)
</span><span class="lines">@@ -1,2 +1,6 @@
</span><ins>+CONSOLE MESSAGE: line 11: current entries: 0
+CONSOLE MESSAGE: line 20: entry: http://127.0.0.1:8000/resources/js-test-pre.js
+CONSOLE MESSAGE: line 20: entry: http://127.0.0.1:8000/resources/square100.png
+CONSOLE MESSAGE: line 20: entry: http://127.0.0.1:8000/resources/square100.png
</ins><span class="cx"> PASS foundResource is 2
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkLayoutTestshttptestsperformanceperformanceresourcetimingcachedentrieshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html (201129 => 201130)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html        2016-05-19 07:32:48 UTC (rev 201129)
+++ trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html        2016-05-19 08:08:30 UTC (rev 201130)
</span><span class="lines">@@ -7,6 +7,8 @@
</span><span class="cx">         testRunner.dumpAsText()
</span><span class="cx">         testRunner.waitUntilDone();
</span><span class="cx">     }
</span><ins>+    if (window.performance)
+        console.log(&quot;current entries: &quot; + performance.getEntriesByType('resource').length);
</ins><span class="cx"> &lt;/script&gt;
</span><span class="cx"> &lt;script src=&quot;../../resources/js-test-pre.js&quot;&gt;&lt;/script&gt;
</span><span class="cx"> &lt;img src=&quot;../../resources/square100.png&quot;&gt;
</span><span class="lines">@@ -15,6 +17,7 @@
</span><span class="cx">     var runTest = function() {
</span><span class="cx">         var resources = performance.getEntriesByType('resource');
</span><span class="cx">         for (var i = 0; i &lt; resources.length; ++i) {
</span><ins>+            console.log(&quot;entry: &quot; + resources[i].name);
</ins><span class="cx">             if (resources[i].name.indexOf(&quot;square&quot;) != -1)
</span><span class="cx">                 ++foundResource;
</span><span class="cx">         };
</span></span></pre>
</div>
</div>

</body>
</html>