<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[201114] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/201114">201114</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2016-05-18 16:25:47 -0700 (Wed, 18 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove LayoutUnit::operator unsigned().
https://bugs.webkit.org/show_bug.cgi?id=157856
Reviewed by Simon Fraser.
Converting LayoutUnit values to unsigned is lossy. We should avoid
such implicit conversions.
No behaviour change.
* html/ImageInputType.cpp:
(WebCore::ImageInputType::height):
(WebCore::ImageInputType::width):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* platform/LayoutUnit.h:
(WebCore::LayoutUnit::operator unsigned): Deleted.
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeColumnCountAndWidth):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlImageInputTypecpp">trunk/Source/WebCore/html/ImageInputType.cpp</a></li>
<li><a href="#trunkSourceWebCorepageEventHandlercpp">trunk/Source/WebCore/page/EventHandler.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformLayoutUnith">trunk/Source/WebCore/platform/LayoutUnit.h</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockFlowcpp">trunk/Source/WebCore/rendering/RenderBlockFlow.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (201113 => 201114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-18 23:09:09 UTC (rev 201113)
+++ trunk/Source/WebCore/ChangeLog 2016-05-18 23:25:47 UTC (rev 201114)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-05-18 Zalan Bujtas <zalan@apple.com>
+
+ Remove LayoutUnit::operator unsigned().
+ https://bugs.webkit.org/show_bug.cgi?id=157856
+
+ Reviewed by Simon Fraser.
+
+ Converting LayoutUnit values to unsigned is lossy. We should avoid
+ such implicit conversions.
+
+ No behaviour change.
+
+ * html/ImageInputType.cpp:
+ (WebCore::ImageInputType::height):
+ (WebCore::ImageInputType::width):
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::hitTestResultAtPoint):
+ * platform/LayoutUnit.h:
+ (WebCore::LayoutUnit::operator unsigned): Deleted.
+ * rendering/RenderBlockFlow.cpp:
+ (WebCore::RenderBlockFlow::computeColumnCountAndWidth):
+
</ins><span class="cx"> 2016-05-18 Alex Christensen <achristensen@webkit.org>
</span><span class="cx">
</span><span class="cx"> Clean up CSS code
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlImageInputTypecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/ImageInputType.cpp (201113 => 201114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/ImageInputType.cpp 2016-05-18 23:09:09 UTC (rev 201113)
+++ trunk/Source/WebCore/html/ImageInputType.cpp 2016-05-18 23:25:47 UTC (rev 201114)
</span><span class="lines">@@ -182,7 +182,7 @@
</span><span class="cx"> // If the image is available, use its height.
</span><span class="cx"> HTMLImageLoader* imageLoader = element->imageLoader();
</span><span class="cx"> if (imageLoader && imageLoader->image())
</span><del>- return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).height();
</del><ins>+ return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).height().toUnsigned();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> element->document().updateLayout();
</span><span class="lines">@@ -203,7 +203,7 @@
</span><span class="cx"> // If the image is available, use its width.
</span><span class="cx"> HTMLImageLoader* imageLoader = element->imageLoader();
</span><span class="cx"> if (imageLoader && imageLoader->image())
</span><del>- return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).width();
</del><ins>+ return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).width().toUnsigned();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> element->document().updateLayout();
</span></span></pre></div>
<a id="trunkSourceWebCorepageEventHandlercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/EventHandler.cpp (201113 => 201114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/EventHandler.cpp 2016-05-18 23:09:09 UTC (rev 201113)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2016-05-18 23:25:47 UTC (rev 201114)
</span><span class="lines">@@ -1131,7 +1131,9 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- HitTestResult result(point, padding.height(), padding.width(), padding.height(), padding.width());
</del><ins>+ unsigned nonNegativePaddingWidth = std::max<LayoutUnit>(0, padding.width()).toUnsigned();
+ unsigned nonNegativePaddingHeight = std::max<LayoutUnit>(0, padding.height()).toUnsigned();
+ HitTestResult result(point, nonNegativePaddingHeight, nonNegativePaddingWidth, nonNegativePaddingHeight, nonNegativePaddingWidth);
</ins><span class="cx">
</span><span class="cx"> RenderView* renderView = m_frame.contentRenderer();
</span><span class="cx"> if (!renderView)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformLayoutUnith"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/LayoutUnit.h (201113 => 201114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/LayoutUnit.h 2016-05-18 23:09:09 UTC (rev 201113)
+++ trunk/Source/WebCore/platform/LayoutUnit.h 2016-05-18 23:25:47 UTC (rev 201114)
</span><span class="lines">@@ -114,7 +114,6 @@
</span><span class="cx"> unsigned toUnsigned() const { REPORT_OVERFLOW(m_value >= 0); return toInt(); }
</span><span class="cx">
</span><span class="cx"> operator int() const { return toInt(); }
</span><del>- operator unsigned() const { return toUnsigned(); }
</del><span class="cx"> operator float() const { return toFloat(); }
</span><span class="cx"> operator double() const { return toDouble(); }
</span><span class="cx"> operator bool() const { return m_value; }
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockFlowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (201113 => 201114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-18 23:09:09 UTC (rev 201113)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-18 23:25:47 UTC (rev 201114)
</span><span class="lines">@@ -412,16 +412,16 @@
</span><span class="cx"> LayoutUnit availWidth = desiredColumnWidth;
</span><span class="cx"> LayoutUnit colGap = columnGap();
</span><span class="cx"> LayoutUnit colWidth = std::max<LayoutUnit>(LayoutUnit::fromPixel(1), LayoutUnit(style().columnWidth()));
</span><del>- int colCount = std::max<int>(1, style().columnCount());
</del><ins>+ unsigned colCount = std::max<unsigned>(1, style().columnCount());
</ins><span class="cx">
</span><span class="cx"> if (style().hasAutoColumnWidth() && !style().hasAutoColumnCount()) {
</span><span class="cx"> desiredColumnCount = colCount;
</span><span class="cx"> desiredColumnWidth = std::max<LayoutUnit>(0, (availWidth - ((desiredColumnCount - 1) * colGap)) / desiredColumnCount);
</span><span class="cx"> } else if (!style().hasAutoColumnWidth() && style().hasAutoColumnCount()) {
</span><del>- desiredColumnCount = std::max<LayoutUnit>(1, (availWidth + colGap) / (colWidth + colGap));
</del><ins>+ desiredColumnCount = std::max<LayoutUnit>(1, (availWidth + colGap) / (colWidth + colGap)).toUnsigned();
</ins><span class="cx"> desiredColumnWidth = ((availWidth + colGap) / desiredColumnCount) - colGap;
</span><span class="cx"> } else {
</span><del>- desiredColumnCount = std::max<LayoutUnit>(std::min<LayoutUnit>(colCount, (availWidth + colGap) / (colWidth + colGap)), 1);
</del><ins>+ desiredColumnCount = std::max<LayoutUnit>(std::min<LayoutUnit>(colCount, (availWidth + colGap) / (colWidth + colGap)), 1).toUnsigned();
</ins><span class="cx"> desiredColumnWidth = ((availWidth + colGap) / desiredColumnCount) - colGap;
</span><span class="cx"> }
</span><span class="cx"> setComputedColumnCountAndWidth(desiredColumnCount, desiredColumnWidth);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (201113 => 201114)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-05-18 23:09:09 UTC (rev 201113)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-05-18 23:25:47 UTC (rev 201114)
</span><span class="lines">@@ -5104,7 +5104,7 @@
</span><span class="cx">
</span><span class="cx"> LayoutUnit contentArea = pluginRenderBox.contentWidth() * pluginRenderBox.contentHeight();
</span><span class="cx"> if (contentArea > candidatePlugInArea * primarySnapshottedPlugInSearchBucketSize) {
</span><del>- candidatePlugInArea = contentArea;
</del><ins>+ candidatePlugInArea = contentArea.toUnsigned();
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> return false;
</span></span></pre>
</div>
</div>
</body>
</html>