<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200977] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200977">200977</a></dd>
<dt>Author</dt> <dd>achristensen@apple.com</dd>
<dt>Date</dt> <dd>2016-05-16 16:11:08 -0700 (Mon, 16 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't include CSSParser.h from other headers
https://bugs.webkit.org/show_bug.cgi?id=157765
Reviewed by Zalan Bujtas.
No change in behavior. This just makes it so touching CSSParser.h doesn't rebuild as many files.
* css/CSSCalculationValue.cpp:
* css/CSSParser.cpp:
(WebCore::CSSParser::sourceSize):
(WebCore::filterProperties):
* css/CSSParser.h:
(WebCore::CSSParser::ValueWithCalculation::ValueWithCalculation):
* css/CSSProperty.h:
(WebCore::prefixingVariantForPropertyId):
* css/FontFace.cpp:
* css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::parseDeclaration):
(WebCore::MutableStyleProperties::addParsedProperties):
* css/StyleProperties.h:
* css/StyleResolver.h:
* rendering/style/RenderStyle.cpp:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorecssCSSCalculationValuecpp">trunk/Source/WebCore/css/CSSCalculationValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSParsercpp">trunk/Source/WebCore/css/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSParserh">trunk/Source/WebCore/css/CSSParser.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSPropertyh">trunk/Source/WebCore/css/CSSProperty.h</a></li>
<li><a href="#trunkSourceWebCorecssFontFacecpp">trunk/Source/WebCore/css/FontFace.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStylePropertiescpp">trunk/Source/WebCore/css/StyleProperties.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStylePropertiesh">trunk/Source/WebCore/css/StyleProperties.h</a></li>
<li><a href="#trunkSourceWebCorecssStyleResolverh">trunk/Source/WebCore/css/StyleResolver.h</a></li>
<li><a href="#trunkSourceWebCorerenderingstyleRenderStylecpp">trunk/Source/WebCore/rendering/style/RenderStyle.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (200976 => 200977)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/ChangeLog 2016-05-16 23:11:08 UTC (rev 200977)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2016-05-16 Alex Christensen <achristensen@webkit.org>
+
+ Don't include CSSParser.h from other headers
+ https://bugs.webkit.org/show_bug.cgi?id=157765
+
+ Reviewed by Zalan Bujtas.
+
+ No change in behavior. This just makes it so touching CSSParser.h doesn't rebuild as many files.
+
+ * css/CSSCalculationValue.cpp:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::sourceSize):
+ (WebCore::filterProperties):
+ * css/CSSParser.h:
+ (WebCore::CSSParser::ValueWithCalculation::ValueWithCalculation):
+ * css/CSSProperty.h:
+ (WebCore::prefixingVariantForPropertyId):
+ * css/FontFace.cpp:
+ * css/StyleProperties.cpp:
+ (WebCore::MutableStyleProperties::parseDeclaration):
+ (WebCore::MutableStyleProperties::addParsedProperties):
+ * css/StyleProperties.h:
+ * css/StyleResolver.h:
+ * rendering/style/RenderStyle.cpp:
+
</ins><span class="cx"> 2016-05-16 Aaron Chu <aaron_chu@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION (r200441): Yahoo sports, finance and news pages automatically scroll
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSCalculationValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSCalculationValue.cpp (200976 => 200977)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSCalculationValue.cpp 2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/CSSCalculationValue.cpp 2016-05-16 23:11:08 UTC (rev 200977)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> #include "config.h"
</span><span class="cx"> #include "CSSCalculationValue.h"
</span><span class="cx">
</span><ins>+#include "CSSParser.h"
</ins><span class="cx"> #include "CSSPrimitiveValueMappings.h"
</span><span class="cx"> #include "StyleResolver.h"
</span><span class="cx"> #include <wtf/MathExtras.h>
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.cpp (200976 => 200977)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.cpp 2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2016-05-16 23:11:08 UTC (rev 200977)
</span><span class="lines">@@ -1595,7 +1595,7 @@
</span><span class="cx"> return SourceSize(WTFMove(expression), WTFMove(value));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static inline void filterProperties(bool important, const CSSParser::ParsedPropertyVector& input, Vector<CSSProperty, 256>& output, size_t& unusedEntries, std::bitset<numCSSProperties>& seenProperties, HashSet<AtomicString>& seenCustomProperties)
</del><ins>+static inline void filterProperties(bool important, const ParsedPropertyVector& input, Vector<CSSProperty, 256>& output, size_t& unusedEntries, std::bitset<numCSSProperties>& seenProperties, HashSet<AtomicString>& seenCustomProperties)
</ins><span class="cx"> {
</span><span class="cx"> // Add properties in reverse order so that highest priority definitions are reached first. Duplicate definitions can then be ignored when found.
</span><span class="cx"> for (int i = input.size() - 1; i >= 0; --i) {
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParserh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.h (200976 => 200977)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.h 2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/CSSParser.h 2016-05-16 23:11:08 UTC (rev 200977)
</span><span class="lines">@@ -88,8 +88,6 @@
</span><span class="cx"> Error
</span><span class="cx"> };
</span><span class="cx">
</span><del>- using ParsedPropertyVector = Vector<CSSProperty, 256>;
-
</del><span class="cx"> class ValueWithCalculation {
</span><span class="cx"> public:
</span><span class="cx"> explicit ValueWithCalculation(CSSParserValue& value)
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSPropertyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSProperty.h (200976 => 200977)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSProperty.h 2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/CSSProperty.h 2016-05-16 23:11:08 UTC (rev 200977)
</span><span class="lines">@@ -104,6 +104,8 @@
</span><span class="cx"> RefPtr<CSSValue> m_value;
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+typedef Vector<CSSProperty, 256> ParsedPropertyVector;
+
</ins><span class="cx"> inline CSSPropertyID prefixingVariantForPropertyId(CSSPropertyID propertyID)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(propertyID != CSSPropertyInvalid);
</span></span></pre></div>
<a id="trunkSourceWebCorecssFontFacecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/FontFace.cpp (200976 => 200977)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/FontFace.cpp 2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/FontFace.cpp 2016-05-16 23:11:08 UTC (rev 200977)
</span><span class="lines">@@ -28,6 +28,7 @@
</span><span class="cx">
</span><span class="cx"> #include "CSSFontFaceSource.h"
</span><span class="cx"> #include "CSSFontFeatureValue.h"
</span><ins>+#include "CSSParser.h"
</ins><span class="cx"> #include "CSSUnicodeRangeValue.h"
</span><span class="cx"> #include "CSSValuePool.h"
</span><span class="cx"> #include "Document.h"
</span></span></pre></div>
<a id="trunkSourceWebCorecssStylePropertiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleProperties.cpp (200976 => 200977)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleProperties.cpp 2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/StyleProperties.cpp 2016-05-16 23:11:08 UTC (rev 200977)
</span><span class="lines">@@ -818,7 +818,7 @@
</span><span class="cx"> return oldProperties != m_propertyVector;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool MutableStyleProperties::addParsedProperties(const CSSParser::ParsedPropertyVector& properties)
</del><ins>+bool MutableStyleProperties::addParsedProperties(const ParsedPropertyVector& properties)
</ins><span class="cx"> {
</span><span class="cx"> bool anyChanged = false;
</span><span class="cx"> m_propertyVector.reserveCapacity(m_propertyVector.size() + properties.size());
</span></span></pre></div>
<a id="trunkSourceWebCorecssStylePropertiesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleProperties.h (200976 => 200977)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleProperties.h 2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/StyleProperties.h 2016-05-16 23:11:08 UTC (rev 200977)
</span><span class="lines">@@ -22,7 +22,6 @@
</span><span class="cx"> #ifndef StyleProperties_h
</span><span class="cx"> #define StyleProperties_h
</span><span class="cx">
</span><del>-#include "CSSParser.h"
</del><span class="cx"> #include "CSSParserMode.h"
</span><span class="cx"> #include "CSSPrimitiveValue.h"
</span><span class="cx"> #include "CSSProperty.h"
</span><span class="lines">@@ -201,7 +200,7 @@
</span><span class="cx">
</span><span class="cx"> PropertySetCSSStyleDeclaration* cssStyleDeclaration();
</span><span class="cx">
</span><del>- bool addParsedProperties(const CSSParser::ParsedPropertyVector&);
</del><ins>+ bool addParsedProperties(const ParsedPropertyVector&);
</ins><span class="cx"> bool addParsedProperty(const CSSProperty&);
</span><span class="cx">
</span><span class="cx"> // These expand shorthand properties into multiple properties.
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleResolverh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleResolver.h (200976 => 200977)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleResolver.h 2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/css/StyleResolver.h 2016-05-16 23:11:08 UTC (rev 200977)
</span><span class="lines">@@ -62,6 +62,7 @@
</span><span class="cx"> class CSSSelector;
</span><span class="cx"> class CSSStyleSheet;
</span><span class="cx"> class CSSValue;
</span><ins>+class CSSVariableDependentValue;
</ins><span class="cx"> class ContainerNode;
</span><span class="cx"> class Document;
</span><span class="cx"> class Element;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingstyleRenderStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (200976 => 200977)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2016-05-16 23:08:05 UTC (rev 200976)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2016-05-16 23:11:08 UTC (rev 200977)
</span><span class="lines">@@ -25,6 +25,7 @@
</span><span class="cx">
</span><span class="cx"> #include "ContentData.h"
</span><span class="cx"> #include "CSSCustomPropertyValue.h"
</span><ins>+#include "CSSParser.h"
</ins><span class="cx"> #include "CSSPropertyNames.h"
</span><span class="cx"> #include "CSSVariableDependentValue.h"
</span><span class="cx"> #include "CursorList.h"
</span></span></pre>
</div>
</div>
</body>
</html>