<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200910] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200910">200910</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2016-05-13 19:27:50 -0700 (Fri, 13 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[iOS] <select> elements popover should render right-aligned when in RTL mode
https://bugs.webkit.org/show_bug.cgi?id=157699
<rdar://problem/26282319>
Reviewed by Simon Fraser.
Some follow-up changes as suggested by Darin in review.
* Shared/AssistedNodeInformation.h: Use initializers so we can
remove the constructors.
(WebKit::OptionItem::OptionItem): Deleted.
(WebKit::AssistedNodeInformation::AssistedNodeInformation): Deleted.
* UIProcess/ios/forms/WKFormSelectPopover.mm: Add a comment to explain
why we are explicitly setting the language.
(-[WKSelectTableViewController initWithView:hasGroups:]):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedAssistedNodeInformationh">trunk/Source/WebKit2/Shared/AssistedNodeInformation.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosformsWKFormSelectPopovermm">trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (200909 => 200910)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-05-14 02:26:23 UTC (rev 200909)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-14 02:27:50 UTC (rev 200910)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-05-13 Dean Jackson <dino@apple.com>
+
+ [iOS] <select> elements popover should render right-aligned when in RTL mode
+ https://bugs.webkit.org/show_bug.cgi?id=157699
+ <rdar://problem/26282319>
+
+ Reviewed by Simon Fraser.
+
+ Some follow-up changes as suggested by Darin in review.
+
+ * Shared/AssistedNodeInformation.h: Use initializers so we can
+ remove the constructors.
+ (WebKit::OptionItem::OptionItem): Deleted.
+ (WebKit::AssistedNodeInformation::AssistedNodeInformation): Deleted.
+ * UIProcess/ios/forms/WKFormSelectPopover.mm: Add a comment to explain
+ why we are explicitly setting the language.
+ (-[WKSelectTableViewController initWithView:hasGroups:]):
+
</ins><span class="cx"> 2016-05-13 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> [NetworkCache] Avoid having to re-parse URLs after deserializing them
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedAssistedNodeInformationh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/AssistedNodeInformation.h (200909 => 200910)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/AssistedNodeInformation.h 2016-05-14 02:26:23 UTC (rev 200909)
+++ trunk/Source/WebKit2/Shared/AssistedNodeInformation.h 2016-05-14 02:27:50 UTC (rev 200910)
</span><span class="lines">@@ -57,14 +57,6 @@
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> struct OptionItem {
</span><del>- OptionItem()
- : isGroup(false)
- , isSelected(false)
- , disabled(false)
- , parentGroupID(0)
- {
- }
-
</del><span class="cx"> OptionItem(const OptionItem& item)
</span><span class="cx"> : text(item.text)
</span><span class="cx"> , isGroup(item.isGroup)
</span><span class="lines">@@ -83,55 +75,36 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx"> String text;
</span><del>- bool isGroup;
- bool isSelected;
- bool disabled;
- int parentGroupID;
</del><ins>+ bool isGroup { false };
+ bool isSelected { false };
+ bool disabled { false };
+ int parentGroupID { 0 };
</ins><span class="cx">
</span><span class="cx"> void encode(IPC::ArgumentEncoder&) const;
</span><span class="cx"> static bool decode(IPC::ArgumentDecoder&, OptionItem&);
</span><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> struct AssistedNodeInformation {
</span><del>- AssistedNodeInformation()
- : minimumScaleFactor(-INFINITY)
- , maximumScaleFactor(INFINITY)
- , nodeFontSize(0)
- , hasNextNode(false)
- , hasPreviousNode(false)
- , isAutocorrect(false)
- , isRTL(false)
- , isMultiSelect(false)
- , isReadOnly(false)
- , allowsUserScaling(false)
- , insideFixedPosition(false)
- , autocapitalizeType(WebAutocapitalizeTypeDefault)
- , elementType(InputType::None)
- , selectedIndex(-1)
- , valueAsNumber(0)
- {
- }
-
</del><span class="cx"> WebCore::IntRect elementRect;
</span><span class="cx"> WebCore::IntRect selectionRect;
</span><del>- double minimumScaleFactor;
- double maximumScaleFactor;
- double nodeFontSize;
- bool hasNextNode;
- bool hasPreviousNode;
- bool isAutocorrect;
- bool isRTL;
- bool isMultiSelect;
- bool isReadOnly;
- bool allowsUserScaling;
- bool insideFixedPosition;
- WebAutocapitalizeType autocapitalizeType;
- InputType elementType;
</del><ins>+ double minimumScaleFactor { -INFINITY };
+ double maximumScaleFactor { INFINITY };
+ double nodeFontSize { 0 };
+ bool hasNextNode { false };
+ bool hasPreviousNode { false };
+ bool isAutocorrect { false };
+ bool isRTL { false };
+ bool isMultiSelect { false };
+ bool isReadOnly {false };
+ bool allowsUserScaling { false };
+ bool insideFixedPosition { false };
+ WebAutocapitalizeType autocapitalizeType { WebAutocapitalizeTypeDefault };
+ InputType elementType { InputType::None };
</ins><span class="cx"> String formAction;
</span><span class="cx"> Vector<OptionItem> selectOptions;
</span><del>- int selectedIndex;
</del><ins>+ int selectedIndex { -1 };
</ins><span class="cx"> String value;
</span><del>- double valueAsNumber;
</del><ins>+ double valueAsNumber { 0 };
</ins><span class="cx"> String title;
</span><span class="cx"> WebCore::AutofillFieldName autofillFieldName { WebCore::AutofillFieldName::None };
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosformsWKFormSelectPopovermm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm (200909 => 200910)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm 2016-05-14 02:26:23 UTC (rev 200909)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKFormSelectPopover.mm 2016-05-14 02:27:50 UTC (rev 200910)
</span><span class="lines">@@ -125,7 +125,10 @@
</span><span class="cx"> UITextWritingDirection writingDirection = _contentView.assistedNodeInformation.isRTL ? UITextWritingDirectionRightToLeft : UITextWritingDirectionLeftToRight;
</span><span class="cx"> BOOL override = NO;
</span><span class="cx"> _textAlignment = (writingDirection == UITextWritingDirectionLeftToRight) ? NSTextAlignmentLeft : NSTextAlignmentRight;
</span><del>-
</del><ins>+
+ // Typically UIKit apps have their writing direction follow the system
+ // language. However WebKit wants to follow the content direction.
+ // For that reason we have to override what the system thinks.
</ins><span class="cx"> if (writingDirection == UITextWritingDirectionRightToLeft)
</span><span class="cx"> self.view.semanticContentAttribute = UISemanticContentAttributeForceRightToLeft;
</span><span class="cx"> [self setTitle:stringWithWritingDirection(_contentView.assistedNodeInformation.title, writingDirection, override)];
</span></span></pre>
</div>
</div>
</body>
</html>