<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200846] releases/WebKitGTK/webkit-2.12</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200846">200846</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-05-13 05:18:51 -0700 (Fri, 13 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/200247">r200247</a> - Wheel Event Not Fired For `body,html { height:100% }`
https://bugs.webkit.org/show_bug.cgi?id=148450
Reviewed by Brent Fulgham.
Source/WebCore:
EventHandler::handleWheelEvent() didn't pass the Active flag in the HitTestRequest,
which causes code in RenderLayer::hitTest() to fail to fall back to returning the
root layer if no other element is hit. "Active" is in the default flags,
so just create the HitTestRequest with the default flags.
Test: fast/events/wheel-event-outside-body.html
* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
LayoutTests:
Testcase, skipped on iOS which doesn't support wheel events.
* fast/events/wheel-event-outside-body-expected.txt: Added.
* fast/events/wheel-event-outside-body.html: Added.
* platform/ios-simulator/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorepageEventHandlercpp">releases/WebKitGTK/webkit-2.12/Source/WebCore/page/EventHandler.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsfasteventswheeleventoutsidebodyexpectedtxt">releases/WebKitGTK/webkit-2.12/LayoutTests/fast/events/wheel-event-outside-body-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsfasteventswheeleventoutsidebodyhtml">releases/WebKitGTK/webkit-2.12/LayoutTests/fast/events/wheel-event-outside-body.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit212LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (200845 => 200846)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog        2016-05-13 12:14:22 UTC (rev 200845)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog        2016-05-13 12:18:51 UTC (rev 200846)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-04-29 Simon Fraser <simon.fraser@apple.com>
+
+ Wheel Event Not Fired For `body,html { height:100% }`
+ https://bugs.webkit.org/show_bug.cgi?id=148450
+
+ Reviewed by Brent Fulgham.
+
+ Testcase, skipped on iOS which doesn't support wheel events.
+
+ * fast/events/wheel-event-outside-body-expected.txt: Added.
+ * fast/events/wheel-event-outside-body.html: Added.
+ * platform/ios-simulator/TestExpectations:
+
</ins><span class="cx"> 2016-04-28 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Content disappears on mouse over.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsfasteventswheeleventoutsidebodyexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/fast/events/wheel-event-outside-body-expected.txt (0 => 200846)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/fast/events/wheel-event-outside-body-expected.txt         (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/fast/events/wheel-event-outside-body-expected.txt        2016-05-13 12:18:51 UTC (rev 200846)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+PASS: received mousewheel event
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsfasteventswheeleventoutsidebodyhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/fast/events/wheel-event-outside-body.html (0 => 200846)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/fast/events/wheel-event-outside-body.html         (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/fast/events/wheel-event-outside-body.html        2016-05-13 12:18:51 UTC (rev 200846)
</span><span class="lines">@@ -0,0 +1,72 @@
</span><ins>+<!DOCTYPE html>
+
+<html>
+<head>
+ <style>
+ html {
+ background-color: white;
+ }
+ body {
+ background-color: silver;
+ height: 400px;
+ margin: 0;
+ }
+
+ .tall {
+ position: absolute;
+ top: 0;
+ background-color: gray;
+ height: 2000px;
+ width: 20px;
+ }
+
+ #results {
+ position: fixed;
+ margin-left: 25px;
+ }
+ </style>
+
+ <script>
+ if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+ }
+
+ function setResult(s)
+ {
+ document.getElementById('results').innerText = s;
+ }
+
+ function runTest()
+ {
+ window.addEventListener('mousewheel', function(event) {
+ setResult('PASS: received mousewheel event');
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }, false)
+ window.scrollTo(0, 800);
+
+ window.setTimeout(function() {
+ if (window.eventSender) {
+ eventSender.mouseMoveTo(50, 100);
+ eventSender.mouseScrollBy(-1, -2);
+ }
+
+ // Watchdog timer in case of failure.
+ window.setTimeout(function() {
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }, 100);
+ }, 0);
+ }
+
+ window.addEventListener('load', runTest, false);
+ </script>
+</head>
+<body>
+<div id="results">
+ FAIL: did not receive mousewheel event.
+</div>
+<div class="tall"></div>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (200845 => 200846)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog        2016-05-13 12:14:22 UTC (rev 200845)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog        2016-05-13 12:18:51 UTC (rev 200846)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-04-29 Simon Fraser <simon.fraser@apple.com>
+
+ Wheel Event Not Fired For `body,html { height:100% }`
+ https://bugs.webkit.org/show_bug.cgi?id=148450
+
+ Reviewed by Brent Fulgham.
+
+ EventHandler::handleWheelEvent() didn't pass the Active flag in the HitTestRequest,
+ which causes code in RenderLayer::hitTest() to fail to fall back to returning the
+ root layer if no other element is hit. "Active" is in the default flags,
+ so just create the HitTestRequest with the default flags.
+
+ Test: fast/events/wheel-event-outside-body.html
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::handleWheelEvent):
+
</ins><span class="cx"> 2016-04-28 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Content disappears on mouse over.
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorepageEventHandlercpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/page/EventHandler.cpp (200845 => 200846)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/page/EventHandler.cpp        2016-05-13 12:14:22 UTC (rev 200845)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/page/EventHandler.cpp        2016-05-13 12:18:51 UTC (rev 200846)
</span><span class="lines">@@ -2601,7 +2601,7 @@
</span><span class="cx"> m_isHandlingWheelEvent = true;
</span><span class="cx"> setFrameWasScrolledByUser();
</span><span class="cx">
</span><del>- HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::DisallowShadowContent);
</del><ins>+ HitTestRequest request;
</ins><span class="cx"> HitTestResult result(view->windowToContents(event.position()));
</span><span class="cx"> renderView->hitTest(request, result);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>