<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200702] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200702">200702</a></dd>
<dt>Author</dt> <dd>bburg@apple.com</dd>
<dt>Date</dt> <dd>2016-05-11 13:57:08 -0700 (Wed, 11 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Automation: add command to asynchronously load the Web Inspector frontend in the background
https://bugs.webkit.org/show_bug.cgi?id=157509
Reviewed by Timothy Hatcher and Joseph Pecoraro.
In order to make it easier to debug code that executes as a result of an automation
command, this patch adds a new Automation command to asynchronously load the debugger
and Inspector frontend. It is designed for use by automation clients to implement an
auto-inspection feature to aid in debugging automation scripts.
* UIProcess/Automation/Automation.json: Add new command.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::inspectBrowsingContext): Added.
(WebKit::WebAutomationSession::inspectorFrontendLoaded): Added.
This message is forwarded by WebInspectorProxy to the inspected page's session.
* UIProcess/Automation/WebAutomationSession.h:
* UIProcess/Cocoa/WebAutomationSessionCocoa.mm:
(WebKit::WebAutomationSession::sendSynthesizedEventsToPage):
Force the active automation window to become key and bring to front prior to
sending each NSEvent. This way, if the Inspector pauses while a command executes,
the automation window will get back focus when the Inspector unpauses just before
the next synthesized mouse or keyboard NSEvent is sent to its NSWindow.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::frontendLoaded):
Forward to the inspected page's session.
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in: Add notification of the frontend's load.
* WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::frontendLoaded):
Kick off notifying the automation session in UIProcess that the inspector loaded.
(WebKit::WebInspectorUI::closeWindow):
In some circumstances, the Web Inspector can be loaded without showing
the window. If this hidden page closes, make sure the frontend host gets
a chance to disconnect its InspectorFrontendClient. Normally this happens
when the window closes, but unshown Inspectors do not get window instances.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAutomationAutomationjson">trunk/Source/WebKit2/UIProcess/Automation/Automation.json</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAutomationWebAutomationSessioncpp">trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAutomationWebAutomationSessionh">trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessCocoaWebAutomationSessionCocoamm">trunk/Source/WebKit2/UIProcess/Cocoa/WebAutomationSessionCocoa.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebInspectorProxycpp">trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebInspectorProxyh">trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebInspectorProxymessagesin">trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebInspectorUIcpp">trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (200701 => 200702)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-05-11 20:54:09 UTC (rev 200701)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-11 20:57:08 UTC (rev 200702)
</span><span class="lines">@@ -1,3 +1,46 @@
</span><ins>+2016-05-10 Brian Burg <bburg@apple.com>
+
+ Web Automation: add command to asynchronously load the Web Inspector frontend in the background
+ https://bugs.webkit.org/show_bug.cgi?id=157509
+
+ Reviewed by Timothy Hatcher and Joseph Pecoraro.
+
+ In order to make it easier to debug code that executes as a result of an automation
+ command, this patch adds a new Automation command to asynchronously load the debugger
+ and Inspector frontend. It is designed for use by automation clients to implement an
+ auto-inspection feature to aid in debugging automation scripts.
+
+ * UIProcess/Automation/Automation.json: Add new command.
+ * UIProcess/Automation/WebAutomationSession.cpp:
+ (WebKit::WebAutomationSession::inspectBrowsingContext): Added.
+ (WebKit::WebAutomationSession::inspectorFrontendLoaded): Added.
+ This message is forwarded by WebInspectorProxy to the inspected page's session.
+
+ * UIProcess/Automation/WebAutomationSession.h:
+ * UIProcess/Cocoa/WebAutomationSessionCocoa.mm:
+ (WebKit::WebAutomationSession::sendSynthesizedEventsToPage):
+ Force the active automation window to become key and bring to front prior to
+ sending each NSEvent. This way, if the Inspector pauses while a command executes,
+ the automation window will get back focus when the Inspector unpauses just before
+ the next synthesized mouse or keyboard NSEvent is sent to its NSWindow.
+
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorProxy::frontendLoaded):
+ Forward to the inspected page's session.
+
+ * UIProcess/WebInspectorProxy.h:
+ * UIProcess/WebInspectorProxy.messages.in: Add notification of the frontend's load.
+
+ * WebProcess/WebPage/WebInspectorUI.cpp:
+ (WebKit::WebInspectorUI::frontendLoaded):
+ Kick off notifying the automation session in UIProcess that the inspector loaded.
+
+ (WebKit::WebInspectorUI::closeWindow):
+ In some circumstances, the Web Inspector can be loaded without showing
+ the window. If this hidden page closes, make sure the frontend host gets
+ a chance to disconnect its InspectorFrontendClient. Normally this happens
+ when the window closes, but unshown Inspectors do not get window instances.
+
</ins><span class="cx"> 2016-05-11 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> Update Node::appendChild() / replaceChild() / removeChild() / insertBefore() to take references instead of pointers
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAutomationAutomationjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Automation/Automation.json (200701 => 200702)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Automation/Automation.json 2016-05-11 20:54:09 UTC (rev 200701)
+++ trunk/Source/WebKit2/UIProcess/Automation/Automation.json 2016-05-11 20:57:08 UTC (rev 200702)
</span><span class="lines">@@ -294,6 +294,14 @@
</span><span class="cx"> "async": true
</span><span class="cx"> },
</span><span class="cx"> {
</span><ins>+ "name": "inspectBrowsingContext",
+ "description": "Inspect the specified browsing context using Web Inspector.",
+ "parameters": [
+ { "name": "handle", "$ref": "BrowsingContextHandle", "description": "The handle for the browsing context that should be inspected." }
+ ],
+ "async": true
+ },
+ {
</ins><span class="cx"> "name": "evaluateJavaScriptFunction",
</span><span class="cx"> "description": "Evaluates a script function in a browsing context and calls it with the supplied arguments.",
</span><span class="cx"> "parameters": [
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAutomationWebAutomationSessioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp (200701 => 200702)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp 2016-05-11 20:54:09 UTC (rev 200701)
+++ trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp 2016-05-11 20:57:08 UTC (rev 200702)
</span><span class="lines">@@ -31,6 +31,7 @@
</span><span class="cx"> #include "WebAutomationSessionMessages.h"
</span><span class="cx"> #include "WebAutomationSessionProxyMessages.h"
</span><span class="cx"> #include "WebCookieManagerProxy.h"
</span><ins>+#include "WebInspectorProxy.h"
</ins><span class="cx"> #include "WebProcessPool.h"
</span><span class="cx"> #include <JavaScriptCore/InspectorBackendDispatcher.h>
</span><span class="cx"> #include <JavaScriptCore/InspectorFrontendRouter.h>
</span><span class="lines">@@ -432,12 +433,34 @@
</span><span class="cx"> page->reload(reloadFromOrigin, contentBlockersEnabled);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void WebAutomationSession::inspectBrowsingContext(Inspector::ErrorString& errorString, const String& handle, Ref<InspectBrowsingContextCallback>&& callback)
+{
+ WebPageProxy* page = webPageProxyForHandle(handle);
+ if (!page)
+ FAIL_WITH_PREDEFINED_ERROR(WindowNotFound);
+
+ if (auto callback = m_pendingInspectorCallbacksPerPage.take(page->pageID()))
+ callback->sendFailure(STRING_FOR_PREDEFINED_ERROR_NAME(Timeout));
+ m_pendingInspectorCallbacksPerPage.set(page->pageID(), WTFMove(callback));
+
+ // Don't bring the inspector to front since this may be done automatically.
+ // We just want it loaded so it can pause if a breakpoint is hit during a command.
+ if (page->inspector())
+ page->inspector()->connect();
+}
+
</ins><span class="cx"> void WebAutomationSession::navigationOccurredForPage(const WebPageProxy& page)
</span><span class="cx"> {
</span><span class="cx"> if (auto callback = m_pendingNavigationInBrowsingContextCallbacksPerPage.take(page.pageID()))
</span><span class="cx"> callback->sendSuccess(InspectorObject::create());
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void WebAutomationSession::inspectorFrontendLoaded(const WebPageProxy& page)
+{
+ if (auto callback = m_pendingInspectorCallbacksPerPage.take(page.pageID()))
+ callback->sendSuccess(InspectorObject::create());
+}
+
</ins><span class="cx"> void WebAutomationSession::evaluateJavaScriptFunction(Inspector::ErrorString& errorString, const String& browsingContextHandle, const String* optionalFrameHandle, const String& function, const Inspector::InspectorArray& arguments, const bool* optionalExpectsImplicitCallbackArgument, const int* optionalCallbackTimeout, Ref<EvaluateJavaScriptFunctionCallback>&& callback)
</span><span class="cx"> {
</span><span class="cx"> WebPageProxy* page = webPageProxyForHandle(browsingContextHandle);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAutomationWebAutomationSessionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h (200701 => 200702)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h 2016-05-11 20:54:09 UTC (rev 200701)
+++ trunk/Source/WebKit2/UIProcess/Automation/WebAutomationSession.h 2016-05-11 20:57:08 UTC (rev 200702)
</span><span class="lines">@@ -83,6 +83,7 @@
</span><span class="cx"> void setProcessPool(WebProcessPool*);
</span><span class="cx">
</span><span class="cx"> void navigationOccurredForPage(const WebPageProxy&);
</span><ins>+ void inspectorFrontendLoaded(const WebPageProxy&);
</ins><span class="cx">
</span><span class="cx"> #if ENABLE(REMOTE_INSPECTOR)
</span><span class="cx"> // Inspector::RemoteAutomationTarget API
</span><span class="lines">@@ -104,6 +105,7 @@
</span><span class="cx"> void goBackInBrowsingContext(Inspector::ErrorString&, const String&, Ref<GoBackInBrowsingContextCallback>&&) override;
</span><span class="cx"> void goForwardInBrowsingContext(Inspector::ErrorString&, const String&, Ref<GoForwardInBrowsingContextCallback>&&) override;
</span><span class="cx"> void reloadBrowsingContext(Inspector::ErrorString&, const String&, Ref<ReloadBrowsingContextCallback>&&) override;
</span><ins>+ void inspectBrowsingContext(Inspector::ErrorString&, const String&, Ref<InspectBrowsingContextCallback>&&) override;
</ins><span class="cx"> void evaluateJavaScriptFunction(Inspector::ErrorString&, const String& browsingContextHandle, const String* optionalFrameHandle, const String& function, const Inspector::InspectorArray& arguments, const bool* optionalExpectsImplicitCallbackArgument, const int* optionalCallbackTimeout, Ref<Inspector::AutomationBackendDispatcherHandler::EvaluateJavaScriptFunctionCallback>&&) override;
</span><span class="cx"> void performMouseInteraction(Inspector::ErrorString&, const String& handle, const Inspector::InspectorObject& requestedPosition, const String& mouseButton, const String& mouseInteraction, const Inspector::InspectorArray& keyModifiers, RefPtr<Inspector::Protocol::Automation::Point>& updatedPosition) override;
</span><span class="cx"> void performKeyboardInteractions(Inspector::ErrorString&, const String& handle, const Inspector::InspectorArray& interactions) override;
</span><span class="lines">@@ -176,6 +178,8 @@
</span><span class="cx">
</span><span class="cx"> HashMap<uint64_t, RefPtr<Inspector::BackendDispatcher::CallbackBase>> m_pendingNavigationInBrowsingContextCallbacksPerPage;
</span><span class="cx">
</span><ins>+ HashMap<uint64_t, RefPtr<Inspector::BackendDispatcher::CallbackBase>> m_pendingInspectorCallbacksPerPage;
+
</ins><span class="cx"> uint64_t m_nextEvaluateJavaScriptCallbackID { 1 };
</span><span class="cx"> HashMap<uint64_t, RefPtr<Inspector::AutomationBackendDispatcherHandler::EvaluateJavaScriptFunctionCallback>> m_evaluateJavaScriptFunctionCallbacks;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessCocoaWebAutomationSessionCocoamm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebAutomationSessionCocoa.mm (200701 => 200702)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/Cocoa/WebAutomationSessionCocoa.mm 2016-05-11 20:54:09 UTC (rev 200701)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebAutomationSessionCocoa.mm 2016-05-11 20:57:08 UTC (rev 200702)
</span><span class="lines">@@ -51,6 +51,10 @@
</span><span class="cx"> NSWindow *window = page.platformWindow();
</span><span class="cx">
</span><span class="cx"> for (NSEvent *event in eventsToSend) {
</span><ins>+ // Take focus back in case the Inspector became focused while the prior command or
+ // NSEvent was delivered to the window.
+ [window makeKeyAndOrderFront:nil];
+
</ins><span class="cx"> markEventAsSynthesizedForAutomation(event);
</span><span class="cx"> [window sendEvent:event];
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebInspectorProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (200701 => 200702)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2016-05-11 20:54:09 UTC (rev 200701)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2016-05-11 20:57:08 UTC (rev 200702)
</span><span class="lines">@@ -32,6 +32,7 @@
</span><span class="cx"> #include "WKArray.h"
</span><span class="cx"> #include "WKContextMenuItem.h"
</span><span class="cx"> #include "WKMutableArray.h"
</span><ins>+#include "WebAutomationSession.h"
</ins><span class="cx"> #include "WebFramePolicyListenerProxy.h"
</span><span class="cx"> #include "WebFrameProxy.h"
</span><span class="cx"> #include "WebInspectorMessages.h"
</span><span class="lines">@@ -601,6 +602,12 @@
</span><span class="cx"> platformDidClose();
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void WebInspectorProxy::frontendLoaded()
+{
+ if (auto* automationSession = m_inspectedPage->process().processPool().automationSession())
+ automationSession->inspectorFrontendLoaded(*m_inspectedPage);
+}
+
</ins><span class="cx"> void WebInspectorProxy::bringToFront()
</span><span class="cx"> {
</span><span class="cx"> // WebCore::InspectorFrontendClientLocal tells us to do this on load. We want to
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebInspectorProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h (200701 => 200702)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h 2016-05-11 20:54:09 UTC (rev 200701)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h 2016-05-11 20:57:08 UTC (rev 200702)
</span><span class="lines">@@ -190,6 +190,7 @@
</span><span class="cx">
</span><span class="cx"> // Called by WebInspectorProxy messages
</span><span class="cx"> void createInspectorPage(IPC::Attachment, bool canAttach, bool underTest);
</span><ins>+ void frontendLoaded();
</ins><span class="cx"> void didClose();
</span><span class="cx"> void bringToFront();
</span><span class="cx"> void attachAvailabilityChanged(bool);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebInspectorProxymessagesin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in (200701 => 200702)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in 2016-05-11 20:54:09 UTC (rev 200701)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in 2016-05-11 20:57:08 UTC (rev 200702)
</span><span class="lines">@@ -23,6 +23,7 @@
</span><span class="cx"> messages -> WebInspectorProxy {
</span><span class="cx"> CreateInspectorPage(IPC::Attachment connectionIdentifier, bool canAttach, bool underTest)
</span><span class="cx">
</span><ins>+ FrontendLoaded()
</ins><span class="cx"> DidClose()
</span><span class="cx"> BringToFront()
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebInspectorUIcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp (200701 => 200702)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2016-05-11 20:54:09 UTC (rev 200701)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2016-05-11 20:57:08 UTC (rev 200702)
</span><span class="lines">@@ -96,6 +96,8 @@
</span><span class="cx"> setDockingUnavailable(m_dockingUnavailable);
</span><span class="cx"> setDockSide(m_dockSide);
</span><span class="cx">
</span><ins>+ WebProcess::singleton().parentProcessConnection()->send(Messages::WebInspectorProxy::FrontendLoaded(), m_inspectedPageIdentifier);
+
</ins><span class="cx"> bringToFront();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -128,6 +130,9 @@
</span><span class="cx"> m_frontendController->setInspectorFrontendClient(nullptr);
</span><span class="cx"> m_frontendController = nullptr;
</span><span class="cx">
</span><ins>+ if (m_frontendHost)
+ m_frontendHost->disconnectClient();
+
</ins><span class="cx"> m_inspectedPageIdentifier = 0;
</span><span class="cx"> m_underTest = false;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>