<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200665] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200665">200665</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-05-10 18:55:47 -0700 (Tue, 10 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Horizontally-scrollable items with a 3d transform are rendered incorrectly in RTL when container has -webkit-overflow-scroll: touch
https://bugs.webkit.org/show_bug.cgi?id=157482
rdar://problem/26204794
Reviewed by Zalan Bujtas.
Source/WebCore:
The compositing code was confused about scroll offsets vs. scroll positions, because
of the badly named scrolledContentOffset(); we used that in one place, and scrollOffset()
lower down. Change both to use scrollOffset().
Test: compositing/rtl/rtl-with-transformed-descendants.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
LayoutTests:
This can't be a ref test because on iOS ref test snapshots are doing by drawing, not by snapshotting layers.
* compositing/rtl/rtl-with-transformed-descendants-expected.txt: Added.
* compositing/rtl/rtl-with-transformed-descendants.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderLayerBackingcpp">trunk/Source/WebCore/rendering/RenderLayerBacking.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestscompositingrtlrtlscrollingwithtransformeddescendantsexpectedtxt">trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt</a></li>
<li><a href="#trunkLayoutTestscompositingrtlrtlscrollingwithtransformeddescendantshtml">trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html</a></li>
<li>trunk/LayoutTests/platform/ios-simulator/compositing/rtl/</li>
<li><a href="#trunkLayoutTestsplatformiossimulatorcompositingrtlrtlscrollingwithtransformeddescendantsexpectedtxt">trunk/LayoutTests/platform/ios-simulator/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorwk1compositingrtlrtlscrollingwithtransformeddescendantsexpectedtxt">trunk/LayoutTests/platform/ios-simulator-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (200664 => 200665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-05-11 01:55:42 UTC (rev 200664)
+++ trunk/LayoutTests/ChangeLog 2016-05-11 01:55:47 UTC (rev 200665)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-05-10 Simon Fraser <simon.fraser@apple.com>
+
+ Horizontally-scrollable items with a 3d transform are rendered incorrectly in RTL when container has -webkit-overflow-scroll: touch
+ https://bugs.webkit.org/show_bug.cgi?id=157482
+ rdar://problem/26204794
+
+ Reviewed by Zalan Bujtas.
+
+ This can't be a ref test because on iOS ref test snapshots are doing by drawing, not by snapshotting layers.
+
+ * compositing/rtl/rtl-with-transformed-descendants-expected.txt: Added.
+ * compositing/rtl/rtl-with-transformed-descendants.html: Added.
+
</ins><span class="cx"> 2016-05-10 Hunseop Jeong <hs85.jeong@samsung.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed EFL Gardening on 10th May.
</span></span></pre></div>
<a id="trunkLayoutTestscompositingrtlrtlscrollingwithtransformeddescendantsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (0 => 200665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt 2016-05-11 01:55:47 UTC (rev 200665)
</span><span class="lines">@@ -0,0 +1,26 @@
</span><ins>+
+(GraphicsLayer
+ (anchor 0.00 0.00)
+ (bounds 800.00 600.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 800.00 600.00)
+ (contentsOpaque 1)
+ (children 1
+ (GraphicsLayer
+ (position 10.00 10.00)
+ (bounds 400.00 204.00)
+ (children 1
+ (GraphicsLayer
+ (position 96.00 0.00)
+ (anchor 0.00 0.00)
+ (bounds 150.00 200.00)
+ (contentsOpaque 1)
+ )
+ )
+ )
+ )
+ )
+ )
+)
+
</ins></span></pre></div>
<a id="trunkLayoutTestscompositingrtlrtlscrollingwithtransformeddescendantshtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html (0 => 200665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html (rev 0)
+++ trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html 2016-05-11 01:55:47 UTC (rev 200665)
</span><span class="lines">@@ -0,0 +1,47 @@
</span><ins>+<html>
+ <head>
+ <style type="text/css">
+ #scroller {
+ overflow-x: auto;
+ width: 400px;
+ white-space: nowrap;
+ -webkit-overflow-scrolling: touch;
+ border: 2px solid black;
+ }
+
+ .tile {
+ position: relative;
+ width: 150px;
+ height: 200px;
+ background-color: silver;
+ display: inline-block;
+ }
+
+ .translated {
+ background-color: green;
+ transform: translateZ(0);
+ transform-origin: top left;
+ }
+ </style>
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ function dumpLayers()
+ {
+ document.getElementById('layertree').textContent = window.internals.layerTreeAsText(document);
+ }
+ window.addEventListener('load', dumpLayers, false);
+ </script>
+ </head>
+ <body>
+ <div id="scroller" dir="rtl">
+ <div class="tile"></div>
+ <div class="translated tile"></div>
+ <div class="tile"></div>
+ <div class="tile"></div>
+ <div class="tile"></div>
+ </div>
+ <pre id="layertree"></pre>
+ </body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorcompositingrtlrtlscrollingwithtransformeddescendantsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/ios-simulator/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (0 => 200665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt 2016-05-11 01:55:47 UTC (rev 200665)
</span><span class="lines">@@ -0,0 +1,40 @@
</span><ins>+
+(GraphicsLayer
+ (anchor 0.00 0.00)
+ (bounds 800.00 600.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 800.00 600.00)
+ (contentsOpaque 1)
+ (children 1
+ (GraphicsLayer
+ (position 8.00 8.00)
+ (bounds 404.00 209.00)
+ (drawsContent 1)
+ (children 1
+ (GraphicsLayer
+ (position 2.00 2.00)
+ (bounds origin 366.00 0.00)
+ (bounds 400.00 205.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 766.00 205.00)
+ (drawsContent 1)
+ (children 1
+ (GraphicsLayer
+ (position 462.00 0.00)
+ (anchor 0.00 0.00)
+ (bounds 150.00 200.00)
+ (contentsOpaque 1)
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+)
+
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorwk1compositingrtlrtlscrollingwithtransformeddescendantsexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/platform/ios-simulator-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (0 => 200665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios-simulator-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt 2016-05-11 01:55:47 UTC (rev 200665)
</span><span class="lines">@@ -0,0 +1,39 @@
</span><ins>+
+(GraphicsLayer
+ (anchor 0.00 0.00)
+ (bounds 800.00 600.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 800.00 600.00)
+ (children 1
+ (GraphicsLayer
+ (position 8.00 8.00)
+ (bounds 404.00 209.00)
+ (drawsContent 1)
+ (children 1
+ (GraphicsLayer
+ (position 2.00 2.00)
+ (bounds origin 366.00 0.00)
+ (bounds 400.00 205.00)
+ (children 1
+ (GraphicsLayer
+ (bounds 766.00 205.00)
+ (drawsContent 1)
+ (children 1
+ (GraphicsLayer
+ (position 462.00 0.00)
+ (anchor 0.00 0.00)
+ (bounds 150.00 200.00)
+ (contentsOpaque 1)
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+ )
+)
+
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (200664 => 200665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-11 01:55:42 UTC (rev 200664)
+++ trunk/Source/WebCore/ChangeLog 2016-05-11 01:55:47 UTC (rev 200665)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-05-10 Simon Fraser <simon.fraser@apple.com>
+
+ Horizontally-scrollable items with a 3d transform are rendered incorrectly in RTL when container has -webkit-overflow-scroll: touch
+ https://bugs.webkit.org/show_bug.cgi?id=157482
+ rdar://problem/26204794
+
+ Reviewed by Zalan Bujtas.
+
+ The compositing code was confused about scroll offsets vs. scroll positions, because
+ of the badly named scrolledContentOffset(); we used that in one place, and scrollOffset()
+ lower down. Change both to use scrollOffset().
+
+ Test: compositing/rtl/rtl-with-transformed-descendants.html
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGeometry):
+
</ins><span class="cx"> 2016-05-10 Enrica Casucci <enrica@apple.com>
</span><span class="cx">
</span><span class="cx"> Numerous block selection issues on iOS.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderLayerBackingcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (200664 => 200665)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2016-05-11 01:55:42 UTC (rev 200664)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2016-05-11 01:55:47 UTC (rev 200665)
</span><span class="lines">@@ -815,9 +815,9 @@
</span><span class="cx"> renderBox.width() - renderBox.borderLeft() - renderBox.borderRight(),
</span><span class="cx"> renderBox.height() - renderBox.borderTop() - renderBox.borderBottom());
</span><span class="cx">
</span><del>- IntSize scrollOffset = compAncestor->scrolledContentOffset();
</del><ins>+ ScrollOffset scrollOffset = compAncestor->scrollOffset();
</ins><span class="cx"> // FIXME: pixel snap the padding box.
</span><del>- graphicsLayerParentLocation = paddingBox.location() - scrollOffset;
</del><ins>+ graphicsLayerParentLocation = paddingBox.location() - toLayoutSize(scrollOffset);
</ins><span class="cx"> }
</span><span class="cx"> #else
</span><span class="cx"> if (compAncestor && compAncestor->needsCompositedScrolling()) {
</span></span></pre>
</div>
</div>
</body>
</html>