<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200626] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200626">200626</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-05-10 10:23:09 -0700 (Tue, 10 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Get rid of a lot of calls to RefPtr::release()
https://bugs.webkit.org/show_bug.cgi?id=157505
Reviewed by Alex Christensen.
Get rid of a lot of calls to RefPtr::release() and use WTFMove() instead.
Source/WebCore:
* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::addKeyTimerFired):
(WebCore::MediaKeySession::sendMessage):
(WebCore::MediaKeySession::sendError):
* Modules/geolocation/Geolocation.cpp:
(WebCore::createGeoposition):
* Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::disconnectFrameForDocumentSuspension):
(WebCore::DOMWindowIndexedDatabase::reconnectFrameFromDocumentSuspension):
* Modules/indexeddb/IDBKey.h:
(WebCore::IDBKey::createMultiEntryArray):
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::scheduleEvent):
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::scheduleEvent):
* Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::scheduleEvent):
* Modules/notifications/DOMWindowNotifications.cpp:
(WebCore::DOMWindowNotifications::disconnectFrameForDocumentSuspension):
(WebCore::DOMWindowNotifications::reconnectFrameFromDocumentSuspension):
* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabaseBackend):
* Modules/webdatabase/DatabaseManager.h:
* Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::unwrap):
* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::enqueueRawFrame):
(WebCore::WebSocketChannel::enqueueBlobFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
* bindings/js/JSBlobCustom.cpp:
(WebCore::constructJSBlob):
* bindings/js/JSGeolocationCustom.cpp:
(WebCore::createPositionOptions):
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::fillMessagePortArray):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::createScriptInstanceForWidget):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
* crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::generatePair):
* css/CSSBasicShapes.cpp:
(WebCore::buildSerializablePositionOffset):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImageRepeat):
(WebCore::counterToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSContentDistributionValue.cpp:
(WebCore::CSSContentDistributionValue::customCSSText):
* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
* css/CSSFilterImageValue.h:
* css/CSSGrammar.y.in:
* css/CSSNamedImageValue.cpp:
(WebCore::CSSNamedImageValue::image):
* css/CSSNamedImageValue.h:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseInsetRoundedCorners):
(WebCore::ShadowParseContext::commitLength):
(WebCore::CSSParser::parseShadow):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseCounter):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseDeprecatedLinearGradient):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseTransformValue):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseTextIndent):
(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::createViewportRule):
* css/CSSParser.h:
* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
* css/CSSParserValues.h:
* css/CSSValueList.cpp:
(WebCore::CSSValueList::copy):
* css/CSSValueList.h:
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::svgPropertyValue):
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertClipPath):
(WebCore::StyleBuilderConverter::convertReflection):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
* css/StyleResolver.h:
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::createCSSOMWrapper):
* css/StyleRule.h:
* dom/Attr.cpp:
(WebCore::Attr::create):
* dom/Attr.h:
* dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::nextNode):
* dom/Document.cpp:
(WebCore::Document::setFocusedElement):
(WebCore::Document::takeDOMWindowFrom):
(WebCore::Document::updateHoverActiveState):
* dom/Element.cpp:
(WebCore::Element::detachAttribute):
(WebCore::Element::setAttributeNodeNS):
(WebCore::Element::ensureAttr):
* dom/Element.h:
* dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::entanglePorts):
* dom/NodeIterator.cpp:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
* dom/Range.cpp:
(WebCore::Range::processContentsBetweenOffsets):
* dom/StyledElement.cpp:
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::createBlockElement):
* editing/ApplyBlockElementCommand.h:
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::applyCommandToComposite):
(WebCore::CompositeEditCommand::appendBlockPlaceholder):
(WebCore::CompositeEditCommand::insertBlockPlaceholder):
(WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
(WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
(WebCore::CompositeEditCommand::moveParagraphs):
* editing/CompositeEditCommand.h:
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::wrappingStyleForSerialization):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::extractPropertiesNotIn):
(WebCore::backgroundColorInEffect):
* editing/EditingStyle.h:
* editing/Editor.cpp:
(WebCore::Editor::increaseSelectionListLevel):
(WebCore::Editor::increaseSelectionListLevelOrdered):
(WebCore::Editor::increaseSelectionListLevelUnordered):
(WebCore::Editor::findStringAndScrollToVisible):
(WebCore::Editor::rangeOfString):
* editing/Editor.h:
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
* editing/InsertParagraphSeparatorCommand.h:
* editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doUnapply):
* editing/ModifySelectionListLevel.cpp:
(WebCore::IncreaseSelectionListLevelCommand::doApply):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
* editing/ModifySelectionListLevel.h:
* editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doUnapply):
* editing/RemoveNodePreservingChildrenCommand.cpp:
(WebCore::RemoveNodePreservingChildrenCommand::doApply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
* editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionCommand::doApply):
* editing/mac/DictionaryLookup.h:
* editing/mac/DictionaryLookup.mm:
(WebCore::DictionaryLookup::rangeForSelection):
(WebCore::DictionaryLookup::rangeAtHitTestResult):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::finishRequestAutocomplete):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::scheduleEvent):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent):
* html/HTMLMediaElement.h:
* html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::createVertexArrayOES):
* html/canvas/OESVertexArrayObject.h:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getContextAttributes):
* html/canvas/WebGLRenderingContextBase.h:
* html/track/VTTCue.cpp:
(WebCore::VTTCue::getCueAsHTML):
(WebCore::VTTCue::createCueRenderingTree):
* html/track/VTTCue.h:
* html/track/WebVTTElement.cpp:
(WebCore::WebVTTElement::createEquivalentHTMLElement):
* html/track/WebVTTElement.h:
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTTreeBuilder::buildFromString):
(WebCore::WebVTTParser::createDocumentFragmentFromCueText):
* html/track/WebVTTParser.h:
Source/WTF:
* wtf/text/AtomicStringImpl.cpp:
(WTF::HashAndUTF8CharactersTranslator::translate):
* wtf/text/CString.cpp:
(WTF::CString::copyBufferIfNeeded):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::allocateBufferUpConvert):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/WTFString.cpp:
(WTF::String::append):
(WTF::String::insert):
(WTF::String::removeInternal):
* wtf/text/WTFString.h:
(WTF::String::String):
(WTF::String::operator=):
(WTF::String::releaseImpl):
(WTF::String::isNull): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWTFChangeLog">trunk/Source/WTF/ChangeLog</a></li>
<li><a href="#trunkSourceWTFwtftextAtomicStringImplcpp">trunk/Source/WTF/wtf/text/AtomicStringImpl.cpp</a></li>
<li><a href="#trunkSourceWTFwtftextCStringcpp">trunk/Source/WTF/wtf/text/CString.cpp</a></li>
<li><a href="#trunkSourceWTFwtftextStringBuildercpp">trunk/Source/WTF/wtf/text/StringBuilder.cpp</a></li>
<li><a href="#trunkSourceWTFwtftextWTFStringcpp">trunk/Source/WTF/wtf/text/WTFString.cpp</a></li>
<li><a href="#trunkSourceWTFwtftextWTFStringh">trunk/Source/WTF/wtf/text/WTFString.h</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesencryptedmediaMediaKeySessioncpp">trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesgeolocationGeolocationcpp">trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbDOMWindowIndexedDatabasecpp">trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbIDBKeyh">trunk/Source/WebCore/Modules/indexeddb/IDBKey.h</a></li>
<li><a href="#trunkSourceWebCoreModulesmediasourceMediaSourcecpp">trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediasourceSourceBuffercpp">trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesmediasourceSourceBufferListcpp">trunk/Source/WebCore/Modules/mediasource/SourceBufferList.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesnotificationsDOMWindowNotificationscpp">trunk/Source/WebCore/Modules/notifications/DOMWindowNotifications.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseManagercpp">trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseManagerh">trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLCallbackWrapperh">trunk/Source/WebCore/Modules/webdatabase/SQLCallbackWrapper.h</a></li>
<li><a href="#trunkSourceWebCoreModuleswebsocketsWebSocketChannelcpp">trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSBlobCustomcpp">trunk/Source/WebCore/bindings/js/JSBlobCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSGeolocationCustomcpp">trunk/Source/WebCore/bindings/js/JSGeolocationCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSMessagePortCustomcpp">trunk/Source/WebCore/bindings/js/JSMessagePortCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSSQLTransactionCustomcpp">trunk/Source/WebCore/bindings/js/JSSQLTransactionCustom.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsjsScriptControllerMacmm">trunk/Source/WebCore/bindings/js/ScriptControllerMac.mm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorecryptomacCryptoKeyRSAMaccpp">trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSBasicShapescpp">trunk/Source/WebCore/css/CSSBasicShapes.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSComputedStyleDeclarationcpp">trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSContentDistributionValuecpp">trunk/Source/WebCore/css/CSSContentDistributionValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSFilterImageValuecpp">trunk/Source/WebCore/css/CSSFilterImageValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSFilterImageValueh">trunk/Source/WebCore/css/CSSFilterImageValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSGrammaryin">trunk/Source/WebCore/css/CSSGrammar.y.in</a></li>
<li><a href="#trunkSourceWebCorecssCSSNamedImageValuecpp">trunk/Source/WebCore/css/CSSNamedImageValue.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSNamedImageValueh">trunk/Source/WebCore/css/CSSNamedImageValue.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSParsercpp">trunk/Source/WebCore/css/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSParserh">trunk/Source/WebCore/css/CSSParser.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSParserValuescpp">trunk/Source/WebCore/css/CSSParserValues.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSParserValuesh">trunk/Source/WebCore/css/CSSParserValues.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSValueListcpp">trunk/Source/WebCore/css/CSSValueList.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSValueListh">trunk/Source/WebCore/css/CSSValueList.h</a></li>
<li><a href="#trunkSourceWebCorecssSVGCSSComputedStyleDeclarationcpp">trunk/Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStyleBuilderConverterh">trunk/Source/WebCore/css/StyleBuilderConverter.h</a></li>
<li><a href="#trunkSourceWebCorecssStyleResolvercpp">trunk/Source/WebCore/css/StyleResolver.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStyleResolverh">trunk/Source/WebCore/css/StyleResolver.h</a></li>
<li><a href="#trunkSourceWebCorecssStyleRulecpp">trunk/Source/WebCore/css/StyleRule.cpp</a></li>
<li><a href="#trunkSourceWebCorecssStyleRuleh">trunk/Source/WebCore/css/StyleRule.h</a></li>
<li><a href="#trunkSourceWebCoredomAttrcpp">trunk/Source/WebCore/dom/Attr.cpp</a></li>
<li><a href="#trunkSourceWebCoredomAttrh">trunk/Source/WebCore/dom/Attr.h</a></li>
<li><a href="#trunkSourceWebCoredomContainerNodeh">trunk/Source/WebCore/dom/ContainerNode.h</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>
<li><a href="#trunkSourceWebCoredomMessagePortcpp">trunk/Source/WebCore/dom/MessagePort.cpp</a></li>
<li><a href="#trunkSourceWebCoredomNodeIteratorcpp">trunk/Source/WebCore/dom/NodeIterator.cpp</a></li>
<li><a href="#trunkSourceWebCoredomRangecpp">trunk/Source/WebCore/dom/Range.cpp</a></li>
<li><a href="#trunkSourceWebCoredomStyledElementcpp">trunk/Source/WebCore/dom/StyledElement.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingApplyBlockElementCommandcpp">trunk/Source/WebCore/editing/ApplyBlockElementCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingApplyBlockElementCommandh">trunk/Source/WebCore/editing/ApplyBlockElementCommand.h</a></li>
<li><a href="#trunkSourceWebCoreeditingApplyStyleCommandcpp">trunk/Source/WebCore/editing/ApplyStyleCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingCompositeEditCommandcpp">trunk/Source/WebCore/editing/CompositeEditCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingCompositeEditCommandh">trunk/Source/WebCore/editing/CompositeEditCommand.h</a></li>
<li><a href="#trunkSourceWebCoreeditingEditingStylecpp">trunk/Source/WebCore/editing/EditingStyle.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingEditingStyleh">trunk/Source/WebCore/editing/EditingStyle.h</a></li>
<li><a href="#trunkSourceWebCoreeditingEditorcpp">trunk/Source/WebCore/editing/Editor.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingEditorh">trunk/Source/WebCore/editing/Editor.h</a></li>
<li><a href="#trunkSourceWebCoreeditingInsertParagraphSeparatorCommandcpp">trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingInsertParagraphSeparatorCommandh">trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.h</a></li>
<li><a href="#trunkSourceWebCoreeditingMergeIdenticalElementsCommandcpp">trunk/Source/WebCore/editing/MergeIdenticalElementsCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingModifySelectionListLevelcpp">trunk/Source/WebCore/editing/ModifySelectionListLevel.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingModifySelectionListLevelh">trunk/Source/WebCore/editing/ModifySelectionListLevel.h</a></li>
<li><a href="#trunkSourceWebCoreeditingRemoveNodeCommandcpp">trunk/Source/WebCore/editing/RemoveNodeCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingRemoveNodePreservingChildrenCommandcpp">trunk/Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingReplaceSelectionCommandcpp">trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingSpellingCorrectionCommandcpp">trunk/Source/WebCore/editing/SpellingCorrectionCommand.cpp</a></li>
<li><a href="#trunkSourceWebCoreeditingmacDictionaryLookuph">trunk/Source/WebCore/editing/mac/DictionaryLookup.h</a></li>
<li><a href="#trunkSourceWebCoreeditingmacDictionaryLookupmm">trunk/Source/WebCore/editing/mac/DictionaryLookup.mm</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLFormElementcpp">trunk/Source/WebCore/html/HTMLFormElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementcpp">trunk/Source/WebCore/html/HTMLMediaElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementh">trunk/Source/WebCore/html/HTMLMediaElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasOESVertexArrayObjectcpp">trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasOESVertexArrayObjecth">trunk/Source/WebCore/html/canvas/OESVertexArrayObject.h</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLRenderingContextBasecpp">trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlcanvasWebGLRenderingContextBaseh">trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVTTCuecpp">trunk/Source/WebCore/html/track/VTTCue.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackVTTCueh">trunk/Source/WebCore/html/track/VTTCue.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackWebVTTElementcpp">trunk/Source/WebCore/html/track/WebVTTElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackWebVTTElementh">trunk/Source/WebCore/html/track/WebVTTElement.h</a></li>
<li><a href="#trunkSourceWebCorehtmltrackWebVTTParsercpp">trunk/Source/WebCore/html/track/WebVTTParser.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmltrackWebVTTParserh">trunk/Source/WebCore/html/track/WebVTTParser.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWTFChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/ChangeLog (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/ChangeLog 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WTF/ChangeLog 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -1,3 +1,30 @@
</span><ins>+2016-05-10 Chris Dumez <cdumez@apple.com>
+
+ Get rid of a lot of calls to RefPtr::release()
+ https://bugs.webkit.org/show_bug.cgi?id=157505
+
+ Reviewed by Alex Christensen.
+
+ Get rid of a lot of calls to RefPtr::release() and use WTFMove() instead.
+
+ * wtf/text/AtomicStringImpl.cpp:
+ (WTF::HashAndUTF8CharactersTranslator::translate):
+ * wtf/text/CString.cpp:
+ (WTF::CString::copyBufferIfNeeded):
+ * wtf/text/StringBuilder.cpp:
+ (WTF::StringBuilder::allocateBuffer):
+ (WTF::StringBuilder::allocateBufferUpConvert):
+ (WTF::StringBuilder::shrinkToFit):
+ * wtf/text/WTFString.cpp:
+ (WTF::String::append):
+ (WTF::String::insert):
+ (WTF::String::removeInternal):
+ * wtf/text/WTFString.h:
+ (WTF::String::String):
+ (WTF::String::operator=):
+ (WTF::String::releaseImpl):
+ (WTF::String::isNull): Deleted.
+
</ins><span class="cx"> 2016-05-08 Chris Dumez <cdumez@apple.com>
</span><span class="cx">
</span><span class="cx"> [COCOA] Disable HAVE_DTRACE at build time
</span></span></pre></div>
<a id="trunkSourceWTFwtftextAtomicStringImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/AtomicStringImpl.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/AtomicStringImpl.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WTF/wtf/text/AtomicStringImpl.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -229,7 +229,7 @@
</span><span class="cx"> if (isAllASCII)
</span><span class="cx"> newString = StringImpl::create(buffer.characters, buffer.length);
</span><span class="cx">
</span><del>- location = newString.release().leakRef();
</del><ins>+ location = newString.leakRef();
</ins><span class="cx"> location->setHash(hash);
</span><span class="cx"> location->setIsAtomic(true);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWTFwtftextCStringcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/CString.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/CString.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WTF/wtf/text/CString.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -92,7 +92,7 @@
</span><span class="cx"> if (!m_buffer || m_buffer->hasOneRef())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- RefPtr<CStringBuffer> buffer = m_buffer.release();
</del><ins>+ RefPtr<CStringBuffer> buffer = WTFMove(m_buffer);
</ins><span class="cx"> size_t length = buffer->length();
</span><span class="cx"> m_buffer = CStringBuffer::createUninitialized(length);
</span><span class="cx"> memcpy(m_buffer->mutableData(), buffer->data(), length + 1);
</span></span></pre></div>
<a id="trunkSourceWTFwtftextStringBuildercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/StringBuilder.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/StringBuilder.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WTF/wtf/text/StringBuilder.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -97,11 +97,11 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_is8Bit);
</span><span class="cx"> // Copy the existing data into a new buffer, set result to point to the end of the existing data.
</span><del>- RefPtr<StringImpl> buffer = StringImpl::createUninitialized(requiredLength, m_bufferCharacters8);
</del><ins>+ auto buffer = StringImpl::createUninitialized(requiredLength, m_bufferCharacters8);
</ins><span class="cx"> memcpy(m_bufferCharacters8, currentCharacters, static_cast<size_t>(m_length) * sizeof(LChar)); // This can't overflow.
</span><span class="cx">
</span><span class="cx"> // Update the builder state.
</span><del>- m_buffer = buffer.release();
</del><ins>+ m_buffer = WTFMove(buffer);
</ins><span class="cx"> m_string = String();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -111,11 +111,11 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(!m_is8Bit);
</span><span class="cx"> // Copy the existing data into a new buffer, set result to point to the end of the existing data.
</span><del>- RefPtr<StringImpl> buffer = StringImpl::createUninitialized(requiredLength, m_bufferCharacters16);
</del><ins>+ auto buffer = StringImpl::createUninitialized(requiredLength, m_bufferCharacters16);
</ins><span class="cx"> memcpy(m_bufferCharacters16, currentCharacters, static_cast<size_t>(m_length) * sizeof(UChar)); // This can't overflow.
</span><span class="cx">
</span><span class="cx"> // Update the builder state.
</span><del>- m_buffer = buffer.release();
</del><ins>+ m_buffer = WTFMove(buffer);
</ins><span class="cx"> m_string = String();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -125,14 +125,14 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(m_is8Bit);
</span><span class="cx"> // Copy the existing data into a new buffer, set result to point to the end of the existing data.
</span><del>- RefPtr<StringImpl> buffer = StringImpl::createUninitialized(requiredLength, m_bufferCharacters16);
</del><ins>+ auto buffer = StringImpl::createUninitialized(requiredLength, m_bufferCharacters16);
</ins><span class="cx"> for (unsigned i = 0; i < m_length; ++i)
</span><span class="cx"> m_bufferCharacters16[i] = currentCharacters[i];
</span><span class="cx">
</span><span class="cx"> m_is8Bit = false;
</span><span class="cx">
</span><span class="cx"> // Update the builder state.
</span><del>- m_buffer = buffer.release();
</del><ins>+ m_buffer = WTFMove(buffer);
</ins><span class="cx"> m_string = String();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -357,7 +357,7 @@
</span><span class="cx"> reallocateBuffer<LChar>(m_length);
</span><span class="cx"> else
</span><span class="cx"> reallocateBuffer<UChar>(m_length);
</span><del>- m_string = m_buffer.release();
</del><ins>+ m_string = WTFMove(m_buffer);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWTFwtftextWTFStringcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/WTFString.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/WTFString.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WTF/wtf/text/WTFString.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -100,19 +100,19 @@
</span><span class="cx"> LChar* data;
</span><span class="cx"> if (str.length() > std::numeric_limits<unsigned>::max() - m_impl->length())
</span><span class="cx"> CRASH();
</span><del>- RefPtr<StringImpl> newImpl = StringImpl::createUninitialized(m_impl->length() + str.length(), data);
</del><ins>+ auto newImpl = StringImpl::createUninitialized(m_impl->length() + str.length(), data);
</ins><span class="cx"> memcpy(data, m_impl->characters8(), m_impl->length() * sizeof(LChar));
</span><span class="cx"> memcpy(data + m_impl->length(), str.characters8(), str.length() * sizeof(LChar));
</span><del>- m_impl = newImpl.release();
</del><ins>+ m_impl = WTFMove(newImpl);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> UChar* data;
</span><span class="cx"> if (str.length() > std::numeric_limits<unsigned>::max() - m_impl->length())
</span><span class="cx"> CRASH();
</span><del>- RefPtr<StringImpl> newImpl = StringImpl::createUninitialized(m_impl->length() + str.length(), data);
</del><ins>+ auto newImpl = StringImpl::createUninitialized(m_impl->length() + str.length(), data);
</ins><span class="cx"> StringView(*m_impl).getCharactersWithUpconvert(data);
</span><span class="cx"> StringView(str).getCharactersWithUpconvert(data + m_impl->length());
</span><del>- m_impl = newImpl.release();
</del><ins>+ m_impl = WTFMove(newImpl);
</ins><span class="cx"> } else
</span><span class="cx"> m_impl = str.m_impl;
</span><span class="cx"> }
</span><span class="lines">@@ -133,10 +133,10 @@
</span><span class="cx"> if (m_impl->length() >= std::numeric_limits<unsigned>::max())
</span><span class="cx"> CRASH();
</span><span class="cx"> LChar* data;
</span><del>- RefPtr<StringImpl> newImpl = StringImpl::createUninitialized(m_impl->length() + 1, data);
</del><ins>+ auto newImpl = StringImpl::createUninitialized(m_impl->length() + 1, data);
</ins><span class="cx"> memcpy(data, m_impl->characters8(), m_impl->length());
</span><span class="cx"> data[m_impl->length()] = character;
</span><del>- m_impl = newImpl.release();
</del><ins>+ m_impl = WTFMove(newImpl);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void String::append(UChar character)
</span><span class="lines">@@ -154,10 +154,10 @@
</span><span class="cx"> if (m_impl->length() >= std::numeric_limits<unsigned>::max())
</span><span class="cx"> CRASH();
</span><span class="cx"> UChar* data;
</span><del>- RefPtr<StringImpl> newImpl = StringImpl::createUninitialized(m_impl->length() + 1, data);
</del><ins>+ auto newImpl = StringImpl::createUninitialized(m_impl->length() + 1, data);
</ins><span class="cx"> StringView(*m_impl).getCharactersWithUpconvert(data);
</span><span class="cx"> data[m_impl->length()] = character;
</span><del>- m_impl = newImpl.release();
</del><ins>+ m_impl = WTFMove(newImpl);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> int codePointCompare(const String& a, const String& b)
</span><span class="lines">@@ -187,21 +187,21 @@
</span><span class="cx"> if (lengthToInsert > std::numeric_limits<unsigned>::max() - length())
</span><span class="cx"> CRASH();
</span><span class="cx">
</span><del>- RefPtr<StringImpl> newString;
</del><span class="cx"> if (is8Bit() && string.is8Bit()) {
</span><span class="cx"> LChar* data;
</span><del>- newString = StringImpl::createUninitialized(length() + lengthToInsert, data);
</del><ins>+ auto newString = StringImpl::createUninitialized(length() + lengthToInsert, data);
</ins><span class="cx"> StringView(*m_impl).substring(0, position).getCharactersWithUpconvert(data);
</span><span class="cx"> StringView(string).getCharactersWithUpconvert(data + position);
</span><span class="cx"> StringView(*m_impl).substring(position).getCharactersWithUpconvert(data + position + lengthToInsert);
</span><ins>+ m_impl = WTFMove(newString);
</ins><span class="cx"> } else {
</span><span class="cx"> UChar* data;
</span><del>- newString = StringImpl::createUninitialized(length() + lengthToInsert, data);
</del><ins>+ auto newString = StringImpl::createUninitialized(length() + lengthToInsert, data);
</ins><span class="cx"> StringView(*m_impl).substring(0, position).getCharactersWithUpconvert(data);
</span><span class="cx"> StringView(string).getCharactersWithUpconvert(data + position);
</span><span class="cx"> StringView(*m_impl).substring(position).getCharactersWithUpconvert(data + position + lengthToInsert);
</span><ins>+ m_impl = WTFMove(newString);
</ins><span class="cx"> }
</span><del>- m_impl = newString.release();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void String::append(const LChar* charactersToAppend, unsigned lengthToAppend)
</span><span class="lines">@@ -226,20 +226,20 @@
</span><span class="cx"> if (lengthToAppend > std::numeric_limits<unsigned>::max() - strLength)
</span><span class="cx"> CRASH();
</span><span class="cx"> LChar* data;
</span><del>- RefPtr<StringImpl> newImpl = StringImpl::createUninitialized(strLength + lengthToAppend, data);
</del><ins>+ auto newImpl = StringImpl::createUninitialized(strLength + lengthToAppend, data);
</ins><span class="cx"> StringImpl::copyChars(data, m_impl->characters8(), strLength);
</span><span class="cx"> StringImpl::copyChars(data + strLength, charactersToAppend, lengthToAppend);
</span><del>- m_impl = newImpl.release();
</del><ins>+ m_impl = WTFMove(newImpl);
</ins><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (lengthToAppend > std::numeric_limits<unsigned>::max() - strLength)
</span><span class="cx"> CRASH();
</span><span class="cx"> UChar* data;
</span><del>- RefPtr<StringImpl> newImpl = StringImpl::createUninitialized(length() + lengthToAppend, data);
</del><ins>+ auto newImpl = StringImpl::createUninitialized(length() + lengthToAppend, data);
</ins><span class="cx"> StringImpl::copyChars(data, m_impl->characters16(), strLength);
</span><span class="cx"> StringImpl::copyChars(data + strLength, charactersToAppend, lengthToAppend);
</span><del>- m_impl = newImpl.release();
</del><ins>+ m_impl = WTFMove(newImpl);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void String::append(const UChar* charactersToAppend, unsigned lengthToAppend)
</span><span class="lines">@@ -262,13 +262,13 @@
</span><span class="cx"> if (lengthToAppend > std::numeric_limits<unsigned>::max() - strLength)
</span><span class="cx"> CRASH();
</span><span class="cx"> UChar* data;
</span><del>- RefPtr<StringImpl> newImpl = StringImpl::createUninitialized(strLength + lengthToAppend, data);
</del><ins>+ auto newImpl = StringImpl::createUninitialized(strLength + lengthToAppend, data);
</ins><span class="cx"> if (m_impl->is8Bit())
</span><span class="cx"> StringImpl::copyChars(data, characters8(), strLength);
</span><span class="cx"> else
</span><span class="cx"> StringImpl::copyChars(data, characters16(), strLength);
</span><span class="cx"> StringImpl::copyChars(data + strLength, charactersToAppend, lengthToAppend);
</span><del>- m_impl = newImpl.release();
</del><ins>+ m_impl = WTFMove(newImpl);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -289,12 +289,12 @@
</span><span class="cx"> inline void String::removeInternal(const CharacterType* characters, unsigned position, int lengthToRemove)
</span><span class="cx"> {
</span><span class="cx"> CharacterType* data;
</span><del>- RefPtr<StringImpl> newImpl = StringImpl::createUninitialized(length() - lengthToRemove, data);
</del><ins>+ auto newImpl = StringImpl::createUninitialized(length() - lengthToRemove, data);
</ins><span class="cx"> memcpy(data, characters, position * sizeof(CharacterType));
</span><span class="cx"> memcpy(data + position, characters + position + lengthToRemove,
</span><span class="cx"> (length() - lengthToRemove - position) * sizeof(CharacterType));
</span><span class="cx">
</span><del>- m_impl = newImpl.release();
</del><ins>+ m_impl = WTFMove(newImpl);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void String::remove(unsigned position, int lengthToRemove)
</span></span></pre></div>
<a id="trunkSourceWTFwtftextWTFStringh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WTF/wtf/text/WTFString.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WTF/wtf/text/WTFString.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WTF/wtf/text/WTFString.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -125,10 +125,14 @@
</span><span class="cx">
</span><span class="cx"> // We have to declare the copy constructor and copy assignment operator as well, otherwise
</span><span class="cx"> // they'll be implicitly deleted by adding the move constructor and move assignment operator.
</span><del>- String(const String& other) : m_impl(other.m_impl) { }
- String(String&& other) : m_impl(other.m_impl.release()) { }
</del><ins>+ String(const String& other)
+ : m_impl(other.m_impl)
+ { }
+ String(String&& other)
+ : m_impl(WTFMove(other.m_impl))
+ { }
</ins><span class="cx"> String& operator=(const String& other) { m_impl = other.m_impl; return *this; }
</span><del>- String& operator=(String&& other) { m_impl = other.m_impl.release(); return *this; }
</del><ins>+ String& operator=(String&& other) { m_impl = WTFMove(other.m_impl); return *this; }
</ins><span class="cx">
</span><span class="cx"> // Inline the destructor.
</span><span class="cx"> ALWAYS_INLINE ~String() { }
</span><span class="lines">@@ -144,7 +148,7 @@
</span><span class="cx"> bool isEmpty() const { return !m_impl || !m_impl->length(); }
</span><span class="cx">
</span><span class="cx"> StringImpl* impl() const { return m_impl.get(); }
</span><del>- PassRefPtr<StringImpl> releaseImpl() { return m_impl.release(); }
</del><ins>+ RefPtr<StringImpl> releaseImpl() { return WTFMove(m_impl); }
</ins><span class="cx">
</span><span class="cx"> unsigned length() const
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/ChangeLog 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -1,3 +1,214 @@
</span><ins>+2016-05-10 Chris Dumez <cdumez@apple.com>
+
+ Get rid of a lot of calls to RefPtr::release()
+ https://bugs.webkit.org/show_bug.cgi?id=157505
+
+ Reviewed by Alex Christensen.
+
+ Get rid of a lot of calls to RefPtr::release() and use WTFMove() instead.
+
+ * Modules/encryptedmedia/MediaKeySession.cpp:
+ (WebCore::MediaKeySession::addKeyTimerFired):
+ (WebCore::MediaKeySession::sendMessage):
+ (WebCore::MediaKeySession::sendError):
+ * Modules/geolocation/Geolocation.cpp:
+ (WebCore::createGeoposition):
+ * Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
+ (WebCore::DOMWindowIndexedDatabase::disconnectFrameForDocumentSuspension):
+ (WebCore::DOMWindowIndexedDatabase::reconnectFrameFromDocumentSuspension):
+ * Modules/indexeddb/IDBKey.h:
+ (WebCore::IDBKey::createMultiEntryArray):
+ * Modules/mediasource/MediaSource.cpp:
+ (WebCore::MediaSource::scheduleEvent):
+ * Modules/mediasource/SourceBuffer.cpp:
+ (WebCore::SourceBuffer::scheduleEvent):
+ * Modules/mediasource/SourceBufferList.cpp:
+ (WebCore::SourceBufferList::scheduleEvent):
+ * Modules/notifications/DOMWindowNotifications.cpp:
+ (WebCore::DOMWindowNotifications::disconnectFrameForDocumentSuspension):
+ (WebCore::DOMWindowNotifications::reconnectFrameFromDocumentSuspension):
+ * Modules/webdatabase/DatabaseManager.cpp:
+ (WebCore::DatabaseManager::openDatabaseBackend):
+ * Modules/webdatabase/DatabaseManager.h:
+ * Modules/webdatabase/SQLCallbackWrapper.h:
+ (WebCore::SQLCallbackWrapper::unwrap):
+ * Modules/websockets/WebSocketChannel.cpp:
+ (WebCore::WebSocketChannel::enqueueTextFrame):
+ (WebCore::WebSocketChannel::enqueueRawFrame):
+ (WebCore::WebSocketChannel::enqueueBlobFrame):
+ (WebCore::WebSocketChannel::processOutgoingFrameQueue):
+ * bindings/js/JSBlobCustom.cpp:
+ (WebCore::constructJSBlob):
+ * bindings/js/JSGeolocationCustom.cpp:
+ (WebCore::createPositionOptions):
+ (WebCore::JSGeolocation::getCurrentPosition):
+ (WebCore::JSGeolocation::watchPosition):
+ * bindings/js/JSMessagePortCustom.cpp:
+ (WebCore::fillMessagePortArray):
+ * bindings/js/JSSQLTransactionCustom.cpp:
+ (WebCore::JSSQLTransaction::executeSql):
+ * bindings/js/ScriptControllerMac.mm:
+ (WebCore::ScriptController::createScriptInstanceForWidget):
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateCallWith):
+ * crypto/mac/CryptoKeyRSAMac.cpp:
+ (WebCore::CryptoKeyRSA::generatePair):
+ * css/CSSBasicShapes.cpp:
+ (WebCore::buildSerializablePositionOffset):
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::valueForNinePieceImageRepeat):
+ (WebCore::counterToCSSValue):
+ (WebCore::ComputedStyleExtractor::propertyValue):
+ * css/CSSContentDistributionValue.cpp:
+ (WebCore::CSSContentDistributionValue::customCSSText):
+ * css/CSSFilterImageValue.cpp:
+ (WebCore::CSSFilterImageValue::image):
+ * css/CSSFilterImageValue.h:
+ * css/CSSGrammar.y.in:
+ * css/CSSNamedImageValue.cpp:
+ (WebCore::CSSNamedImageValue::image):
+ * css/CSSNamedImageValue.h:
+ * css/CSSParser.cpp:
+ (WebCore::CSSParser::parseFillProperty):
+ (WebCore::CSSParser::parseAnimationProperty):
+ (WebCore::CSSParser::parseInsetRoundedCorners):
+ (WebCore::ShadowParseContext::commitLength):
+ (WebCore::CSSParser::parseShadow):
+ (WebCore::BorderImageSliceParseContext::commitNumber):
+ (WebCore::BorderImageQuadParseContext::commitNumber):
+ (WebCore::CSSParser::parseBorderRadius):
+ (WebCore::CSSParser::parseCounter):
+ (WebCore::CSSParser::parseDeprecatedGradient):
+ (WebCore::CSSParser::parseDeprecatedLinearGradient):
+ (WebCore::CSSParser::parseDeprecatedRadialGradient):
+ (WebCore::CSSParser::parseLinearGradient):
+ (WebCore::CSSParser::parseRadialGradient):
+ (WebCore::CSSParser::parseTransformValue):
+ (WebCore::CSSParser::parseBuiltinFilterArguments):
+ (WebCore::CSSParser::parseTextIndent):
+ (WebCore::CSSParser::popRuleData):
+ (WebCore::CSSParser::markRuleHeaderStart):
+ (WebCore::CSSParser::createViewportRule):
+ * css/CSSParser.h:
+ * css/CSSParserValues.cpp:
+ (WebCore::CSSParserValue::createCSSValue):
+ * css/CSSParserValues.h:
+ * css/CSSValueList.cpp:
+ (WebCore::CSSValueList::copy):
+ * css/CSSValueList.h:
+ * css/SVGCSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::svgPropertyValue):
+ * css/StyleBuilderConverter.h:
+ (WebCore::StyleBuilderConverter::convertClipPath):
+ (WebCore::StyleBuilderConverter::convertReflection):
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::cachedOrPendingFromValue):
+ (WebCore::StyleResolver::setOrPendingFromValue):
+ (WebCore::StyleResolver::cursorOrPendingFromValue):
+ * css/StyleResolver.h:
+ * css/StyleRule.cpp:
+ (WebCore::StyleRuleBase::createCSSOMWrapper):
+ * css/StyleRule.h:
+ * dom/Attr.cpp:
+ (WebCore::Attr::create):
+ * dom/Attr.h:
+ * dom/ContainerNode.h:
+ (WebCore::ChildNodesLazySnapshot::nextNode):
+ * dom/Document.cpp:
+ (WebCore::Document::setFocusedElement):
+ (WebCore::Document::takeDOMWindowFrom):
+ (WebCore::Document::updateHoverActiveState):
+ * dom/Element.cpp:
+ (WebCore::Element::detachAttribute):
+ (WebCore::Element::setAttributeNodeNS):
+ (WebCore::Element::ensureAttr):
+ * dom/Element.h:
+ * dom/MessagePort.cpp:
+ (WebCore::MessagePort::dispatchMessages):
+ (WebCore::MessagePort::entanglePorts):
+ * dom/NodeIterator.cpp:
+ (WebCore::NodeIterator::nextNode):
+ (WebCore::NodeIterator::previousNode):
+ * dom/Range.cpp:
+ (WebCore::Range::processContentsBetweenOffsets):
+ * dom/StyledElement.cpp:
+ (WebCore::StyledElement::rebuildPresentationAttributeStyle):
+ * editing/ApplyBlockElementCommand.cpp:
+ (WebCore::ApplyBlockElementCommand::createBlockElement):
+ * editing/ApplyBlockElementCommand.h:
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
+ * editing/CompositeEditCommand.cpp:
+ (WebCore::CompositeEditCommand::applyCommandToComposite):
+ (WebCore::CompositeEditCommand::appendBlockPlaceholder):
+ (WebCore::CompositeEditCommand::insertBlockPlaceholder):
+ (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
+ (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):
+ (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
+ (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
+ (WebCore::CompositeEditCommand::moveParagraphs):
+ * editing/CompositeEditCommand.h:
+ * editing/EditingStyle.cpp:
+ (WebCore::EditingStyle::wrappingStyleForSerialization):
+ (WebCore::styleFromMatchedRulesForElement):
+ (WebCore::extractPropertiesNotIn):
+ (WebCore::backgroundColorInEffect):
+ * editing/EditingStyle.h:
+ * editing/Editor.cpp:
+ (WebCore::Editor::increaseSelectionListLevel):
+ (WebCore::Editor::increaseSelectionListLevelOrdered):
+ (WebCore::Editor::increaseSelectionListLevelUnordered):
+ (WebCore::Editor::findStringAndScrollToVisible):
+ (WebCore::Editor::rangeOfString):
+ * editing/Editor.h:
+ * editing/InsertParagraphSeparatorCommand.cpp:
+ (WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
+ * editing/InsertParagraphSeparatorCommand.h:
+ * editing/MergeIdenticalElementsCommand.cpp:
+ (WebCore::MergeIdenticalElementsCommand::doUnapply):
+ * editing/ModifySelectionListLevel.cpp:
+ (WebCore::IncreaseSelectionListLevelCommand::doApply):
+ (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
+ * editing/ModifySelectionListLevel.h:
+ * editing/RemoveNodeCommand.cpp:
+ (WebCore::RemoveNodeCommand::doUnapply):
+ * editing/RemoveNodePreservingChildrenCommand.cpp:
+ (WebCore::RemoveNodePreservingChildrenCommand::doApply):
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplacementFragment::insertFragmentForTestRendering):
+ * editing/SpellingCorrectionCommand.cpp:
+ (WebCore::SpellingCorrectionCommand::doApply):
+ * editing/mac/DictionaryLookup.h:
+ * editing/mac/DictionaryLookup.mm:
+ (WebCore::DictionaryLookup::rangeForSelection):
+ (WebCore::DictionaryLookup::rangeAtHitTestResult):
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::finishRequestAutocomplete):
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::scheduleEvent):
+ (WebCore::HTMLMediaElement::updateActiveTextTrackCues):
+ (WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
+ (WebCore::HTMLMediaElement::addTextTrack):
+ (WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent):
+ * html/HTMLMediaElement.h:
+ * html/canvas/OESVertexArrayObject.cpp:
+ (WebCore::OESVertexArrayObject::createVertexArrayOES):
+ * html/canvas/OESVertexArrayObject.h:
+ * html/canvas/WebGLRenderingContextBase.cpp:
+ (WebCore::WebGLRenderingContextBase::getContextAttributes):
+ * html/canvas/WebGLRenderingContextBase.h:
+ * html/track/VTTCue.cpp:
+ (WebCore::VTTCue::getCueAsHTML):
+ (WebCore::VTTCue::createCueRenderingTree):
+ * html/track/VTTCue.h:
+ * html/track/WebVTTElement.cpp:
+ (WebCore::WebVTTElement::createEquivalentHTMLElement):
+ * html/track/WebVTTElement.h:
+ * html/track/WebVTTParser.cpp:
+ (WebCore::WebVTTTreeBuilder::buildFromString):
+ (WebCore::WebVTTParser::createDocumentFragmentFromCueText):
+ * html/track/WebVTTParser.h:
+
</ins><span class="cx"> 2016-05-05 Gavin Barraclough <barraclough@apple.com>
</span><span class="cx">
</span><span class="cx"> Allow some leeway after page load before throttling, to allow post load events to complete.
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesencryptedmediaMediaKeySessioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -186,9 +186,9 @@
</span><span class="cx">
</span><span class="cx"> // 2.7. If did store key is true, queue a task to fire a simple event named keyadded at the MediaKeySession object.
</span><span class="cx"> if (didStoreKey) {
</span><del>- RefPtr<Event> keyaddedEvent = Event::create(eventNames().webkitkeyaddedEvent, false, false);
</del><ins>+ auto keyaddedEvent = Event::create(eventNames().webkitkeyaddedEvent, false, false);
</ins><span class="cx"> keyaddedEvent->setTarget(this);
</span><del>- m_asyncEventQueue.enqueueEvent(keyaddedEvent.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(keyaddedEvent));
</ins><span class="cx">
</span><span class="cx"> keys()->keyAdded();
</span><span class="cx"> }
</span><span class="lines">@@ -209,9 +209,9 @@
</span><span class="cx">
</span><span class="cx"> void MediaKeySession::sendMessage(Uint8Array* message, String destinationURL)
</span><span class="cx"> {
</span><del>- RefPtr<MediaKeyMessageEvent> event = MediaKeyMessageEvent::create(eventNames().webkitkeymessageEvent, message, destinationURL);
</del><ins>+ auto event = MediaKeyMessageEvent::create(eventNames().webkitkeymessageEvent, message, destinationURL);
</ins><span class="cx"> event->setTarget(this);
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void MediaKeySession::sendError(CDMSessionClient::MediaKeyErrorCode errorCode, uint32_t systemCode)
</span><span class="lines">@@ -219,9 +219,9 @@
</span><span class="cx"> Ref<MediaKeyError> error = MediaKeyError::create(errorCode, systemCode).get();
</span><span class="cx"> setError(error.ptr());
</span><span class="cx">
</span><del>- RefPtr<Event> keyerrorEvent = Event::create(eventNames().webkitkeyerrorEvent, false, false);
</del><ins>+ auto keyerrorEvent = Event::create(eventNames().webkitkeyerrorEvent, false, false);
</ins><span class="cx"> keyerrorEvent->setTarget(this);
</span><del>- m_asyncEventQueue.enqueueEvent(keyerrorEvent.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(keyerrorEvent));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String MediaKeySession::mediaKeysStorageDirectory() const
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesgeolocationGeolocationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx"> RefPtr<Coordinates> coordinates = Coordinates::create(position->latitude(), position->longitude(), position->canProvideAltitude(), position->altitude(),
</span><span class="cx"> position->accuracy(), position->canProvideAltitudeAccuracy(), position->altitudeAccuracy(),
</span><span class="cx"> position->canProvideHeading(), position->heading(), position->canProvideSpeed(), position->speed());
</span><del>- return Geoposition::create(coordinates.release(), convertSecondsToDOMTimeStamp(position->timestamp()));
</del><ins>+ return Geoposition::create(WTFMove(coordinates), convertSecondsToDOMTimeStamp(position->timestamp()));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<PositionError> createPositionError(GeolocationError* error)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbDOMWindowIndexedDatabasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -65,14 +65,14 @@
</span><span class="cx">
</span><span class="cx"> void DOMWindowIndexedDatabase::disconnectFrameForDocumentSuspension()
</span><span class="cx"> {
</span><del>- m_suspendedIDBFactory = m_idbFactory.release();
</del><ins>+ m_suspendedIDBFactory = WTFMove(m_idbFactory);
</ins><span class="cx"> DOMWindowProperty::disconnectFrameForDocumentSuspension();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void DOMWindowIndexedDatabase::reconnectFrameFromDocumentSuspension(Frame* frame)
</span><span class="cx"> {
</span><span class="cx"> DOMWindowProperty::reconnectFrameFromDocumentSuspension(frame);
</span><del>- m_idbFactory = m_suspendedIDBFactory.release();
</del><ins>+ m_idbFactory = WTFMove(m_suspendedIDBFactory);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void DOMWindowIndexedDatabase::willDestroyGlobalObjectInCachedFrame()
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbIDBKeyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKey.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/IDBKey.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKey.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -60,7 +60,7 @@
</span><span class="cx"> return adoptRef(*new IDBKey(KeyType::Date, date));
</span><span class="cx"> }
</span><span class="cx">
</span><del>- static PassRefPtr<IDBKey> createMultiEntryArray(const Vector<RefPtr<IDBKey>>& array)
</del><ins>+ static Ref<IDBKey> createMultiEntryArray(const Vector<RefPtr<IDBKey>>& array)
</ins><span class="cx"> {
</span><span class="cx"> Vector<RefPtr<IDBKey>> result;
</span><span class="cx">
</span><span class="lines">@@ -81,9 +81,9 @@
</span><span class="cx"> sizeEstimate += key->m_sizeEstimate;
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>- RefPtr<IDBKey> idbKey = adoptRef(new IDBKey(result, sizeEstimate));
</del><ins>+ Ref<IDBKey> idbKey = adoptRef(*new IDBKey(result, sizeEstimate));
</ins><span class="cx"> ASSERT(idbKey->isValid());
</span><del>- return idbKey.release();
</del><ins>+ return idbKey;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<IDBKey> createArray(const Vector<RefPtr<IDBKey>>& array)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediasourceMediaSourcecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -867,10 +867,10 @@
</span><span class="cx">
</span><span class="cx"> void MediaSource::scheduleEvent(const AtomicString& eventName)
</span><span class="cx"> {
</span><del>- RefPtr<Event> event = Event::create(eventName, false, false);
</del><ins>+ auto event = Event::create(eventName, false, false);
</ins><span class="cx"> event->setTarget(this);
</span><span class="cx">
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ScriptExecutionContext* MediaSource::scriptExecutionContext() const
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediasourceSourceBuffercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -487,10 +487,10 @@
</span><span class="cx">
</span><span class="cx"> void SourceBuffer::scheduleEvent(const AtomicString& eventName)
</span><span class="cx"> {
</span><del>- RefPtr<Event> event = Event::create(eventName, false, false);
</del><ins>+ auto event = Event::create(eventName, false, false);
</ins><span class="cx"> event->setTarget(this);
</span><span class="cx">
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void SourceBuffer::appendBufferInternal(unsigned char* data, unsigned size, ExceptionCode& ec)
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesmediasourceSourceBufferListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/mediasource/SourceBufferList.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/mediasource/SourceBufferList.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBufferList.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -90,10 +90,10 @@
</span><span class="cx">
</span><span class="cx"> void SourceBufferList::scheduleEvent(const AtomicString& eventName)
</span><span class="cx"> {
</span><del>- RefPtr<Event> event = Event::create(eventName, false, false);
</del><ins>+ auto event = Event::create(eventName, false, false);
</ins><span class="cx"> event->setTarget(this);
</span><span class="cx">
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesnotificationsDOMWindowNotificationscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/notifications/DOMWindowNotifications.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/notifications/DOMWindowNotifications.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/notifications/DOMWindowNotifications.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -70,14 +70,14 @@
</span><span class="cx">
</span><span class="cx"> void DOMWindowNotifications::disconnectFrameForDocumentSuspension()
</span><span class="cx"> {
</span><del>- m_suspendedNotificationCenter = m_notificationCenter.release();
</del><ins>+ m_suspendedNotificationCenter = WTFMove(m_notificationCenter);
</ins><span class="cx"> DOMWindowProperty::disconnectFrameForDocumentSuspension();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void DOMWindowNotifications::reconnectFrameFromDocumentSuspension(Frame* frame)
</span><span class="cx"> {
</span><span class="cx"> DOMWindowProperty::reconnectFrameFromDocumentSuspension(frame);
</span><del>- m_notificationCenter = m_suspendedNotificationCenter.release();
</del><ins>+ m_notificationCenter = WTFMove(m_suspendedNotificationCenter);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void DOMWindowNotifications::willDestroyGlobalObjectInCachedFrame()
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseManagercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -201,7 +201,7 @@
</span><span class="cx"> context->securityOrigin()->toString().ascii().data());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Database> DatabaseManager::openDatabaseBackend(ScriptExecutionContext* context, const String& name, const String& expectedVersion, const String& displayName, unsigned long estimatedSize, bool setVersionInNewDatabase, DatabaseError& error, String& errorMessage)
</del><ins>+RefPtr<Database> DatabaseManager::openDatabaseBackend(ScriptExecutionContext* context, const String& name, const String& expectedVersion, const String& displayName, unsigned long estimatedSize, bool setVersionInNewDatabase, DatabaseError& error, String& errorMessage)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(error == DatabaseError::None);
</span><span class="cx">
</span><span class="lines">@@ -217,11 +217,11 @@
</span><span class="cx"> case DatabaseError::DatabaseSizeOverflowed:
</span><span class="cx"> case DatabaseError::GenericSecurityError:
</span><span class="cx"> logOpenDatabaseError(context, name);
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> case DatabaseError::InvalidDatabaseState:
</span><span class="cx"> logErrorMessage(context, errorMessage);
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> case DatabaseError::DatabaseSizeExceededQuota:
</span><span class="cx"> // Notify the client that we've exceeded the database quota.
</span><span class="lines">@@ -245,15 +245,15 @@
</span><span class="cx">
</span><span class="cx"> if (error == DatabaseError::InvalidDatabaseState) {
</span><span class="cx"> logErrorMessage(context, errorMessage);
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> logOpenDatabaseError(context, name);
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return backend.release();
</del><ins>+ return backend;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void DatabaseManager::addProposedDatabase(ProposedDatabase* proposedDb)
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseManagerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseManager.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -128,7 +128,7 @@
</span><span class="cx"> // it already exist previously. Otherwise, it returns 0.
</span><span class="cx"> RefPtr<DatabaseContext> existingDatabaseContextFor(ScriptExecutionContext*);
</span><span class="cx">
</span><del>- PassRefPtr<Database> openDatabaseBackend(ScriptExecutionContext*, const String& name, const String& expectedVersion, const String& displayName, unsigned long estimatedSize, bool setVersionInNewDatabase, DatabaseError&, String& errorMessage);
</del><ins>+ RefPtr<Database> openDatabaseBackend(ScriptExecutionContext*, const String& name, const String& expectedVersion, const String& displayName, unsigned long estimatedSize, bool setVersionInNewDatabase, DatabaseError&, String& errorMessage);
</ins><span class="cx">
</span><span class="cx"> void addProposedDatabase(ProposedDatabase*);
</span><span class="cx"> void removeProposedDatabase(ProposedDatabase*);
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseSQLCallbackWrapperh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/SQLCallbackWrapper.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/SQLCallbackWrapper.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLCallbackWrapper.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -81,12 +81,12 @@
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><del>- PassRefPtr<T> unwrap()
</del><ins>+ RefPtr<T> unwrap()
</ins><span class="cx"> {
</span><span class="cx"> LockHolder locker(m_mutex);
</span><span class="cx"> ASSERT(!m_callback || m_scriptExecutionContext->isContextThread());
</span><span class="cx"> m_scriptExecutionContext = nullptr;
</span><del>- return m_callback.release();
</del><ins>+ return WTFMove(m_callback);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Useful for optimizations only, please test the return value of unwrap to be sure.
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebsocketsWebSocketChannelcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -699,7 +699,7 @@
</span><span class="cx"> frame->opCode = WebSocketFrame::OpCodeText;
</span><span class="cx"> frame->frameType = QueuedFrameTypeString;
</span><span class="cx"> frame->stringData = string;
</span><del>- m_outgoingFrameQueue.append(frame.release());
</del><ins>+ m_outgoingFrameQueue.append(WTFMove(frame));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebSocketChannel::enqueueRawFrame(WebSocketFrame::OpCode opCode, const char* data, size_t dataLength)
</span><span class="lines">@@ -711,7 +711,7 @@
</span><span class="cx"> frame->vectorData.resize(dataLength);
</span><span class="cx"> if (dataLength)
</span><span class="cx"> memcpy(frame->vectorData.data(), data, dataLength);
</span><del>- m_outgoingFrameQueue.append(frame.release());
</del><ins>+ m_outgoingFrameQueue.append(WTFMove(frame));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebSocketChannel::enqueueBlobFrame(WebSocketFrame::OpCode opCode, Blob& blob)
</span><span class="lines">@@ -721,7 +721,7 @@
</span><span class="cx"> frame->opCode = opCode;
</span><span class="cx"> frame->frameType = QueuedFrameTypeBlob;
</span><span class="cx"> frame->blobData = &blob;
</span><del>- m_outgoingFrameQueue.append(frame.release());
</del><ins>+ m_outgoingFrameQueue.append(WTFMove(frame));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebSocketChannel::processOutgoingFrameQueue()
</span><span class="lines">@@ -754,12 +754,12 @@
</span><span class="cx"> m_blobLoader = std::make_unique<FileReaderLoader>(FileReaderLoader::ReadAsArrayBuffer, this);
</span><span class="cx"> m_blobLoaderStatus = BlobLoaderStarted;
</span><span class="cx"> m_blobLoader->start(m_document, *frame->blobData);
</span><del>- m_outgoingFrameQueue.prepend(frame.release());
</del><ins>+ m_outgoingFrameQueue.prepend(WTFMove(frame));
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> case BlobLoaderStarted:
</span><span class="cx"> case BlobLoaderFailed:
</span><del>- m_outgoingFrameQueue.prepend(frame.release());
</del><ins>+ m_outgoingFrameQueue.prepend(WTFMove(frame));
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> case BlobLoaderFinished: {
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSBlobCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSBlobCustom.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSBlobCustom.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/bindings/js/JSBlobCustom.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -119,8 +119,8 @@
</span><span class="cx">
</span><span class="cx"> if (ArrayBuffer* arrayBuffer = toArrayBuffer(item))
</span><span class="cx"> blobBuilder.append(arrayBuffer);
</span><del>- else if (RefPtr<ArrayBufferView> arrayBufferView = toArrayBufferView(item))
- blobBuilder.append(arrayBufferView.release());
</del><ins>+ else if (auto arrayBufferView = toArrayBufferView(item))
+ blobBuilder.append(WTFMove(arrayBufferView));
</ins><span class="cx"> else if (Blob* blob = JSBlob::toWrapped(item))
</span><span class="cx"> blobBuilder.append(blob);
</span><span class="cx"> else {
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSGeolocationCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSGeolocationCustom.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSGeolocationCustom.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/bindings/js/JSGeolocationCustom.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -72,12 +72,12 @@
</span><span class="cx"> static RefPtr<PositionOptions> createPositionOptions(ExecState* exec, JSValue value)
</span><span class="cx"> {
</span><span class="cx"> // Create default options.
</span><del>- RefPtr<PositionOptions> options = PositionOptions::create();
</del><ins>+ auto options = PositionOptions::create();
</ins><span class="cx">
</span><span class="cx"> // Argument is optional (hence undefined is allowed), and null is allowed.
</span><span class="cx"> if (value.isUndefinedOrNull()) {
</span><span class="cx"> // Use default options.
</span><del>- return options;
</del><ins>+ return WTFMove(options);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Given the above test, this will always yield an object.
</span><span class="lines">@@ -87,35 +87,35 @@
</span><span class="cx"> // Create the dictionary wrapper from the initializer object.
</span><span class="cx"> JSDictionary dictionary(exec, object);
</span><span class="cx">
</span><del>- if (!dictionary.tryGetProperty("enableHighAccuracy", options.get(), setEnableHighAccuracy))
</del><ins>+ if (!dictionary.tryGetProperty("enableHighAccuracy", options.ptr(), setEnableHighAccuracy))
</ins><span class="cx"> return nullptr;
</span><del>- if (!dictionary.tryGetProperty("timeout", options.get(), setTimeout))
</del><ins>+ if (!dictionary.tryGetProperty("timeout", options.ptr(), setTimeout))
</ins><span class="cx"> return nullptr;
</span><del>- if (!dictionary.tryGetProperty("maximumAge", options.get(), setMaximumAge))
</del><ins>+ if (!dictionary.tryGetProperty("maximumAge", options.ptr(), setMaximumAge))
</ins><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- return options;
</del><ins>+ return WTFMove(options);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> JSValue JSGeolocation::getCurrentPosition(ExecState& state)
</span><span class="cx"> {
</span><span class="cx"> // Arguments: PositionCallback, (optional)PositionErrorCallback, (optional)PositionOptions
</span><span class="cx">
</span><del>- RefPtr<PositionCallback> positionCallback = createFunctionOnlyCallback<JSPositionCallback>(&state, globalObject(), state.argument(0));
</del><ins>+ auto positionCallback = createFunctionOnlyCallback<JSPositionCallback>(&state, globalObject(), state.argument(0));
</ins><span class="cx"> if (state.hadException())
</span><span class="cx"> return jsUndefined();
</span><span class="cx"> ASSERT(positionCallback);
</span><span class="cx">
</span><del>- RefPtr<PositionErrorCallback> positionErrorCallback = createFunctionOnlyCallback<JSPositionErrorCallback>(&state, globalObject(), state.argument(1), CallbackAllowUndefined | CallbackAllowNull);
</del><ins>+ auto positionErrorCallback = createFunctionOnlyCallback<JSPositionErrorCallback>(&state, globalObject(), state.argument(1), CallbackAllowUndefined | CallbackAllowNull);
</ins><span class="cx"> if (state.hadException())
</span><span class="cx"> return jsUndefined();
</span><span class="cx">
</span><del>- RefPtr<PositionOptions> positionOptions = createPositionOptions(&state, state.argument(2));
</del><ins>+ auto positionOptions = createPositionOptions(&state, state.argument(2));
</ins><span class="cx"> if (state.hadException())
</span><span class="cx"> return jsUndefined();
</span><span class="cx"> ASSERT(positionOptions);
</span><span class="cx">
</span><del>- wrapped().getCurrentPosition(positionCallback.release(), positionErrorCallback.release(), positionOptions.release());
</del><ins>+ wrapped().getCurrentPosition(WTFMove(positionCallback), WTFMove(positionErrorCallback), WTFMove(positionOptions));
</ins><span class="cx"> return jsUndefined();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -123,21 +123,21 @@
</span><span class="cx"> {
</span><span class="cx"> // Arguments: PositionCallback, (optional)PositionErrorCallback, (optional)PositionOptions
</span><span class="cx">
</span><del>- RefPtr<PositionCallback> positionCallback = createFunctionOnlyCallback<JSPositionCallback>(&state, globalObject(), state.argument(0));
</del><ins>+ auto positionCallback = createFunctionOnlyCallback<JSPositionCallback>(&state, globalObject(), state.argument(0));
</ins><span class="cx"> if (state.hadException())
</span><span class="cx"> return jsUndefined();
</span><span class="cx"> ASSERT(positionCallback);
</span><span class="cx">
</span><del>- RefPtr<PositionErrorCallback> positionErrorCallback = createFunctionOnlyCallback<JSPositionErrorCallback>(&state, globalObject(), state.argument(1), CallbackAllowUndefined | CallbackAllowNull);
</del><ins>+ auto positionErrorCallback = createFunctionOnlyCallback<JSPositionErrorCallback>(&state, globalObject(), state.argument(1), CallbackAllowUndefined | CallbackAllowNull);
</ins><span class="cx"> if (state.hadException())
</span><span class="cx"> return jsUndefined();
</span><span class="cx">
</span><del>- RefPtr<PositionOptions> positionOptions = createPositionOptions(&state, state.argument(2));
</del><ins>+ auto positionOptions = createPositionOptions(&state, state.argument(2));
</ins><span class="cx"> if (state.hadException())
</span><span class="cx"> return jsUndefined();
</span><span class="cx"> ASSERT(positionOptions);
</span><span class="cx">
</span><del>- int watchID = wrapped().watchPosition(positionCallback.release(), positionErrorCallback.release(), positionOptions.release());
</del><ins>+ int watchID = wrapped().watchPosition(WTFMove(positionCallback), WTFMove(positionErrorCallback), WTFMove(positionOptions));
</ins><span class="cx"> return jsNumber(watchID);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSMessagePortCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSMessagePortCustom.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSMessagePortCustom.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/bindings/js/JSMessagePortCustom.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -84,18 +84,16 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Validation of Objects implementing an interface, per WebIDL spec 4.1.15.
</span><del>- RefPtr<MessagePort> port = JSMessagePort::toWrapped(value);
- if (port) {
</del><ins>+ if (RefPtr<MessagePort> port = JSMessagePort::toWrapped(value)) {
</ins><span class="cx"> // Check for duplicate ports.
</span><span class="cx"> if (portArray.contains(port)) {
</span><span class="cx"> setDOMException(&state, INVALID_STATE_ERR);
</span><span class="cx"> return;
</span><span class="cx"> }
</span><del>- portArray.append(port.release());
</del><ins>+ portArray.append(WTFMove(port));
</ins><span class="cx"> } else {
</span><del>- RefPtr<ArrayBuffer> arrayBuffer = toArrayBuffer(value);
- if (arrayBuffer)
- arrayBuffers.append(arrayBuffer);
</del><ins>+ if (RefPtr<ArrayBuffer> arrayBuffer = toArrayBuffer(value))
+ arrayBuffers.append(WTFMove(arrayBuffer));
</ins><span class="cx"> else {
</span><span class="cx"> throwTypeError(&state);
</span><span class="cx"> return;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSSQLTransactionCustomcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSSQLTransactionCustom.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSSQLTransactionCustom.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/bindings/js/JSSQLTransactionCustom.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -109,7 +109,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- wrapped().executeSQL(sqlStatement, sqlValues, callback.release(), errorCallback.release(), ec);
</del><ins>+ wrapped().executeSQL(sqlStatement, sqlValues, WTFMove(callback), WTFMove(errorCallback), ec);
</ins><span class="cx"> setDOMException(&state, ec);
</span><span class="cx">
</span><span class="cx"> return jsUndefined();
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsScriptControllerMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/ScriptControllerMac.mm (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/ScriptControllerMac.mm 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/bindings/js/ScriptControllerMac.mm 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -75,7 +75,7 @@
</span><span class="cx"> id objectForWebScript = [widgetView objectForWebScript];
</span><span class="cx"> if (!objectForWebScript)
</span><span class="cx"> return nullptr;
</span><del>- return JSC::Bindings::ObjcInstance::create(objectForWebScript, rootObject.release());
</del><ins>+ return JSC::Bindings::ObjcInstance::create(objectForWebScript, WTFMove(rootObject));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ([widgetView respondsToSelector:@selector(createPluginScriptableObject)]) {
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> NPObject* npObject = [widgetView createPluginScriptableObject];
</span><span class="cx"> if (!npObject)
</span><span class="cx"> return nullptr;
</span><del>- RefPtr<Instance> instance = JSC::Bindings::CInstance::create(npObject, rootObject.release());
</del><ins>+ RefPtr<Instance> instance = JSC::Bindings::CInstance::create(npObject, WTFMove(rootObject));
</ins><span class="cx"> // -createPluginScriptableObject returns a retained NPObject. The caller is expected to release it.
</span><span class="cx"> _NPN_ReleaseObject(npObject);
</span><span class="cx"> return instance;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -3532,7 +3532,7 @@
</span><span class="cx"> push(@$outputArray, " RefPtr<Inspector::ScriptArguments> scriptArguments(Inspector::createScriptArguments(state, " . @{$function->parameters} . "));\n");
</span><span class="cx"> $implIncludes{"<inspector/ScriptArguments.h>"} = 1;
</span><span class="cx"> $implIncludes{"<inspector/ScriptCallStackFactory.h>"} = 1;
</span><del>- push(@callWithArgs, "scriptArguments.release()");
</del><ins>+ push(@callWithArgs, "WTFMove(scriptArguments)");
</ins><span class="cx"> }
</span><span class="cx"> push(@callWithArgs, "activeDOMWindow(state)") if $codeGenerator->ExtendedAttributeContains($callWith, "ActiveWindow");
</span><span class="cx"> push(@callWithArgs, "firstDOMWindow(state)") if $codeGenerator->ExtendedAttributeContains($callWith, "FirstWindow");
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -4525,7 +4525,7 @@
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> RefPtr<Inspector::ScriptArguments> scriptArguments(Inspector::createScriptArguments(state, 0));
</span><del>- impl.withScriptArgumentsAndCallStack(scriptArguments.release());
</del><ins>+ impl.withScriptArgumentsAndCallStack(WTFMove(scriptArguments));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecryptomacCryptoKeyRSAMaccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -262,9 +262,9 @@
</span><span class="cx"> return;
</span><span class="cx"> }
</span><span class="cx"> callOnWebThreadOrDispatchAsyncOnMainThread(^{
</span><del>- RefPtr<CryptoKeyRSA> publicKey = CryptoKeyRSA::create(algorithm, hash, hasHash, CryptoKeyType::Public, ccPublicKey, true, usage);
- RefPtr<CryptoKeyRSA> privateKey = CryptoKeyRSA::create(algorithm, hash, hasHash, CryptoKeyType::Private, ccPrivateKey, extractable, usage);
- (*localCallback)(CryptoKeyPair::create(publicKey.release(), privateKey.release()));
</del><ins>+ auto publicKey = CryptoKeyRSA::create(algorithm, hash, hasHash, CryptoKeyType::Public, ccPublicKey, true, usage);
+ auto privateKey = CryptoKeyRSA::create(algorithm, hash, hasHash, CryptoKeyType::Private, ccPrivateKey, extractable, usage);
+ (*localCallback)(CryptoKeyPair::create(WTFMove(publicKey), WTFMove(privateKey)));
</ins><span class="cx"> delete localCallback;
</span><span class="cx"> delete localFailureCallback;
</span><span class="cx"> });
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSBasicShapescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSBasicShapes.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSBasicShapes.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSBasicShapes.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -82,7 +82,7 @@
</span><span class="cx"> side = defaultSide;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return cssValuePool.createValue(Pair::create(cssValuePool.createValue(side), amount.release()));
</del><ins>+ return cssValuePool.createValue(Pair::create(cssValuePool.createValue(side), WTFMove(amount)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static String buildCircleString(const String& radius, const String& centerX, const String& centerY)
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSComputedStyleDeclarationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -609,7 +609,7 @@
</span><span class="cx"> verticalRepeat = horizontalRepeat;
</span><span class="cx"> else
</span><span class="cx"> verticalRepeat = cssValuePool.createIdentifierValue(valueForRepeatRule(image.verticalRule()));
</span><del>- return cssValuePool.createValue(Pair::create(horizontalRepeat.release(), verticalRepeat.release()));
</del><ins>+ return cssValuePool.createValue(Pair::create(WTFMove(horizontalRepeat), WTFMove(verticalRepeat)));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static Ref<CSSValue> valueForNinePieceImage(const NinePieceImage& image)
</span><span class="lines">@@ -1791,13 +1791,13 @@
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><span class="cx"> auto& cssValuePool = CSSValuePool::singleton();
</span><del>- RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
</del><ins>+ auto list = CSSValueList::createSpaceSeparated();
</ins><span class="cx"> for (CounterDirectiveMap::const_iterator it = map->begin(); it != map->end(); ++it) {
</span><span class="cx"> list->append(cssValuePool.createValue(it->key, CSSPrimitiveValue::CSS_STRING));
</span><span class="cx"> short number = propertyID == CSSPropertyCounterIncrement ? it->value.incrementValue() : it->value.resetValue();
</span><span class="cx"> list->append(cssValuePool.createValue((double)number, CSSPrimitiveValue::CSS_NUMBER));
</span><span class="cx"> }
</span><del>- return list.release();
</del><ins>+ return WTFMove(list);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static void logUnimplementedPropertyID(CSSPropertyID propertyID)
</span><span class="lines">@@ -3396,9 +3396,9 @@
</span><span class="cx"> // Not a real style property -- used by the editing engine -- so has no computed value.
</span><span class="cx"> break;
</span><span class="cx"> case CSSPropertyWebkitInitialLetter: {
</span><del>- RefPtr<CSSPrimitiveValue> drop = !style->initialLetterDrop() ? cssValuePool.createIdentifierValue(CSSValueNormal) : cssValuePool.createValue(style->initialLetterDrop(), CSSPrimitiveValue::CSS_NUMBER);
- RefPtr<CSSPrimitiveValue> size = !style->initialLetterHeight() ? cssValuePool.createIdentifierValue(CSSValueNormal) : cssValuePool.createValue(style->initialLetterHeight(), CSSPrimitiveValue::CSS_NUMBER);
- return cssValuePool.createValue(Pair::create(drop.release(), size.release()));
</del><ins>+ Ref<CSSPrimitiveValue> drop = !style->initialLetterDrop() ? cssValuePool.createIdentifierValue(CSSValueNormal) : cssValuePool.createValue(style->initialLetterDrop(), CSSPrimitiveValue::CSS_NUMBER);
+ Ref<CSSPrimitiveValue> size = !style->initialLetterHeight() ? cssValuePool.createIdentifierValue(CSSValueNormal) : cssValuePool.createValue(style->initialLetterHeight(), CSSPrimitiveValue::CSS_NUMBER);
+ return cssValuePool.createValue(Pair::create(WTFMove(drop), WTFMove(size)));
</ins><span class="cx"> }
</span><span class="cx"> case CSSPropertyWebkitMarginBottomCollapse:
</span><span class="cx"> case CSSPropertyWebkitMarginAfterCollapse:
</span><span class="lines">@@ -3618,7 +3618,7 @@
</span><span class="cx"> for (const FillLayer* currLayer = layers; currLayer; currLayer = currLayer->next())
</span><span class="cx"> list->append(cssValuePool.createValue(currLayer->blendMode()));
</span><span class="cx">
</span><del>- return list.release();
</del><ins>+ return list;
</ins><span class="cx"> }
</span><span class="cx"> case CSSPropertyBackground:
</span><span class="cx"> return getBackgroundShorthandValue();
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSContentDistributionValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSContentDistributionValue.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSContentDistributionValue.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSContentDistributionValue.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -45,14 +45,14 @@
</span><span class="cx">
</span><span class="cx"> String CSSContentDistributionValue::customCSSText() const
</span><span class="cx"> {
</span><del>- RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
</del><ins>+ auto list = CSSValueList::createSpaceSeparated();
</ins><span class="cx"> if (m_distribution != CSSValueInvalid)
</span><span class="cx"> list->append(distribution());
</span><span class="cx"> if (m_position != CSSValueInvalid)
</span><span class="cx"> list->append(position());
</span><span class="cx"> if (m_overflow != CSSValueInvalid)
</span><span class="cx"> list->append(overflow());
</span><del>- return list.release()->customCSSText();
</del><ins>+ return list->customCSSText();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool CSSContentDistributionValue::equals(const CSSContentDistributionValue& other) const
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSFilterImageValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSFilterImageValue.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSFilterImageValue.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSFilterImageValue.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -136,9 +136,7 @@
</span><span class="cx"> return Image::nullImage();
</span><span class="cx"> filterRenderer->apply();
</span><span class="cx">
</span><del>- m_generatedImage = filterRenderer->output()->copyImage();
-
- return m_generatedImage.release();
</del><ins>+ return filterRenderer->output()->copyImage();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void CSSFilterImageValue::filterImageChanged(const IntRect&)
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSFilterImageValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSFilterImageValue.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSFilterImageValue.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSFilterImageValue.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -112,7 +112,6 @@
</span><span class="cx"> FilterOperations m_filterOperations;
</span><span class="cx">
</span><span class="cx"> CachedResourceHandle<CachedImage> m_cachedImage;
</span><del>- RefPtr<Image> m_generatedImage;
</del><span class="cx">
</span><span class="cx"> FilterSubimageObserverProxy m_filterSubimageObserver;
</span><span class="cx"> };
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSGrammaryin"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSGrammar.y.in 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -489,7 +489,7 @@
</span><span class="cx"> if (RefPtr<StyleRuleBase> rule = adoptRef($2)) {
</span><span class="cx"> if (!$$)
</span><span class="cx"> $$ = new Vector<RefPtr<StyleRuleBase>>;
</span><del>- $$->append(rule.release());
</del><ins>+ $$->append(WTFMove(rule));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> ;
</span><span class="lines">@@ -501,7 +501,7 @@
</span><span class="cx"> if (RefPtr<StyleRuleBase> rule = adoptRef($2)) {
</span><span class="cx"> if (!$$)
</span><span class="cx"> $$ = new Vector<RefPtr<StyleRuleBase>>;
</span><del>- $$->append(rule.release());
</del><ins>+ $$->append(WTFMove(rule));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> ;
</span><span class="lines">@@ -817,7 +817,7 @@
</span><span class="cx"> | keyframes_rule keyframe_rule maybe_space {
</span><span class="cx"> $$ = $1;
</span><span class="cx"> if (RefPtr<StyleKeyframe> keyframe = adoptRef($2))
</span><del>- $$->append(keyframe.release());
</del><ins>+ $$->append(WTFMove(keyframe));
</ins><span class="cx"> }
</span><span class="cx"> ;
</span><span class="cx">
</span><span class="lines">@@ -1001,7 +1001,7 @@
</span><span class="cx"> viewport:
</span><span class="cx"> before_viewport_rule WEBKIT_VIEWPORT_RULE_SYM at_rule_header_end_maybe_space
</span><span class="cx"> '{' at_rule_body_start maybe_space_before_declaration declaration_list closing_brace {
</span><del>- $$ = parser->createViewportRule().leakRef();
</del><ins>+ $$ = &parser->createViewportRule().leakRef();
</ins><span class="cx"> parser->markViewportRuleBodyEnd();
</span><span class="cx"> }
</span><span class="cx"> | before_viewport_rule WEBKIT_VIEWPORT_RULE_SYM error invalid_block {
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSNamedImageValuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSNamedImageValue.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSNamedImageValue.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSNamedImageValue.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -41,9 +41,7 @@
</span><span class="cx"> if (size.isEmpty())
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- m_generatedImage = NamedImageGeneratedImage::create(m_name, size);
-
- return m_generatedImage.release();
</del><ins>+ return NamedImageGeneratedImage::create(m_name, size);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool CSSNamedImageValue::equals(const CSSNamedImageValue& other) const
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSNamedImageValueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSNamedImageValue.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSNamedImageValue.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSNamedImageValue.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -58,7 +58,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String m_name;
</span><del>- RefPtr<Image> m_generatedImage;
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -5010,12 +5010,12 @@
</span><span class="cx"> if (values)
</span><span class="cx"> values->append(currValue.releaseNonNull());
</span><span class="cx"> else
</span><del>- value = currValue.release();
</del><ins>+ value = WTFMove(currValue);
</ins><span class="cx"> if (currValue2) {
</span><span class="cx"> if (values2)
</span><span class="cx"> values2->append(currValue2.releaseNonNull());
</span><span class="cx"> else
</span><del>- value2 = currValue2.release();
</del><ins>+ value2 = WTFMove(currValue2);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5026,14 +5026,14 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (values && values->length()) {
</span><del>- retValue1 = values.release();
</del><ins>+ retValue1 = WTFMove(values);
</ins><span class="cx"> if (values2 && values2->length())
</span><del>- retValue2 = values2.release();
</del><ins>+ retValue2 = WTFMove(values2);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> if (value) {
</span><del>- retValue1 = value.release();
- retValue2 = value2.release();
</del><ins>+ retValue1 = WTFMove(value);
+ retValue2 = WTFMove(value2);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> return false;
</span><span class="lines">@@ -5407,7 +5407,7 @@
</span><span class="cx"> if (values)
</span><span class="cx"> values->append(currValue.releaseNonNull());
</span><span class="cx"> else
</span><del>- value = currValue.release();
</del><ins>+ value = WTFMove(currValue);
</ins><span class="cx">
</span><span class="cx"> allowComma = true;
</span><span class="cx"> }
</span><span class="lines">@@ -5419,11 +5419,11 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (values && values->length()) {
</span><del>- result = values.release();
</del><ins>+ result = WTFMove(values);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> if (value) {
</span><del>- result = value.release();
</del><ins>+ result = WTFMove(value);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> return false;
</span><span class="lines">@@ -6561,7 +6561,7 @@
</span><span class="cx"> if (!indexAfterSlash)
</span><span class="cx"> radii[0][i] = radius;
</span><span class="cx"> else
</span><del>- radii[1][i - indexAfterSlash] = radius.release();
</del><ins>+ radii[1][i - indexAfterSlash] = WTFMove(radius);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!indexAfterSlash) {
</span><span class="lines">@@ -6571,10 +6571,10 @@
</span><span class="cx"> } else
</span><span class="cx"> completeBorderRadii(radii[1]);
</span><span class="cx">
</span><del>- shape->setTopLeftRadius(createPrimitiveValuePair(radii[0][0].release(), radii[1][0].release()));
- shape->setTopRightRadius(createPrimitiveValuePair(radii[0][1].release(), radii[1][1].release()));
- shape->setBottomRightRadius(createPrimitiveValuePair(radii[0][2].release(), radii[1][2].release()));
- shape->setBottomLeftRadius(createPrimitiveValuePair(radii[0][3].release(), radii[1][3].release()));
</del><ins>+ shape->setTopLeftRadius(createPrimitiveValuePair(WTFMove(radii[0][0]), WTFMove(radii[1][0])));
+ shape->setTopRightRadius(createPrimitiveValuePair(WTFMove(radii[0][1]), WTFMove(radii[1][1])));
+ shape->setBottomRightRadius(createPrimitiveValuePair(WTFMove(radii[0][2]), WTFMove(radii[1][2])));
+ shape->setBottomLeftRadius(createPrimitiveValuePair(WTFMove(radii[0][3]), WTFMove(radii[1][3])));
</ins><span class="cx">
</span><span class="cx"> return shape;
</span><span class="cx"> }
</span><span class="lines">@@ -7936,28 +7936,28 @@
</span><span class="cx">
</span><span class="cx"> void commitLength(CSSParser::ValueWithCalculation& valueWithCalculation)
</span><span class="cx"> {
</span><del>- RefPtr<CSSPrimitiveValue> primitiveValue = m_parser.createPrimitiveNumericValue(valueWithCalculation);
</del><ins>+ auto primitiveValue = m_parser.createPrimitiveNumericValue(valueWithCalculation);
</ins><span class="cx">
</span><span class="cx"> if (allowX) {
</span><del>- x = primitiveValue.release();
</del><ins>+ x = WTFMove(primitiveValue);
</ins><span class="cx"> allowX = false;
</span><span class="cx"> allowY = true;
</span><span class="cx"> allowColor = false;
</span><span class="cx"> allowStyle = false;
</span><span class="cx"> allowBreak = false;
</span><span class="cx"> } else if (allowY) {
</span><del>- y = primitiveValue.release();
</del><ins>+ y = WTFMove(primitiveValue);
</ins><span class="cx"> allowY = false;
</span><span class="cx"> allowBlur = true;
</span><span class="cx"> allowColor = true;
</span><span class="cx"> allowStyle = property == CSSPropertyWebkitBoxShadow || property == CSSPropertyBoxShadow;
</span><span class="cx"> allowBreak = true;
</span><span class="cx"> } else if (allowBlur) {
</span><del>- blur = primitiveValue.release();
</del><ins>+ blur = WTFMove(primitiveValue);
</ins><span class="cx"> allowBlur = false;
</span><span class="cx"> allowSpread = property == CSSPropertyWebkitBoxShadow || property == CSSPropertyBoxShadow;
</span><span class="cx"> } else if (allowSpread) {
</span><del>- spread = primitiveValue.release();
</del><ins>+ spread = WTFMove(primitiveValue);
</ins><span class="cx"> allowSpread = false;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -8072,7 +8072,7 @@
</span><span class="cx"> if (context.allowBreak) {
</span><span class="cx"> context.commitValue();
</span><span class="cx"> if (context.values && context.values->length())
</span><del>- return context.values.release();
</del><ins>+ return WTFMove(context.values);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return nullptr;
</span><span class="lines">@@ -8416,16 +8416,16 @@
</span><span class="cx">
</span><span class="cx"> void commitNumber(CSSParser::ValueWithCalculation& valueWithCalculation)
</span><span class="cx"> {
</span><del>- RefPtr<CSSPrimitiveValue> primitiveValue = m_parser.createPrimitiveNumericValue(valueWithCalculation);
</del><ins>+ auto primitiveValue = m_parser.createPrimitiveNumericValue(valueWithCalculation);
</ins><span class="cx"> if (!m_top)
</span><del>- m_top = primitiveValue.release();
</del><ins>+ m_top = WTFMove(primitiveValue);
</ins><span class="cx"> else if (!m_right)
</span><del>- m_right = primitiveValue.release();
</del><ins>+ m_right = WTFMove(primitiveValue);
</ins><span class="cx"> else if (!m_bottom)
</span><del>- m_bottom = primitiveValue.release();
</del><ins>+ m_bottom = WTFMove(primitiveValue);
</ins><span class="cx"> else {
</span><span class="cx"> ASSERT(!m_left);
</span><del>- m_left = primitiveValue.release();
</del><ins>+ m_left = WTFMove(primitiveValue);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> m_allowNumber = !m_left;
</span><span class="lines">@@ -8535,14 +8535,14 @@
</span><span class="cx"> primitiveValue = m_parser.createPrimitiveNumericValue(valueWithCalculation);
</span><span class="cx">
</span><span class="cx"> if (!m_top)
</span><del>- m_top = primitiveValue.release();
</del><ins>+ m_top = WTFMove(primitiveValue);
</ins><span class="cx"> else if (!m_right)
</span><del>- m_right = primitiveValue.release();
</del><ins>+ m_right = WTFMove(primitiveValue);
</ins><span class="cx"> else if (!m_bottom)
</span><del>- m_bottom = primitiveValue.release();
</del><ins>+ m_bottom = WTFMove(primitiveValue);
</ins><span class="cx"> else {
</span><span class="cx"> ASSERT(!m_left);
</span><del>- m_left = primitiveValue.release();
</del><ins>+ m_left = WTFMove(primitiveValue);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> m_allowNumber = !m_left;
</span><span class="lines">@@ -8659,10 +8659,10 @@
</span><span class="cx"> if (!validateUnit(valueWithCalculation, FLength | FPercent | FNonNeg))
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- RefPtr<CSSPrimitiveValue> radius = createPrimitiveNumericValue(valueWithCalculation);
</del><ins>+ auto radius = createPrimitiveNumericValue(valueWithCalculation);
</ins><span class="cx">
</span><span class="cx"> if (!indexAfterSlash) {
</span><del>- radii[0][i] = radius;
</del><ins>+ radii[0][i] = WTFMove(radius);
</ins><span class="cx">
</span><span class="cx"> // Legacy syntax: -webkit-border-radius: l1 l2; is equivalent to border-radius: l1 / l2;
</span><span class="cx"> if (num == 2 && propId == CSSPropertyWebkitBorderRadius) {
</span><span class="lines">@@ -8670,7 +8670,7 @@
</span><span class="cx"> completeBorderRadii(radii[0]);
</span><span class="cx"> }
</span><span class="cx"> } else
</span><del>- radii[1][i - indexAfterSlash] = radius.release();
</del><ins>+ radii[1][i - indexAfterSlash] = WTFMove(radius);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!indexAfterSlash) {
</span><span class="lines">@@ -8681,10 +8681,10 @@
</span><span class="cx"> completeBorderRadii(radii[1]);
</span><span class="cx">
</span><span class="cx"> ImplicitScope implicitScope(*this, PropertyImplicit);
</span><del>- addProperty(CSSPropertyBorderTopLeftRadius, createPrimitiveValuePair(radii[0][0].release(), radii[1][0].release()), important);
- addProperty(CSSPropertyBorderTopRightRadius, createPrimitiveValuePair(radii[0][1].release(), radii[1][1].release()), important);
- addProperty(CSSPropertyBorderBottomRightRadius, createPrimitiveValuePair(radii[0][2].release(), radii[1][2].release()), important);
- addProperty(CSSPropertyBorderBottomLeftRadius, createPrimitiveValuePair(radii[0][3].release(), radii[1][3].release()), important);
</del><ins>+ addProperty(CSSPropertyBorderTopLeftRadius, createPrimitiveValuePair(WTFMove(radii[0][0]), WTFMove(radii[1][0])), important);
+ addProperty(CSSPropertyBorderTopRightRadius, createPrimitiveValuePair(WTFMove(radii[0][1]), WTFMove(radii[1][1])), important);
+ addProperty(CSSPropertyBorderBottomRightRadius, createPrimitiveValuePair(WTFMove(radii[0][2]), WTFMove(radii[1][2])), important);
+ addProperty(CSSPropertyBorderBottomLeftRadius, createPrimitiveValuePair(WTFMove(radii[0][3]), WTFMove(radii[1][3])), important);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -8746,7 +8746,7 @@
</span><span class="cx"> m_valueList->next();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- list->append(createPrimitiveValuePair(counterName.release(),
</del><ins>+ list->append(createPrimitiveValuePair(WTFMove(counterName),
</ins><span class="cx"> CSSValuePool::singleton().createValue(i, CSSPrimitiveValue::CSS_NUMBER)));
</span><span class="cx"> state = ID;
</span><span class="cx"> continue;
</span><span class="lines">@@ -8978,7 +8978,7 @@
</span><span class="cx"> argument = args->next();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- gradient = result.release();
</del><ins>+ gradient = WTFMove(result);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -9076,7 +9076,7 @@
</span><span class="cx"> if (!result->stopCount())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- gradient = result.release();
</del><ins>+ gradient = WTFMove(result);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -9196,7 +9196,7 @@
</span><span class="cx"> if (!parseGradientColorStops(*args, *result, expectComma))
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- gradient = result.release();
</del><ins>+ gradient = WTFMove(result);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -9269,7 +9269,7 @@
</span><span class="cx"> if (!result->stopCount())
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- gradient = result.release();
</del><ins>+ gradient = WTFMove(result);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -9395,7 +9395,7 @@
</span><span class="cx"> if (!parseGradientColorStops(*args, *result, expectComma))
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- gradient = result.release();
</del><ins>+ gradient = WTFMove(result);
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -10069,7 +10069,7 @@
</span><span class="cx"> ++argNumber;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return transformValue.release();
</del><ins>+ return WTFMove(transformValue);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool CSSParser::isBlendMode(CSSValueID valueID)
</span><span class="lines">@@ -10113,7 +10113,7 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<WebKitCSSFilterValue> CSSParser::parseBuiltinFilterArguments(CSSParserValueList& args, WebKitCSSFilterValue::FilterOperationType filterType)
</span><span class="cx"> {
</span><del>- RefPtr<WebKitCSSFilterValue> filterValue = WebKitCSSFilterValue::create(filterType);
</del><ins>+ auto filterValue = WebKitCSSFilterValue::create(filterType);
</ins><span class="cx">
</span><span class="cx"> switch (filterType) {
</span><span class="cx"> case WebKitCSSFilterValue::GrayscaleFilterOperation:
</span><span class="lines">@@ -10199,7 +10199,7 @@
</span><span class="cx"> default:
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><del>- return filterValue.release();
</del><ins>+ return WTFMove(filterValue);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool CSSParser::parseFilter(CSSParserValueList& valueList, RefPtr<CSSValue>& result)
</span><span class="lines">@@ -10604,7 +10604,7 @@
</span><span class="cx"> {
</span><span class="cx"> // <length> | <percentage> | inherit when CSS3_TEXT is disabled.
</span><span class="cx"> // [ <length> | <percentage> ] && [ -webkit-hanging || -webkit-each-line ]? | inherit when CSS3_TEXT is enabled.
</span><del>- RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
</del><ins>+ auto list = CSSValueList::createSpaceSeparated();
</ins><span class="cx"> bool hasLengthOrPercentage = false;
</span><span class="cx"> #if ENABLE(CSS3_TEXT)
</span><span class="cx"> bool hasEachLine = false;
</span><span class="lines">@@ -10636,7 +10636,7 @@
</span><span class="cx"> if (!hasLengthOrPercentage)
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- return list.release();
</del><ins>+ return WTFMove(list);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool CSSParser::parseHangingPunctuation(bool important)
</span><span class="lines">@@ -12970,7 +12970,7 @@
</span><span class="cx"> m_currentRuleDataStack->last()->childRules.append(rule);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CSSRuleSourceData> CSSParser::popRuleData()
</del><ins>+RefPtr<CSSRuleSourceData> CSSParser::popRuleData()
</ins><span class="cx"> {
</span><span class="cx"> if (!m_ruleSourceDataResult)
</span><span class="cx"> return nullptr;
</span><span class="lines">@@ -12979,7 +12979,7 @@
</span><span class="cx"> m_currentRuleData = nullptr;
</span><span class="cx"> RefPtr<CSSRuleSourceData> data = m_currentRuleDataStack->last();
</span><span class="cx"> m_currentRuleDataStack->removeLast();
</span><del>- return data.release();
</del><ins>+ return data;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void CSSParser::syntaxError(const Location& location, SyntaxErrorType error)
</span><span class="lines">@@ -13327,10 +13327,10 @@
</span><span class="cx"> if (m_currentRuleData)
</span><span class="cx"> m_currentRuleDataStack->removeLast();
</span><span class="cx">
</span><del>- RefPtr<CSSRuleSourceData> data = CSSRuleSourceData::create(ruleType);
</del><ins>+ auto data = CSSRuleSourceData::create(ruleType);
</ins><span class="cx"> data->ruleHeaderRange.start = tokenStartOffset();
</span><del>- m_currentRuleData = data;
- m_currentRuleDataStack->append(data.release());
</del><ins>+ m_currentRuleData = data.copyRef();
+ m_currentRuleDataStack->append(WTFMove(data));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template <typename CharacterType>
</span><span class="lines">@@ -13449,16 +13449,16 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_DEVICE_ADAPTATION)
</span><del>-PassRefPtr<StyleRuleBase> CSSParser::createViewportRule()
</del><ins>+Ref<StyleRuleBase> CSSParser::createViewportRule()
</ins><span class="cx"> {
</span><span class="cx"> m_allowImportRules = m_allowNamespaceDeclarations = false;
</span><span class="cx">
</span><del>- RefPtr<StyleRuleViewport> rule = StyleRuleViewport::create(createStyleProperties());
</del><ins>+ auto rule = StyleRuleViewport::create(createStyleProperties());
</ins><span class="cx"> clearProperties();
</span><span class="cx">
</span><span class="cx"> processAndAddNewRuleToSourceTreeIfNeeded();
</span><span class="cx">
</span><del>- return rule.release();
</del><ins>+ return rule;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool CSSParser::parseViewportProperty(CSSPropertyID propId, bool important)
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParserh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSParser.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -450,7 +450,7 @@
</span><span class="cx"> void markPropertyEnd(bool isImportantFound, bool isPropertyParsed);
</span><span class="cx"> void processAndAddNewRuleToSourceTreeIfNeeded();
</span><span class="cx"> void addNewRuleToSourceTree(PassRefPtr<CSSRuleSourceData>);
</span><del>- PassRefPtr<CSSRuleSourceData> popRuleData();
</del><ins>+ RefPtr<CSSRuleSourceData> popRuleData();
</ins><span class="cx"> void resetPropertyRange() { m_propertyRange.start = m_propertyRange.end = UINT_MAX; }
</span><span class="cx"> bool isExtractingSourceData() const { return !!m_currentRuleDataStack; }
</span><span class="cx"> void syntaxError(const Location&, SyntaxErrorType = GeneralSyntaxError);
</span><span class="lines">@@ -462,7 +462,7 @@
</span><span class="cx"> #if ENABLE(CSS_DEVICE_ADAPTATION)
</span><span class="cx"> void markViewportRuleBodyStart() { m_inViewport = true; }
</span><span class="cx"> void markViewportRuleBodyEnd() { m_inViewport = false; }
</span><del>- PassRefPtr<StyleRuleBase> createViewportRule();
</del><ins>+ Ref<StyleRuleBase> createViewportRule();
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> Ref<CSSPrimitiveValue> createPrimitiveNumericValue(ValueWithCalculation&);
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParserValuescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParserValues.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParserValues.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSParserValues.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -86,16 +86,16 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CSSValue> CSSParserValue::createCSSValue()
</del><ins>+RefPtr<CSSValue> CSSParserValue::createCSSValue()
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<CSSValue> parsedValue;
</span><span class="cx"> if (id)
</span><span class="cx"> return CSSPrimitiveValue::createIdentifier(id);
</span><span class="cx">
</span><span class="cx"> if (unit == CSSParserValue::Operator) {
</span><del>- RefPtr<CSSPrimitiveValue> primitiveValue = CSSPrimitiveValue::createParserOperator(iValue);
</del><ins>+ auto primitiveValue = CSSPrimitiveValue::createParserOperator(iValue);
</ins><span class="cx"> primitiveValue->setPrimitiveType(CSSPrimitiveValue::CSS_PARSER_OPERATOR);
</span><del>- return primitiveValue.release();
</del><ins>+ return WTFMove(primitiveValue);
</ins><span class="cx"> }
</span><span class="cx"> if (unit == CSSParserValue::Function)
</span><span class="cx"> return CSSFunctionValue::create(function);
</span><span class="lines">@@ -172,11 +172,11 @@
</span><span class="cx"> case CSSPrimitiveValue::CSS_CALC:
</span><span class="cx"> case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_NUMBER:
</span><span class="cx"> case CSSPrimitiveValue::CSS_CALC_PERCENTAGE_WITH_LENGTH:
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> CSSParserSelector* CSSParserSelector::parsePagePseudoSelector(const CSSParserString& pseudoTypeString)
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParserValuesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParserValues.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParserValues.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSParserValues.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -124,7 +124,7 @@
</span><span class="cx">
</span><span class="cx"> void setFromValueList(std::unique_ptr<CSSParserValueList>);
</span><span class="cx">
</span><del>- PassRefPtr<CSSValue> createCSSValue();
</del><ins>+ RefPtr<CSSValue> createCSSValue();
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> void destroy(const CSSParserValue&);
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSValueListcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSValueList.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSValueList.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSValueList.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -78,7 +78,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CSSValueList> CSSValueList::copy()
</del><ins>+Ref<CSSValueList> CSSValueList::copy()
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<CSSValueList> newList;
</span><span class="cx"> switch (m_valueListSeparator) {
</span><span class="lines">@@ -96,7 +96,7 @@
</span><span class="cx"> }
</span><span class="cx"> for (auto& value : m_values)
</span><span class="cx"> newList->append(value.get());
</span><del>- return newList.release();
</del><ins>+ return newList.releaseNonNull();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> String CSSValueList::customCSSText() const
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSValueListh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSValueList.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSValueList.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/CSSValueList.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -67,7 +67,7 @@
</span><span class="cx"> void prepend(Ref<CSSValue>&&);
</span><span class="cx"> bool removeAll(CSSValue*);
</span><span class="cx"> bool hasValue(CSSValue*) const;
</span><del>- PassRefPtr<CSSValueList> copy();
</del><ins>+ Ref<CSSValueList> copy();
</ins><span class="cx">
</span><span class="cx"> String customCSSText() const;
</span><span class="cx"> bool equals(const CSSValueList&) const;
</span></span></pre></div>
<a id="trunkSourceWebCorecssSVGCSSComputedStyleDeclarationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -206,7 +206,7 @@
</span><span class="cx"> return glyphOrientationToCSSPrimitiveValue(svgStyle.glyphOrientationHorizontal());
</span><span class="cx"> case CSSPropertyGlyphOrientationVertical: {
</span><span class="cx"> if (RefPtr<CSSPrimitiveValue> value = glyphOrientationToCSSPrimitiveValue(svgStyle.glyphOrientationVertical()))
</span><del>- return value.release();
</del><ins>+ return value;
</ins><span class="cx">
</span><span class="cx"> if (svgStyle.glyphOrientationVertical() == GO_AUTO)
</span><span class="cx"> return CSSPrimitiveValue::createIdentifier(CSSValueAuto);
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleBuilderConverterh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleBuilderConverter.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleBuilderConverter.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/StyleBuilderConverter.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -80,13 +80,13 @@
</span><span class="cx"> static String convertStringOrNone(StyleResolver&, CSSValue&);
</span><span class="cx"> static TextEmphasisPosition convertTextEmphasisPosition(StyleResolver&, CSSValue&);
</span><span class="cx"> static ETextAlign convertTextAlign(StyleResolver&, CSSValue&);
</span><del>- static PassRefPtr<ClipPathOperation> convertClipPath(StyleResolver&, CSSValue&);
</del><ins>+ static RefPtr<ClipPathOperation> convertClipPath(StyleResolver&, CSSValue&);
</ins><span class="cx"> static EResize convertResize(StyleResolver&, CSSValue&);
</span><span class="cx"> static int convertMarqueeRepetition(StyleResolver&, CSSValue&);
</span><span class="cx"> static int convertMarqueeSpeed(StyleResolver&, CSSValue&);
</span><span class="cx"> static PassRefPtr<QuotesData> convertQuotes(StyleResolver&, CSSValue&);
</span><span class="cx"> static TextUnderlinePosition convertTextUnderlinePosition(StyleResolver&, CSSValue&);
</span><del>- static PassRefPtr<StyleReflection> convertReflection(StyleResolver&, CSSValue&);
</del><ins>+ static RefPtr<StyleReflection> convertReflection(StyleResolver&, CSSValue&);
</ins><span class="cx"> static IntSize convertInitialLetter(StyleResolver&, CSSValue&);
</span><span class="cx"> static float convertTextStrokeWidth(StyleResolver&, CSSValue&);
</span><span class="cx"> static LineBoxContain convertLineBoxContain(StyleResolver&, CSSValue&);
</span><span class="lines">@@ -482,7 +482,7 @@
</span><span class="cx"> return parentStyle->textAlign();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline PassRefPtr<ClipPathOperation> StyleBuilderConverter::convertClipPath(StyleResolver& styleResolver, CSSValue& value)
</del><ins>+inline RefPtr<ClipPathOperation> StyleBuilderConverter::convertClipPath(StyleResolver& styleResolver, CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (is<CSSPrimitiveValue>(value)) {
</span><span class="cx"> auto& primitiveValue = downcast<CSSPrimitiveValue>(value);
</span><span class="lines">@@ -523,7 +523,7 @@
</span><span class="cx"> operation = BoxClipPathOperation::create(referenceBox);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return operation.release();
</del><ins>+ return operation;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> inline EResize StyleBuilderConverter::convertResize(StyleResolver& styleResolver, CSSValue& value)
</span><span class="lines">@@ -616,7 +616,7 @@
</span><span class="cx"> return static_cast<TextUnderlinePosition>(combinedPosition);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-inline PassRefPtr<StyleReflection> StyleBuilderConverter::convertReflection(StyleResolver& styleResolver, CSSValue& value)
</del><ins>+inline RefPtr<StyleReflection> StyleBuilderConverter::convertReflection(StyleResolver& styleResolver, CSSValue& value)
</ins><span class="cx"> {
</span><span class="cx"> if (is<CSSPrimitiveValue>(value)) {
</span><span class="cx"> ASSERT(downcast<CSSPrimitiveValue>(value).getValueID() == CSSValueNone);
</span><span class="lines">@@ -625,7 +625,7 @@
</span><span class="cx">
</span><span class="cx"> auto& reflectValue = downcast<CSSReflectValue>(value);
</span><span class="cx">
</span><del>- RefPtr<StyleReflection> reflection = StyleReflection::create();
</del><ins>+ auto reflection = StyleReflection::create();
</ins><span class="cx"> reflection->setDirection(*reflectValue.direction());
</span><span class="cx">
</span><span class="cx"> if (reflectValue.offset())
</span><span class="lines">@@ -636,7 +636,7 @@
</span><span class="cx"> styleResolver.styleMap()->mapNinePieceImage(CSSPropertyWebkitBoxReflect, reflectValue.mask(), mask);
</span><span class="cx"> reflection->setMask(mask);
</span><span class="cx">
</span><del>- return reflection.release();
</del><ins>+ return WTFMove(reflection);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> inline IntSize StyleBuilderConverter::convertInitialLetter(StyleResolver&, CSSValue& value)
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleResolvercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleResolver.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleResolver.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -1679,12 +1679,12 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<StyleImage> StyleResolver::cachedOrPendingFromValue(CSSPropertyID property, CSSImageValue& value)
</del><ins>+RefPtr<StyleImage> StyleResolver::cachedOrPendingFromValue(CSSPropertyID property, CSSImageValue& value)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<StyleImage> image = value.cachedOrPendingImage();
</span><span class="cx"> if (image && image->isPendingImage())
</span><span class="cx"> m_state.pendingImageProperties().set(property, &value);
</span><del>- return image.release();
</del><ins>+ return image;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<StyleImage> StyleResolver::generatedOrPendingFromValue(CSSPropertyID property, CSSImageGeneratorValue& value)
</span><span class="lines">@@ -1702,21 +1702,21 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_IMAGE_SET)
</span><del>-PassRefPtr<StyleImage> StyleResolver::setOrPendingFromValue(CSSPropertyID property, CSSImageSetValue& value)
</del><ins>+RefPtr<StyleImage> StyleResolver::setOrPendingFromValue(CSSPropertyID property, CSSImageSetValue& value)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<StyleImage> image = value.cachedOrPendingImageSet(document());
</span><span class="cx"> if (image && image->isPendingImage())
</span><span class="cx"> m_state.pendingImageProperties().set(property, &value);
</span><del>- return image.release();
</del><ins>+ return image;
</ins><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-PassRefPtr<StyleImage> StyleResolver::cursorOrPendingFromValue(CSSPropertyID property, CSSCursorImageValue& value)
</del><ins>+RefPtr<StyleImage> StyleResolver::cursorOrPendingFromValue(CSSPropertyID property, CSSCursorImageValue& value)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<StyleImage> image = value.cachedOrPendingImage(document());
</span><span class="cx"> if (image && image->isPendingImage())
</span><span class="cx"> m_state.pendingImageProperties().set(property, &value);
</span><del>- return image.release();
</del><ins>+ return image;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(IOS_TEXT_AUTOSIZING)
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleResolverh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleResolver.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleResolver.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/StyleResolver.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -459,12 +459,12 @@
</span><span class="cx"> State& state() { return m_state; }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<StyleImage> styleImage(CSSPropertyID, CSSValue&);
</span><del>- PassRefPtr<StyleImage> cachedOrPendingFromValue(CSSPropertyID, CSSImageValue&);
</del><ins>+ RefPtr<StyleImage> cachedOrPendingFromValue(CSSPropertyID, CSSImageValue&);
</ins><span class="cx"> PassRefPtr<StyleImage> generatedOrPendingFromValue(CSSPropertyID, CSSImageGeneratorValue&);
</span><span class="cx"> #if ENABLE(CSS_IMAGE_SET)
</span><del>- PassRefPtr<StyleImage> setOrPendingFromValue(CSSPropertyID, CSSImageSetValue&);
</del><ins>+ RefPtr<StyleImage> setOrPendingFromValue(CSSPropertyID, CSSImageSetValue&);
</ins><span class="cx"> #endif
</span><del>- PassRefPtr<StyleImage> cursorOrPendingFromValue(CSSPropertyID, CSSCursorImageValue&);
</del><ins>+ RefPtr<StyleImage> cursorOrPendingFromValue(CSSPropertyID, CSSCursorImageValue&);
</ins><span class="cx">
</span><span class="cx"> bool applyPropertyToRegularStyle() const { return m_state.applyPropertyToRegularStyle(); }
</span><span class="cx"> bool applyPropertyToVisitedLinkStyle() const { return m_state.applyPropertyToVisitedLinkStyle(); }
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleRulecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleRule.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleRule.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/StyleRule.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -140,7 +140,7 @@
</span><span class="cx"> return Ref<StyleRuleBase>(*static_cast<StyleRuleBase*>(nullptr));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CSSRule> StyleRuleBase::createCSSOMWrapper(CSSStyleSheet* parentSheet, CSSRule* parentRule) const
</del><ins>+RefPtr<CSSRule> StyleRuleBase::createCSSOMWrapper(CSSStyleSheet* parentSheet, CSSRule* parentRule) const
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<CSSRule> rule;
</span><span class="cx"> StyleRuleBase& self = const_cast<StyleRuleBase&>(*this);
</span><span class="lines">@@ -187,7 +187,7 @@
</span><span class="cx"> }
</span><span class="cx"> if (parentRule)
</span><span class="cx"> rule->setParentRule(parentRule);
</span><del>- return rule.release();
</del><ins>+ return rule;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> unsigned StyleRule::averageSizeInBytes()
</span></span></pre></div>
<a id="trunkSourceWebCorecssStyleRuleh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/StyleRule.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/StyleRule.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/css/StyleRule.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -94,7 +94,7 @@
</span><span class="cx"> private:
</span><span class="cx"> void destroy();
</span><span class="cx">
</span><del>- PassRefPtr<CSSRule> createCSSOMWrapper(CSSStyleSheet* parentSheet, CSSRule* parentRule) const;
</del><ins>+ RefPtr<CSSRule> createCSSOMWrapper(CSSStyleSheet* parentSheet, CSSRule* parentRule) const;
</ins><span class="cx">
</span><span class="cx"> unsigned m_type : 5;
</span><span class="cx"> signed m_sourceLine : 27;
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttrcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/dom/Attr.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -52,18 +52,18 @@
</span><span class="cx"> {
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Attr> Attr::create(Element* element, const QualifiedName& name)
</del><ins>+Ref<Attr> Attr::create(Element* element, const QualifiedName& name)
</ins><span class="cx"> {
</span><del>- RefPtr<Attr> attr = adoptRef(new Attr(element, name));
</del><ins>+ Ref<Attr> attr = adoptRef(*new Attr(element, name));
</ins><span class="cx"> attr->createTextChild();
</span><del>- return attr.release();
</del><ins>+ return attr;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Attr> Attr::create(Document& document, const QualifiedName& name, const AtomicString& value)
</del><ins>+Ref<Attr> Attr::create(Document& document, const QualifiedName& name, const AtomicString& value)
</ins><span class="cx"> {
</span><del>- RefPtr<Attr> attr = adoptRef(new Attr(document, name, value));
</del><ins>+ Ref<Attr> attr = adoptRef(*new Attr(document, name, value));
</ins><span class="cx"> attr->createTextChild();
</span><del>- return attr.release();
</del><ins>+ return attr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Attr::~Attr()
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttrh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/dom/Attr.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -42,8 +42,8 @@
</span><span class="cx">
</span><span class="cx"> class Attr final : public ContainerNode {
</span><span class="cx"> public:
</span><del>- static RefPtr<Attr> create(Element*, const QualifiedName&);
- static RefPtr<Attr> create(Document&, const QualifiedName&, const AtomicString& value);
</del><ins>+ static Ref<Attr> create(Element*, const QualifiedName&);
+ static Ref<Attr> create(Document&, const QualifiedName&, const AtomicString& value);
</ins><span class="cx"> virtual ~Attr();
</span><span class="cx">
</span><span class="cx"> String name() const { return qualifiedName().toString(); }
</span></span></pre></div>
<a id="trunkSourceWebCoredomContainerNodeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/ContainerNode.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/ContainerNode.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/dom/ContainerNode.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -209,13 +209,13 @@
</span><span class="cx"> RefPtr<Node> nextNode()
</span><span class="cx"> {
</span><span class="cx"> if (LIKELY(!hasSnapshot())) {
</span><del>- RefPtr<Node> node = m_currentNode.release();
</del><ins>+ RefPtr<Node> node = WTFMove(m_currentNode);
</ins><span class="cx"> if (node)
</span><span class="cx"> m_currentNode = node->nextSibling();
</span><del>- return node.release();
</del><ins>+ return node;
</ins><span class="cx"> }
</span><span class="cx"> if (m_currentIndex >= m_snapshot.size())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> return m_snapshot[m_currentIndex++];
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -3752,7 +3752,7 @@
</span><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> bool focusChangeBlocked = false;
</span><del>- RefPtr<Element> oldFocusedElement = m_focusedElement.release();
</del><ins>+ RefPtr<Element> oldFocusedElement = WTFMove(m_focusedElement);
</ins><span class="cx">
</span><span class="cx"> // Remove focus from the existing focus node (if any)
</span><span class="cx"> if (oldFocusedElement) {
</span><span class="lines">@@ -4068,7 +4068,7 @@
</span><span class="cx"> // A valid DOMWindow is needed by CachedFrame for its documents.
</span><span class="cx"> ASSERT(!document->inPageCache());
</span><span class="cx">
</span><del>- m_domWindow = document->m_domWindow.release();
</del><ins>+ m_domWindow = WTFMove(document->m_domWindow);
</ins><span class="cx"> m_domWindow->didSecureTransitionTo(this);
</span><span class="cx">
</span><span class="cx"> ASSERT(m_domWindow->document() == this);
</span><span class="lines">@@ -6573,7 +6573,7 @@
</span><span class="cx"> // at the time the mouse went down.
</span><span class="cx"> bool mustBeInActiveChain = request.active() && request.move();
</span><span class="cx">
</span><del>- RefPtr<Element> oldHoveredElement = m_hoveredElement.release();
</del><ins>+ RefPtr<Element> oldHoveredElement = WTFMove(m_hoveredElement);
</ins><span class="cx">
</span><span class="cx"> // A touch release does not set a new hover target; clearing the element we're working with
</span><span class="cx"> // will clear the chain of hovered elements all the way to the top of the tree.
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/dom/Element.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -369,7 +369,7 @@
</span><span class="cx"> return targetDocument.createElement(tagQName(), false);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Attr> Element::detachAttribute(unsigned index)
</del><ins>+Ref<Attr> Element::detachAttribute(unsigned index)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(elementData());
</span><span class="cx">
</span><span class="lines">@@ -382,7 +382,7 @@
</span><span class="cx"> attrNode = Attr::create(document(), attribute.name(), attribute.value());
</span><span class="cx">
</span><span class="cx"> removeAttributeInternal(index, NotInSynchronizationOfLazyAttribute);
</span><del>- return attrNode.release();
</del><ins>+ return attrNode.releaseNonNull();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool Element::removeAttribute(const QualifiedName& name)
</span><span class="lines">@@ -1998,7 +1998,7 @@
</span><span class="cx"> treeScope().adoptIfNeeded(&attrNode);
</span><span class="cx"> ensureAttrNodeListForElement(*this).append(&attrNode);
</span><span class="cx">
</span><del>- return oldAttrNode.release();
</del><ins>+ return oldAttrNode;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> RefPtr<Attr> Element::removeAttributeNode(Attr& attr, ExceptionCode& ec)
</span><span class="lines">@@ -3167,7 +3167,7 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<Attr> Element::ensureAttr(const QualifiedName& name)
</del><ins>+Ref<Attr> Element::ensureAttr(const QualifiedName& name)
</ins><span class="cx"> {
</span><span class="cx"> auto& attrNodeList = ensureAttrNodeListForElement(*this);
</span><span class="cx"> RefPtr<Attr> attrNode = findAttrNodeInList(attrNodeList, name);
</span><span class="lines">@@ -3176,7 +3176,7 @@
</span><span class="cx"> treeScope().adoptIfNeeded(attrNode.get());
</span><span class="cx"> attrNodeList.append(attrNode);
</span><span class="cx"> }
</span><del>- return attrNode.release();
</del><ins>+ return attrNode.releaseNonNull();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Element::detachAttrNodeFromElementWithValue(Attr* attrNode, const AtomicString& value)
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/dom/Element.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -166,7 +166,7 @@
</span><span class="cx"> bool removeAttribute(const AtomicString& name);
</span><span class="cx"> bool removeAttributeNS(const AtomicString& namespaceURI, const AtomicString& localName);
</span><span class="cx">
</span><del>- RefPtr<Attr> detachAttribute(unsigned index);
</del><ins>+ Ref<Attr> detachAttribute(unsigned index);
</ins><span class="cx">
</span><span class="cx"> RefPtr<Attr> getAttributeNode(const AtomicString& name);
</span><span class="cx"> RefPtr<Attr> getAttributeNodeNS(const AtomicString& namespaceURI, const AtomicString& localName);
</span><span class="lines">@@ -176,7 +176,7 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<Attr> attrIfExists(const QualifiedName&);
</span><span class="cx"> RefPtr<Attr> attrIfExists(const AtomicString& localName, bool shouldIgnoreAttributeCase);
</span><del>- RefPtr<Attr> ensureAttr(const QualifiedName&);
</del><ins>+ Ref<Attr> ensureAttr(const QualifiedName&);
</ins><span class="cx">
</span><span class="cx"> const Vector<RefPtr<Attr>>& attrNodeList();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomMessagePortcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/MessagePort.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/MessagePort.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/dom/MessagePort.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -160,7 +160,7 @@
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<MessagePortArray> ports = MessagePort::entanglePorts(*m_scriptExecutionContext, WTFMove(channels));
</span><del>- Ref<Event> event = MessageEvent::create(WTFMove(ports), message.release());
</del><ins>+ Ref<Event> event = MessageEvent::create(WTFMove(ports), WTFMove(message));
</ins><span class="cx"> dispatchEvent(event);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -214,9 +214,9 @@
</span><span class="cx">
</span><span class="cx"> auto portArray = std::make_unique<MessagePortArray>(channels->size());
</span><span class="cx"> for (unsigned int i = 0; i < channels->size(); ++i) {
</span><del>- RefPtr<MessagePort> port = MessagePort::create(context);
</del><ins>+ auto port = MessagePort::create(context);
</ins><span class="cx"> port->entangle(WTFMove((*channels)[i]));
</span><del>- (*portArray)[i] = port.release();
</del><ins>+ (*portArray)[i] = WTFMove(port);
</ins><span class="cx"> }
</span><span class="cx"> return portArray;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomNodeIteratorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/NodeIterator.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/NodeIterator.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/dom/NodeIterator.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -97,7 +97,7 @@
</span><span class="cx"> bool nodeWasAccepted = acceptNode(provisionalResult.get()) == NodeFilter::FILTER_ACCEPT;
</span><span class="cx"> if (nodeWasAccepted) {
</span><span class="cx"> m_referenceNode = m_candidateNode;
</span><del>- result = provisionalResult.release();
</del><ins>+ result = WTFMove(provisionalResult);
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -119,7 +119,7 @@
</span><span class="cx"> bool nodeWasAccepted = acceptNode(provisionalResult.get()) == NodeFilter::FILTER_ACCEPT;
</span><span class="cx"> if (nodeWasAccepted) {
</span><span class="cx"> m_referenceNode = m_candidateNode;
</span><del>- result = provisionalResult.release();
</del><ins>+ result = WTFMove(provisionalResult);
</ins><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoredomRangecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Range.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Range.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/dom/Range.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -670,13 +670,13 @@
</span><span class="cx"> endOffset = std::min(endOffset, static_cast<CharacterData*>(container)->length());
</span><span class="cx"> startOffset = std::min(startOffset, endOffset);
</span><span class="cx"> if (action == Extract || action == Clone) {
</span><del>- RefPtr<CharacterData> c = static_cast<CharacterData*>(container->cloneNode(true).ptr());
- deleteCharacterData(c, startOffset, endOffset, ec);
</del><ins>+ RefPtr<CharacterData> characters = static_cast<CharacterData*>(container->cloneNode(true).ptr());
+ deleteCharacterData(characters, startOffset, endOffset, ec);
</ins><span class="cx"> if (fragment) {
</span><span class="cx"> result = fragment;
</span><del>- result->appendChild(c.release(), ec);
</del><ins>+ result->appendChild(characters.release(), ec);
</ins><span class="cx"> } else
</span><del>- result = c.release();
</del><ins>+ result = WTFMove(characters);
</ins><span class="cx"> }
</span><span class="cx"> if (action == Extract || action == Delete)
</span><span class="cx"> downcast<CharacterData>(*container).deleteData(startOffset, endOffset - startOffset, ec);
</span><span class="lines">@@ -685,13 +685,13 @@
</span><span class="cx"> endOffset = std::min(endOffset, static_cast<ProcessingInstruction*>(container)->data().length());
</span><span class="cx"> startOffset = std::min(startOffset, endOffset);
</span><span class="cx"> if (action == Extract || action == Clone) {
</span><del>- RefPtr<ProcessingInstruction> c = static_cast<ProcessingInstruction*>(container->cloneNode(true).ptr());
- c->setData(c->data().substring(startOffset, endOffset - startOffset));
</del><ins>+ RefPtr<ProcessingInstruction> processingInstruction = static_cast<ProcessingInstruction*>(container->cloneNode(true).ptr());
+ processingInstruction->setData(processingInstruction->data().substring(startOffset, endOffset - startOffset));
</ins><span class="cx"> if (fragment) {
</span><span class="cx"> result = fragment;
</span><del>- result->appendChild(c.release(), ec);
</del><ins>+ result->appendChild(processingInstruction.release(), ec);
</ins><span class="cx"> } else
</span><del>- result = c.release();
</del><ins>+ result = WTFMove(processingInstruction);
</ins><span class="cx"> }
</span><span class="cx"> if (action == Extract || action == Delete) {
</span><span class="cx"> ProcessingInstruction& pi = downcast<ProcessingInstruction>(*container);
</span></span></pre></div>
<a id="trunkSourceWebCoredomStyledElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/StyledElement.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/StyledElement.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/dom/StyledElement.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -347,7 +347,7 @@
</span><span class="cx">
</span><span class="cx"> std::unique_ptr<PresentationAttributeCacheEntry> newEntry = std::make_unique<PresentationAttributeCacheEntry>();
</span><span class="cx"> newEntry->key = cacheKey;
</span><del>- newEntry->value = style.release();
</del><ins>+ newEntry->value = WTFMove(style);
</ins><span class="cx">
</span><span class="cx"> static const int presentationAttributeCacheMaximumSize = 4096;
</span><span class="cx"> if (presentationAttributeCache().size() > presentationAttributeCacheMaximumSize) {
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingApplyBlockElementCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ApplyBlockElementCommand.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ApplyBlockElementCommand.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/ApplyBlockElementCommand.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -292,12 +292,12 @@
</span><span class="cx"> return Position(text.get(), position.offsetInContainerNode() - 1);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Element> ApplyBlockElementCommand::createBlockElement()
</del><ins>+Ref<HTMLElement> ApplyBlockElementCommand::createBlockElement()
</ins><span class="cx"> {
</span><del>- RefPtr<Element> element = createHTMLElement(document(), m_tagName);
</del><ins>+ auto element = createHTMLElement(document(), m_tagName);
</ins><span class="cx"> if (m_inlineStyle.length())
</span><span class="cx"> element->setAttribute(styleAttr, m_inlineStyle);
</span><del>- return element.release();
</del><ins>+ return element;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingApplyBlockElementCommandh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ApplyBlockElementCommand.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ApplyBlockElementCommand.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/ApplyBlockElementCommand.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -42,7 +42,7 @@
</span><span class="cx"> ApplyBlockElementCommand(Document&, const QualifiedName& tagName);
</span><span class="cx">
</span><span class="cx"> virtual void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection);
</span><del>- PassRefPtr<Element> createBlockElement();
</del><ins>+ Ref<HTMLElement> createBlockElement();
</ins><span class="cx"> const QualifiedName tagName() const { return m_tagName; }
</span><span class="cx">
</span><span class="cx"> private:
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingApplyStyleCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ApplyStyleCommand.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ApplyStyleCommand.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/ApplyStyleCommand.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -398,9 +398,9 @@
</span><span class="cx"> } else if (node->isTextNode() && node->renderer() && node->parentNode() != lastStyledNode) {
</span><span class="cx"> // Last styled node was not parent node of this text node, but we wish to style this
</span><span class="cx"> // text node. To make this possible, add a style span to surround this text node.
</span><del>- RefPtr<HTMLElement> span = createStyleSpanElement(document());
</del><ins>+ auto span = createStyleSpanElement(document());
</ins><span class="cx"> surroundNodeRangeWithElement(node, node, span.get());
</span><del>- element = span.release();
</del><ins>+ element = WTFMove(span);
</ins><span class="cx"> } else {
</span><span class="cx"> // Only handle HTML elements and text nodes.
</span><span class="cx"> continue;
</span><span class="lines">@@ -422,7 +422,7 @@
</span><span class="cx"> if (inlineStyle->isEmpty()) {
</span><span class="cx"> removeNodeAttribute(element.get(), styleAttr);
</span><span class="cx"> if (isSpanWithoutAttributesOrUnstyledStyleSpan(element.get()))
</span><del>- unstyledSpans.append(element.release());
</del><ins>+ unstyledSpans.append(WTFMove(element));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingCompositeEditCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/CompositeEditCommand.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/CompositeEditCommand.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -394,7 +394,7 @@
</span><span class="cx"> command->setParent(nullptr);
</span><span class="cx"> ensureComposition()->append(toSimpleEditCommand(command.get()));
</span><span class="cx"> }
</span><del>- m_commands.append(command.release());
</del><ins>+ m_commands.append(WTFMove(command));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void CompositeEditCommand::applyCommandToComposite(PassRefPtr<CompositeEditCommand> command, const VisibleSelection& selection)
</span><span class="lines">@@ -1024,35 +1024,35 @@
</span><span class="cx"> deleteInsignificantText(pos, end);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Node> CompositeEditCommand::appendBlockPlaceholder(PassRefPtr<Element> container)
</del><ins>+RefPtr<Node> CompositeEditCommand::appendBlockPlaceholder(PassRefPtr<Element> container)
</ins><span class="cx"> {
</span><span class="cx"> if (!container)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><span class="cx"> // Should assert isBlockFlow || isInlineFlow when deletion improves. See 4244964.
</span><span class="cx"> ASSERT(container->renderer());
</span><span class="cx">
</span><del>- RefPtr<Node> placeholder = createBlockPlaceholderElement(document());
- appendNode(placeholder, container);
- return placeholder.release();
</del><ins>+ auto placeholder = createBlockPlaceholderElement(document());
+ appendNode(placeholder.ptr(), container);
+ return WTFMove(placeholder);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Node> CompositeEditCommand::insertBlockPlaceholder(const Position& pos)
</del><ins>+RefPtr<Node> CompositeEditCommand::insertBlockPlaceholder(const Position& pos)
</ins><span class="cx"> {
</span><span class="cx"> if (pos.isNull())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> // Should assert isBlockFlow || isInlineFlow when deletion improves. See 4244964.
</span><span class="cx"> ASSERT(pos.deprecatedNode()->renderer());
</span><span class="cx">
</span><del>- RefPtr<Node> placeholder = createBlockPlaceholderElement(document());
- insertNodeAt(placeholder, pos);
- return placeholder.release();
</del><ins>+ auto placeholder = createBlockPlaceholderElement(document());
+ insertNodeAt(placeholder.ptr(), pos);
+ return WTFMove(placeholder);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Node> CompositeEditCommand::addBlockPlaceholderIfNeeded(Element* container)
</del><ins>+RefPtr<Node> CompositeEditCommand::addBlockPlaceholderIfNeeded(Element* container)
</ins><span class="cx"> {
</span><span class="cx"> if (!container)
</span><span class="cx"> return nullptr;
</span><span class="lines">@@ -1086,17 +1086,17 @@
</span><span class="cx"> deleteTextFromNode(downcast<Text>(p.anchorNode()), p.offsetInContainerNode(), 1);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Node> CompositeEditCommand::insertNewDefaultParagraphElementAt(const Position& position)
</del><ins>+Ref<HTMLElement> CompositeEditCommand::insertNewDefaultParagraphElementAt(const Position& position)
</ins><span class="cx"> {
</span><del>- RefPtr<Element> paragraphElement = createDefaultParagraphElement(document());
</del><ins>+ auto paragraphElement = createDefaultParagraphElement(document());
</ins><span class="cx"> paragraphElement->appendChild(createBreakElement(document()), IGNORE_EXCEPTION);
</span><del>- insertNodeAt(paragraphElement, position);
- return paragraphElement.release();
</del><ins>+ insertNodeAt(paragraphElement.ptr(), position);
+ return paragraphElement;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // If the paragraph is not entirely within it's own block, create one and move the paragraph into
</span><span class="cx"> // it, and return that block. Otherwise return 0.
</span><del>-PassRefPtr<Node> CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary(const Position& pos)
</del><ins>+RefPtr<Node> CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary(const Position& pos)
</ins><span class="cx"> {
</span><span class="cx"> if (pos.isNull())
</span><span class="cx"> return nullptr;
</span><span class="lines">@@ -1148,16 +1148,16 @@
</span><span class="cx"> // If upstreamStart is not editable, then we can bail here.
</span><span class="cx"> if (!isEditablePosition(upstreamStart))
</span><span class="cx"> return nullptr;
</span><del>- RefPtr<Node> newBlock = insertNewDefaultParagraphElementAt(upstreamStart);
</del><ins>+ auto newBlock = insertNewDefaultParagraphElementAt(upstreamStart);
</ins><span class="cx">
</span><span class="cx"> bool endWasBr = visibleParagraphEnd.deepEquivalent().deprecatedNode()->hasTagName(brTag);
</span><span class="cx">
</span><del>- moveParagraphs(visibleParagraphStart, visibleParagraphEnd, VisiblePosition(firstPositionInNode(newBlock.get())));
</del><ins>+ moveParagraphs(visibleParagraphStart, visibleParagraphEnd, VisiblePosition(firstPositionInNode(newBlock.ptr())));
</ins><span class="cx">
</span><span class="cx"> if (newBlock->lastChild() && newBlock->lastChild()->hasTagName(brTag) && !endWasBr)
</span><span class="cx"> removeNode(newBlock->lastChild());
</span><span class="cx">
</span><del>- return newBlock.release();
</del><ins>+ return WTFMove(newBlock);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void CompositeEditCommand::pushAnchorElementDown(Element& anchorElement)
</span><span class="lines">@@ -1200,9 +1200,9 @@
</span><span class="cx">
</span><span class="cx"> for (size_t i = ancestors.size(); i != 0; --i) {
</span><span class="cx"> Node* item = ancestors[i - 1].get();
</span><del>- RefPtr<Node> child = item->cloneNode(isRenderedTable(item));
- appendNode(child, downcast<Element>(lastNode.get()));
- lastNode = child.release();
</del><ins>+ auto child = item->cloneNode(isRenderedTable(item));
+ appendNode(child.ptr(), downcast<Element>(lastNode.get()));
+ lastNode = WTFMove(child);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1227,9 +1227,9 @@
</span><span class="cx"> lastNode = lastNode->parentNode();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- RefPtr<Node> clonedNode = node->cloneNode(true);
- insertNodeAfter(clonedNode, lastNode);
- lastNode = clonedNode.release();
</del><ins>+ auto clonedNode = node->cloneNode(true);
+ insertNodeAfter(clonedNode.ptr(), lastNode);
+ lastNode = WTFMove(clonedNode);
</ins><span class="cx"> if (node == end.deprecatedNode() || end.deprecatedNode()->isDescendantOf(node.get()))
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="lines">@@ -1647,7 +1647,7 @@
</span><span class="cx">
</span><span class="cx"> // Splits the tree parent by parent until we reach the specified ancestor. We use VisiblePositions
</span><span class="cx"> // to determine if the split is necessary. Returns the last split node.
</span><del>-PassRefPtr<Node> CompositeEditCommand::splitTreeToNode(Node* start, Node* end, bool shouldSplitAncestor)
</del><ins>+RefPtr<Node> CompositeEditCommand::splitTreeToNode(Node* start, Node* end, bool shouldSplitAncestor)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(start);
</span><span class="cx"> ASSERT(end);
</span><span class="lines">@@ -1668,7 +1668,7 @@
</span><span class="cx"> splitElement(downcast<Element>(node->parentNode()), node);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return node.release();
</del><ins>+ return node;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<Element> createBlockPlaceholderElement(Document& document)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingCompositeEditCommandh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/CompositeEditCommand.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/CompositeEditCommand.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/CompositeEditCommand.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -170,14 +170,14 @@
</span><span class="cx"> void deleteInsignificantText(const Position& start, const Position& end);
</span><span class="cx"> void deleteInsignificantTextDownstream(const Position&);
</span><span class="cx">
</span><del>- PassRefPtr<Node> appendBlockPlaceholder(PassRefPtr<Element>);
- PassRefPtr<Node> insertBlockPlaceholder(const Position&);
- PassRefPtr<Node> addBlockPlaceholderIfNeeded(Element*);
</del><ins>+ RefPtr<Node> appendBlockPlaceholder(PassRefPtr<Element>);
+ RefPtr<Node> insertBlockPlaceholder(const Position&);
+ RefPtr<Node> addBlockPlaceholderIfNeeded(Element*);
</ins><span class="cx"> void removePlaceholderAt(const Position&);
</span><span class="cx">
</span><del>- PassRefPtr<Node> insertNewDefaultParagraphElementAt(const Position&);
</del><ins>+ Ref<HTMLElement> insertNewDefaultParagraphElementAt(const Position&);
</ins><span class="cx">
</span><del>- PassRefPtr<Node> moveParagraphContentsToNewBlockIfNecessary(const Position&);
</del><ins>+ RefPtr<Node> moveParagraphContentsToNewBlockIfNecessary(const Position&);
</ins><span class="cx">
</span><span class="cx"> void pushAnchorElementDown(Element&);
</span><span class="cx">
</span><span class="lines">@@ -192,7 +192,7 @@
</span><span class="cx">
</span><span class="cx"> Position positionAvoidingSpecialElementBoundary(const Position&);
</span><span class="cx">
</span><del>- PassRefPtr<Node> splitTreeToNode(Node*, Node*, bool splitAncestor = false);
</del><ins>+ RefPtr<Node> splitTreeToNode(Node*, Node*, bool splitAncestor = false);
</ins><span class="cx">
</span><span class="cx"> Vector<RefPtr<EditCommand>> m_commands;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditingStylecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/EditingStyle.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/EditingStyle.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/EditingStyle.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -151,7 +151,7 @@
</span><span class="cx"> static int legacyFontSizeFromCSSValue(Document*, CSSPrimitiveValue*, bool shouldUseFixedFontDefaultSize, LegacyFontSizeMode);
</span><span class="cx"> static bool isTransparentColorValue(CSSValue*);
</span><span class="cx"> static bool hasTransparentBackgroundColor(StyleProperties*);
</span><del>-static PassRefPtr<CSSValue> backgroundColorInEffect(Node*);
</del><ins>+static RefPtr<CSSValue> backgroundColorInEffect(Node*);
</ins><span class="cx">
</span><span class="cx"> class HTMLElementEquivalent {
</span><span class="cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class="lines">@@ -1185,11 +1185,10 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<EditingStyle> EditingStyle::wrappingStyleForSerialization(Node* context, bool shouldAnnotate)
</del><ins>+Ref<EditingStyle> EditingStyle::wrappingStyleForSerialization(Node* context, bool shouldAnnotate)
</ins><span class="cx"> {
</span><del>- RefPtr<EditingStyle> wrappingStyle;
</del><span class="cx"> if (shouldAnnotate) {
</span><del>- wrappingStyle = EditingStyle::create(context, EditingStyle::EditingPropertiesInEffect);
</del><ins>+ auto wrappingStyle = EditingStyle::create(context, EditingStyle::EditingPropertiesInEffect);
</ins><span class="cx">
</span><span class="cx"> // Styles that Mail blockquotes contribute should only be placed on the Mail blockquote,
</span><span class="cx"> // to help us differentiate those styles from ones that the user has applied.
</span><span class="lines">@@ -1199,10 +1198,10 @@
</span><span class="cx"> // Call collapseTextDecorationProperties first or otherwise it'll copy the value over from in-effect to text-decorations.
</span><span class="cx"> wrappingStyle->collapseTextDecorationProperties();
</span><span class="cx">
</span><del>- return wrappingStyle.release();
</del><ins>+ return wrappingStyle;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- wrappingStyle = EditingStyle::create();
</del><ins>+ auto wrappingStyle = EditingStyle::create();
</ins><span class="cx">
</span><span class="cx"> // When not annotating for interchange, we only preserve inline style declarations.
</span><span class="cx"> for (Node* node = context; node && !node->isDocumentNode(); node = node->parentNode()) {
</span><span class="lines">@@ -1212,7 +1211,7 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return wrappingStyle.release();
</del><ins>+ return wrappingStyle;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -1265,15 +1264,15 @@
</span><span class="cx"> m_fontSizeDelta += oldFontSizeDelta;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-static PassRefPtr<MutableStyleProperties> styleFromMatchedRulesForElement(Element* element, unsigned rulesToInclude)
</del><ins>+static Ref<MutableStyleProperties> styleFromMatchedRulesForElement(Element* element, unsigned rulesToInclude)
</ins><span class="cx"> {
</span><del>- RefPtr<MutableStyleProperties> style = MutableStyleProperties::create();
</del><ins>+ auto style = MutableStyleProperties::create();
</ins><span class="cx"> for (auto& matchedRule : element->styleResolver().styleRulesForElement(element, rulesToInclude)) {
</span><span class="cx"> if (matchedRule->isStyleRule())
</span><span class="cx"> style->mergeAndOverrideOnConflict(static_pointer_cast<StyleRule>(matchedRule)->properties());
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return style.release();
</del><ins>+ return style;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void EditingStyle::mergeStyleFromRules(StyledElement* element)
</span><span class="lines">@@ -1773,30 +1772,31 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename T>
</span><del>-static PassRefPtr<MutableStyleProperties> extractPropertiesNotIn(StyleProperties& styleWithRedundantProperties, T& baseStyle)
</del><ins>+static Ref<MutableStyleProperties> extractPropertiesNotIn(StyleProperties& styleWithRedundantProperties, T& baseStyle)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<EditingStyle> result = EditingStyle::create(&styleWithRedundantProperties);
</span><span class="cx"> result->removeEquivalentProperties(baseStyle);
</span><del>- RefPtr<MutableStyleProperties> mutableStyle = result->style();
</del><ins>+ ASSERT(result->style());
+ Ref<MutableStyleProperties> mutableStyle = *result->style();
</ins><span class="cx">
</span><span class="cx"> RefPtr<CSSValue> baseTextDecorationsInEffect = extractPropertyValue(baseStyle, CSSPropertyWebkitTextDecorationsInEffect);
</span><del>- diffTextDecorations(*mutableStyle, CSSPropertyTextDecoration, baseTextDecorationsInEffect.get());
- diffTextDecorations(*mutableStyle, CSSPropertyWebkitTextDecorationsInEffect, baseTextDecorationsInEffect.get());
</del><ins>+ diffTextDecorations(mutableStyle, CSSPropertyTextDecoration, baseTextDecorationsInEffect.get());
+ diffTextDecorations(mutableStyle, CSSPropertyWebkitTextDecorationsInEffect, baseTextDecorationsInEffect.get());
</ins><span class="cx">
</span><del>- if (extractPropertyValue(baseStyle, CSSPropertyFontWeight) && fontWeightIsBold(*mutableStyle) == fontWeightIsBold(baseStyle))
</del><ins>+ if (extractPropertyValue(baseStyle, CSSPropertyFontWeight) && fontWeightIsBold(mutableStyle) == fontWeightIsBold(baseStyle))
</ins><span class="cx"> mutableStyle->removeProperty(CSSPropertyFontWeight);
</span><span class="cx">
</span><del>- if (extractPropertyValue(baseStyle, CSSPropertyColor) && textColorFromStyle(*mutableStyle) == textColorFromStyle(baseStyle))
</del><ins>+ if (extractPropertyValue(baseStyle, CSSPropertyColor) && textColorFromStyle(mutableStyle) == textColorFromStyle(baseStyle))
</ins><span class="cx"> mutableStyle->removeProperty(CSSPropertyColor);
</span><span class="cx">
</span><span class="cx"> if (extractPropertyValue(baseStyle, CSSPropertyTextAlign)
</span><del>- && textAlignResolvingStartAndEnd(*mutableStyle) == textAlignResolvingStartAndEnd(baseStyle))
</del><ins>+ && textAlignResolvingStartAndEnd(mutableStyle) == textAlignResolvingStartAndEnd(baseStyle))
</ins><span class="cx"> mutableStyle->removeProperty(CSSPropertyTextAlign);
</span><span class="cx">
</span><del>- if (extractPropertyValue(baseStyle, CSSPropertyBackgroundColor) && backgroundColorFromStyle(*mutableStyle) == backgroundColorFromStyle(baseStyle))
</del><ins>+ if (extractPropertyValue(baseStyle, CSSPropertyBackgroundColor) && backgroundColorFromStyle(mutableStyle) == backgroundColorFromStyle(baseStyle))
</ins><span class="cx"> mutableStyle->removeProperty(CSSPropertyBackgroundColor);
</span><span class="cx">
</span><del>- return mutableStyle.release();
</del><ins>+ return mutableStyle;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> template<typename T>
</span><span class="lines">@@ -1849,15 +1849,15 @@
</span><span class="cx"> return isTransparentColorValue(cssValue.get());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<CSSValue> backgroundColorInEffect(Node* node)
</del><ins>+RefPtr<CSSValue> backgroundColorInEffect(Node* node)
</ins><span class="cx"> {
</span><span class="cx"> for (Node* ancestor = node; ancestor; ancestor = ancestor->parentNode()) {
</span><span class="cx"> if (RefPtr<CSSValue> value = ComputedStyleExtractor(ancestor).propertyValue(CSSPropertyBackgroundColor)) {
</span><span class="cx"> if (!isTransparentColorValue(value.get()))
</span><del>- return value.release();
</del><ins>+ return value;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditingStyleh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/EditingStyle.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/EditingStyle.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/EditingStyle.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -148,7 +148,7 @@
</span><span class="cx"> void mergeTypingStyle(Document&);
</span><span class="cx"> enum CSSPropertyOverrideMode { OverrideValues, DoNotOverrideValues };
</span><span class="cx"> void mergeInlineStyleOfElement(StyledElement*, CSSPropertyOverrideMode, PropertiesToInclude = AllProperties);
</span><del>- static PassRefPtr<EditingStyle> wrappingStyleForSerialization(Node* context, bool shouldAnnotate);
</del><ins>+ static Ref<EditingStyle> wrappingStyleForSerialization(Node* context, bool shouldAnnotate);
</ins><span class="cx"> void mergeStyleFromRules(StyledElement*);
</span><span class="cx"> void mergeStyleFromRulesForSerialization(StyledElement*);
</span><span class="cx"> void removeStyleFromRulesAndContext(StyledElement*, Node* context);
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/Editor.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/Editor.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/Editor.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -799,34 +799,34 @@
</span><span class="cx"> return canEditRichly() && DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel(&document());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Node> Editor::increaseSelectionListLevel()
</del><ins>+RefPtr<Node> Editor::increaseSelectionListLevel()
</ins><span class="cx"> {
</span><span class="cx"> if (!canEditRichly() || m_frame.selection().isNone())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> RefPtr<Node> newList = IncreaseSelectionListLevelCommand::increaseSelectionListLevel(&document());
</span><span class="cx"> revealSelectionAfterEditingOperation();
</span><span class="cx"> return newList;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Node> Editor::increaseSelectionListLevelOrdered()
</del><ins>+RefPtr<Node> Editor::increaseSelectionListLevelOrdered()
</ins><span class="cx"> {
</span><span class="cx"> if (!canEditRichly() || m_frame.selection().isNone())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> RefPtr<Node> newList = IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered(&document());
</span><span class="cx"> revealSelectionAfterEditingOperation();
</span><del>- return newList.release();
</del><ins>+ return newList;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Node> Editor::increaseSelectionListLevelUnordered()
</del><ins>+RefPtr<Node> Editor::increaseSelectionListLevelUnordered()
</ins><span class="cx"> {
</span><span class="cx"> if (!canEditRichly() || m_frame.selection().isNone())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> RefPtr<Node> newList = IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered(&document());
</span><span class="cx"> revealSelectionAfterEditingOperation();
</span><del>- return newList.release();
</del><ins>+ return newList;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void Editor::decreaseSelectionListLevel()
</span><span class="lines">@@ -3138,22 +3138,22 @@
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Range> Editor::findStringAndScrollToVisible(const String& target, Range* previousMatch, FindOptions options)
</del><ins>+RefPtr<Range> Editor::findStringAndScrollToVisible(const String& target, Range* previousMatch, FindOptions options)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<Range> nextMatch = rangeOfString(target, previousMatch, options);
</span><span class="cx"> if (!nextMatch)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> nextMatch->firstNode()->renderer()->scrollRectToVisible(nextMatch->absoluteBoundingBox(),
</span><span class="cx"> ScrollAlignment::alignCenterIfNeeded, ScrollAlignment::alignCenterIfNeeded);
</span><span class="cx">
</span><del>- return nextMatch.release();
</del><ins>+ return nextMatch;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Range> Editor::rangeOfString(const String& target, Range* referenceRange, FindOptions options)
</del><ins>+RefPtr<Range> Editor::rangeOfString(const String& target, Range* referenceRange, FindOptions options)
</ins><span class="cx"> {
</span><span class="cx"> if (target.isEmpty())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><span class="cx"> // Start from an edge of the reference range, if there's a reference range that's not in shadow content. Which edge
</span><span class="cx"> // is used depends on whether we're searching forward or backward, and whether startInSelection is set.
</span><span class="lines">@@ -3176,7 +3176,7 @@
</span><span class="cx"> searchRange->setStart(*shadowTreeRoot, 0);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- RefPtr<Range> resultRange(findPlainText(*searchRange, target, options));
</del><ins>+ RefPtr<Range> resultRange = findPlainText(*searchRange, target, options);
</ins><span class="cx"> // If we started in the reference range and the found range exactly matches the reference range, find again.
</span><span class="cx"> // Build a selection with the found range to remove collapsed whitespace.
</span><span class="cx"> // Compare ranges instead of selection objects to ignore the way that the current selection was made.
</span><span class="lines">@@ -3220,7 +3220,7 @@
</span><span class="cx"> // this should be a success case instead, so we'll just fall through in that case.
</span><span class="cx"> }
</span><span class="cx">
</span><del>- return resultRange->collapsed() ? nullptr : resultRange.release();
</del><ins>+ return resultRange->collapsed() ? nullptr : resultRange;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> static bool isFrameInRange(Frame* frame, Range* range)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingEditorh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/Editor.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/Editor.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/Editor.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -164,9 +164,9 @@
</span><span class="cx"> WEBCORE_EXPORT PassRefPtr<Node> insertUnorderedList();
</span><span class="cx"> WEBCORE_EXPORT bool canIncreaseSelectionListLevel();
</span><span class="cx"> WEBCORE_EXPORT bool canDecreaseSelectionListLevel();
</span><del>- WEBCORE_EXPORT PassRefPtr<Node> increaseSelectionListLevel();
- WEBCORE_EXPORT PassRefPtr<Node> increaseSelectionListLevelOrdered();
- WEBCORE_EXPORT PassRefPtr<Node> increaseSelectionListLevelUnordered();
</del><ins>+ WEBCORE_EXPORT RefPtr<Node> increaseSelectionListLevel();
+ WEBCORE_EXPORT RefPtr<Node> increaseSelectionListLevelOrdered();
+ WEBCORE_EXPORT RefPtr<Node> increaseSelectionListLevelUnordered();
</ins><span class="cx"> WEBCORE_EXPORT void decreaseSelectionListLevel();
</span><span class="cx">
</span><span class="cx"> void removeFormattingAndStyle();
</span><span class="lines">@@ -364,8 +364,8 @@
</span><span class="cx"> String selectedTextForDataTransfer() const;
</span><span class="cx"> WEBCORE_EXPORT bool findString(const String&, FindOptions);
</span><span class="cx">
</span><del>- PassRefPtr<Range> rangeOfString(const String&, Range*, FindOptions);
- PassRefPtr<Range> findStringAndScrollToVisible(const String&, Range*, FindOptions);
</del><ins>+ RefPtr<Range> rangeOfString(const String&, Range*, FindOptions);
+ RefPtr<Range> findStringAndScrollToVisible(const String&, Range*, FindOptions);
</ins><span class="cx">
</span><span class="cx"> const VisibleSelection& mark() const; // Mark, to be used as emacs uses it.
</span><span class="cx"> void setMark(const VisibleSelection&);
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingInsertParagraphSeparatorCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -131,19 +131,19 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Element> InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock(const Vector<RefPtr<Element>>& ancestors, PassRefPtr<Element> blockToInsert)
</del><ins>+RefPtr<Element> InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock(const Vector<RefPtr<Element>>& ancestors, PassRefPtr<Element> blockToInsert)
</ins><span class="cx"> {
</span><span class="cx"> // Make clones of ancestors in between the start node and the start block.
</span><span class="cx"> RefPtr<Element> parent = blockToInsert;
</span><span class="cx"> for (size_t i = ancestors.size(); i != 0; --i) {
</span><del>- RefPtr<Element> child = ancestors[i - 1]->cloneElementWithoutChildren(document());
</del><ins>+ auto child = ancestors[i - 1]->cloneElementWithoutChildren(document());
</ins><span class="cx"> // It should always be okay to remove id from the cloned elements, since the originals are not deleted.
</span><span class="cx"> child->removeAttribute(idAttr);
</span><del>- appendNode(child, parent);
- parent = child.release();
</del><ins>+ appendNode(child.ptr(), parent);
+ parent = WTFMove(child);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- return parent.release();
</del><ins>+ return parent;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void InsertParagraphSeparatorCommand::doApply()
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingInsertParagraphSeparatorCommandh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx"> void calculateStyleBeforeInsertion(const Position&);
</span><span class="cx"> void applyStyleAfterInsertion(Node* originalEnclosingBlock);
</span><span class="cx"> void getAncestorsInsideBlock(const Node* insertionNode, Element* outerBlock, Vector<RefPtr<Element>>& ancestors);
</span><del>- PassRefPtr<Element> cloneHierarchyUnderNewBlock(const Vector<RefPtr<Element>>& ancestors, PassRefPtr<Element> blockToInsert);
</del><ins>+ RefPtr<Element> cloneHierarchyUnderNewBlock(const Vector<RefPtr<Element>>& ancestors, PassRefPtr<Element> blockToInsert);
</ins><span class="cx">
</span><span class="cx"> bool shouldUseDefaultParagraphElement(Node*) const;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingMergeIdenticalElementsCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/MergeIdenticalElementsCommand.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/MergeIdenticalElementsCommand.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/MergeIdenticalElementsCommand.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> ASSERT(m_element1);
</span><span class="cx"> ASSERT(m_element2);
</span><span class="cx">
</span><del>- RefPtr<Node> atChild = m_atChild.release();
</del><ins>+ RefPtr<Node> atChild = WTFMove(m_atChild);
</ins><span class="cx">
</span><span class="cx"> ContainerNode* parent = m_element2->parentNode();
</span><span class="cx"> if (!parent || !parent->hasEditableStyle())
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingModifySelectionListLevelcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ModifySelectionListLevel.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ModifySelectionListLevel.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/ModifySelectionListLevel.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -198,7 +198,7 @@
</span><span class="cx"> }
</span><span class="cx"> insertNodeBefore(newParent, startListChild);
</span><span class="cx"> appendSiblingNodeRange(startListChild, endListChild, newParent.get());
</span><del>- m_listElement = newParent.release();
</del><ins>+ m_listElement = WTFMove(newParent);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -209,13 +209,13 @@
</span><span class="cx"> return canIncreaseListLevel(document->frame()->selection().selection(), startListChild, endListChild);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevel(Document* document, Type type)
</del><ins>+RefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevel(Document* document, Type type)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT(document);
</span><span class="cx"> ASSERT(document->frame());
</span><del>- RefPtr<IncreaseSelectionListLevelCommand> command = create(*document, type);
</del><ins>+ auto command = create(*document, type);
</ins><span class="cx"> command->apply();
</span><del>- return command->m_listElement.release();
</del><ins>+ return WTFMove(command->m_listElement);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> PassRefPtr<Node> IncreaseSelectionListLevelCommand::increaseSelectionListLevel(Document* document)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingModifySelectionListLevelh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ModifySelectionListLevel.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ModifySelectionListLevel.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/ModifySelectionListLevel.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> enum Type { InheritedListType, OrderedList, UnorderedList };
</span><del>- static PassRefPtr<Node> increaseSelectionListLevel(Document*, Type);
</del><ins>+ static RefPtr<Node> increaseSelectionListLevel(Document*, Type);
</ins><span class="cx">
</span><span class="cx"> static Ref<IncreaseSelectionListLevelCommand> create(Document& document, Type type)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingRemoveNodeCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/RemoveNodeCommand.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/RemoveNodeCommand.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/RemoveNodeCommand.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -58,8 +58,8 @@
</span><span class="cx">
</span><span class="cx"> void RemoveNodeCommand::doUnapply()
</span><span class="cx"> {
</span><del>- RefPtr<ContainerNode> parent = m_parent.release();
- RefPtr<Node> refChild = m_refChild.release();
</del><ins>+ RefPtr<ContainerNode> parent = WTFMove(m_parent);
+ RefPtr<Node> refChild = WTFMove(m_refChild);
</ins><span class="cx"> if (!parent || !parent->hasEditableStyle())
</span><span class="cx"> return;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingRemoveNodePreservingChildrenCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -47,7 +47,7 @@
</span><span class="cx">
</span><span class="cx"> size_t size = children.size();
</span><span class="cx"> for (size_t i = 0; i < size; ++i) {
</span><del>- RefPtr<Node> child = children[i].release();
</del><ins>+ RefPtr<Node> child = WTFMove(children[i]);
</ins><span class="cx"> removeNode(child, m_shouldAssumeContentIsAlwaysEditable);
</span><span class="cx"> insertNodeBefore(child.release(), m_node, m_shouldAssumeContentIsAlwaysEditable);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingReplaceSelectionCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -86,7 +86,7 @@
</span><span class="cx"> void removeNodePreservingChildren(PassRefPtr<Node>);
</span><span class="cx">
</span><span class="cx"> private:
</span><del>- PassRefPtr<StyledElement> insertFragmentForTestRendering(Node* rootEditableNode);
</del><ins>+ Ref<HTMLElement> insertFragmentForTestRendering(Node* rootEditableNode);
</ins><span class="cx"> void removeUnrenderedNodes(Node*);
</span><span class="cx"> void restoreAndRemoveTestRenderingNodesToFragment(StyledElement*);
</span><span class="cx"> void removeInterchangeNodes(Node*);
</span><span class="lines">@@ -252,15 +252,15 @@
</span><span class="cx"> parent->insertBefore(*node, refNode, ASSERT_NO_EXCEPTION);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<StyledElement> ReplacementFragment::insertFragmentForTestRendering(Node* rootEditableElement)
</del><ins>+Ref<HTMLElement> ReplacementFragment::insertFragmentForTestRendering(Node* rootEditableElement)
</ins><span class="cx"> {
</span><del>- RefPtr<StyledElement> holder = createDefaultParagraphElement(document());
</del><ins>+ auto holder = createDefaultParagraphElement(document());
</ins><span class="cx">
</span><span class="cx"> holder->appendChild(*m_fragment, ASSERT_NO_EXCEPTION);
</span><del>- rootEditableElement->appendChild(holder.get(), ASSERT_NO_EXCEPTION);
</del><ins>+ rootEditableElement->appendChild(holder.ptr(), ASSERT_NO_EXCEPTION);
</ins><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><del>- return holder.release();
</del><ins>+ return holder;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment(StyledElement* holder)
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingSpellingCorrectionCommandcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/SpellingCorrectionCommand.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/SpellingCorrectionCommand.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/SpellingCorrectionCommand.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -101,16 +101,14 @@
</span><span class="cx"> if (!m_rangeToBeCorrected)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- RefPtr<DocumentFragment> fragment = createFragmentFromText(*m_rangeToBeCorrected, m_correction);
- if (!fragment)
- return;
</del><ins>+ auto fragment = createFragmentFromText(*m_rangeToBeCorrected, m_correction);
</ins><span class="cx">
</span><span class="cx"> applyCommandToComposite(SetSelectionCommand::create(m_selectionToBeCorrected, FrameSelection::defaultSetSelectionOptions() | FrameSelection::SpellCorrectionTriggered));
</span><span class="cx"> #if USE(AUTOCORRECTION_PANEL)
</span><span class="cx"> applyCommandToComposite(SpellingCorrectionRecordUndoCommand::create(document(), m_corrected, m_correction));
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>- applyCommandToComposite(ReplaceSelectionCommand::create(document(), fragment.release(), ReplaceSelectionCommand::MatchStyle, EditActionPaste));
</del><ins>+ applyCommandToComposite(ReplaceSelectionCommand::create(document(), WTFMove(fragment), ReplaceSelectionCommand::MatchStyle, EditActionPaste));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool SpellingCorrectionCommand::shouldRetainAutocorrectionIndicator() const
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingmacDictionaryLookuph"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/mac/DictionaryLookup.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/mac/DictionaryLookup.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/mac/DictionaryLookup.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -52,8 +52,8 @@
</span><span class="cx">
</span><span class="cx"> class DictionaryLookup {
</span><span class="cx"> public:
</span><del>- WEBCORE_EXPORT static PassRefPtr<Range> rangeForSelection(const VisibleSelection&, NSDictionary **options);
- WEBCORE_EXPORT static PassRefPtr<Range> rangeAtHitTestResult(const HitTestResult&, NSDictionary **options);
</del><ins>+ WEBCORE_EXPORT static RefPtr<Range> rangeForSelection(const VisibleSelection&, NSDictionary **options);
+ WEBCORE_EXPORT static RefPtr<Range> rangeAtHitTestResult(const HitTestResult&, NSDictionary **options);
</ins><span class="cx"> WEBCORE_EXPORT static NSString *stringForPDFSelection(PDFSelection *, NSDictionary **options);
</span><span class="cx">
</span><span class="cx"> // FIXME: Should move/unify dictionaryPopupInfoForRange here too.
</span></span></pre></div>
<a id="trunkSourceWebCoreeditingmacDictionaryLookupmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/editing/mac/DictionaryLookup.mm (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/editing/mac/DictionaryLookup.mm 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/editing/mac/DictionaryLookup.mm 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -65,7 +65,7 @@
</span><span class="cx"> return selectedRange->contains(position);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Range> DictionaryLookup::rangeForSelection(const VisibleSelection& selection, NSDictionary **options)
</del><ins>+RefPtr<Range> DictionaryLookup::rangeForSelection(const VisibleSelection& selection, NSDictionary **options)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<Range> selectedRange = selection.toNormalizedRange();
</span><span class="cx"> if (!selectedRange)
</span><span class="lines">@@ -90,10 +90,10 @@
</span><span class="cx"> [luLookupDefinitionModule tokenRangeForString:fullPlainTextString range:rangeToPass options:options];
</span><span class="cx"> END_BLOCK_OBJC_EXCEPTIONS;
</span><span class="cx">
</span><del>- return selectedRange.release();
</del><ins>+ return selectedRange;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<Range> DictionaryLookup::rangeAtHitTestResult(const HitTestResult& hitTestResult, NSDictionary **options)
</del><ins>+RefPtr<Range> DictionaryLookup::rangeAtHitTestResult(const HitTestResult& hitTestResult, NSDictionary **options)
</ins><span class="cx"> {
</span><span class="cx"> Node* node = hitTestResult.innerNonSharedNode();
</span><span class="cx"> if (!node)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLFormElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -462,7 +462,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> event->setTarget(this);
</span><del>- m_pendingAutocompleteEvents.append(event.release());
</del><ins>+ m_pendingAutocompleteEvents.append(WTFMove(event));
</ins><span class="cx">
</span><span class="cx"> // Dispatch events later as this API is meant to work asynchronously in all situations and implementations.
</span><span class="cx"> if (!m_requestAutocompleteTimer.isActive())
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -900,7 +900,7 @@
</span><span class="cx"> // Don't set the event target, the event queue will set it in GenericEventQueue::timerFired and setting it here
</span><span class="cx"> // will trigger an ASSERT if this element has been marked for deletion.
</span><span class="cx">
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::pendingActionTimerFired()
</span><span class="lines">@@ -1619,11 +1619,11 @@
</span><span class="cx"> if (eventTasks[i].second->startTime() >= eventTasks[i].second->endTime()) {
</span><span class="cx"> event = Event::create(eventNames().enterEvent, false, false);
</span><span class="cx"> event->setTarget(eventTasks[i].second);
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx">
</span><span class="cx"> event = Event::create(eventNames().exitEvent, false, false);
</span><span class="cx"> event->setTarget(eventTasks[i].second);
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx"> } else {
</span><span class="cx"> if (eventTasks[i].first == eventTasks[i].second->startMediaTime())
</span><span class="cx"> event = Event::create(eventNames().enterEvent, false, false);
</span><span class="lines">@@ -1631,7 +1631,7 @@
</span><span class="cx"> event = Event::create(eventNames().exitEvent, false, false);
</span><span class="cx">
</span><span class="cx"> event->setTarget(eventTasks[i].second);
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1645,7 +1645,7 @@
</span><span class="cx"> RefPtr<Event> event = Event::create(eventNames().cuechangeEvent, false, false);
</span><span class="cx"> event->setTarget(affectedTracks[i]);
</span><span class="cx">
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx">
</span><span class="cx"> // ... if the text track has a corresponding track element, to then fire a
</span><span class="cx"> // simple event named cuechange at the track element as well.
</span><span class="lines">@@ -1655,7 +1655,7 @@
</span><span class="cx"> ASSERT(trackElement);
</span><span class="cx"> event->setTarget(trackElement);
</span><span class="cx">
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2353,9 +2353,9 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- RefPtr<Event> event = MediaKeyNeededEvent::create(eventNames().webkitneedkeyEvent, initData);
</del><ins>+ auto event = MediaKeyNeededEvent::create(eventNames().webkitneedkeyEvent, initData);
</ins><span class="cx"> event->setTarget(this);
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx">
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -3605,7 +3605,7 @@
</span><span class="cx"> removeVideoTrack(m_videoTracks->lastItem());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<TextTrack> HTMLMediaElement::addTextTrack(const String& kind, const String& label, const String& language, ExceptionCode& ec)
</del><ins>+RefPtr<TextTrack> HTMLMediaElement::addTextTrack(const String& kind, const String& label, const String& language, ExceptionCode& ec)
</ins><span class="cx"> {
</span><span class="cx"> // 4.8.10.12.4 Text track API
</span><span class="cx"> // The addTextTrack(kind, label, language) method of media elements, when invoked, must run the following steps:
</span><span class="lines">@@ -3613,7 +3613,7 @@
</span><span class="cx"> // 1. If kind is not one of the following strings, then throw a SyntaxError exception and abort these steps
</span><span class="cx"> if (!TextTrack::isValidKindKeyword(kind)) {
</span><span class="cx"> ec = TypeError;
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // 2. If the label argument was omitted, let label be the empty string.
</span><span class="lines">@@ -3622,13 +3622,13 @@
</span><span class="cx">
</span><span class="cx"> // 5. Create a new text track corresponding to the new object, and set its text track kind to kind, its text
</span><span class="cx"> // track label to label, its text track language to language...
</span><del>- RefPtr<TextTrack> textTrack = TextTrack::create(ActiveDOMObject::scriptExecutionContext(), this, kind, emptyString(), label, language);
</del><ins>+ auto textTrack = TextTrack::create(ActiveDOMObject::scriptExecutionContext(), this, kind, emptyString(), label, language);
</ins><span class="cx">
</span><span class="cx"> // Note, due to side effects when changing track parameters, we have to
</span><span class="cx"> // first append the track to the text track list.
</span><span class="cx">
</span><span class="cx"> // 6. Add the new text track to the media element's list of text tracks.
</span><del>- addTextTrack(textTrack);
</del><ins>+ addTextTrack(textTrack.ptr());
</ins><span class="cx">
</span><span class="cx"> // ... its text track readiness state to the text track loaded state ...
</span><span class="cx"> textTrack->setReadinessState(TextTrack::Loaded);
</span><span class="lines">@@ -3636,7 +3636,7 @@
</span><span class="cx"> // ... its text track mode to the text track hidden mode, and its text track list of cues to an empty list ...
</span><span class="cx"> textTrack->setMode(TextTrack::Mode::Hidden);
</span><span class="cx">
</span><del>- return textTrack.release();
</del><ins>+ return WTFMove(textTrack);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> AudioTrackList* HTMLMediaElement::audioTracks()
</span><span class="lines">@@ -5193,9 +5193,9 @@
</span><span class="cx"> {
</span><span class="cx"> bool hasTargets = m_mediaSession->hasWirelessPlaybackTargets(*this);
</span><span class="cx"> LOG(Media, "HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent(%p) - hasTargets = %s", this, boolString(hasTargets));
</span><del>- RefPtr<Event> event = WebKitPlaybackTargetAvailabilityEvent::create(eventNames().webkitplaybacktargetavailabilitychangedEvent, hasTargets);
</del><ins>+ auto event = WebKitPlaybackTargetAvailabilityEvent::create(eventNames().webkitplaybacktargetavailabilitychangedEvent, hasTargets);
</ins><span class="cx"> event->setTarget(this);
</span><del>- m_asyncEventQueue.enqueueEvent(event.release());
</del><ins>+ m_asyncEventQueue.enqueueEvent(WTFMove(event));
</ins><span class="cx"> updateMediaState(UpdateMediaState::Asynchronously);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -267,7 +267,7 @@
</span><span class="cx"> double percentLoaded() const;
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- PassRefPtr<TextTrack> addTextTrack(const String& kind, const String& label, const String& language, ExceptionCode&);
</del><ins>+ RefPtr<TextTrack> addTextTrack(const String& kind, const String& label, const String& language, ExceptionCode&);
</ins><span class="cx">
</span><span class="cx"> AudioTrackList* audioTracks();
</span><span class="cx"> TextTrackList* textTracks();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasOESVertexArrayObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/canvas/OESVertexArrayObject.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -48,14 +48,14 @@
</span><span class="cx"> return OESVertexArrayObjectName;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<WebGLVertexArrayObjectOES> OESVertexArrayObject::createVertexArrayOES()
</del><ins>+RefPtr<WebGLVertexArrayObjectOES> OESVertexArrayObject::createVertexArrayOES()
</ins><span class="cx"> {
</span><span class="cx"> if (m_context->isContextLost())
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- RefPtr<WebGLVertexArrayObjectOES> o = WebGLVertexArrayObjectOES::create(m_context, WebGLVertexArrayObjectOES::VAOTypeUser);
- m_context->addContextObject(o.get());
- return o.release();
</del><ins>+ auto object = WebGLVertexArrayObjectOES::create(m_context, WebGLVertexArrayObjectOES::VAOTypeUser);
+ m_context->addContextObject(object.ptr());
+ return WTFMove(object);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void OESVertexArrayObject::deleteVertexArrayOES(WebGLVertexArrayObjectOES* arrayObject)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasOESVertexArrayObjecth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/OESVertexArrayObject.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/OESVertexArrayObject.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/canvas/OESVertexArrayObject.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -43,7 +43,7 @@
</span><span class="cx">
</span><span class="cx"> ExtensionName getName() const override;
</span><span class="cx">
</span><del>- PassRefPtr<WebGLVertexArrayObjectOES> createVertexArrayOES();
</del><ins>+ RefPtr<WebGLVertexArrayObjectOES> createVertexArrayOES();
</ins><span class="cx"> void deleteVertexArrayOES(WebGLVertexArrayObjectOES*);
</span><span class="cx"> GC3Dboolean isVertexArrayOES(WebGLVertexArrayObjectOES*);
</span><span class="cx"> void bindVertexArrayOES(WebGLVertexArrayObjectOES*, ExceptionCode&);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLRenderingContextBasecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -2201,7 +2201,7 @@
</span><span class="cx"> return WebGLGetInfo(static_cast<unsigned int>(value));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<WebGLContextAttributes> WebGLRenderingContextBase::getContextAttributes()
</del><ins>+RefPtr<WebGLContextAttributes> WebGLRenderingContextBase::getContextAttributes()
</ins><span class="cx"> {
</span><span class="cx"> if (isContextLostOrPending())
</span><span class="cx"> return nullptr;
</span><span class="lines">@@ -2211,12 +2211,12 @@
</span><span class="cx"> // Also, we need to enforce requested values of "false" for depth
</span><span class="cx"> // and stencil, regardless of the properties of the underlying
</span><span class="cx"> // GraphicsContext3D.
</span><del>- RefPtr<WebGLContextAttributes> attributes = WebGLContextAttributes::create(m_context->getContextAttributes());
</del><ins>+ auto attributes = WebGLContextAttributes::create(m_context->getContextAttributes());
</ins><span class="cx"> if (!m_attributes.depth)
</span><span class="cx"> attributes->setDepth(false);
</span><span class="cx"> if (!m_attributes.stencil)
</span><span class="cx"> attributes->setStencil(false);
</span><del>- return attributes.release();
</del><ins>+ return WTFMove(attributes);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> GC3Denum WebGLRenderingContextBase::getError()
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlcanvasWebGLRenderingContextBaseh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -197,7 +197,7 @@
</span><span class="cx"> bool getAttachedShaders(WebGLProgram*, Vector<RefPtr<WebGLShader>>&, ExceptionCode&);
</span><span class="cx"> GC3Dint getAttribLocation(WebGLProgram*, const String& name);
</span><span class="cx"> WebGLGetInfo getBufferParameter(GC3Denum target, GC3Denum pname, ExceptionCode&);
</span><del>- PassRefPtr<WebGLContextAttributes> getContextAttributes();
</del><ins>+ RefPtr<WebGLContextAttributes> getContextAttributes();
</ins><span class="cx"> GC3Denum getError();
</span><span class="cx"> virtual WebGLExtension* getExtension(const String& name) = 0;
</span><span class="cx"> virtual WebGLGetInfo getFramebufferAttachmentParameter(GC3Denum target, GC3Denum attachment, GC3Denum pname, ExceptionCode&) = 0;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVTTCuecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VTTCue.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VTTCue.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/track/VTTCue.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -502,27 +502,26 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<DocumentFragment> VTTCue::getCueAsHTML()
</del><ins>+RefPtr<DocumentFragment> VTTCue::getCueAsHTML()
</ins><span class="cx"> {
</span><span class="cx"> createWebVTTNodeTree();
</span><span class="cx"> if (!m_webVTTNodeTree)
</span><del>- return 0;
</del><ins>+ return nullptr;
</ins><span class="cx">
</span><del>- RefPtr<DocumentFragment> clonedFragment = DocumentFragment::create(ownerDocument());
- copyWebVTTNodeToDOMTree(m_webVTTNodeTree.get(), clonedFragment.get());
- return clonedFragment.release();
</del><ins>+ auto clonedFragment = DocumentFragment::create(ownerDocument());
+ copyWebVTTNodeToDOMTree(m_webVTTNodeTree.get(), clonedFragment.ptr());
+ return WTFMove(clonedFragment);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<DocumentFragment> VTTCue::createCueRenderingTree()
</del><ins>+RefPtr<DocumentFragment> VTTCue::createCueRenderingTree()
</ins><span class="cx"> {
</span><del>- RefPtr<DocumentFragment> clonedFragment;
</del><span class="cx"> createWebVTTNodeTree();
</span><span class="cx"> if (!m_webVTTNodeTree)
</span><span class="cx"> return nullptr;
</span><span class="cx">
</span><del>- clonedFragment = DocumentFragment::create(ownerDocument());
- m_webVTTNodeTree->cloneChildNodes(*clonedFragment);
- return clonedFragment.release();
</del><ins>+ auto clonedFragment = DocumentFragment::create(ownerDocument());
+ m_webVTTNodeTree->cloneChildNodes(clonedFragment);
+ return WTFMove(clonedFragment);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void VTTCue::setRegionId(const String& regionId)
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackVTTCueh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/VTTCue.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/VTTCue.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/track/VTTCue.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -114,8 +114,8 @@
</span><span class="cx"> const String& cueSettings() const { return m_settings; }
</span><span class="cx"> void setCueSettings(const String&);
</span><span class="cx">
</span><del>- PassRefPtr<DocumentFragment> getCueAsHTML();
- PassRefPtr<DocumentFragment> createCueRenderingTree();
</del><ins>+ RefPtr<DocumentFragment> getCueAsHTML();
+ RefPtr<DocumentFragment> createCueRenderingTree();
</ins><span class="cx">
</span><span class="cx"> const String& regionId() const { return m_regionId; }
</span><span class="cx"> void setRegionId(const String&);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackWebVTTElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/WebVTTElement.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/WebVTTElement.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/track/WebVTTElement.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -87,7 +87,7 @@
</span><span class="cx"> return WTFMove(clone);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<HTMLElement> WebVTTElement::createEquivalentHTMLElement(Document& document)
</del><ins>+Ref<HTMLElement> WebVTTElement::createEquivalentHTMLElement(Document& document)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<HTMLElement> htmlElement;
</span><span class="cx">
</span><span class="lines">@@ -119,7 +119,7 @@
</span><span class="cx"> ASSERT(htmlElement);
</span><span class="cx"> if (htmlElement)
</span><span class="cx"> htmlElement->setAttribute(HTMLNames::classAttr, fastGetAttribute(HTMLNames::classAttr));
</span><del>- return htmlElement.release();
</del><ins>+ return htmlElement.releaseNonNull();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> } // namespace WebCore
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackWebVTTElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/WebVTTElement.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/WebVTTElement.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/track/WebVTTElement.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -48,7 +48,7 @@
</span><span class="cx"> class WebVTTElement final : public Element {
</span><span class="cx"> public:
</span><span class="cx"> static Ref<WebVTTElement> create(const WebVTTNodeType, Document&);
</span><del>- PassRefPtr<HTMLElement> createEquivalentHTMLElement(Document&);
</del><ins>+ Ref<HTMLElement> createEquivalentHTMLElement(Document&);
</ins><span class="cx">
</span><span class="cx"> Ref<Element> cloneElementWithoutAttributesAndChildren(Document&) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackWebVTTParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/WebVTTParser.cpp (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/WebVTTParser.cpp 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/track/WebVTTParser.cpp 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -364,7 +364,7 @@
</span><span class="cx"> WebVTTTreeBuilder(Document& document)
</span><span class="cx"> : m_document(document) { }
</span><span class="cx">
</span><del>- PassRefPtr<DocumentFragment> buildFromString(const String& cueText);
</del><ins>+ Ref<DocumentFragment> buildFromString(const String& cueText);
</ins><span class="cx">
</span><span class="cx"> private:
</span><span class="cx"> void constructTreeFromToken(Document&);
</span><span class="lines">@@ -375,19 +375,19 @@
</span><span class="cx"> Document& m_document;
</span><span class="cx"> };
</span><span class="cx">
</span><del>-PassRefPtr<DocumentFragment> WebVTTTreeBuilder::buildFromString(const String& cueText)
</del><ins>+Ref<DocumentFragment> WebVTTTreeBuilder::buildFromString(const String& cueText)
</ins><span class="cx"> {
</span><span class="cx"> // Cue text processing based on
</span><span class="cx"> // 5.4 WebVTT cue text parsing rules, and
</span><span class="cx"> // 5.5 WebVTT cue text DOM construction rules.
</span><del>- RefPtr<DocumentFragment> fragment = DocumentFragment::create(m_document);
</del><ins>+ auto fragment = DocumentFragment::create(m_document);
</ins><span class="cx">
</span><span class="cx"> if (cueText.isEmpty()) {
</span><span class="cx"> fragment->parserAppendChild(Text::create(m_document, emptyString()));
</span><del>- return fragment.release();
</del><ins>+ return fragment;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- m_currentNode = fragment;
</del><ins>+ m_currentNode = fragment.ptr();
</ins><span class="cx">
</span><span class="cx"> WebVTTTokenizer tokenizer(cueText);
</span><span class="cx"> m_languageStack.clear();
</span><span class="lines">@@ -395,10 +395,10 @@
</span><span class="cx"> while (tokenizer.nextToken(m_token))
</span><span class="cx"> constructTreeFromToken(m_document);
</span><span class="cx">
</span><del>- return fragment.release();
</del><ins>+ return fragment;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-PassRefPtr<DocumentFragment> WebVTTParser::createDocumentFragmentFromCueText(Document& document, const String& cueText)
</del><ins>+Ref<DocumentFragment> WebVTTParser::createDocumentFragmentFromCueText(Document& document, const String& cueText)
</ins><span class="cx"> {
</span><span class="cx"> WebVTTTreeBuilder treeBuilder(document);
</span><span class="cx"> return treeBuilder.buildFromString(cueText);
</span></span></pre></div>
<a id="trunkSourceWebCorehtmltrackWebVTTParserh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/track/WebVTTParser.h (200625 => 200626)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/track/WebVTTParser.h 2016-05-10 17:05:50 UTC (rev 200625)
+++ trunk/Source/WebCore/html/track/WebVTTParser.h 2016-05-10 17:23:09 UTC (rev 200626)
</span><span class="lines">@@ -144,7 +144,7 @@
</span><span class="cx"> void getNewRegions(Vector<RefPtr<VTTRegion>>&);
</span><span class="cx">
</span><span class="cx"> // Create the DocumentFragment representation of the WebVTT cue text.
</span><del>- static PassRefPtr<DocumentFragment> createDocumentFragmentFromCueText(Document&, const String&);
</del><ins>+ static Ref<DocumentFragment> createDocumentFragmentFromCueText(Document&, const String&);
</ins><span class="cx">
</span><span class="cx"> protected:
</span><span class="cx"> ScriptExecutionContext* m_scriptExecutionContext;
</span></span></pre>
</div>
</div>
</body>
</html>