<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200622] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200622">200622</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2016-05-10 08:27:02 -0700 (Tue, 10 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/193610">r193610</a>): Drop down menu doesn’t expand at allofbach.com
https://bugs.webkit.org/show_bug.cgi?id=157445
Reviewed by Simon Fraser.
When we don't run transitions (becasuse of to/from 'auto' values) we should also not
report the 'from' value and behave as if we finished the transition already.
Source/WebCore:
Test: fast/animation/height-auto-transition-computed-value.html
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): This is a revert of
looping the 'to' value back to the first keyframe when reverse animation is at the start value (last keyframe).
* platform/Length.cpp:
(WebCore::blend):
LayoutTests:
* fast/animation/height-auto-transition-computed-value-expected.html: Added.
* fast/animation/height-auto-transition-computed-value.html: Added.
* imported/blink/transitions/transition-not-interpolable-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsimportedblinktransitionstransitionnotinterpolableexpectedtxt">trunk/LayoutTests/imported/blink/transitions/transition-not-interpolable-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorTestExpectations">trunk/LayoutTests/platform/ios-simulator/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorepageanimationKeyframeAnimationcpp">trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformLengthcpp">trunk/Source/WebCore/platform/Length.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastanimationheightautotransitioncomputedvalueexpectedhtml">trunk/LayoutTests/fast/animation/height-auto-transition-computed-value-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastanimationheightautotransitioncomputedvaluehtml">trunk/LayoutTests/fast/animation/height-auto-transition-computed-value.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (200621 => 200622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-05-10 14:56:00 UTC (rev 200621)
+++ trunk/LayoutTests/ChangeLog 2016-05-10 15:27:02 UTC (rev 200622)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-05-10 Zalan Bujtas <zalan@apple.com>
+
+ REGRESSION (r193610): Drop down menu doesn’t expand at allofbach.com
+ https://bugs.webkit.org/show_bug.cgi?id=157445
+
+ Reviewed by Simon Fraser.
+
+ When we don't run transitions (becasuse of to/from 'auto' values) we should also not
+ report the 'from' value and behave as if we finished the transition already.
+
+ * fast/animation/height-auto-transition-computed-value-expected.html: Added.
+ * fast/animation/height-auto-transition-computed-value.html: Added.
+ * imported/blink/transitions/transition-not-interpolable-expected.txt:
+
</ins><span class="cx"> 2016-05-09 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] <select> elements should render right-aligned when in RTL mode
</span></span></pre></div>
<a id="trunkLayoutTestsfastanimationheightautotransitioncomputedvalueexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/animation/height-auto-transition-computed-value-expected.html (0 => 200622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/animation/height-auto-transition-computed-value-expected.html (rev 0)
+++ trunk/LayoutTests/fast/animation/height-auto-transition-computed-value-expected.html 2016-05-10 15:27:02 UTC (rev 200622)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that auto transition returns the proper computed value.</title>
+<style>
+#dropdown {
+ overflow: hidden;
+ border: 1px solid red;
+ height: 18px;
+ transition: height 1s ease-out;
+}
+</style>
+</head>
+<body>
+<div id=dropdown></div>
+PASS if you can see foobar above.
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastanimationheightautotransitioncomputedvaluehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/animation/height-auto-transition-computed-value.html (0 => 200622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/animation/height-auto-transition-computed-value.html (rev 0)
+++ trunk/LayoutTests/fast/animation/height-auto-transition-computed-value.html 2016-05-10 15:27:02 UTC (rev 200622)
</span><span class="lines">@@ -0,0 +1,35 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that auto transition returns the proper computed value.</title>
+<style>
+#dropdown {
+ font-size: 16px;
+ font-family: ahem;
+ color: white;
+ overflow: hidden;
+ border: 1px solid red;
+ height: 0px;
+ transition: height 1s ease-out;
+}
+</style>
+</head>
+<body>
+<div id=dropdown>foobar</div>
+PASS if you can see foobar above.
+
+<script>
+if (window.testRunner)
+ testRunner.waitUntilDone();
+
+setTimeout(function() {
+ var element = document.getElementById("dropdown");
+ element.style.height = 'auto';
+ var h = element.offsetHeight;
+ element.style.height = h + 'px';
+ if (window.testRunner)
+ testRunner.notifyDone();
+}, 0);
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkLayoutTestsimportedblinktransitionstransitionnotinterpolableexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/imported/blink/transitions/transition-not-interpolable-expected.txt (200621 => 200622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/imported/blink/transitions/transition-not-interpolable-expected.txt 2016-05-10 14:56:00 UTC (rev 200621)
+++ trunk/LayoutTests/imported/blink/transitions/transition-not-interpolable-expected.txt 2016-05-10 15:27:02 UTC (rev 200622)
</span><span class="lines">@@ -1 +1 @@
</span><del>-FAIL -- transtion should not apply from 0px to auto
</del><ins>+PASS
</ins></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (200621 => 200622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-05-10 14:56:00 UTC (rev 200621)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-05-10 15:27:02 UTC (rev 200622)
</span><span class="lines">@@ -2949,6 +2949,7 @@
</span><span class="cx"> fast/regions/layers/region-removed-during-animation.html [ ImageOnlyFailure ]
</span><span class="cx"> fast/sub-pixel/table-with-subpixel-cell-size.html [ ImageOnlyFailure ]
</span><span class="cx"> svg/text/tspan-multiple-outline.svg [ ImageOnlyFailure ]
</span><ins>+fast/animation/height-auto-transition-computed-value.html [ ImageOnlyFailure ]
</ins><span class="cx">
</span><span class="cx"> webkit.org/b/155174 svg/animations/animate-marker-orient-from-angle-to-autostartreverse.html [ Skip ]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (200621 => 200622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-10 14:56:00 UTC (rev 200621)
+++ trunk/Source/WebCore/ChangeLog 2016-05-10 15:27:02 UTC (rev 200622)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-05-10 Zalan Bujtas <zalan@apple.com>
+
+ REGRESSION (r193610): Drop down menu doesn’t expand at allofbach.com
+ https://bugs.webkit.org/show_bug.cgi?id=157445
+
+ Reviewed by Simon Fraser.
+
+ When we don't run transitions (becasuse of to/from 'auto' values) we should also not
+ report the 'from' value and behave as if we finished the transition already.
+
+ Test: fast/animation/height-auto-transition-computed-value.html
+
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): This is a revert of
+ looping the 'to' value back to the first keyframe when reverse animation is at the start value (last keyframe).
+
+ * platform/Length.cpp:
+ (WebCore::blend):
+
</ins><span class="cx"> 2016-05-09 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] <select> elements should render right-aligned when in RTL mode
</span></span></pre></div>
<a id="trunkSourceWebCorepageanimationKeyframeAnimationcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp (200621 => 200622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp 2016-05-10 14:56:00 UTC (rev 200621)
+++ trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp 2016-05-10 15:27:02 UTC (rev 200622)
</span><span class="lines">@@ -67,23 +67,21 @@
</span><span class="cx">
</span><span class="cx"> void KeyframeAnimation::fetchIntervalEndpointsForProperty(CSSPropertyID property, const RenderStyle*& fromStyle, const RenderStyle*& toStyle, double& prog) const
</span><span class="cx"> {
</span><ins>+ size_t numKeyframes = m_keyframes.size();
+ if (!numKeyframes)
+ return;
+
</ins><span class="cx"> // Find the first key
</span><span class="cx"> double elapsedTime = getElapsedTime();
</span><span class="cx"> if (m_animation->duration() && m_animation->iterationCount() != Animation::IterationCountInfinite)
</span><span class="cx"> elapsedTime = std::min(elapsedTime, m_animation->duration() * m_animation->iterationCount());
</span><span class="cx">
</span><span class="cx"> const double fractionalTime = this->fractionalTime(1, elapsedTime, 0);
</span><del>-
- size_t numKeyframes = m_keyframes.size();
- if (!numKeyframes)
- return;
-
</del><span class="cx"> ASSERT(!m_keyframes[0].key());
</span><span class="cx"> ASSERT(m_keyframes[m_keyframes.size() - 1].key() == 1);
</span><del>-
</del><ins>+
</ins><span class="cx"> int prevIndex = -1;
</span><span class="cx"> int nextIndex = -1;
</span><del>-
</del><span class="cx"> // FIXME: with a lot of keys, this linear search will be slow. We could binary search.
</span><span class="cx"> for (size_t i = 0; i < numKeyframes; ++i) {
</span><span class="cx"> const KeyframeValue& currKeyFrame = m_keyframes[i];
</span><span class="lines">@@ -95,31 +93,22 @@
</span><span class="cx"> nextIndex = i;
</span><span class="cx"> break;
</span><span class="cx"> }
</span><del>-
</del><span class="cx"> prevIndex = i;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (prevIndex == -1)
</span><span class="cx"> prevIndex = 0;
</span><ins>+ if (nextIndex == -1)
+ nextIndex = m_keyframes.size() - 1;
</ins><span class="cx">
</span><del>- if (nextIndex == -1) {
- int lastIndex = m_keyframes.size() - 1;
- if (prevIndex == lastIndex)
- nextIndex = 0;
- else
- nextIndex = lastIndex;
- }
-
- ASSERT(prevIndex != nextIndex);
-
</del><span class="cx"> const KeyframeValue& prevKeyframe = m_keyframes[prevIndex];
</span><span class="cx"> const KeyframeValue& nextKeyframe = m_keyframes[nextIndex];
</span><span class="cx">
</span><span class="cx"> fromStyle = prevKeyframe.style();
</span><span class="cx"> toStyle = nextKeyframe.style();
</span><del>-
</del><ins>+
</ins><span class="cx"> double offset = prevKeyframe.key();
</span><del>- double scale = 1.0 / (nextKeyframe.key() - prevKeyframe.key());
</del><ins>+ double scale = 1.0 / (nextIndex == prevIndex ? 1 : (nextKeyframe.key() - prevKeyframe.key()));
</ins><span class="cx">
</span><span class="cx"> prog = progress(scale, offset, prevKeyframe.timingFunction(name()));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformLengthcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/Length.cpp (200621 => 200622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/Length.cpp 2016-05-10 14:56:00 UTC (rev 200621)
+++ trunk/Source/WebCore/platform/Length.cpp 2016-05-10 15:27:02 UTC (rev 200622)
</span><span class="lines">@@ -299,7 +299,7 @@
</span><span class="cx"> Length blend(const Length& from, const Length& to, double progress)
</span><span class="cx"> {
</span><span class="cx"> if (from.isAuto() || to.isAuto())
</span><del>- return progress ? to : from;
</del><ins>+ return to;
</ins><span class="cx">
</span><span class="cx"> if (from.type() == Calculated || to.type() == Calculated)
</span><span class="cx"> return blendMixedTypes(from, to, progress);
</span></span></pre>
</div>
</div>
</body>
</html>