<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200524] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200524">200524</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2016-05-06 14:21:20 -0700 (Fri, 06 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Regions, Shapes and Tracks don't need runtime features
https://bugs.webkit.org/show_bug.cgi?id=157426
<rdar://problem/26146262>
Reviewed by Simon Fraser.
Source/WebCore:
The following RuntimeEnabledFeatures can be removed since
we have no need to disable them (they are stable and have
shipped for a while):
- CSS Regions
- CSS Shapes
- Media tracks
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures): Deleted.
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setCSSShapesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssShapesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssRegionsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setCSSCompositingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssCompositingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled): Deleted.
* css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::createRegionRule):
(WebCore::CSSParserContext::CSSParserContext): Deleted.
(WebCore::operator==): Deleted.
(WebCore::CSSParser::parseShapeProperty): Deleted.
(WebCore::CSSParser::cssRegionsEnabled): Deleted.
(WebCore::CSSParser::cssCompositingEnabled): Deleted.
(WebCore::CSSParser::parseFlowThread): Deleted.
(WebCore::CSSParser::parseRegionThread): Deleted.
* css/CSSParser.h:
* css/CSSParserMode.h:
* dom/Document.cpp:
(WebCore::Document::webkitGetNamedFlows):
(WebCore::Document::cssRegionsEnabled): Deleted.
(WebCore::Document::cssCompositingEnabled): Deleted.
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::unregisterNamedFlowContentElement):
(WebCore::Element::webkitRegionOverset):
(WebCore::Element::webkitGetRegionFlowRanges): Deleted.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::scheduleDelayedAction):
(WebCore::HTMLMediaElement::pendingActionTimerFired):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::setVideoFullscreenLayer):
(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
(WebCore::HTMLMediaElement::finishParsingChildren): Deleted.
(WebCore::HTMLMediaElement::audioTrackEnabledChanged): Deleted.
(WebCore::HTMLMediaElement::videoTrackSelectedChanged): Deleted.
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack): Deleted.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Deleted.
(WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack): Deleted.
(WebCore::HTMLMediaElement::addAudioTrack): Deleted.
(WebCore::HTMLMediaElement::addTextTrack): Deleted.
(WebCore::HTMLMediaElement::addVideoTrack): Deleted.
(WebCore::HTMLMediaElement::removeAudioTrack): Deleted.
(WebCore::HTMLMediaElement::removeTextTrack): Deleted.
(WebCore::HTMLMediaElement::removeVideoTrack): Deleted.
(WebCore::HTMLMediaElement::audioTracks): Deleted.
(WebCore::HTMLMediaElement::textTracks): Deleted.
(WebCore::HTMLMediaElement::videoTracks): Deleted.
(WebCore::HTMLMediaElement::didAddTextTrack): Deleted.
(WebCore::HTMLMediaElement::didRemoveTextTrack): Deleted.
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute):
(WebCore::HTMLTrackElement::scheduleLoad): Deleted.
(WebCore::HTMLTrackElement::canLoadURL): Deleted.
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo): Deleted.
(WebCore::InternalSettings::setCSSShapesEnabled): Deleted.
* testing/InternalSettings.h:
* testing/InternalSettings.idl:
Source/WebKit/mac:
The following RuntimeEnabledFeatures can be removed since
we have no need to disable them (they are stable and have
shipped for a while):
- CSS Regions
- CSS Shapes
- Media tracks
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Deleted.
(-[WebPreferences cssRegionsEnabled]): Deleted.
(-[WebPreferences setCSSRegionsEnabled:]): Deleted.
(-[WebPreferences cssCompositingEnabled]): Deleted.
(-[WebPreferences setCSSCompositingEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Deleted.
Source/WebKit2:
The following RuntimeEnabledFeatures can be removed since
we have no need to disable them (they are stable and have
shipped for a while):
- CSS Regions
- CSS Shapes
- Media tracks
* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCSSRegionsEnabled): Deleted.
(WKPreferencesGetCSSRegionsEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Deleted.
(WebKit::InjectedBundle::setCSSRegionsEnabled): Deleted.
(WebKit::InjectedBundle::setCSSCompositingEnabled): Deleted.
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Deleted.
Tools:
The following RuntimeEnabledFeatures can be removed since
we have no need to disable them (they are stable and have
shipped for a while):
- CSS Regions
- CSS Shapes
- Media tracks
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues): Deleted.
LayoutTests:
Remove these tests since their runtime flags no longer exist.
* fast/regions/css-regions-disabled-expected.txt: Removed.
* fast/regions/css-regions-disabled.html: Removed.
* fast/shapes/css-shapes-disabled-expected.txt: Removed.
* fast/shapes/css-shapes-disabled.html: Removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturescpp">trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh">trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSParsercpp">trunk/Source/WebCore/css/CSSParser.cpp</a></li>
<li><a href="#trunkSourceWebCorecssCSSParserh">trunk/Source/WebCore/css/CSSParser.h</a></li>
<li><a href="#trunkSourceWebCorecssCSSParserModeh">trunk/Source/WebCore/css/CSSParserMode.h</a></li>
<li><a href="#trunkSourceWebCoredomDocumentcpp">trunk/Source/WebCore/dom/Document.cpp</a></li>
<li><a href="#trunkSourceWebCoredomDocumenth">trunk/Source/WebCore/dom/Document.h</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLMediaElementcpp">trunk/Source/WebCore/html/HTMLMediaElement.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLTrackElementcpp">trunk/Source/WebCore/html/HTMLTrackElement.cpp</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBlockFlowcpp">trunk/Source/WebCore/rendering/RenderBlockFlow.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalSettingscpp">trunk/Source/WebCore/testing/InternalSettings.cpp</a></li>
<li><a href="#trunkSourceWebCoretestingInternalSettingsh">trunk/Source/WebCore/testing/InternalSettings.h</a></li>
<li><a href="#trunkSourceWebCoretestingInternalSettingsidl">trunk/Source/WebCore/testing/InternalSettings.idl</a></li>
<li><a href="#trunkSourceWebKitmacChangeLog">trunk/Source/WebKit/mac/ChangeLog</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesmm">trunk/Source/WebKit/mac/WebView/WebPreferences.mm</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebPreferencesPrivateh">trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h</a></li>
<li><a href="#trunkSourceWebKitmacWebViewWebViewmm">trunk/Source/WebKit/mac/WebView/WebView.mm</a></li>
<li><a href="#trunkSourceWebKitwinWebViewcpp">trunk/Source/WebKit/win/WebView.cpp</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2SharedWebPreferencesDefinitionsh">trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencescpp">trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp">trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessInjectedBundleInjectedBundleh">trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h</a></li>
<li><a href="#trunkSourceWebKit2WebProcessWebPageWebPagecpp">trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsDumpRenderTreemacDumpRenderTreemm">trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastregionscssregionsdisabledexpectedtxt">trunk/LayoutTests/fast/regions/css-regions-disabled-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastregionscssregionsdisabledhtml">trunk/LayoutTests/fast/regions/css-regions-disabled.html</a></li>
<li><a href="#trunkLayoutTestsfastshapescssshapesdisabledexpectedtxt">trunk/LayoutTests/fast/shapes/css-shapes-disabled-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastshapescssshapesdisabledhtml">trunk/LayoutTests/fast/shapes/css-shapes-disabled.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/LayoutTests/ChangeLog 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-05-06 Dean Jackson <dino@apple.com>
+
+ Regions, Shapes and Tracks don't need runtime features
+ https://bugs.webkit.org/show_bug.cgi?id=157426
+ <rdar://problem/26146262>
+
+ Reviewed by Simon Fraser.
+
+ Remove these tests since their runtime flags no longer exist.
+
+ * fast/regions/css-regions-disabled-expected.txt: Removed.
+ * fast/regions/css-regions-disabled.html: Removed.
+ * fast/shapes/css-shapes-disabled-expected.txt: Removed.
+ * fast/shapes/css-shapes-disabled.html: Removed.
+
</ins><span class="cx"> 2016-05-06 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Unreviewed IDB test gardening.
</span></span></pre></div>
<a id="trunkLayoutTestsfastregionscssregionsdisabledexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/regions/css-regions-disabled-expected.txt (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/css-regions-disabled-expected.txt 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/LayoutTests/fast/regions/css-regions-disabled-expected.txt 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1,22 +0,0 @@
</span><del>-Test that parsing of css regions related properties is disabled by default.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS testWebKitFlowInto("-webkit-flow-into: none") is ""
-PASS testWebKitFlowInto("-webkit-flow-into: first-flow") is ""
-PASS testComputedStyleWebKitFlowInto("none") is "none"
-PASS testComputedStyleWebKitFlowInto("first-flow") is "none"
-PASS testWebKitFlowFrom("-webkit-flow-from: first-flow") is ""
-PASS testWebKitFlowFrom("-webkit-flow-from: none") is ""
-PASS testComputedStyleWebKitFlowFrom("first-flow") is "none"
-PASS testComputedStyleWebKitFlowFrom("none") is "none"
-PASS testWebKitRegionFragment("-webkit-region-fragment: auto") is ""
-PASS testWebKitRegionFragment("-webkit-region-fragment: break") is ""
-PASS testComputedStyleWebKitRegionFragment("auto") is "auto"
-PASS testComputedStyleWebKitRegionFragment("break") is "auto"
-PASS webkitRegionRuleIndex is -1
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastregionscssregionsdisabledhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/regions/css-regions-disabled.html (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/regions/css-regions-disabled.html 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/LayoutTests/fast/regions/css-regions-disabled.html 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1,10 +0,0 @@
</span><del>-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="../../resources/js-test-pre.js"></script>
-</head>
-<body>
-<script src="script-tests/css-regions-disabled.js"></script>
-<script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsfastshapescssshapesdisabledexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/shapes/css-shapes-disabled-expected.txt (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/shapes/css-shapes-disabled-expected.txt 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/LayoutTests/fast/shapes/css-shapes-disabled-expected.txt 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1,13 +0,0 @@
</span><del>-Test that parsing of css shapes related properties can be disabled.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS testInlineStyle("-webkit-shape-margin", "10px") is ""
-PASS testComputedStyle("-webkit-shape-margin", "10px") is "0px"
-PASS testInlineStyle("-webkit-shape-outside", "circle(10px at 10px 10px)") is ""
-PASS testComputedStyle("-webkit-shape-outside", "circle(10px at 10px 10px)") is "none"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
</del></span></pre></div>
<a id="trunkLayoutTestsfastshapescssshapesdisabledhtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/fast/shapes/css-shapes-disabled.html (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/shapes/css-shapes-disabled.html 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/LayoutTests/fast/shapes/css-shapes-disabled.html 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1,38 +0,0 @@
</span><del>-<!DOCTYPE html>
-<html>
-<body>
-<script src="../../resources/js-test-pre.js"></script>
-<script>
-
-description('Test that parsing of css shapes related properties can be disabled.');
-
-if (window.internals)
- window.internals.settings.setCSSShapesEnabled(false);
-
-function testInlineStyle(property, value) {
- var div = document.createElement("div");
- div.setAttribute("style", property + ": " + value);
- return div.style.getPropertyValue(property);
-}
-
-function testComputedStyle(property, value) {
- var div = document.createElement("div");
- document.body.appendChild(div);
- div.style.setProperty(property, value);
- var computedValue = getComputedStyle(div).getPropertyValue(property);
- document.body.removeChild(div);
- return computedValue;
-}
-
-function testStyle(property, value, computedExpected) {
- shouldBeEqualToString('testInlineStyle("' + property + '", "' + value + '")', '');
- shouldBeEqualToString('testComputedStyle("' + property + '", "' + value + '")', computedExpected);
-}
-
-testStyle("-webkit-shape-margin", "10px", "0px");
-testStyle("-webkit-shape-outside", "circle(10px at 10px 10px)", "none");
-
-</script>
-<script src="../../resources/js-test-post.js"></script>
-</body>
-</html>
</del></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/ChangeLog 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1,3 +1,96 @@
</span><ins>+2016-05-06 Dean Jackson <dino@apple.com>
+
+ Regions, Shapes and Tracks don't need runtime features
+ https://bugs.webkit.org/show_bug.cgi?id=157426
+ <rdar://problem/26146262>
+
+ Reviewed by Simon Fraser.
+
+ The following RuntimeEnabledFeatures can be removed since
+ we have no need to disable them (they are stable and have
+ shipped for a while):
+ - CSS Regions
+ - CSS Shapes
+ - Media tracks
+
+ * bindings/generic/RuntimeEnabledFeatures.cpp:
+ (WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures): Deleted.
+ * bindings/generic/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setCSSShapesEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::cssShapesEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::cssRegionsEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::setCSSCompositingEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::cssCompositingEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled): Deleted.
+ * css/CSSParser.cpp:
+ (WebCore::isSimpleLengthPropertyID):
+ (WebCore::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParser::parseValue):
+ (WebCore::CSSParser::parseFillProperty):
+ (WebCore::CSSParser::createRegionRule):
+ (WebCore::CSSParserContext::CSSParserContext): Deleted.
+ (WebCore::operator==): Deleted.
+ (WebCore::CSSParser::parseShapeProperty): Deleted.
+ (WebCore::CSSParser::cssRegionsEnabled): Deleted.
+ (WebCore::CSSParser::cssCompositingEnabled): Deleted.
+ (WebCore::CSSParser::parseFlowThread): Deleted.
+ (WebCore::CSSParser::parseRegionThread): Deleted.
+ * css/CSSParser.h:
+ * css/CSSParserMode.h:
+ * dom/Document.cpp:
+ (WebCore::Document::webkitGetNamedFlows):
+ (WebCore::Document::cssRegionsEnabled): Deleted.
+ (WebCore::Document::cssCompositingEnabled): Deleted.
+ * dom/Document.h:
+ * dom/Element.cpp:
+ (WebCore::Element::unregisterNamedFlowContentElement):
+ (WebCore::Element::webkitRegionOverset):
+ (WebCore::Element::webkitGetRegionFlowRanges): Deleted.
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::scheduleDelayedAction):
+ (WebCore::HTMLMediaElement::pendingActionTimerFired):
+ (WebCore::HTMLMediaElement::prepareForLoad):
+ (WebCore::HTMLMediaElement::loadInternal):
+ (WebCore::HTMLMediaElement::setReadyState):
+ (WebCore::HTMLMediaElement::playbackProgressTimerFired):
+ (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
+ (WebCore::HTMLMediaElement::userCancelledLoad):
+ (WebCore::HTMLMediaElement::setVideoFullscreenLayer):
+ (WebCore::HTMLMediaElement::hasClosedCaptions):
+ (WebCore::HTMLMediaElement::setClosedCaptionsVisible):
+ (WebCore::HTMLMediaElement::configureTextTrackDisplay):
+ (WebCore::HTMLMediaElement::finishParsingChildren): Deleted.
+ (WebCore::HTMLMediaElement::audioTrackEnabledChanged): Deleted.
+ (WebCore::HTMLMediaElement::videoTrackSelectedChanged): Deleted.
+ (WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack): Deleted.
+ (WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Deleted.
+ (WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack): Deleted.
+ (WebCore::HTMLMediaElement::addAudioTrack): Deleted.
+ (WebCore::HTMLMediaElement::addTextTrack): Deleted.
+ (WebCore::HTMLMediaElement::addVideoTrack): Deleted.
+ (WebCore::HTMLMediaElement::removeAudioTrack): Deleted.
+ (WebCore::HTMLMediaElement::removeTextTrack): Deleted.
+ (WebCore::HTMLMediaElement::removeVideoTrack): Deleted.
+ (WebCore::HTMLMediaElement::audioTracks): Deleted.
+ (WebCore::HTMLMediaElement::textTracks): Deleted.
+ (WebCore::HTMLMediaElement::videoTracks): Deleted.
+ (WebCore::HTMLMediaElement::didAddTextTrack): Deleted.
+ (WebCore::HTMLMediaElement::didRemoveTextTrack): Deleted.
+ * html/HTMLTrackElement.cpp:
+ (WebCore::HTMLTrackElement::parseAttribute):
+ (WebCore::HTMLTrackElement::scheduleLoad): Deleted.
+ (WebCore::HTMLTrackElement::canLoadURL): Deleted.
+ * rendering/RenderBlockFlow.cpp:
+ (WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::Backup::Backup):
+ (WebCore::InternalSettings::Backup::restoreTo): Deleted.
+ (WebCore::InternalSettings::setCSSShapesEnabled): Deleted.
+ * testing/InternalSettings.h:
+ * testing/InternalSettings.idl:
+
</ins><span class="cx"> 2016-05-06 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> Modern IDB (Workers): Start running a lot of the workers tests.
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -50,9 +50,6 @@
</span><span class="cx"> , m_isDeviceMotionEnabled(true)
</span><span class="cx"> , m_isDeviceOrientationEnabled(true)
</span><span class="cx"> , m_isLinkPreloadEnabled(false)
</span><del>- , m_isCSSShapesEnabled(true)
- , m_isCSSRegionsEnabled(false)
- , m_isCSSCompositingEnabled(false)
</del><span class="cx"> , m_isLangAttributeAwareFormControlUIEnabled(false)
</span><span class="cx"> #if PLATFORM(IOS)
</span><span class="cx"> , m_isPluginReplacementEnabled(true)
</span><span class="lines">@@ -78,9 +75,6 @@
</span><span class="cx"> #if ENABLE(JAVASCRIPT_I18N_API)
</span><span class="cx"> , m_isJavaScriptI18NAPIEnabled(false)
</span><span class="cx"> #endif
</span><del>-#if ENABLE(VIDEO_TRACK)
- , m_isVideoTrackEnabled(true)
-#endif
</del><span class="cx"> #if ENABLE(INPUT_TYPE_DATE)
</span><span class="cx"> , m_isInputTypeDateEnabled(true)
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsgenericRuntimeEnabledFeaturesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -72,25 +72,6 @@
</span><span class="cx"> bool indexedDBWorkersEnabled() const { return m_isIndexedDBWorkersEnabled; }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if ENABLE(CSS_SHAPES)
- void setCSSShapesEnabled(bool isEnabled) { m_isCSSShapesEnabled = isEnabled; }
- bool cssShapesEnabled() const { return m_isCSSShapesEnabled; }
-#else
- void setCSSShapesEnabled(bool) { }
- bool cssShapesEnabled() const { return false; }
-#endif
-
-#if ENABLE(CSS_REGIONS)
- void setCSSRegionsEnabled(bool isEnabled) { m_isCSSRegionsEnabled = isEnabled; }
- bool cssRegionsEnabled() const { return m_isCSSRegionsEnabled; }
-#else
- void setCSSRegionsEnabled(bool) { }
- bool cssRegionsEnabled() const { return false; }
-#endif
-
- void setCSSCompositingEnabled(bool isEnabled) { m_isCSSCompositingEnabled = isEnabled; }
- bool cssCompositingEnabled() const { return m_isCSSCompositingEnabled; }
-
</del><span class="cx"> #if ENABLE(FONT_LOAD_EVENTS)
</span><span class="cx"> void setFontLoadEventsEnabled(bool isEnabled) { m_isFontLoadEventsEnabled = isEnabled; }
</span><span class="cx"> bool fontLoadEventsEnabled() const { return m_isFontLoadEventsEnabled; }
</span><span class="lines">@@ -154,11 +135,6 @@
</span><span class="cx"> bool legacyCSSVendorPrefixesEnabled() const { return m_isLegacyCSSVendorPrefixesEnabled; }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if ENABLE(VIDEO_TRACK)
- bool webkitVideoTrackEnabled() const { return m_isVideoTrackEnabled; }
- void setWebkitVideoTrackEnabled(bool isEnabled) { m_isVideoTrackEnabled = isEnabled; }
-#endif
-
</del><span class="cx"> #if ENABLE(INPUT_TYPE_DATE)
</span><span class="cx"> bool inputTypeDateEnabled() const { return m_isInputTypeDateEnabled; }
</span><span class="cx"> void setInputTypeDateEnabled(bool isEnabled) { m_isInputTypeDateEnabled = isEnabled; }
</span><span class="lines">@@ -265,9 +241,6 @@
</span><span class="cx"> bool m_isDeviceMotionEnabled;
</span><span class="cx"> bool m_isDeviceOrientationEnabled;
</span><span class="cx"> bool m_isLinkPreloadEnabled;
</span><del>- bool m_isCSSShapesEnabled;
- bool m_isCSSRegionsEnabled;
- bool m_isCSSCompositingEnabled;
</del><span class="cx"> bool m_isLangAttributeAwareFormControlUIEnabled;
</span><span class="cx"> bool m_isPluginReplacementEnabled;
</span><span class="cx"> bool m_isResourceTimingEnabled;
</span><span class="lines">@@ -295,10 +268,6 @@
</span><span class="cx"> bool m_isLegacyCSSVendorPrefixesEnabled;
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if ENABLE(VIDEO_TRACK)
- bool m_isVideoTrackEnabled;
-#endif
-
</del><span class="cx"> #if ENABLE(INPUT_TYPE_DATE)
</span><span class="cx"> bool m_isInputTypeDateEnabled;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParsercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -246,8 +246,6 @@
</span><span class="cx"> : baseURL(baseURL)
</span><span class="cx"> , mode(mode)
</span><span class="cx"> , isHTMLDocument(false)
</span><del>- , isCSSRegionsEnabled(RuntimeEnabledFeatures::sharedFeatures().cssRegionsEnabled())
- , isCSSCompositingEnabled(RuntimeEnabledFeatures::sharedFeatures().cssCompositingEnabled())
</del><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx"> , cssGridLayoutEnabled(RuntimeEnabledFeatures::sharedFeatures().isCSSGridLayoutEnabled())
</span><span class="cx"> #endif
</span><span class="lines">@@ -268,8 +266,6 @@
</span><span class="cx"> , charset(charset)
</span><span class="cx"> , mode(document.inQuirksMode() ? CSSQuirksMode : CSSStrictMode)
</span><span class="cx"> , isHTMLDocument(document.isHTMLDocument())
</span><del>- , isCSSRegionsEnabled(document.cssRegionsEnabled())
- , isCSSCompositingEnabled(document.cssCompositingEnabled())
</del><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx"> , cssGridLayoutEnabled(document.isCSSGridLayoutEnabled())
</span><span class="cx"> #endif
</span><span class="lines">@@ -291,8 +287,6 @@
</span><span class="cx"> && a.charset == b.charset
</span><span class="cx"> && a.mode == b.mode
</span><span class="cx"> && a.isHTMLDocument == b.isHTMLDocument
</span><del>- && a.isCSSRegionsEnabled == b.isCSSRegionsEnabled
- && a.isCSSCompositingEnabled == b.isCSSCompositingEnabled
</del><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx"> && a.cssGridLayoutEnabled == b.cssGridLayoutEnabled
</span><span class="cx"> #endif
</span><span class="lines">@@ -552,13 +546,11 @@
</span><span class="cx"> case CSSPropertyGridColumnGap:
</span><span class="cx"> case CSSPropertyGridRowGap:
</span><span class="cx"> #endif
</span><del>- acceptsNegativeNumbers = false;
- return true;
</del><span class="cx"> #if ENABLE(CSS_SHAPES)
</span><span class="cx"> case CSSPropertyWebkitShapeMargin:
</span><del>- acceptsNegativeNumbers = false;
- return RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled();
</del><span class="cx"> #endif
</span><ins>+ acceptsNegativeNumbers = false;
+ return true;
</ins><span class="cx"> case CSSPropertyBottom:
</span><span class="cx"> case CSSPropertyCx:
</span><span class="cx"> case CSSPropertyCy:
</span><span class="lines">@@ -821,14 +813,14 @@
</span><span class="cx"> break;
</span><span class="cx"> #if ENABLE(CSS_COMPOSITING)
</span><span class="cx"> case CSSPropertyMixBlendMode:
</span><del>- if (parserContext.isCSSCompositingEnabled && (valueID == CSSValueNormal || valueID == CSSValueMultiply || valueID == CSSValueScreen
</del><ins>+ if (valueID == CSSValueNormal || valueID == CSSValueMultiply || valueID == CSSValueScreen
</ins><span class="cx"> || valueID == CSSValueOverlay || valueID == CSSValueDarken || valueID == CSSValueLighten || valueID == CSSValueColorDodge
</span><span class="cx"> || valueID == CSSValueColorBurn || valueID == CSSValueHardLight || valueID == CSSValueSoftLight || valueID == CSSValueDifference
</span><del>- || valueID == CSSValueExclusion || valueID == CSSValuePlusDarker || valueID == CSSValuePlusLighter))
</del><ins>+ || valueID == CSSValueExclusion || valueID == CSSValuePlusDarker || valueID == CSSValuePlusLighter)
</ins><span class="cx"> return true;
</span><span class="cx"> break;
</span><span class="cx"> case CSSPropertyIsolation:
</span><del>- if (parserContext.isCSSCompositingEnabled && (valueID == CSSValueAuto || valueID == CSSValueIsolate))
</del><ins>+ if (valueID == CSSValueAuto || valueID == CSSValueIsolate)
</ins><span class="cx"> return true;
</span><span class="cx"> break;
</span><span class="cx"> #endif
</span><span class="lines">@@ -931,15 +923,15 @@
</span><span class="cx"> #if ENABLE(CSS_REGIONS)
</span><span class="cx"> case CSSPropertyWebkitRegionBreakAfter:
</span><span class="cx"> case CSSPropertyWebkitRegionBreakBefore:
</span><del>- if (parserContext.isCSSRegionsEnabled && (valueID == CSSValueAuto || valueID == CSSValueAlways || valueID == CSSValueAvoid || valueID == CSSValueLeft || valueID == CSSValueRight))
</del><ins>+ if (valueID == CSSValueAuto || valueID == CSSValueAlways || valueID == CSSValueAvoid || valueID == CSSValueLeft || valueID == CSSValueRight)
</ins><span class="cx"> return true;
</span><span class="cx"> break;
</span><span class="cx"> case CSSPropertyWebkitRegionBreakInside:
</span><del>- if (parserContext.isCSSRegionsEnabled && (valueID == CSSValueAuto || valueID == CSSValueAvoid))
</del><ins>+ if (valueID == CSSValueAuto || valueID == CSSValueAvoid)
</ins><span class="cx"> return true;
</span><span class="cx"> break;
</span><span class="cx"> case CSSPropertyWebkitRegionFragment:
</span><del>- if (parserContext.isCSSRegionsEnabled && (valueID == CSSValueAuto || valueID == CSSValueBreak))
</del><ins>+ if (valueID == CSSValueAuto || valueID == CSSValueBreak)
</ins><span class="cx"> return true;
</span><span class="cx"> break;
</span><span class="cx"> #endif
</span><span class="lines">@@ -2624,12 +2616,10 @@
</span><span class="cx"> break;
</span><span class="cx"> #if ENABLE(CSS_COMPOSITING)
</span><span class="cx"> case CSSPropertyMixBlendMode:
</span><del>- if (cssCompositingEnabled())
- validPrimitive = true;
</del><ins>+ validPrimitive = true;
</ins><span class="cx"> break;
</span><span class="cx"> case CSSPropertyIsolation:
</span><del>- if (cssCompositingEnabled())
- validPrimitive = true;
</del><ins>+ validPrimitive = true;
</ins><span class="cx"> break;
</span><span class="cx"> #endif
</span><span class="cx"> case CSSPropertyFlex: {
</span><span class="lines">@@ -2683,12 +2673,8 @@
</span><span class="cx"> break;
</span><span class="cx"> #if ENABLE(CSS_REGIONS)
</span><span class="cx"> case CSSPropertyWebkitFlowInto:
</span><del>- if (!cssRegionsEnabled())
- return false;
</del><span class="cx"> return parseFlowThread(propId, important);
</span><span class="cx"> case CSSPropertyWebkitFlowFrom:
</span><del>- if (!cssRegionsEnabled())
- return false;
</del><span class="cx"> return parseRegionThread(propId, important);
</span><span class="cx"> #endif
</span><span class="cx"> case CSSPropertyTransform:
</span><span class="lines">@@ -3186,10 +3172,10 @@
</span><span class="cx"> parsedValue = parseShapeProperty(propId);
</span><span class="cx"> break;
</span><span class="cx"> case CSSPropertyWebkitShapeMargin:
</span><del>- validPrimitive = (RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled() && !id && validateUnit(valueWithCalculation, FLength | FPercent | FNonNeg));
</del><ins>+ validPrimitive = !id && validateUnit(valueWithCalculation, FLength | FPercent | FNonNeg);
</ins><span class="cx"> break;
</span><span class="cx"> case CSSPropertyWebkitShapeImageThreshold:
</span><del>- validPrimitive = (RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled() && !id && validateUnit(valueWithCalculation, FNumber));
</del><ins>+ validPrimitive = !id && validateUnit(valueWithCalculation, FNumber);
</ins><span class="cx"> break;
</span><span class="cx"> #endif
</span><span class="cx"> #if ENABLE(CSS_IMAGE_ORIENTATION)
</span><span class="lines">@@ -4975,11 +4961,11 @@
</span><span class="cx"> }
</span><span class="cx"> break;
</span><span class="cx"> case CSSPropertyBackgroundBlendMode:
</span><del>- if (cssCompositingEnabled() && (currentValue->id == CSSValueNormal || currentValue->id == CSSValueMultiply
</del><ins>+ if (currentValue->id == CSSValueNormal || currentValue->id == CSSValueMultiply
</ins><span class="cx"> || currentValue->id == CSSValueScreen || currentValue->id == CSSValueOverlay || currentValue->id == CSSValueDarken
</span><span class="cx"> || currentValue->id == CSSValueLighten || currentValue->id == CSSValueColorDodge || currentValue->id == CSSValueColorBurn
</span><span class="cx"> || currentValue->id == CSSValueHardLight || currentValue->id == CSSValueSoftLight || currentValue->id == CSSValueDifference
</span><del>- || currentValue->id == CSSValueExclusion)) {
</del><ins>+ || currentValue->id == CSSValueExclusion) {
</ins><span class="cx"> currValue = CSSValuePool::singleton().createIdentifierValue(currentValue->id);
</span><span class="cx"> m_valueList->next();
</span><span class="cx"> }
</span><span class="lines">@@ -6874,9 +6860,6 @@
</span><span class="cx"> #if ENABLE(CSS_SHAPES)
</span><span class="cx"> RefPtr<CSSValue> CSSParser::parseShapeProperty(CSSPropertyID propId)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled())
- return nullptr;
-
</del><span class="cx"> CSSParserValue& value = *m_valueList->current();
</span><span class="cx"> CSSValueID valueId = value.id;
</span><span class="cx">
</span><span class="lines">@@ -10267,16 +10250,6 @@
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-bool CSSParser::cssRegionsEnabled() const
-{
- return m_context.isCSSRegionsEnabled;
-}
-
-bool CSSParser::cssCompositingEnabled() const
-{
- return m_context.isCSSCompositingEnabled;
-}
-
</del><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx"> bool CSSParser::isCSSGridLayoutEnabled() const
</span><span class="cx"> {
</span><span class="lines">@@ -10290,7 +10263,6 @@
</span><span class="cx"> bool CSSParser::parseFlowThread(CSSPropertyID propId, bool important)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(propId == CSSPropertyWebkitFlowInto);
</span><del>- ASSERT(cssRegionsEnabled());
</del><span class="cx">
</span><span class="cx"> if (m_valueList->size() != 1)
</span><span class="cx"> return false;
</span><span class="lines">@@ -10322,7 +10294,6 @@
</span><span class="cx"> bool CSSParser::parseRegionThread(CSSPropertyID propId, bool important)
</span><span class="cx"> {
</span><span class="cx"> ASSERT(propId == CSSPropertyWebkitFlowFrom);
</span><del>- ASSERT(cssRegionsEnabled());
</del><span class="cx">
</span><span class="cx"> if (m_valueList->size() != 1)
</span><span class="cx"> return false;
</span><span class="lines">@@ -13197,7 +13168,7 @@
</span><span class="cx">
</span><span class="cx"> RefPtr<StyleRuleBase> CSSParser::createRegionRule(Vector<std::unique_ptr<CSSParserSelector>>* regionSelector, RuleList* rules)
</span><span class="cx"> {
</span><del>- if (!cssRegionsEnabled() || !regionSelector || !rules) {
</del><ins>+ if (!regionSelector || !rules) {
</ins><span class="cx"> popRuleData();
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParserh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParser.h (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParser.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/css/CSSParser.h 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -348,8 +348,6 @@
</span><span class="cx"> bool parseFontFeatureTag(CSSValueList&);
</span><span class="cx"> bool parseFontFeatureSettings(bool important);
</span><span class="cx">
</span><del>- bool cssRegionsEnabled() const;
- bool cssCompositingEnabled() const;
</del><span class="cx"> bool parseFlowThread(CSSPropertyID, bool important);
</span><span class="cx"> bool parseRegionThread(CSSPropertyID, bool important);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorecssCSSParserModeh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/css/CSSParserMode.h (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/css/CSSParserMode.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/css/CSSParserMode.h 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -64,8 +64,6 @@
</span><span class="cx"> String charset;
</span><span class="cx"> CSSParserMode mode;
</span><span class="cx"> bool isHTMLDocument;
</span><del>- bool isCSSRegionsEnabled;
- bool isCSSCompositingEnabled;
</del><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx"> bool cssGridLayoutEnabled;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/dom/Document.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1128,16 +1128,6 @@
</span><span class="cx"> return element.releaseNonNull();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-bool Document::cssRegionsEnabled() const
-{
- return RuntimeEnabledFeatures::sharedFeatures().cssRegionsEnabled();
-}
-
-bool Document::cssCompositingEnabled() const
-{
- return RuntimeEnabledFeatures::sharedFeatures().cssCompositingEnabled();
-}
-
</del><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx"> bool Document::isCSSGridLayoutEnabled() const
</span><span class="cx"> {
</span><span class="lines">@@ -1146,17 +1136,15 @@
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if ENABLE(CSS_REGIONS)
</span><del>-
</del><span class="cx"> RefPtr<DOMNamedFlowCollection> Document::webkitGetNamedFlows()
</span><span class="cx"> {
</span><del>- if (!cssRegionsEnabled() || !renderView())
</del><ins>+ if (!renderView())
</ins><span class="cx"> return nullptr;
</span><span class="cx">
</span><span class="cx"> updateStyleIfNeeded();
</span><span class="cx">
</span><span class="cx"> return namedFlows().createCSSOMSnapshot();
</span><span class="cx"> }
</span><del>-
</del><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> NamedFlowCollection& Document::namedFlows()
</span></span></pre></div>
<a id="trunkSourceWebCoredomDocumenth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Document.h (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Document.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/dom/Document.h 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -392,8 +392,6 @@
</span><span class="cx"> WEBCORE_EXPORT RefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
</span><span class="cx"> WEBCORE_EXPORT Ref<Element> createElement(const QualifiedName&, bool createdByParser);
</span><span class="cx">
</span><del>- bool cssRegionsEnabled() const;
- bool cssCompositingEnabled() const;
</del><span class="cx"> #if ENABLE(CSS_GRID_LAYOUT)
</span><span class="cx"> bool isCSSGridLayoutEnabled() const;
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/dom/Element.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1614,7 +1614,7 @@
</span><span class="cx">
</span><span class="cx"> void Element::unregisterNamedFlowContentElement()
</span><span class="cx"> {
</span><del>- if (document().cssRegionsEnabled() && isNamedFlowContentNode() && document().renderView())
</del><ins>+ if (isNamedFlowContentNode() && document().renderView())
</ins><span class="cx"> document().renderView()->flowThreadController().unregisterNamedFlowContentElement(*this);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2930,7 +2930,7 @@
</span><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx">
</span><span class="cx"> static NeverDestroyed<AtomicString> undefinedState("undefined", AtomicString::ConstructFromLiteral);
</span><del>- if (!document().cssRegionsEnabled() || !renderNamedFlowFragment())
</del><ins>+ if (!renderNamedFlowFragment())
</ins><span class="cx"> return undefinedState;
</span><span class="cx">
</span><span class="cx"> switch (regionOversetState()) {
</span><span class="lines">@@ -2957,9 +2957,6 @@
</span><span class="cx"> Vector<RefPtr<Range>> Element::webkitGetRegionFlowRanges() const
</span><span class="cx"> {
</span><span class="cx"> Vector<RefPtr<Range>> rangeObjects;
</span><del>- if (!document().cssRegionsEnabled())
- return rangeObjects;
-
</del><span class="cx"> document().updateLayoutIgnorePendingStylesheets();
</span><span class="cx"> if (renderer() && renderer()->isRenderNamedFlowFragmentContainer()) {
</span><span class="cx"> RenderNamedFlowFragment& namedFlowFragment = *downcast<RenderBlockFlow>(*renderer()).renderNamedFlowFragment();
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLMediaElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -719,9 +719,6 @@
</span><span class="cx"> m_parsingInProgress = false;
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> if (descendantsOfType<HTMLTrackElement>(*this).first())
</span><span class="cx"> scheduleDelayedAction(ConfigureTextTracks);
</span><span class="cx"> #endif
</span><span class="lines">@@ -864,7 +861,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled() && (actionType & ConfigureTextTracks))
</del><ins>+ if (actionType & ConfigureTextTracks)
</ins><span class="cx"> setFlags(m_pendingActionFlags, ConfigureTextTracks);
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -910,7 +907,7 @@
</span><span class="cx"> m_pendingActionFlags = 0;
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled() && (pendingActions & ConfigureTextTracks))
</del><ins>+ if (pendingActions & ConfigureTextTracks)
</ins><span class="cx"> configureTextTracks();
</span><span class="cx"> #endif
</span><span class="cx">
</span><span class="lines">@@ -1099,8 +1096,7 @@
</span><span class="cx">
</span><span class="cx"> updateMediaController();
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateActiveTextTrackCues(MediaTime::zeroTime());
</del><ins>+ updateActiveTextTrackCues(MediaTime::zeroTime());
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -1176,14 +1172,12 @@
</span><span class="cx">
</span><span class="cx"> // HTMLMediaElement::textTracksAreReady will need "... the text tracks whose mode was not in the
</span><span class="cx"> // disabled state when the element's resource selection algorithm last started".
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled()) {
- m_textTracksWhenResourceSelectionBegan.clear();
- if (m_textTracks) {
- for (unsigned i = 0; i < m_textTracks->length(); ++i) {
- TextTrack* track = m_textTracks->item(i);
- if (track->mode() != TextTrack::Mode::Disabled)
- m_textTracksWhenResourceSelectionBegan.append(track);
- }
</del><ins>+ m_textTracksWhenResourceSelectionBegan.clear();
+ if (m_textTracks) {
+ for (unsigned i = 0; i < m_textTracks->length(); ++i) {
+ TextTrack* track = m_textTracks->item(i);
+ if (track->mode() != TextTrack::Mode::Disabled)
+ m_textTracksWhenResourceSelectionBegan.append(track);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> #endif
</span><span class="lines">@@ -1711,8 +1705,6 @@
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::audioTrackEnabledChanged(AudioTrack* track)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
</del><span class="cx"> if (m_audioTracks && m_audioTracks->contains(track))
</span><span class="cx"> m_audioTracks->scheduleChangeEvent();
</span><span class="cx"> }
</span><span class="lines">@@ -1754,8 +1746,6 @@
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::videoTrackSelectedChanged(VideoTrack* track)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
</del><span class="cx"> if (m_videoTracks && m_videoTracks->contains(track))
</span><span class="cx"> m_videoTracks->scheduleChangeEvent();
</span><span class="cx"> }
</span><span class="lines">@@ -2161,7 +2151,7 @@
</span><span class="cx"> ReadyState newState = static_cast<ReadyState>(state);
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- bool tracksAreReady = !RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled() || textTracksAreReady();
</del><ins>+ bool tracksAreReady = textTracksAreReady();
</ins><span class="cx">
</span><span class="cx"> if (newState == oldState && m_tracksAreReady == tracksAreReady)
</span><span class="cx"> return;
</span><span class="lines">@@ -2283,8 +2273,7 @@
</span><span class="cx"> updatePlayState();
</span><span class="cx"> updateMediaController();
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateActiveTextTrackCues(currentMediaTime());
</del><ins>+ updateActiveTextTrackCues(currentMediaTime());
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3425,8 +3414,7 @@
</span><span class="cx"> mediaControls()->playbackProgressed();
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateActiveTextTrackCues(currentMediaTime());
</del><ins>+ updateActiveTextTrackCues(currentMediaTime());
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if ENABLE(MEDIA_SOURCE)
</span><span class="lines">@@ -3486,17 +3474,11 @@
</span><span class="cx"> if (isPlaying() && !m_mediaSession->playbackPermitted(*this))
</span><span class="cx"> pauseInternal();
</span><span class="cx">
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> addAudioTrack(AudioTrack::create(this, prpTrack));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::mediaPlayerDidAddTextTrack(PassRefPtr<InbandTextTrackPrivate> prpTrack)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> // 4.8.10.12.2 Sourcing in-band text tracks
</span><span class="cx"> // 1. Associate the relevant data with a new text track and its corresponding new TextTrack object.
</span><span class="cx"> RefPtr<InbandTextTrack> textTrack = InbandTextTrack::create(ActiveDOMObject::scriptExecutionContext(), this, prpTrack);
</span><span class="lines">@@ -3530,9 +3512,6 @@
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::mediaPlayerDidAddVideoTrack(PassRefPtr<VideoTrackPrivate> prpTrack)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> addVideoTrack(VideoTrack::create(this, prpTrack));
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3559,17 +3538,11 @@
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::addAudioTrack(PassRefPtr<AudioTrack> track)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> audioTracks()->append(track);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::addTextTrack(PassRefPtr<TextTrack> track)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> if (!m_requireCaptionPreferencesChangedCallbacks) {
</span><span class="cx"> m_requireCaptionPreferencesChangedCallbacks = true;
</span><span class="cx"> Document& document = this->document();
</span><span class="lines">@@ -3585,25 +3558,16 @@
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::addVideoTrack(PassRefPtr<VideoTrack> track)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> videoTracks()->append(track);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::removeAudioTrack(AudioTrack* track)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> m_audioTracks->remove(track);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::removeTextTrack(TextTrack* track, bool scheduleEvent)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> TrackDisplayUpdateScope scope(this);
</span><span class="cx"> if (TextTrackCueList* cues = track->cues())
</span><span class="cx"> textTrackRemoveCues(track, cues);
</span><span class="lines">@@ -3616,9 +3580,6 @@
</span><span class="cx">
</span><span class="cx"> void HTMLMediaElement::removeVideoTrack(VideoTrack* track)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> m_videoTracks->remove(track);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3643,9 +3604,6 @@
</span><span class="cx">
</span><span class="cx"> PassRefPtr<TextTrack> HTMLMediaElement::addTextTrack(const String& kind, const String& label, const String& language, ExceptionCode& ec)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return 0;
-
</del><span class="cx"> // 4.8.10.12.4 Text track API
</span><span class="cx"> // The addTextTrack(kind, label, language) method of media elements, when invoked, must run the following steps:
</span><span class="cx">
</span><span class="lines">@@ -3680,9 +3638,6 @@
</span><span class="cx">
</span><span class="cx"> AudioTrackList* HTMLMediaElement::audioTracks()
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return 0;
-
</del><span class="cx"> if (!m_audioTracks)
</span><span class="cx"> m_audioTracks = AudioTrackList::create(this, ActiveDOMObject::scriptExecutionContext());
</span><span class="cx">
</span><span class="lines">@@ -3691,9 +3646,6 @@
</span><span class="cx">
</span><span class="cx"> TextTrackList* HTMLMediaElement::textTracks()
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return 0;
-
</del><span class="cx"> if (!m_textTracks)
</span><span class="cx"> m_textTracks = TextTrackList::create(this, ActiveDOMObject::scriptExecutionContext());
</span><span class="cx">
</span><span class="lines">@@ -3702,9 +3654,6 @@
</span><span class="cx">
</span><span class="cx"> VideoTrackList* HTMLMediaElement::videoTracks()
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return 0;
-
</del><span class="cx"> if (!m_videoTracks)
</span><span class="cx"> m_videoTracks = VideoTrackList::create(this, ActiveDOMObject::scriptExecutionContext());
</span><span class="cx">
</span><span class="lines">@@ -3715,9 +3664,6 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(trackElement->hasTagName(trackTag));
</span><span class="cx">
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> // 4.8.10.12.3 Sourcing out-of-band text tracks
</span><span class="cx"> // When a track element's parent element changes and the new parent is a media element,
</span><span class="cx"> // then the user agent must add the track element's corresponding text track to the
</span><span class="lines">@@ -3741,9 +3687,6 @@
</span><span class="cx"> {
</span><span class="cx"> ASSERT(trackElement->hasTagName(trackTag));
</span><span class="cx">
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> #if !LOG_DISABLED
</span><span class="cx"> if (trackElement->hasTagName(trackTag)) {
</span><span class="cx"> URL url = trackElement->getNonEmptyURLAttribute(srcAttr);
</span><span class="lines">@@ -4321,8 +4264,7 @@
</span><span class="cx"> LOG(Media, "HTMLMediaElement::mediaPlayerTimeChanged(%p)", this);
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateActiveTextTrackCues(currentMediaTime());
</del><ins>+ updateActiveTextTrackCues(currentMediaTime());
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> beginProcessingMediaPlayerCallback();
</span><span class="lines">@@ -4967,8 +4909,7 @@
</span><span class="cx"> m_readyState = HAVE_NOTHING;
</span><span class="cx"> updateMediaController();
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateActiveTextTrackCues(MediaTime::zeroTime());
</del><ins>+ updateActiveTextTrackCues(MediaTime::zeroTime());
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5469,8 +5410,7 @@
</span><span class="cx"> m_player->setVideoFullscreenLayer(platformLayer);
</span><span class="cx"> setNeedsStyleRecalc(SyntheticStyleChange);
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- updateTextTrackDisplay();
</del><ins>+ updateTextTrackDisplay();
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5496,7 +5436,7 @@
</span><span class="cx"> return true;
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled() || !m_textTracks)
</del><ins>+ if (!m_textTracks)
</ins><span class="cx"> return false;
</span><span class="cx">
</span><span class="cx"> for (unsigned i = 0; i < m_textTracks->length(); ++i) {
</span><span class="lines">@@ -5547,10 +5487,8 @@
</span><span class="cx"> m_player->setClosedCaptionsVisible(closedCaptionVisible);
</span><span class="cx">
</span><span class="cx"> #if ENABLE(VIDEO_TRACK)
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled()) {
- markCaptionAndSubtitleTracksAsUnconfigured(Immediately);
- updateTextTrackDisplay();
- }
</del><ins>+ markCaptionAndSubtitleTracksAsUnconfigured(Immediately);
+ updateTextTrackDisplay();
</ins><span class="cx"> #else
</span><span class="cx"> if (hasMediaControls())
</span><span class="cx"> mediaControls()->changedClosedCaptionsVisibility();
</span><span class="lines">@@ -5797,10 +5735,8 @@
</span><span class="cx">
</span><span class="cx"> mediaControls()->changedClosedCaptionsVisibility();
</span><span class="cx">
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled()) {
- updateTextTrackDisplay();
- updateActiveTextTrackCues(currentMediaTime());
- }
</del><ins>+ updateTextTrackDisplay();
+ updateActiveTextTrackCues(currentMediaTime());
</ins><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLTrackElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLTrackElement.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLTrackElement.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/html/HTMLTrackElement.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -92,24 +92,22 @@
</span><span class="cx">
</span><span class="cx"> void HTMLTrackElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
</span><span class="cx"> {
</span><del>- if (RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled()) {
- if (name == srcAttr) {
- if (!value.isEmpty())
- scheduleLoad();
- else if (m_track)
- m_track->removeAllCues();
</del><ins>+ if (name == srcAttr) {
+ if (!value.isEmpty())
+ scheduleLoad();
+ else if (m_track)
+ m_track->removeAllCues();
</ins><span class="cx">
</span><del>- // 4.8.10.12.3 Sourcing out-of-band text tracks
- // As the kind, label, and srclang attributes are set, changed, or removed, the text track must update accordingly...
- } else if (name == kindAttr)
- ensureTrack().setKindKeywordIgnoringASCIICase(value.string());
- else if (name == labelAttr)
- ensureTrack().setLabel(value);
- else if (name == srclangAttr)
- ensureTrack().setLanguage(value);
- else if (name == defaultAttr)
- ensureTrack().setIsDefault(!value.isNull());
- }
</del><ins>+ // 4.8.10.12.3 Sourcing out-of-band text tracks
+ // As the kind, label, and srclang attributes are set, changed, or removed, the text track must update accordingly...
+ } else if (name == kindAttr)
+ ensureTrack().setKindKeywordIgnoringASCIICase(value.string());
+ else if (name == labelAttr)
+ ensureTrack().setLabel(value);
+ else if (name == srclangAttr)
+ ensureTrack().setLanguage(value);
+ else if (name == defaultAttr)
+ ensureTrack().setIsDefault(!value.isNull());
</ins><span class="cx">
</span><span class="cx"> HTMLElement::parseAttribute(name, value);
</span><span class="cx"> }
</span><span class="lines">@@ -170,9 +168,6 @@
</span><span class="cx"> if (m_loadTimer.isActive())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return;
-
</del><span class="cx"> // 2. If the text track's text track mode is not set to one of hidden or showing, abort these steps.
</span><span class="cx"> if (ensureTrack().mode() != TextTrack::Mode::Hidden && ensureTrack().mode() != TextTrack::Mode::Showing)
</span><span class="cx"> return;
</span><span class="lines">@@ -208,9 +203,6 @@
</span><span class="cx">
</span><span class="cx"> bool HTMLTrackElement::canLoadURL(const URL& url)
</span><span class="cx"> {
</span><del>- if (!RuntimeEnabledFeatures::sharedFeatures().webkitVideoTrackEnabled())
- return false;
-
</del><span class="cx"> HTMLMediaElement* parent = mediaElement();
</span><span class="cx"> if (!parent)
</span><span class="cx"> return false;
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBlockFlowcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -3142,7 +3142,7 @@
</span><span class="cx">
</span><span class="cx"> void RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded()
</span><span class="cx"> {
</span><del>- if (!document().cssRegionsEnabled() || renderNamedFlowFragment() || isRenderNamedFlowFragment())
</del><ins>+ if (renderNamedFlowFragment() || isRenderNamedFlowFragment())
</ins><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> // FIXME: Multicolumn regions not yet supported (http://dev.w3.org/csswg/css-regions/#multi-column-regions)
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalSettingscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/InternalSettings.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -66,8 +66,7 @@
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><span class="cx"> InternalSettings::Backup::Backup(Settings& settings)
</span><del>- : m_originalCSSShapesEnabled(RuntimeEnabledFeatures::sharedFeatures().cssShapesEnabled())
- , m_originalEditingBehavior(settings.editingBehaviorType())
</del><ins>+ : m_originalEditingBehavior(settings.editingBehaviorType())
</ins><span class="cx"> #if ENABLE(TEXT_AUTOSIZING)
</span><span class="cx"> , m_originalTextAutosizingEnabled(settings.textAutosizingEnabled())
</span><span class="cx"> , m_originalTextAutosizingWindowSizeOverride(settings.textAutosizingWindowSizeOverride())
</span><span class="lines">@@ -113,7 +112,6 @@
</span><span class="cx">
</span><span class="cx"> void InternalSettings::Backup::restoreTo(Settings& settings)
</span><span class="cx"> {
</span><del>- RuntimeEnabledFeatures::sharedFeatures().setCSSShapesEnabled(m_originalCSSShapesEnabled);
</del><span class="cx"> settings.setEditingBehaviorType(m_originalEditingBehavior);
</span><span class="cx">
</span><span class="cx"> for (const auto& standardFont : m_standardFontFamilies)
</span><span class="lines">@@ -365,12 +363,6 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InternalSettings::setCSSShapesEnabled(bool enabled, ExceptionCode& ec)
-{
- UNUSED_PARAM(ec);
- RuntimeEnabledFeatures::sharedFeatures().setCSSShapesEnabled(enabled);
-}
-
</del><span class="cx"> void InternalSettings::setCanStartMedia(bool enabled, ExceptionCode& ec)
</span><span class="cx"> {
</span><span class="cx"> InternalSettingsGuardForSettings();
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalSettingsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/InternalSettings.h (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/InternalSettings.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/testing/InternalSettings.h 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -53,7 +53,6 @@
</span><span class="cx"> explicit Backup(Settings&);
</span><span class="cx"> void restoreTo(Settings&);
</span><span class="cx">
</span><del>- bool m_originalCSSShapesEnabled;
</del><span class="cx"> EditingBehaviorType m_originalEditingBehavior;
</span><span class="cx">
</span><span class="cx"> // Initially empty, only used if changed by a test.
</span><span class="lines">@@ -131,7 +130,6 @@
</span><span class="cx"> void setTextAutosizingWindowSizeOverride(int width, int height, ExceptionCode&);
</span><span class="cx"> void setTextAutosizingFontScaleFactor(float fontScaleFactor, ExceptionCode&);
</span><span class="cx"> void setMediaTypeOverride(const String& mediaType, ExceptionCode&);
</span><del>- void setCSSShapesEnabled(bool, ExceptionCode&);
</del><span class="cx"> void setCanStartMedia(bool, ExceptionCode&);
</span><span class="cx"> void setWirelessPlaybackDisabled(bool);
</span><span class="cx"> void setEditingBehavior(const String&, ExceptionCode&);
</span></span></pre></div>
<a id="trunkSourceWebCoretestingInternalSettingsidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/testing/InternalSettings.idl (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/testing/InternalSettings.idl 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebCore/testing/InternalSettings.idl 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -45,9 +45,6 @@
</span><span class="cx"> [RaisesException] void setTextAutosizingWindowSizeOverride(long width, long height);
</span><span class="cx"> [RaisesException] void setTextAutosizingFontScaleFactor(unrestricted float fontScaleFactor);
</span><span class="cx">
</span><del>- // Features
- [RaisesException] void setCSSShapesEnabled(boolean enabled);
-
</del><span class="cx"> // Media
</span><span class="cx"> [RaisesException] void setCanStartMedia(boolean enabled);
</span><span class="cx"> [Conditional=VIDEO_TRACK, RaisesException] void setShouldDisplayTrackKind(DOMString kind, boolean enabled);
</span></span></pre></div>
<a id="trunkSourceWebKitmacChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/ChangeLog (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/ChangeLog 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1,3 +1,29 @@
</span><ins>+2016-05-06 Dean Jackson <dino@apple.com>
+
+ Regions, Shapes and Tracks don't need runtime features
+ https://bugs.webkit.org/show_bug.cgi?id=157426
+ <rdar://problem/26146262>
+
+ Reviewed by Simon Fraser.
+
+ The following RuntimeEnabledFeatures can be removed since
+ we have no need to disable them (they are stable and have
+ shipped for a while):
+ - CSS Regions
+ - CSS Shapes
+ - Media tracks
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]): Deleted.
+ (-[WebPreferences cssRegionsEnabled]): Deleted.
+ (-[WebPreferences setCSSRegionsEnabled:]): Deleted.
+ (-[WebPreferences cssCompositingEnabled]): Deleted.
+ (-[WebPreferences setCSSCompositingEnabled:]): Deleted.
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]): Deleted.
+
</ins><span class="cx"> 2016-05-06 Daniel Bates <dabates@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove workaround for Apple Internal bots
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferenceKeysPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -102,8 +102,6 @@
</span><span class="cx"> #define WebKitDisplayListDrawingEnabledPreferenceKey @"WebKitDisplayListDrawingEnabled"
</span><span class="cx"> #define WebKitCanvasUsesAcceleratedDrawingPreferenceKey @"WebKitCanvasUsesAcceleratedDrawing"
</span><span class="cx"> #define WebKitAcceleratedCompositingEnabledPreferenceKey @"WebKitAcceleratedCompositingEnabled"
</span><del>-#define WebKitCSSRegionsEnabledPreferenceKey @"WebKitCSSRegionsEnabled"
-#define WebKitCSSCompositingEnabledPreferenceKey @"WebKitCSSCompositingEnabled"
</del><span class="cx"> #define WebKitShowDebugBordersPreferenceKey @"WebKitShowDebugBorders"
</span><span class="cx"> #define WebKitSimpleLineLayoutDebugBordersEnabledPreferenceKey @"WebKitSimpleLineLayoutDebugBordersEnabled"
</span><span class="cx"> #define WebKitShowRepaintCounterPreferenceKey @"WebKitShowRepaintCounter"
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -490,8 +490,6 @@
</span><span class="cx"> [NSNumber numberWithBool:NO], WebKitJavaScriptCanAccessClipboardPreferenceKey,
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitXSSAuditorEnabledPreferenceKey,
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitAcceleratedCompositingEnabledPreferenceKey,
</span><del>- [NSNumber numberWithBool:YES], WebKitCSSRegionsEnabledPreferenceKey,
- [NSNumber numberWithBool:YES], WebKitCSSCompositingEnabledPreferenceKey,
</del><span class="cx"> [NSNumber numberWithBool:NO], WebKitDisplayListDrawingEnabledPreferenceKey,
</span><span class="cx"> #if PLATFORM(IOS) && !PLATFORM(IOS_SIMULATOR)
</span><span class="cx"> [NSNumber numberWithBool:YES], WebKitAcceleratedDrawingEnabledPreferenceKey,
</span><span class="lines">@@ -1880,26 +1878,6 @@
</span><span class="cx"> [self _setBoolValue:enabled forKey:WebKitAcceleratedCompositingEnabledPreferenceKey];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (BOOL)cssRegionsEnabled
-{
- return [self _boolValueForKey:WebKitCSSRegionsEnabledPreferenceKey];
-}
-
-- (void)setCSSRegionsEnabled:(BOOL)enabled
-{
- [self _setBoolValue:enabled forKey:WebKitCSSRegionsEnabledPreferenceKey];
-}
-
-- (BOOL)cssCompositingEnabled
-{
- return [self _boolValueForKey:WebKitCSSCompositingEnabledPreferenceKey];
-}
-
-- (void)setCSSCompositingEnabled:(BOOL)enabled
-{
- [self _setBoolValue:enabled forKey:WebKitCSSCompositingEnabledPreferenceKey];
-}
-
</del><span class="cx"> - (BOOL)showDebugBorders
</span><span class="cx"> {
</span><span class="cx"> return [self _boolValueForKey:WebKitShowDebugBordersPreferenceKey];
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebPreferencesPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -212,12 +212,6 @@
</span><span class="cx"> - (BOOL)acceleratedCompositingEnabled;
</span><span class="cx"> - (void)setAcceleratedCompositingEnabled:(BOOL)enabled;
</span><span class="cx">
</span><del>-- (BOOL)cssRegionsEnabled;
-- (void)setCSSRegionsEnabled:(BOOL)enabled;
-
-- (BOOL)cssCompositingEnabled;
-- (void)setCSSCompositingEnabled:(BOOL)enabled;
-
</del><span class="cx"> - (BOOL)showDebugBorders;
</span><span class="cx"> - (void)setShowDebugBorders:(BOOL)show;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKitmacWebViewWebViewmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -2313,8 +2313,6 @@
</span><span class="cx"> settings.setFrameFlatteningEnabled([preferences isFrameFlatteningEnabled]);
</span><span class="cx"> settings.setSpatialNavigationEnabled([preferences isSpatialNavigationEnabled]);
</span><span class="cx"> settings.setPaginateDuringLayoutEnabled([preferences paginateDuringLayoutEnabled]);
</span><del>- RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled([preferences cssRegionsEnabled]);
- RuntimeEnabledFeatures::sharedFeatures().setCSSCompositingEnabled([preferences cssCompositingEnabled]);
</del><span class="cx">
</span><span class="cx"> settings.setAsynchronousSpellCheckingEnabled([preferences asynchronousSpellCheckingEnabled]);
</span><span class="cx"> settings.setHyperlinkAuditingEnabled([preferences hyperlinkAuditingEnabled]);
</span></span></pre></div>
<a id="trunkSourceWebKitwinWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit/win/WebView.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit/win/WebView.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit/win/WebView.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -5034,11 +5034,6 @@
</span><span class="cx"> return hr;
</span><span class="cx"> settings.setPluginsEnabled(!!enabled);
</span><span class="cx">
</span><del>- hr = preferences->isCSSRegionsEnabled(&enabled);
- if (FAILED(hr))
- return hr;
- RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled(!!enabled);
-
</del><span class="cx"> #if ENABLE(INDEXED_DATABASE)
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setWebkitIndexedDBEnabled(true);
</span><span class="cx"> #endif
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1,3 +1,31 @@
</span><ins>+2016-05-06 Dean Jackson <dino@apple.com>
+
+ Regions, Shapes and Tracks don't need runtime features
+ https://bugs.webkit.org/show_bug.cgi?id=157426
+ <rdar://problem/26146262>
+
+ Reviewed by Simon Fraser.
+
+ The following RuntimeEnabledFeatures can be removed since
+ we have no need to disable them (they are stable and have
+ shipped for a while):
+ - CSS Regions
+ - CSS Shapes
+ - Media tracks
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetCSSRegionsEnabled): Deleted.
+ (WKPreferencesGetCSSRegionsEnabled): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Deleted.
+ (WebKit::InjectedBundle::setCSSRegionsEnabled): Deleted.
+ (WebKit::InjectedBundle::setCSSCompositingEnabled): Deleted.
+ * WebProcess/InjectedBundle/InjectedBundle.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::updatePreferences): Deleted.
+
</ins><span class="cx"> 2016-05-05 Ada Chan <adachan@apple.com>
</span><span class="cx">
</span><span class="cx"> Create a fence in WebVideoFullscreenManagerProxy::setVideoLayerFrame() to pass to the web process
</span></span></pre></div>
<a id="trunkSourceWebKit2SharedWebPreferencesDefinitionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -132,8 +132,6 @@
</span><span class="cx"> macro(Accelerated2dCanvasEnabled, accelerated2dCanvasEnabled, Bool, bool, false, "", "") \
</span><span class="cx"> macro(CSSAnimationTriggersEnabled, cssAnimationTriggersEnabled, Bool, bool, true, "", "") \
</span><span class="cx"> macro(WebAnimationsEnabled, webAnimationsEnabled, Bool, bool, false, "", "") \
</span><del>- macro(CSSRegionsEnabled, cssRegionsEnabled, Bool, bool, true, "", "") \
- macro(CSSCompositingEnabled, cssCompositingEnabled, Bool, bool, true, "", "") \
</del><span class="cx"> macro(ForceFTPDirectoryListings, forceFTPDirectoryListings, Bool, bool, false, "", "") \
</span><span class="cx"> macro(TabsToLinks, tabsToLinks, Bool, bool, DEFAULT_WEBKIT_TABSTOLINKS_ENABLED, "", "") \
</span><span class="cx"> macro(DNSPrefetchingEnabled, dnsPrefetchingEnabled, Bool, bool, false, "", "") \
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -508,16 +508,6 @@
</span><span class="cx"> return toImpl(preferencesRef)->webAnimationsEnabled();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WKPreferencesSetCSSRegionsEnabled(WKPreferencesRef preferencesRef, bool flag)
-{
- toImpl(preferencesRef)->setCSSRegionsEnabled(flag);
-}
-
-bool WKPreferencesGetCSSRegionsEnabled(WKPreferencesRef preferencesRef)
-{
- return toImpl(preferencesRef)->cssRegionsEnabled();
-}
-
</del><span class="cx"> void WKPreferencesSetNeedsSiteSpecificQuirks(WKPreferencesRef preferencesRef, bool flag)
</span><span class="cx"> {
</span><span class="cx"> toImpl(preferencesRef)->setNeedsSiteSpecificQuirks(flag);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -115,10 +115,6 @@
</span><span class="cx"> WK_EXPORT void WKPreferencesSetWebAnimationsEnabled(WKPreferencesRef, bool flag);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetWebAnimationsEnabled(WKPreferencesRef);
</span><span class="cx">
</span><del>-// Defaults to true
-WK_EXPORT void WKPreferencesSetCSSRegionsEnabled(WKPreferencesRef, bool flag);
-WK_EXPORT bool WKPreferencesGetCSSRegionsEnabled(WKPreferencesRef);
-
</del><span class="cx"> // Defaults to false.
</span><span class="cx"> WK_EXPORT void WKPreferencesSetNeedsSiteSpecificQuirks(WKPreferencesRef, bool);
</span><span class="cx"> WK_EXPORT bool WKPreferencesGetNeedsSiteSpecificQuirks(WKPreferencesRef);
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleInjectedBundlecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -183,16 +183,6 @@
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsEnabled(enabled);
</span><span class="cx"> #endif
</span><span class="cx">
</span><del>-#if ENABLE(CSS_REGIONS)
- if (preference == "WebKitCSSRegionsEnabled")
- RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled(enabled);
-#endif
-
-#if ENABLE(CSS_COMPOSITING)
- if (preference == "WebKitCSSCompositingEnabled")
- RuntimeEnabledFeatures::sharedFeatures().setCSSCompositingEnabled(enabled);
-#endif
-
</del><span class="cx"> #if ENABLE(FETCH_API)
</span><span class="cx"> if (preference == "WebKitFetchAPIEnabled")
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled(enabled);
</span><span class="lines">@@ -595,22 +585,4 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InjectedBundle::setCSSRegionsEnabled(bool enabled)
-{
-#if ENABLE(CSS_REGIONS)
- RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled(enabled);
-#else
- UNUSED_PARAM(enabled);
-#endif
-}
-
-void InjectedBundle::setCSSCompositingEnabled(bool enabled)
-{
-#if ENABLE(CSS_COMPOSITING)
- RuntimeEnabledFeatures::sharedFeatures().setCSSCompositingEnabled(enabled);
-#else
- UNUSED_PARAM(enabled);
-#endif
-}
-
</del><span class="cx"> } // namespace WebKit
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessInjectedBundleInjectedBundleh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -153,8 +153,6 @@
</span><span class="cx"> void setSerialLoadingEnabled(bool);
</span><span class="cx"> void setCSSAnimationTriggersEnabled(bool);
</span><span class="cx"> void setWebAnimationsEnabled(bool);
</span><del>- void setCSSRegionsEnabled(bool);
- void setCSSCompositingEnabled(bool);
</del><span class="cx"> void dispatchPendingLoadRequests();
</span><span class="cx">
</span><span class="cx"> #if PLATFORM(COCOA) && WK_API_ENABLED
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessWebPageWebPagecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -2919,8 +2919,6 @@
</span><span class="cx"> #if ENABLE(WEB_ANIMATIONS)
</span><span class="cx"> RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsEnabled(store.getBoolValueForKey(WebPreferencesKey::webAnimationsEnabledKey()));
</span><span class="cx"> #endif
</span><del>- RuntimeEnabledFeatures::sharedFeatures().setCSSRegionsEnabled(store.getBoolValueForKey(WebPreferencesKey::cssRegionsEnabledKey()));
- RuntimeEnabledFeatures::sharedFeatures().setCSSCompositingEnabled(store.getBoolValueForKey(WebPreferencesKey::cssCompositingEnabledKey()));
</del><span class="cx"> settings.setWebGLEnabled(store.getBoolValueForKey(WebPreferencesKey::webGLEnabledKey()));
</span><span class="cx"> settings.setForceSoftwareWebGLRendering(store.getBoolValueForKey(WebPreferencesKey::forceSoftwareWebGLRenderingKey()));
</span><span class="cx"> settings.setAccelerated2dCanvasEnabled(store.getBoolValueForKey(WebPreferencesKey::accelerated2dCanvasEnabledKey()));
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Tools/ChangeLog 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-05-06 Dean Jackson <dino@apple.com>
+
+ Regions, Shapes and Tracks don't need runtime features
+ https://bugs.webkit.org/show_bug.cgi?id=157426
+ <rdar://problem/26146262>
+
+ Reviewed by Simon Fraser.
+
+ The following RuntimeEnabledFeatures can be removed since
+ we have no need to disable them (they are stable and have
+ shipped for a while):
+ - CSS Regions
+ - CSS Shapes
+ - Media tracks
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues): Deleted.
+
</ins><span class="cx"> 2016-05-06 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Increase delay when launching multiple ios-simulators in parallel
</span></span></pre></div>
<a id="trunkToolsDumpRenderTreemacDumpRenderTreemm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (200523 => 200524)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-05-06 21:16:42 UTC (rev 200523)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2016-05-06 21:21:20 UTC (rev 200524)
</span><span class="lines">@@ -966,7 +966,6 @@
</span><span class="cx"> [preferences setCanvasUsesAcceleratedDrawing:YES];
</span><span class="cx"> [preferences setAcceleratedDrawingEnabled:useAcceleratedDrawing];
</span><span class="cx"> #endif
</span><del>- [preferences setCSSRegionsEnabled:YES];
</del><span class="cx"> [preferences setUsePreHTML5ParserQuirks:NO];
</span><span class="cx"> [preferences setAsynchronousSpellCheckingEnabled:NO];
</span><span class="cx"> #if !PLATFORM(IOS)
</span></span></pre>
</div>
</div>
</body>
</html>