<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200480] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200480">200480</a></dd>
<dt>Author</dt> <dd>fpizlo@apple.com</dd>
<dt>Date</dt> <dd>2016-05-05 14:53:27 -0700 (Thu, 05 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Reduce thresholds that control the maximum IC stub size.
Rubber stamped by Chris Dumez and Benjamin Poulain.
This reduces the thresholds to before the megamorphic load optimizations to see if that
recovers a PLT regression.
* runtime/Options.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeOptionsh">trunk/Source/JavaScriptCore/runtime/Options.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (200479 => 200480)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-05-05 21:38:41 UTC (rev 200479)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-05-05 21:53:27 UTC (rev 200480)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-05-05 Filip Pizlo <fpizlo@apple.com>
</span><span class="cx">
</span><ins>+ Reduce thresholds that control the maximum IC stub size.
+
+ Rubber stamped by Chris Dumez and Benjamin Poulain.
+
+ This reduces the thresholds to before the megamorphic load optimizations to see if that
+ recovers a PLT regression.
+
+ * runtime/Options.h:
+
+2016-05-05 Filip Pizlo <fpizlo@apple.com>
+
</ins><span class="cx"> We shouldn't crash if DFG AI proved that something was unreachable on one run but then decided not to prove it on another run
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=157379
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeOptionsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/Options.h (200479 => 200480)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/Options.h 2016-05-05 21:38:41 UTC (rev 200479)
+++ trunk/Source/JavaScriptCore/runtime/Options.h 2016-05-05 21:53:27 UTC (rev 200480)
</span><span class="lines">@@ -123,9 +123,9 @@
</span><span class="cx"> v(bool, forceCodeBlockLiveness, false, Normal, nullptr) \
</span><span class="cx"> v(bool, forceICFailure, false, Normal, nullptr) \
</span><span class="cx"> \
</span><del>- v(unsigned, repatchCountForCoolDown, 10, Normal, nullptr) \
</del><ins>+ v(unsigned, repatchCountForCoolDown, 8, Normal, nullptr) \
</ins><span class="cx"> v(unsigned, initialCoolDownCount, 20, Normal, nullptr) \
</span><del>- v(unsigned, repatchBufferingCountdown, 10, Normal, nullptr) \
</del><ins>+ v(unsigned, repatchBufferingCountdown, 8, Normal, nullptr) \
</ins><span class="cx"> \
</span><span class="cx"> v(bool, dumpGeneratedBytecodes, false, Normal, nullptr) \
</span><span class="cx"> v(bool, dumpBytecodeLivenessResults, false, Normal, nullptr) \
</span><span class="lines">@@ -191,7 +191,7 @@
</span><span class="cx"> v(bool, ftlCrashes, false, Normal, nullptr) /* fool-proof way of checking that you ended up in the FTL. ;-) */\
</span><span class="cx"> v(bool, clobberAllRegsInFTLICSlowPath, !ASSERT_DISABLED, Normal, nullptr) \
</span><span class="cx"> v(bool, useAccessInlining, true, Normal, nullptr) \
</span><del>- v(unsigned, maxAccessVariantListSize, 13, Normal, nullptr) \
</del><ins>+ v(unsigned, maxAccessVariantListSize, 8, Normal, nullptr) \
</ins><span class="cx"> v(unsigned, megamorphicLoadCost, 999, Normal, nullptr) /* This used to be 10, but we're temporarily testing what happens when the feature is disabled. */\
</span><span class="cx"> v(bool, usePolyvariantDevirtualization, true, Normal, nullptr) \
</span><span class="cx"> v(bool, usePolymorphicAccessInlining, true, Normal, nullptr) \
</span></span></pre>
</div>
</div>
</body>
</html>