<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200436] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200436">200436</a></dd>
<dt>Author</dt> <dd>dino@apple.com</dd>
<dt>Date</dt> <dd>2016-05-04 15:28:40 -0700 (Wed, 04 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>TestRunner should always enable all the experimental features
https://bugs.webkit.org/show_bug.cgi?id=157360
<rdar://problem/26099748>
Reviewed by Anders Carlsson.
Source/WebKit2:
Experimental features are disabled by default, but it is
a pain to enable them in every test. Instead, have the
test runner turn them all on.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesEnableAllExperimentalFeatures):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::enableAllExperimentalFeatures):
* UIProcess/WebPreferences.h:
Tools:
Call the new SPI that enables all the experimental features.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencescpp">trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh">trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPreferencescpp">trunk/Source/WebKit2/UIProcess/WebPreferences.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPreferencesh">trunk/Source/WebKit2/UIProcess/WebPreferences.h</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsWebKitTestRunnerTestControllercpp">trunk/Tools/WebKitTestRunner/TestController.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (200435 => 200436)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-04 22:28:40 UTC (rev 200436)
</span><span class="lines">@@ -1,3 +1,22 @@
</span><ins>+2016-05-04 Dean Jackson <dino@apple.com>
+
+ TestRunner should always enable all the experimental features
+ https://bugs.webkit.org/show_bug.cgi?id=157360
+ <rdar://problem/26099748>
+
+ Reviewed by Anders Carlsson.
+
+ Experimental features are disabled by default, but it is
+ a pain to enable them in every test. Instead, have the
+ test runner turn them all on.
+
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesEnableAllExperimentalFeatures):
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+ * UIProcess/WebPreferences.cpp:
+ (WebKit::WebPreferences::enableAllExperimentalFeatures):
+ * UIProcess/WebPreferences.h:
+
</ins><span class="cx"> 2016-05-04 Gyuyoung Kim <gyuyoung.kim@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add WKPreference for SelectionPaintingWithoutSelectionGaps
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp (200435 => 200436)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp 2016-05-04 22:28:40 UTC (rev 200436)
</span><span class="lines">@@ -62,6 +62,11 @@
</span><span class="cx"> return toAPI(preferences.release().leakRef());
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void WKPreferencesEnableAllExperimentalFeatures(WKPreferencesRef preferencesRef)
+{
+ toImpl(preferencesRef)->enableAllExperimentalFeatures();
+}
+
</ins><span class="cx"> void WKPreferencesSetJavaScriptEnabled(WKPreferencesRef preferencesRef, bool javaScriptEnabled)
</span><span class="cx"> {
</span><span class="cx"> toImpl(preferencesRef)->setJavaScriptEnabled(javaScriptEnabled);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPICWKPreferencesRefPrivateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (200435 => 200436)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h 2016-05-04 22:28:40 UTC (rev 200436)
</span><span class="lines">@@ -57,6 +57,8 @@
</span><span class="cx"> // Creates a copy with no identifier.
</span><span class="cx"> WK_EXPORT WKPreferencesRef WKPreferencesCreateCopy(WKPreferencesRef);
</span><span class="cx">
</span><ins>+WK_EXPORT void WKPreferencesEnableAllExperimentalFeatures(WKPreferencesRef);
+
</ins><span class="cx"> // Defaults to kWKFontSmoothingLevelMedium.
</span><span class="cx"> WK_EXPORT void WKPreferencesSetFontSmoothingLevel(WKPreferencesRef, WKFontSmoothingLevel);
</span><span class="cx"> WK_EXPORT WKFontSmoothingLevel WKPreferencesGetFontSmoothingLevel(WKPreferencesRef);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPreferencescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPreferences.cpp (200435 => 200436)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPreferences.cpp 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Source/WebKit2/UIProcess/WebPreferences.cpp 2016-05-04 22:28:40 UTC (rev 200436)
</span><span class="lines">@@ -263,6 +263,16 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void WebPreferences::enableAllExperimentalFeatures()
+{
+#define SET_FEATURE_ENABLED(KeyUpper, KeyLower, TypeName, Type, DefaultValue, HumanReadableName, HumanReadableDescription) \
+ set##KeyUpper(true); \
+
+ FOR_EACH_WEBKIT_EXPERIMENTAL_FEATURE_PREFERENCE(SET_FEATURE_ENABLED)
+
+#undef SET_FEATURE_ENABLED
+}
+
</ins><span class="cx"> bool WebPreferences::anyPagesAreUsingPrivateBrowsing()
</span><span class="cx"> {
</span><span class="cx"> return privateBrowsingPageCount;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPreferencesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPreferences.h (200435 => 200436)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPreferences.h 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Source/WebKit2/UIProcess/WebPreferences.h 2016-05-04 22:28:40 UTC (rev 200436)
</span><span class="lines">@@ -67,6 +67,7 @@
</span><span class="cx"> static const Vector<RefPtr<API::Object>>& experimentalFeatures();
</span><span class="cx"> bool isEnabledForFeature(const API::ExperimentalFeature&) const;
</span><span class="cx"> void setEnabledForFeature(bool, const API::ExperimentalFeature&);
</span><ins>+ void enableAllExperimentalFeatures();
</ins><span class="cx">
</span><span class="cx"> // Exposed for WebKitTestRunner use only.
</span><span class="cx"> void forceUpdate() { update(); }
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (200435 => 200436)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Tools/ChangeLog 2016-05-04 22:28:40 UTC (rev 200436)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-05-04 Dean Jackson <dino@apple.com>
+
+ TestRunner should always enable all the experimental features
+ https://bugs.webkit.org/show_bug.cgi?id=157360
+ <rdar://problem/26099748>
+
+ Reviewed by Anders Carlsson.
+
+ Call the new SPI that enables all the experimental features.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+
</ins><span class="cx"> 2016-05-04 Mark Lam <mark.lam@apple.com>
</span><span class="cx">
</span><span class="cx"> ES6 Function.name inferred from property names of literal objects can break some websites.
</span></span></pre></div>
<a id="trunkToolsWebKitTestRunnerTestControllercpp"></a>
<div class="modfile"><h4>Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (200435 => 200436)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/WebKitTestRunner/TestController.cpp 2016-05-04 22:27:58 UTC (rev 200435)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2016-05-04 22:28:40 UTC (rev 200436)
</span><span class="lines">@@ -643,6 +643,7 @@
</span><span class="cx"> // Reset preferences
</span><span class="cx"> WKPreferencesRef preferences = platformPreferences();
</span><span class="cx"> WKPreferencesResetTestRunnerOverrides(preferences);
</span><ins>+ WKPreferencesEnableAllExperimentalFeatures(preferences);
</ins><span class="cx"> WKPreferencesSetPageVisibilityBasedProcessSuppressionEnabled(preferences, false);
</span><span class="cx"> WKPreferencesSetOfflineWebApplicationCacheEnabled(preferences, true);
</span><span class="cx"> WKPreferencesSetFontSmoothingLevel(preferences, kWKFontSmoothingLevelNoSubpixelAntiAliasing);
</span></span></pre>
</div>
</div>
</body>
</html>