<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200448] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200448">200448</a></dd>
<dt>Author</dt> <dd>darin@apple.com</dd>
<dt>Date</dt> <dd>2016-05-04 20:09:41 -0700 (Wed, 04 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Start on dictionary support for IDL, getting enough to work for one dictionary
https://bugs.webkit.org/show_bug.cgi?id=157336
Reviewed by Alex Christensen.
* bindings/js/JSDOMBinding.h: Return RefPtr instead of PassRefPtr for the return
value of toArrayBufferView. Not only is this the correct modern idiom, it also
works properly with auto, and PassRefPtr does not.
* bindings/js/JSDOMBuild.h: Added. This has the build function template in it.
It's used to build values like dictionaries. We specialize and call the tempate
in generated code. This is only the initial simplistic version; will be refining
for exception handling, optional handling, default value handling, and lots of
other things not yet needed for this first dictionary.
* bindings/scripts/CodeGenerator.pm:
(ProcessDocument): Handle dictionaries much like how we handle enumerations.
(SkipIncludeHeader): Moved small list of special types here from CodeGeneratorJS.
(IsDictionaryType): Added.
(IsRefPtrType): Make this return 0 for dictionary types.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateInterface): Added handling for dictionaries.
(SkipIncludeHeader): Deleted.
(AddIncludesForType): Call the the SkipIncludeHeader from CodeGenerator.pm directly.
(GetNestedClassName): Factored out the work that was previously in
GetEnumerationClassName so we could reuse it for dictionaries too.
(GetEnumerationClassName): Changed to call GetNestedClassName.
(GetEnumerationClassIdentifier): Deleted. Instead of using this, we now use templates
so we can use the actual class name.
(GenerateEnumerationImplementationContent): Changed parse and expectedEnumerationValues
to use function template specialization instead of functions. This cleans up the code
a bit and makes it eaiser to use from other templates. Later we may want to merge the
parse function template build function template from JSDOMBuild.h. Added specialization
of the build function template.
(GetDictionaryClassName): Added. Calls GetNestedClassName.
(GenerateDictionaryImplementationContent): Added. Generates the build function for each
dictionary type. Initial simplistic version to be refined.
(GenerateImplementation): Added dictionaries argument and called the
GenerateDictionaryImplementationContent function. Also changed many functions to take
interface arguments and also removed redundant interfaceName arguments from functions
that formerly took both.
(GenerateParametersCheck): Updated for changes above. That includes calling the new
parse function template. Also changed to use auto and WTFMove, which makes the code
both more generic and potentially more efficient and obviates the need for a special
case for dictionary types.
(GenerateCallbackHeader): Updated for changes above.
(GenerateCallbackImplementation): Ditto.
(GenerateImplementationFunctionCall): Ditto.
(GetNativeTypeFromSignature): Ditto.
(GetNativeType): Changed this function to take the interface because that's needed to
get the type name right for enumeration types rather than returning "auto". Made that
change as well. Moved one type, DOMStringList, into the nativeType hash instead of
having explicit code here for it. Didn't add a dictionary type case here yet, but
probably will need to do that in the next patch.
(ShouldPassWrapperByReference): Pass interface in to GetNativeType.
(GetNativeVectorInnerType): Removed unneeded special case for DOMString.
(GetNativeTypeForCallbacks): Changed to take the interface.
(GetNativeTypeForMemoization): Ditto.
(JSValueToNative): Changed expression for Dictionary (the thing I am working to make
obsolete) to name the type so it will work with auto. Added a case for dictionary
types and updated the case for enumeration types.
(NativeToJSValue): Updated to take an interface rather than an interface name, and to
pass that along as needed.
* bindings/scripts/IDLParser.pm:
(Parse): Add dictionaries to a list.
(parseDictionary): Put name, extended attributes, and members into the dictionary.
(parseDictionaryMembers): Build up a members array.
(parseDictionaryMember): Put isOptional, type, name, and default value into the
dictionary member.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
* bindings/scripts/test/JS/JSTestGlobalObject.cpp:
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
* bindings/scripts/test/JS/JSTestNode.cpp:
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
Regenerated.
* bindings/scripts/test/TestObj.idl: Added some test cases that I was using to
get the bindings script to work. Right now this is basically identical to the
actual use of this in Element.idl, but over time I will modify it to cover more
features of dictionaries. Also fixed some incorrect test cases trying to use
the type "bool", which doesn't exist in IDL.
* dom/Element.cpp:
(WebCore::Element::canHaveUserAgentShadowRoot): Added. The existing code used a
combination of a virtual function on HTMLElement and type checking. It's better
to just use a virtual function on Element.
(WebCore::Element::attachShadow): Updated to take a ShadowRootInit struct instead
of a Dictionary. Also tweaked the code in a couple other minor ways.
* dom/Element.h: Added the ShadowRootMode enum class and the ShadowRootInit struct,
and changed attachShadow to take ShadowRootInit instead of Dictionary. Also added
the private canHaveUserAgentShadowRoot virtual function.
* dom/Element.idl: Added ShadowRootMode, ShadowRootInit, and used them in as the
arguemnt type for attachShadow.
* html/HTMLElement.h: Made canHaveUserAgentShadowRoot a private override instead
of a public virtual function.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMBindingh">trunk/Source/WebCore/bindings/js/JSDOMBinding.h</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorpm">trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm">trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptsIDLParserpm">trunk/Source/WebCore/bindings/scripts/IDLParser.pm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestObjh">trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestActiveDOMObjectcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestCustomNamedGettercpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestEventTargetcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestGlobalObjectcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestInterfacecpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestNamedConstructorcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestNodecpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestNondeterministiccpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestOverloadedConstructorscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestOverrideBuiltinscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestSerializedScriptValueInterfacecpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestJSJSTestTypedefscpp">trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestObjCDOMTestObjh">trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestObjCDOMTestObjmm">trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm</a></li>
<li><a href="#trunkSourceWebCorebindingsscriptstestTestObjidl">trunk/Source/WebCore/bindings/scripts/test/TestObj.idl</a></li>
<li><a href="#trunkSourceWebCoredomElementcpp">trunk/Source/WebCore/dom/Element.cpp</a></li>
<li><a href="#trunkSourceWebCoredomElementh">trunk/Source/WebCore/dom/Element.h</a></li>
<li><a href="#trunkSourceWebCoredomElementidl">trunk/Source/WebCore/dom/Element.idl</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLElementh">trunk/Source/WebCore/html/HTMLElement.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkSourceWebCorebindingsjsJSDOMBuildh">trunk/Source/WebCore/bindings/js/JSDOMBuild.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/ChangeLog 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -1,3 +1,119 @@
</span><ins>+2016-05-03 Darin Adler <darin@apple.com>
+
+ Start on dictionary support for IDL, getting enough to work for one dictionary
+ https://bugs.webkit.org/show_bug.cgi?id=157336
+
+ Reviewed by Alex Christensen.
+
+ * bindings/js/JSDOMBinding.h: Return RefPtr instead of PassRefPtr for the return
+ value of toArrayBufferView. Not only is this the correct modern idiom, it also
+ works properly with auto, and PassRefPtr does not.
+
+ * bindings/js/JSDOMBuild.h: Added. This has the build function template in it.
+ It's used to build values like dictionaries. We specialize and call the tempate
+ in generated code. This is only the initial simplistic version; will be refining
+ for exception handling, optional handling, default value handling, and lots of
+ other things not yet needed for this first dictionary.
+
+ * bindings/scripts/CodeGenerator.pm:
+ (ProcessDocument): Handle dictionaries much like how we handle enumerations.
+ (SkipIncludeHeader): Moved small list of special types here from CodeGeneratorJS.
+ (IsDictionaryType): Added.
+ (IsRefPtrType): Make this return 0 for dictionary types.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateInterface): Added handling for dictionaries.
+ (SkipIncludeHeader): Deleted.
+ (AddIncludesForType): Call the the SkipIncludeHeader from CodeGenerator.pm directly.
+ (GetNestedClassName): Factored out the work that was previously in
+ GetEnumerationClassName so we could reuse it for dictionaries too.
+ (GetEnumerationClassName): Changed to call GetNestedClassName.
+ (GetEnumerationClassIdentifier): Deleted. Instead of using this, we now use templates
+ so we can use the actual class name.
+ (GenerateEnumerationImplementationContent): Changed parse and expectedEnumerationValues
+ to use function template specialization instead of functions. This cleans up the code
+ a bit and makes it eaiser to use from other templates. Later we may want to merge the
+ parse function template build function template from JSDOMBuild.h. Added specialization
+ of the build function template.
+ (GetDictionaryClassName): Added. Calls GetNestedClassName.
+ (GenerateDictionaryImplementationContent): Added. Generates the build function for each
+ dictionary type. Initial simplistic version to be refined.
+ (GenerateImplementation): Added dictionaries argument and called the
+ GenerateDictionaryImplementationContent function. Also changed many functions to take
+ interface arguments and also removed redundant interfaceName arguments from functions
+ that formerly took both.
+ (GenerateParametersCheck): Updated for changes above. That includes calling the new
+ parse function template. Also changed to use auto and WTFMove, which makes the code
+ both more generic and potentially more efficient and obviates the need for a special
+ case for dictionary types.
+ (GenerateCallbackHeader): Updated for changes above.
+ (GenerateCallbackImplementation): Ditto.
+ (GenerateImplementationFunctionCall): Ditto.
+ (GetNativeTypeFromSignature): Ditto.
+ (GetNativeType): Changed this function to take the interface because that's needed to
+ get the type name right for enumeration types rather than returning "auto". Made that
+ change as well. Moved one type, DOMStringList, into the nativeType hash instead of
+ having explicit code here for it. Didn't add a dictionary type case here yet, but
+ probably will need to do that in the next patch.
+ (ShouldPassWrapperByReference): Pass interface in to GetNativeType.
+ (GetNativeVectorInnerType): Removed unneeded special case for DOMString.
+ (GetNativeTypeForCallbacks): Changed to take the interface.
+ (GetNativeTypeForMemoization): Ditto.
+ (JSValueToNative): Changed expression for Dictionary (the thing I am working to make
+ obsolete) to name the type so it will work with auto. Added a case for dictionary
+ types and updated the case for enumeration types.
+ (NativeToJSValue): Updated to take an interface rather than an interface name, and to
+ pass that along as needed.
+
+ * bindings/scripts/IDLParser.pm:
+ (Parse): Add dictionaries to a list.
+ (parseDictionary): Put name, extended attributes, and members into the dictionary.
+ (parseDictionaryMembers): Build up a members array.
+ (parseDictionaryMember): Put isOptional, type, name, and default value into the
+ dictionary member.
+
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+ * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
+ * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
+ * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
+ * bindings/scripts/test/JS/JSTestEventTarget.cpp:
+ * bindings/scripts/test/JS/JSTestGlobalObject.cpp:
+ * bindings/scripts/test/JS/JSTestInterface.cpp:
+ * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
+ * bindings/scripts/test/JS/JSTestNode.cpp:
+ * bindings/scripts/test/JS/JSTestNondeterministic.cpp:
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
+ * bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
+ * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
+ * bindings/scripts/test/JS/JSTestTypedefs.cpp:
+ * bindings/scripts/test/ObjC/DOMTestObj.h:
+ * bindings/scripts/test/ObjC/DOMTestObj.mm:
+ Regenerated.
+
+ * bindings/scripts/test/TestObj.idl: Added some test cases that I was using to
+ get the bindings script to work. Right now this is basically identical to the
+ actual use of this in Element.idl, but over time I will modify it to cover more
+ features of dictionaries. Also fixed some incorrect test cases trying to use
+ the type "bool", which doesn't exist in IDL.
+
+ * dom/Element.cpp:
+ (WebCore::Element::canHaveUserAgentShadowRoot): Added. The existing code used a
+ combination of a virtual function on HTMLElement and type checking. It's better
+ to just use a virtual function on Element.
+ (WebCore::Element::attachShadow): Updated to take a ShadowRootInit struct instead
+ of a Dictionary. Also tweaked the code in a couple other minor ways.
+
+ * dom/Element.h: Added the ShadowRootMode enum class and the ShadowRootInit struct,
+ and changed attachShadow to take ShadowRootInit instead of Dictionary. Also added
+ the private canHaveUserAgentShadowRoot virtual function.
+
+ * dom/Element.idl: Added ShadowRootMode, ShadowRootInit, and used them in as the
+ arguemnt type for attachShadow.
+
+ * html/HTMLElement.h: Made canHaveUserAgentShadowRoot a private override instead
+ of a public virtual function.
+
</ins><span class="cx"> 2016-05-04 Eric Carlson <eric.carlson@apple.com>
</span><span class="cx">
</span><span class="cx"> [iOS] Playback does not pause when locking screen after playing to AirPlay.
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMBindingh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -551,9 +551,9 @@
</span><span class="cx">
</span><span class="cx"> WEBCORE_EXPORT JSC::JSValue jsArray(JSC::ExecState*, JSDOMGlobalObject*, PassRefPtr<DOMStringList>);
</span><span class="cx">
</span><del>-inline PassRefPtr<JSC::ArrayBufferView> toArrayBufferView(JSC::JSValue value)
</del><ins>+inline RefPtr<JSC::ArrayBufferView> toArrayBufferView(JSC::JSValue value)
</ins><span class="cx"> {
</span><del>- JSC::JSArrayBufferView* wrapper = JSC::jsDynamicCast<JSC::JSArrayBufferView*>(value);
</del><ins>+ auto* wrapper = JSC::jsDynamicCast<JSC::JSArrayBufferView*>(value);
</ins><span class="cx"> if (!wrapper)
</span><span class="cx"> return nullptr;
</span><span class="cx"> return wrapper->impl();
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsjsJSDOMBuildh"></a>
<div class="addfile"><h4>Added: trunk/Source/WebCore/bindings/js/JSDOMBuild.h (0 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/js/JSDOMBuild.h (rev 0)
+++ trunk/Source/WebCore/bindings/js/JSDOMBuild.h 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -0,0 +1,39 @@
</span><ins>+/*
+
+Copyright (C) 2016 Apple Inc. All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions
+are met:
+1. Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+2. Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in the
+ documentation and/or other materials provided with the distribution.
+
+THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+*/
+
+#pragma once
+
+namespace WebCore {
+
+template<typename T> T build(JSC::ExecState&, JSC::JSValue);
+template<typename T, unsigned characterCount> T build(JSC::ExecState&, JSC::JSValue, const char (&propertyName)[characterCount]);
+
+template<typename T, unsigned characterCount> inline T build(JSC::ExecState& state, JSC::JSValue value, const char (&propertyName)[characterCount])
+{
+ return build<T>(state, value.get(&state, JSC::Identifier::fromString(&state, propertyName)));
+}
+
+}
</ins></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -70,6 +70,7 @@
</span><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> my %enumTypeHash = ();
</span><ins>+my %dictionaryTypes = ();
</ins><span class="cx">
</span><span class="cx"> my %typedArrayTypes = (
</span><span class="cx"> "ArrayBuffer" => 1,
</span><span class="lines">@@ -162,6 +163,7 @@
</span><span class="cx"> require $ifaceName . ".pm";
</span><span class="cx">
</span><span class="cx"> %enumTypeHash = map { $_->name => $_->values } @{$useDocument->enumerations};
</span><ins>+ %dictionaryTypes = map { $_->name => 1 } @{$useDocument->dictionaries};
</ins><span class="cx">
</span><span class="cx"> # Dynamically load external code generation perl module
</span><span class="cx"> $codeGenerator = $ifaceName->new($object, $writeDependencies, $verbose, $targetIdlFilePath);
</span><span class="lines">@@ -176,9 +178,9 @@
</span><span class="cx"> my $interfaces = $useDocument->interfaces;
</span><span class="cx"> foreach my $interface (@$interfaces) {
</span><span class="cx"> print "Generating $useGenerator bindings code for IDL interface \"" . $interface->name . "\"...\n" if $verbose;
</span><del>- # FIXME: Repeating each enumeration for every interface would not work if we actually were using
</del><ins>+ # FIXME: Repeating each enumeration and dictionaries for every interface would not work if we actually were using
</ins><span class="cx"> # multiple interfaces per file, but we aren't, so this is fine for now.
</span><del>- $codeGenerator->GenerateInterface($interface, $defines, $useDocument->enumerations);
</del><ins>+ $codeGenerator->GenerateInterface($interface, $defines, $useDocument->enumerations, $useDocument->dictionaries);
</ins><span class="cx"> $codeGenerator->WriteData($interface, $useOutputDir, $useOutputHeadersDir);
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -324,14 +326,16 @@
</span><span class="cx"> my $object = shift;
</span><span class="cx"> my $type = shift;
</span><span class="cx">
</span><ins>+ # FIXME: This is a lot like !IsRefPtrType. Maybe they could share code?
+
</ins><span class="cx"> return 1 if $object->IsPrimitiveType($type);
</span><ins>+ return 1 if $object->IsTypedArrayType($type);
+ return 1 if $type eq "Array";
+ return 1 if $type eq "DOMString";
+ return 1 if $type eq "DOMTimeStamp";
+ return 1 if $type eq "SVGNumber";
+ return 1 if $type eq "any";
</ins><span class="cx">
</span><del>- # Special case: SVGNumber.h does not exist.
- return 1 if $type eq "SVGNumber";
-
- # Typed arrays already included by JSDOMBinding.h.
- return 1 if $object->IsTypedArrayType($type);
-
</del><span class="cx"> return 0;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -390,6 +394,13 @@
</span><span class="cx"> return @{$enumTypeHash{$type}};
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+sub IsDictionaryType
+{
+ my ($object, $type) = @_;
+
+ return $dictionaryTypes{$type} || 0;
+}
+
</ins><span class="cx"> sub IsNonPointerType
</span><span class="cx"> {
</span><span class="cx"> my $object = shift;
</span><span class="lines">@@ -432,8 +443,9 @@
</span><span class="cx"> my $type = shift;
</span><span class="cx">
</span><span class="cx"> return 0 if $object->IsPrimitiveType($type);
</span><ins>+ return 0 if $object->IsDictionaryType($type);
+ return 0 if $object->IsEnumType($type);
</ins><span class="cx"> return 0 if $object->GetArrayOrSequenceType($type);
</span><del>- return 0 if $object->IsEnumType($type);
</del><span class="cx"> return 0 if $type eq "DOMString";
</span><span class="cx"> return 0 if $type eq "any";
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsCodeGeneratorJSpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -120,20 +120,15 @@
</span><span class="cx">
</span><span class="cx"> sub GenerateInterface
</span><span class="cx"> {
</span><del>- my $object = shift;
- my $interface = shift;
- my $defines = shift;
- my $enumerations = shift;
</del><ins>+ my ($object, $interface, $defines, $enumerations, $dictionaries) = @_;
</ins><span class="cx">
</span><span class="cx"> $codeGenerator->LinkOverloadedFunctions($interface);
</span><del>-
- # Start actual generation
</del><span class="cx"> if ($interface->isCallback) {
</span><span class="cx"> $object->GenerateCallbackHeader($interface);
</span><del>- $object->GenerateCallbackImplementation($interface, $enumerations);
</del><ins>+ $object->GenerateCallbackImplementation($interface, $enumerations, $dictionaries);
</ins><span class="cx"> } else {
</span><span class="cx"> $object->GenerateHeader($interface);
</span><del>- $object->GenerateImplementation($interface, $enumerations);
</del><ins>+ $object->GenerateImplementation($interface, $enumerations, $dictionaries);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -208,21 +203,6 @@
</span><span class="cx"> AddIncludesForType($type, $isCallback, \%headerIncludes);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-my %typesWithoutHeader = (
- "Array" => 1,
- "DOMString" => 1,
- "DOMTimeStamp" => 1,
- "any" => 1
-);
-
-sub SkipIncludeHeader
-{
- my $type = shift;
-
- return 1 if $codeGenerator->SkipIncludeHeader($type);
- return $typesWithoutHeader{$type};
-}
-
</del><span class="cx"> sub GetExportMacroForJSClass
</span><span class="cx"> {
</span><span class="cx"> my $interface = shift;
</span><span class="lines">@@ -237,7 +217,7 @@
</span><span class="cx"> my $isCallback = shift;
</span><span class="cx"> my $includesRef = shift;
</span><span class="cx">
</span><del>- return if SkipIncludeHeader($type);
</del><ins>+ return if $codeGenerator->SkipIncludeHeader($type);
</ins><span class="cx">
</span><span class="cx"> # When we're finished with the one-file-per-class reorganization, we won't need these special cases.
</span><span class="cx"> if ($type eq "XPathNSResolver") {
</span><span class="lines">@@ -820,35 +800,33 @@
</span><span class="cx"> || IsClassNameWordBoundary($class, -$i) && substr($class, -$i) eq substr($name, 0, $i));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-sub GetEnumerationClassName
</del><ins>+sub GetNestedClassName
</ins><span class="cx"> {
</span><span class="cx"> my ($interface, $name) = @_;
</span><span class="cx">
</span><span class="cx"> my $class = GetImplClassName($interface->name);
</span><del>- my $enum = $codeGenerator->WK_ucfirst($name);
</del><ins>+ my $member = $codeGenerator->WK_ucfirst($name);
</ins><span class="cx">
</span><span class="cx"> # Since the enumeration name will be nested in the class name's namespace, remove any words
</span><span class="cx"> # that happen to match the start or end of the class name. If an enumeration is named TrackType or
</span><span class="cx"> # TextTrackType, and the class is named TextTrack, then we will get a name like TextTrack::Type.
</span><del>- my $enumLength = length($enum);
</del><ins>+ my $memberLength = length($member);
</ins><span class="cx"> my $longestPrefixLength = 0;
</span><del>- if ($enum =~ /^[A-Z]./) {
- for (my $i = 2; $i < $enumLength - 1; $i++) {
- $longestPrefixLength = $i if IsPrefixRemovable($class, $enum, $i);
</del><ins>+ if ($member =~ /^[A-Z]./) {
+ for (my $i = 2; $i < $memberLength - 1; $i++) {
+ $longestPrefixLength = $i if IsPrefixRemovable($class, $member, $i);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><del>- $enum = substr($enum, $longestPrefixLength);
</del><ins>+ $member = substr($member, $longestPrefixLength);
</ins><span class="cx">
</span><del>- return "${class}::$enum";
</del><ins>+ return "${class}::$member";
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-sub GetEnumerationClassIdentifier
</del><ins>+sub GetEnumerationClassName
</ins><span class="cx"> {
</span><span class="cx"> my ($interface, $name) = @_;
</span><span class="cx">
</span><del>- my $identifier = GetEnumerationClassName($interface, $name);
- $identifier =~ s/:://;
- return $identifier;
</del><ins>+ return GetNestedClassName($interface, $name);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub GetEnumerationValueName
</span><span class="lines">@@ -865,15 +843,20 @@
</span><span class="cx"> {
</span><span class="cx"> my ($interface, $enumerations) = @_;
</span><span class="cx">
</span><ins>+ return "" unless @$enumerations;
+
</ins><span class="cx"> # FIXME: Could optimize this to only generate the parts of each enumeration that are actually
</span><span class="cx"> # used, which would require iterating over everything in the interface.
</span><span class="cx">
</span><span class="cx"> my $result = "";
</span><ins>+
+ $result .= "template<typename T> Optional<T> parse(ExecState&, JSValue);\n";
+ $result .= "template<typename T> const char* expectedEnumerationValues();\n\n";
+
</ins><span class="cx"> foreach my $enumeration (@$enumerations) {
</span><span class="cx"> my $name = $enumeration->name;
</span><span class="cx">
</span><span class="cx"> my $className = GetEnumerationClassName($interface, $name);
</span><del>- my $classIdentifier = GetEnumerationClassIdentifier($interface, $name);
</del><span class="cx">
</span><span class="cx"> # FIXME: A little ugly to have this be a side effect instead of a return value.
</span><span class="cx"> AddToImplIncludes("<runtime/JSString.h>");
</span><span class="lines">@@ -881,11 +864,9 @@
</span><span class="cx"> my $conditionalString = $codeGenerator->GenerateConditionalString($enumeration);
</span><span class="cx"> $result .= "#if ${conditionalString}\n\n" if $conditionalString;
</span><span class="cx">
</span><del>- # Declare these instead of using "static" because these may be unused and we don't
- # want to get warnings about them.
</del><ins>+ # Declare this instead of using "static" because it may be unused and we don't
+ # want to get warnings about it.
</ins><span class="cx"> $result .= "JSString* jsStringWithCache(ExecState*, $className);\n";
</span><del>- $result .= "Optional<$className> parse$classIdentifier(ExecState&, JSValue);\n";
- $result .= "extern const char expectedEnumerationValues${classIdentifier}[];\n\n";
</del><span class="cx">
</span><span class="cx"> # Take an ExecState* instead of an ExecState& to match the jsStringWithCache from JSString.h.
</span><span class="cx"> # FIXME: Change to take VM& instead of ExecState*.
</span><span class="lines">@@ -919,7 +900,7 @@
</span><span class="cx"> # FIXME: Change to take VM& instead of ExecState&.
</span><span class="cx"> # FIXME: Consider using toStringOrNull to make exception checking faster.
</span><span class="cx"> # FIXME: Consider finding a more efficient way to match against all the strings quickly.
</span><del>- $result .= "Optional<$className> parse$classIdentifier(ExecState& state, JSValue value)\n";
</del><ins>+ $result .= "template<> Optional<$className> parse<$className>(ExecState& state, JSValue value)\n";
</ins><span class="cx"> $result .= "{\n";
</span><span class="cx"> $result .= " auto stringValue = value.toWTFString(&state);\n";
</span><span class="cx"> foreach my $value (@{$enumeration->values}) {
</span><span class="lines">@@ -934,13 +915,68 @@
</span><span class="cx"> $result .= " return Nullopt;\n";
</span><span class="cx"> $result .= "}\n\n";
</span><span class="cx">
</span><del>- $result .= "const char expectedEnumerationValues${classIdentifier}[] = \"\\\"" . join ("\\\", \\\"", @{$enumeration->values}) . "\\\"\";\n\n";
</del><ins>+ # FIXME: A little ugly to have this be a side effect instead of a return value.
+ AddToImplIncludes("JSDOMBuild.h");
</ins><span class="cx">
</span><ins>+ $result .= "template<> $className build<$className>(ExecState& state, JSValue value)\n";
+ $result .= "{\n";
+ $result .= " auto result = parse<$className>(state, value);\n";
+ $result .= " if (UNLIKELY(!result)) {\n";
+ $result .= " throwTypeError(&state);\n";
+ $result .= " return { };\n";
+ $result .= " }\n";
+ $result .= " return result.value();\n";
+ $result .= "}\n\n";
+
+ $result .= "template<> inline const char* expectedEnumerationValues<$className>()\n";
+ $result .= "{\n";
+ $result .= " return \"\\\"" . join ("\\\", \\\"", @{$enumeration->values}) . "\\\"\";\n";
+ $result .= "}\n\n";
+
</ins><span class="cx"> $result .= "#endif\n\n" if $conditionalString;
</span><span class="cx"> }
</span><span class="cx"> return $result;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+sub GetDictionaryClassName
+{
+ my ($interface, $name) = @_;
+
+ return GetNestedClassName($interface, $name);
+}
+
+sub GenerateDictionaryImplementationContent
+{
+ my ($interface, $dictionaries) = @_;
+
+ my $result = "";
+ foreach my $dictionary (@$dictionaries) {
+ my $name = $dictionary->name;
+
+ my $conditionalString = $codeGenerator->GenerateConditionalString($dictionary);
+ $result .= "#if ${conditionalString}\n\n" if $conditionalString;
+
+ my $className = GetDictionaryClassName($interface, $name);
+
+ # FIXME: A little ugly to have this be a side effect instead of a return value.
+ AddToImplIncludes("JSDOMBuild.h");
+
+ $result .= "template<> $className build<$className>(ExecState& state, JSValue value)\n";
+ $result .= "{\n";
+ $result .= " return { \n";
+
+ foreach my $member (@{$dictionary->members}) {
+ $result .= " build<" . GetNativeTypeFromSignature($interface, $member) . ">(state, value, \"" . $member->name . "\"),\n";
+ }
+
+ $result .= " };\n";
+ $result .= "}\n\n";
+
+ $result .= "#endif\n\n" if $conditionalString;
+ }
+ return $result;
+}
+
</ins><span class="cx"> sub GenerateHeader
</span><span class="cx"> {
</span><span class="cx"> my ($object, $interface) = @_;
</span><span class="lines">@@ -1899,7 +1935,7 @@
</span><span class="cx">
</span><span class="cx"> sub GenerateImplementation
</span><span class="cx"> {
</span><del>- my ($object, $interface, $enumerations) = @_;
</del><ins>+ my ($object, $interface, $enumerations, $dictionaries) = @_;
</ins><span class="cx">
</span><span class="cx"> my $interfaceName = $interface->name;
</span><span class="cx"> my $className = "JS$interfaceName";
</span><span class="lines">@@ -1932,6 +1968,7 @@
</span><span class="cx"> push(@implContent, "namespace WebCore {\n\n");
</span><span class="cx">
</span><span class="cx"> push(@implContent, GenerateEnumerationImplementationContent($interface, $enumerations));
</span><ins>+ push(@implContent, GenerateDictionaryImplementationContent($interface, $dictionaries));
</ins><span class="cx">
</span><span class="cx"> my @functions = @{$interface->functions};
</span><span class="cx"> push(@functions, @{$interface->iterable->functions}) if $interface->iterable;
</span><span class="lines">@@ -2528,14 +2565,14 @@
</span><span class="cx"> push(@implContent, " JSGlobalObject* globalObject = state->lexicalGlobalObject();\n");
</span><span class="cx"> push(@implContent, " InputCursor& cursor = globalObject->inputCursor();\n");
</span><span class="cx">
</span><del>- my $nativeType = GetNativeType($type);
- my $memoizedType = GetNativeTypeForMemoization($type);
</del><ins>+ my $nativeType = GetNativeType($interface, $type);
+ my $memoizedType = GetNativeTypeForMemoization($interface, $type);
</ins><span class="cx"> my $exceptionCode = $getterExceptionsWithMessage ? "ec.code" : ($getterExceptions ? "ec" : "0");
</span><span class="cx"> push(@implContent, " static NeverDestroyed<const AtomicString> bindingName(\"$interfaceName.$name\", AtomicString::ConstructFromLiteral);\n");
</span><span class="cx"> push(@implContent, " if (cursor.isCapturing()) {\n");
</span><span class="cx"> push(@implContent, " $memoizedType memoizedResult = castedThis->wrapped().$implGetterFunctionName(" . join(", ", @arguments) . ");\n");
</span><span class="cx"> push(@implContent, " cursor.appendInput<MemoizedDOMResult<$memoizedType>>(bindingName.get().string(), memoizedResult, $exceptionCode);\n");
</span><del>- push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interfaceName, "memoizedResult", "castedThis") . ";\n");
</del><ins>+ push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interface, "memoizedResult", "castedThis") . ";\n");
</ins><span class="cx"> push(@implContent, " setDOMException(state, ec);\n") if $getterExceptions;
</span><span class="cx"> push(@implContent, " return JSValue::encode(result);\n");
</span><span class="cx"> push(@implContent, " }\n");
</span><span class="lines">@@ -2545,7 +2582,7 @@
</span><span class="cx"> push(@implContent, " MemoizedDOMResultBase* input = cursor.fetchInput<MemoizedDOMResultBase>();\n");
</span><span class="cx"> push(@implContent, " if (input && input->convertTo<$memoizedType>(memoizedResult)) {\n");
</span><span class="cx"> # FIXME: the generated code should report an error if an input cannot be fetched or converted.
</span><del>- push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interfaceName, "memoizedResult", "castedThis") . ";\n");
</del><ins>+ push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interface, "memoizedResult", "castedThis") . ";\n");
</ins><span class="cx"> push(@implContent, " setDOMException(state, input->exceptionCode());\n") if $getterExceptions;
</span><span class="cx"> push(@implContent, " return JSValue::encode(result);\n");
</span><span class="cx"> push(@implContent, " }\n");
</span><span class="lines">@@ -2558,7 +2595,7 @@
</span><span class="cx"> } elsif ($attribute->signature->extendedAttributes->{"CheckSecurityForNode"}) {
</span><span class="cx"> $implIncludes{"JSDOMBinding.h"} = 1;
</span><span class="cx"> push(@implContent, " auto& impl = castedThis->wrapped();\n");
</span><del>- push(@implContent, " return JSValue::encode(shouldAllowAccessToNode(state, impl." . $attribute->signature->name . "()) ? " . NativeToJSValue($attribute->signature, 0, $interfaceName, "impl.$implGetterFunctionName()", "castedThis") . " : jsNull());\n");
</del><ins>+ push(@implContent, " return JSValue::encode(shouldAllowAccessToNode(state, impl." . $attribute->signature->name . "()) ? " . NativeToJSValue($attribute->signature, 0, $interface, "impl.$implGetterFunctionName()", "castedThis") . " : jsNull());\n");
</ins><span class="cx"> } elsif ($type eq "EventHandler") {
</span><span class="cx"> my $getter = $attribute->signature->extendedAttributes->{"WindowEventHandler"} ? "windowEventHandlerAttribute"
</span><span class="cx"> : $attribute->signature->extendedAttributes->{"DocumentEventHandler"} ? "documentEventHandlerAttribute"
</span><span class="lines">@@ -2591,13 +2628,13 @@
</span><span class="cx"> my @callWithArgs = GenerateCallWith($attribute->signature->extendedAttributes->{"CallWith"}, \@implContent, "JSValue::encode(jsUndefined())");
</span><span class="cx">
</span><span class="cx"> if ($svgListPropertyType) {
</span><del>- push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interfaceName, "castedThis->wrapped().$implGetterFunctionName(" . (join ", ", @callWithArgs) . ")", "castedThis") . ";\n");
</del><ins>+ push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interface, "castedThis->wrapped().$implGetterFunctionName(" . (join ", ", @callWithArgs) . ")", "castedThis") . ";\n");
</ins><span class="cx"> } elsif ($svgPropertyOrListPropertyType) {
</span><span class="cx"> push(@implContent, " $svgPropertyOrListPropertyType& impl = castedThis->wrapped().propertyReference();\n");
</span><span class="cx"> if ($svgPropertyOrListPropertyType eq "float") { # Special case for JSSVGNumber
</span><del>- push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interfaceName, "impl", "castedThis") . ";\n");
</del><ins>+ push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interface, "impl", "castedThis") . ";\n");
</ins><span class="cx"> } else {
</span><del>- push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interfaceName, "impl.$implGetterFunctionName(" . (join ", ", @callWithArgs) . ")", "castedThis") . ";\n");
</del><ins>+ push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interface, "impl.$implGetterFunctionName(" . (join ", ", @callWithArgs) . ")", "castedThis") . ";\n");
</ins><span class="cx">
</span><span class="cx"> }
</span><span class="cx"> } else {
</span><span class="lines">@@ -2614,7 +2651,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> unshift(@arguments, @callWithArgs);
</span><del>- my $jsType = NativeToJSValue($attribute->signature, 0, $interfaceName, "${functionName}(" . join(", ", @arguments) . ")", "castedThis");
</del><ins>+ my $jsType = NativeToJSValue($attribute->signature, 0, $interface, "${functionName}(" . join(", ", @arguments) . ")", "castedThis");
</ins><span class="cx"> push(@implContent, " auto& impl = castedThis->wrapped();\n") if !$attribute->isStatic;
</span><span class="cx"> if ($codeGenerator->IsSVGAnimatedType($type)) {
</span><span class="cx"> push(@implContent, " RefPtr<$type> obj = $jsType;\n");
</span><span class="lines">@@ -2632,10 +2669,10 @@
</span><span class="cx">
</span><span class="cx"> if ($svgPropertyOrListPropertyType) {
</span><span class="cx"> push(@implContent, " $svgPropertyOrListPropertyType impl(*castedThis->wrapped());\n");
</span><del>- push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interfaceName, "impl.$implGetterFunctionName(" . join(", ", @arguments) . ")", "castedThis") . ";\n");
</del><ins>+ push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interface, "impl.$implGetterFunctionName(" . join(", ", @arguments) . ")", "castedThis") . ";\n");
</ins><span class="cx"> } else {
</span><span class="cx"> push(@implContent, " auto& impl = castedThis->wrapped();\n");
</span><del>- push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interfaceName, "impl.$implGetterFunctionName(" . join(", ", @arguments) . ")", "castedThis") . ";\n");
</del><ins>+ push(@implContent, " JSValue result = " . NativeToJSValue($attribute->signature, 0, $interface, "impl.$implGetterFunctionName(" . join(", ", @arguments) . ")", "castedThis") . ";\n");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> push(@implContent, " setDOMException(state, ec);\n");
</span><span class="lines">@@ -2858,7 +2895,7 @@
</span><span class="cx"> my ($nativeValue, $mayThrowException) = JSValueToNative($interface, $attribute->signature, "value", $attribute->signature->extendedAttributes->{"Conditional"});
</span><span class="cx"> if ($codeGenerator->IsWrapperType($type) && $attribute->signature->extendedAttributes->{"StrictTypeChecking"} && $attribute->signature->isNullable) {
</span><span class="cx"> $implIncludes{"<runtime/Error.h>"} = 1;
</span><del>- push(@implContent, " " . GetNativeTypeFromSignature($attribute->signature) . " nativeValue = nullptr;\n");
</del><ins>+ push(@implContent, " " . GetNativeTypeFromSignature($interface, $attribute->signature) . " nativeValue = nullptr;\n");
</ins><span class="cx"> push(@implContent, " if (!value.isUndefinedOrNull()) {\n");
</span><span class="cx"> push(@implContent, " nativeValue = $nativeValue;\n");
</span><span class="cx"> if ($mayThrowException) {
</span><span class="lines">@@ -2871,7 +2908,7 @@
</span><span class="cx"> push(@implContent, " }\n");
</span><span class="cx"> push(@implContent, " }\n");
</span><span class="cx"> } else {
</span><del>- push(@implContent, " " . GetNativeTypeFromSignature($attribute->signature) . " nativeValue = $nativeValue;\n");
</del><ins>+ push(@implContent, " auto nativeValue = $nativeValue;\n");
</ins><span class="cx"> if ($mayThrowException) {
</span><span class="cx"> push(@implContent, " if (UNLIKELY(state->hadException()))\n");
</span><span class="cx"> push(@implContent, " return false;\n");
</span><span class="lines">@@ -2934,7 +2971,7 @@
</span><span class="cx"> } elsif ($codeGenerator->IsEnumType($type)) {
</span><span class="cx"> push(@arguments, "nativeValue.value()");
</span><span class="cx"> } else {
</span><del>- push(@arguments, $shouldPassByReference ? "*nativeValue" : "nativeValue");
</del><ins>+ push(@arguments, $shouldPassByReference ? "*nativeValue" : "WTFMove(nativeValue)");
</ins><span class="cx"> }
</span><span class="cx"> if ($attribute->signature->extendedAttributes->{"ImplementedBy"}) {
</span><span class="cx"> my $implementedBy = $attribute->signature->extendedAttributes->{"ImplementedBy"};
</span><span class="lines">@@ -3083,7 +3120,7 @@
</span><span class="cx">
</span><span class="cx"> my $numParameters = @{$function->parameters};
</span><span class="cx"> my ($functionString, $dummy) = GenerateParametersCheck(\@implContent, $function, $interface, $numParameters, $functionImplementationName, $svgPropertyType, $svgPropertyOrListPropertyType, $svgListPropertyType);
</span><del>- GenerateImplementationFunctionCall($function, $functionString, " ", $svgPropertyType, $interfaceName);
</del><ins>+ GenerateImplementationFunctionCall($function, $functionString, " ", $svgPropertyType, $interface);
</ins><span class="cx"> }
</span><span class="cx"> } else {
</span><span class="cx"> GenerateFunctionCastedThis($interface, $className, $function);
</span><span class="lines">@@ -3137,7 +3174,7 @@
</span><span class="cx">
</span><span class="cx"> my $numParameters = @{$function->parameters};
</span><span class="cx"> my ($functionString, $dummy) = GenerateParametersCheck(\@implContent, $function, $interface, $numParameters, $functionImplementationName, $svgPropertyType, $svgPropertyOrListPropertyType, $svgListPropertyType);
</span><del>- GenerateImplementationFunctionCall($function, $functionString, " ", $svgPropertyType, $interfaceName);
</del><ins>+ GenerateImplementationFunctionCall($function, $functionString, " ", $svgPropertyType, $interface);
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -3629,7 +3666,7 @@
</span><span class="cx"> if ($argType eq "DOMString") {
</span><span class="cx"> $nativeElementType = "String";
</span><span class="cx"> } else {
</span><del>- $nativeElementType = GetNativeType($argType);
</del><ins>+ $nativeElementType = GetNativeType($interface, $argType);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if (!IsNativeType($argType)) {
</span><span class="lines">@@ -3647,7 +3684,6 @@
</span><span class="cx"> }
</span><span class="cx"> } elsif ($codeGenerator->IsEnumType($argType)) {
</span><span class="cx"> my $className = GetEnumerationClassName($interface, $argType);
</span><del>- my $classIdentifier = GetEnumerationClassIdentifier($interface, $argType);
</del><span class="cx">
</span><span class="cx"> $implIncludes{"<runtime/Error.h>"} = 1;
</span><span class="cx">
</span><span class="lines">@@ -3675,11 +3711,11 @@
</span><span class="cx"> $indent = " ";
</span><span class="cx"> }
</span><span class="cx">
</span><del>- push(@$outputArray, "$indent $defineOptionalValue = parse$classIdentifier(*state, ${name}Value);\n");
</del><ins>+ push(@$outputArray, "$indent $defineOptionalValue = parse<$className>(*state, ${name}Value);\n");
</ins><span class="cx"> push(@$outputArray, "$indent if (UNLIKELY(state->hadException()))\n");
</span><span class="cx"> push(@$outputArray, "$indent return JSValue::encode(jsUndefined());\n");
</span><span class="cx"> push(@$outputArray, "$indent if (UNLIKELY(!$optionalValue))\n");
</span><del>- push(@$outputArray, "$indent return throwArgumentMustBeEnumError(*state, $argsIndex, \"$name\", \"$interfaceName\", $quotedFunctionName, expectedEnumerationValues$classIdentifier);\n");
</del><ins>+ push(@$outputArray, "$indent return throwArgumentMustBeEnumError(*state, $argsIndex, \"$name\", \"$interfaceName\", $quotedFunctionName, expectedEnumerationValues<$className>());\n");
</ins><span class="cx"> push(@$outputArray, "$indent $name = optionalValue.value();\n") if $optionalValue ne $name;
</span><span class="cx">
</span><span class="cx"> push(@$outputArray, " }\n") if $indent ne "";
</span><span class="lines">@@ -3709,7 +3745,7 @@
</span><span class="cx"> } else {
</span><span class="cx"> my $outer;
</span><span class="cx"> my $inner;
</span><del>- my $nativeType = GetNativeTypeFromSignature($parameter);
</del><ins>+ my $nativeType = GetNativeTypeFromSignature($interface, $parameter);
</ins><span class="cx">
</span><span class="cx"> if ($optional && defined($parameter->default) && !WillConvertUndefinedToDefaultParameterValue($parameter->type, $parameter->default)) {
</span><span class="cx"> my $defaultValue = $parameter->default;
</span><span class="lines">@@ -3736,16 +3772,15 @@
</span><span class="cx"> } elsif ($optional && !defined($parameter->default)) {
</span><span class="cx"> # Use WTF::Optional<>() for optional parameters that are missing or undefined and that do not have
</span><span class="cx"> # a default value in the IDL.
</span><del>- my $defaultValue = "Optional<$nativeType>()";
- $nativeType = "Optional<$nativeType>";
- $outer = "state->argument($argsIndex).isUndefined() ? $defaultValue : ";
</del><ins>+ $outer = "state->argument($argsIndex).isUndefined() ? Optional<$nativeType>() : ";
</ins><span class="cx"> $inner = "state->uncheckedArgument($argsIndex)";
</span><span class="cx"> } else {
</span><span class="cx"> $outer = "";
</span><span class="cx"> $inner = "state->argument($argsIndex)";
</span><span class="cx"> }
</span><span class="cx"> my ($nativeValue, $mayThrowException) = JSValueToNative($interface, $parameter, $inner, $function->signature->extendedAttributes->{"Conditional"});
</span><del>- push(@$outputArray, " $nativeType $name = ${outer}${nativeValue};\n");
</del><ins>+ push(@$outputArray, " auto $name = ${outer}${nativeValue};\n");
+ $value = "WTFMove($name)";
</ins><span class="cx"> if ($mayThrowException) {
</span><span class="cx"> push(@$outputArray, " if (UNLIKELY(state->hadException()))\n");
</span><span class="cx"> push(@$outputArray, " return JSValue::encode(jsUndefined());\n");
</span><span class="lines">@@ -3844,9 +3879,9 @@
</span><span class="cx"> foreach my $function (@{$interface->functions}) {
</span><span class="cx"> my @arguments = ();
</span><span class="cx"> foreach my $parameter (@{$function->parameters}) {
</span><del>- push(@arguments, GetNativeTypeForCallbacks($parameter->type) . " " . $parameter->name);
</del><ins>+ push(@arguments, GetNativeTypeForCallbacks($interface, $parameter->type) . " " . $parameter->name);
</ins><span class="cx"> }
</span><del>- push(@headerContent, " virtual " . GetNativeTypeForCallbacks($function->signature->type) . " " . $function->signature->name . "(" . join(", ", @arguments) . ");\n");
</del><ins>+ push(@headerContent, " virtual " . GetNativeTypeForCallbacks($interface, $function->signature->type) . " " . $function->signature->name . "(" . join(", ", @arguments) . ");\n");
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3978,20 +4013,20 @@
</span><span class="cx"> push(@implContent, "\n// Functions\n");
</span><span class="cx"> foreach my $function (@{$interface->functions}) {
</span><span class="cx"> my @params = @{$function->parameters};
</span><del>- if ($function->signature->extendedAttributes->{"Custom"} || GetNativeType($function->signature->type) ne "bool") {
</del><ins>+ if ($function->signature->extendedAttributes->{"Custom"} || GetNativeType($interface, $function->signature->type) ne "bool") {
</ins><span class="cx"> next;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> AddIncludesForTypeInImpl($function->signature->type);
</span><span class="cx"> my $functionName = $function->signature->name;
</span><del>- push(@implContent, "\n" . GetNativeTypeForCallbacks($function->signature->type) . " ${className}::${functionName}(");
</del><ins>+ push(@implContent, "\n" . GetNativeTypeForCallbacks($interface, $function->signature->type) . " ${className}::${functionName}(");
</ins><span class="cx">
</span><span class="cx"> my @args = ();
</span><span class="cx"> my @argsCheck = ();
</span><span class="cx"> foreach my $param (@params) {
</span><span class="cx"> my $paramName = $param->name;
</span><span class="cx"> AddIncludesForTypeInImpl($param->type, 1);
</span><del>- push(@args, GetNativeTypeForCallbacks($param->type) . " " . $paramName);
</del><ins>+ push(@args, GetNativeTypeForCallbacks($interface, $param->type) . " " . $paramName);
</ins><span class="cx"> }
</span><span class="cx"> push(@implContent, join(", ", @args));
</span><span class="cx"> push(@implContent, ")\n");
</span><span class="lines">@@ -4007,7 +4042,7 @@
</span><span class="cx">
</span><span class="cx"> foreach my $param (@params) {
</span><span class="cx"> my $paramName = $param->name;
</span><del>- push(@implContent, " args.append(" . NativeToJSValue($param, 1, $interfaceName, $paramName, "m_data") . ");\n");
</del><ins>+ push(@implContent, " args.append(" . NativeToJSValue($param, 1, $interface, $paramName, "m_data") . ");\n");
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> push(@implContent, "\n NakedPtr<Exception> returnedException;\n");
</span><span class="lines">@@ -4056,11 +4091,7 @@
</span><span class="cx">
</span><span class="cx"> sub GenerateImplementationFunctionCall()
</span><span class="cx"> {
</span><del>- my $function = shift;
- my $functionString = shift;
- my $indent = shift;
- my $svgPropertyType = shift;
- my $interfaceName = shift;
</del><ins>+ my ($function, $functionString, $indent, $svgPropertyType, $interface) = @_;
</ins><span class="cx">
</span><span class="cx"> my $nondeterministic = $function->signature->extendedAttributes->{"Nondeterministic"};
</span><span class="cx"> my $raisesExceptionWithMessage = $function->signature->extendedAttributes->{"RaisesExceptionWithMessage"};
</span><span class="lines">@@ -4104,9 +4135,9 @@
</span><span class="cx"> AddToImplIncludes("<replay/InputCursor.h>", "WEB_REPLAY");
</span><span class="cx"> AddToImplIncludes("<wtf/NeverDestroyed.h>", "WEB_REPLAY");
</span><span class="cx">
</span><del>- my $nativeType = GetNativeTypeFromSignature($function->signature);
- my $memoizedType = GetNativeTypeForMemoization($function->signature->type);
- my $bindingName = $interfaceName . "." . $function->signature->name;
</del><ins>+ my $nativeType = GetNativeTypeFromSignature($interface, $function->signature);
+ my $memoizedType = GetNativeTypeForMemoization($interface, $function->signature->type);
+ my $bindingName = $interface->name . "." . $function->signature->name;
</ins><span class="cx"> push(@implContent, $indent . "JSValue result;\n");
</span><span class="cx"> push(@implContent, "#if ENABLE(WEB_REPLAY)\n");
</span><span class="cx"> push(@implContent, $indent . "InputCursor& cursor = state->lexicalGlobalObject()->inputCursor();\n");
</span><span class="lines">@@ -4115,24 +4146,24 @@
</span><span class="cx"> push(@implContent, $indent . " $nativeType memoizedResult = $functionString;\n");
</span><span class="cx"> my $exceptionCode = $raisesExceptionWithMessage ? "ec.code" : ($raisesException ? "ec" : "0");
</span><span class="cx"> push(@implContent, $indent . " cursor.appendInput<MemoizedDOMResult<$memoizedType>>(bindingName.get().string(), memoizedResult, $exceptionCode);\n");
</span><del>- push(@implContent, $indent . " result = " . NativeToJSValue($function->signature, 1, $interfaceName, "memoizedResult", $thisObject) . ";\n");
</del><ins>+ push(@implContent, $indent . " result = " . NativeToJSValue($function->signature, 1, $interface, "memoizedResult", $thisObject) . ";\n");
</ins><span class="cx"> push(@implContent, $indent . "} else if (cursor.isReplaying()) {\n");
</span><span class="cx"> push(@implContent, $indent . " MemoizedDOMResultBase* input = cursor.fetchInput<MemoizedDOMResultBase>();\n");
</span><span class="cx"> push(@implContent, $indent . " $memoizedType memoizedResult;\n");
</span><span class="cx"> # FIXME: the generated code should report an error if an input cannot be fetched or converted.
</span><span class="cx"> push(@implContent, $indent . " if (input && input->convertTo<$memoizedType>(memoizedResult)) {\n");
</span><del>- push(@implContent, $indent . " result = " . NativeToJSValue($function->signature, 1, $interfaceName, "memoizedResult", $thisObject) . ";\n");
</del><ins>+ push(@implContent, $indent . " result = " . NativeToJSValue($function->signature, 1, $interface, "memoizedResult", $thisObject) . ";\n");
</ins><span class="cx"> push(@implContent, $indent . " ec.code = input->exceptionCode();\n") if $raisesExceptionWithMessage;
</span><span class="cx"> push(@implContent, $indent . " ec = input->exceptionCode();\n") if $raisesException && !$raisesExceptionWithMessage;
</span><span class="cx"> push(@implContent, $indent . " } else\n");
</span><del>- push(@implContent, $indent . " result = " . NativeToJSValue($function->signature, 1, $interfaceName, $functionString, $thisObject) . ";\n");
</del><ins>+ push(@implContent, $indent . " result = " . NativeToJSValue($function->signature, 1, $interface, $functionString, $thisObject) . ";\n");
</ins><span class="cx"> push(@implContent, $indent . "} else\n");
</span><del>- push(@implContent, $indent . " result = " . NativeToJSValue($function->signature, 1, $interfaceName, $functionString, $thisObject) . ";\n");
</del><ins>+ push(@implContent, $indent . " result = " . NativeToJSValue($function->signature, 1, $interface, $functionString, $thisObject) . ";\n");
</ins><span class="cx"> push(@implContent, "#else\n");
</span><del>- push(@implContent, $indent . "result = " . NativeToJSValue($function->signature, 1, $interfaceName, $functionString, $thisObject) . ";\n");
</del><ins>+ push(@implContent, $indent . "result = " . NativeToJSValue($function->signature, 1, $interface, $functionString, $thisObject) . ";\n");
</ins><span class="cx"> push(@implContent, "#endif\n");
</span><span class="cx"> } else {
</span><del>- push(@implContent, $indent . "JSValue result = " . NativeToJSValue($function->signature, 1, $interfaceName, $functionString, $thisObject) . ";\n");
</del><ins>+ push(@implContent, $indent . "JSValue result = " . NativeToJSValue($function->signature, 1, $interface, $functionString, $thisObject) . ";\n");
</ins><span class="cx"> }
</span><span class="cx"> push(@implContent, "\n" . $indent . "setDOMException(state, ec);\n") if $raisesException;
</span><span class="cx">
</span><span class="lines">@@ -4200,14 +4231,14 @@
</span><span class="cx">
</span><span class="cx"> sub GetNativeTypeFromSignature
</span><span class="cx"> {
</span><del>- my $signature = shift;
- my $type = $signature->type;
</del><ins>+ my ($interface, $signature) = @_;
</ins><span class="cx">
</span><del>- return GetNativeType($type);
</del><ins>+ return GetNativeType($interface, $signature->type);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> my %nativeType = (
</span><span class="cx"> "DOMString" => "String",
</span><ins>+ "DOMStringList" => "RefPtr<DOMStringList>",
</ins><span class="cx"> "DOMTimeStamp" => "DOMTimeStamp",
</span><span class="cx"> "Date" => "double",
</span><span class="cx"> "Dictionary" => "Dictionary",
</span><span class="lines">@@ -4231,22 +4262,20 @@
</span><span class="cx">
</span><span class="cx"> sub GetNativeType
</span><span class="cx"> {
</span><del>- my $type = shift;
</del><ins>+ my ($interface, $type) = @_;
</ins><span class="cx">
</span><del>- # FIXME: Maybe we can start using "auto" for most of these?
-
- my $svgNativeType = $codeGenerator->GetSVGTypeNeedingTearOff($type);
- return "${svgNativeType}*" if $svgNativeType;
- return "RefPtr<DOMStringList>" if $type eq "DOMStringList";
- return "RefPtr<${type}>" if $codeGenerator->IsTypedArrayType($type) and not $type eq "ArrayBuffer";
</del><span class="cx"> return $nativeType{$type} if exists $nativeType{$type};
</span><span class="cx">
</span><ins>+ return GetEnumerationClassName($interface, $type) if $codeGenerator->IsEnumType($type);
+
+ my $tearOffType = $codeGenerator->GetSVGTypeNeedingTearOff($type);
+ return "${tearOffType}*" if $tearOffType;
+
+ return "RefPtr<${type}>" if $codeGenerator->IsTypedArrayType($type) and $type ne "ArrayBuffer";
+
</ins><span class="cx"> my $arrayOrSequenceType = $codeGenerator->GetArrayOrSequenceType($type);
</span><del>-
</del><span class="cx"> return "Vector<" . GetNativeVectorInnerType($arrayOrSequenceType) . ">" if $arrayOrSequenceType;
</span><del>- return "auto" if $codeGenerator->IsEnumType($type);
</del><span class="cx">
</span><del>- # For all other types, the native type is a pointer with same type name as the IDL type.
</del><span class="cx"> return "${type}*";
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4255,8 +4284,7 @@
</span><span class="cx"> my $parameter = shift;
</span><span class="cx"> my $interface = shift;
</span><span class="cx">
</span><del>- my $nativeType = GetNativeType($parameter->type);
-
</del><ins>+ my $nativeType = GetNativeType($interface, $parameter->type);
</ins><span class="cx"> return $codeGenerator->ShouldPassWrapperByReference($parameter, $interface) && (substr($nativeType, -1) eq '*' || $nativeType =~ /^RefPtr/);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4264,27 +4292,25 @@
</span><span class="cx"> {
</span><span class="cx"> my $arrayOrSequenceType = shift;
</span><span class="cx">
</span><del>- return "String" if $arrayOrSequenceType eq "DOMString";
</del><span class="cx"> return $nativeType{$arrayOrSequenceType} if exists $nativeType{$arrayOrSequenceType};
</span><span class="cx"> return "RefPtr<${arrayOrSequenceType}>";
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub GetNativeTypeForCallbacks
</span><span class="cx"> {
</span><del>- my $type = shift;
</del><ins>+ my ($interface, $type) = @_;
+
</ins><span class="cx"> return "PassRefPtr<SerializedScriptValue>" if $type eq "SerializedScriptValue";
</span><span class="cx"> return "PassRefPtr<DOMStringList>" if $type eq "DOMStringList";
</span><span class="cx"> return "const String&" if $type eq "DOMString";
</span><del>-
- return GetNativeType($type);
</del><ins>+ return GetNativeType($interface, $type);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub GetNativeTypeForMemoization
</span><span class="cx"> {
</span><del>- my $type = shift;
- return "String" if $type eq "DOMString";
</del><ins>+ my ($interface, $type) = @_;
</ins><span class="cx">
</span><del>- return GetNativeType($type);
</del><ins>+ return GetNativeType($interface, $type);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub GetSVGPropertyTypes
</span><span class="lines">@@ -4373,7 +4399,7 @@
</span><span class="cx">
</span><span class="cx"> if ($type eq "Dictionary") {
</span><span class="cx"> AddToImplIncludes("Dictionary.h", $conditional);
</span><del>- return ("{ state, $value }", 0);
</del><ins>+ return ("Dictionary(state, $value)", 0);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> my $arrayOrSequenceType = $codeGenerator->GetArrayOrSequenceType($type);
</span><span class="lines">@@ -4393,7 +4419,8 @@
</span><span class="cx"> return ("valueToDate(state, $value)", 1) if $type eq "Date";
</span><span class="cx">
</span><span class="cx"> return ("to$type($value)", 1) if $codeGenerator->IsTypedArrayType($type);
</span><del>- return ("parse" . GetEnumerationClassIdentifier($interface, $type) . "(*state, $value)", 1) if $codeGenerator->IsEnumType($type);
</del><ins>+ return ("parse<" . GetEnumerationClassName($interface, $type) . ">(*state, $value)", 1) if $codeGenerator->IsEnumType($type);
+ return ("build<" . GetDictionaryClassName($interface, $type) . ">(*state, $value)", 1) if $codeGenerator->IsDictionaryType($type);
</ins><span class="cx">
</span><span class="cx"> AddToImplIncludes("JS$type.h", $conditional);
</span><span class="cx">
</span><span class="lines">@@ -4405,11 +4432,7 @@
</span><span class="cx">
</span><span class="cx"> sub NativeToJSValue
</span><span class="cx"> {
</span><del>- my $signature = shift;
- my $inFunctionCall = shift;
- my $interfaceName = shift;
- my $value = shift;
- my $thisValue = shift;
</del><ins>+ my ($signature, $inFunctionCall, $interface, $value, $thisValue) = @_;
</ins><span class="cx">
</span><span class="cx"> my $conditional = $signature->extendedAttributes->{"Conditional"};
</span><span class="cx"> my $type = $signature->type;
</span><span class="lines">@@ -4481,28 +4504,29 @@
</span><span class="cx">
</span><span class="cx"> return $value if $codeGenerator->IsSVGAnimatedType($type);
</span><span class="cx">
</span><del>- if ($codeGenerator->IsSVGAnimatedType($interfaceName) or ($interfaceName eq "SVGViewSpec" and $type eq "SVGTransformList")) {
</del><ins>+ if ($codeGenerator->IsSVGAnimatedType($interface->name) or ($interface->name eq "SVGViewSpec" and $type eq "SVGTransformList")) {
</ins><span class="cx"> # Convert from abstract RefPtr<ListProperty> to real type, so the right toJS() method can be invoked.
</span><del>- $value = "static_cast<" . GetNativeType($type) . ">($value.get())";
- } elsif ($interfaceName eq "SVGViewSpec") {
</del><ins>+ $value = "static_cast<" . GetNativeType($interface, $type) . ">($value.get())";
+ } elsif ($interface->name eq "SVGViewSpec") {
</ins><span class="cx"> # Convert from abstract SVGProperty to real type, so the right toJS() method can be invoked.
</span><del>- $value = "static_cast<" . GetNativeType($type) . ">($value)";
- } elsif ($codeGenerator->IsSVGTypeNeedingTearOff($type) and not $interfaceName =~ /List$/) {
</del><ins>+ $value = "static_cast<" . GetNativeType($interface, $type) . ">($value)";
+ } elsif ($codeGenerator->IsSVGTypeNeedingTearOff($type) and not $interface->name =~ /List$/) {
</ins><span class="cx"> my $tearOffType = $codeGenerator->GetSVGTypeNeedingTearOff($type);
</span><span class="cx"> if ($codeGenerator->IsSVGTypeWithWritablePropertiesNeedingTearOff($type) and !$inFunctionCall and not defined $signature->extendedAttributes->{"Immutable"}) {
</span><span class="cx"> my $getter = $value;
</span><span class="cx"> $getter =~ s/impl\.//;
</span><span class="cx"> $getter =~ s/impl->//;
</span><span class="cx"> $getter =~ s/\(\)//;
</span><del>- my $updateMethod = "&${interfaceName}::update" . $codeGenerator->WK_ucfirst($getter);
</del><ins>+ my $updateMethod = "&" . $interface->name . "::update" . $codeGenerator->WK_ucfirst($getter);
</ins><span class="cx">
</span><del>- my $selfIsTearOffType = $codeGenerator->IsSVGTypeNeedingTearOff($interfaceName);
</del><ins>+ my $selfIsTearOffType = $codeGenerator->IsSVGTypeNeedingTearOff($interface->name);
</ins><span class="cx"> if ($selfIsTearOffType) {
</span><span class="cx"> # FIXME: Why SVGMatrix specifically?
</span><span class="cx"> AddToImplIncludes("SVGMatrixTearOff.h", $conditional);
</span><span class="cx"> $value = "SVGMatrixTearOff::create(castedThis->wrapped(), $value)";
</span><span class="cx"> } else {
</span><span class="cx"> AddToImplIncludes("SVGStaticPropertyTearOff.h", $conditional);
</span><ins>+ my $interfaceName = $interface->name;
</ins><span class="cx"> $tearOffType =~ s/SVGPropertyTearOff</SVGStaticPropertyTearOff<$interfaceName, /;
</span><span class="cx"> $value = "${tearOffType}::create(impl, $value, $updateMethod)";
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptsIDLParserpm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/IDLParser.pm (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -35,9 +35,10 @@
</span><span class="cx">
</span><span class="cx"> # Used to represent a parsed IDL document
</span><span class="cx"> struct( idlDocument => {
</span><del>- interfaces => '@', # All parsed interfaces
- enumerations => '@', # All parsed enumerations
- fileName => '$', # file name
</del><ins>+ interfaces => '@', # List of 'domInterface'
+ enumerations => '@', # List of 'domEnum'
+ dictionaries => '@', # List of 'domDictionary'
+ fileName => '$',
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> # Used to represent 'interface' blocks
</span><span class="lines">@@ -110,6 +111,12 @@
</span><span class="cx"> extendedAttributes => '$',
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+struct( domDictionary => {
+ name => '$',
+ members => '@', # List of 'domSignature'
+ extendedAttributes => '$',
+});
+
</ins><span class="cx"> struct( Token => {
</span><span class="cx"> type => '$', # type of token
</span><span class="cx"> value => '$' # value of token
</span><span class="lines">@@ -217,6 +224,8 @@
</span><span class="cx"> push(@{$document->interfaces}, $definition);
</span><span class="cx"> } elsif (ref($definition) eq "domEnum") {
</span><span class="cx"> push(@{$document->enumerations}, $definition);
</span><ins>+ } elsif (ref($definition) eq "domDictionary") {
+ push(@{$document->dictionaries}, $definition);
</ins><span class="cx"> } else {
</span><span class="cx"> die "Unrecognized IDL definition kind: \"" . ref($definition) . "\"";
</span><span class="cx"> }
</span><span class="lines">@@ -623,14 +632,18 @@
</span><span class="cx">
</span><span class="cx"> my $next = $self->nextToken();
</span><span class="cx"> if ($next->value() eq "dictionary") {
</span><ins>+ my $dictionary = domDictionary->new();
+ $dictionary->extendedAttributes($extendedAttributeList);
</ins><span class="cx"> $self->assertTokenValue($self->getToken(), "dictionary", __LINE__);
</span><del>- $self->assertTokenType($self->getToken(), IdentifierToken);
</del><ins>+ my $nameToken = $self->getToken();
+ $self->assertTokenType($nameToken, IdentifierToken);
+ $dictionary->name($nameToken->value());
</ins><span class="cx"> $self->parseInheritance();
</span><span class="cx"> $self->assertTokenValue($self->getToken(), "{", __LINE__);
</span><del>- $self->parseDictionaryMembers();
</del><ins>+ $dictionary->members($self->parseDictionaryMembers());
</ins><span class="cx"> $self->assertTokenValue($self->getToken(), "}", __LINE__);
</span><span class="cx"> $self->assertTokenValue($self->getToken(), ";", __LINE__);
</span><del>- return;
</del><ins>+ return $dictionary;
</ins><span class="cx"> }
</span><span class="cx"> $self->assertUnexpectedToken($next->value(), __LINE__);
</span><span class="cx"> }
</span><span class="lines">@@ -639,15 +652,19 @@
</span><span class="cx"> {
</span><span class="cx"> my $self = shift;
</span><span class="cx">
</span><ins>+ my @members = ();
+
</ins><span class="cx"> while (1) {
</span><span class="cx"> my $extendedAttributeList = $self->parseExtendedAttributeListAllowEmpty();
</span><span class="cx"> my $next = $self->nextToken();
</span><span class="cx"> if ($next->type() == IdentifierToken || $next->value() =~ /$nextExceptionField_1/) {
</span><del>- $self->parseDictionaryMember($extendedAttributeList);
</del><ins>+ push(@members, $self->parseDictionaryMember($extendedAttributeList));
</ins><span class="cx"> } else {
</span><span class="cx"> last;
</span><span class="cx"> }
</span><span class="cx"> }
</span><ins>+
+ return \@members;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> sub parseDictionaryMember
</span><span class="lines">@@ -657,11 +674,20 @@
</span><span class="cx">
</span><span class="cx"> my $next = $self->nextToken();
</span><span class="cx"> if ($next->type() == IdentifierToken || $next->value() =~ /$nextExceptionField_1/) {
</span><del>- $self->parseType();
- $self->assertTokenType($self->getToken(), IdentifierToken);
- $self->parseDefault();
</del><ins>+ my $member = domSignature->new();
+ if ($next->value ne "required") {
+ $member->isOptional(1);
+ } else {
+ $self->assertTokenValue($self->getToken(), "required", __LINE__);
+ $member->isOptional(0);
+ }
+ $member->type($self->parseType());
+ my $nameToken = $self->getToken();
+ $self->assertTokenType($nameToken, IdentifierToken);
+ $member->name($nameToken->value);
+ $member->default($self->parseDefault());
</ins><span class="cx"> $self->assertTokenValue($self->getToken(), ";", __LINE__);
</span><del>- return;
</del><ins>+ return $member;
</ins><span class="cx"> }
</span><span class="cx"> $self->assertUnexpectedToken($next->value(), __LINE__);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -34,10 +34,10 @@
</span><span class="cx"> #include "WebKitDOMNodePrivate.h"
</span><span class="cx"> #include "WebKitDOMPrivate.h"
</span><span class="cx"> #include "WebKitDOMSVGPointPrivate.h"
</span><ins>+#include "WebKitDOMShadowRootInitPrivate.h"
</ins><span class="cx"> #include "WebKitDOMTestEnumTypePrivate.h"
</span><span class="cx"> #include "WebKitDOMTestNodePrivate.h"
</span><span class="cx"> #include "WebKitDOMTestObjPrivate.h"
</span><del>-#include "WebKitDOMboolPrivate.h"
</del><span class="cx"> #include "gobject/ConvertToUTF8String.h"
</span><span class="cx"> #include <wtf/GetPtr.h>
</span><span class="cx"> #include <wtf/RefPtr.h>
</span><span class="lines">@@ -1925,40 +1925,40 @@
</span><span class="cx"> item->banana();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-WebKitDOMbool* webkit_dom_test_obj_strict_function(WebKitDOMTestObj* self, const gchar* str, gfloat a, glong b, GError** error)
</del><ins>+gboolean webkit_dom_test_obj_strict_function(WebKitDOMTestObj* self, const gchar* str, gfloat a, glong b, GError** error)
</ins><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(self), 0);
- g_return_val_if_fail(str, 0);
- g_return_val_if_fail(!error || !*error, 0);
</del><ins>+ g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(self), FALSE);
+ g_return_val_if_fail(str, FALSE);
+ g_return_val_if_fail(!error || !*error, FALSE);
</ins><span class="cx"> WebCore::TestObj* item = WebKit::core(self);
</span><span class="cx"> WTF::String convertedStr = WTF::String::fromUTF8(str);
</span><span class="cx"> WebCore::ExceptionCode ec = 0;
</span><del>- RefPtr<WebCore::bool> gobjectResult = WTF::getPtr(item->strictFunction(convertedStr, a, b, ec));
</del><ins>+ gboolean result = item->strictFunction(convertedStr, a, b, ec);
</ins><span class="cx"> if (ec) {
</span><span class="cx"> WebCore::ExceptionCodeDescription ecdesc(ec);
</span><span class="cx"> g_set_error_literal(error, g_quark_from_string("WEBKIT_DOM"), ecdesc.code, ecdesc.name);
</span><span class="cx"> }
</span><del>- return WebKit::kit(gobjectResult.get());
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-WebKitDOMbool* webkit_dom_test_obj_strict_function_with_array(WebKitDOMTestObj* self, WebKitDOMTestObj* objArg, glong array, GError** error)
</del><ins>+gboolean webkit_dom_test_obj_strict_function_with_array(WebKitDOMTestObj* self, WebKitDOMTestObj* objArg, glong array, GError** error)
</ins><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><del>- g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(self), 0);
- g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(objArg), 0);
- g_return_val_if_fail(WEBKIT_DOM_IS_LONG[](array), 0);
- g_return_val_if_fail(!error || !*error, 0);
</del><ins>+ g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(self), FALSE);
+ g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(objArg), FALSE);
+ g_return_val_if_fail(WEBKIT_DOM_IS_LONG[](array), FALSE);
+ g_return_val_if_fail(!error || !*error, FALSE);
</ins><span class="cx"> WebCore::TestObj* item = WebKit::core(self);
</span><span class="cx"> WebCore::TestObj* convertedObjArg = WebKit::core(objArg);
</span><span class="cx"> WebCore::long[]* convertedArray = WebKit::core(array);
</span><span class="cx"> WebCore::ExceptionCode ec = 0;
</span><del>- RefPtr<WebCore::bool> gobjectResult = WTF::getPtr(item->strictFunctionWithArray(*convertedObjArg, array, ec));
</del><ins>+ gboolean result = item->strictFunctionWithArray(*convertedObjArg, array, ec);
</ins><span class="cx"> if (ec) {
</span><span class="cx"> WebCore::ExceptionCodeDescription ecdesc(ec);
</span><span class="cx"> g_set_error_literal(error, g_quark_from_string("WEBKIT_DOM"), ecdesc.code, ecdesc.name);
</span><span class="cx"> }
</span><del>- return WebKit::kit(gobjectResult.get());
</del><ins>+ return result;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void webkit_dom_test_obj_variadic_string_method(WebKitDOMTestObj* self, const gchar* head, const gchar* tail)
</span><span class="lines">@@ -2001,6 +2001,16 @@
</span><span class="cx"> item->any(a, b);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+void webkit_dom_test_obj_attach_shadow_root(WebKitDOMTestObj* self, WebKitDOMShadowRootInit* init)
+{
+ WebCore::JSMainThreadNullState state;
+ g_return_if_fail(WEBKIT_DOM_IS_TEST_OBJ(self));
+ g_return_if_fail(WEBKIT_DOM_IS_SHADOW_ROOT_INIT(init));
+ WebCore::TestObj* item = WebKit::core(self);
+ WebCore::ShadowRootInit* convertedInit = WebKit::core(init);
+ item->attachShadowRoot(convertedInit);
+}
+
</ins><span class="cx"> glong webkit_dom_test_obj_get_read_only_long_attr(WebKitDOMTestObj* self)
</span><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestGObjectWebKitDOMTestObjh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -847,11 +847,11 @@
</span><span class="cx"> * @b: A #glong
</span><span class="cx"> * @error: #GError
</span><span class="cx"> *
</span><del>- * Returns: (transfer none): A #WebKitDOMbool
</del><ins>+ * Returns: A #gboolean
</ins><span class="cx"> *
</span><span class="cx"> * Stability: Unstable
</span><span class="cx"> **/
</span><del>-WEBKIT_API WebKitDOMbool*
</del><ins>+WEBKIT_API gboolean
</ins><span class="cx"> webkit_dom_test_obj_strict_function(WebKitDOMTestObj* self, const gchar* str, gfloat a, glong b, GError** error);
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -861,11 +861,11 @@
</span><span class="cx"> * @array: A #glong
</span><span class="cx"> * @error: #GError
</span><span class="cx"> *
</span><del>- * Returns: (transfer none): A #WebKitDOMbool
</del><ins>+ * Returns: A #gboolean
</ins><span class="cx"> *
</span><span class="cx"> * Stability: Unstable
</span><span class="cx"> **/
</span><del>-WEBKIT_API WebKitDOMbool*
</del><ins>+WEBKIT_API gboolean
</ins><span class="cx"> webkit_dom_test_obj_strict_function_with_array(WebKitDOMTestObj* self, WebKitDOMTestObj* objArg, glong array, GError** error);
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -913,6 +913,16 @@
</span><span class="cx"> webkit_dom_test_obj_any(WebKitDOMTestObj* self, gfloat a, glong b);
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * webkit_dom_test_obj_attach_shadow_root:
+ * @self: A #WebKitDOMTestObj
+ * @init: A #WebKitDOMShadowRootInit
+ *
+ * Stability: Unstable
+**/
+WEBKIT_API void
+webkit_dom_test_obj_attach_shadow_root(WebKitDOMTestObj* self, WebKitDOMShadowRootInit* init);
+
+/**
</ins><span class="cx"> * webkit_dom_test_obj_get_read_only_long_attr:
</span><span class="cx"> * @self: A #WebKitDOMTestObj
</span><span class="cx"> *
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestActiveDOMObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -203,7 +203,7 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Node* nextChild = JSNode::toWrapped(state->argument(0));
</del><ins>+ auto nextChild = JSNode::toWrapped(state->argument(0));
</ins><span class="cx"> if (UNLIKELY(!nextChild))
</span><span class="cx"> return throwVMTypeError(state);
</span><span class="cx"> impl.excitingFunction(*nextChild);
</span><span class="lines">@@ -220,10 +220,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String message = state->argument(0).toWTFString(state);
</del><ins>+ auto message = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.postMessage(message);
</del><ins>+ impl.postMessage(WTFMove(message));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestCustomNamedGettercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -193,10 +193,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String str = state->argument(0).toWTFString(state);
</del><ins>+ auto str = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.anotherFunction(str);
</del><ins>+ impl.anotherFunction(WTFMove(str));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestEventTargetcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -205,10 +205,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- unsigned index = toUInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto index = toUInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.item(index)));
</del><ins>+ JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.item(WTFMove(index))));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestGlobalObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -214,10 +214,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestGlobalObject", "regularAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setRegularAttribute(nativeValue);
</del><ins>+ impl.setRegularAttribute(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -232,10 +232,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestGlobalObject", "enabledAtRuntimeAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setEnabledAtRuntimeAttribute(nativeValue);
</del><ins>+ impl.setEnabledAtRuntimeAttribute(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -256,10 +256,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String testParam = state->argument(0).toWTFString(state);
</del><ins>+ auto testParam = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.regularOperation(testParam);
</del><ins>+ impl.regularOperation(WTFMove(testParam));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -274,10 +274,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String testParam = state->argument(0).toWTFString(state);
</del><ins>+ auto testParam = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.enabledAtRuntimeOperation(testParam);
</del><ins>+ impl.enabledAtRuntimeOperation(WTFMove(testParam));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -294,10 +294,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int testParam = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto testParam = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.enabledAtRuntimeOperation(testParam);
</del><ins>+ impl.enabledAtRuntimeOperation(WTFMove(testParam));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestInterfacecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -226,10 +226,10 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- String str1 = state->argument(0).toWTFString(state);
</del><ins>+ auto str1 = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String str2 = state->argument(1).isUndefined() ? ASCIILiteral("defaultString") : state->uncheckedArgument(1).toWTFString(state);
</del><ins>+ auto str2 = state->argument(1).isUndefined() ? ASCIILiteral("defaultString") : state->uncheckedArgument(1).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> ScriptExecutionContext* context = castedThis->scriptExecutionContext();
</span><span class="lines">@@ -630,10 +630,10 @@
</span><span class="cx"> bool setJSTestInterfaceConstructorImplementsStaticAttr(ExecState* state, EncodedJSValue thisValue, EncodedJSValue encodedValue)
</span><span class="cx"> {
</span><span class="cx"> JSValue value = JSValue::decode(encodedValue);
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- TestInterface::setImplementsStaticAttr(nativeValue);
</del><ins>+ TestInterface::setImplementsStaticAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -649,10 +649,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestInterface", "implementsStr2");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setImplementsStr2(nativeValue);
</del><ins>+ impl.setImplementsStr2(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -683,7 +683,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestInterface", "implementsNode");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Node* nativeValue = JSNode::toWrapped(value);
</del><ins>+ auto nativeValue = JSNode::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -698,10 +698,10 @@
</span><span class="cx"> bool setJSTestInterfaceConstructorSupplementalStaticAttr(ExecState* state, EncodedJSValue thisValue, EncodedJSValue encodedValue)
</span><span class="cx"> {
</span><span class="cx"> JSValue value = JSValue::decode(encodedValue);
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- WebCore::TestSupplemental::setSupplementalStaticAttr(nativeValue);
</del><ins>+ WebCore::TestSupplemental::setSupplementalStaticAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -717,10 +717,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestInterface", "supplementalStr2");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- WebCore::TestSupplemental::setSupplementalStr2(impl, nativeValue);
</del><ins>+ WebCore::TestSupplemental::setSupplementalStr2(impl, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -751,7 +751,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestInterface", "supplementalNode");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Node* nativeValue = JSNode::toWrapped(value);
</del><ins>+ auto nativeValue = JSNode::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -797,13 +797,13 @@
</span><span class="cx"> auto* context = jsCast<JSDOMGlobalObject*>(state->lexicalGlobalObject())->scriptExecutionContext();
</span><span class="cx"> if (!context)
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String strArg = state->argument(0).toWTFString(state);
</del><ins>+ auto strArg = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(1));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(1));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.implementsMethod2(*context, strArg, *objArg, ec)));
</del><ins>+ JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.implementsMethod2(*context, WTFMove(strArg), *objArg, ec)));
</ins><span class="cx">
</span><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return JSValue::encode(result);
</span><span class="lines">@@ -863,13 +863,13 @@
</span><span class="cx"> auto* context = jsCast<JSDOMGlobalObject*>(state->lexicalGlobalObject())->scriptExecutionContext();
</span><span class="cx"> if (!context)
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String strArg = state->argument(0).toWTFString(state);
</del><ins>+ auto strArg = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(1));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(1));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(WebCore::TestSupplemental::supplementalMethod2(impl, *context, strArg, *objArg, ec)));
</del><ins>+ JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(WebCore::TestSupplemental::supplementalMethod2(impl, *context, WTFMove(strArg), *objArg, ec)));
</ins><span class="cx">
</span><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return JSValue::encode(result);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestNamedConstructorcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -86,13 +86,13 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- String str1 = state->argument(0).toWTFString(state);
</del><ins>+ auto str1 = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String str2 = state->argument(1).isUndefined() ? ASCIILiteral("defaultString") : state->uncheckedArgument(1).toWTFString(state);
</del><ins>+ auto str2 = state->argument(1).isUndefined() ? ASCIILiteral("defaultString") : state->uncheckedArgument(1).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String str3 = state->argument(2).isUndefined() ? String() : state->uncheckedArgument(2).toWTFString(state);
</del><ins>+ auto str3 = state->argument(2).isUndefined() ? String() : state->uncheckedArgument(2).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> RefPtr<TestNamedConstructor> object = TestNamedConstructor::createForJSConstructor(*castedThis->document(), str1, str2, str3, ec);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestNodecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -165,10 +165,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestNode", "name");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setName(nativeValue);
</del><ins>+ impl.setName(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestNondeterministiccpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -352,10 +352,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestNondeterministic", "nondeterministicWriteableAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setNondeterministicWriteableAttr(nativeValue);
</del><ins>+ impl.setNondeterministicWriteableAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -369,10 +369,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestNondeterministic", "nondeterministicExceptionAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setNondeterministicExceptionAttr(nativeValue);
</del><ins>+ impl.setNondeterministicExceptionAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -386,10 +386,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestNondeterministic", "nondeterministicGetterExceptionAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setNondeterministicGetterExceptionAttr(nativeValue);
</del><ins>+ impl.setNondeterministicGetterExceptionAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -404,10 +404,10 @@
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setNondeterministicSetterExceptionAttr(nativeValue, ec);
</del><ins>+ impl.setNondeterministicSetterExceptionAttr(WTFMove(nativeValue), ec);
</ins><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestObjcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -29,6 +29,7 @@
</span><span class="cx"> #include "Frame.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "JSDOMBinding.h"
</span><ins>+#include "JSDOMBuild.h"
</ins><span class="cx"> #include "JSDOMConstructor.h"
</span><span class="cx"> #include "JSDOMIterator.h"
</span><span class="cx"> #include "JSDOMPromise.h"
</span><span class="lines">@@ -45,7 +46,6 @@
</span><span class="cx"> #include "JSTestNode.h"
</span><span class="cx"> #include "JSTestObj.h"
</span><span class="cx"> #include "JSTestSubObj.h"
</span><del>-#include "JSbool.h"
</del><span class="cx"> #include "LifecycleCallbackQueue.h"
</span><span class="cx"> #include "RuntimeEnabledFeatures.h"
</span><span class="cx"> #include "SVGDocument.h"
</span><span class="lines">@@ -57,7 +57,6 @@
</span><span class="cx"> #include "TestObj.h"
</span><span class="cx"> #include "URL.h"
</span><span class="cx"> #include "WebCoreJSClientData.h"
</span><del>-#include "bool.h"
</del><span class="cx"> #include <inspector/ScriptArguments.h>
</span><span class="cx"> #include <inspector/ScriptCallStackFactory.h>
</span><span class="cx"> #include <runtime/Error.h>
</span><span class="lines">@@ -87,10 +86,10 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><ins>+template<typename T> Optional<T> parse(ExecState&, JSValue);
+template<typename T> const char* expectedEnumerationValues();
+
</ins><span class="cx"> JSString* jsStringWithCache(ExecState*, TestObj::EnumType);
</span><del>-Optional<TestObj::EnumType> parseTestObjEnumType(ExecState&, JSValue);
-extern const char expectedEnumerationValuesTestObjEnumType[];
-
</del><span class="cx"> JSString* jsStringWithCache(ExecState* state, TestObj::EnumType enumerationValue)
</span><span class="cx"> {
</span><span class="cx"> static NeverDestroyed<const String> values[] = {
</span><span class="lines">@@ -111,7 +110,7 @@
</span><span class="cx"> static JSString* arrayJSValue(ExecState* state, JSDOMGlobalObject*, TestObj::EnumType value) { return jsStringWithCache(state, value); }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-Optional<TestObj::EnumType> parseTestObjEnumType(ExecState& state, JSValue value)
</del><ins>+template<> Optional<TestObj::EnumType> parse<TestObj::EnumType>(ExecState& state, JSValue value)
</ins><span class="cx"> {
</span><span class="cx"> auto stringValue = value.toWTFString(&state);
</span><span class="cx"> if (stringValue.isEmpty())
</span><span class="lines">@@ -125,12 +124,22 @@
</span><span class="cx"> return Nullopt;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-const char expectedEnumerationValuesTestObjEnumType[] = "\"\", \"EnumValue1\", \"EnumValue2\", \"EnumValue3\"";
</del><ins>+template<> TestObj::EnumType build<TestObj::EnumType>(ExecState& state, JSValue value)
+{
+ auto result = parse<TestObj::EnumType>(state, value);
+ if (UNLIKELY(!result)) {
+ throwTypeError(&state);
+ return { };
+ }
+ return result.value();
+}
</ins><span class="cx">
</span><ins>+template<> inline const char* expectedEnumerationValues<TestObj::EnumType>()
+{
+ return "\"\", \"EnumValue1\", \"EnumValue2\", \"EnumValue3\"";
+}
+
</ins><span class="cx"> JSString* jsStringWithCache(ExecState*, TestObj::Optional);
</span><del>-Optional<TestObj::Optional> parseTestObjOptional(ExecState&, JSValue);
-extern const char expectedEnumerationValuesTestObjOptional[];
-
</del><span class="cx"> JSString* jsStringWithCache(ExecState* state, TestObj::Optional enumerationValue)
</span><span class="cx"> {
</span><span class="cx"> static NeverDestroyed<const String> values[] = {
</span><span class="lines">@@ -151,7 +160,7 @@
</span><span class="cx"> static JSString* arrayJSValue(ExecState* state, JSDOMGlobalObject*, TestObj::Optional value) { return jsStringWithCache(state, value); }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-Optional<TestObj::Optional> parseTestObjOptional(ExecState& state, JSValue value)
</del><ins>+template<> Optional<TestObj::Optional> parse<TestObj::Optional>(ExecState& state, JSValue value)
</ins><span class="cx"> {
</span><span class="cx"> auto stringValue = value.toWTFString(&state);
</span><span class="cx"> if (stringValue.isEmpty())
</span><span class="lines">@@ -165,14 +174,24 @@
</span><span class="cx"> return Nullopt;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-const char expectedEnumerationValuesTestObjOptional[] = "\"\", \"OptionalValue1\", \"OptionalValue2\", \"OptionalValue3\"";
</del><ins>+template<> TestObj::Optional build<TestObj::Optional>(ExecState& state, JSValue value)
+{
+ auto result = parse<TestObj::Optional>(state, value);
+ if (UNLIKELY(!result)) {
+ throwTypeError(&state);
+ return { };
+ }
+ return result.value();
+}
</ins><span class="cx">
</span><ins>+template<> inline const char* expectedEnumerationValues<TestObj::Optional>()
+{
+ return "\"\", \"OptionalValue1\", \"OptionalValue2\", \"OptionalValue3\"";
+}
+
</ins><span class="cx"> #if ENABLE(Condition1)
</span><span class="cx">
</span><span class="cx"> JSString* jsStringWithCache(ExecState*, TestObj::EnumA);
</span><del>-Optional<TestObj::EnumA> parseTestObjEnumA(ExecState&, JSValue);
-extern const char expectedEnumerationValuesTestObjEnumA[];
-
</del><span class="cx"> JSString* jsStringWithCache(ExecState* state, TestObj::EnumA enumerationValue)
</span><span class="cx"> {
</span><span class="cx"> static NeverDestroyed<const String> values[] = {
</span><span class="lines">@@ -187,7 +206,7 @@
</span><span class="cx"> static JSString* arrayJSValue(ExecState* state, JSDOMGlobalObject*, TestObj::EnumA value) { return jsStringWithCache(state, value); }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-Optional<TestObj::EnumA> parseTestObjEnumA(ExecState& state, JSValue value)
</del><ins>+template<> Optional<TestObj::EnumA> parse<TestObj::EnumA>(ExecState& state, JSValue value)
</ins><span class="cx"> {
</span><span class="cx"> auto stringValue = value.toWTFString(&state);
</span><span class="cx"> if (stringValue == "A")
</span><span class="lines">@@ -195,16 +214,26 @@
</span><span class="cx"> return Nullopt;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-const char expectedEnumerationValuesTestObjEnumA[] = "\"A\"";
</del><ins>+template<> TestObj::EnumA build<TestObj::EnumA>(ExecState& state, JSValue value)
+{
+ auto result = parse<TestObj::EnumA>(state, value);
+ if (UNLIKELY(!result)) {
+ throwTypeError(&state);
+ return { };
+ }
+ return result.value();
+}
</ins><span class="cx">
</span><ins>+template<> inline const char* expectedEnumerationValues<TestObj::EnumA>()
+{
+ return "\"A\"";
+}
+
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if ENABLE(Condition1) && ENABLE(Condition2)
</span><span class="cx">
</span><span class="cx"> JSString* jsStringWithCache(ExecState*, TestObj::EnumB);
</span><del>-Optional<TestObj::EnumB> parseTestObjEnumB(ExecState&, JSValue);
-extern const char expectedEnumerationValuesTestObjEnumB[];
-
</del><span class="cx"> JSString* jsStringWithCache(ExecState* state, TestObj::EnumB enumerationValue)
</span><span class="cx"> {
</span><span class="cx"> static NeverDestroyed<const String> values[] = {
</span><span class="lines">@@ -219,7 +248,7 @@
</span><span class="cx"> static JSString* arrayJSValue(ExecState* state, JSDOMGlobalObject*, TestObj::EnumB value) { return jsStringWithCache(state, value); }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-Optional<TestObj::EnumB> parseTestObjEnumB(ExecState& state, JSValue value)
</del><ins>+template<> Optional<TestObj::EnumB> parse<TestObj::EnumB>(ExecState& state, JSValue value)
</ins><span class="cx"> {
</span><span class="cx"> auto stringValue = value.toWTFString(&state);
</span><span class="cx"> if (stringValue == "B")
</span><span class="lines">@@ -227,16 +256,26 @@
</span><span class="cx"> return Nullopt;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-const char expectedEnumerationValuesTestObjEnumB[] = "\"B\"";
</del><ins>+template<> TestObj::EnumB build<TestObj::EnumB>(ExecState& state, JSValue value)
+{
+ auto result = parse<TestObj::EnumB>(state, value);
+ if (UNLIKELY(!result)) {
+ throwTypeError(&state);
+ return { };
+ }
+ return result.value();
+}
</ins><span class="cx">
</span><ins>+template<> inline const char* expectedEnumerationValues<TestObj::EnumB>()
+{
+ return "\"B\"";
+}
+
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> #if ENABLE(Condition1) || ENABLE(Condition2)
</span><span class="cx">
</span><span class="cx"> JSString* jsStringWithCache(ExecState*, TestObj::EnumC);
</span><del>-Optional<TestObj::EnumC> parseTestObjEnumC(ExecState&, JSValue);
-extern const char expectedEnumerationValuesTestObjEnumC[];
-
</del><span class="cx"> JSString* jsStringWithCache(ExecState* state, TestObj::EnumC enumerationValue)
</span><span class="cx"> {
</span><span class="cx"> static NeverDestroyed<const String> values[] = {
</span><span class="lines">@@ -251,7 +290,7 @@
</span><span class="cx"> static JSString* arrayJSValue(ExecState* state, JSDOMGlobalObject*, TestObj::EnumC value) { return jsStringWithCache(state, value); }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-Optional<TestObj::EnumC> parseTestObjEnumC(ExecState& state, JSValue value)
</del><ins>+template<> Optional<TestObj::EnumC> parse<TestObj::EnumC>(ExecState& state, JSValue value)
</ins><span class="cx"> {
</span><span class="cx"> auto stringValue = value.toWTFString(&state);
</span><span class="cx"> if (stringValue == "C")
</span><span class="lines">@@ -259,14 +298,24 @@
</span><span class="cx"> return Nullopt;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-const char expectedEnumerationValuesTestObjEnumC[] = "\"C\"";
</del><ins>+template<> TestObj::EnumC build<TestObj::EnumC>(ExecState& state, JSValue value)
+{
+ auto result = parse<TestObj::EnumC>(state, value);
+ if (UNLIKELY(!result)) {
+ throwTypeError(&state);
+ return { };
+ }
+ return result.value();
+}
</ins><span class="cx">
</span><ins>+template<> inline const char* expectedEnumerationValues<TestObj::EnumC>()
+{
+ return "\"C\"";
+}
+
</ins><span class="cx"> #endif
</span><span class="cx">
</span><span class="cx"> JSString* jsStringWithCache(ExecState*, TestObj::Kind);
</span><del>-Optional<TestObj::Kind> parseTestObjKind(ExecState&, JSValue);
-extern const char expectedEnumerationValuesTestObjKind[];
-
</del><span class="cx"> JSString* jsStringWithCache(ExecState* state, TestObj::Kind enumerationValue)
</span><span class="cx"> {
</span><span class="cx"> static NeverDestroyed<const String> values[] = {
</span><span class="lines">@@ -283,7 +332,7 @@
</span><span class="cx"> static JSString* arrayJSValue(ExecState* state, JSDOMGlobalObject*, TestObj::Kind value) { return jsStringWithCache(state, value); }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-Optional<TestObj::Kind> parseTestObjKind(ExecState& state, JSValue value)
</del><ins>+template<> Optional<TestObj::Kind> parse<TestObj::Kind>(ExecState& state, JSValue value)
</ins><span class="cx"> {
</span><span class="cx"> auto stringValue = value.toWTFString(&state);
</span><span class="cx"> if (stringValue == "quick")
</span><span class="lines">@@ -293,12 +342,22 @@
</span><span class="cx"> return Nullopt;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-const char expectedEnumerationValuesTestObjKind[] = "\"quick\", \"dead\"";
</del><ins>+template<> TestObj::Kind build<TestObj::Kind>(ExecState& state, JSValue value)
+{
+ auto result = parse<TestObj::Kind>(state, value);
+ if (UNLIKELY(!result)) {
+ throwTypeError(&state);
+ return { };
+ }
+ return result.value();
+}
</ins><span class="cx">
</span><ins>+template<> inline const char* expectedEnumerationValues<TestObj::Kind>()
+{
+ return "\"quick\", \"dead\"";
+}
+
</ins><span class="cx"> JSString* jsStringWithCache(ExecState*, TestObj::Size);
</span><del>-Optional<TestObj::Size> parseTestObjSize(ExecState&, JSValue);
-extern const char expectedEnumerationValuesTestObjSize[];
-
</del><span class="cx"> JSString* jsStringWithCache(ExecState* state, TestObj::Size enumerationValue)
</span><span class="cx"> {
</span><span class="cx"> static NeverDestroyed<const String> values[] = {
</span><span class="lines">@@ -315,7 +374,7 @@
</span><span class="cx"> static JSString* arrayJSValue(ExecState* state, JSDOMGlobalObject*, TestObj::Size value) { return jsStringWithCache(state, value); }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-Optional<TestObj::Size> parseTestObjSize(ExecState& state, JSValue value)
</del><ins>+template<> Optional<TestObj::Size> parse<TestObj::Size>(ExecState& state, JSValue value)
</ins><span class="cx"> {
</span><span class="cx"> auto stringValue = value.toWTFString(&state);
</span><span class="cx"> if (stringValue == "small")
</span><span class="lines">@@ -325,12 +384,22 @@
</span><span class="cx"> return Nullopt;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-const char expectedEnumerationValuesTestObjSize[] = "\"small\", \"much-much-larger\"";
</del><ins>+template<> TestObj::Size build<TestObj::Size>(ExecState& state, JSValue value)
+{
+ auto result = parse<TestObj::Size>(state, value);
+ if (UNLIKELY(!result)) {
+ throwTypeError(&state);
+ return { };
+ }
+ return result.value();
+}
</ins><span class="cx">
</span><ins>+template<> inline const char* expectedEnumerationValues<TestObj::Size>()
+{
+ return "\"small\", \"much-much-larger\"";
+}
+
</ins><span class="cx"> JSString* jsStringWithCache(ExecState*, TestObj::Confidence);
</span><del>-Optional<TestObj::Confidence> parseTestObjConfidence(ExecState&, JSValue);
-extern const char expectedEnumerationValuesTestObjConfidence[];
-
</del><span class="cx"> JSString* jsStringWithCache(ExecState* state, TestObj::Confidence enumerationValue)
</span><span class="cx"> {
</span><span class="cx"> static NeverDestroyed<const String> values[] = {
</span><span class="lines">@@ -347,7 +416,7 @@
</span><span class="cx"> static JSString* arrayJSValue(ExecState* state, JSDOMGlobalObject*, TestObj::Confidence value) { return jsStringWithCache(state, value); }
</span><span class="cx"> };
</span><span class="cx">
</span><del>-Optional<TestObj::Confidence> parseTestObjConfidence(ExecState& state, JSValue value)
</del><ins>+template<> Optional<TestObj::Confidence> parse<TestObj::Confidence>(ExecState& state, JSValue value)
</ins><span class="cx"> {
</span><span class="cx"> auto stringValue = value.toWTFString(&state);
</span><span class="cx"> if (stringValue == "high")
</span><span class="lines">@@ -357,8 +426,70 @@
</span><span class="cx"> return Nullopt;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-const char expectedEnumerationValuesTestObjConfidence[] = "\"high\", \"kinda-low\"";
</del><ins>+template<> TestObj::Confidence build<TestObj::Confidence>(ExecState& state, JSValue value)
+{
+ auto result = parse<TestObj::Confidence>(state, value);
+ if (UNLIKELY(!result)) {
+ throwTypeError(&state);
+ return { };
+ }
+ return result.value();
+}
</ins><span class="cx">
</span><ins>+template<> inline const char* expectedEnumerationValues<TestObj::Confidence>()
+{
+ return "\"high\", \"kinda-low\"";
+}
+
+JSString* jsStringWithCache(ExecState*, TestObj::ShadowRootMode);
+JSString* jsStringWithCache(ExecState* state, TestObj::ShadowRootMode enumerationValue)
+{
+ static NeverDestroyed<const String> values[] = {
+ ASCIILiteral("open"),
+ ASCIILiteral("closed"),
+ };
+ static_assert(static_cast<size_t>(TestObj::ShadowRootMode::Open) == 0, "TestObj::ShadowRootMode::Open is not 0 as expected");
+ static_assert(static_cast<size_t>(TestObj::ShadowRootMode::Closed) == 1, "TestObj::ShadowRootMode::Closed is not 1 as expected");
+ ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values));
+ return jsStringWithCache(state, values[static_cast<size_t>(enumerationValue)]);
+}
+
+template<> struct JSValueTraits<TestObj::ShadowRootMode> {
+ static JSString* arrayJSValue(ExecState* state, JSDOMGlobalObject*, TestObj::ShadowRootMode value) { return jsStringWithCache(state, value); }
+};
+
+template<> Optional<TestObj::ShadowRootMode> parse<TestObj::ShadowRootMode>(ExecState& state, JSValue value)
+{
+ auto stringValue = value.toWTFString(&state);
+ if (stringValue == "open")
+ return TestObj::ShadowRootMode::Open;
+ if (stringValue == "closed")
+ return TestObj::ShadowRootMode::Closed;
+ return Nullopt;
+}
+
+template<> TestObj::ShadowRootMode build<TestObj::ShadowRootMode>(ExecState& state, JSValue value)
+{
+ auto result = parse<TestObj::ShadowRootMode>(state, value);
+ if (UNLIKELY(!result)) {
+ throwTypeError(&state);
+ return { };
+ }
+ return result.value();
+}
+
+template<> inline const char* expectedEnumerationValues<TestObj::ShadowRootMode>()
+{
+ return "\"open\", \"closed\"";
+}
+
+template<> TestObj::ShadowRootInit build<TestObj::ShadowRootInit>(ExecState& state, JSValue value)
+{
+ return {
+ build<TestObj::ShadowRootMode>(state, value, "mode"),
+ };
+}
+
</ins><span class="cx"> // Functions
</span><span class="cx">
</span><span class="cx"> #if ENABLE(TEST_FEATURE)
</span><span class="lines">@@ -485,6 +616,7 @@
</span><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjConstructorFunctionTestStaticPromiseFunction(JSC::ExecState*);
</span><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjConstructorFunctionTestStaticPromiseFunctionWithException(JSC::ExecState*);
</span><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionMethodWithNeedsLifecycleProcessingStack(JSC::ExecState*);
</span><ins>+JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionAttachShadowRoot(JSC::ExecState*);
</ins><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionSymbolIterator(JSC::ExecState*);
</span><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionEntries(JSC::ExecState*);
</span><span class="cx"> JSC::EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionKeys(JSC::ExecState*);
</span><span class="lines">@@ -1057,6 +1189,7 @@
</span><span class="cx"> { "testPromiseFunctionWithOptionalIntArgument", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionTestPromiseFunctionWithOptionalIntArgument), (intptr_t) (0) } },
</span><span class="cx"> { "testPromiseOverloadedFunction", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionTestPromiseOverloadedFunction), (intptr_t) (1) } },
</span><span class="cx"> { "methodWithNeedsLifecycleProcessingStack", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithNeedsLifecycleProcessingStack), (intptr_t) (0) } },
</span><ins>+ { "attachShadowRoot", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionAttachShadowRoot), (intptr_t) (1) } },
</ins><span class="cx"> { "entries", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionEntries), (intptr_t) (0) } },
</span><span class="cx"> { "keys", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionKeys), (intptr_t) (0) } },
</span><span class="cx"> { "values", JSC::Function, NoIntrinsic, { (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionValues), (intptr_t) (0) } },
</span><span class="lines">@@ -2464,10 +2597,10 @@
</span><span class="cx"> bool setJSTestObjConstructorStaticStringAttr(ExecState* state, EncodedJSValue thisValue, EncodedJSValue encodedValue)
</span><span class="cx"> {
</span><span class="cx"> JSValue value = JSValue::decode(encodedValue);
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- TestObj::setStaticStringAttr(nativeValue);
</del><ins>+ TestObj::setStaticStringAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2494,7 +2627,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "enumAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- auto nativeValue = parseTestObjEnumType(*state, value);
</del><ins>+ auto nativeValue = parse<TestObj::EnumType>(*state, value);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><span class="cx"> if (UNLIKELY(!nativeValue))
</span><span class="lines">@@ -2513,10 +2646,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "byteAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int8_t nativeValue = toInt8(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt8(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setByteAttr(nativeValue);
</del><ins>+ impl.setByteAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2530,10 +2663,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "octetAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- uint8_t nativeValue = toUInt8(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toUInt8(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setOctetAttr(nativeValue);
</del><ins>+ impl.setOctetAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2547,10 +2680,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "shortAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int16_t nativeValue = toInt16(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt16(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setShortAttr(nativeValue);
</del><ins>+ impl.setShortAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2564,10 +2697,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "clampedShortAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int16_t nativeValue = toInt16(state, value, Clamp);
</del><ins>+ auto nativeValue = toInt16(state, value, Clamp);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setClampedShortAttr(nativeValue);
</del><ins>+ impl.setClampedShortAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2581,10 +2714,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "enforceRangeShortAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int16_t nativeValue = toInt16(state, value, EnforceRange);
</del><ins>+ auto nativeValue = toInt16(state, value, EnforceRange);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setEnforceRangeShortAttr(nativeValue);
</del><ins>+ impl.setEnforceRangeShortAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2598,10 +2731,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "unsignedShortAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- uint16_t nativeValue = toUInt16(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toUInt16(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setUnsignedShortAttr(nativeValue);
</del><ins>+ impl.setUnsignedShortAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2615,10 +2748,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "longAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setLongAttr(nativeValue);
</del><ins>+ impl.setLongAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2632,10 +2765,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "longLongAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- long long nativeValue = toInt64(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt64(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setLongLongAttr(nativeValue);
</del><ins>+ impl.setLongLongAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2649,10 +2782,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "unsignedLongLongAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- unsigned long long nativeValue = toUInt64(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toUInt64(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setUnsignedLongLongAttr(nativeValue);
</del><ins>+ impl.setUnsignedLongLongAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2666,10 +2799,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "stringAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setStringAttr(nativeValue);
</del><ins>+ impl.setStringAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2683,7 +2816,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "testObjAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -2702,8 +2835,8 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "testNullableObjAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
- impl.setTestNullableObjAttr(nativeValue);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
+ impl.setTestNullableObjAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2717,7 +2850,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -2736,10 +2869,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "stringAttrTreatingNullAsEmptyString");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = valueToStringTreatingNullAsEmptyString(state, value);
</del><ins>+ auto nativeValue = valueToStringTreatingNullAsEmptyString(state, value);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setStringAttrTreatingNullAsEmptyString(nativeValue);
</del><ins>+ impl.setStringAttrTreatingNullAsEmptyString(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2753,7 +2886,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "XMLObjAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -2772,10 +2905,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "create");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- bool nativeValue = value.toBoolean(state);
</del><ins>+ auto nativeValue = value.toBoolean(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setCreate(nativeValue);
</del><ins>+ impl.setCreate(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2789,10 +2922,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "reflectedStringAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setAttributeWithoutSynchronization(WebCore::HTMLNames::reflectedstringattrAttr, nativeValue);
</del><ins>+ impl.setAttributeWithoutSynchronization(WebCore::HTMLNames::reflectedstringattrAttr, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2806,10 +2939,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "reflectedIntegralAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setIntegralAttribute(WebCore::HTMLNames::reflectedintegralattrAttr, nativeValue);
</del><ins>+ impl.setIntegralAttribute(WebCore::HTMLNames::reflectedintegralattrAttr, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2823,10 +2956,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "reflectedUnsignedIntegralAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- unsigned nativeValue = toUInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toUInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setUnsignedIntegralAttribute(WebCore::HTMLNames::reflectedunsignedintegralattrAttr, nativeValue);
</del><ins>+ impl.setUnsignedIntegralAttribute(WebCore::HTMLNames::reflectedunsignedintegralattrAttr, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2840,10 +2973,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "reflectedBooleanAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- bool nativeValue = value.toBoolean(state);
</del><ins>+ auto nativeValue = value.toBoolean(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setBooleanAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr, nativeValue);
</del><ins>+ impl.setBooleanAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2857,10 +2990,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "reflectedURLAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setAttributeWithoutSynchronization(WebCore::HTMLNames::reflectedurlattrAttr, nativeValue);
</del><ins>+ impl.setAttributeWithoutSynchronization(WebCore::HTMLNames::reflectedurlattrAttr, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2874,10 +3007,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "reflectedStringAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setAttributeWithoutSynchronization(WebCore::HTMLNames::customContentStringAttrAttr, nativeValue);
</del><ins>+ impl.setAttributeWithoutSynchronization(WebCore::HTMLNames::customContentStringAttrAttr, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2891,10 +3024,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "reflectedCustomIntegralAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setIntegralAttribute(WebCore::HTMLNames::customContentIntegralAttrAttr, nativeValue);
</del><ins>+ impl.setIntegralAttribute(WebCore::HTMLNames::customContentIntegralAttrAttr, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2908,10 +3041,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "reflectedCustomBooleanAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- bool nativeValue = value.toBoolean(state);
</del><ins>+ auto nativeValue = value.toBoolean(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setBooleanAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr, nativeValue);
</del><ins>+ impl.setBooleanAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2925,10 +3058,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "reflectedCustomURLAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setAttributeWithoutSynchronization(WebCore::HTMLNames::customContentURLAttrAttr, nativeValue);
</del><ins>+ impl.setAttributeWithoutSynchronization(WebCore::HTMLNames::customContentURLAttrAttr, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2943,10 +3076,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "enabledAtRuntimeAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setEnabledAtRuntimeAttribute(nativeValue);
</del><ins>+ impl.setEnabledAtRuntimeAttribute(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2961,7 +3094,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "typedArrayAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- RefPtr<Float32Array> nativeValue = toFloat32Array(value);
</del><ins>+ auto nativeValue = toFloat32Array(value);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="lines">@@ -2982,10 +3115,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "attrWithGetterException");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setAttrWithGetterException(nativeValue);
</del><ins>+ impl.setAttrWithGetterException(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -2999,10 +3132,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "attrWithGetterExceptionWithMessage");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setAttrWithGetterExceptionWithMessage(nativeValue);
</del><ins>+ impl.setAttrWithGetterExceptionWithMessage(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3017,10 +3150,10 @@
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setAttrWithSetterException(nativeValue, ec);
</del><ins>+ impl.setAttrWithSetterException(WTFMove(nativeValue), ec);
</ins><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -3036,10 +3169,10 @@
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> ExceptionCodeWithMessage ec;
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setAttrWithSetterExceptionWithMessage(nativeValue, ec);
</del><ins>+ impl.setAttrWithSetterExceptionWithMessage(WTFMove(nativeValue), ec);
</ins><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -3054,10 +3187,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "stringAttrWithGetterException");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setStringAttrWithGetterException(nativeValue);
</del><ins>+ impl.setStringAttrWithGetterException(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3072,10 +3205,10 @@
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setStringAttrWithSetterException(nativeValue, ec);
</del><ins>+ impl.setStringAttrWithSetterException(WTFMove(nativeValue), ec);
</ins><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -3098,7 +3231,7 @@
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx"> }
</span><del>- impl.setStrictTypeCheckingAttribute(nativeValue);
</del><ins>+ impl.setStrictTypeCheckingAttribute(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3151,10 +3284,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "withScriptStateAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setWithScriptStateAttribute(*state, nativeValue);
</del><ins>+ impl.setWithScriptStateAttribute(*state, WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3168,10 +3301,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "withCallWithAndSetterCallWithAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setWithCallWithAndSetterCallWithAttribute(*state, activeDOMWindow(state), firstDOMWindow(state), nativeValue);
</del><ins>+ impl.setWithCallWithAndSetterCallWithAttribute(*state, activeDOMWindow(state), firstDOMWindow(state), WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3185,7 +3318,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "withScriptExecutionContextAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -3207,7 +3340,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "withScriptStateAttributeRaises");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -3226,7 +3359,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "withScriptExecutionContextAttributeRaises");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -3248,7 +3381,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "withScriptExecutionContextAndScriptStateAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -3270,7 +3403,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "withScriptExecutionContextAndScriptStateAttributeRaises");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -3292,7 +3425,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "withScriptExecutionContextAndScriptStateWithSpacesAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -3314,7 +3447,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "withScriptArgumentsAndCallStackAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* nativeValue = JSTestObj::toWrapped(value);
</del><ins>+ auto nativeValue = JSTestObj::toWrapped(value);
</ins><span class="cx"> if (UNLIKELY(!nativeValue)) {
</span><span class="cx"> throwVMTypeError(state);
</span><span class="cx"> return false;
</span><span class="lines">@@ -3334,10 +3467,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "conditionalAttr1");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setConditionalAttr1(nativeValue);
</del><ins>+ impl.setConditionalAttr1(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3353,10 +3486,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "conditionalAttr2");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setConditionalAttr2(nativeValue);
</del><ins>+ impl.setConditionalAttr2(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3372,10 +3505,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "conditionalAttr3");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setConditionalAttr3(nativeValue);
</del><ins>+ impl.setConditionalAttr3(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3435,8 +3568,8 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "anyAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- JSC::JSValue nativeValue = value;
- impl.setAnyAttribute(nativeValue);
</del><ins>+ auto nativeValue = value;
+ impl.setAnyAttribute(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3450,8 +3583,8 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "mutablePoint");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- SVGPropertyTearOff<SVGPoint>* nativeValue = JSSVGPoint::toWrapped(value);
- impl.setMutablePoint(nativeValue);
</del><ins>+ auto nativeValue = JSSVGPoint::toWrapped(value);
+ impl.setMutablePoint(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3465,8 +3598,8 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "immutablePoint");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- SVGPropertyTearOff<SVGPoint>* nativeValue = JSSVGPoint::toWrapped(value);
- impl.setImmutablePoint(nativeValue);
</del><ins>+ auto nativeValue = JSSVGPoint::toWrapped(value);
+ impl.setImmutablePoint(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3480,10 +3613,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "strawberry");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setBlueberry(nativeValue);
</del><ins>+ impl.setBlueberry(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3497,10 +3630,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "strictFloat");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- float nativeValue = value.toFloat(state);
</del><ins>+ auto nativeValue = value.toFloat(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setStrictFloat(nativeValue);
</del><ins>+ impl.setStrictFloat(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3514,10 +3647,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "id");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setId(nativeValue);
</del><ins>+ impl.setId(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3544,10 +3677,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "nullableLongSettableAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setNullableLongSettableAttribute(nativeValue);
</del><ins>+ impl.setNullableLongSettableAttribute(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3561,10 +3694,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "nullableStringSettableAttribute");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = valueToStringWithUndefinedOrNullCheck(state, value);
</del><ins>+ auto nativeValue = valueToStringWithUndefinedOrNullCheck(state, value);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setNullableStringSettableAttribute(nativeValue);
</del><ins>+ impl.setNullableStringSettableAttribute(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3578,10 +3711,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "nullableStringValue");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setNullableStringValue(nativeValue);
</del><ins>+ impl.setNullableStringValue(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3595,7 +3728,7 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestObj", "attributeWithReservedEnumType");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- auto nativeValue = parseTestObjOptional(*state, value);
</del><ins>+ auto nativeValue = parse<TestObj::Optional>(*state, value);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><span class="cx"> if (UNLIKELY(!nativeValue))
</span><span class="lines">@@ -3615,10 +3748,10 @@
</span><span class="cx"> }
</span><span class="cx"> Ref<TestNode> forwardedImpl = castedThis->wrapped().putForwardsAttribute();
</span><span class="cx"> auto& impl = forwardedImpl.get();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setName(nativeValue);
</del><ins>+ impl.setName(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3635,10 +3768,10 @@
</span><span class="cx"> if (!forwardedImpl)
</span><span class="cx"> return false;
</span><span class="cx"> auto& impl = *forwardedImpl;
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setName(nativeValue);
</del><ins>+ impl.setName(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3668,10 +3801,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String testParam = state->argument(0).toWTFString(state);
</del><ins>+ auto testParam = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.enabledAtRuntimeOperation(testParam);
</del><ins>+ impl.enabledAtRuntimeOperation(WTFMove(testParam));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3688,10 +3821,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int testParam = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto testParam = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.enabledAtRuntimeOperation(testParam);
</del><ins>+ impl.enabledAtRuntimeOperation(WTFMove(testParam));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3737,16 +3870,16 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 3))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int longArg = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto longArg = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String strArg = state->argument(1).toWTFString(state);
</del><ins>+ auto strArg = state->argument(1).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(2));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(2));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- impl.voidMethodWithArgs(longArg, strArg, *objArg);
</del><ins>+ impl.voidMethodWithArgs(WTFMove(longArg), WTFMove(strArg), *objArg);
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3772,16 +3905,16 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 3))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int8_t byteArg = toInt8(state, state->argument(0), NormalConversion);
</del><ins>+ auto byteArg = toInt8(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String strArg = state->argument(1).toWTFString(state);
</del><ins>+ auto strArg = state->argument(1).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(2));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(2));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- JSValue result = jsNumber(impl.byteMethodWithArgs(byteArg, strArg, *objArg));
</del><ins>+ JSValue result = jsNumber(impl.byteMethodWithArgs(WTFMove(byteArg), WTFMove(strArg), *objArg));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3807,16 +3940,16 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 3))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- uint8_t octetArg = toUInt8(state, state->argument(0), NormalConversion);
</del><ins>+ auto octetArg = toUInt8(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String strArg = state->argument(1).toWTFString(state);
</del><ins>+ auto strArg = state->argument(1).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(2));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(2));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- JSValue result = jsNumber(impl.octetMethodWithArgs(octetArg, strArg, *objArg));
</del><ins>+ JSValue result = jsNumber(impl.octetMethodWithArgs(WTFMove(octetArg), WTFMove(strArg), *objArg));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3842,16 +3975,16 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 3))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int longArg = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto longArg = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String strArg = state->argument(1).toWTFString(state);
</del><ins>+ auto strArg = state->argument(1).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(2));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(2));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- JSValue result = jsNumber(impl.longMethodWithArgs(longArg, strArg, *objArg));
</del><ins>+ JSValue result = jsNumber(impl.longMethodWithArgs(WTFMove(longArg), WTFMove(strArg), *objArg));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3877,16 +4010,16 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 3))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int longArg = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto longArg = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String strArg = state->argument(1).toWTFString(state);
</del><ins>+ auto strArg = state->argument(1).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(2));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(2));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.objMethodWithArgs(longArg, strArg, *objArg)));
</del><ins>+ JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.objMethodWithArgs(WTFMove(longArg), WTFMove(strArg), *objArg)));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3912,10 +4045,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String arg = valueToStringTreatingNullAsEmptyString(state, state->argument(0));
</del><ins>+ auto arg = valueToStringTreatingNullAsEmptyString(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithArgTreatingNullAsEmptyString(arg);
</del><ins>+ impl.methodWithArgTreatingNullAsEmptyString(WTFMove(arg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3947,10 +4080,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- unsigned index = toUInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto index = toUInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = jsStringOrNull(state, impl.nullableStringSpecialMethod(index));
</del><ins>+ JSValue result = jsStringOrNull(state, impl.nullableStringSpecialMethod(WTFMove(index)));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3964,10 +4097,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Vector<RefPtr<ScriptProfile>> sequenceArg = (toRefPtrNativeArray<ScriptProfile, JSScriptProfile>(state, state->argument(0), &JSScriptProfile::toWrapped));
</del><ins>+ auto sequenceArg = (toRefPtrNativeArray<ScriptProfile, JSScriptProfile>(state, state->argument(0), &JSScriptProfile::toWrapped));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithSequenceArg(sequenceArg);
</del><ins>+ impl.methodWithSequenceArg(WTFMove(sequenceArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3981,10 +4114,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int longArg = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto longArg = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = jsArray(state, castedThis->globalObject(), impl.methodReturningSequence(longArg));
</del><ins>+ JSValue result = jsArray(state, castedThis->globalObject(), impl.methodReturningSequence(WTFMove(longArg)));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4000,11 +4133,11 @@
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> auto enumArgValue = state->argument(0);
</span><span class="cx"> TestObj::EnumType enumArg;
</span><del>- auto optionalValue = parseTestObjEnumType(*state, enumArgValue);
</del><ins>+ auto optionalValue = parse<TestObj::EnumType>(*state, enumArgValue);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> if (UNLIKELY(!optionalValue))
</span><del>- return throwArgumentMustBeEnumError(*state, 0, "enumArg", "TestObj", "methodWithEnumArg", expectedEnumerationValuesTestObjEnumType);
</del><ins>+ return throwArgumentMustBeEnumError(*state, 0, "enumArg", "TestObj", "methodWithEnumArg", expectedEnumerationValues<TestObj::EnumType>());
</ins><span class="cx"> enumArg = optionalValue.value();
</span><span class="cx"> impl.methodWithEnumArg(enumArg);
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="lines">@@ -4023,11 +4156,11 @@
</span><span class="cx"> if (enumArgValue.isUndefined()) {
</span><span class="cx"> enumArg = TestObj::EnumType::EnumValue1;
</span><span class="cx"> } else {
</span><del>- auto optionalValue = parseTestObjEnumType(*state, enumArgValue);
</del><ins>+ auto optionalValue = parse<TestObj::EnumType>(*state, enumArgValue);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> if (UNLIKELY(!optionalValue))
</span><del>- return throwArgumentMustBeEnumError(*state, 0, "enumArg", "TestObj", "methodWithOptionalEnumArgAndDefaultValue", expectedEnumerationValuesTestObjEnumType);
</del><ins>+ return throwArgumentMustBeEnumError(*state, 0, "enumArg", "TestObj", "methodWithOptionalEnumArgAndDefaultValue", expectedEnumerationValues<TestObj::EnumType>());
</ins><span class="cx"> enumArg = optionalValue.value();
</span><span class="cx"> }
</span><span class="cx"> impl.methodWithOptionalEnumArgAndDefaultValue(enumArg);
</span><span class="lines">@@ -4045,13 +4178,13 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- String strArg = state->argument(0).toWTFString(state);
</del><ins>+ auto strArg = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(1));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(1));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.methodThatRequiresAllArgsAndThrows(strArg, *objArg, ec)));
</del><ins>+ JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.methodThatRequiresAllArgsAndThrows(WTFMove(strArg), *objArg, ec)));
</ins><span class="cx">
</span><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return JSValue::encode(result);
</span><span class="lines">@@ -4067,10 +4200,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- RefPtr<SerializedScriptValue> serializedArg = SerializedScriptValue::create(state, state->argument(0), 0, 0);
</del><ins>+ auto serializedArg = SerializedScriptValue::create(state, state->argument(0), 0, 0);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.serializedValue(serializedArg);
</del><ins>+ impl.serializedValue(WTFMove(serializedArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4084,9 +4217,9 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Dictionary oo = { state, state->argument(0) };
- Dictionary ooo = { state, state->argument(1) };
- impl.optionsObject(oo, ooo);
</del><ins>+ auto oo = Dictionary(state, state->argument(0));
+ auto ooo = Dictionary(state, state->argument(1));
+ impl.optionsObject(WTFMove(oo), WTFMove(ooo));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4148,10 +4281,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String argument = state->argument(0).toWTFString(state);
</del><ins>+ auto argument = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = jsStringWithCache(state, impl.privateMethod(argument));
</del><ins>+ JSValue result = jsStringWithCache(state, impl.privateMethod(WTFMove(argument)));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4347,10 +4480,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalArg");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Optional<int> opt = state->argument(0).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(0), NormalConversion);
</del><ins>+ auto opt = state->argument(0).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalArg(opt);
</del><ins>+ impl.methodWithOptionalArg(WTFMove(opt));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4362,10 +4495,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalArgAndDefaultValue");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int opt = state->argument(0).isUndefined() ? 666 : toInt32(state, state->uncheckedArgument(0), NormalConversion);
</del><ins>+ auto opt = state->argument(0).isUndefined() ? 666 : toInt32(state, state->uncheckedArgument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalArgAndDefaultValue(opt);
</del><ins>+ impl.methodWithOptionalArgAndDefaultValue(WTFMove(opt));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4379,13 +4512,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int nonOpt = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto nonOpt = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- Optional<int> opt = state->argument(1).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(1), NormalConversion);
</del><ins>+ auto opt = state->argument(1).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(1), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithNonOptionalArgAndOptionalArg(nonOpt, opt);
</del><ins>+ impl.methodWithNonOptionalArgAndOptionalArg(WTFMove(nonOpt), WTFMove(opt));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4399,16 +4532,16 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int nonOpt = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto nonOpt = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- Optional<int> opt1 = state->argument(1).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(1), NormalConversion);
</del><ins>+ auto opt1 = state->argument(1).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(1), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- Optional<int> opt2 = state->argument(2).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(2), NormalConversion);
</del><ins>+ auto opt2 = state->argument(2).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(2), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithNonOptionalArgAndTwoOptionalArgs(nonOpt, opt1, opt2);
</del><ins>+ impl.methodWithNonOptionalArgAndTwoOptionalArgs(WTFMove(nonOpt), WTFMove(opt1), WTFMove(opt2));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4420,10 +4553,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalString");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String str = state->argument(0).isUndefined() ? String() : state->uncheckedArgument(0).toWTFString(state);
</del><ins>+ auto str = state->argument(0).isUndefined() ? String() : state->uncheckedArgument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalString(str);
</del><ins>+ impl.methodWithOptionalString(WTFMove(str));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4435,10 +4568,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalAtomicString");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String str = state->argument(0).isUndefined() ? nullAtom : state->uncheckedArgument(0).toString(state)->toAtomicString(state);
</del><ins>+ auto str = state->argument(0).isUndefined() ? nullAtom : state->uncheckedArgument(0).toString(state)->toAtomicString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalAtomicString(str);
</del><ins>+ impl.methodWithOptionalAtomicString(WTFMove(str));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4450,10 +4583,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalStringAndDefaultValue");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String str = state->argument(0).isUndefined() ? ASCIILiteral("foo") : state->uncheckedArgument(0).toWTFString(state);
</del><ins>+ auto str = state->argument(0).isUndefined() ? ASCIILiteral("foo") : state->uncheckedArgument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalStringAndDefaultValue(str);
</del><ins>+ impl.methodWithOptionalStringAndDefaultValue(WTFMove(str));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4465,10 +4598,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalAtomicStringAndDefaultValue");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String str = state->argument(0).isUndefined() ? AtomicString("foo", AtomicString::ConstructFromLiteral) : state->uncheckedArgument(0).toString(state)->toAtomicString(state);
</del><ins>+ auto str = state->argument(0).isUndefined() ? AtomicString("foo", AtomicString::ConstructFromLiteral) : state->uncheckedArgument(0).toString(state)->toAtomicString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalAtomicStringAndDefaultValue(str);
</del><ins>+ impl.methodWithOptionalAtomicStringAndDefaultValue(WTFMove(str));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4480,10 +4613,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalStringIsNull");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String str = state->argument(0).isUndefined() ? String() : state->uncheckedArgument(0).toWTFString(state);
</del><ins>+ auto str = state->argument(0).isUndefined() ? String() : state->uncheckedArgument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalStringIsNull(str);
</del><ins>+ impl.methodWithOptionalStringIsNull(WTFMove(str));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4495,10 +4628,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalStringIsUndefined");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String str = state->argument(0).toWTFString(state);
</del><ins>+ auto str = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalStringIsUndefined(str);
</del><ins>+ impl.methodWithOptionalStringIsUndefined(WTFMove(str));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4510,10 +4643,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalAtomicStringIsNull");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String str = state->argument(0).isUndefined() ? nullAtom : state->uncheckedArgument(0).toString(state)->toAtomicString(state);
</del><ins>+ auto str = state->argument(0).isUndefined() ? nullAtom : state->uncheckedArgument(0).toString(state)->toAtomicString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalAtomicStringIsNull(str);
</del><ins>+ impl.methodWithOptionalAtomicStringIsNull(WTFMove(str));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4525,10 +4658,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalStringIsEmptyString");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String str = state->argument(0).isUndefined() ? emptyString() : state->uncheckedArgument(0).toWTFString(state);
</del><ins>+ auto str = state->argument(0).isUndefined() ? emptyString() : state->uncheckedArgument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalStringIsEmptyString(str);
</del><ins>+ impl.methodWithOptionalStringIsEmptyString(WTFMove(str));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4540,10 +4673,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalAtomicStringIsEmptyString");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String str = state->argument(0).isUndefined() ? emptyAtom : state->uncheckedArgument(0).toString(state)->toAtomicString(state);
</del><ins>+ auto str = state->argument(0).isUndefined() ? emptyAtom : state->uncheckedArgument(0).toString(state)->toAtomicString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalAtomicStringIsEmptyString(str);
</del><ins>+ impl.methodWithOptionalAtomicStringIsEmptyString(WTFMove(str));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4555,10 +4688,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalDoubleIsNaN");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- double number = state->argument(0).toNumber(state);
</del><ins>+ auto number = state->argument(0).toNumber(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalDoubleIsNaN(number);
</del><ins>+ impl.methodWithOptionalDoubleIsNaN(WTFMove(number));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4570,10 +4703,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalFloatIsNaN");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- float number = state->argument(0).toFloat(state);
</del><ins>+ auto number = state->argument(0).toFloat(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalFloatIsNaN(number);
</del><ins>+ impl.methodWithOptionalFloatIsNaN(WTFMove(number));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4585,10 +4718,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalSequence");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Vector<String> sequence = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto sequence = toNativeArray<String>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalSequence(sequence);
</del><ins>+ impl.methodWithOptionalSequence(WTFMove(sequence));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4600,10 +4733,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalLongLong");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Optional<long long> number = state->argument(0).isUndefined() ? Optional<long long>() : toInt64(state, state->uncheckedArgument(0), NormalConversion);
</del><ins>+ auto number = state->argument(0).isUndefined() ? Optional<long long>() : toInt64(state, state->uncheckedArgument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalLongLong(number);
</del><ins>+ impl.methodWithOptionalLongLong(WTFMove(number));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4615,10 +4748,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalLongLongIsZero");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- long long number = toInt64(state, state->argument(0), NormalConversion);
</del><ins>+ auto number = toInt64(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalLongLongIsZero(number);
</del><ins>+ impl.methodWithOptionalLongLongIsZero(WTFMove(number));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4630,10 +4763,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalUnsignedLongLong");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Optional<unsigned long long> number = state->argument(0).isUndefined() ? Optional<unsigned long long>() : toUInt64(state, state->uncheckedArgument(0), NormalConversion);
</del><ins>+ auto number = state->argument(0).isUndefined() ? Optional<unsigned long long>() : toUInt64(state, state->uncheckedArgument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalUnsignedLongLong(number);
</del><ins>+ impl.methodWithOptionalUnsignedLongLong(WTFMove(number));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4645,10 +4778,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalUnsignedLongLongIsZero");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- unsigned long long number = toUInt64(state, state->argument(0), NormalConversion);
</del><ins>+ auto number = toUInt64(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalUnsignedLongLongIsZero(number);
</del><ins>+ impl.methodWithOptionalUnsignedLongLongIsZero(WTFMove(number));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4660,10 +4793,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalArray");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Optional<Vector<String>> array = state->argument(0).isUndefined() ? Optional<Vector<String>>() : toNativeArray<String>(state, state->uncheckedArgument(0));
</del><ins>+ auto array = state->argument(0).isUndefined() ? Optional<Vector<String>>() : toNativeArray<String>(state, state->uncheckedArgument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalArray(array);
</del><ins>+ impl.methodWithOptionalArray(WTFMove(array));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4675,10 +4808,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalArrayIsEmpty");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Vector<String> array = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto array = toNativeArray<String>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalArrayIsEmpty(array);
</del><ins>+ impl.methodWithOptionalArrayIsEmpty(WTFMove(array));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4690,10 +4823,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalBoolean");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Optional<bool> b = state->argument(0).isUndefined() ? Optional<bool>() : state->uncheckedArgument(0).toBoolean(state);
</del><ins>+ auto b = state->argument(0).isUndefined() ? Optional<bool>() : state->uncheckedArgument(0).toBoolean(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalBoolean(b);
</del><ins>+ impl.methodWithOptionalBoolean(WTFMove(b));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4705,10 +4838,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalBooleanIsFalse");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- bool b = state->argument(0).toBoolean(state);
</del><ins>+ auto b = state->argument(0).toBoolean(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithOptionalBooleanIsFalse(b);
</del><ins>+ impl.methodWithOptionalBooleanIsFalse(WTFMove(b));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4720,8 +4853,8 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalAny");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- JSC::JSValue a = state->argument(0);
- impl.methodWithOptionalAny(a);
</del><ins>+ auto a = state->argument(0);
+ impl.methodWithOptionalAny(WTFMove(a));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4733,8 +4866,8 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalNullableWrapper");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* obj = JSTestObj::toWrapped(state->argument(0));
- impl.methodWithOptionalNullableWrapper(obj);
</del><ins>+ auto obj = JSTestObj::toWrapped(state->argument(0));
+ impl.methodWithOptionalNullableWrapper(WTFMove(obj));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4746,8 +4879,8 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "methodWithOptionalNullableWrapperIsNull");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- TestObj* obj = JSTestObj::toWrapped(state->argument(0));
- impl.methodWithOptionalNullableWrapperIsNull(obj);
</del><ins>+ auto obj = JSTestObj::toWrapped(state->argument(0));
+ impl.methodWithOptionalNullableWrapperIsNull(WTFMove(obj));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4778,13 +4911,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int nonCallback = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto nonCallback = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> if (UNLIKELY(!state->argument(1).isObject()))
</span><span class="cx"> return throwArgumentMustBeFunctionError(*state, 1, "callback", "TestObj", "methodWithNonCallbackArgAndCallbackArg");
</span><span class="cx"> RefPtr<TestCallback> callback = JSTestCallback::create(asObject(state->uncheckedArgument(1)), castedThis->globalObject());
</span><del>- impl.methodWithNonCallbackArgAndCallbackArg(nonCallback, WTFMove(callback));
</del><ins>+ impl.methodWithNonCallbackArgAndCallbackArg(WTFMove(nonCallback), WTFMove(callback));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4833,13 +4966,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int nonCallback = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto nonCallback = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> if (UNLIKELY(!state->argument(1).isFunction()))
</span><span class="cx"> return throwArgumentMustBeFunctionError(*state, 1, "callback", "TestObj", "methodWithNonCallbackArgAndCallbackFunctionArg");
</span><span class="cx"> RefPtr<TestCallbackFunction> callback = JSTestCallbackFunction::create(asObject(state->uncheckedArgument(1)), castedThis->globalObject());
</span><del>- impl.methodWithNonCallbackArgAndCallbackFunctionArg(nonCallback, WTFMove(callback));
</del><ins>+ impl.methodWithNonCallbackArgAndCallbackFunctionArg(WTFMove(nonCallback), WTFMove(callback));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4939,11 +5072,11 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(0));
- String strArg = state->argument(1).toWTFString(state);
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(0));
+ auto strArg = state->argument(1).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.overloadedMethod(objArg, strArg);
</del><ins>+ impl.overloadedMethod(WTFMove(objArg), WTFMove(strArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4957,11 +5090,11 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(0));
- Optional<int> longArg = state->argument(1).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(1), NormalConversion);
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(0));
+ auto longArg = state->argument(1).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(1), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.overloadedMethod(objArg, longArg);
</del><ins>+ impl.overloadedMethod(WTFMove(objArg), WTFMove(longArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4975,10 +5108,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String strArg = state->argument(0).toWTFString(state);
</del><ins>+ auto strArg = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.overloadedMethod(strArg);
</del><ins>+ impl.overloadedMethod(WTFMove(strArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4992,10 +5125,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int longArg = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto longArg = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.overloadedMethod(longArg);
</del><ins>+ impl.overloadedMethod(WTFMove(longArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5026,10 +5159,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- RefPtr<DOMStringList> listArg = toDOMStringList(state, state->argument(0));
</del><ins>+ auto listArg = toDOMStringList(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.overloadedMethod(listArg);
</del><ins>+ impl.overloadedMethod(WTFMove(listArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5043,10 +5176,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Vector<String> arrayArg = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<String>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.overloadedMethod(arrayArg);
</del><ins>+ impl.overloadedMethod(WTFMove(arrayArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5060,7 +5193,7 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(0));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(0));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><span class="cx"> impl.overloadedMethod(*objArg);
</span><span class="lines">@@ -5077,10 +5210,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Vector<String> arrayArg = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<String>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.overloadedMethod(arrayArg);
</del><ins>+ impl.overloadedMethod(WTFMove(arrayArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5094,10 +5227,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Vector<unsigned> arrayArg = toNativeArray<unsigned>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<unsigned>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.overloadedMethod(arrayArg);
</del><ins>+ impl.overloadedMethod(WTFMove(arrayArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5111,10 +5244,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String strArg = state->argument(0).toWTFString(state);
</del><ins>+ auto strArg = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.overloadedMethod(strArg);
</del><ins>+ impl.overloadedMethod(WTFMove(strArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5151,7 +5284,7 @@
</span><span class="cx"> return jsTestObjPrototypeFunctionOverloadedMethod4(state);
</span><span class="cx"> if ((argsCount == 1 && (arg0.isNull() || arg0.isObject())))
</span><span class="cx"> return jsTestObjPrototypeFunctionOverloadedMethod5(state);
</span><del>- if ((argsCount == 1 && (arg0.isNull() || (arg0.isObject() && asObject(arg0)->inherits(JSDOMStringList::info())))))
</del><ins>+ if (argsCount == 1)
</ins><span class="cx"> return jsTestObjPrototypeFunctionOverloadedMethod6(state);
</span><span class="cx"> if ((argsCount == 1 && (arg0.isNull() || (arg0.isObject() && isJSArray(arg0)))))
</span><span class="cx"> return jsTestObjPrototypeFunctionOverloadedMethod7(state);
</span><span class="lines">@@ -5180,9 +5313,9 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- TestObj* objArg1 = JSTestObj::toWrapped(state->argument(0));
- TestObj* objArg2 = JSTestObj::toWrapped(state->argument(1));
- impl.overloadedMethodWithOptionalParameter(objArg1, objArg2);
</del><ins>+ auto objArg1 = JSTestObj::toWrapped(state->argument(0));
+ auto objArg2 = JSTestObj::toWrapped(state->argument(1));
+ impl.overloadedMethodWithOptionalParameter(WTFMove(objArg1), WTFMove(objArg2));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5196,11 +5329,11 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(0));
- Optional<int> longArg = state->argument(1).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(1), NormalConversion);
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(0));
+ auto longArg = state->argument(1).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(1), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.overloadedMethodWithOptionalParameter(objArg, longArg);
</del><ins>+ impl.overloadedMethodWithOptionalParameter(WTFMove(objArg), WTFMove(longArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5226,10 +5359,10 @@
</span><span class="cx">
</span><span class="cx"> EncodedJSValue JSC_HOST_CALL jsTestObjConstructorFunctionClassMethodWithOptional(ExecState* state)
</span><span class="cx"> {
</span><del>- Optional<int> arg = state->argument(0).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(0), NormalConversion);
</del><ins>+ auto arg = state->argument(0).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = jsNumber(TestObj::classMethodWithOptional(arg));
</del><ins>+ JSValue result = jsNumber(TestObj::classMethodWithOptional(WTFMove(arg)));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5245,10 +5378,10 @@
</span><span class="cx"> {
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- int arg = toInt32(state, state->argument(0), NormalConversion);
</del><ins>+ auto arg = toInt32(state, state->argument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- TestObj::overloadedMethod1(arg);
</del><ins>+ TestObj::overloadedMethod1(WTFMove(arg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5259,10 +5392,10 @@
</span><span class="cx"> {
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String type = state->argument(0).toWTFString(state);
</del><ins>+ auto type = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- TestObj::overloadedMethod1(type);
</del><ins>+ TestObj::overloadedMethod1(WTFMove(type));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5297,13 +5430,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- uint16_t objArgsShort = toUInt16(state, state->argument(0), Clamp);
</del><ins>+ auto objArgsShort = toUInt16(state, state->argument(0), Clamp);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- unsigned objArgsLong = toUInt32(state, state->argument(1), Clamp);
</del><ins>+ auto objArgsLong = toUInt32(state, state->argument(1), Clamp);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.classMethodWithClamp(objArgsShort, objArgsLong);
</del><ins>+ impl.classMethodWithClamp(WTFMove(objArgsShort), WTFMove(objArgsLong));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5317,13 +5450,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- uint16_t objArgsShort = toUInt16(state, state->argument(0), EnforceRange);
</del><ins>+ auto objArgsShort = toUInt16(state, state->argument(0), EnforceRange);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- unsigned objArgsLong = toUInt32(state, state->argument(1), EnforceRange);
</del><ins>+ auto objArgsLong = toUInt32(state, state->argument(1), EnforceRange);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.classMethodWithEnforceRange(objArgsShort, objArgsLong);
</del><ins>+ impl.classMethodWithEnforceRange(WTFMove(objArgsShort), WTFMove(objArgsLong));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5337,10 +5470,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Vector<unsigned> unsignedLongSequence = toNativeArray<unsigned>(state, state->argument(0));
</del><ins>+ auto unsignedLongSequence = toNativeArray<unsigned>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithUnsignedLongSequence(unsignedLongSequence);
</del><ins>+ impl.methodWithUnsignedLongSequence(WTFMove(unsignedLongSequence));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5355,10 +5488,10 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- Vector<String> values = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto values = toNativeArray<String>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = jsArray(state, castedThis->globalObject(), impl.stringArrayFunction(values, ec));
</del><ins>+ JSValue result = jsArray(state, castedThis->globalObject(), impl.stringArrayFunction(WTFMove(values), ec));
</ins><span class="cx">
</span><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return JSValue::encode(result);
</span><span class="lines">@@ -5375,7 +5508,7 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- RefPtr<DOMStringList> values = toDOMStringList(state, state->argument(0));
</del><ins>+ auto values = toDOMStringList(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> if (UNLIKELY(!values))
</span><span class="lines">@@ -5396,13 +5529,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Vector<unsigned> arrayArg = toNativeArray<unsigned>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<unsigned>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- Vector<unsigned> nullableArrayArg = toNativeArray<unsigned>(state, state->argument(1));
</del><ins>+ auto nullableArrayArg = toNativeArray<unsigned>(state, state->argument(1));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithAndWithoutNullableSequence(arrayArg, nullableArrayArg);
</del><ins>+ impl.methodWithAndWithoutNullableSequence(WTFMove(arrayArg), WTFMove(nullableArrayArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5416,13 +5549,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Vector<unsigned> arrayArg = toNativeArray<unsigned>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<unsigned>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- Vector<unsigned> nullableArrayArg = toNativeArray<unsigned>(state, state->argument(1));
</del><ins>+ auto nullableArrayArg = toNativeArray<unsigned>(state, state->argument(1));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.methodWithAndWithoutNullableSequence2(arrayArg, nullableArrayArg);
</del><ins>+ impl.methodWithAndWithoutNullableSequence2(WTFMove(arrayArg), WTFMove(nullableArrayArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5453,7 +5586,7 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- TestNode* value = JSTestNode::toWrapped(state->argument(0));
</del><ins>+ auto value = JSTestNode::toWrapped(state->argument(0));
</ins><span class="cx"> if (UNLIKELY(!value))
</span><span class="cx"> return throwVMTypeError(state);
</span><span class="cx"> impl.convert1(*value);
</span><span class="lines">@@ -5470,8 +5603,8 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- TestNode* value = JSTestNode::toWrapped(state->argument(0));
- impl.convert2(value);
</del><ins>+ auto value = JSTestNode::toWrapped(state->argument(0));
+ impl.convert2(WTFMove(value));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5485,10 +5618,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String value = state->argument(0).toWTFString(state);
</del><ins>+ auto value = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.convert3(value);
</del><ins>+ impl.convert3(WTFMove(value));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5502,10 +5635,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String value = valueToStringWithUndefinedOrNullCheck(state, state->argument(0));
</del><ins>+ auto value = valueToStringWithUndefinedOrNullCheck(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.convert4(value);
</del><ins>+ impl.convert4(WTFMove(value));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5556,16 +5689,16 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 3))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- String str = state->argument(0).toWTFString(state);
</del><ins>+ auto str = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- float a = state->argument(1).toFloat(state);
</del><ins>+ auto a = state->argument(1).toFloat(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- int b = toInt32(state, state->argument(2), NormalConversion);
</del><ins>+ auto b = toInt32(state, state->argument(2), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.strictFunction(str, a, b, ec)));
</del><ins>+ JSValue result = jsBoolean(impl.strictFunction(WTFMove(str), WTFMove(a), WTFMove(b), ec));
</ins><span class="cx">
</span><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return JSValue::encode(result);
</span><span class="lines">@@ -5584,13 +5717,13 @@
</span><span class="cx"> ExceptionCode ec = 0;
</span><span class="cx"> if (UNLIKELY(!state->argument(0).isUndefinedOrNull() && !state->argument(0).inherits(JSTestObj::info())))
</span><span class="cx"> return throwArgumentTypeError(*state, 0, "objArg", "TestObj", "strictFunctionWithSequence", "TestObj");
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(0));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(0));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- Vector<unsigned> a = toNativeArray<unsigned>(state, state->argument(1));
</del><ins>+ auto a = toNativeArray<unsigned>(state, state->argument(1));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.strictFunctionWithSequence(*objArg, a, ec)));
</del><ins>+ JSValue result = jsBoolean(impl.strictFunctionWithSequence(*objArg, WTFMove(a), ec));
</ins><span class="cx">
</span><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return JSValue::encode(result);
</span><span class="lines">@@ -5609,13 +5742,13 @@
</span><span class="cx"> ExceptionCode ec = 0;
</span><span class="cx"> if (UNLIKELY(!state->argument(0).isUndefinedOrNull() && !state->argument(0).inherits(JSTestObj::info())))
</span><span class="cx"> return throwArgumentTypeError(*state, 0, "objArg", "TestObj", "strictFunctionWithArray", "TestObj");
</span><del>- TestObj* objArg = JSTestObj::toWrapped(state->argument(0));
</del><ins>+ auto objArg = JSTestObj::toWrapped(state->argument(0));
</ins><span class="cx"> if (UNLIKELY(!objArg))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- Vector<int> array = toNativeArray<int>(state, state->argument(1));
</del><ins>+ auto array = toNativeArray<int>(state, state->argument(1));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.strictFunctionWithArray(*objArg, array, ec)));
</del><ins>+ JSValue result = jsBoolean(impl.strictFunctionWithArray(*objArg, WTFMove(array), ec));
</ins><span class="cx">
</span><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return JSValue::encode(result);
</span><span class="lines">@@ -5631,13 +5764,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String head = state->argument(0).toWTFString(state);
</del><ins>+ auto head = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> Vector<String> tail = toNativeArguments<String>(state, 1);
</span><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.variadicStringMethod(head, tail);
</del><ins>+ impl.variadicStringMethod(WTFMove(head), tail);
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5651,13 +5784,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- double head = state->argument(0).toNumber(state);
</del><ins>+ auto head = state->argument(0).toNumber(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> Vector<double> tail = toNativeArguments<double>(state, 1);
</span><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.variadicDoubleMethod(head, tail);
</del><ins>+ impl.variadicDoubleMethod(WTFMove(head), tail);
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5671,7 +5804,7 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Node* head = JSNode::toWrapped(state->argument(0));
</del><ins>+ auto head = JSNode::toWrapped(state->argument(0));
</ins><span class="cx"> if (UNLIKELY(!head))
</span><span class="cx"> return throwVMTypeError(state);
</span><span class="cx"> Vector<Node*> tail;
</span><span class="lines">@@ -5694,13 +5827,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- float a = state->argument(0).toFloat(state);
</del><ins>+ auto a = state->argument(0).toFloat(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- int b = toInt32(state, state->argument(1), NormalConversion);
</del><ins>+ auto b = toInt32(state, state->argument(1), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.any(a, b);
</del><ins>+ impl.any(WTFMove(a), WTFMove(b));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5738,12 +5871,12 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- float a = state->argument(0).toFloat(state);
</del><ins>+ auto a = state->argument(0).toFloat(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> if (UNLIKELY(!std::isfinite(a)))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- impl.testPromiseFunctionWithFloatArgument(a, DeferredWrapper(state, castedThis->globalObject(), promiseDeferred));
</del><ins>+ impl.testPromiseFunctionWithFloatArgument(WTFMove(a), DeferredWrapper(state, castedThis->globalObject(), promiseDeferred));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5781,10 +5914,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestObj", "testPromiseFunctionWithOptionalIntArgument");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Optional<int> a = state->argument(0).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(0), NormalConversion);
</del><ins>+ auto a = state->argument(0).isUndefined() ? Optional<int>() : toInt32(state, state->uncheckedArgument(0), NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.testPromiseFunctionWithOptionalIntArgument(a, DeferredWrapper(state, castedThis->globalObject(), promiseDeferred));
</del><ins>+ impl.testPromiseFunctionWithOptionalIntArgument(WTFMove(a), DeferredWrapper(state, castedThis->globalObject(), promiseDeferred));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5804,12 +5937,12 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- float a = state->argument(0).toFloat(state);
</del><ins>+ auto a = state->argument(0).toFloat(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> if (UNLIKELY(!std::isfinite(a)))
</span><span class="cx"> return throwVMTypeError(state);
</span><del>- impl.testPromiseOverloadedFunction(a, DeferredWrapper(state, castedThis->globalObject(), promiseDeferred));
</del><ins>+ impl.testPromiseOverloadedFunction(WTFMove(a), DeferredWrapper(state, castedThis->globalObject(), promiseDeferred));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -5829,7 +5962,7 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- FetchRequest* request = JSFetchRequest::toWrapped(state->argument(0));
</del><ins>+ auto request = JSFetchRequest::toWrapped(state->argument(0));
</ins><span class="cx"> if (UNLIKELY(!request))
</span><span class="cx"> return throwVMTypeError(state);
</span><span class="cx"> impl.testPromiseOverloadedFunction(*request, DeferredWrapper(state, castedThis->globalObject(), promiseDeferred));
</span><span class="lines">@@ -5890,6 +6023,23 @@
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+EncodedJSValue JSC_HOST_CALL jsTestObjPrototypeFunctionAttachShadowRoot(ExecState* state)
+{
+ JSValue thisValue = state->thisValue();
+ auto castedThis = jsDynamicCast<JSTestObj*>(thisValue);
+ if (UNLIKELY(!castedThis))
+ return throwThisTypeError(*state, "TestObj", "attachShadowRoot");
+ ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestObj::info());
+ auto& impl = castedThis->wrapped();
+ if (UNLIKELY(state->argumentCount() < 1))
+ return throwVMError(state, createNotEnoughArgumentsError(state));
+ auto init = build<TestObj::ShadowRootInit>(*state, state->argument(0));
+ if (UNLIKELY(state->hadException()))
+ return JSValue::encode(jsUndefined());
+ impl.attachShadowRoot(WTFMove(init));
+ return JSValue::encode(jsUndefined());
+}
+
</ins><span class="cx"> using TestObjIterator = JSDOMIterator<JSTestObj>;
</span><span class="cx"> using TestObjIteratorPrototype = JSDOMIteratorPrototype<JSTestObj>;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestOverloadedConstructorscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -70,7 +70,7 @@
</span><span class="cx"> auto* castedThis = jsCast<JSTestOverloadedConstructorsConstructor*>(state->callee());
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- ArrayBuffer* arrayBuffer = toArrayBuffer(state->argument(0));
</del><ins>+ auto arrayBuffer = toArrayBuffer(state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> if (UNLIKELY(!arrayBuffer))
</span><span class="lines">@@ -84,7 +84,7 @@
</span><span class="cx"> auto* castedThis = jsCast<JSTestOverloadedConstructorsConstructor*>(state->callee());
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- RefPtr<ArrayBufferView> arrayBufferView = toArrayBufferView(state->argument(0));
</del><ins>+ auto arrayBufferView = toArrayBufferView(state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> if (UNLIKELY(!arrayBufferView))
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx"> auto* castedThis = jsCast<JSTestOverloadedConstructorsConstructor*>(state->callee());
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Blob* blob = JSBlob::toWrapped(state->argument(0));
</del><ins>+ auto blob = JSBlob::toWrapped(state->argument(0));
</ins><span class="cx"> if (UNLIKELY(!blob))
</span><span class="cx"> return throwVMTypeError(state);
</span><span class="cx"> RefPtr<TestOverloadedConstructors> object = TestOverloadedConstructors::create(*blob);
</span><span class="lines">@@ -110,7 +110,7 @@
</span><span class="cx"> auto* castedThis = jsCast<JSTestOverloadedConstructorsConstructor*>(state->callee());
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String string = state->argument(0).toWTFString(state);
</del><ins>+ auto string = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> RefPtr<TestOverloadedConstructors> object = TestOverloadedConstructors::create(string);
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestOverrideBuiltinscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -200,10 +200,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestOverrideBuiltins", "namedItem");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestOverrideBuiltins::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String name = state->argument(0).isUndefined() ? ASCIILiteral("test") : state->uncheckedArgument(0).toWTFString(state);
</del><ins>+ auto name = state->argument(0).isUndefined() ? ASCIILiteral("test") : state->uncheckedArgument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.namedItem(name)));
</del><ins>+ JSValue result = toJS(state, castedThis->globalObject(), WTF::getPtr(impl.namedItem(WTFMove(name))));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestSerializedScriptValueInterfacecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -243,10 +243,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestSerializedScriptValueInterface", "value");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- RefPtr<SerializedScriptValue> nativeValue = SerializedScriptValue::create(state, value, 0, 0);
</del><ins>+ auto nativeValue = SerializedScriptValue::create(state, value, 0, 0);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setValue(nativeValue);
</del><ins>+ impl.setValue(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -260,10 +260,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestSerializedScriptValueInterface", "cachedValue");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- RefPtr<SerializedScriptValue> nativeValue = SerializedScriptValue::create(state, value, 0, 0);
</del><ins>+ auto nativeValue = SerializedScriptValue::create(state, value, 0, 0);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setCachedValue(nativeValue);
</del><ins>+ impl.setCachedValue(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestJSJSTestTypedefscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -128,7 +128,7 @@
</span><span class="cx"> auto* castedThis = jsCast<JSTestTypedefsConstructor*>(state->callee());
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 2))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- String hello = state->argument(0).toWTFString(state);
</del><ins>+ auto hello = state->argument(0).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> if (UNLIKELY(!state->argument(1).isObject()))
</span><span class="lines">@@ -353,10 +353,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestTypedefs", "unsignedLongLongAttr");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- unsigned long long nativeValue = toUInt64(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toUInt64(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setUnsignedLongLongAttr(nativeValue);
</del><ins>+ impl.setUnsignedLongLongAttr(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -370,10 +370,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestTypedefs", "immutableSerializedScriptValue");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- RefPtr<SerializedScriptValue> nativeValue = SerializedScriptValue::create(state, value, 0, 0);
</del><ins>+ auto nativeValue = SerializedScriptValue::create(state, value, 0, 0);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setImmutableSerializedScriptValue(nativeValue);
</del><ins>+ impl.setImmutableSerializedScriptValue(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -387,10 +387,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestTypedefs", "attrWithGetterException");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setAttrWithGetterException(nativeValue);
</del><ins>+ impl.setAttrWithGetterException(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -405,10 +405,10 @@
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- int nativeValue = toInt32(state, value, NormalConversion);
</del><ins>+ auto nativeValue = toInt32(state, value, NormalConversion);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setAttrWithSetterException(nativeValue, ec);
</del><ins>+ impl.setAttrWithSetterException(WTFMove(nativeValue), ec);
</ins><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -423,10 +423,10 @@
</span><span class="cx"> return throwSetterTypeError(*state, "TestTypedefs", "stringAttrWithGetterException");
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setStringAttrWithGetterException(nativeValue);
</del><ins>+ impl.setStringAttrWithGetterException(WTFMove(nativeValue));
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -441,10 +441,10 @@
</span><span class="cx"> }
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- String nativeValue = value.toWTFString(state);
</del><ins>+ auto nativeValue = value.toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return false;
</span><del>- impl.setStringAttrWithSetterException(nativeValue, ec);
</del><ins>+ impl.setStringAttrWithSetterException(WTFMove(nativeValue), ec);
</ins><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="lines">@@ -463,10 +463,10 @@
</span><span class="cx"> return throwThisTypeError(*state, "TestTypedefs", "func");
</span><span class="cx"> ASSERT_GC_OBJECT_INHERITS(castedThis, JSTestTypedefs::info());
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><del>- Vector<int> x = toNativeArray<int>(state, state->argument(0));
</del><ins>+ auto x = toNativeArray<int>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.func(x);
</del><ins>+ impl.func(WTFMove(x));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -480,22 +480,22 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 3))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- float width = state->argument(0).toFloat(state);
</del><ins>+ auto width = state->argument(0).toFloat(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- float height = state->argument(1).toFloat(state);
</del><ins>+ auto height = state->argument(1).toFloat(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- float blur = state->argument(2).toFloat(state);
</del><ins>+ auto blur = state->argument(2).toFloat(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- String color = state->argument(3).isUndefined() ? String() : state->uncheckedArgument(3).toWTFString(state);
</del><ins>+ auto color = state->argument(3).isUndefined() ? String() : state->uncheckedArgument(3).toWTFString(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- Optional<float> alpha = state->argument(4).isUndefined() ? Optional<float>() : state->uncheckedArgument(4).toFloat(state);
</del><ins>+ auto alpha = state->argument(4).isUndefined() ? Optional<float>() : state->uncheckedArgument(4).toFloat(state);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.setShadow(width, height, blur, color, alpha);
</del><ins>+ impl.setShadow(WTFMove(width), WTFMove(height), WTFMove(blur), WTFMove(color), WTFMove(alpha));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -509,10 +509,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Vector<RefPtr<SerializedScriptValue>> sequenceArg = (toRefPtrNativeArray<SerializedScriptValue, JSSerializedScriptValue>(state, state->argument(0), &JSSerializedScriptValue::toWrapped));
</del><ins>+ auto sequenceArg = (toRefPtrNativeArray<SerializedScriptValue, JSSerializedScriptValue>(state, state->argument(0), &JSSerializedScriptValue::toWrapped));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = jsNumber(impl.methodWithSequenceArg(sequenceArg));
</del><ins>+ JSValue result = jsNumber(impl.methodWithSequenceArg(WTFMove(sequenceArg)));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -526,10 +526,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Vector<String> arrayArg = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto arrayArg = toNativeArray<String>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.nullableArrayArg(arrayArg);
</del><ins>+ impl.nullableArrayArg(WTFMove(arrayArg));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -543,13 +543,13 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- unsigned long long arg1 = toUInt64(state, state->argument(0), Clamp);
</del><ins>+ auto arg1 = toUInt64(state, state->argument(0), Clamp);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- Optional<unsigned long long> arg2 = state->argument(1).isUndefined() ? Optional<unsigned long long>() : toUInt64(state, state->uncheckedArgument(1), Clamp);
</del><ins>+ auto arg2 = state->argument(1).isUndefined() ? Optional<unsigned long long>() : toUInt64(state, state->uncheckedArgument(1), Clamp);
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- impl.funcWithClamp(arg1, arg2);
</del><ins>+ impl.funcWithClamp(WTFMove(arg1), WTFMove(arg2));
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -576,10 +576,10 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- Vector<String> values = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto values = toNativeArray<String>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = jsArray(state, castedThis->globalObject(), impl.stringArrayFunction(values, ec));
</del><ins>+ JSValue result = jsArray(state, castedThis->globalObject(), impl.stringArrayFunction(WTFMove(values), ec));
</ins><span class="cx">
</span><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return JSValue::encode(result);
</span><span class="lines">@@ -596,10 +596,10 @@
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><span class="cx"> ExceptionCode ec = 0;
</span><del>- Vector<String> values = toNativeArray<String>(state, state->argument(0));
</del><ins>+ auto values = toNativeArray<String>(state, state->argument(0));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = jsArray(state, castedThis->globalObject(), impl.stringArrayFunction2(values, ec));
</del><ins>+ JSValue result = jsArray(state, castedThis->globalObject(), impl.stringArrayFunction2(WTFMove(values), ec));
</ins><span class="cx">
</span><span class="cx"> setDOMException(state, ec);
</span><span class="cx"> return JSValue::encode(result);
</span><span class="lines">@@ -615,10 +615,10 @@
</span><span class="cx"> auto& impl = castedThis->wrapped();
</span><span class="cx"> if (UNLIKELY(state->argumentCount() < 1))
</span><span class="cx"> return throwVMError(state, createNotEnoughArgumentsError(state));
</span><del>- Vector<RefPtr<TestEventTarget>> sequenceArg = (toRefPtrNativeArray<TestEventTarget, JSTestEventTarget>(state, state->argument(0), &JSTestEventTarget::toWrapped));
</del><ins>+ auto sequenceArg = (toRefPtrNativeArray<TestEventTarget, JSTestEventTarget>(state, state->argument(0), &JSTestEventTarget::toWrapped));
</ins><span class="cx"> if (UNLIKELY(state->hadException()))
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><del>- JSValue result = jsBoolean(impl.callWithSequenceThatRequiresInclude(sequenceArg));
</del><ins>+ JSValue result = jsBoolean(impl.callWithSequenceThatRequiresInclude(WTFMove(sequenceArg)));
</ins><span class="cx"> return JSValue::encode(result);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestObjCDOMTestObjh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -31,6 +31,7 @@
</span><span class="cx"> @class DOMNode;
</span><span class="cx"> @class DOMSVGDocument;
</span><span class="cx"> @class DOMSVGPoint;
</span><ins>+@class DOMShadowRootInit;
</ins><span class="cx"> @class DOMTestEnumType;
</span><span class="cx"> @class DOMTestNode;
</span><span class="cx"> @class DOMTestObj;
</span><span class="lines">@@ -39,7 +40,6 @@
</span><span class="cx"> @class DOMTestObjectCConstructor;
</span><span class="cx"> @class DOMTestSubObjConstructor;
</span><span class="cx"> @class DOMany;
</span><del>-@class DOMbool;
</del><span class="cx"> @class NSString;
</span><span class="cx"> @protocol DOMEventListener;
</span><span class="cx">
</span><span class="lines">@@ -209,9 +209,10 @@
</span><span class="cx"> - (DOMSVGPoint *)mutablePointFunction;
</span><span class="cx"> - (DOMSVGPoint *)immutablePointFunction;
</span><span class="cx"> - (void)orange;
</span><del>-- (DOMbool *)strictFunction:(NSString *)str a:(float)a b:(int)b;
</del><ins>+- (BOOL)strictFunction:(NSString *)str a:(float)a b:(int)b;
</ins><span class="cx"> - (void)variadicStringMethod:(NSString *)head tail:(NSString *)tail;
</span><span class="cx"> - (void)variadicDoubleMethod:(double)head tail:(double)tail;
</span><span class="cx"> - (void)variadicNodeMethod:(DOMNode *)head tail:(DOMNode *)tail;
</span><span class="cx"> - (void)any:(float)a b:(int)b;
</span><ins>+- (void)attachShadowRoot:(DOMShadowRootInit *)init;
</ins><span class="cx"> @end
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestObjCDOMTestObjmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> #import "DOMNodeInternal.h"
</span><span class="cx"> #import "DOMSVGDocumentInternal.h"
</span><span class="cx"> #import "DOMSVGPointInternal.h"
</span><ins>+#import "DOMShadowRootInitInternal.h"
</ins><span class="cx"> #import "DOMTestEnumTypeInternal.h"
</span><span class="cx"> #import "DOMTestNodeInternal.h"
</span><span class="cx"> #import "DOMTestObjInternal.h"
</span><span class="lines">@@ -42,7 +43,6 @@
</span><span class="cx"> #import "DOMTestObjectCConstructorInternal.h"
</span><span class="cx"> #import "DOMTestSubObjConstructorInternal.h"
</span><span class="cx"> #import "DOManyInternal.h"
</span><del>-#import "DOMboolInternal.h"
</del><span class="cx"> #import "Dictionary.h"
</span><span class="cx"> #import "Document.h"
</span><span class="cx"> #import "EventListener.h"
</span><span class="lines">@@ -54,6 +54,7 @@
</span><span class="cx"> #import "SVGDocument.h"
</span><span class="cx"> #import "SVGPoint.h"
</span><span class="cx"> #import "SerializedScriptValue.h"
</span><ins>+#import "ShadowRootInit.h"
</ins><span class="cx"> #import "TestEnumType.h"
</span><span class="cx"> #import "TestNode.h"
</span><span class="cx"> #import "TestObj.h"
</span><span class="lines">@@ -65,8 +66,6 @@
</span><span class="cx"> #import "URL.h"
</span><span class="cx"> #import "WebCoreObjCExtras.h"
</span><span class="cx"> #import "WebScriptObjectPrivate.h"
</span><del>-#import "any.h"
-#import "bool.h"
</del><span class="cx"> #import <wtf/GetPtr.h>
</span><span class="cx">
</span><span class="cx"> #define IMPL reinterpret_cast<WebCore::TestObj*>(_internal)
</span><span class="lines">@@ -1571,11 +1570,11 @@
</span><span class="cx"> IMPL->banana();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-- (DOMbool *)strictFunction:(NSString *)str a:(float)a b:(int)b
</del><ins>+- (BOOL)strictFunction:(NSString *)str a:(float)a b:(int)b
</ins><span class="cx"> {
</span><span class="cx"> WebCore::JSMainThreadNullState state;
</span><span class="cx"> WebCore::ExceptionCode ec = 0;
</span><del>- DOMbool *result = kit(WTF::getPtr(IMPL->strictFunction(str, a, b, ec)));
</del><ins>+ BOOL result = IMPL->strictFunction(str, a, b, ec);
</ins><span class="cx"> WebCore::raiseOnDOMError(ec);
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="lines">@@ -1606,6 +1605,12 @@
</span><span class="cx"> IMPL->any(a, b);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+- (void)attachShadowRoot:(DOMShadowRootInit *)init
+{
+ WebCore::JSMainThreadNullState state;
+ IMPL->attachShadowRoot(core(init));
+}
+
</ins><span class="cx"> @end
</span><span class="cx">
</span><span class="cx"> WebCore::TestObj* core(DOMTestObj *wrapper)
</span></span></pre></div>
<a id="trunkSourceWebCorebindingsscriptstestTestObjidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/bindings/scripts/test/TestObj.idl (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/bindings/scripts/test/TestObj.idl 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -307,10 +307,10 @@
</span><span class="cx"> [ImplementedAs=blueberry] attribute long strawberry;
</span><span class="cx">
</span><span class="cx"> [StrictTypeChecking] attribute unrestricted float strictFloat;
</span><del>- [StrictTypeChecking, RaisesException] bool strictFunction(DOMString str, unrestricted float a, long b);
</del><ins>+ [StrictTypeChecking, RaisesException] boolean strictFunction(DOMString str, unrestricted float a, long b);
</ins><span class="cx">
</span><del>- [StrictTypeChecking, RaisesException] bool strictFunctionWithSequence(TestObj objArg, sequence<unsigned long> a);
- [StrictTypeChecking, RaisesException] bool strictFunctionWithArray(TestObj objArg, long[] array);
</del><ins>+ [StrictTypeChecking, RaisesException] boolean strictFunctionWithSequence(TestObj objArg, sequence<unsigned long> a);
+ [StrictTypeChecking, RaisesException] boolean strictFunctionWithArray(TestObj objArg, long[] array);
</ins><span class="cx">
</span><span class="cx"> // ObjectiveC reserved words.
</span><span class="cx"> readonly attribute long description;
</span><span class="lines">@@ -370,8 +370,14 @@
</span><span class="cx"> #if defined(TESTING_JS)
</span><span class="cx"> [InvokesCustomElementLifecycleCallbacks] void methodWithNeedsLifecycleProcessingStack();
</span><span class="cx"> #endif
</span><ins>+
+ void attachShadowRoot(ShadowRootInit init);
</ins><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> // The following comment should not generate any code.
</span><span class="cx"> // TestObj implements TestImplements;
</span><span class="cx">
</span><ins>+enum ShadowRootMode { "open", "closed" };
+dictionary ShadowRootInit {
+ required ShadowRootMode mode;
+};
</ins></span></pre></div>
<a id="trunkSourceWebCoredomElementcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.cpp (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.cpp 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/dom/Element.cpp 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -1674,21 +1674,14 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-RefPtr<ShadowRoot> Element::attachShadow(const Dictionary& dictionary, ExceptionCode& ec)
</del><ins>+bool Element::canHaveUserAgentShadowRoot() const
</ins><span class="cx"> {
</span><del>- String mode;
- dictionary.get("mode", mode);
</del><ins>+ return false;
+}
</ins><span class="cx">
</span><del>- auto type = ShadowRoot::Type::Closed;
- if (mode == "open")
- type = ShadowRoot::Type::Open;
- else if (mode != "closed") {
- ec = TypeError;
- return nullptr;
- }
-
- // FIXME: The current spec allows attachShadow on non-HTML elements.
- if (!is<HTMLElement>(this) || downcast<HTMLElement>(this)->canHaveUserAgentShadowRoot()) {
</del><ins>+RefPtr<ShadowRoot> Element::attachShadow(const ShadowRootInit& init, ExceptionCode& ec)
+{
+ if (canHaveUserAgentShadowRoot()) {
</ins><span class="cx"> ec = NOT_SUPPORTED_ERR;
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="lines">@@ -1698,9 +1691,9 @@
</span><span class="cx"> return nullptr;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- addShadowRoot(ShadowRoot::create(document(), type));
-
- return shadowRoot();
</del><ins>+ auto shadow = ShadowRoot::create(document(), init.mode == ShadowRootMode::Open ? ShadowRoot::Type::Open : ShadowRoot::Type::Closed);
+ addShadowRoot(shadow.copyRef());
+ return WTFMove(shadow);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> ShadowRoot* Element::shadowRootForBindings(JSC::ExecState& state) const
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.h (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.h 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/dom/Element.h 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -249,8 +249,13 @@
</span><span class="cx"> WEBCORE_EXPORT ShadowRoot* shadowRoot() const;
</span><span class="cx"> WEBCORE_EXPORT RefPtr<ShadowRoot> createShadowRoot(ExceptionCode&);
</span><span class="cx">
</span><ins>+ enum class ShadowRootMode { Open, Closed };
+ struct ShadowRootInit {
+ ShadowRootMode mode;
+ };
+
</ins><span class="cx"> ShadowRoot* shadowRootForBindings(JSC::ExecState&) const;
</span><del>- RefPtr<ShadowRoot> attachShadow(const Dictionary&, ExceptionCode&);
</del><ins>+ RefPtr<ShadowRoot> attachShadow(const ShadowRootInit&, ExceptionCode&);
</ins><span class="cx">
</span><span class="cx"> ShadowRoot* userAgentShadowRoot() const;
</span><span class="cx"> WEBCORE_EXPORT ShadowRoot& ensureUserAgentShadowRoot();
</span><span class="lines">@@ -585,11 +590,11 @@
</span><span class="cx">
</span><span class="cx"> void cancelFocusAppearanceUpdate();
</span><span class="cx">
</span><del>- // cloneNode is private so that non-virtual cloneElementWithChildren and cloneElementWithoutChildren
- // are used instead.
</del><ins>+ // The cloneNode function is private so that non-virtual cloneElementWith/WithoutChildren are used instead.
</ins><span class="cx"> Ref<Node> cloneNodeInternal(Document&, CloningOperation) override;
</span><span class="cx"> virtual Ref<Element> cloneElementWithoutAttributesAndChildren(Document&);
</span><span class="cx">
</span><ins>+ virtual bool canHaveUserAgentShadowRoot() const;
</ins><span class="cx"> void removeShadowRoot();
</span><span class="cx">
</span><span class="cx"> const RenderStyle* existingComputedStyle();
</span></span></pre></div>
<a id="trunkSourceWebCoredomElementidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Element.idl (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Element.idl 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/dom/Element.idl 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -185,7 +185,7 @@
</span><span class="cx">
</span><span class="cx"> // Shadow DOM API
</span><span class="cx"> #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
</span><del>- [Conditional=SHADOW_DOM, EnabledAtRuntime=ShadowDOM, RaisesException] ShadowRoot attachShadow(Dictionary options);
</del><ins>+ [Conditional=SHADOW_DOM, EnabledAtRuntime=ShadowDOM, RaisesException] ShadowRoot attachShadow(ShadowRootInit init);
</ins><span class="cx"> [Conditional=SHADOW_DOM, EnabledAtRuntime=ShadowDOM, ImplementedAs=shadowRootForBindings, CallWith=ScriptState] readonly attribute ShadowRoot shadowRoot;
</span><span class="cx"> [Conditional=SHADOW_DOM, EnabledAtRuntime=ShadowDOM, Reflect] attribute DOMString slot;
</span><span class="cx"> #endif
</span><span class="lines">@@ -233,6 +233,12 @@
</span><span class="cx"> [NotEnumerable, Conditional=WIRELESS_PLAYBACK_TARGET] attribute EventHandler onwebkitplaybacktargetavailabilitychanged;
</span><span class="cx"> };
</span><span class="cx">
</span><ins>+enum ShadowRootMode { "open", "closed" };
+
+dictionary ShadowRootInit {
+ required ShadowRootMode mode;
+};
+
</ins><span class="cx"> Element implements ChildNode;
</span><span class="cx"> Element implements ParentNode;
</span><span class="cx"> Element implements NonDocumentTypeChildNode;
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLElementh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLElement.h (200447 => 200448)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLElement.h 2016-05-05 01:06:59 UTC (rev 200447)
+++ trunk/Source/WebCore/html/HTMLElement.h 2016-05-05 03:09:41 UTC (rev 200448)
</span><span class="lines">@@ -89,7 +89,6 @@
</span><span class="cx">
</span><span class="cx"> virtual bool isHTMLUnknownElement() const { return false; }
</span><span class="cx"> virtual bool isTextControlInnerTextElement() const { return false; }
</span><del>- virtual bool canHaveUserAgentShadowRoot() const { return false; }
</del><span class="cx">
</span><span class="cx"> bool willRespondToMouseMoveEvents() override;
</span><span class="cx"> bool willRespondToMouseWheelEvents() override;
</span></span></pre>
</div>
</div>
</body>
</html>