<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200404] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200404">200404</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-05-03 18:54:39 -0700 (Tue, 03 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Simplify console.clear
https://bugs.webkit.org/show_bug.cgi?id=157316
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-05-03
Reviewed by Timothy Hatcher.
* inspector/ScriptArguments.cpp:
(Inspector::ScriptArguments::createEmpty):
(Inspector::ScriptArguments::ScriptArguments):
* inspector/ScriptArguments.h:
Provide a way to create an empty list.
* runtime/ConsoleClient.cpp:
(JSC::ConsoleClient::clear):
* runtime/ConsoleClient.h:
Drop unnecessary parameter.
* runtime/ConsoleObject.cpp:
(JSC::consoleProtoFuncClear):
No need to parse arguments.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorScriptArgumentscpp">trunk/Source/JavaScriptCore/inspector/ScriptArguments.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorScriptArgumentsh">trunk/Source/JavaScriptCore/inspector/ScriptArguments.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeConsoleClientcpp">trunk/Source/JavaScriptCore/runtime/ConsoleClient.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeConsoleClienth">trunk/Source/JavaScriptCore/runtime/ConsoleClient.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeConsoleObjectcpp">trunk/Source/JavaScriptCore/runtime/ConsoleObject.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (200403 => 200404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-05-04 01:46:30 UTC (rev 200403)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-05-04 01:54:39 UTC (rev 200404)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-05-03 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Simplify console.clear
+ https://bugs.webkit.org/show_bug.cgi?id=157316
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/ScriptArguments.cpp:
+ (Inspector::ScriptArguments::createEmpty):
+ (Inspector::ScriptArguments::ScriptArguments):
+ * inspector/ScriptArguments.h:
+ Provide a way to create an empty list.
+
+ * runtime/ConsoleClient.cpp:
+ (JSC::ConsoleClient::clear):
+ * runtime/ConsoleClient.h:
+ Drop unnecessary parameter.
+
+ * runtime/ConsoleObject.cpp:
+ (JSC::consoleProtoFuncClear):
+ No need to parse arguments.
+
</ins><span class="cx"> 2016-05-03 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> Improve Symbol() to string coercion error message
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorScriptArgumentscpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/ScriptArguments.cpp (200403 => 200404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/ScriptArguments.cpp 2016-05-04 01:46:30 UTC (rev 200403)
+++ trunk/Source/JavaScriptCore/inspector/ScriptArguments.cpp 2016-05-04 01:54:39 UTC (rev 200404)
</span><span class="lines">@@ -42,6 +42,16 @@
</span><span class="cx"> return adoptRef(*new ScriptArguments(scriptState, arguments));
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+Ref<ScriptArguments> ScriptArguments::createEmpty(JSC::ExecState* scriptState)
+{
+ return adoptRef(*new ScriptArguments(scriptState));
+}
+
+ScriptArguments::ScriptArguments(JSC::ExecState* execState)
+ : m_globalObject(execState->vm(), execState->lexicalGlobalObject())
+{
+}
+
</ins><span class="cx"> ScriptArguments::ScriptArguments(JSC::ExecState* execState, Vector<Deprecated::ScriptValue>& arguments)
</span><span class="cx"> : m_globalObject(execState->vm(), execState->lexicalGlobalObject())
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorScriptArgumentsh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/ScriptArguments.h (200403 => 200404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/ScriptArguments.h 2016-05-04 01:46:30 UTC (rev 200403)
+++ trunk/Source/JavaScriptCore/inspector/ScriptArguments.h 2016-05-04 01:54:39 UTC (rev 200404)
</span><span class="lines">@@ -52,6 +52,7 @@
</span><span class="cx"> class JS_EXPORT_PRIVATE ScriptArguments : public RefCounted<ScriptArguments> {
</span><span class="cx"> public:
</span><span class="cx"> static Ref<ScriptArguments> create(JSC::ExecState*, Vector<Deprecated::ScriptValue>& arguments);
</span><ins>+ static Ref<ScriptArguments> createEmpty(JSC::ExecState*);
</ins><span class="cx"> ~ScriptArguments();
</span><span class="cx">
</span><span class="cx"> const Deprecated::ScriptValue& argumentAt(size_t) const;
</span><span class="lines">@@ -63,6 +64,7 @@
</span><span class="cx"> bool isEqual(ScriptArguments*) const;
</span><span class="cx">
</span><span class="cx"> private:
</span><ins>+ ScriptArguments(JSC::ExecState*);
</ins><span class="cx"> ScriptArguments(JSC::ExecState*, Vector<Deprecated::ScriptValue>& arguments);
</span><span class="cx">
</span><span class="cx"> JSC::Strong<JSC::JSGlobalObject> m_globalObject;
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeConsoleClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ConsoleClient.cpp (200403 => 200404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ConsoleClient.cpp 2016-05-04 01:46:30 UTC (rev 200403)
+++ trunk/Source/JavaScriptCore/runtime/ConsoleClient.cpp 2016-05-04 01:54:39 UTC (rev 200404)
</span><span class="lines">@@ -203,9 +203,9 @@
</span><span class="cx"> internalMessageWithTypeAndLevel(MessageType::Log, level, exec, WTFMove(arguments), ArgumentRequired);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ConsoleClient::clear(ExecState* exec, RefPtr<ScriptArguments>&& arguments)
</del><ins>+void ConsoleClient::clear(ExecState* exec)
</ins><span class="cx"> {
</span><del>- internalMessageWithTypeAndLevel(MessageType::Clear, MessageLevel::Log, exec, WTFMove(arguments), ArgumentNotRequired);
</del><ins>+ internalMessageWithTypeAndLevel(MessageType::Clear, MessageLevel::Log, exec, ScriptArguments::createEmpty(exec), ArgumentNotRequired);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void ConsoleClient::dir(ExecState* exec, RefPtr<ScriptArguments>&& arguments)
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeConsoleClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ConsoleClient.h (200403 => 200404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ConsoleClient.h 2016-05-04 01:46:30 UTC (rev 200403)
+++ trunk/Source/JavaScriptCore/runtime/ConsoleClient.h 2016-05-04 01:54:39 UTC (rev 200404)
</span><span class="lines">@@ -45,7 +45,7 @@
</span><span class="cx"> JS_EXPORT_PRIVATE static void printConsoleMessageWithArguments(MessageSource, MessageType, MessageLevel, JSC::ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span><span class="cx">
</span><span class="cx"> void logWithLevel(ExecState*, RefPtr<Inspector::ScriptArguments>&&, MessageLevel);
</span><del>- void clear(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</del><ins>+ void clear(ExecState*);
</ins><span class="cx"> void dir(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span><span class="cx"> void dirXML(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span><span class="cx"> void table(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeConsoleObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ConsoleObject.cpp (200403 => 200404)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ConsoleObject.cpp 2016-05-04 01:46:30 UTC (rev 200403)
+++ trunk/Source/JavaScriptCore/runtime/ConsoleObject.cpp 2016-05-04 01:54:39 UTC (rev 200404)
</span><span class="lines">@@ -146,8 +146,7 @@
</span><span class="cx"> if (!client)
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx">
</span><del>- RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 0));
- client->clear(exec, WTFMove(arguments));
</del><ins>+ client->clear(exec);
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>