<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200371] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200371">200371</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-05-03 08:24:36 -0700 (Tue, 03 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: console.assert should do far less work when the assertion is true
https://bugs.webkit.org/show_bug.cgi?id=157297
<rdar://problem/26056556>
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-05-03
Reviewed by Timothy Hatcher.
* runtime/ConsoleClient.h:
* runtime/ConsoleClient.cpp:
(JSC::ConsoleClient::assertion):
(JSC::ConsoleClient::assertCondition): Deleted.
Rename, now that this will only get called when the assertion failed.
* runtime/ConsoleObject.cpp:
(JSC::consoleProtoFuncAssert):
Avoid doing any work if the assertion succeeded.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeConsoleClientcpp">trunk/Source/JavaScriptCore/runtime/ConsoleClient.cpp</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeConsoleClienth">trunk/Source/JavaScriptCore/runtime/ConsoleClient.h</a></li>
<li><a href="#trunkSourceJavaScriptCoreruntimeConsoleObjectcpp">trunk/Source/JavaScriptCore/runtime/ConsoleObject.cpp</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (200370 => 200371)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-05-03 15:23:53 UTC (rev 200370)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-05-03 15:24:36 UTC (rev 200371)
</span><span class="lines">@@ -1,5 +1,23 @@
</span><span class="cx"> 2016-05-03 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: console.assert should do far less work when the assertion is true
+ https://bugs.webkit.org/show_bug.cgi?id=157297
+ <rdar://problem/26056556>
+
+ Reviewed by Timothy Hatcher.
+
+ * runtime/ConsoleClient.h:
+ * runtime/ConsoleClient.cpp:
+ (JSC::ConsoleClient::assertion):
+ (JSC::ConsoleClient::assertCondition): Deleted.
+ Rename, now that this will only get called when the assertion failed.
+
+ * runtime/ConsoleObject.cpp:
+ (JSC::consoleProtoFuncAssert):
+ Avoid doing any work if the assertion succeeded.
+
+2016-05-03 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Unreviewed follow-up testapi fix after r200355.
</span><span class="cx">
</span><span class="cx"> * runtime/JSGlobalObject.cpp:
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeConsoleClientcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ConsoleClient.cpp (200370 => 200371)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ConsoleClient.cpp 2016-05-03 15:23:53 UTC (rev 200370)
+++ trunk/Source/JavaScriptCore/runtime/ConsoleClient.cpp 2016-05-03 15:24:36 UTC (rev 200371)
</span><span class="lines">@@ -228,11 +228,8 @@
</span><span class="cx"> internalMessageWithTypeAndLevel(MessageType::Trace, MessageLevel::Log, exec, WTFMove(arguments), ArgumentNotRequired);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void ConsoleClient::assertCondition(ExecState* exec, RefPtr<ScriptArguments>&& arguments, bool condition)
</del><ins>+void ConsoleClient::assertion(ExecState* exec, RefPtr<ScriptArguments>&& arguments)
</ins><span class="cx"> {
</span><del>- if (condition)
- return;
-
</del><span class="cx"> internalMessageWithTypeAndLevel(MessageType::Assert, MessageLevel::Error, exec, WTFMove(arguments), ArgumentNotRequired);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeConsoleClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ConsoleClient.h (200370 => 200371)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ConsoleClient.h 2016-05-03 15:23:53 UTC (rev 200370)
+++ trunk/Source/JavaScriptCore/runtime/ConsoleClient.h 2016-05-03 15:24:36 UTC (rev 200371)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> void dirXML(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span><span class="cx"> void table(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span><span class="cx"> void trace(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span><del>- void assertCondition(ExecState*, RefPtr<Inspector::ScriptArguments>&&, bool condition);
</del><ins>+ void assertion(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</ins><span class="cx"> void group(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span><span class="cx"> void groupCollapsed(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span><span class="cx"> void groupEnd(ExecState*, RefPtr<Inspector::ScriptArguments>&&);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreruntimeConsoleObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/runtime/ConsoleObject.cpp (200370 => 200371)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/runtime/ConsoleObject.cpp 2016-05-03 15:23:53 UTC (rev 200370)
+++ trunk/Source/JavaScriptCore/runtime/ConsoleObject.cpp 2016-05-03 15:24:36 UTC (rev 200371)
</span><span class="lines">@@ -201,12 +201,15 @@
</span><span class="cx"> if (!client)
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx">
</span><del>- bool condition(exec->argument(0).toBoolean(exec));
</del><ins>+ bool condition = exec->argument(0).toBoolean(exec);
</ins><span class="cx"> if (exec->hadException())
</span><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx">
</span><ins>+ if (condition)
+ return JSValue::encode(jsUndefined());
+
</ins><span class="cx"> RefPtr<Inspector::ScriptArguments> arguments(Inspector::createScriptArguments(exec, 1));
</span><del>- client->assertCondition(exec, arguments.release(), condition);
</del><ins>+ client->assertion(exec, arguments.release());
</ins><span class="cx"> return JSValue::encode(jsUndefined());
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>