<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200373] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200373">200373</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-05-03 08:39:28 -0700 (Tue, 03 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Update window.console function API description strings in Console
https://bugs.webkit.org/show_bug.cgi?id=157298
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-05-03
Reviewed by Timothy Hatcher.
* UserInterface/Models/NativeFunctionParameters.js:
* UserInterface/Views/ObjectTreePropertyTreeElement.js:
(WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
The Console object changed how it works. Work with the new
structure, and the older structure for legacy backends.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceModelsNativeFunctionParametersjs">trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsObjectTreePropertyTreeElementjs">trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (200372 => 200373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-05-03 15:30:52 UTC (rev 200372)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-05-03 15:39:28 UTC (rev 200373)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2016-05-03 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Update window.console function API description strings in Console
+ https://bugs.webkit.org/show_bug.cgi?id=157298
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Models/NativeFunctionParameters.js:
+ * UserInterface/Views/ObjectTreePropertyTreeElement.js:
+ (WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
+ The Console object changed how it works. Work with the new
+ structure, and the older structure for legacy backends.
+
+2016-05-03 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Allow format specifiers in console.assert and console.trace
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=157295
</span><span class="cx"> <rdar://problem/26056039>
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceModelsNativeFunctionParametersjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js (200372 => 200373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2016-05-03 15:30:52 UTC (rev 200372)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2016-05-03 15:39:28 UTC (rev 200373)
</span><span class="lines">@@ -160,6 +160,29 @@
</span><span class="cx"> __proto__: null,
</span><span class="cx"> },
</span><span class="cx">
</span><ins>+ Console: {
+ assert: "condition, [message], [...values]",
+ count: "[label]",
+ debug: "message, [...values]",
+ dir: "object",
+ dirxml: "object",
+ error: "message, [...values]",
+ group: "[name]",
+ groupCollapsed: "[name]",
+ groupEnd: "[name]",
+ info: "message, [...values]",
+ log: "message, [...values]",
+ profile: "name",
+ profileEnd: "name",
+ table: "data, [columns]",
+ time: "name",
+ timeEnd: "name",
+ timeStamp: "[label]",
+ trace: "message, [...values]",
+ warn: "message, [...values]",
+ __proto__: null,
+ },
+
</ins><span class="cx"> // Autogenerated DOM Interface static methods.
</span><span class="cx">
</span><span class="cx"> IDBKeyRangeConstructor: {
</span><span class="lines">@@ -370,29 +393,6 @@
</span><span class="cx"> __proto__: null,
</span><span class="cx"> },
</span><span class="cx">
</span><del>- Console: {
- assert: "condition, [message], [...values]",
- count: "[label]",
- debug: "message, [...values]",
- dir: "object",
- dirxml: "object",
- error: "message, [...values]",
- group: "[name]",
- groupCollapsed: "[name]",
- groupEnd: "[name]",
- info: "message, [...values]",
- log: "message, [...values]",
- profile: "name",
- profileEnd: "name",
- table: "data, [columns]",
- time: "name",
- timeEnd: "name",
- timeStamp: "[label]",
- trace: "message, [...values]",
- warn: "message, [...values]",
- __proto__: null,
- },
-
</del><span class="cx"> // Curated DOM Interfaces.
</span><span class="cx">
</span><span class="cx"> Element: {
</span><span class="lines">@@ -2187,4 +2187,9 @@
</span><span class="cx"> Object.assign(WebInspector.NativePrototypeFunctionParameters.Element, ParentNode);
</span><span class="cx"> Object.assign(WebInspector.NativePrototypeFunctionParameters.Document, ParentNode);
</span><span class="cx"> Object.assign(WebInspector.NativePrototypeFunctionParameters.DocumentFragment, ParentNode);
</span><ins>+
+ // COMPATIBILITY (iOS 9): window.console used to be a Console object instance,
+ // now it is just a namespace object on the global object.
+ WebInspector.NativePrototypeFunctionParameters.Console = WebInspector.NativeConstructorFunctionParameters.Console;
+
</ins><span class="cx"> })();
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsObjectTreePropertyTreeElementjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js (200372 => 200373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js 2016-05-03 15:30:52 UTC (rev 200372)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js 2016-05-03 15:39:28 UTC (rev 200373)
</span><span class="lines">@@ -272,7 +272,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Native DOM constructor or on native objects that are not functions.
</span><del>- if (parentDescription.endsWith("Constructor") || parentDescription === "Math" || parentDescription === "JSON" || parentDescription === "Reflect") {
</del><ins>+ if (parentDescription.endsWith("Constructor") || ["Math", "JSON", "Reflect", "Console"].includes(parentDescription)) {
</ins><span class="cx"> var name = parentDescription;
</span><span class="cx"> if (WebInspector.NativeConstructorFunctionParameters[name]) {
</span><span class="cx"> var params = WebInspector.NativeConstructorFunctionParameters[name][this._property.name];
</span></span></pre>
</div>
</div>
</body>
</html>