<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200352] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200352">200352</a></dd>
<dt>Author</dt> <dd>beidson@apple.com</dd>
<dt>Date</dt> <dd>2016-05-02 18:01:53 -0700 (Mon, 02 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Const-ify some IDB code.
https://bugs.webkit.org/show_bug.cgi?id=157287
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Refactor only).
* Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
* Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::deleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::abortTransaction):
(WebCore::InProcessIDBServer::commitTransaction):
(WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):
* Modules/indexeddb/shared/InProcessIDBServer.h:
Source/WebKit2:
* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::deleteDatabase):
(WebKit::WebIDBConnectionToServer::openDatabase):
(WebKit::WebIDBConnectionToServer::abortTransaction):
(WebKit::WebIDBConnectionToServer::commitTransaction):
(WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbclientIDBConnectionToServerDelegateh">trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbsharedInProcessIDBServercpp">trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp</a></li>
<li><a href="#trunkSourceWebCoreModulesindexeddbsharedInProcessIDBServerh">trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2WebProcessDatabasesIndexedDBWebIDBConnectionToServercpp">trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp</a></li>
<li><a href="#trunkSourceWebKit2WebProcessDatabasesIndexedDBWebIDBConnectionToServerh">trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (200351 => 200352)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebCore/ChangeLog 2016-05-03 01:01:53 UTC (rev 200352)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-05-02 Brady Eidson <beidson@apple.com>
+
+ Const-ify some IDB code.
+ https://bugs.webkit.org/show_bug.cgi?id=157287
+
+ Reviewed by Alex Christensen.
+
+ No new tests (Refactor only).
+
+ * Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
+ * Modules/indexeddb/shared/InProcessIDBServer.cpp:
+ (WebCore::InProcessIDBServer::deleteDatabase):
+ (WebCore::InProcessIDBServer::openDatabase):
+ (WebCore::InProcessIDBServer::abortTransaction):
+ (WebCore::InProcessIDBServer::commitTransaction):
+ (WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):
+ * Modules/indexeddb/shared/InProcessIDBServer.h:
+
</ins><span class="cx"> 2016-05-02 Antti Koivisto <antti@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r199964): Animation on pseudo elements doesn't trigger if first frame matches the current style
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbclientIDBConnectionToServerDelegateh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h (200351 => 200352)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h 2016-05-03 01:01:53 UTC (rev 200352)
</span><span class="lines">@@ -57,11 +57,11 @@
</span><span class="cx"> virtual ~IDBConnectionToServerDelegate() { }
</span><span class="cx">
</span><span class="cx"> virtual uint64_t identifier() const = 0;
</span><del>- virtual void deleteDatabase(IDBRequestData&) = 0;
- virtual void openDatabase(IDBRequestData&) = 0;
- virtual void abortTransaction(IDBResourceIdentifier&) = 0;
- virtual void commitTransaction(IDBResourceIdentifier&) = 0;
- virtual void didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier&) = 0;
</del><ins>+ virtual void deleteDatabase(const IDBRequestData&) = 0;
+ virtual void openDatabase(const IDBRequestData&) = 0;
+ virtual void abortTransaction(const IDBResourceIdentifier&) = 0;
+ virtual void commitTransaction(const IDBResourceIdentifier&) = 0;
+ virtual void didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier&) = 0;
</ins><span class="cx"> virtual void createObjectStore(const IDBRequestData&, const IDBObjectStoreInfo&) = 0;
</span><span class="cx"> virtual void deleteObjectStore(const IDBRequestData&, const String& objectStoreName) = 0;
</span><span class="cx"> virtual void clearObjectStore(const IDBRequestData&, uint64_t objectStoreIdentifier) = 0;
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbsharedInProcessIDBServercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp (200351 => 200352)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp 2016-05-03 01:01:53 UTC (rev 200352)
</span><span class="lines">@@ -89,7 +89,7 @@
</span><span class="cx"> return *m_connectionToClient;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InProcessIDBServer::deleteDatabase(IDBRequestData& requestData)
</del><ins>+void InProcessIDBServer::deleteDatabase(const IDBRequestData& requestData)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<InProcessIDBServer> self(this);
</span><span class="cx"> RunLoop::current().dispatch([this, self, requestData] {
</span><span class="lines">@@ -105,7 +105,7 @@
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InProcessIDBServer::openDatabase(IDBRequestData& requestData)
</del><ins>+void InProcessIDBServer::openDatabase(const IDBRequestData& requestData)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<InProcessIDBServer> self(this);
</span><span class="cx"> RunLoop::current().dispatch([this, self, requestData] {
</span><span class="lines">@@ -225,7 +225,7 @@
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InProcessIDBServer::abortTransaction(IDBResourceIdentifier& resourceIdentifier)
</del><ins>+void InProcessIDBServer::abortTransaction(const IDBResourceIdentifier& resourceIdentifier)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<InProcessIDBServer> self(this);
</span><span class="cx"> RunLoop::current().dispatch([this, self, resourceIdentifier] {
</span><span class="lines">@@ -233,7 +233,7 @@
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InProcessIDBServer::commitTransaction(IDBResourceIdentifier& resourceIdentifier)
</del><ins>+void InProcessIDBServer::commitTransaction(const IDBResourceIdentifier& resourceIdentifier)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<InProcessIDBServer> self(this);
</span><span class="cx"> RunLoop::current().dispatch([this, self, resourceIdentifier] {
</span><span class="lines">@@ -241,7 +241,7 @@
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void InProcessIDBServer::didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier& transactionIdentifier)
</del><ins>+void InProcessIDBServer::didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier& transactionIdentifier)
</ins><span class="cx"> {
</span><span class="cx"> RefPtr<InProcessIDBServer> self(this);
</span><span class="cx"> RunLoop::current().dispatch([this, self, transactionIdentifier] {
</span></span></pre></div>
<a id="trunkSourceWebCoreModulesindexeddbsharedInProcessIDBServerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h (200351 => 200352)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h 2016-05-03 01:01:53 UTC (rev 200352)
</span><span class="lines">@@ -55,11 +55,11 @@
</span><span class="cx"> IDBServer::IDBConnectionToClient& connectionToClient() const;
</span><span class="cx">
</span><span class="cx"> // IDBConnectionToServer
</span><del>- void deleteDatabase(IDBRequestData&) final;
- void openDatabase(IDBRequestData&) final;
- void abortTransaction(IDBResourceIdentifier&) final;
- void commitTransaction(IDBResourceIdentifier&) final;
- void didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier&) final;
</del><ins>+ void deleteDatabase(const IDBRequestData&) final;
+ void openDatabase(const IDBRequestData&) final;
+ void abortTransaction(const IDBResourceIdentifier&) final;
+ void commitTransaction(const IDBResourceIdentifier&) final;
+ void didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier&) final;
</ins><span class="cx"> void createObjectStore(const IDBRequestData&, const IDBObjectStoreInfo&) final;
</span><span class="cx"> void deleteObjectStore(const IDBRequestData&, const String& objectStoreName) final;
</span><span class="cx"> void clearObjectStore(const IDBRequestData&, uint64_t objectStoreIdentifier) final;
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (200351 => 200352)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebKit2/ChangeLog 2016-05-03 01:01:53 UTC (rev 200352)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-05-02 Brady Eidson <beidson@apple.com>
+
+ Const-ify some IDB code.
+ https://bugs.webkit.org/show_bug.cgi?id=157287
+
+ Reviewed by Alex Christensen.
+
+ * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
+ (WebKit::WebIDBConnectionToServer::deleteDatabase):
+ (WebKit::WebIDBConnectionToServer::openDatabase):
+ (WebKit::WebIDBConnectionToServer::abortTransaction):
+ (WebKit::WebIDBConnectionToServer::commitTransaction):
+ (WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
+ * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
+
</ins><span class="cx"> 2016-05-02 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Sort the project file.
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessDatabasesIndexedDBWebIDBConnectionToServercpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp (200351 => 200352)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp 2016-05-03 01:01:53 UTC (rev 200352)
</span><span class="lines">@@ -81,27 +81,27 @@
</span><span class="cx"> return *m_connectionToServer;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebIDBConnectionToServer::deleteDatabase(IDBRequestData& requestData)
</del><ins>+void WebIDBConnectionToServer::deleteDatabase(const IDBRequestData& requestData)
</ins><span class="cx"> {
</span><span class="cx"> send(Messages::WebIDBConnectionToClient::DeleteDatabase(requestData));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebIDBConnectionToServer::openDatabase(IDBRequestData& requestData)
</del><ins>+void WebIDBConnectionToServer::openDatabase(const IDBRequestData& requestData)
</ins><span class="cx"> {
</span><span class="cx"> send(Messages::WebIDBConnectionToClient::OpenDatabase(requestData));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebIDBConnectionToServer::abortTransaction(IDBResourceIdentifier& transactionIdentifier)
</del><ins>+void WebIDBConnectionToServer::abortTransaction(const IDBResourceIdentifier& transactionIdentifier)
</ins><span class="cx"> {
</span><span class="cx"> send(Messages::WebIDBConnectionToClient::AbortTransaction(transactionIdentifier));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebIDBConnectionToServer::commitTransaction(IDBResourceIdentifier& transactionIdentifier)
</del><ins>+void WebIDBConnectionToServer::commitTransaction(const IDBResourceIdentifier& transactionIdentifier)
</ins><span class="cx"> {
</span><span class="cx"> send(Messages::WebIDBConnectionToClient::CommitTransaction(transactionIdentifier));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier& transactionIdentifier)
</del><ins>+void WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier& transactionIdentifier)
</ins><span class="cx"> {
</span><span class="cx"> send(Messages::WebIDBConnectionToClient::DidFinishHandlingVersionChangeTransaction(transactionIdentifier));
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2WebProcessDatabasesIndexedDBWebIDBConnectionToServerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h (200351 => 200352)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h 2016-05-03 00:51:39 UTC (rev 200351)
+++ trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h 2016-05-03 01:01:53 UTC (rev 200352)
</span><span class="lines">@@ -45,11 +45,11 @@
</span><span class="cx"> uint64_t messageSenderDestinationID() final { return m_identifier; }
</span><span class="cx">
</span><span class="cx"> // IDBConnectionToServerDelegate
</span><del>- void deleteDatabase(WebCore::IDBRequestData&) final;
- void openDatabase(WebCore::IDBRequestData&) final;
- void abortTransaction(WebCore::IDBResourceIdentifier&) final;
- void commitTransaction(WebCore::IDBResourceIdentifier&) final;
- void didFinishHandlingVersionChangeTransaction(WebCore::IDBResourceIdentifier&) final;
</del><ins>+ void deleteDatabase(const WebCore::IDBRequestData&) final;
+ void openDatabase(const WebCore::IDBRequestData&) final;
+ void abortTransaction(const WebCore::IDBResourceIdentifier&) final;
+ void commitTransaction(const WebCore::IDBResourceIdentifier&) final;
+ void didFinishHandlingVersionChangeTransaction(const WebCore::IDBResourceIdentifier&) final;
</ins><span class="cx"> void createObjectStore(const WebCore::IDBRequestData&, const WebCore::IDBObjectStoreInfo&) final;
</span><span class="cx"> void deleteObjectStore(const WebCore::IDBRequestData&, const String& objectStoreName) final;
</span><span class="cx"> void clearObjectStore(const WebCore::IDBRequestData&, uint64_t objectStoreIdentifier) final;
</span></span></pre>
</div>
</div>
</body>
</html>