<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200339] trunk/Tools</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200339">200339</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-05-02 14:42:07 -0700 (Mon, 02 May 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add fail-fast option to run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=157270
Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2016-05-02
Reviewed by Geoffrey Garen.
* Scripts/run-javascriptcore-tests: Add fail-fast command line option.
Defaults to yes, which is the current behavior.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptsrunjavascriptcoretests">trunk/Tools/Scripts/run-javascriptcore-tests</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (200338 => 200339)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-05-02 21:20:15 UTC (rev 200338)
+++ trunk/Tools/ChangeLog 2016-05-02 21:42:07 UTC (rev 200339)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-05-02 Srinivasan Vijayaraghavan <svijayaraghavan@apple.com>
+
+ Add fail-fast option to run-javascriptcore-tests
+ https://bugs.webkit.org/show_bug.cgi?id=157270
+
+ Reviewed by Geoffrey Garen.
+
+ * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
+ Defaults to yes, which is the current behavior.
+
</ins><span class="cx"> 2016-05-02 Carlos Alberto Lopez Perez <clopez@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
</span></span></pre></div>
<a id="trunkToolsScriptsrunjavascriptcoretests"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/run-javascriptcore-tests (200338 => 200339)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/run-javascriptcore-tests 2016-05-02 21:20:15 UTC (rev 200338)
+++ trunk/Tools/Scripts/run-javascriptcore-tests 2016-05-02 21:42:07 UTC (rev 200339)
</span><span class="lines">@@ -67,6 +67,7 @@
</span><span class="cx"> my $enableFTL = isAppleMacWebKit() || isX86_64() && (isGtk() || isEfl());
</span><span class="cx"> my $createTarball = 0;
</span><span class="cx"> my $remoteHost = 0;
</span><ins>+my $failFast = 1;
</ins><span class="cx"> my $remoteConfigFile;
</span><span class="cx"> my $jsonFileName;
</span><span class="cx">
</span><span class="lines">@@ -76,6 +77,7 @@
</span><span class="cx"> my $jscStressDefault = $runJSCStress ? "will run" : " will not run";
</span><span class="cx"> my $jitStressTestsDefault = $runJITStressTests ? "will run" : " will not run";
</span><span class="cx"> my $quickModeDefault = $runQuickMode ? "some" : "all";
</span><ins>+my $failFastDefault = $failFast ? "fail fast" : "don't fail fast";
</ins><span class="cx"> my $filter;
</span><span class="cx"> my $usage = <<EOF;
</span><span class="cx"> Usage: $programName [options] [options to pass to build system]
</span><span class="lines">@@ -90,6 +92,7 @@
</span><span class="cx"> If the runner only runs some it will run the default and no-cjit-validate modes.
</span><span class="cx"> Note, this will not change the behavior of tests that specify their own modes.
</span><span class="cx">
</span><ins>+ --[no-]fail-fast Stop this script when a test family reports an error or failure (default: $failFastDefault)
</ins><span class="cx"> --json-output= Create a file at specified path, listing failed stress tests in JSON format.
</span><span class="cx"> --tarball Create a tarball of the bundle produced by running the JSC stress tests.
</span><span class="cx"> --remote= Run the JSC stress tests on the specified remote host. Implies --tarball.
</span><span class="lines">@@ -116,6 +119,7 @@
</span><span class="cx"> 'jsc-stress!' => \$runJSCStress,
</span><span class="cx"> 'jit-stress-tests!' => \$runJITStressTests,
</span><span class="cx"> 'quick!' => \$runQuickMode,
</span><ins>+ 'fail-fast!' => \$failFast,
</ins><span class="cx"> 'json-output=s' => \$jsonFileName,
</span><span class="cx"> 'tarball!' => \$createTarball,
</span><span class="cx"> 'remote=s' => \$remoteHost,
</span><span class="lines">@@ -203,7 +207,9 @@
</span><span class="cx"> my $testapiResult = system { $command[0] } @command;
</span><span class="cx"> my $exitStatus = exitStatus($testapiResult);
</span><span class="cx"> print "testAPI completed with rc=$testapiResult ($exitStatus)\n";
</span><del>- exit exitStatus($testapiResult) if $testapiResult;
</del><ins>+ if ($testapiResult && $failFast) {
+ exit exitStatus($testapiResult);
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> # Find JavaScriptCore directory
</span></span></pre>
</div>
</div>
</body>
</html>