<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200214] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200214">200214</a></dd>
<dt>Author</dt> <dd>cfleizach@apple.com</dd>
<dt>Date</dt> <dd>2016-04-28 16:12:37 -0700 (Thu, 28 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>AX: superscript content exposed as plain text; VoiceOver does not speak or pause to make this understandable
https://bugs.webkit.org/show_bug.cgi?id=157122
<rdar://problem/21231487>
Reviewed by Daniel Bates.
Expose role types for subscript and superscript.
Modified: accessibility/mac/subroles-for-formatted-groups.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isStyleFormatGroup):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
LayoutTests:
AX: superscript content exposed as plain text; VoiceOver does not speak or pause to make this understandable
https://bugs.webkit.org/show_bug.cgi?id=157122
<rdar://problem/21231487>
Reviewed by Daniel Bates.
* accessibility/mac/subroles-for-formatted-groups-expected.txt:
* accessibility/mac/subroles-for-formatted-groups.html:
* platform/mac/accessibility/accessibility/roles-exposed-expected.txt:
* accessibility/roles-computedRoleString-expected.txt:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsaccessibilitymacsubrolesforformattedgroupsexpectedtxt">trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups-expected.txt</a></li>
<li><a href="#trunkLayoutTestsaccessibilitymacsubrolesforformattedgroupshtml">trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups.html</a></li>
<li><a href="#trunkLayoutTestsaccessibilityrolescomputedRoleStringexpectedtxt">trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacaccessibilityrolesexposedexpectedtxt">trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreaccessibilityAccessibilityObjectcpp">trunk/Source/WebCore/accessibility/AccessibilityObject.cpp</a></li>
<li><a href="#trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm">trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (200213 => 200214)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/LayoutTests/ChangeLog 2016-04-28 23:12:37 UTC (rev 200214)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-04-28 Chris Fleizach <cfleizach@apple.com>
+
+ AX: superscript content exposed as plain text; VoiceOver does not speak or pause to make this understandable
+ https://bugs.webkit.org/show_bug.cgi?id=157122
+ <rdar://problem/21231487>
+
+ Reviewed by Daniel Bates.
+
+ * accessibility/mac/subroles-for-formatted-groups-expected.txt:
+ * accessibility/mac/subroles-for-formatted-groups.html:
+ * platform/mac/accessibility/accessibility/roles-exposed-expected.txt:
+ * accessibility/roles-computedRoleString-expected.txt:
+
</ins><span class="cx"> 2016-04-28 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=157140
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitymacsubrolesforformattedgroupsexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups-expected.txt (200213 => 200214)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups-expected.txt 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups-expected.txt 2016-04-28 23:12:37 UTC (rev 200214)
</span><span class="lines">@@ -2,7 +2,7 @@
</span><span class="cx"> kbd
</span><span class="cx"> sample
</span><span class="cx"> pre
</span><del>-var insert delete cite
</del><ins>+var insert delete cite sub sup
</ins><span class="cx"> This test makes sure that formatting style groups.
</span><span class="cx">
</span><span class="cx"> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
</span><span class="lines">@@ -16,6 +16,8 @@
</span><span class="cx"> ins: AXSubrole: AXInsertStyleGroup
</span><span class="cx"> del: AXSubrole: AXDeleteStyleGroup
</span><span class="cx"> cite: AXSubrole: AXCiteStyleGroup
</span><ins>+sub: AXSubrole: AXSubscriptStyleGroup
+sup: AXSubrole: AXSuperscriptStyleGroup
</ins><span class="cx"> PASS successfullyParsed is true
</span><span class="cx">
</span><span class="cx"> TEST COMPLETE
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilitymacsubrolesforformattedgroupshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups.html (200213 => 200214)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups.html 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/LayoutTests/accessibility/mac/subroles-for-formatted-groups.html 2016-04-28 23:12:37 UTC (rev 200214)
</span><span class="lines">@@ -13,6 +13,8 @@
</span><span class="cx"> <ins id="ins">insert</ins>
</span><span class="cx"> <del id="del">delete</del>
</span><span class="cx"> <cite id="cite">cite</cite>
</span><ins>+<sub id="sub">sub</sub>
+<sup id="sup">sup</sup>
</ins><span class="cx">
</span><span class="cx"> <p id="description"></p>
</span><span class="cx"> <div id="console"></div>
</span><span class="lines">@@ -30,6 +32,8 @@
</span><span class="cx"> debug("ins: " + accessibilityController.accessibleElementById('ins').subrole);
</span><span class="cx"> debug("del: " + accessibilityController.accessibleElementById('del').subrole);
</span><span class="cx"> debug("cite: " + accessibilityController.accessibleElementById('cite').subrole);
</span><ins>+ debug("sub: " + accessibilityController.accessibleElementById('sub').subrole);
+ debug("sup: " + accessibilityController.accessibleElementById('sup').subrole);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> </script>
</span></span></pre></div>
<a id="trunkLayoutTestsaccessibilityrolescomputedRoleStringexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt (200213 => 200214)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt 2016-04-28 23:12:37 UTC (rev 200214)
</span><span class="lines">@@ -59,6 +59,8 @@
</span><span class="cx"> PASS: optgroup -> option.
</span><span class="cx"> PASS: option -> option.
</span><span class="cx"> PASS: option -> option.
</span><ins>+PASS: sub -> .
+PASS: sup -> .
</ins><span class="cx"> PASS: table -> table.
</span><span class="cx"> PASS: tr -> row.
</span><span class="cx"> PASS: th -> columnheader.
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacaccessibilityrolesexposedexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt (200213 => 200214)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2016-04-28 23:12:37 UTC (rev 200214)
</span><span class="lines">@@ -635,14 +635,14 @@
</span><span class="cx"> AXRoleDescription:
</span><span class="cx">
</span><span class="cx"> sub
</span><del>- AXRole:
- AXSubrole:
- AXRoleDescription:
</del><ins>+ AXRole: AXGroup
+ AXSubrole: AXSubscriptStyleGroup
+ AXRoleDescription: group
</ins><span class="cx">
</span><span class="cx"> sup
</span><del>- AXRole:
- AXSubrole:
- AXRoleDescription:
</del><ins>+ AXRole: AXGroup
+ AXSubrole: AXSuperscriptStyleGroup
+ AXRoleDescription: group
</ins><span class="cx">
</span><span class="cx"> svg
</span><span class="cx"> AXRole:
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (200213 => 200214)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/Source/WebCore/ChangeLog 2016-04-28 23:12:37 UTC (rev 200214)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-04-28 Chris Fleizach <cfleizach@apple.com>
+
+ AX: superscript content exposed as plain text; VoiceOver does not speak or pause to make this understandable
+ https://bugs.webkit.org/show_bug.cgi?id=157122
+ <rdar://problem/21231487>
+
+ Reviewed by Daniel Bates.
+
+ Expose role types for subscript and superscript.
+
+ Modified: accessibility/mac/subroles-for-formatted-groups.html
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::isStyleFormatGroup):
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper subrole]):
+
</ins><span class="cx"> 2016-04-28 Brady Eidson <beidson@apple.com>
</span><span class="cx">
</span><span class="cx"> inspector/indexeddb/requestDatabaseNames.html is flaky on Mac.
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilityAccessibilityObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (200213 => 200214)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2016-04-28 23:12:37 UTC (rev 200214)
</span><span class="lines">@@ -3024,7 +3024,8 @@
</span><span class="cx"> return node->hasTagName(kbdTag) || node->hasTagName(codeTag)
</span><span class="cx"> || node->hasTagName(preTag) || node->hasTagName(sampTag)
</span><span class="cx"> || node->hasTagName(varTag) || node->hasTagName(citeTag)
</span><del>- || node->hasTagName(insTag) || node->hasTagName(delTag);
</del><ins>+ || node->hasTagName(insTag) || node->hasTagName(delTag)
+ || node->hasTagName(supTag) || node->hasTagName(subTag);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> bool AccessibilityObject::isContainedByPasswordField() const
</span></span></pre></div>
<a id="trunkSourceWebCoreaccessibilitymacWebAccessibilityObjectWrapperMacmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (200213 => 200214)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2016-04-28 22:55:27 UTC (rev 200213)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2016-04-28 23:12:37 UTC (rev 200214)
</span><span class="lines">@@ -2413,6 +2413,10 @@
</span><span class="cx"> return @"AXInsertStyleGroup";
</span><span class="cx"> if (node->hasTagName(delTag))
</span><span class="cx"> return @"AXDeleteStyleGroup";
</span><ins>+ if (node->hasTagName(supTag))
+ return @"AXSuperscriptStyleGroup";
+ if (node->hasTagName(subTag))
+ return @"AXSubscriptStyleGroup";
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>