<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200090] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200090">200090</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-04-26 09:33:55 -0700 (Tue, 26 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Chart status should always be computed against prior values
https://bugs.webkit.org/show_bug.cgi?id=157014
Reviewed by Darin Adler.
Compare the current value against the last baseline or target value that appear before the current value in time
so that the comparison stay the same even when new baseline and target values are reported. Also include the compared
baseline or target value in the label for clarity.
* public/v3/components/chart-status-view.js:
(ChartStatusView.prototype._computeChartStatus):
(ChartStatusView.prototype._computeChartStatus.labelForDiff):
(ChartStatusView.prototype._findLastPointPriorToTime): Extracted from _relativeDifferenceToLaterPointInTimeSeries.
Now finds the last point before the current point's time if there is any, or the last point in baseline / target.
(ChartStatusView.prototype._relativeDifferenceToLaterPointInTimeSeries): Deleted.
* public/v3/models/metric.js:
(Metric.prototype.makeFormatter): Don't use SI units for unit-less metrics.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3componentschartstatusviewjs">trunk/Websites/perf.webkit.org/public/v3/components/chart-status-view.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3modelsmetricjs">trunk/Websites/perf.webkit.org/public/v3/models/metric.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (200089 => 200090)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2016-04-26 16:22:32 UTC (rev 200089)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-04-26 16:33:55 UTC (rev 200090)
</span><span class="lines">@@ -1,3 +1,23 @@
</span><ins>+2016-04-26 Ryosuke Niwa <rniwa@webkit.org>
+
+ Chart status should always be computed against prior values
+ https://bugs.webkit.org/show_bug.cgi?id=157014
+
+ Reviewed by Darin Adler.
+
+ Compare the current value against the last baseline or target value that appear before the current value in time
+ so that the comparison stay the same even when new baseline and target values are reported. Also include the compared
+ baseline or target value in the label for clarity.
+
+ * public/v3/components/chart-status-view.js:
+ (ChartStatusView.prototype._computeChartStatus):
+ (ChartStatusView.prototype._computeChartStatus.labelForDiff):
+ (ChartStatusView.prototype._findLastPointPriorToTime): Extracted from _relativeDifferenceToLaterPointInTimeSeries.
+ Now finds the last point before the current point's time if there is any, or the last point in baseline / target.
+ (ChartStatusView.prototype._relativeDifferenceToLaterPointInTimeSeries): Deleted.
+ * public/v3/models/metric.js:
+ (Metric.prototype.makeFormatter): Don't use SI units for unit-less metrics.
+
</ins><span class="cx"> 2016-04-13 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r199444): Perf dashboard always fetches all measurement sets
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3componentschartstatusviewjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/components/chart-status-view.js (200089 => 200090)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/components/chart-status-view.js 2016-04-26 16:22:32 UTC (rev 200089)
+++ trunk/Websites/perf.webkit.org/public/v3/components/chart-status-view.js 2016-04-26 16:33:55 UTC (rev 200090)
</span><span class="lines">@@ -112,33 +112,38 @@
</span><span class="cx"> if (!currentPoint)
</span><span class="cx"> currentPoint = currentTimeSeriesData[currentTimeSeriesData.length - 1];
</span><span class="cx">
</span><del>- var diffFromBaseline = this._relativeDifferenceToLaterPointInTimeSeries(currentPoint, baselineTimeSeriesData);
- var diffFromTarget = this._relativeDifferenceToLaterPointInTimeSeries(currentPoint, targetTimeSeriesData);
</del><ins>+ var baselinePoint = this._findLastPointPriorToTime(currentPoint, baselineTimeSeriesData);
+ var diffFromBaseline = baselinePoint !== undefined ? (currentPoint.value - baselinePoint.value) / baselinePoint.value : undefined;
</ins><span class="cx">
</span><ins>+ var targetPoint = this._findLastPointPriorToTime(currentPoint, targetTimeSeriesData);
+ var diffFromTarget = targetPoint !== undefined ? (currentPoint.value - targetPoint.value) / targetPoint.value : undefined;
+
</ins><span class="cx"> var label = '';
</span><span class="cx"> var className = '';
</span><span class="cx">
</span><del>- function labelForDiff(diff, name, comparison)
</del><ins>+ function labelForDiff(diff, referencePoint, name, comparison)
</ins><span class="cx"> {
</span><del>- return Math.abs(diff * 100).toFixed(1) + '% ' + comparison + ' ' + name;
</del><ins>+ var relativeDiff = Math.abs(diff * 100).toFixed(1);
+ var referenceValue = referencePoint ? ` (${formatter(referencePoint.value)})` : '';
+ return `${relativeDiff}% ${comparison} ${name}${referenceValue}`;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var smallerIsBetter = metric.isSmallerBetter();
</span><span class="cx"> if (diffFromBaseline !== undefined && diffFromTarget !== undefined) {
</span><span class="cx"> if (diffFromBaseline > 0 == smallerIsBetter) {
</span><del>- label = labelForDiff(diffFromBaseline, 'baseline', 'worse than');
</del><ins>+ label = labelForDiff(diffFromBaseline, baselinePoint, 'baseline', 'worse than');
</ins><span class="cx"> className = 'worse';
</span><span class="cx"> } else if (diffFromTarget < 0 == smallerIsBetter) {
</span><del>- label = labelForDiff(diffFromBaseline, 'target', 'better than');
</del><ins>+ label = labelForDiff(diffFromTarget, targetPoint, 'target', 'better than');
</ins><span class="cx"> className = 'better';
</span><span class="cx"> } else
</span><del>- label = labelForDiff(diffFromTarget, 'target', 'until');
</del><ins>+ label = labelForDiff(diffFromTarget, targetPoint, 'target', 'until');
</ins><span class="cx"> } else if (diffFromBaseline !== undefined) {
</span><span class="cx"> className = diffFromBaseline > 0 == smallerIsBetter ? 'worse' : 'better';
</span><del>- label = labelForDiff(diffFromBaseline, 'baseline', className + ' than');
</del><ins>+ label = labelForDiff(diffFromBaseline, baselinePoint, 'baseline', className + ' than');
</ins><span class="cx"> } else if (diffFromTarget !== undefined) {
</span><span class="cx"> className = diffFromTarget < 0 == smallerIsBetter ? 'better' : 'worse';
</span><del>- label = labelForDiff(diffFromTarget, 'target', className + ' than');
</del><ins>+ label = labelForDiff(diffFromTarget, targetPoint, 'target', className + ' than');
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> var valueDelta = null;
</span><span class="lines">@@ -157,20 +162,17 @@
</span><span class="cx"> };
</span><span class="cx"> }
</span><span class="cx">
</span><del>- _relativeDifferenceToLaterPointInTimeSeries(currentPoint, timeSeriesData)
</del><ins>+ _findLastPointPriorToTime(currentPoint, timeSeriesData)
</ins><span class="cx"> {
</span><span class="cx"> if (!currentPoint || !timeSeriesData || !timeSeriesData.length)
</span><span class="cx"> return undefined;
</span><span class="cx">
</span><del>- // FIXME: We shouldn't be using the first data point to access the time series object.
- var referencePoint = timeSeriesData[0].series.findPointAfterTime(currentPoint.time);
- if (!referencePoint)
- return undefined;
-
- return (currentPoint.value - referencePoint.value) / referencePoint.value;
</del><ins>+ var i = 0;
+ while (i < timeSeriesData.length - 1 && timeSeriesData[i + 1].time < currentPoint.time)
+ i++;
+ return timeSeriesData[i];
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-
</del><span class="cx"> static htmlTemplate()
</span><span class="cx"> {
</span><span class="cx"> return `
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3modelsmetricjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/models/metric.js (200089 => 200090)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/models/metric.js 2016-04-26 16:22:32 UTC (rev 200089)
+++ trunk/Websites/perf.webkit.org/public/v3/models/metric.js 2016-04-26 16:33:55 UTC (rev 200090)
</span><span class="lines">@@ -68,8 +68,11 @@
</span><span class="cx"> isMiliseconds = true;
</span><span class="cx"> unit = 's';
</span><span class="cx"> }
</span><ins>+
+ if (!unit)
+ return function (value) { return value.toFixed(2) + ' ' + (unit || ''); }
+
</ins><span class="cx"> var divisor = unit == 'B' ? 1024 : 1000;
</span><del>-
</del><span class="cx"> var suffix = ['\u03BC', 'm', '', 'K', 'M', 'G', 'T', 'P', 'E'];
</span><span class="cx"> var threshold = sigFig >= 3 ? divisor : (divisor / 10);
</span><span class="cx"> return function (value) {
</span></span></pre>
</div>
</div>
</body>
</html>