<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200004] releases/WebKitGTK/webkit-2.12</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200004">200004</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-04-25 06:13:16 -0700 (Mon, 25 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/199585">r199585</a> - Selection.deleteFromDocument should not leave a selection character
https://bugs.webkit.org/show_bug.cgi?id=151442
Reviewed by Michael Catanzaro.
Source/WebCore:
This is a merge of Blink <a href="http://trac.webkit.org/projects/webkit/changeset/172511">r172511</a>:
https://codereview.chromium.org/255453003
Let Selection.deleteFromDocument not delete a character when the
selection is a caret.
Selection.deleteFromDocument delete a character when the selection
is a caret.
However, current standard says that Selection.deleteFromDocument
does nothing when the selection is a caret:
https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#dom-selection-deletefromdocument
Both IE10 and FireFox seem following the spec.
Test: imported/blink/editing/selection/deleteFromDocument-undo-crash.html
* page/DOMSelection.cpp:
(WebCore::DOMSelection::deleteFromDocument): Deleted.
LayoutTests:
* editing/selection/deleteFromDocument-expected.txt:
* editing/selection/deleteFromDocument.html:
* imported/blink/editing/selection/deleteFromDocument-undo-crash-expected.txt: Added.
* imported/blink/editing/selection/deleteFromDocument-undo-crash.html: Added.
* TestExpectations: Skip imported/blink/editing/selection/deleteFromDocument-undo-crash.html in Debug.
* platform/gtk/TestExpectations: Unskip imported/blink/editing/selection/deleteFromDocument-crash.html.
* platform/win/TestExpectations: Ditto.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsTestExpectations">releases/WebKitGTK/webkit-2.12/LayoutTests/TestExpectations</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestseditingselectiondeleteFromDocumentexpectedtxt">releases/WebKitGTK/webkit-2.12/LayoutTests/editing/selection/deleteFromDocument-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestseditingselectiondeleteFromDocumenthtml">releases/WebKitGTK/webkit-2.12/LayoutTests/editing/selection/deleteFromDocument.html</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsplatformgtkTestExpectations">releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsplatformwinTestExpectations">releases/WebKitGTK/webkit-2.12/LayoutTests/platform/win/TestExpectations</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorepageDOMSelectioncpp">releases/WebKitGTK/webkit-2.12/Source/WebCore/page/DOMSelection.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsimportedblinkeditingselectiondeleteFromDocumentundocrashexpectedtxt">releases/WebKitGTK/webkit-2.12/LayoutTests/imported/blink/editing/selection/deleteFromDocument-undo-crash-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsimportedblinkeditingselectiondeleteFromDocumentundocrashhtml">releases/WebKitGTK/webkit-2.12/LayoutTests/imported/blink/editing/selection/deleteFromDocument-undo-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit212LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (200003 => 200004)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-25 13:08:42 UTC (rev 200003)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-25 13:13:16 UTC (rev 200004)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-04-15 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ Selection.deleteFromDocument should not leave a selection character
+ https://bugs.webkit.org/show_bug.cgi?id=151442
+
+ Reviewed by Michael Catanzaro.
+
+ * editing/selection/deleteFromDocument-expected.txt:
+ * editing/selection/deleteFromDocument.html:
+ * imported/blink/editing/selection/deleteFromDocument-undo-crash-expected.txt: Added.
+ * imported/blink/editing/selection/deleteFromDocument-undo-crash.html: Added.
+ * TestExpectations: Skip imported/blink/editing/selection/deleteFromDocument-undo-crash.html in Debug.
+ * platform/gtk/TestExpectations: Unskip imported/blink/editing/selection/deleteFromDocument-crash.html.
+ * platform/win/TestExpectations: Ditto.
+
</ins><span class="cx"> 2016-04-14 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CachedResource::addClientToSet + 27
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsTestExpectations"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/TestExpectations (200003 => 200004)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/TestExpectations 2016-04-25 13:08:42 UTC (rev 200003)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/TestExpectations 2016-04-25 13:13:16 UTC (rev 200004)
</span><span class="lines">@@ -474,6 +474,7 @@
</span><span class="cx"> [ Debug ] fast/history/history-back-while-pdf-in-pagecache.html [ Skip ]
</span><span class="cx"> webkit.org/b/121628 [ Release ] fast/history/history-back-while-pdf-in-pagecache.html [ Pass ImageOnlyFailure ]
</span><span class="cx"> [ Debug ] fullscreen/full-screen-iframe-legacy.html [ Pass Crash ]
</span><ins>+webkit.org/b/151488 [ Debug ] imported/blink/editing/selection/deleteFromDocument-undo-crash.html [ Skip ]
</ins><span class="cx">
</span><span class="cx"> webkit.org/b/139634 [ Debug ] fast/selectors/matches-backtracking.html [ Slow ]
</span><span class="cx"> webkit.org/b/139634 [ Debug ] fast/selectors/nth-child-of-register-requirement.html [ Slow ]
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestseditingselectiondeleteFromDocumentexpectedtxt"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/editing/selection/deleteFromDocument-expected.txt (200003 => 200004)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/editing/selection/deleteFromDocument-expected.txt 2016-04-25 13:08:42 UTC (rev 200003)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/editing/selection/deleteFromDocument-expected.txt 2016-04-25 13:13:16 UTC (rev 200004)
</span><span class="lines">@@ -1,7 +1,9 @@
</span><ins>+PASS span1.textContent is "foobar"
+PASS span1.textContent is "foobar"
+PASS span1.firstChild.nextSibling.id is "span2"
+PASS span1.firstChild.nextSibling.firstChild.nodeValue is ""
+PASS test.textContent is "fz"
+PASS successfullyParsed is true
+
+TEST COMPLETE
</ins><span class="cx"> fz
</span><del>-Success: span1.textContent is fooar.
-Success: span1.textContent is foar.
-Success: span1.textContent is foar.
-Success: span1.firstChild.nextSibling.id is span2.
-Success: span1.firstChild.nextSibling.firstChild.nodeValue is .
-Success: test.textContent is fz.
</del></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestseditingselectiondeleteFromDocumenthtml"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/editing/selection/deleteFromDocument.html (200003 => 200004)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/editing/selection/deleteFromDocument.html 2016-04-25 13:08:42 UTC (rev 200003)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/editing/selection/deleteFromDocument.html 2016-04-25 13:13:16 UTC (rev 200004)
</span><span class="lines">@@ -1,7 +1,9 @@
</span><span class="cx"> <html>
</span><ins>+<head>
+<script src="../../resources/js-test.js"></script>
+</head>
</ins><span class="cx"> <body>
</span><span class="cx"> <div id="test"><span id="span1">foo<span id="span2">bar</span></span><span id="span3">baz</span></div>
</span><del>-<div id="console"></div>
</del><span class="cx"> <script>
</span><span class="cx"> var s = window.getSelection();
</span><span class="cx"> var testDiv = document.getElementById("test");
</span><span class="lines">@@ -9,23 +11,6 @@
</span><span class="cx"> var span2 = document.getElementById("span2");
</span><span class="cx"> var span3 = document.getElementById("span3");
</span><span class="cx">
</span><del>-function log(str) {
- var li = document.createElement("li");
- li.appendChild(document.createTextNode(str));
- document.getElementById("console").appendChild(li);
-}
-
-function shouldBe(expr, expected) {
- var actual = eval(expr);
- if (actual != expected)
- log("Failure: " + expr + " should be " + expected + ", was " + actual + ".");
- else
- log("Success: " + expr + " is " + expected + ".");
-}
-
-if (window.testRunner)
- testRunner.dumpAsText();
-
</del><span class="cx"> var r = document.createRange();
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -35,40 +20,27 @@
</span><span class="cx"> s.addRange(r);
</span><span class="cx">
</span><span class="cx"> s.deleteFromDocument()
</span><del>-shouldBe('span1.textContent', 'fooar');
-try {
- s.deleteFromDocument()
- shouldBe('span1.textContent', 'foar');
-} catch (ex) {
- log(ex);
-}
</del><ins>+shouldBeEqualToString("span1.textContent", "foobar");
</ins><span class="cx">
</span><del>-
</del><span class="cx"> // try to delete a collapsed selection at the start
</span><span class="cx"> r.setStart(span1.firstChild, 0);
</span><span class="cx"> r.setEnd(span1.firstChild, 0);
</span><span class="cx"> s.removeAllRanges();
</span><span class="cx"> s.addRange(r);
</span><span class="cx">
</span><del>-try {
- s.deleteFromDocument()
- shouldBe('span1.textContent', 'foar');
-} catch (ex) {
- log(ex);
-}
</del><ins>+s.deleteFromDocument()
+shouldBeEqualToString("span1.textContent", "foobar");
</ins><span class="cx">
</span><del>-
</del><span class="cx"> // delete whole contents
</span><span class="cx"> r.setStart(span2.firstChild, 0);
</span><del>-r.setEnd(span2.firstChild, 2);
</del><ins>+r.setEnd(span2.firstChild, 3);
</ins><span class="cx"> s.removeAllRanges();
</span><span class="cx"> s.addRange(r);
</span><span class="cx">
</span><span class="cx"> s.deleteFromDocument()
</span><del>-shouldBe('span1.firstChild.nextSibling.id', 'span2');
-shouldBe('span1.firstChild.nextSibling.firstChild.nodeValue', '');
</del><ins>+shouldBeEqualToString("span1.firstChild.nextSibling.id", "span2");
+shouldBeEqualToString("span1.firstChild.nextSibling.firstChild.nodeValue", "");
</ins><span class="cx">
</span><del>-
</del><span class="cx"> // partially delete two nodes
</span><span class="cx"> r.setStart(span1.firstChild, 1);
</span><span class="cx"> r.setEnd(span3.firstChild, 2);
</span><span class="lines">@@ -76,7 +48,7 @@
</span><span class="cx"> s.addRange(r);
</span><span class="cx">
</span><span class="cx"> s.deleteFromDocument()
</span><del>-shouldBe('test.textContent', 'fz');
</del><ins>+shouldBeEqualToString("test.textContent", "fz");
</ins><span class="cx">
</span><span class="cx"> </script>
</span><span class="cx"> </body>
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsimportedblinkeditingselectiondeleteFromDocumentundocrashexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/imported/blink/editing/selection/deleteFromDocument-undo-crash-expected.txt (0 => 200004)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/imported/blink/editing/selection/deleteFromDocument-undo-crash-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/imported/blink/editing/selection/deleteFromDocument-undo-crash-expected.txt 2016-04-25 13:13:16 UTC (rev 200004)
</span><span class="lines">@@ -0,0 +1 @@
</span><ins>+PASS. WebKit didn't crash.
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsimportedblinkeditingselectiondeleteFromDocumentundocrashhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/imported/blink/editing/selection/deleteFromDocument-undo-crash.html (0 => 200004)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/imported/blink/editing/selection/deleteFromDocument-undo-crash.html (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/imported/blink/editing/selection/deleteFromDocument-undo-crash.html 2016-04-25 13:13:16 UTC (rev 200004)
</span><span class="lines">@@ -0,0 +1,30 @@
</span><ins>+<html>
+<head>
+<script id="script1"></script>
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+window.onload = function () {
+ document.designMode = "on";
+ var selection = window.getSelection();
+ document.execCommand("SelectAll", false)
+ var range = selection.getRangeAt(0);
+
+ range.insertNode(document.getElementById("script1"));
+ document.execCommand('InsertText', false, 'efgh');
+ document.execCommand('JustifyFull', false, false);
+
+ selection.deleteFromDocument();
+ document.execCommand("Undo", false, false);
+
+ document.execCommand("Delete");
+
+ document.documentElement.innerHTML = "PASS. WebKit didn't crash.";
+};
+</script>
+</head>
+<body>
+ <h1>abcd</h1>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations (200003 => 200004)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations 2016-04-25 13:08:42 UTC (rev 200003)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations 2016-04-25 13:13:16 UTC (rev 200004)
</span><span class="lines">@@ -2437,7 +2437,6 @@
</span><span class="cx"> webkit.org/b/151267 imported/blink/css3/blending/svg-blend-overlapping-elements.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/151267 imported/blink/css3/blending/svg-isolation-foreign-no-isolation.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/151267 imported/blink/css3/blending/svg-isolation-nested-svg-no-isolation.html [ ImageOnlyFailure ]
</span><del>-webkit.org/b/151267 imported/blink/editing/selection/deleteFromDocument-crash.html [ ImageOnlyFailure ]
</del><span class="cx"> webkit.org/b/151267 imported/blink/fast/canvas/canvas-clip-stack-persistence.html [ ImageOnlyFailure ]
</span><span class="cx"> webkit.org/b/151267 imported/blink/fast/css/fixed-overlaps-absolute-in-clip.html [ ImageOnlyFailure Pass ]
</span><span class="cx"> webkit.org/b/151267 imported/blink/fast/css/tab-size-complex-path.html [ ImageOnlyFailure ]
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsplatformwinTestExpectations"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/platform/win/TestExpectations (200003 => 200004)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/platform/win/TestExpectations 2016-04-25 13:08:42 UTC (rev 200003)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/platform/win/TestExpectations 2016-04-25 13:13:16 UTC (rev 200004)
</span><span class="lines">@@ -3271,7 +3271,6 @@
</span><span class="cx"> imported/blink/css3/blending/svg-isolation-nested-svg-no-isolation.html [ ImageOnlyFailure ]
</span><span class="cx"> imported/blink/css3/filters/effect-drop-shadow-clip-abspos.html [ ImageOnlyFailure ]
</span><span class="cx"> imported/blink/css3/filters/effect-reference-on-transparent-element.html [ ImageOnlyFailure ]
</span><del>-imported/blink/editing/selection/deleteFromDocument-crash.html [ ImageOnlyFailure ]
</del><span class="cx"> imported/blink/fast/css/tab-size-complex-path.html [ ImageOnlyFailure ]
</span><span class="cx"> imported/blink/fast/css/text-decoration-propagate.html [ ImageOnlyFailure ]
</span><span class="cx"> imported/blink/fast/text/emoji-font-fallback-win.html [ ImageOnlyFailure ]
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (200003 => 200004)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-25 13:08:42 UTC (rev 200003)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-25 13:13:16 UTC (rev 200004)
</span><span class="lines">@@ -1,3 +1,28 @@
</span><ins>+2016-04-15 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ Selection.deleteFromDocument should not leave a selection character
+ https://bugs.webkit.org/show_bug.cgi?id=151442
+
+ Reviewed by Michael Catanzaro.
+
+ This is a merge of Blink r172511:
+ https://codereview.chromium.org/255453003
+
+ Let Selection.deleteFromDocument not delete a character when the
+ selection is a caret.
+
+ Selection.deleteFromDocument delete a character when the selection
+ is a caret.
+ However, current standard says that Selection.deleteFromDocument
+ does nothing when the selection is a caret:
+ https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#dom-selection-deletefromdocument
+ Both IE10 and FireFox seem following the spec.
+
+ Test: imported/blink/editing/selection/deleteFromDocument-undo-crash.html
+
+ * page/DOMSelection.cpp:
+ (WebCore::DOMSelection::deleteFromDocument): Deleted.
+
</ins><span class="cx"> 2016-04-14 Dean Jackson <dino@apple.com>
</span><span class="cx">
</span><span class="cx"> CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CachedResource::addClientToSet + 27
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorepageDOMSelectioncpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/page/DOMSelection.cpp (200003 => 200004)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/page/DOMSelection.cpp 2016-04-25 13:08:42 UTC (rev 200003)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/page/DOMSelection.cpp 2016-04-25 13:13:16 UTC (rev 200004)
</span><span class="lines">@@ -429,9 +429,6 @@
</span><span class="cx"> if (selection.isNone())
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- if (isCollapsed())
- selection.modify(FrameSelection::AlterationExtend, DirectionBackward, CharacterGranularity);
-
</del><span class="cx"> RefPtr<Range> selectedRange = selection.selection().toNormalizedRange();
</span><span class="cx"> if (!selectedRange)
</span><span class="cx"> return;
</span></span></pre>
</div>
</div>
</body>
</html>