<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200021] releases/WebKitGTK/webkit-2.12</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200021">200021</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-04-25 08:46:41 -0700 (Mon, 25 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/199715">r199715</a> - [GTK] accessibility/gtk/entry-and-password.html is failing since <a href="http://trac.webkit.org/projects/webkit/changeset/194847">r194847</a>
https://bugs.webkit.org/show_bug.cgi?id=153062
Reviewed by Carlos Garcia Campos.
Source/WebCore:
The changes in <a href="http://trac.webkit.org/projects/webkit/changeset/194847">r194847</a> include using WebCore's rendering for the CapsLock indicator.
As a side effect, password inputs gained a TextControlInnerTextElement child from
the Shadow DOM. If we include that child in the accessibility tree, the child will
emit focus and text notifications that suggest the user is no longer in the control.
This can be especially problematic for screen reader users with key echo enabled
when typing in a password input. To fix this, prune TextControlInnerTextElement
children from the accessibility tree for ATK.
No new tests as existing coverage caught this regression. Also modified the
auto-fill-crash.html test whose expectations include the children count for
a text input.
* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
LayoutTests:
The auto-fill-crash.html test has expectations which include the children
count for the text input. These expectations were incorrect for ATK where
accessible text inputs lack accessible text children.
* accessibility/auto-fill-crash.html: Modified to take platform into account.
* platform/gtk/TestExpectations: Unskipped entry-and-password.html.
* platform/gtk/accessibility/auto-fill-crash-expected.txt: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsplatformgtkTestExpectations">releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoreaccessibilityatkAccessibilityObjectAtkcpp">releases/WebKitGTK/webkit-2.12/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsplatformgtkaccessibilityautofillcrashexpectedtxt">releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/accessibility/auto-fill-crash-expected.txt</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit212LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (200020 => 200021)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-25 15:41:32 UTC (rev 200020)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-25 15:46:41 UTC (rev 200021)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-04-19 Joanmarie Diggs <jdiggs@igalia.com>
+
+ [GTK] accessibility/gtk/entry-and-password.html is failing since r194847
+ https://bugs.webkit.org/show_bug.cgi?id=153062
+
+ Reviewed by Carlos Garcia Campos.
+
+ The auto-fill-crash.html test has expectations which include the children
+ count for the text input. These expectations were incorrect for ATK where
+ accessible text inputs lack accessible text children.
+
+ * accessibility/auto-fill-crash.html: Modified to take platform into account.
+ * platform/gtk/TestExpectations: Unskipped entry-and-password.html.
+ * platform/gtk/accessibility/auto-fill-crash-expected.txt: Added.
+
</ins><span class="cx"> 2016-04-18 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Possible off-by-one in hyphenation code
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations (200020 => 200021)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations 2016-04-25 15:41:32 UTC (rev 200020)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/TestExpectations 2016-04-25 15:46:41 UTC (rev 200021)
</span><span class="lines">@@ -2600,8 +2600,6 @@
</span><span class="cx"> webkit.org/b/152908 pageoverlay/overlay-small-frame-mouse-events.html [ Failure ]
</span><span class="cx"> webkit.org/b/152908 pageoverlay/overlay-small-frame-paints.html [ Failure ]
</span><span class="cx">
</span><del>-webkit.org/b/153062 accessibility/gtk/entry-and-password.html [ Failure ]
-
</del><span class="cx"> webkit.org/b/153602 fast/table/003.html [ Failure ]
</span><span class="cx"> webkit.org/b/153602 fast/text/emoji.html [ Failure ]
</span><span class="cx"> webkit.org/b/153602 tables/mozilla_expected_failures/bugs/bug89315.html [ Failure ]
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsplatformgtkaccessibilityautofillcrashexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/accessibility/auto-fill-crash-expected.txt (0 => 200021)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/accessibility/auto-fill-crash-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/platform/gtk/accessibility/auto-fill-crash-expected.txt 2016-04-25 15:46:41 UTC (rev 200021)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+
+This tests that when an auto fill element is removed we won't crash accessing an old value.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS accessibilityController.accessibleElementById('textfield').childrenCount is 2
+PASS accessibilityController.accessibleElementById('textfield').childrenCount is 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (200020 => 200021)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-25 15:41:32 UTC (rev 200020)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-25 15:46:41 UTC (rev 200021)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-04-19 Joanmarie Diggs <jdiggs@igalia.com>
+
+ [GTK] accessibility/gtk/entry-and-password.html is failing since r194847
+ https://bugs.webkit.org/show_bug.cgi?id=153062
+
+ Reviewed by Carlos Garcia Campos.
+
+ The changes in r194847 include using WebCore's rendering for the CapsLock indicator.
+ As a side effect, password inputs gained a TextControlInnerTextElement child from
+ the Shadow DOM. If we include that child in the accessibility tree, the child will
+ emit focus and text notifications that suggest the user is no longer in the control.
+ This can be especially problematic for screen reader users with key echo enabled
+ when typing in a password input. To fix this, prune TextControlInnerTextElement
+ children from the accessibility tree for ATK.
+
+ No new tests as existing coverage caught this regression. Also modified the
+ auto-fill-crash.html test whose expectations include the children count for
+ a text input.
+
+ * accessibility/atk/AccessibilityObjectAtk.cpp:
+ (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
+
</ins><span class="cx"> 2016-04-18 Martin Robinson <mrobinson@igalia.com>
</span><span class="cx">
</span><span class="cx"> [GTK] Possible off-by-one in hyphenation code
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCoreaccessibilityatkAccessibilityObjectAtkcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp (200020 => 200021)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp 2016-04-25 15:41:32 UTC (rev 200020)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp 2016-04-25 15:46:41 UTC (rev 200021)
</span><span class="lines">@@ -24,6 +24,7 @@
</span><span class="cx"> #include "HTMLElement.h"
</span><span class="cx"> #include "HTMLNames.h"
</span><span class="cx"> #include "RenderText.h"
</span><ins>+#include "TextControlInnerElements.h"
</ins><span class="cx"> #include <glib-object.h>
</span><span class="cx">
</span><span class="cx"> #if HAVE(ACCESSIBILITY)
</span><span class="lines">@@ -96,6 +97,13 @@
</span><span class="cx"> if (node && node->hasTagName(HTMLNames::spanTag) && !canSetFocusAttribute() && !hasAttributesRequiredForInclusion())
</span><span class="cx"> return IgnoreObject;
</span><span class="cx">
</span><ins>+ // If we include TextControlInnerTextElement children, changes to those children
+ // will result in focus and text notifications that suggest the user is no longer
+ // in the control. This can be especially problematic for screen reader users with
+ // key echo enabled when typing in a password input.
+ if (is<TextControlInnerTextElement>(node))
+ return IgnoreObject;
+
</ins><span class="cx"> // Given a paragraph or div containing a non-nested anonymous block, WebCore
</span><span class="cx"> // ignores the paragraph or div and includes the block. We want the opposite:
</span><span class="cx"> // ATs are expecting accessible objects associated with textual elements. They
</span></span></pre>
</div>
</div>
</body>
</html>