<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[200009] releases/WebKitGTK/webkit-2.12</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/200009">200009</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-04-25 06:49:50 -0700 (Mon, 25 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/199607">r199607</a> - ASSERT when loading github.com
https://bugs.webkit.org/show_bug.cgi?id=156604
<rdar://problem/19890634>
Reviewed by Darin Adler.
Source/WebCore:
HTMLFormControlElement::m_isValid is a cache of the results of the valid() function.
When cloning the node, we were preserving each individual item, but not the state
of the cache. Therefore, the cache and the attributes didn't agree with each other.
Test: fast/forms/checkValidity-cloneNode-crash.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement):
LayoutTests:
* fast/forms/checkValidity-cloneNode-crash-expected.txt: Added.
* fast/forms/checkValidity-cloneNode-crash.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorehtmlHTMLInputElementcpp">releases/WebKitGTK/webkit-2.12/Source/WebCore/html/HTMLInputElement.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsfastformscheckValiditycloneNodecrashexpectedtxt">releases/WebKitGTK/webkit-2.12/LayoutTests/fast/forms/checkValidity-cloneNode-crash-expected.txt</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsfastformscheckValiditycloneNodecrashhtml">releases/WebKitGTK/webkit-2.12/LayoutTests/fast/forms/checkValidity-cloneNode-crash.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit212LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (200008 => 200009)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-25 13:42:08 UTC (rev 200008)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-25 13:49:50 UTC (rev 200009)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-04-15 Myles C. Maxfield <mmaxfield@apple.com>
+
+ ASSERT when loading github.com
+ https://bugs.webkit.org/show_bug.cgi?id=156604
+ <rdar://problem/19890634>
+
+ Reviewed by Darin Adler.
+
+ * fast/forms/checkValidity-cloneNode-crash-expected.txt: Added.
+ * fast/forms/checkValidity-cloneNode-crash.html: Added.
+
</ins><span class="cx"> 2016-04-15 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove support for X-Frame-Options in `<meta>`
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsfastformscheckValiditycloneNodecrashexpectedtxt"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/fast/forms/checkValidity-cloneNode-crash-expected.txt (0 => 200009)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/fast/forms/checkValidity-cloneNode-crash-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/fast/forms/checkValidity-cloneNode-crash-expected.txt 2016-04-25 13:49:50 UTC (rev 200009)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+This test makes sure that calling checkValidity() on a cloned node does not crash a Debug build. The test passes if there is no crash (and if you don't see any 'FAIL's)
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS element.checkValidity() is true
+PASS element2.checkValidity() is true
+PASS element.checkValidity() is true
+PASS element2.checkValidity() is true
+PASS element.checkValidity() is true
+PASS element2.checkValidity() is false
+PASS element.checkValidity() is true
+PASS element2.checkValidity() is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestsfastformscheckValiditycloneNodecrashhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/fast/forms/checkValidity-cloneNode-crash.html (0 => 200009)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/fast/forms/checkValidity-cloneNode-crash.html (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/fast/forms/checkValidity-cloneNode-crash.html 2016-04-25 13:49:50 UTC (rev 200009)
</span><span class="lines">@@ -0,0 +1,60 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../../resources/js-test-pre.js"></script>
+</head>
+<body>
+<script>
+description("This test makes sure that calling checkValidity() on a cloned node does not crash a Debug build. The test passes if there is no crash (and if you don't see any 'FAIL's)");
+
+var element;
+var element2;
+
+function checkInputElement() {
+ element = document.createElement("input");
+ element.required = true;
+ element.value = "hi"
+ shouldBeTrue("element.checkValidity()");
+ element2 = element.cloneNode();
+ shouldBeTrue("element2.checkValidity()");
+}
+
+function checkDeepSelect() {
+ element = document.createElement("select")
+ element.innerHTML = "<option>Volvo</option><option>Saab</option><option>Opel</option>";
+ element.required=true;
+ shouldBeTrue("element.checkValidity()");
+ element2 = element.cloneNode(true);
+ shouldBeTrue("element2.checkValidity()");
+}
+
+function checkShallowSelect() {
+ element = document.createElement("select")
+ element.innerHTML = "<option>Volvo</option><option>Saab</option><option>Opel</option>";
+ element.required = true;
+ shouldBeTrue("element.checkValidity()");
+ element2 = element.cloneNode();
+ shouldBeFalse("element2.checkValidity()");
+}
+
+function checkTextArea() {
+ element = document.createElement("textarea")
+ element.required = true;
+ element.checkValidity();
+ element.value = "a";
+ shouldBeTrue("element.checkValidity()");
+ element2 = element.cloneNode();
+ // https://bugs.webkit.org/show_bug.cgi?id=156637 will fix this bug.
+ // shouldBeTrue("element2.checkValidity()");
+ element2.value = element.value;
+ shouldBeTrue("element2.checkValidity()");
+}
+
+checkInputElement();
+checkDeepSelect();
+checkShallowSelect();
+checkTextArea();
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (200008 => 200009)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-25 13:42:08 UTC (rev 200008)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-25 13:49:50 UTC (rev 200009)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-04-15 Myles C. Maxfield <mmaxfield@apple.com>
+
+ ASSERT when loading github.com
+ https://bugs.webkit.org/show_bug.cgi?id=156604
+ <rdar://problem/19890634>
+
+ Reviewed by Darin Adler.
+
+ HTMLFormControlElement::m_isValid is a cache of the results of the valid() function.
+ When cloning the node, we were preserving each individual item, but not the state
+ of the cache. Therefore, the cache and the attributes didn't agree with each other.
+
+ Test: fast/forms/checkValidity-cloneNode-crash.html
+
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement):
+
</ins><span class="cx"> 2016-04-15 Brent Fulgham <bfulgham@apple.com>
</span><span class="cx">
</span><span class="cx"> Remove support for X-Frame-Options in `<meta>`
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorehtmlHTMLInputElementcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/html/HTMLInputElement.cpp (200008 => 200009)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/html/HTMLInputElement.cpp 2016-04-25 13:42:08 UTC (rev 200008)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/html/HTMLInputElement.cpp 2016-04-25 13:49:50 UTC (rev 200009)
</span><span class="lines">@@ -923,6 +923,7 @@
</span><span class="cx">
</span><span class="cx"> HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(source);
</span><span class="cx">
</span><ins>+ updateValidity();
</ins><span class="cx"> setFormControlValueMatchesRenderer(false);
</span><span class="cx"> m_inputType->updateInnerTextValue();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>