<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199876] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199876">199876</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-04-22 05:49:03 -0700 (Fri, 22 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[GTK] Enable the download attribute support
https://bugs.webkit.org/show_bug.cgi?id=99025
Reviewed by Žan Doberšek.
.:
* Source/cmake/OptionsGTK.cmake:
Tools:
* Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Unskip tests that should pass now.
* platform/gtk/TestExpectations:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkChangeLog">trunk/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourcecmakeOptionsGTKcmake">trunk/Source/cmake/OptionsGTK.cmake</a></li>
<li><a href="#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href="#trunkToolsScriptswebkitperlFeatureListpm">trunk/Tools/Scripts/webkitperl/FeatureList.pm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/ChangeLog (199875 => 199876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/ChangeLog 2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/ChangeLog 2016-04-22 12:49:03 UTC (rev 199876)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [GTK] Enable the download attribute support
+ https://bugs.webkit.org/show_bug.cgi?id=99025
+
+ Reviewed by Žan Doberšek.
+
+ * Source/cmake/OptionsGTK.cmake:
+
</ins><span class="cx"> 2016-04-18 Yusuke Suzuki <utatane.tea@gmail.com>
</span><span class="cx">
</span><span class="cx"> [JSCOnly] Implement RunLoop and remove glib dependency
</span></span></pre></div>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (199875 => 199876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/LayoutTests/ChangeLog 2016-04-22 12:49:03 UTC (rev 199876)
</span><span class="lines">@@ -1,3 +1,14 @@
</span><ins>+2016-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [GTK] Enable the download attribute support
+ https://bugs.webkit.org/show_bug.cgi?id=99025
+
+ Reviewed by Žan Doberšek.
+
+ Unskip tests that should pass now.
+
+ * platform/gtk/TestExpectations:
+
</ins><span class="cx"> 2016-04-22 Manuel Rego Casasnovas <rego@igalia.com>
</span><span class="cx">
</span><span class="cx"> [css-grid] Fix bug with positioned items in vertical writing mode
</span></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (199875 => 199876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-04-22 12:49:03 UTC (rev 199876)
</span><span class="lines">@@ -280,12 +280,6 @@
</span><span class="cx"> webkit.org/b/99024 media/encrypted-media [ Skip ]
</span><span class="cx"> webkit.org/b/99024 fast/events/constructors/media-key-event-constructor.html [ Timeout ]
</span><span class="cx">
</span><del>-# Tests that require ENABLE(DOWNLOAD_ATTRIBUTE).
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-nodownload.html [ Pass ]
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-download.html [ Failure ]
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Failure ]
-webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-download-unset.html [ Timeout Pass ]
-
</del><span class="cx"> # CSS Filters is disabled
</span><span class="cx"> webkit.org/b/99026 css3/filters [ Skip ]
</span><span class="cx"> webkit.org/b/99026 fast/filter-image/filter-image.html [ Skip ]
</span></span></pre></div>
<a id="trunkSourcecmakeOptionsGTKcmake"></a>
<div class="modfile"><h4>Modified: trunk/Source/cmake/OptionsGTK.cmake (199875 => 199876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/cmake/OptionsGTK.cmake 2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/Source/cmake/OptionsGTK.cmake 2016-04-22 12:49:03 UTC (rev 199876)
</span><span class="lines">@@ -156,6 +156,7 @@
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS PRIVATE ON)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PRIVATE ON)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATABASE_PROCESS PRIVATE ON)
</span><ins>+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOWNLOAD_ATTRIBUTE PRIVATE ON)
</ins><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PRIVATE ${ENABLE_FTL_DEFAULT})
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF)
</span><span class="cx"> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API PRIVATE ON)
</span></span></pre></div>
<a id="trunkToolsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Tools/ChangeLog (199875 => 199876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/ChangeLog 2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/Tools/ChangeLog 2016-04-22 12:49:03 UTC (rev 199876)
</span><span class="lines">@@ -1,3 +1,12 @@
</span><ins>+2016-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ [GTK] Enable the download attribute support
+ https://bugs.webkit.org/show_bug.cgi?id=99025
+
+ Reviewed by Žan Doberšek.
+
+ * Scripts/webkitperl/FeatureList.pm:
+
</ins><span class="cx"> 2016-04-21 Keith Miller <keith_miller@apple.com>
</span><span class="cx">
</span><span class="cx"> WebScriptObject description swizzler should work in a multi-threaded world
</span></span></pre></div>
<a id="trunkToolsScriptswebkitperlFeatureListpm"></a>
<div class="modfile"><h4>Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (199875 => 199876)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Tools/Scripts/webkitperl/FeatureList.pm 2016-04-22 12:21:21 UTC (rev 199875)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm 2016-04-22 12:49:03 UTC (rev 199876)
</span><span class="lines">@@ -249,7 +249,7 @@
</span><span class="cx"> define => "ENABLE_DOM4_EVENTS_CONSTRUCTOR", default => (isAppleWebKit() || isGtk() || isEfl()), value => \$dom4EventsConstructor },
</span><span class="cx">
</span><span class="cx"> { option => "download-attribute", desc => "Toggle Download Attribute support",
</span><del>- define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isEfl(), value => \$downloadAttributeSupport },
</del><ins>+ define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => (isEfl() || isGtk()), value => \$downloadAttributeSupport },
</ins><span class="cx">
</span><span class="cx"> { option => "fetch-api", desc => "Toggle Fetch API support",
</span><span class="cx"> define => "ENABLE_FETCH_API", default => 1, value => \$fetchAPISupport },
</span></span></pre>
</div>
</div>
</body>
</html>