<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199942] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199942">199942</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-04-22 17:58:01 -0700 (Fri, 22 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Cannot access the SQLTransaction.constructor.prototype
https://bugs.webkit.org/show_bug.cgi?id=156613
Reviewed by Darin Adler.
Source/WebCore:
Drop [NoInterfaceObject] from the following SQL interfaces:
Database, SQLError, SQLResultSet, SQLResultSetRowList and SQLTransaction.
This matches the specification:
https://dev.w3.org/html5/webdatabase/
This was causing the 'constructor' property to be wrong for these
interfaces as it would be a generic Object.
Test: storage/websql/transaction-prototype.html
* Modules/webdatabase/Database.idl:
* Modules/webdatabase/SQLError.idl:
* Modules/webdatabase/SQLResultSet.idl:
* Modules/webdatabase/SQLResultSetRowList.idl:
* Modules/webdatabase/SQLTransaction.idl:
LayoutTests:
Rebaseline existing test now that more SQL constructors are exposed on the
global Window object. Also add a test to confirm that it is possible to
access SQLTransaction.constructor.prototype and that it seems correct.
* js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* storage/websql/transaction-prototype-expected.txt: Added.
* storage/websql/transaction-prototype.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacmavericksjsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkLayoutTestsplatformmacyosemitejsdomglobalconstructorsattributesexpectedtxt">trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseDatabaseidl">trunk/Source/WebCore/Modules/webdatabase/Database.idl</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLErroridl">trunk/Source/WebCore/Modules/webdatabase/SQLError.idl</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLResultSetidl">trunk/Source/WebCore/Modules/webdatabase/SQLResultSet.idl</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLResultSetRowListidl">trunk/Source/WebCore/Modules/webdatabase/SQLResultSetRowList.idl</a></li>
<li><a href="#trunkSourceWebCoreModuleswebdatabaseSQLTransactionidl">trunk/Source/WebCore/Modules/webdatabase/SQLTransaction.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsstoragewebsqltransactionprototypeexpectedtxt">trunk/LayoutTests/storage/websql/transaction-prototype-expected.txt</a></li>
<li><a href="#trunkLayoutTestsstoragewebsqltransactionprototypehtml">trunk/LayoutTests/storage/websql/transaction-prototype.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/LayoutTests/ChangeLog 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -1,3 +1,21 @@
</span><ins>+2016-04-22 Chris Dumez <cdumez@apple.com>
+
+ Cannot access the SQLTransaction.constructor.prototype
+ https://bugs.webkit.org/show_bug.cgi?id=156613
+
+ Reviewed by Darin Adler.
+
+ Rebaseline existing test now that more SQL constructors are exposed on the
+ global Window object. Also add a test to confirm that it is possible to
+ access SQLTransaction.constructor.prototype and that it seems correct.
+
+ * js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac/js/dom/global-constructors-attributes-expected.txt:
+ * storage/websql/transaction-prototype-expected.txt: Added.
+ * storage/websql/transaction-prototype.html: Added.
+
</ins><span class="cx"> 2016-04-22 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Source directives lost when using Function constructor repeatedly
</span></span></pre></div>
<a id="trunkLayoutTestsjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -313,6 +313,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataTransfer').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataTransfer').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataTransfer').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'Database').value is Database
+PASS Object.getOwnPropertyDescriptor(global, 'Database').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DelayNode').value is DelayNode
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DelayNode').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DelayNode').hasOwnProperty('set') is false
</span><span class="lines">@@ -1008,11 +1013,31 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').value is SQLError
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').value is SQLException
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').value is SQLResultSet
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').value is SQLResultSetRowList
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').value is SQLTransaction
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').value is SVGAElement
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -328,6 +328,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataView').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataView').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataView').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'Database').value is Database
+PASS Object.getOwnPropertyDescriptor(global, 'Database').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Date').value is Date
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Date').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Date').hasOwnProperty('set') is false
</span><span class="lines">@@ -1188,11 +1193,31 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').value is SQLError
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').value is SQLException
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').value is SQLResultSet
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').value is SQLResultSetRowList
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').value is SQLTransaction
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').value is SVGAElement
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacmavericksjsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -298,6 +298,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataTransfer').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataTransfer').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataTransfer').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'Database').value is Database
+PASS Object.getOwnPropertyDescriptor(global, 'Database').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DelayNode').value is DelayNode
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DelayNode').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DelayNode').hasOwnProperty('set') is false
</span><span class="lines">@@ -1053,11 +1058,31 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').value is SQLError
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').value is SQLException
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').value is SQLResultSet
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').value is SQLResultSetRowList
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').value is SQLTransaction
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').value is SVGAElement
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsplatformmacyosemitejsdomglobalconstructorsattributesexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -328,6 +328,11 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataView').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataView').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'DataView').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'Database').value is Database
+PASS Object.getOwnPropertyDescriptor(global, 'Database').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'Database').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Date').value is Date
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Date').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Date').hasOwnProperty('set') is false
</span><span class="lines">@@ -1188,11 +1193,31 @@
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'Response').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').value is SQLError
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLError').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').value is SQLException
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').hasOwnProperty('set') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').enumerable is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SQLException').configurable is true
</span><ins>+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').value is SQLResultSet
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSet').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').value is SQLResultSetRowList
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLResultSetRowList').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').value is SQLTransaction
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SQLTransaction').configurable is true
</ins><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').value is SVGAElement
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').hasOwnProperty('get') is false
</span><span class="cx"> PASS Object.getOwnPropertyDescriptor(global, 'SVGAElement').hasOwnProperty('set') is false
</span></span></pre></div>
<a id="trunkLayoutTestsstoragewebsqltransactionprototypeexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/storage/websql/transaction-prototype-expected.txt (0 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/websql/transaction-prototype-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/websql/transaction-prototype-expected.txt 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+Tests that it is possible to access SQLTransaction.constructor.prototype and that it is correct
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS transaction.__proto__ is SQLTransaction.prototype
+PASS transaction.constructor is SQLTransaction
+PASS transaction.constructor.prototype is SQLTransaction.prototype
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsstoragewebsqltransactionprototypehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/storage/websql/transaction-prototype.html (0 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/storage/websql/transaction-prototype.html (rev 0)
+++ trunk/LayoutTests/storage/websql/transaction-prototype.html 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+<script src="../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that it is possible to access SQLTransaction.constructor.prototype and that it is correct");
+jsTestIsAsync = true;
+
+var db = openDatabase('mydb', '1.0', 'my first database', 2 * 1024 * 1024);
+
+db.transaction(function (tx) {
+ transaction = tx;
+ shouldBe("transaction.__proto__", "SQLTransaction.prototype");
+ shouldBe("transaction.constructor", "SQLTransaction");
+ shouldBe("transaction.constructor.prototype", "SQLTransaction.prototype");
+ finishJSTest();
+});
+</script>
+<script src="../../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/Source/WebCore/ChangeLog 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -1,3 +1,27 @@
</span><ins>+2016-04-22 Chris Dumez <cdumez@apple.com>
+
+ Cannot access the SQLTransaction.constructor.prototype
+ https://bugs.webkit.org/show_bug.cgi?id=156613
+
+ Reviewed by Darin Adler.
+
+ Drop [NoInterfaceObject] from the following SQL interfaces:
+ Database, SQLError, SQLResultSet, SQLResultSetRowList and SQLTransaction.
+
+ This matches the specification:
+ https://dev.w3.org/html5/webdatabase/
+
+ This was causing the 'constructor' property to be wrong for these
+ interfaces as it would be a generic Object.
+
+ Test: storage/websql/transaction-prototype.html
+
+ * Modules/webdatabase/Database.idl:
+ * Modules/webdatabase/SQLError.idl:
+ * Modules/webdatabase/SQLResultSet.idl:
+ * Modules/webdatabase/SQLResultSetRowList.idl:
+ * Modules/webdatabase/SQLTransaction.idl:
+
</ins><span class="cx"> 2016-04-22 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Include columnNumber in event listener locations
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseDatabaseidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/Database.idl (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/Database.idl 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/Source/WebCore/Modules/webdatabase/Database.idl 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -26,9 +26,7 @@
</span><span class="cx"> * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-[
- NoInterfaceObject,
-] interface Database {
</del><ins>+interface Database {
</ins><span class="cx"> readonly attribute DOMString version;
</span><span class="cx"> void changeVersion(DOMString oldVersion, DOMString newVersion, optional SQLTransactionCallback callback, optional SQLTransactionErrorCallback errorCallback, optional VoidCallback successCallback);
</span><span class="cx"> void transaction(SQLTransactionCallback callback, optional SQLTransactionErrorCallback errorCallback, optional VoidCallback successCallback);
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseSQLErroridl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/SQLError.idl (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/SQLError.idl 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLError.idl 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> [
</span><del>- NoInterfaceObject,
</del><span class="cx"> ImplementationLacksVTable
</span><span class="cx"> ] interface SQLError {
</span><span class="cx"> readonly attribute unsigned long code;
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseSQLResultSetidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/SQLResultSet.idl (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/SQLResultSet.idl 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLResultSet.idl 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> [
</span><del>- NoInterfaceObject,
</del><span class="cx"> ImplementationLacksVTable
</span><span class="cx"> ] interface SQLResultSet {
</span><span class="cx"> readonly attribute SQLResultSetRowList rows;
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseSQLResultSetRowListidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/SQLResultSetRowList.idl (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/SQLResultSetRowList.idl 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLResultSetRowList.idl 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> [
</span><del>- NoInterfaceObject,
</del><span class="cx"> ImplementationLacksVTable,
</span><span class="cx"> ] interface SQLResultSetRowList {
</span><span class="cx"> readonly attribute unsigned long length;
</span></span></pre></div>
<a id="trunkSourceWebCoreModuleswebdatabaseSQLTransactionidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/Modules/webdatabase/SQLTransaction.idl (199941 => 199942)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/Modules/webdatabase/SQLTransaction.idl 2016-04-23 00:45:27 UTC (rev 199941)
+++ trunk/Source/WebCore/Modules/webdatabase/SQLTransaction.idl 2016-04-23 00:58:01 UTC (rev 199942)
</span><span class="lines">@@ -27,7 +27,6 @@
</span><span class="cx"> */
</span><span class="cx">
</span><span class="cx"> [
</span><del>- NoInterfaceObject,
</del><span class="cx"> SkipVTableValidation,
</span><span class="cx"> ] interface SQLTransaction {
</span><span class="cx"> [Custom] void executeSql(DOMString sqlStatement,
</span></span></pre>
</div>
</div>
</body>
</html>