<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199790] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199790">199790</a></dd>
<dt>Author</dt> <dd>timothy@apple.com</dd>
<dt>Date</dt> <dd>2016-04-20 14:58:46 -0700 (Wed, 20 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Use debounce proxies in a couple more places
https://bugs.webkit.org/show_bug.cgi?id=156759
Reviewed by Joseph Pecoraro.
* UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser.prototype._dispatchCurrentRepresentedObjectsDidChangeEvent):
(WebInspector.ContentBrowser.prototype._contentViewSelectionPathComponentDidChange):
(WebInspector.ContentBrowser.prototype._contentViewSupplementalRepresentedObjectsDidChange):
(WebInspector.ContentBrowser.prototype._dispatchCurrentRepresentedObjectsDidChangeEventSoon): Deleted.
* UserInterface/Views/DOMTreeUpdater.js:
(WebInspector.DOMTreeUpdater.prototype._attributesUpdated):
(WebInspector.DOMTreeUpdater.prototype._characterDataModified):
(WebInspector.DOMTreeUpdater.prototype._nodeInserted):
(WebInspector.DOMTreeUpdater.prototype._nodeRemoved):
(WebInspector.DOMTreeUpdater.prototype._updateModifiedNodes):
(WebInspector.DOMTreeUpdater.prototype._updateModifiedNodesSoon): Deleted.
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel):
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
(WebInspector.NavigationSidebarPanel.prototype._treeElementDisclosureDidChange):
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibilitySoon): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsContentBrowserjs">trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeUpdaterjs">trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNavigationSidebarPaneljs">trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (199789 => 199790)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-04-20 21:58:44 UTC (rev 199789)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-04-20 21:58:46 UTC (rev 199790)
</span><span class="lines">@@ -1,5 +1,32 @@
</span><span class="cx"> 2016-04-19 Timothy Hatcher <timothy@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Use debounce proxies in a couple more places
+
+ https://bugs.webkit.org/show_bug.cgi?id=156759
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/ContentBrowser.js:
+ (WebInspector.ContentBrowser.prototype._dispatchCurrentRepresentedObjectsDidChangeEvent):
+ (WebInspector.ContentBrowser.prototype._contentViewSelectionPathComponentDidChange):
+ (WebInspector.ContentBrowser.prototype._contentViewSupplementalRepresentedObjectsDidChange):
+ (WebInspector.ContentBrowser.prototype._dispatchCurrentRepresentedObjectsDidChangeEventSoon): Deleted.
+ * UserInterface/Views/DOMTreeUpdater.js:
+ (WebInspector.DOMTreeUpdater.prototype._attributesUpdated):
+ (WebInspector.DOMTreeUpdater.prototype._characterDataModified):
+ (WebInspector.DOMTreeUpdater.prototype._nodeInserted):
+ (WebInspector.DOMTreeUpdater.prototype._nodeRemoved):
+ (WebInspector.DOMTreeUpdater.prototype._updateModifiedNodes):
+ (WebInspector.DOMTreeUpdater.prototype._updateModifiedNodesSoon): Deleted.
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WebInspector.NavigationSidebarPanel):
+ (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
+ (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
+ (WebInspector.NavigationSidebarPanel.prototype._treeElementDisclosureDidChange):
+ (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibilitySoon): Deleted.
+
+2016-04-19 Timothy Hatcher <timothy@apple.com>
+
</ins><span class="cx"> Web Inspector: Make debounce use an ES6 Proxy
</span><span class="cx">
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=156756
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsContentBrowserjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js (199789 => 199790)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js 2016-04-20 21:58:44 UTC (rev 199789)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js 2016-04-20 21:58:46 UTC (rev 199790)
</span><span class="lines">@@ -421,19 +421,9 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- _dispatchCurrentRepresentedObjectsDidChangeEventSoon()
- {
- if (this._currentRepresentedObjectsDidChangeTimeout)
- return;
- this._currentRepresentedObjectsDidChangeTimeout = setTimeout(this._dispatchCurrentRepresentedObjectsDidChangeEvent.bind(this), 0);
- }
-
</del><span class="cx"> _dispatchCurrentRepresentedObjectsDidChangeEvent()
</span><span class="cx"> {
</span><del>- if (this._currentRepresentedObjectsDidChangeTimeout) {
- clearTimeout(this._currentRepresentedObjectsDidChangeTimeout);
- delete this._currentRepresentedObjectsDidChangeTimeout;
- }
</del><ins>+ this._dispatchCurrentRepresentedObjectsDidChangeEvent.cancelDebounce();
</ins><span class="cx">
</span><span class="cx"> this.dispatchEventToListeners(WebInspector.ContentBrowser.Event.CurrentRepresentedObjectsDidChange);
</span><span class="cx"> }
</span><span class="lines">@@ -450,7 +440,7 @@
</span><span class="cx">
</span><span class="cx"> this._navigationBar.needsLayout();
</span><span class="cx">
</span><del>- this._dispatchCurrentRepresentedObjectsDidChangeEventSoon();
</del><ins>+ this.soon._dispatchCurrentRepresentedObjectsDidChangeEvent();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _contentViewSupplementalRepresentedObjectsDidChange(event)
</span><span class="lines">@@ -458,7 +448,7 @@
</span><span class="cx"> if (event.target !== this.currentContentView)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- this._dispatchCurrentRepresentedObjectsDidChangeEventSoon();
</del><ins>+ this.soon._dispatchCurrentRepresentedObjectsDidChangeEvent();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _currentContentViewDidChange(event)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsDOMTreeUpdaterjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js (199789 => 199790)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js 2016-04-20 21:58:44 UTC (rev 199789)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js 2016-04-20 21:58:46 UTC (rev 199790)
</span><span class="lines">@@ -57,28 +57,28 @@
</span><span class="cx"> {
</span><span class="cx"> this._recentlyModifiedNodes.push({node: event.data.node, updated: true, attribute: event.data.name});
</span><span class="cx"> if (this._treeOutline._visible)
</span><del>- this._updateModifiedNodesSoon();
</del><ins>+ this.soon._updateModifiedNodes();
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _characterDataModified: function(event)
</span><span class="cx"> {
</span><span class="cx"> this._recentlyModifiedNodes.push({node: event.data.node, updated: true});
</span><span class="cx"> if (this._treeOutline._visible)
</span><del>- this._updateModifiedNodesSoon();
</del><ins>+ this.soon._updateModifiedNodes();
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _nodeInserted: function(event)
</span><span class="cx"> {
</span><span class="cx"> this._recentlyModifiedNodes.push({node: event.data.node, parent: event.data.parent, inserted: true});
</span><span class="cx"> if (this._treeOutline._visible)
</span><del>- this._updateModifiedNodesSoon();
</del><ins>+ this.soon._updateModifiedNodes();
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _nodeRemoved: function(event)
</span><span class="cx"> {
</span><span class="cx"> this._recentlyModifiedNodes.push({node: event.data.node, parent: event.data.parent, removed: true});
</span><span class="cx"> if (this._treeOutline._visible)
</span><del>- this._updateModifiedNodesSoon();
</del><ins>+ this.soon._updateModifiedNodes();
</ins><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> _childNodeCountUpdated: function(event)
</span><span class="lines">@@ -88,19 +88,9 @@
</span><span class="cx"> treeElement.hasChildren = event.data.hasChildNodes();
</span><span class="cx"> },
</span><span class="cx">
</span><del>- _updateModifiedNodesSoon: function()
- {
- if (this._updateModifiedNodesTimeout)
- return;
- this._updateModifiedNodesTimeout = setTimeout(this._updateModifiedNodes.bind(this), 0);
- },
-
</del><span class="cx"> _updateModifiedNodes: function()
</span><span class="cx"> {
</span><del>- if (this._updateModifiedNodesTimeout) {
- clearTimeout(this._updateModifiedNodesTimeout);
- this._updateModifiedNodesTimeout = null;
- }
</del><ins>+ this._updateModifiedNodes.cancelDebounce();
</ins><span class="cx">
</span><span class="cx"> let updatedParentTreeElements = [];
</span><span class="cx"> for (let recentlyModifiedNode of this._recentlyModifiedNodes) {
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNavigationSidebarPaneljs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (199789 => 199790)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2016-04-20 21:58:44 UTC (rev 199789)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2016-04-20 21:58:46 UTC (rev 199790)
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx">
</span><span class="cx"> this._visibleContentTreeOutlines = new Set;
</span><span class="cx">
</span><del>- this.contentView.element.addEventListener("scroll", this._updateContentOverflowShadowVisibilitySoon.bind(this));
</del><ins>+ this.contentView.element.addEventListener("scroll", this.soon._updateContentOverflowShadowVisibility);
</ins><span class="cx">
</span><span class="cx"> this._contentTreeOutline = this.createContentTreeOutline(true);
</span><span class="cx"> this._selectedContentTreeOutline = null;
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> this.element.appendChild(this._topOverflowShadowElement);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- this._boundUpdateContentOverflowShadowVisibility = this._updateContentOverflowShadowVisibilitySoon.bind(this);
</del><ins>+ this._boundUpdateContentOverflowShadowVisibility = this.soon._updateContentOverflowShadowVisibility;
</ins><span class="cx"> window.addEventListener("resize", this._boundUpdateContentOverflowShadowVisibility);
</span><span class="cx">
</span><span class="cx"> this._filtersSetting = new WebInspector.Setting(identifier + "-navigation-sidebar-filters", {});
</span><span class="lines">@@ -486,18 +486,10 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Private
</span><del>-
- _updateContentOverflowShadowVisibilitySoon()
- {
- if (this._updateContentOverflowShadowVisibilityIdentifier)
- return;
</del><span class="cx">
</span><del>- this._updateContentOverflowShadowVisibilityIdentifier = setTimeout(this._updateContentOverflowShadowVisibility.bind(this), 0);
- }
-
</del><span class="cx"> _updateContentOverflowShadowVisibility()
</span><span class="cx"> {
</span><del>- this._updateContentOverflowShadowVisibilityIdentifier = undefined;
</del><ins>+ this._updateContentOverflowShadowVisibility.cancelDebounce();
</ins><span class="cx">
</span><span class="cx"> let scrollHeight = this.contentView.element.scrollHeight;
</span><span class="cx"> let offsetHeight = this.contentView.element.offsetHeight;
</span><span class="lines">@@ -636,7 +628,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> this._checkForEmptyFilterResults();
</span><del>- this._updateContentOverflowShadowVisibilitySoon();
</del><ins>+ this.soon._updateContentOverflowShadowVisibility();
</ins><span class="cx">
</span><span class="cx"> if (this.selected)
</span><span class="cx"> this._checkElementsForPendingViewStateCookie([treeElement]);
</span><span class="lines">@@ -646,7 +638,7 @@
</span><span class="cx">
</span><span class="cx"> _treeElementDisclosureDidChange(event)
</span><span class="cx"> {
</span><del>- this._updateContentOverflowShadowVisibilitySoon();
</del><ins>+ this.soon._updateContentOverflowShadowVisibility();
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> _treeSelectionDidChange(event)
</span></span></pre>
</div>
</div>
</body>
</html>