<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199787] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199787">199787</a></dd>
<dt>Author</dt> <dd>sbarati@apple.com</dd>
<dt>Date</dt> <dd>2016-04-20 14:47:39 -0700 (Wed, 20 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>We don't need a manual stack for an RAII object when the machine's stack will do just fine
https://bugs.webkit.org/show_bug.cgi?id=156807
Reviewed by Mark Lam.
We kept around a vector for an RAII object to maintain
the recursive nature of having these RAII objects on
the stack as the parser recursed. Instead, the RAII object
can just have a field with the value it wants to restore
and use the machine's stack.
This is a 1% octane code-load progression.
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::BinaryExprContext::BinaryExprContext):
(JSC::SyntaxChecker::BinaryExprContext::~BinaryExprContext):
(JSC::SyntaxChecker::UnaryExprContext::UnaryExprContext):
(JSC::SyntaxChecker::UnaryExprContext::~UnaryExprContext):
(JSC::SyntaxChecker::operatorStackPop):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreparserSyntaxCheckerh">trunk/Source/JavaScriptCore/parser/SyntaxChecker.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (199786 => 199787)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-04-20 21:25:11 UTC (rev 199786)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-04-20 21:47:39 UTC (rev 199787)
</span><span class="lines">@@ -1,3 +1,25 @@
</span><ins>+2016-04-20 Saam barati <sbarati@apple.com>
+
+ We don't need a manual stack for an RAII object when the machine's stack will do just fine
+ https://bugs.webkit.org/show_bug.cgi?id=156807
+
+ Reviewed by Mark Lam.
+
+ We kept around a vector for an RAII object to maintain
+ the recursive nature of having these RAII objects on
+ the stack as the parser recursed. Instead, the RAII object
+ can just have a field with the value it wants to restore
+ and use the machine's stack.
+
+ This is a 1% octane code-load progression.
+
+ * parser/SyntaxChecker.h:
+ (JSC::SyntaxChecker::BinaryExprContext::BinaryExprContext):
+ (JSC::SyntaxChecker::BinaryExprContext::~BinaryExprContext):
+ (JSC::SyntaxChecker::UnaryExprContext::UnaryExprContext):
+ (JSC::SyntaxChecker::UnaryExprContext::~UnaryExprContext):
+ (JSC::SyntaxChecker::operatorStackPop):
+
</ins><span class="cx"> 2016-04-20 Michael Saboff <msaboff@apple.com>
</span><span class="cx">
</span><span class="cx"> REGRESSION(r190289): Spin trying to view/sign in to hbogo.com
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreparserSyntaxCheckerh"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/parser/SyntaxChecker.h (199786 => 199787)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/parser/SyntaxChecker.h 2016-04-20 21:25:11 UTC (rev 199786)
+++ trunk/Source/JavaScriptCore/parser/SyntaxChecker.h 2016-04-20 21:47:39 UTC (rev 199787)
</span><span class="lines">@@ -38,30 +38,30 @@
</span><span class="cx"> BinaryExprContext(SyntaxChecker& context)
</span><span class="cx"> : m_context(&context)
</span><span class="cx"> {
</span><del>- m_context->m_topBinaryExprs.append(m_context->m_topBinaryExpr);
</del><ins>+ m_token = m_context->m_topBinaryExpr;
</ins><span class="cx"> m_context->m_topBinaryExpr = 0;
</span><span class="cx"> }
</span><span class="cx"> ~BinaryExprContext()
</span><span class="cx"> {
</span><del>- m_context->m_topBinaryExpr = m_context->m_topBinaryExprs.last();
- m_context->m_topBinaryExprs.removeLast();
</del><ins>+ m_context->m_topBinaryExpr = m_token;
</ins><span class="cx"> }
</span><span class="cx"> private:
</span><ins>+ int m_token;
</ins><span class="cx"> SyntaxChecker* m_context;
</span><span class="cx"> };
</span><span class="cx"> struct UnaryExprContext {
</span><span class="cx"> UnaryExprContext(SyntaxChecker& context)
</span><span class="cx"> : m_context(&context)
</span><span class="cx"> {
</span><del>- m_context->m_topUnaryTokens.append(m_context->m_topUnaryToken);
</del><ins>+ m_token = m_context->m_topUnaryToken;
</ins><span class="cx"> m_context->m_topUnaryToken = 0;
</span><span class="cx"> }
</span><span class="cx"> ~UnaryExprContext()
</span><span class="cx"> {
</span><del>- m_context->m_topUnaryToken = m_context->m_topUnaryTokens.last();
- m_context->m_topUnaryTokens.removeLast();
</del><ins>+ m_context->m_topUnaryToken = m_token;
</ins><span class="cx"> }
</span><span class="cx"> private:
</span><ins>+ int m_token;
</ins><span class="cx"> SyntaxChecker* m_context;
</span><span class="cx"> };
</span><span class="cx">
</span><span class="lines">@@ -397,8 +397,6 @@
</span><span class="cx"> private:
</span><span class="cx"> int m_topBinaryExpr;
</span><span class="cx"> int m_topUnaryToken;
</span><del>- Vector<int, 8> m_topBinaryExprs;
- Vector<int, 8> m_topUnaryTokens;
</del><span class="cx"> };
</span><span class="cx">
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>