<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199634] trunk/Source/WebInspectorUI</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199634">199634</a></dd>
<dt>Author</dt> <dd>mattbaker@apple.com</dd>
<dt>Date</dt> <dd>2016-04-16 18:20:00 -0700 (Sat, 16 Apr 2016)</dd>
</dl>

<h3>Log Message</h3>
<pre>display:inline on the tbody is causing the width of the iframe to be shrunk to the minimum size of its text.
https://bugs.webkit.org/show_bug.cgi?id=15666

Reviewed by Timothy Hatcher.

Fix a regression caused by the recent Timelines UI redesign, and
reorder TimelineDataGrid's constructor arguments now that most
timeline views no longer have an associated tree outline.

* UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView):
* UserInterface/Views/LayoutTimelineView.js:
(WebInspector.LayoutTimelineView):
* UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView):
* UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView):
* UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView):
* UserInterface/Views/ScriptDetailsTimelineView.js:
(WebInspector.ScriptDetailsTimelineView):
Reorder constructor parameters and omit optional treeOutline and
synchronizerDelegate arguments when they aren't needed.

* UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid):
Reorder constructor arguments so that treeOutline can be optional.
(WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
Nodes should be refreshed and re-inserted in the data grid without
requiring a grid synchronizer. If a synchronizer exists, re-insert
the tree element for the node. Since the syncronizer is disabled the
order of grid/tree operations doesn't matter.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsHeapAllocationsTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLayoutTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNetworkGridContentViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsNetworkTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsRenderingFrameTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsScriptDetailsTimelineViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTimelineDataGridjs">trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (199633 => 199634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog        2016-04-17 00:40:55 UTC (rev 199633)
+++ trunk/Source/WebInspectorUI/ChangeLog        2016-04-17 01:20:00 UTC (rev 199634)
</span><span class="lines">@@ -1,3 +1,38 @@
</span><ins>+2016-04-16  Matt Baker  &lt;mattbaker@apple.com&gt;
+
+        display:inline on the tbody is causing the width of the iframe to be shrunk to the minimum size of its text.
+        https://bugs.webkit.org/show_bug.cgi?id=15666
+
+        Reviewed by Timothy Hatcher.
+
+        Fix a regression caused by the recent Timelines UI redesign, and
+        reorder TimelineDataGrid's constructor arguments now that most
+        timeline views no longer have an associated tree outline.
+
+        * UserInterface/Views/HeapAllocationsTimelineView.js:
+        (WebInspector.HeapAllocationsTimelineView):
+        * UserInterface/Views/LayoutTimelineView.js:
+        (WebInspector.LayoutTimelineView):
+        * UserInterface/Views/NetworkGridContentView.js:
+        (WebInspector.NetworkGridContentView):
+        * UserInterface/Views/NetworkTimelineView.js:
+        (WebInspector.NetworkTimelineView):
+        * UserInterface/Views/RenderingFrameTimelineView.js:
+        (WebInspector.RenderingFrameTimelineView):
+        * UserInterface/Views/ScriptDetailsTimelineView.js:
+        (WebInspector.ScriptDetailsTimelineView):
+        Reorder constructor parameters and omit optional treeOutline and
+        synchronizerDelegate arguments when they aren't needed.
+
+        * UserInterface/Views/TimelineDataGrid.js:
+        (WebInspector.TimelineDataGrid):
+        Reorder constructor arguments so that treeOutline can be optional.
+        (WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
+        Nodes should be refreshed and re-inserted in the data grid without
+        requiring a grid synchronizer. If a synchronizer exists, re-insert
+        the tree element for the node. Since the syncronizer is disabled the
+        order of grid/tree operations doesn't matter.
+
</ins><span class="cx"> 2016-04-15  Joseph Pecoraro  &lt;pecoraro@apple.com&gt;
</span><span class="cx"> 
</span><span class="cx">         Web Inspector: sourceMappingURL not used when sourceURL is set
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsHeapAllocationsTimelineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js (199633 => 199634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js        2016-04-17 00:40:55 UTC (rev 199633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js        2016-04-17 01:20:00 UTC (rev 199634)
</span><span class="lines">@@ -75,7 +75,7 @@
</span><span class="cx">         this._snapshotListPathComponent = new WebInspector.HierarchicalPathComponent(WebInspector.UIString(&quot;Snapshot List&quot;), &quot;snapshot-list-icon&quot;, &quot;snapshot-list&quot;, false, false);
</span><span class="cx">         this._snapshotListPathComponent.addEventListener(WebInspector.HierarchicalPathComponent.Event.Clicked, this._snapshotListPathComponentClicked, this);
</span><span class="cx"> 
</span><del>-        this._dataGrid = new WebInspector.TimelineDataGrid(null, columns);
</del><ins>+        this._dataGrid = new WebInspector.TimelineDataGrid(columns);
</ins><span class="cx">         this._dataGrid.sortColumnIdentifierSetting = new WebInspector.Setting(&quot;heap-allocations-timeline-view-sort&quot;, &quot;timestamp&quot;);
</span><span class="cx">         this._dataGrid.sortOrderSetting = new WebInspector.Setting(&quot;heap-allocations-timeline-view-sort-order&quot;, WebInspector.DataGrid.SortOrder.Ascending);
</span><span class="cx">         this._dataGrid.addEventListener(WebInspector.DataGrid.Event.SelectedNodeChanged, this._dataGridNodeSelected, this);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsLayoutTimelineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js (199633 => 199634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js        2016-04-17 00:40:55 UTC (rev 199633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LayoutTimelineView.js        2016-04-17 01:20:00 UTC (rev 199634)
</span><span class="lines">@@ -68,7 +68,7 @@
</span><span class="cx">         for (var column in columns)
</span><span class="cx">             columns[column].sortable = true;
</span><span class="cx"> 
</span><del>-        this._dataGrid = new WebInspector.LayoutTimelineDataGrid(null, columns);
</del><ins>+        this._dataGrid = new WebInspector.LayoutTimelineDataGrid(columns);
</ins><span class="cx">         this._dataGrid.addEventListener(WebInspector.TimelineDataGrid.Event.FiltersDidChange, this._dataGridFiltersDidChange, this);
</span><span class="cx">         this._dataGrid.addEventListener(WebInspector.DataGrid.Event.SelectedNodeChanged, this._dataGridNodeSelected, this);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNetworkGridContentViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js (199633 => 199634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js        2016-04-17 00:40:55 UTC (rev 199633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js        2016-04-17 01:20:00 UTC (rev 199634)
</span><span class="lines">@@ -80,7 +80,7 @@
</span><span class="cx">         for (var column in columns)
</span><span class="cx">             columns[column].sortable = true;
</span><span class="cx"> 
</span><del>-        this._dataGrid = new WebInspector.TimelineDataGrid(this._contentTreeOutline, columns);
</del><ins>+        this._dataGrid = new WebInspector.TimelineDataGrid(columns, this._contentTreeOutline);
</ins><span class="cx">         this._dataGrid.addEventListener(WebInspector.DataGrid.Event.SelectedNodeChanged, this._dataGridNodeSelected, this);
</span><span class="cx">         this._dataGrid.sortColumnIdentifierSetting = new WebInspector.Setting(&quot;network-grid-content-view-sort&quot;, &quot;requestSent&quot;);
</span><span class="cx">         this._dataGrid.sortOrderSetting = new WebInspector.Setting(&quot;network-grid-content-view-sort-order&quot;, WebInspector.DataGrid.SortOrder.Ascending);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsNetworkTimelineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js (199633 => 199634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js        2016-04-17 00:40:55 UTC (rev 199633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js        2016-04-17 01:20:00 UTC (rev 199634)
</span><span class="lines">@@ -87,7 +87,7 @@
</span><span class="cx">         for (var column in columns)
</span><span class="cx">             columns[column].sortable = true;
</span><span class="cx"> 
</span><del>-        this._dataGrid = new WebInspector.TimelineDataGrid(null, columns);
</del><ins>+        this._dataGrid = new WebInspector.TimelineDataGrid(columns);
</ins><span class="cx">         this._dataGrid.addEventListener(WebInspector.TimelineDataGrid.Event.FiltersDidChange, this._dataGridFiltersDidChange, this);
</span><span class="cx">         this._dataGrid.addEventListener(WebInspector.DataGrid.Event.SelectedNodeChanged, this._dataGridNodeSelected, this);
</span><span class="cx">         this._dataGrid.sortColumnIdentifierSetting = new WebInspector.Setting(&quot;network-timeline-view-sort&quot;, &quot;requestSent&quot;);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsRenderingFrameTimelineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js (199633 => 199634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js        2016-04-17 00:40:55 UTC (rev 199633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js        2016-04-17 01:20:00 UTC (rev 199634)
</span><span class="lines">@@ -76,7 +76,7 @@
</span><span class="cx">         for (var column in columns)
</span><span class="cx">             columns[column].sortable = true;
</span><span class="cx"> 
</span><del>-        this._dataGrid = new WebInspector.TimelineDataGrid(null, columns, this);
</del><ins>+        this._dataGrid = new WebInspector.TimelineDataGrid(columns);
</ins><span class="cx">         this._dataGrid.addEventListener(WebInspector.DataGrid.Event.SelectedNodeChanged, this._dataGridNodeSelected, this);
</span><span class="cx">         this._dataGrid.sortColumnIdentifierSetting = new WebInspector.Setting(&quot;rendering-frame-timeline-view-sort&quot;, &quot;startTime&quot;);
</span><span class="cx">         this._dataGrid.sortOrderSetting = new WebInspector.Setting(&quot;rendering-frame-timeline-view-sort-order&quot;, WebInspector.DataGrid.SortOrder.Ascending);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsScriptDetailsTimelineViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js (199633 => 199634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js        2016-04-17 00:40:55 UTC (rev 199633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js        2016-04-17 01:20:00 UTC (rev 199634)
</span><span class="lines">@@ -71,7 +71,7 @@
</span><span class="cx">         for (var column in columns)
</span><span class="cx">             columns[column].sortable = true;
</span><span class="cx"> 
</span><del>-        this._dataGrid = new WebInspector.ScriptTimelineDataGrid(null, columns, this);
</del><ins>+        this._dataGrid = new WebInspector.ScriptTimelineDataGrid(columns);
</ins><span class="cx">         this._dataGrid.addEventListener(WebInspector.TimelineDataGrid.Event.FiltersDidChange, this._dataGridFiltersDidChange, this);
</span><span class="cx">         this._dataGrid.addEventListener(WebInspector.DataGrid.Event.SelectedNodeChanged, this._dataGridNodeSelected, this);
</span><span class="cx">         this._dataGrid.sortColumnIdentifierSetting = new WebInspector.Setting(&quot;script-timeline-view-sort&quot;, &quot;startTime&quot;);
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTimelineDataGridjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js (199633 => 199634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js        2016-04-17 00:40:55 UTC (rev 199633)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js        2016-04-17 01:20:00 UTC (rev 199634)
</span><span class="lines">@@ -25,7 +25,7 @@
</span><span class="cx"> 
</span><span class="cx"> WebInspector.TimelineDataGrid = class TimelineDataGrid extends WebInspector.DataGrid
</span><span class="cx"> {
</span><del>-    constructor(treeOutline, columns, delegate, editCallback, deleteCallback)
</del><ins>+    constructor(columns, treeOutline, delegate, editCallback, deleteCallback)
</ins><span class="cx">     {
</span><span class="cx">         super(columns, editCallback, deleteCallback);
</span><span class="cx"> 
</span><span class="lines">@@ -226,16 +226,16 @@
</span><span class="cx">             this._scheduledDataGridNodeRefreshIdentifier = undefined;
</span><span class="cx">         }
</span><span class="cx"> 
</span><del>-        if (!this._dirtyDataGridNodes || !this._treeOutlineDataGridSynchronizer)
</del><ins>+        if (!this._dirtyDataGridNodes)
</ins><span class="cx">             return;
</span><span class="cx"> 
</span><del>-        var selectedNode = this.selectedNode;
-        var sortComparator = this._sortComparator.bind(this);
-        var treeOutline = this._treeOutlineDataGridSynchronizer.treeOutline;
</del><ins>+        let selectedNode = this.selectedNode;
+        let sortComparator = this._sortComparator.bind(this);
</ins><span class="cx"> 
</span><del>-        this._treeOutlineDataGridSynchronizer.enabled = false;
</del><ins>+        if (this._treeOutlineDataGridSynchronizer)
+            this._treeOutlineDataGridSynchronizer.enabled = false;
</ins><span class="cx"> 
</span><del>-        for (var dataGridNode of this._dirtyDataGridNodes) {
</del><ins>+        for (let dataGridNode of this._dirtyDataGridNodes) {
</ins><span class="cx">             dataGridNode.refresh();
</span><span class="cx"> 
</span><span class="cx">             if (!this.sortColumnIdentifier)
</span><span class="lines">@@ -244,32 +244,38 @@
</span><span class="cx">             if (dataGridNode === selectedNode)
</span><span class="cx">                 this._ignoreSelectionEvent = true;
</span><span class="cx"> 
</span><del>-            var treeElement = this._treeOutlineDataGridSynchronizer.treeElementForDataGridNode(dataGridNode);
</del><ins>+            console.assert(!dataGridNode.parent || dataGridNode.parent === this);
+            if (dataGridNode.parent === this)
+                this.removeChild(dataGridNode);
+
+            let insertionIndex = insertionIndexForObjectInListSortedByFunction(dataGridNode, this.children, sortComparator);
+            this.insertChild(dataGridNode, insertionIndex);
+
+            if (dataGridNode === selectedNode) {
+                selectedNode.revealAndSelect();
+                this._ignoreSelectionEvent = false;
+            }
+
+            if (!this._treeOutlineDataGridSynchronizer)
+                continue;
+
+            let treeOutline = this._treeOutlineDataGridSynchronizer.treeOutline;
+            let treeElement = this._treeOutlineDataGridSynchronizer.treeElementForDataGridNode(dataGridNode);
</ins><span class="cx">             console.assert(treeElement);
</span><span class="cx"> 
</span><span class="cx">             console.assert(!treeElement.parent || treeElement.parent === treeOutline);
</span><span class="cx">             if (treeElement.parent === treeOutline)
</span><span class="cx">                 treeOutline.removeChild(treeElement);
</span><span class="cx"> 
</span><del>-            console.assert(!dataGridNode.parent || dataGridNode.parent === this);
-            if (dataGridNode.parent === this)
-                this.removeChild(dataGridNode);
-
-            var insertionIndex = insertionIndexForObjectInListSortedByFunction(dataGridNode, this.children, sortComparator);
</del><span class="cx">             treeOutline.insertChild(treeElement, insertionIndex);
</span><del>-            this.insertChild(dataGridNode, insertionIndex);
</del><span class="cx"> 
</span><span class="cx">             // Adding the tree element back to the tree outline subjects it to filters.
</span><span class="cx">             // Make sure we keep the hidden state in-sync while the synchronizer is disabled.
</span><span class="cx">             dataGridNode.element.classList.toggle(&quot;hidden&quot;, treeElement.hidden);
</span><del>-
-            if (dataGridNode === selectedNode) {
-                selectedNode.revealAndSelect();
-                this._ignoreSelectionEvent = false;
-            }
</del><span class="cx">         }
</span><span class="cx"> 
</span><del>-        this._treeOutlineDataGridSynchronizer.enabled = true;
</del><ins>+        if (this._treeOutlineDataGridSynchronizer)
+            this._treeOutlineDataGridSynchronizer.enabled = true;
</ins><span class="cx"> 
</span><span class="cx">         this._dirtyDataGridNodes = null;
</span><span class="cx">     }
</span></span></pre>
</div>
</div>

</body>
</html>