<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199592] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199592">199592</a></dd>
<dt>Author</dt> <dd>joepeck@webkit.org</dd>
<dt>Date</dt> <dd>2016-04-15 10:18:12 -0700 (Fri, 15 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: Cleanup inspector/debugger tests
https://bugs.webkit.org/show_bug.cgi?id=156619
Reviewed by Brian Burg.
Source/JavaScriptCore:
While cleaning up the tests it exposed the fact that breakpoints
were not getting disabled when the inspector closes. This means
that opening the inspector, with breakpoints, and closing the
inspector, would leave the JSC::Debugger thinking breakpoints
are active. The JSC::Debugger should be reset.
* inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::disable):
Source/WebInspectorUI:
* UserInterface/Base/Main.js:
(WebInspector.loaded):
* UserInterface/Controllers/DebuggerManager.js:
Remove agent checks for agents that are always available.
LayoutTests:
* inspector/debugger/breakpoint-action-detach.html:
* inspector/debugger/breakpoint-action-with-exception.html:
* inspector/debugger/breakpoint-condition-detach.html:
* inspector/debugger/breakpoint-condition-with-bad-script.html:
* inspector/debugger/breakpoint-condition-with-exception.html:
* inspector/debugger/breakpoint-eval-with-exception.html:
* inspector/debugger/breakpoint-inside-conditons-and-actions.html:
* inspector/debugger/call-frame-function-name.html:
* inspector/debugger/call-frame-this-host.html:
* inspector/debugger/call-frame-this-nonstrict.html:
* inspector/debugger/call-frame-this-strict.html:
* inspector/debugger/debugger-statement.html:
* inspector/debugger/didSampleProbe-multiple-probes.html:
* inspector/debugger/hit-breakpoint-from-console.html:
* inspector/debugger/nested-inspectors.html:
* inspector/debugger/pause-on-assert.html:
* inspector/debugger/regress-133182.html:
* inspector/debugger/removeBreakpoint.html:
* inspector/debugger/setBreakpoint-actions.html:
* inspector/debugger/setBreakpoint-autoContinue.html:
* inspector/debugger/setBreakpoint-column.html:
* inspector/debugger/setBreakpoint-condition.html:
* inspector/debugger/setBreakpoint-dfg-and-modify-local.html:
* inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:
* inspector/debugger/setBreakpoint-dfg.html:
* inspector/debugger/setBreakpoint-options-exception.html:
* inspector/debugger/setBreakpoint.html:
* inspector/debugger/setBreakpointByUrl-sourceURL.html:
* inspector/debugger/setPauseOnExceptions-all.html:
* inspector/debugger/setPauseOnExceptions-none.html:
* inspector/debugger/setPauseOnExceptions-uncaught.html:
Activate breakpoints in protocol tests that may set breakpoints and pause.
Inspector tests automatically enable breakpoints.
* inspector/debugger/setVariableValue-expected.txt: Removed.
* inspector/debugger/setVariableValue.html: Removed.
* platform/gtk/TestExpectations:
Remove references to bad test. The protocol command no longer exists.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerbreakpointactiondetachhtml">trunk/LayoutTests/inspector/debugger/breakpoint-action-detach.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerbreakpointactionwithexceptionhtml">trunk/LayoutTests/inspector/debugger/breakpoint-action-with-exception.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerbreakpointconditiondetachhtml">trunk/LayoutTests/inspector/debugger/breakpoint-condition-detach.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerbreakpointconditionwithbadscripthtml">trunk/LayoutTests/inspector/debugger/breakpoint-condition-with-bad-script.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerbreakpointconditionwithexceptionhtml">trunk/LayoutTests/inspector/debugger/breakpoint-condition-with-exception.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerbreakpointevalwithexceptionhtml">trunk/LayoutTests/inspector/debugger/breakpoint-eval-with-exception.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerbreakpointinsideconditonsandactionshtml">trunk/LayoutTests/inspector/debugger/breakpoint-inside-conditons-and-actions.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggercallframefunctionnamehtml">trunk/LayoutTests/inspector/debugger/call-frame-function-name.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggercallframethishosthtml">trunk/LayoutTests/inspector/debugger/call-frame-this-host.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggercallframethisnonstricthtml">trunk/LayoutTests/inspector/debugger/call-frame-this-nonstrict.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggercallframethisstricthtml">trunk/LayoutTests/inspector/debugger/call-frame-this-strict.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerdebuggerstatementhtml">trunk/LayoutTests/inspector/debugger/debugger-statement.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerdidSampleProbemultipleprobeshtml">trunk/LayoutTests/inspector/debugger/didSampleProbe-multiple-probes.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerhitbreakpointfromconsolehtml">trunk/LayoutTests/inspector/debugger/hit-breakpoint-from-console.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggernestedinspectorshtml">trunk/LayoutTests/inspector/debugger/nested-inspectors.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerpauseonasserthtml">trunk/LayoutTests/inspector/debugger/pause-on-assert.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerregress133182html">trunk/LayoutTests/inspector/debugger/regress-133182.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggerremoveBreakpointhtml">trunk/LayoutTests/inspector/debugger/removeBreakpoint.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetBreakpointactionshtml">trunk/LayoutTests/inspector/debugger/setBreakpoint-actions.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetBreakpointautoContinuehtml">trunk/LayoutTests/inspector/debugger/setBreakpoint-autoContinue.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetBreakpointcolumnhtml">trunk/LayoutTests/inspector/debugger/setBreakpoint-column.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetBreakpointconditionhtml">trunk/LayoutTests/inspector/debugger/setBreakpoint-condition.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetBreakpointdfgandmodifylocalhtml">trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-and-modify-local.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetBreakpointdfgcalleeandexaminedfglocalhtml">trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetBreakpointdfghtml">trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetBreakpointoptionsexceptionhtml">trunk/LayoutTests/inspector/debugger/setBreakpoint-options-exception.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetBreakpointhtml">trunk/LayoutTests/inspector/debugger/setBreakpoint.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetBreakpointByUrlsourceURLhtml">trunk/LayoutTests/inspector/debugger/setBreakpointByUrl-sourceURL.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetPauseOnExceptionsallhtml">trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-all.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetPauseOnExceptionsnonehtml">trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-none.html</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetPauseOnExceptionsuncaughthtml">trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-uncaught.html</a></li>
<li><a href="#trunkLayoutTestsplatformgtkTestExpectations">trunk/LayoutTests/platform/gtk/TestExpectations</a></li>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectoragentsInspectorDebuggerAgentcpp">trunk/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseMainjs">trunk/Source/WebInspectorUI/UserInterface/Base/Main.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceControllersDebuggerManagerjs">trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsinspectordebuggersetVariableValueexpectedtxt">trunk/LayoutTests/inspector/debugger/setVariableValue-expected.txt</a></li>
<li><a href="#trunkLayoutTestsinspectordebuggersetVariableValuehtml">trunk/LayoutTests/inspector/debugger/setVariableValue.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/ChangeLog 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -1,3 +1,49 @@
</span><ins>+2016-04-14 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Cleanup inspector/debugger tests
+ https://bugs.webkit.org/show_bug.cgi?id=156619
+
+ Reviewed by Brian Burg.
+
+ * inspector/debugger/breakpoint-action-detach.html:
+ * inspector/debugger/breakpoint-action-with-exception.html:
+ * inspector/debugger/breakpoint-condition-detach.html:
+ * inspector/debugger/breakpoint-condition-with-bad-script.html:
+ * inspector/debugger/breakpoint-condition-with-exception.html:
+ * inspector/debugger/breakpoint-eval-with-exception.html:
+ * inspector/debugger/breakpoint-inside-conditons-and-actions.html:
+ * inspector/debugger/call-frame-function-name.html:
+ * inspector/debugger/call-frame-this-host.html:
+ * inspector/debugger/call-frame-this-nonstrict.html:
+ * inspector/debugger/call-frame-this-strict.html:
+ * inspector/debugger/debugger-statement.html:
+ * inspector/debugger/didSampleProbe-multiple-probes.html:
+ * inspector/debugger/hit-breakpoint-from-console.html:
+ * inspector/debugger/nested-inspectors.html:
+ * inspector/debugger/pause-on-assert.html:
+ * inspector/debugger/regress-133182.html:
+ * inspector/debugger/removeBreakpoint.html:
+ * inspector/debugger/setBreakpoint-actions.html:
+ * inspector/debugger/setBreakpoint-autoContinue.html:
+ * inspector/debugger/setBreakpoint-column.html:
+ * inspector/debugger/setBreakpoint-condition.html:
+ * inspector/debugger/setBreakpoint-dfg-and-modify-local.html:
+ * inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:
+ * inspector/debugger/setBreakpoint-dfg.html:
+ * inspector/debugger/setBreakpoint-options-exception.html:
+ * inspector/debugger/setBreakpoint.html:
+ * inspector/debugger/setBreakpointByUrl-sourceURL.html:
+ * inspector/debugger/setPauseOnExceptions-all.html:
+ * inspector/debugger/setPauseOnExceptions-none.html:
+ * inspector/debugger/setPauseOnExceptions-uncaught.html:
+ Activate breakpoints in protocol tests that may set breakpoints and pause.
+ Inspector tests automatically enable breakpoints.
+
+ * inspector/debugger/setVariableValue-expected.txt: Removed.
+ * inspector/debugger/setVariableValue.html: Removed.
+ * platform/gtk/TestExpectations:
+ Remove references to bad test. The protocol command no longer exists.
+
</ins><span class="cx"> 2016-04-15 John Wilander <wilander@apple.com>
</span><span class="cx">
</span><span class="cx"> Refactor WebSockets handshake to use StringView instead of String for header validation.
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerbreakpointactiondetachhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/breakpoint-action-detach.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/breakpoint-action-detach.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-action-detach.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -50,6 +50,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerbreakpointactionwithexceptionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/breakpoint-action-with-exception.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/breakpoint-action-with-exception.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-action-with-exception.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -47,6 +47,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerbreakpointconditiondetachhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/breakpoint-condition-detach.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/breakpoint-condition-detach.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-condition-detach.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -50,6 +50,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerbreakpointconditionwithbadscripthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/breakpoint-condition-with-bad-script.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/breakpoint-condition-with-bad-script.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-condition-with-bad-script.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -44,6 +44,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerbreakpointconditionwithexceptionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/breakpoint-condition-with-exception.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/breakpoint-condition-with-exception.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-condition-with-exception.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -46,6 +46,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerbreakpointevalwithexceptionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/breakpoint-eval-with-exception.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/breakpoint-eval-with-exception.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-eval-with-exception.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -56,6 +56,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerbreakpointinsideconditonsandactionshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/breakpoint-inside-conditons-and-actions.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/breakpoint-inside-conditons-and-actions.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/breakpoint-inside-conditons-and-actions.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -60,6 +60,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> }
</span><span class="cx"> </script>
</span><span class="cx"> </head>
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggercallframefunctionnamehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/call-frame-function-name.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/call-frame-function-name.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/call-frame-function-name.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -12,6 +12,7 @@
</span><span class="cx"> // call frame functionNames are what we expect.
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> InspectorProtocol.eventHandler["Debugger.scriptParsed"] = function(messageObject)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggercallframethishosthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/call-frame-this-host.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/call-frame-this-host.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/call-frame-this-host.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -12,6 +12,7 @@
</span><span class="cx"> // call frame this values are what we expect.
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> InspectorProtocol.eventHandler["Debugger.scriptParsed"] = function(messageObject)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggercallframethisnonstricthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/call-frame-this-nonstrict.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/call-frame-this-nonstrict.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/call-frame-this-nonstrict.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -12,6 +12,7 @@
</span><span class="cx"> // call frame this values are what we expect.
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> InspectorProtocol.eventHandler["Debugger.scriptParsed"] = function(messageObject)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggercallframethisstricthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/call-frame-this-strict.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/call-frame-this-strict.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/call-frame-this-strict.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -12,6 +12,7 @@
</span><span class="cx"> // call frame this values are what we expect.
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> InspectorProtocol.eventHandler["Debugger.scriptParsed"] = function(messageObject)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerdebuggerstatementhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/debugger-statement.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/debugger-statement.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/debugger-statement.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -13,6 +13,7 @@
</span><span class="cx"> // and one not inlined.
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> var breakpointFound = false;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerdidSampleProbemultipleprobeshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/didSampleProbe-multiple-probes.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/didSampleProbe-multiple-probes.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/didSampleProbe-multiple-probes.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -7,6 +7,7 @@
</span><span class="cx"> function test()
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> var samples = [];
</span><span class="cx"> const expectedSampleCount = 4;
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerhitbreakpointfromconsolehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/hit-breakpoint-from-console.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/hit-breakpoint-from-console.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/hit-breakpoint-from-console.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -6,6 +6,7 @@
</span><span class="cx"> function test()
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> InspectorProtocol.eventHandler["Debugger.scriptParsed"] = function(messageObject)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggernestedinspectorshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/nested-inspectors.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/nested-inspectors.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/nested-inspectors.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -9,6 +9,7 @@
</span><span class="cx"> // This function runs in the second inspector window. We can use this one to debug the first inspector.
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> InspectorProtocol.sendCommand("Debugger.setPauseOnExceptions", {state: "all"}, function(responseObject) {
</span><span class="cx"> InspectorProtocol.checkForError(responseObject);
</span><span class="cx"> ProtocolTest.log("Debugger.setPauseOnExceptions - all");
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerpauseonasserthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/pause-on-assert.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/pause-on-assert.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/pause-on-assert.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -6,6 +6,7 @@
</span><span class="cx"> function test()
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> InspectorProtocol.sendCommand("Debugger.setPauseOnExceptions", {state: "all"}, InspectorProtocol.checkForError);
</span><span class="cx">
</span><span class="cx"> var step = null;
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerregress133182html"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/regress-133182.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/regress-133182.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/regress-133182.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -34,6 +34,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> InspectorProtocol.sendCommand("Debugger.setPauseOnExceptions", {state: "uncaught"}, function(responseObject) {
</span><span class="cx"> InspectorProtocol.checkForError(responseObject);
</span><span class="cx"> expectPause = true;
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggerremoveBreakpointhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/removeBreakpoint.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/removeBreakpoint.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/removeBreakpoint.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -6,6 +6,7 @@
</span><span class="cx"> function test()
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> var breakpointTriggered = 0;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetBreakpointactionshtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-actions.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setBreakpoint-actions.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-actions.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -9,6 +9,7 @@
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Console.enable", {});
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> var isExpectingLogs = false;
</span><span class="cx"> var isExpectingSounds = false;
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetBreakpointautoContinuehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-autoContinue.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setBreakpoint-autoContinue.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-autoContinue.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -6,6 +6,7 @@
</span><span class="cx"> function test()
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> var allowedToHitBreakpoint = false;
</span><span class="cx"> var breakpointIdentifier = null;
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetBreakpointcolumnhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-column.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setBreakpoint-column.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-column.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -12,6 +12,7 @@
</span><span class="cx"> // by running some expressions at that call frame.
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> InspectorProtocol.eventHandler["Debugger.scriptParsed"] = function(messageObject)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetBreakpointconditionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-condition.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setBreakpoint-condition.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-condition.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -6,6 +6,7 @@
</span><span class="cx"> function test()
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> var inBreakpoint = false;
</span><span class="cx"> var breakpointTriggered = 0;
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetBreakpointdfgandmodifylocalhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-and-modify-local.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-and-modify-local.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-and-modify-local.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -13,6 +13,7 @@
</span><span class="cx"> // and one not inlined.
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> var breakpointId = null;
</span><span class="cx"> var scriptId = 0;
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetBreakpointdfgcalleeandexaminedfglocalhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -13,6 +13,7 @@
</span><span class="cx"> // and examine a global and local via the DFG frame.
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> var breakpointId = null;
</span><span class="cx"> var scriptId = 0;
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetBreakpointdfghtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-dfg.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -13,6 +13,7 @@
</span><span class="cx"> // and one not inlined.
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> var dfgNonInlinedBreakpointId = null;
</span><span class="cx"> var dfgInlinedBreakpointId = null;
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetBreakpointoptionsexceptionhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint-options-exception.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setBreakpoint-options-exception.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint-options-exception.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -8,6 +8,7 @@
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Console.enable", {});
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> var logsSeen = 0;
</span><span class="cx"> const expectedLogs = 2;
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetBreakpointhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setBreakpoint.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setBreakpoint.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setBreakpoint.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -6,6 +6,7 @@
</span><span class="cx"> function test()
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> InspectorProtocol.eventHandler["Debugger.scriptParsed"] = function(messageObject)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetBreakpointByUrlsourceURLhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setBreakpointByUrl-sourceURL.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setBreakpointByUrl-sourceURL.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setBreakpointByUrl-sourceURL.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -9,6 +9,7 @@
</span><span class="cx"> function test()
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx">
</span><span class="cx"> InspectorProtocol.eventHandler["Debugger.scriptParsed"] = function(messageObject)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetPauseOnExceptionsallhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-all.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-all.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-all.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -101,6 +101,7 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> InspectorProtocol.sendCommand("Debugger.setPauseOnExceptions", {state: "all"}, function(responseObject) {
</span><span class="cx"> InspectorProtocol.checkForError(responseObject);
</span><span class="cx"> ProtocolTest.log("Debugger.setPauseOnExceptions - all");
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetPauseOnExceptionsnonehtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-none.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-none.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-none.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -6,6 +6,7 @@
</span><span class="cx"> function test()
</span><span class="cx"> {
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> InspectorProtocol.sendCommand("Debugger.setPauseOnExceptions", {state: "none"}, function(responseObject) {
</span><span class="cx"> InspectorProtocol.checkForError(responseObject);
</span><span class="cx"> ProtocolTest.log("Debugger.setPauseOnExceptions - none");
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetPauseOnExceptionsuncaughthtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-uncaught.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-uncaught.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setPauseOnExceptions-uncaught.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -79,6 +79,7 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> InspectorProtocol.sendCommand("Debugger.enable", {});
</span><ins>+ InspectorProtocol.sendCommand("Debugger.setBreakpointsActive", {active: true});
</ins><span class="cx"> InspectorProtocol.sendCommand("Debugger.setPauseOnExceptions", {state: "uncaught"}, function(responseObject) {
</span><span class="cx"> InspectorProtocol.checkForError(responseObject);
</span><span class="cx"> ProtocolTest.log("Debugger.setPauseOnExceptions - uncaught");
</span></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetVariableValueexpectedtxt"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector/debugger/setVariableValue-expected.txt (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setVariableValue-expected.txt 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setVariableValue-expected.txt 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -1,4 +0,0 @@
</span><del>-Closure returns: {"type":"string","value":"ttttrue52013"}
- (expected: 'ttttrue52013')
-Protocol command 'Debugger.setVariableValue' failed
-
</del></span></pre></div>
<a id="trunkLayoutTestsinspectordebuggersetVariableValuehtml"></a>
<div class="delfile"><h4>Deleted: trunk/LayoutTests/inspector/debugger/setVariableValue.html (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/inspector/debugger/setVariableValue.html 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/inspector/debugger/setVariableValue.html 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -1,180 +0,0 @@
</span><del>-<html>
-<head>
-<script type="text/javascript" src="../../http/tests/inspector/resources/protocol-test.js"></script>
-<script>
-function test()
-{
- // A general-purpose engine for sending a sequence of protocol commands.
- // The clients provide requests and response handlers, while the engine catches
- // errors and makes sure that once there's nothing to do completeTest() is called.
- // @param step is an object with command, params and callback fields
- function runRequestSeries(step) {
- processStep(step);
-
- function processStep(s) {
- try {
- processStepOrFail(s);
- } catch (e) {
- ProtocolTest.log(e.stack);
- ProtocolTest.completeTest();
- }
- }
-
- function processStepOrFail(s) {
- if (!s) {
- ProtocolTest.completeTest();
- return;
- }
- if (!s.command) {
- // A simple loopback step.
- var next = s.callback();
- processStep(next);
- return;
- }
-
- var innerCallback = function(response) {
- var next;
- if ("error" in response) {
- if (!("errorHandler" in s)) {
- // Error message is not logged intentionally, it may be platform-specific.
- ProtocolTest.log("Protocol command '" + s.command + "' failed");
- ProtocolTest.completeTest();
- return;
- }
- try {
- next = s.errorHandler(response.error);
- } catch (e) {
- ProtocolTest.log(e.stack);
- ProtocolTest.completeTest();
- return;
- }
- } else {
- try {
- next = s.callback(response.result);
- } catch (e) {
- ProtocolTest.log(e.stack);
- ProtocolTest.completeTest();
- return;
- }
- }
- processStep(next);
- }
- InspectorProtocol.sendCommand(s.command, s.params, innerCallback);
- }
- }
-
- var firstStep = { callback: enableDebugger };
-
- runRequestSeries(firstStep);
-
- function enableDebugger() {
- return { command: "Debugger.enable", params: {}, callback: evalFunction };
- }
-
- // Testing function/closure scopes.
-
- function evalFunction(response) {
- var expression = "(function(p){var r=5;with({year:2013}){return function Closure(q){return p+q+r+year};}})('ttt')";
- return { command: "Runtime.evaluate", params: {expression: expression}, callback: callbackEvalFunction };
- }
-
- function callbackEvalFunction(result) {
- var id = result.result.objectId;
- if (id === undefined)
- throw new Error("objectId is expected");
- return createCheckFunctionStepChain(id);
- }
-
- function createCheckFunctionStepChain(functionObjectId) {
- var params = {
- objectId: functionObjectId,
- functionDeclaration: "function(){return this(true);}"
- };
- return {
- command: "Runtime.callFunctionOn", params: params, callback: callbackLogClosureEval
- };
-
- function callbackLogClosureEval(result) {
- ProtocolTest.log("Closure returns: " + JSON.stringify(result.result));
- ProtocolTest.log(" (expected: 'ttttrue52013')");
-
- var params = {
- functionObjectId: functionObjectId,
- scopeNumber: 1,
- variableName: "r",
- newValue: { value: 4 }
- };
- return {
- command: "Debugger.setVariableValue", params: params, callback: setVariableCallback
- };
- }
-
- function setVariableCallback() {
- ProtocolTest.log("Debugger.setVariableValue OK");
-
- var params = {
- objectId: functionObjectId,
- functionDeclaration: "function(){return this(true);}"
- };
- return {
- command: "Runtime.callFunctionOn", params: params, callback: callbackLogClosureEval2
- };
-
- }
-
- function callbackLogClosureEval2(result) {
- ProtocolTest.log("Closure returns: " + JSON.stringify(result.result));
- ProtocolTest.log(" (expected: 'ttttrue42013')");
-
- var params = {
- // No target is specified
- scopeNumber: 1,
- variableName: "r",
- newValue: { value: 4 }
- };
- return {
- command: "Debugger.setVariableValue", params: params, errorHandler: setVariableErrorCallback3
- };
- }
-
- function setVariableErrorCallback3(error) {
- ProtocolTest.log("Expected error: " + JSON.stringify(error));
-
- var params = {
- functionObjectId: functionObjectId,
- scopeNumber: 100, // Wrong scope number
- variableName: "r",
- newValue: { value: 4 }
- };
- return {
- command: "Debugger.setVariableValue", params: params, errorHandler: setVariableErrorCallback4
- };
- }
-
- function setVariableErrorCallback4(error) {
- ProtocolTest.log("Expected error");
-
- var params = {
- functionObjectId: functionObjectId,
- scopeNumber: 1,
- variableName: "bad", // Wrong variable name
- newValue: { value: 4 }
- };
- return {
- command: "Debugger.setVariableValue", params: params, errorHandler: setVariableErrorCallback5
- };
- }
-
- function setVariableErrorCallback5(error) {
- ProtocolTest.log("Expected error");
-
- // End of test.
- return;
- }
- }
-}
-</script>
-</head>
-<body onload="runTest()">
-</body>
-</html>
</del></span></pre></div>
<a id="trunkLayoutTestsplatformgtkTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/gtk/TestExpectations (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/gtk/TestExpectations 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -1444,7 +1444,6 @@
</span><span class="cx"> webkit.org/b/122571 inspector/debugger/setBreakpoint-column.html [ Timeout Pass ]
</span><span class="cx"> webkit.org/b/122571 inspector/debugger/setBreakpoint-condition.html [ Timeout Pass ]
</span><span class="cx"> webkit.org/b/122571 inspector/debugger/removeBreakpoint.html [ Timeout Pass ]
</span><del>-webkit.org/b/122571 inspector/debugger/setVariableValue.html [ Timeout Pass ]
</del><span class="cx"> webkit.org/b/122571 inspector/debugger/call-frame-this-strict.html [ Timeout Pass ]
</span><span class="cx"> webkit.org/b/122571 inspector/dom/request-child-nodes-depth.html [ Timeout Pass ]
</span><span class="cx"> webkit.org/b/122571 inspector/dom/focus.html [ Failure Timeout Pass ]
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-04-14 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: Cleanup inspector/debugger tests
+ https://bugs.webkit.org/show_bug.cgi?id=156619
+
+ Reviewed by Brian Burg.
+
+ While cleaning up the tests it exposed the fact that breakpoints
+ were not getting disabled when the inspector closes. This means
+ that opening the inspector, with breakpoints, and closing the
+ inspector, would leave the JSC::Debugger thinking breakpoints
+ are active. The JSC::Debugger should be reset.
+
+ * inspector/agents/InspectorDebuggerAgent.cpp:
+ (Inspector::InspectorDebuggerAgent::disable):
+
</ins><span class="cx"> 2016-04-14 Geoffrey Garen <ggaren@apple.com>
</span><span class="cx">
</span><span class="cx"> CopiedBlock should be 64kB
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectoragentsInspectorDebuggerAgentcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -104,6 +104,9 @@
</span><span class="cx"> m_scriptDebugServer.removeListener(this, isBeingDestroyed);
</span><span class="cx"> clearInspectorBreakpointState();
</span><span class="cx">
</span><ins>+ if (!isBeingDestroyed)
+ m_scriptDebugServer.deactivateBreakpoints();
+
</ins><span class="cx"> ASSERT(m_javaScriptBreakpoints.isEmpty());
</span><span class="cx">
</span><span class="cx"> if (m_listener)
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -1,5 +1,17 @@
</span><span class="cx"> 2016-04-14 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: Cleanup inspector/debugger tests
+ https://bugs.webkit.org/show_bug.cgi?id=156619
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.loaded):
+ * UserInterface/Controllers/DebuggerManager.js:
+ Remove agent checks for agents that are always available.
+
+2016-04-14 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Add a JavaScript Formatting test for template strings
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=156600
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -92,8 +92,7 @@
</span><span class="cx"> InspectorBackend.registerReplayDispatcher(new WebInspector.ReplayObserver);
</span><span class="cx">
</span><span class="cx"> // Enable agents.
</span><del>- if (window.InspectorAgent)
- InspectorAgent.enable();
</del><ins>+ InspectorAgent.enable();
</ins><span class="cx">
</span><span class="cx"> // Perform one-time tasks.
</span><span class="cx"> WebInspector.CSSCompletions.requestCSSCompletions();
</span><span class="lines">@@ -125,13 +124,12 @@
</span><span class="cx"> this.replayManager = new WebInspector.ReplayManager;
</span><span class="cx">
</span><span class="cx"> // Enable the Console Agent after creating the singleton managers.
</span><del>- if (window.ConsoleAgent)
- ConsoleAgent.enable();
</del><ins>+ ConsoleAgent.enable();
</ins><span class="cx">
</span><span class="cx"> // Tell the backend we are initialized after all our initialization messages have been sent.
</span><span class="cx"> setTimeout(function() {
</span><span class="cx"> // COMPATIBILITY (iOS 8): Inspector.initialized did not exist yet.
</span><del>- if (window.InspectorAgent && InspectorAgent.initialized)
</del><ins>+ if (InspectorAgent.initialized)
</ins><span class="cx"> InspectorAgent.initialized();
</span><span class="cx"> }, 0);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceControllersDebuggerManagerjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js (199591 => 199592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2016-04-15 16:44:14 UTC (rev 199591)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2016-04-15 17:18:12 UTC (rev 199592)
</span><span class="lines">@@ -29,8 +29,7 @@
</span><span class="cx"> {
</span><span class="cx"> super();
</span><span class="cx">
</span><del>- if (window.DebuggerAgent)
- DebuggerAgent.enable();
</del><ins>+ DebuggerAgent.enable();
</ins><span class="cx">
</span><span class="cx"> WebInspector.notifications.addEventListener(WebInspector.Notification.DebugUIEnabledDidChange, this._debugUIEnabledDidChange, this);
</span><span class="cx">
</span><span class="lines">@@ -79,8 +78,7 @@
</span><span class="cx"> this._temporarilyDisabledBreakpointsRestoreSetting.value = null;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if (window.DebuggerAgent)
- DebuggerAgent.setBreakpointsActive(this._breakpointsEnabledSetting.value);
</del><ins>+ DebuggerAgent.setBreakpointsActive(this._breakpointsEnabledSetting.value);
</ins><span class="cx">
</span><span class="cx"> this._updateBreakOnExceptionsState();
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>