<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199498] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199498">199498</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-04-13 09:25:13 -0700 (Wed, 13 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION(<a href="http://trac.webkit.org/projects/webkit/changeset/199444">r199444</a>): Perf dashboard always fetches all measurement sets
https://bugs.webkit.org/show_bug.cgi?id=156534
Reviewed by Darin Adler.
The bug was cased by SummaryPage's constructor fetching all measurement sets. Since each page is always
constructed in main(), this resulted in all measurement sets being fetched on all pages.
* public/v3/pages/summary-page.js:
(SummaryPage):
(SummaryPage.prototype.open): Fetch measurement set JSONs here.
(SummaryPage.prototype._createConfigurationGroup): Renamed from _createConfigurationGroupAndStartFetchingData.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pagessummarypagejs">trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (199497 => 199498)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2016-04-13 16:16:13 UTC (rev 199497)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-04-13 16:25:13 UTC (rev 199498)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-04-13 Ryosuke Niwa <rniwa@webkit.org>
+
+ REGRESSION(r199444): Perf dashboard always fetches all measurement sets
+ https://bugs.webkit.org/show_bug.cgi?id=156534
+
+ Reviewed by Darin Adler.
+
+ The bug was cased by SummaryPage's constructor fetching all measurement sets. Since each page is always
+ constructed in main(), this resulted in all measurement sets being fetched on all pages.
+
+ * public/v3/pages/summary-page.js:
+ (SummaryPage):
+ (SummaryPage.prototype.open): Fetch measurement set JSONs here.
+ (SummaryPage.prototype._createConfigurationGroup): Renamed from _createConfigurationGroupAndStartFetchingData.
+
</ins><span class="cx"> 2016-04-12 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><span class="cx"> Add a summary page to v3 UI
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pagessummarypagejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js (199497 => 199498)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js 2016-04-13 16:16:13 UTC (rev 199497)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js 2016-04-13 16:25:13 UTC (rev 199498)
</span><span class="lines">@@ -11,9 +11,8 @@
</span><span class="cx"> };
</span><span class="cx"> this._shouldConstructTable = true;
</span><span class="cx"> this._renderQueue = [];
</span><ins>+ this._configGroups = [];
</ins><span class="cx">
</span><del>- var current = Date.now();
- var timeRange = [current - 7 * 24 * 3600 * 1000, current];
</del><span class="cx"> for (var metricGroup of summarySettings.metricGroups) {
</span><span class="cx"> var group = {name: metricGroup.name, rows: []};
</span><span class="cx"> this._table.groups.push(group);
</span><span class="lines">@@ -21,7 +20,7 @@
</span><span class="cx"> var row = {name: subMetricGroup.name, cells: []};
</span><span class="cx"> group.rows.push(row);
</span><span class="cx"> for (var platformGroup of summarySettings.platformGroups)
</span><del>- row.cells.push(this._createConfigurationGroupAndStartFetchingData(platformGroup.platforms, subMetricGroup.metrics, timeRange));
</del><ins>+ row.cells.push(this._createConfigurationGroup(platformGroup.platforms, subMetricGroup.metrics));
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -31,6 +30,11 @@
</span><span class="cx"> open(state)
</span><span class="cx"> {
</span><span class="cx"> super.open(state);
</span><ins>+
+ var current = Date.now();
+ var timeRange = [current - 7 * 24 * 3600 * 1000, current];
+ for (var group of this._configGroups)
+ group.fetchAndComputeSummary(timeRange).then(this.render.bind(this));
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> render()
</span><span class="lines">@@ -44,12 +48,12 @@
</span><span class="cx"> render();
</span><span class="cx"> }
</span><span class="cx">
</span><del>- _createConfigurationGroupAndStartFetchingData(platformIdList, metricIdList, timeRange)
</del><ins>+ _createConfigurationGroup(platformIdList, metricIdList)
</ins><span class="cx"> {
</span><span class="cx"> var platforms = platformIdList.map(function (id) { return Platform.findById(id); }).filter(function (obj) { return !!obj; });
</span><span class="cx"> var metrics = metricIdList.map(function (id) { return Metric.findById(id); }).filter(function (obj) { return !!obj; });
</span><span class="cx"> var configGroup = new SummaryPageConfigurationGroup(platforms, metrics);
</span><del>- configGroup.fetchAndComputeSummary(timeRange).then(this.render.bind(this));
</del><ins>+ this._configGroups.push(configGroup);
</ins><span class="cx"> return configGroup;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>