<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199414] releases/WebKitGTK/webkit-2.12</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199414">199414</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-04-12 23:48:59 -0700 (Tue, 12 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Merge <a href="http://trac.webkit.org/projects/webkit/changeset/198374">r198374</a> - Images in feed on ebay.com jiggle when one is hovered
https://bugs.webkit.org/show_bug.cgi?id=155608
<rdar://problem/25160681>
The content offset in compositing layer = subpixel gap between the graphics layer and the layer bounds + layer bounds top left.
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/hidpi-viewport-clipping-on-composited-content.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::contentOffsetInCompostingLayer):
* rendering/RenderLayerBacking.h:
LayoutTests:
* compositing/hidpi-viewport-clipping-on-composited-content-expected.html: Added.
* compositing/hidpi-viewport-clipping-on-composited-content.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestsChangeLog">releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCoreChangeLog">releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorerenderingRenderLayerBackingcpp">releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderLayerBacking.cpp</a></li>
<li><a href="#releasesWebKitGTKwebkit212SourceWebCorerenderingRenderLayerBackingh">releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderLayerBacking.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestscompositinghidpiviewportclippingoncompositedcontentexpectedhtml">releases/WebKitGTK/webkit-2.12/LayoutTests/compositing/hidpi-viewport-clipping-on-composited-content-expected.html</a></li>
<li><a href="#releasesWebKitGTKwebkit212LayoutTestscompositinghidpiviewportclippingoncompositedcontenthtml">releases/WebKitGTK/webkit-2.12/LayoutTests/compositing/hidpi-viewport-clipping-on-composited-content.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="releasesWebKitGTKwebkit212LayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (199413 => 199414)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-13 06:47:52 UTC (rev 199413)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog 2016-04-13 06:48:59 UTC (rev 199414)
</span><span class="lines">@@ -1,5 +1,18 @@
</span><span class="cx"> 2016-03-17 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><ins>+ Images in feed on ebay.com jiggle when one is hovered
+ https://bugs.webkit.org/show_bug.cgi?id=155608
+ <rdar://problem/25160681>
+
+ The content offset in compositing layer = subpixel gap between the graphics layer and the layer bounds + layer bounds top left.
+
+ Reviewed by Simon Fraser.
+
+ * compositing/hidpi-viewport-clipping-on-composited-content-expected.html: Added.
+ * compositing/hidpi-viewport-clipping-on-composited-content.html: Added.
+
+2016-03-17 Zalan Bujtas <zalan@apple.com>
+
</ins><span class="cx"> Don't initiate a style recall while drawing text
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=155618
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestscompositinghidpiviewportclippingoncompositedcontentexpectedhtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/compositing/hidpi-viewport-clipping-on-composited-content-expected.html (0 => 199414)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/compositing/hidpi-viewport-clipping-on-composited-content-expected.html (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/compositing/hidpi-viewport-clipping-on-composited-content-expected.html 2016-04-13 06:48:59 UTC (rev 199414)
</span><span class="lines">@@ -0,0 +1,26 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that we position composited content properly when they are clipped to the viewport.</title>
+<style>
+ .jiggle {
+ width: 20px;
+ height: 5px;
+ position: absolute;
+ background: green;
+ }
+</style>
+</head>
+<body>
+<script>
+var leftPos = 0;
+for (i = 0; i < 50; ++i) {
+ var element = document.createElement("div");
+ element.className = "jiggle";
+ element.style.top = (6 * i) + "px";
+ element.style.left = leftPos + "px";
+ document.body.appendChild(element);
+ leftPos -= 0.1;
+}
+</script>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit212LayoutTestscompositinghidpiviewportclippingoncompositedcontenthtml"></a>
<div class="addfile"><h4>Added: releases/WebKitGTK/webkit-2.12/LayoutTests/compositing/hidpi-viewport-clipping-on-composited-content.html (0 => 199414)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/LayoutTests/compositing/hidpi-viewport-clipping-on-composited-content.html (rev 0)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/compositing/hidpi-viewport-clipping-on-composited-content.html 2016-04-13 06:48:59 UTC (rev 199414)
</span><span class="lines">@@ -0,0 +1,36 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that we position composited content properly when they are clipped to the viewport.</title>
+<style>
+ .jiggle {
+ width: 20px;
+ height: 5px;
+ position: absolute;
+ background: green;
+ }
+
+ .overlapping {
+ position: absolute;
+ top: 0px;
+ left: 0px;
+ width: 10px;
+ height: 300px;
+ -webkit-transform: translateZ(0);
+ }
+</style>
+</head>
+<body>
+<div class=overlapping></div>
+<script>
+var leftPos = 0;
+for (i = 0; i < 50; ++i) {
+ var element = document.createElement("div");
+ element.className = "jiggle";
+ element.style.top = (6 * i) + "px";
+ element.style.left = leftPos + "px";
+ document.body.appendChild(element);
+ leftPos -= 0.1;
+}
+</script>
+</html>
</ins></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (199413 => 199414)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-13 06:47:52 UTC (rev 199413)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog 2016-04-13 06:48:59 UTC (rev 199414)
</span><span class="lines">@@ -1,5 +1,22 @@
</span><span class="cx"> 2016-03-17 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><ins>+ Images in feed on ebay.com jiggle when one is hovered
+ https://bugs.webkit.org/show_bug.cgi?id=155608
+ <rdar://problem/25160681>
+
+ The content offset in compositing layer = subpixel gap between the graphics layer and the layer bounds + layer bounds top left.
+
+ Reviewed by Simon Fraser.
+
+ Test: compositing/hidpi-viewport-clipping-on-composited-content.html
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGeometry):
+ (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer):
+ * rendering/RenderLayerBacking.h:
+
+2016-03-17 Zalan Bujtas <zalan@apple.com>
+
</ins><span class="cx"> Don't initiate a style recall while drawing text
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=155618
</span><span class="cx">
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorerenderingRenderLayerBackingcpp"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderLayerBacking.cpp (199413 => 199414)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderLayerBacking.cpp 2016-04-13 06:47:52 UTC (rev 199413)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderLayerBacking.cpp 2016-04-13 06:48:59 UTC (rev 199414)
</span><span class="lines">@@ -787,8 +787,8 @@
</span><span class="cx"> relativeCompositingBounds.moveBy(offsetFromParent);
</span><span class="cx">
</span><span class="cx"> LayoutRect enclosingRelativeCompositingBounds = LayoutRect(encloseRectToDevicePixels(relativeCompositingBounds, deviceScaleFactor));
</span><del>- LayoutSize subpixelOffsetAdjustment = enclosingRelativeCompositingBounds.location() - relativeCompositingBounds.location();
- LayoutSize rendererOffsetFromGraphicsLayer = toLayoutSize(localCompositingBounds.location()) + subpixelOffsetAdjustment;
</del><ins>+ m_compositedBoundsDeltaFromGraphicsLayer = enclosingRelativeCompositingBounds.location() - relativeCompositingBounds.location();
+ LayoutSize rendererOffsetFromGraphicsLayer = toLayoutSize(localCompositingBounds.location()) + m_compositedBoundsDeltaFromGraphicsLayer;
</ins><span class="cx">
</span><span class="cx"> FloatSize devicePixelOffsetFromRenderer;
</span><span class="cx"> LayoutSize devicePixelFractionFromRenderer;
</span><span class="lines">@@ -2095,7 +2095,7 @@
</span><span class="cx"> // Return the offset from the top-left of this compositing layer at which the renderer's contents are painted.
</span><span class="cx"> LayoutSize RenderLayerBacking::contentOffsetInCompostingLayer() const
</span><span class="cx"> {
</span><del>- return LayoutSize(-m_compositedBounds.x(), -m_compositedBounds.y()) + m_devicePixelFractionFromRenderer;
</del><ins>+ return LayoutSize(-m_compositedBounds.x() - m_compositedBoundsDeltaFromGraphicsLayer.width(), -m_compositedBounds.y() - m_compositedBoundsDeltaFromGraphicsLayer.height());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> LayoutRect RenderLayerBacking::contentsBox() const
</span></span></pre></div>
<a id="releasesWebKitGTKwebkit212SourceWebCorerenderingRenderLayerBackingh"></a>
<div class="modfile"><h4>Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderLayerBacking.h (199413 => 199414)</h4>
<pre class="diff"><span>
<span class="info">--- releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderLayerBacking.h 2016-04-13 06:47:52 UTC (rev 199413)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/rendering/RenderLayerBacking.h 2016-04-13 06:48:59 UTC (rev 199414)
</span><span class="lines">@@ -367,6 +367,7 @@
</span><span class="cx">
</span><span class="cx"> LayoutRect m_compositedBounds;
</span><span class="cx"> LayoutSize m_devicePixelFractionFromRenderer;
</span><ins>+ LayoutSize m_compositedBoundsDeltaFromGraphicsLayer; // This is the (subpixel) distance between the edge of the graphics layer and the layer bounds.
</ins><span class="cx">
</span><span class="cx"> bool m_artificiallyInflatedBounds; // bounds had to be made non-zero to make transform-origin work
</span><span class="cx"> bool m_isMainFrameRenderViewLayer;
</span></span></pre>
</div>
</div>
</body>
</html>