<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199392] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199392">199392</a></dd>
<dt>Author</dt> <dd>cdumez@apple.com</dd>
<dt>Date</dt> <dd>2016-04-12 15:38:35 -0700 (Tue, 12 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Attr.value should not be nullable
https://bugs.webkit.org/show_bug.cgi?id=156515
Reviewed by Benjamin Poulain.
Source/WebCore:
Update Attr.value so that it is no longer nullable, as per:
https://dom.spec.whatwg.org/#interface-attr
This aligns our behavior with Firefox and Chrome as well.
Test: fast/dom/Attr/value-not-nullable.html
* dom/Attr.cpp:
(WebCore::Attr::setValueForBindings):
(WebCore::Attr::setNodeValue):
(WebCore::Attr::setValue):
* dom/Attr.h:
* dom/Attr.idl:
LayoutTests:
Add layout test and rebaseline existing one now that Attr.value is no
longer nullable.
* fast/dom/Attr/value-not-nullable-expected.txt: Added.
* fast/dom/Attr/value-not-nullable.html: Added.
* fast/dom/coreDOM-element-attribute-js-null-expected.txt:
* fast/dom/coreDOM-element-attribute-js-null.xhtml:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsfastdomcoreDOMelementattributejsnullexpectedtxt">trunk/LayoutTests/fast/dom/coreDOM-element-attribute-js-null-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomcoreDOMelementattributejsnullxhtml">trunk/LayoutTests/fast/dom/coreDOM-element-attribute-js-null.xhtml</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomAttrcpp">trunk/Source/WebCore/dom/Attr.cpp</a></li>
<li><a href="#trunkSourceWebCoredomAttrh">trunk/Source/WebCore/dom/Attr.h</a></li>
<li><a href="#trunkSourceWebCoredomAttridl">trunk/Source/WebCore/dom/Attr.idl</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastdomAttrvaluenotnullableexpectedtxt">trunk/LayoutTests/fast/dom/Attr/value-not-nullable-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastdomAttrvaluenotnullablehtml">trunk/LayoutTests/fast/dom/Attr/value-not-nullable.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (199391 => 199392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-04-12 21:52:08 UTC (rev 199391)
+++ trunk/LayoutTests/ChangeLog 2016-04-12 22:38:35 UTC (rev 199392)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-04-12 Chris Dumez <cdumez@apple.com>
+
+ Attr.value should not be nullable
+ https://bugs.webkit.org/show_bug.cgi?id=156515
+
+ Reviewed by Benjamin Poulain.
+
+ Add layout test and rebaseline existing one now that Attr.value is no
+ longer nullable.
+
+ * fast/dom/Attr/value-not-nullable-expected.txt: Added.
+ * fast/dom/Attr/value-not-nullable.html: Added.
+ * fast/dom/coreDOM-element-attribute-js-null-expected.txt:
+ * fast/dom/coreDOM-element-attribute-js-null.xhtml:
+
</ins><span class="cx"> 2016-04-12 David Kilzer <ddkilzer@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: inspector/heap/getRemoteObject.html is flakey
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomAttrvaluenotnullableexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Attr/value-not-nullable-expected.txt (0 => 199392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Attr/value-not-nullable-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/Attr/value-not-nullable-expected.txt 2016-04-12 22:38:35 UTC (rev 199392)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+Tests that Attr.value is not nullable
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+attr = document.createAttribute('test')
+PASS attr.value is ""
+PASS attr.value = null did not throw exception.
+PASS attr.value is "null"
+PASS attr.value = undefined did not throw exception.
+PASS attr.value is "undefined"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomAttrvaluenotnullablehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/dom/Attr/value-not-nullable.html (0 => 199392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/Attr/value-not-nullable.html (rev 0)
+++ trunk/LayoutTests/fast/dom/Attr/value-not-nullable.html 2016-04-12 22:38:35 UTC (rev 199392)
</span><span class="lines">@@ -0,0 +1,16 @@
</span><ins>+<!DOCTYPE html>
+<body>
+<script src="../../../resources/js-test-pre.js"></script>
+<script>
+description("Tests that Attr.value is not nullable");
+
+evalAndLog("attr = document.createAttribute('test')");
+shouldBeEmptyString("attr.value");
+shouldNotThrow("attr.value = null");
+shouldBeEqualToString("attr.value", "null");
+shouldNotThrow("attr.value = undefined");
+shouldBeEqualToString("attr.value", "undefined");
+
+</script>
+<script src="../../../resources/js-test-post.js"></script>
+</body>
</ins></span></pre></div>
<a id="trunkLayoutTestsfastdomcoreDOMelementattributejsnullexpectedtxt"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/coreDOM-element-attribute-js-null-expected.txt (199391 => 199392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/coreDOM-element-attribute-js-null-expected.txt 2016-04-12 21:52:08 UTC (rev 199391)
+++ trunk/LayoutTests/fast/dom/coreDOM-element-attribute-js-null-expected.txt 2016-04-12 22:38:35 UTC (rev 199392)
</span><span class="lines">@@ -1,6 +1,6 @@
</span><span class="cx"> This test setting various attributes of a elements to JavaScript null.
</span><span class="cx">
</span><del>-TEST SUCCEEDED: The value was null. [tested Attr.value]
</del><ins>+TEST SUCCEEDED: The value was the string 'null'. [tested Attr.value]
</ins><span class="cx">
</span><span class="cx"> TEST SUCCEEDED: The value was the empty string. [tested ProcessingInstruction.data]
</span><span class="cx">
</span></span></pre></div>
<a id="trunkLayoutTestsfastdomcoreDOMelementattributejsnullxhtml"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/fast/dom/coreDOM-element-attribute-js-null.xhtml (199391 => 199392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/dom/coreDOM-element-attribute-js-null.xhtml 2016-04-12 21:52:08 UTC (rev 199391)
+++ trunk/LayoutTests/fast/dom/coreDOM-element-attribute-js-null.xhtml 2016-04-12 22:38:35 UTC (rev 199392)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> type: 'Attr',
</span><span class="cx"> elementToUse: document.createAttributeNS('http://www.w3.org/1999/xhtml','anAttribute'),
</span><span class="cx"> attributes: [
</span><del>- {name: 'value', expectedNull: null}
</del><ins>+ {name: 'value', expectedNull: 'null'}
</ins><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (199391 => 199392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-04-12 21:52:08 UTC (rev 199391)
+++ trunk/Source/WebCore/ChangeLog 2016-04-12 22:38:35 UTC (rev 199392)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2016-04-12 Chris Dumez <cdumez@apple.com>
+
+ Attr.value should not be nullable
+ https://bugs.webkit.org/show_bug.cgi?id=156515
+
+ Reviewed by Benjamin Poulain.
+
+ Update Attr.value so that it is no longer nullable, as per:
+ https://dom.spec.whatwg.org/#interface-attr
+
+ This aligns our behavior with Firefox and Chrome as well.
+
+ Test: fast/dom/Attr/value-not-nullable.html
+
+ * dom/Attr.cpp:
+ (WebCore::Attr::setValueForBindings):
+ (WebCore::Attr::setNodeValue):
+ (WebCore::Attr::setValue):
+ * dom/Attr.h:
+ * dom/Attr.idl:
+
</ins><span class="cx"> 2016-04-12 Konstantin Tokarev <annulen@yandex.ru>
</span><span class="cx">
</span><span class="cx"> Fixed uninitialization of Node::DataUnion with GCC 4.8.
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttrcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.cpp (199391 => 199392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.cpp 2016-04-12 21:52:08 UTC (rev 199391)
+++ trunk/Source/WebCore/dom/Attr.cpp 2016-04-12 22:38:35 UTC (rev 199392)
</span><span class="lines">@@ -120,7 +120,7 @@
</span><span class="cx"> invalidateNodeListAndCollectionCachesInAncestors(&m_name, m_element);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void Attr::setValue(const AtomicString& value, ExceptionCode&)
</del><ins>+void Attr::setValueForBindings(const AtomicString& value)
</ins><span class="cx"> {
</span><span class="cx"> AtomicString oldValue = this->value();
</span><span class="cx"> if (m_element)
</span><span class="lines">@@ -132,9 +132,9 @@
</span><span class="cx"> m_element->didModifyAttribute(qualifiedName(), oldValue, value);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void Attr::setNodeValue(const String& v, ExceptionCode& ec)
</del><ins>+void Attr::setNodeValue(const String& v, ExceptionCode&)
</ins><span class="cx"> {
</span><del>- setValue(v, ec);
</del><ins>+ setValueForBindings(v);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> Ref<Node> Attr::cloneNodeInternal(Document& targetDocument, CloningOperation)
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttrh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.h (199391 => 199392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.h 2016-04-12 21:52:08 UTC (rev 199391)
+++ trunk/Source/WebCore/dom/Attr.h 2016-04-12 22:38:35 UTC (rev 199392)
</span><span class="lines">@@ -51,8 +51,9 @@
</span><span class="cx"> Element* ownerElement() const { return m_element; }
</span><span class="cx">
</span><span class="cx"> const AtomicString& value() const;
</span><del>- void setValue(const AtomicString&, ExceptionCode&);
</del><span class="cx"> void setValue(const AtomicString&);
</span><ins>+ const AtomicString& valueForBindings() const { return value(); }
+ void setValueForBindings(const AtomicString&);
</ins><span class="cx">
</span><span class="cx"> const QualifiedName& qualifiedName() const { return m_name; }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCoredomAttridl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/Attr.idl (199391 => 199392)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/Attr.idl 2016-04-12 21:52:08 UTC (rev 199391)
+++ trunk/Source/WebCore/dom/Attr.idl 2016-04-12 22:38:35 UTC (rev 199392)
</span><span class="lines">@@ -30,7 +30,7 @@
</span><span class="cx">
</span><span class="cx"> readonly attribute boolean specified;
</span><span class="cx">
</span><del>- [SetterRaisesException] attribute DOMString? value;
</del><ins>+ [ImplementedAs=valueForBindings] attribute DOMString value;
</ins><span class="cx">
</span><span class="cx"> // DOM Level 2
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>