<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199335] trunk/Source/WebCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199335">199335</a></dd>
<dt>Author</dt> <dd>darin@apple.com</dd>
<dt>Date</dt> <dd>2016-04-11 22:49:45 -0700 (Mon, 11 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection
https://bugs.webkit.org/show_bug.cgi?id=156491
Reviewed by Chris Dumez.
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add): Take a reference instead of a pointer.
* html/HTMLOptionsCollection.h: Removed unneeded forward declaration. Changed
add to take a reference instead of a pointer for the element to add. Used
final instead of override on virtual functions.
* html/HTMLOptionsCollection.idl: Removed now-unneeded attribute
UsePointersEvenForNonNullableObjectArguments; the only function affected was
add, and the overloading code was already checking for null.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionsCollectioncpp">trunk/Source/WebCore/html/HTMLOptionsCollection.cpp</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionsCollectionh">trunk/Source/WebCore/html/HTMLOptionsCollection.h</a></li>
<li><a href="#trunkSourceWebCorehtmlHTMLOptionsCollectionidl">trunk/Source/WebCore/html/HTMLOptionsCollection.idl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (199334 => 199335)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-04-12 04:15:16 UTC (rev 199334)
+++ trunk/Source/WebCore/ChangeLog 2016-04-12 05:49:45 UTC (rev 199335)
</span><span class="lines">@@ -1,5 +1,21 @@
</span><span class="cx"> 2016-04-11 Darin Adler <darin@apple.com>
</span><span class="cx">
</span><ins>+ Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection
+ https://bugs.webkit.org/show_bug.cgi?id=156491
+
+ Reviewed by Chris Dumez.
+
+ * html/HTMLOptionsCollection.cpp:
+ (WebCore::HTMLOptionsCollection::add): Take a reference instead of a pointer.
+ * html/HTMLOptionsCollection.h: Removed unneeded forward declaration. Changed
+ add to take a reference instead of a pointer for the element to add. Used
+ final instead of override on virtual functions.
+ * html/HTMLOptionsCollection.idl: Removed now-unneeded attribute
+ UsePointersEvenForNonNullableObjectArguments; the only function affected was
+ add, and the overloading code was already checking for null.
+
+2016-04-11 Darin Adler <darin@apple.com>
+
</ins><span class="cx"> Remove UsePointersEvenForNonNullableObjectArguments from HTMLSelectElement
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=156458
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionsCollectioncpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.cpp (199334 => 199335)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionsCollection.cpp 2016-04-12 04:15:16 UTC (rev 199334)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.cpp 2016-04-12 05:49:45 UTC (rev 199335)
</span><span class="lines">@@ -36,14 +36,12 @@
</span><span class="cx"> return adoptRef(*new HTMLOptionsCollection(select));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLOptionsCollection::add(HTMLElement* element, HTMLElement* beforeElement, ExceptionCode& ec)
</del><ins>+void HTMLOptionsCollection::add(HTMLElement& element, HTMLElement* beforeElement, ExceptionCode& ec)
</ins><span class="cx"> {
</span><del>- if (!element)
- return;
- selectElement().add(*element, beforeElement, ec);
</del><ins>+ selectElement().add(element, beforeElement, ec);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-void HTMLOptionsCollection::add(HTMLElement* element, int beforeIndex, ExceptionCode& ec)
</del><ins>+void HTMLOptionsCollection::add(HTMLElement& element, int beforeIndex, ExceptionCode& ec)
</ins><span class="cx"> {
</span><span class="cx"> add(element, item(beforeIndex), ec);
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionsCollectionh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.h (199334 => 199335)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionsCollection.h 2016-04-12 04:15:16 UTC (rev 199334)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.h 2016-04-12 05:49:45 UTC (rev 199335)
</span><span class="lines">@@ -30,8 +30,6 @@
</span><span class="cx">
</span><span class="cx"> namespace WebCore {
</span><span class="cx">
</span><del>-class HTMLOptionElement;
-
</del><span class="cx"> typedef int ExceptionCode;
</span><span class="cx">
</span><span class="cx"> class HTMLOptionsCollection final : public CachedHTMLCollection<HTMLOptionsCollection, CollectionTypeTraits<SelectOptions>::traversalType> {
</span><span class="lines">@@ -41,11 +39,11 @@
</span><span class="cx"> HTMLSelectElement& selectElement() { return downcast<HTMLSelectElement>(ownerNode()); }
</span><span class="cx"> const HTMLSelectElement& selectElement() const { return downcast<HTMLSelectElement>(ownerNode()); }
</span><span class="cx">
</span><del>- HTMLOptionElement* item(unsigned offset) const override;
- HTMLOptionElement* namedItem(const AtomicString& name) const override;
</del><ins>+ HTMLOptionElement* item(unsigned offset) const final;
+ HTMLOptionElement* namedItem(const AtomicString& name) const final;
</ins><span class="cx">
</span><del>- void add(HTMLElement*, HTMLElement* beforeElement, ExceptionCode&);
- void add(HTMLElement*, int beforeIndex, ExceptionCode&);
</del><ins>+ void add(HTMLElement&, HTMLElement* beforeElement, ExceptionCode&);
+ void add(HTMLElement&, int beforeIndex, ExceptionCode&);
</ins><span class="cx"> void remove(int index);
</span><span class="cx"> void remove(HTMLOptionElement&);
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebCorehtmlHTMLOptionsCollectionidl"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/html/HTMLOptionsCollection.idl (199334 => 199335)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/html/HTMLOptionsCollection.idl 2016-04-12 04:15:16 UTC (rev 199334)
+++ trunk/Source/WebCore/html/HTMLOptionsCollection.idl 2016-04-12 05:49:45 UTC (rev 199335)
</span><span class="lines">@@ -21,7 +21,6 @@
</span><span class="cx"> [
</span><span class="cx"> JSGenerateToNativeObject,
</span><span class="cx"> CustomIndexedSetter,
</span><del>- UsePointersEvenForNonNullableObjectArguments,
</del><span class="cx"> GenerateIsReachable=ImplOwnerNodeRoot,
</span><span class="cx"> ] interface HTMLOptionsCollection : HTMLCollection {
</span><span class="cx"> attribute long selectedIndex;
</span></span></pre>
</div>
</div>
</body>
</html>