<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199244] trunk/PerformanceTests</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199244">199244</a></dd>
<dt>Author</dt> <dd>jonlee@apple.com</dd>
<dt>Date</dt> <dd>2016-04-08 13:19:26 -0700 (Fri, 08 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix SVG benchmark test
https://bugs.webkit.org/show_bug.cgi?id=156410
Reviewed by Dean Jackson.
* Animometer/resources/extensions.js: Update Point.zero to be a static Point.
* Animometer/tests/simple/resources/tiled-canvas-image.js:
(Stage.call._setupTiles): Refactor.
* Animometer/tests/master/resources/particles.js:
(Particle.prototype.reset): Use Point.center.
(complexity): We are not using a gradient background anymore, so remove the +1.
* Animometer/tests/master/resources/svg-particles.js: Update to use SVG transform
instead of CSS transform.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkPerformanceTestsAnimometerresourcesextensionsjs">trunk/PerformanceTests/Animometer/resources/extensions.js</a></li>
<li><a href="#trunkPerformanceTestsAnimometertestsmasterresourcesparticlesjs">trunk/PerformanceTests/Animometer/tests/master/resources/particles.js</a></li>
<li><a href="#trunkPerformanceTestsAnimometertestsmasterresourcessvgparticlesjs">trunk/PerformanceTests/Animometer/tests/master/resources/svg-particles.js</a></li>
<li><a href="#trunkPerformanceTestsAnimometertestssimpleresourcestiledcanvasimagejs">trunk/PerformanceTests/Animometer/tests/simple/resources/tiled-canvas-image.js</a></li>
<li><a href="#trunkPerformanceTestsChangeLog">trunk/PerformanceTests/ChangeLog</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkPerformanceTestsAnimometerresourcesextensionsjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/resources/extensions.js (199243 => 199244)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/resources/extensions.js        2016-04-08 20:07:51 UTC (rev 199243)
+++ trunk/PerformanceTests/Animometer/resources/extensions.js        2016-04-08 20:19:26 UTC (rev 199244)
</span><span class="lines">@@ -286,10 +286,7 @@
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> Utilities.extendObject(Point, {
</span><del>- zero: function()
- {
- return new Point(0, 0);
- },
</del><ins>+ zero: new Point(0, 0),
</ins><span class="cx">
</span><span class="cx"> pointOnCircle: function(angle, radius)
</span><span class="cx"> {
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometertestsmasterresourcesparticlesjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/tests/master/resources/particles.js (199243 => 199244)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/tests/master/resources/particles.js        2016-04-08 20:07:51 UTC (rev 199243)
+++ trunk/PerformanceTests/Animometer/tests/master/resources/particles.js        2016-04-08 20:19:26 UTC (rev 199244)
</span><span class="lines">@@ -15,7 +15,7 @@
</span><span class="cx"> {
</span><span class="cx"> var randSize = Math.round(Math.pow(Pseudo.random(), 4) * this.sizeRange + this.sizeMinimum);
</span><span class="cx"> this.size = new Point(randSize, randSize);
</span><del>- this.minPosition = this.size.multiply(.5);
</del><ins>+ this.minPosition = this.size.center;
</ins><span class="cx"> this.maxPosition = this.stage.size.subtract(this.minPosition);
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -107,7 +107,6 @@
</span><span class="cx">
</span><span class="cx"> complexity: function()
</span><span class="cx"> {
</span><del>- // We add one to represent the gradient background.
- return this.particles.length + 1;
</del><ins>+ return this.particles.length;
</ins><span class="cx"> }
</span><span class="cx"> });
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometertestsmasterresourcessvgparticlesjs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/tests/master/resources/svg-particles.js (199243 => 199244)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/tests/master/resources/svg-particles.js        2016-04-08 20:07:51 UTC (rev 199243)
+++ trunk/PerformanceTests/Animometer/tests/master/resources/svg-particles.js        2016-04-08 20:19:26 UTC (rev 199244)
</span><span class="lines">@@ -42,9 +42,9 @@
</span><span class="cx"> if (this.isClipPath) {
</span><span class="cx"> this.element.setAttribute("width", this.size.x);
</span><span class="cx"> this.element.setAttribute("height", this.size.y);
</span><del>- this.transformSuffix = "translate(-" + (this.size.x >> 1) + "px,-" + (this.size.y >> 1) + "px)";
</del><ins>+ this.transformSuffix = " translate(-" + this.size.center.x + ",-" + this.size.center.y + ")";
</ins><span class="cx"> } else
</span><del>- this.transformSuffix = "scale(" + this.size.x + ")translate(-.5px,-.5px)";
</del><ins>+ this.transformSuffix = " scale(" + this.size.x + ") translate(-.5,-.5)";
</ins><span class="cx">
</span><span class="cx"> this.stage.colorOffset = (this.stage.colorOffset + .5) % 360;
</span><span class="cx">
</span><span class="lines">@@ -59,7 +59,7 @@
</span><span class="cx">
</span><span class="cx"> move: function()
</span><span class="cx"> {
</span><del>- this.element.style.transform = "translate(" + this.position.x + "px," + this.position.y + "px)" + this.rotater.rotateZ() + this.transformSuffix;
</del><ins>+ this.element.setAttribute("transform", "translate(" + this.position.x + "," + this.position.y + ") " + this.rotater.rotate(Point.zero) + this.transformSuffix);
</ins><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre></div>
<a id="trunkPerformanceTestsAnimometertestssimpleresourcestiledcanvasimagejs"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/Animometer/tests/simple/resources/tiled-canvas-image.js (199243 => 199244)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/Animometer/tests/simple/resources/tiled-canvas-image.js        2016-04-08 20:07:51 UTC (rev 199243)
+++ trunk/PerformanceTests/Animometer/tests/simple/resources/tiled-canvas-image.js        2016-04-08 20:19:26 UTC (rev 199244)
</span><span class="lines">@@ -41,7 +41,7 @@
</span><span class="cx">
</span><span class="cx"> this._tiles = new Array(maxTilesPerRow * maxTilesPerCol);
</span><span class="cx">
</span><del>- var source = Point.zero();
</del><ins>+ var source = Point.zero;
</ins><span class="cx"> for (var index = 0; index < this._tiles.length; ++index) {
</span><span class="cx"> this._tiles[index] = new CanvasImageTile(this, source);
</span><span class="cx"> source = this._nextTilePosition(source);
</span></span></pre></div>
<a id="trunkPerformanceTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/PerformanceTests/ChangeLog (199243 => 199244)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/PerformanceTests/ChangeLog        2016-04-08 20:07:51 UTC (rev 199243)
+++ trunk/PerformanceTests/ChangeLog        2016-04-08 20:19:26 UTC (rev 199244)
</span><span class="lines">@@ -1,3 +1,19 @@
</span><ins>+2016-04-08 Jon Lee <jonlee@apple.com>
+
+ Fix SVG benchmark test
+ https://bugs.webkit.org/show_bug.cgi?id=156410
+
+ Reviewed by Dean Jackson.
+
+ * Animometer/resources/extensions.js: Update Point.zero to be a static Point.
+ * Animometer/tests/simple/resources/tiled-canvas-image.js:
+ (Stage.call._setupTiles): Refactor.
+ * Animometer/tests/master/resources/particles.js:
+ (Particle.prototype.reset): Use Point.center.
+ (complexity): We are not using a gradient background anymore, so remove the +1.
+ * Animometer/tests/master/resources/svg-particles.js: Update to use SVG transform
+ instead of CSS transform.
+
</ins><span class="cx"> 2016-04-06 Jon Lee <jonlee@apple.com>
</span><span class="cx">
</span><span class="cx"> Update master benchmark with SVG test
</span></span></pre>
</div>
</div>
</body>
</html>