<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[199201] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/199201">199201</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-04-07 16:28:08 -0700 (Thu, 07 Apr 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Web Inspector: ProfileView source links are off by 1 line, worse in pretty printed code
https://bugs.webkit.org/show_bug.cgi?id=156371
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-04-07
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
* inspector/protocol/ScriptProfiler.json:
Clarify that these locations are 1-based.
Source/WebInspectorUI:
* UserInterface/Views/ProfileDataGridNode.js:
(WebInspector.ProfileDataGridNode.prototype._displayContent):
Switch the 1-based locations in the CCT data structure to 0-based for SourceCodeLocation.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCoreinspectorprotocolScriptProfilerjson">trunk/Source/JavaScriptCore/inspector/protocol/ScriptProfiler.json</a></li>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsProfileDataGridNodejs">trunk/Source/WebInspectorUI/UserInterface/Views/ProfileDataGridNode.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (199200 => 199201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-04-07 23:14:25 UTC (rev 199200)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-04-07 23:28:08 UTC (rev 199201)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-04-07 Joseph Pecoraro <pecoraro@apple.com>
+
+ Web Inspector: ProfileView source links are off by 1 line, worse in pretty printed code
+ https://bugs.webkit.org/show_bug.cgi?id=156371
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/protocol/ScriptProfiler.json:
+ Clarify that these locations are 1-based.
+
</ins><span class="cx"> 2016-04-07 Jon Davis <jond@apple.com>
</span><span class="cx">
</span><span class="cx"> Add Web Animations API to Feature Status Page
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoreinspectorprotocolScriptProfilerjson"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/inspector/protocol/ScriptProfiler.json (199200 => 199201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/inspector/protocol/ScriptProfiler.json 2016-04-07 23:14:25 UTC (rev 199200)
+++ trunk/Source/JavaScriptCore/inspector/protocol/ScriptProfiler.json 2016-04-07 23:28:08 UTC (rev 199201)
</span><span class="lines">@@ -20,8 +20,8 @@
</span><span class="cx"> "id": "ExpressionLocation",
</span><span class="cx"> "type": "object",
</span><span class="cx"> "properties": [
</span><del>- { "name": "line", "type": "integer" },
- { "name": "column", "type": "integer" }
</del><ins>+ { "name": "line", "type": "integer", "description": "1-based." },
+ { "name": "column", "type": "integer", "description": "1-based." }
</ins><span class="cx"> ]
</span><span class="cx"> },
</span><span class="cx"> {
</span><span class="lines">@@ -30,8 +30,8 @@
</span><span class="cx"> "properties": [
</span><span class="cx"> { "name": "sourceID", "$ref": "Debugger.ScriptId", "description": "Unique script identifier." },
</span><span class="cx"> { "name": "name", "type": "string", "description": "A displayable name for the stack frame. i.e function name, (program), etc." },
</span><del>- { "name": "line", "type": "integer" },
- { "name": "column", "type": "integer" },
</del><ins>+ { "name": "line", "type": "integer", "description": "-1 if unavailable. 1-based if available." },
+ { "name": "column", "type": "integer", "description": "-1 if unavailable. 1-based if available." },
</ins><span class="cx"> { "name": "url", "type": "string" },
</span><span class="cx"> { "name": "expressionLocation", "$ref": "ExpressionLocation", "optional": true }
</span><span class="cx"> ]
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (199200 => 199201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-04-07 23:14:25 UTC (rev 199200)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-04-07 23:28:08 UTC (rev 199201)
</span><span class="lines">@@ -1,5 +1,16 @@
</span><span class="cx"> 2016-04-07 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Web Inspector: ProfileView source links are off by 1 line, worse in pretty printed code
+ https://bugs.webkit.org/show_bug.cgi?id=156371
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ProfileDataGridNode.js:
+ (WebInspector.ProfileDataGridNode.prototype._displayContent):
+ Switch the 1-based locations in the CCT data structure to 0-based for SourceCodeLocation.
+
+2016-04-07 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Web Inspector: Uncaught Exception: No resource with given URL found
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=156259
</span><span class="cx"> <rdar://problem/25564749>
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsProfileDataGridNodejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProfileDataGridNode.js (199200 => 199201)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/ProfileDataGridNode.js 2016-04-07 23:14:25 UTC (rev 199200)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProfileDataGridNode.js 2016-04-07 23:28:08 UTC (rev 199201)
</span><span class="lines">@@ -220,7 +220,8 @@
</span><span class="cx">
</span><span class="cx"> let script = WebInspector.debuggerManager.scriptForIdentifier(this._node.sourceID);
</span><span class="cx"> if (script && script.url && this._node.line >= 0 && this._node.column >= 0) {
</span><del>- let sourceCodeLocation = script.createSourceCodeLocation(this._node.line, this._node.column);
</del><ins>+ // Convert from 1-based line and column to 0-based.
+ let sourceCodeLocation = script.createSourceCodeLocation(this._node.line - 1, this._node.column - 1);
</ins><span class="cx">
</span><span class="cx"> let locationElement = fragment.appendChild(document.createElement("span"));
</span><span class="cx"> locationElement.classList.add("location");
</span></span></pre>
</div>
</div>
</body>
</html>