<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198837] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198837">198837</a></dd>
<dt>Author</dt> <dd>simon.fraser@apple.com</dd>
<dt>Date</dt> <dd>2016-03-30 09:25:18 -0700 (Wed, 30 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make animation events non-cancelable
https://bugs.webkit.org/show_bug.cgi?id=78110
Reviewed by Dan Bates.
Source/WebCore:
Make the animation events non-cancelable.
Test: animations/animation-events-not-cancelable.html
* dom/AnimationEvent.cpp:
(WebCore::AnimationEvent::AnimationEvent):
LayoutTests:
* animations/animation-events-not-cancelable-expected.txt: Added.
* animations/animation-events-not-cancelable.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoredomAnimationEventcpp">trunk/Source/WebCore/dom/AnimationEvent.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsanimationsanimationeventsnotcancelableexpectedtxt">trunk/LayoutTests/animations/animation-events-not-cancelable-expected.txt</a></li>
<li><a href="#trunkLayoutTestsanimationsanimationeventsnotcancelablehtml">trunk/LayoutTests/animations/animation-events-not-cancelable.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (198836 => 198837)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-03-30 14:37:29 UTC (rev 198836)
+++ trunk/LayoutTests/ChangeLog 2016-03-30 16:25:18 UTC (rev 198837)
</span><span class="lines">@@ -1,3 +1,13 @@
</span><ins>+2016-03-24 Simon Fraser <simon.fraser@apple.com>
+
+ Make animation events non-cancelable
+ https://bugs.webkit.org/show_bug.cgi?id=78110
+
+ Reviewed by Dan Bates.
+
+ * animations/animation-events-not-cancelable-expected.txt: Added.
+ * animations/animation-events-not-cancelable.html: Added.
+
</ins><span class="cx"> 2016-03-30 Gyuyoung Kim <gyuyoung.kim@webkit.org>
</span><span class="cx">
</span><span class="cx"> [EFL] Mark svg zoom and pageoverlay tests to failure
</span></span></pre></div>
<a id="trunkLayoutTestsanimationsanimationeventsnotcancelableexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/animations/animation-events-not-cancelable-expected.txt (0 => 198837)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/animations/animation-events-not-cancelable-expected.txt (rev 0)
+++ trunk/LayoutTests/animations/animation-events-not-cancelable-expected.txt 2016-03-30 16:25:18 UTC (rev 198837)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+Tests that animation events are not cancelable.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+animationstart:
+PASS event.cancelable is false
+animationiteration:
+PASS event.cancelable is false
+animationend:
+PASS event.cancelable is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
</ins></span></pre></div>
<a id="trunkLayoutTestsanimationsanimationeventsnotcancelablehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/animations/animation-events-not-cancelable.html (0 => 198837)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/animations/animation-events-not-cancelable.html (rev 0)
+++ trunk/LayoutTests/animations/animation-events-not-cancelable.html 2016-03-30 16:25:18 UTC (rev 198837)
</span><span class="lines">@@ -0,0 +1,53 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<script src="../resources/js-test-pre.js"></script>
+<style>
+#box {
+ height: 10px;
+ width: 10px;
+ background-color: blue;
+ position: relative;
+}
+#box.running {
+ animation: move 0.02s 2 linear;
+}
+@keyframes move {
+ from { left: 0px; }
+ to { left: 10px; }
+}
+</style>
+</head>
+<body>
+<div id="box"></div>
+
+<p id="description"></p>
+<div id="console"></div>
+<script>
+jsTestIsAsync = true;
+
+description('Tests that animation events are not cancelable.');
+
+var box = document.getElementById('box');
+box.addEventListener('animationstart', function(event) {
+ debug(event.type + ':');
+ shouldBe('event.cancelable', 'false');
+}, false);
+
+box.addEventListener('animationiteration', function(event) {
+ debug(event.type + ':');
+ shouldBe('event.cancelable', 'false');
+}, false);
+
+box.addEventListener('animationend', function(event) {
+ debug(event.type + ':');
+ shouldBe('event.cancelable', 'false');
+ finishJSTest();
+}, false);
+
+box.classList.add('running');
+
+</script>
+<script src="../resources/js-test-post.js"></script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (198836 => 198837)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-03-30 14:37:29 UTC (rev 198836)
+++ trunk/Source/WebCore/ChangeLog 2016-03-30 16:25:18 UTC (rev 198837)
</span><span class="lines">@@ -1,3 +1,17 @@
</span><ins>+2016-03-24 Simon Fraser <simon.fraser@apple.com>
+
+ Make animation events non-cancelable
+ https://bugs.webkit.org/show_bug.cgi?id=78110
+
+ Reviewed by Dan Bates.
+
+ Make the animation events non-cancelable.
+
+ Test: animations/animation-events-not-cancelable.html
+
+ * dom/AnimationEvent.cpp:
+ (WebCore::AnimationEvent::AnimationEvent):
+
</ins><span class="cx"> 2016-03-30 Manuel Rego Casasnovas <rego@igalia.com>
</span><span class="cx">
</span><span class="cx"> [css-grid] Refactor positioned children code
</span></span></pre></div>
<a id="trunkSourceWebCoredomAnimationEventcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/dom/AnimationEvent.cpp (198836 => 198837)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/dom/AnimationEvent.cpp 2016-03-30 14:37:29 UTC (rev 198836)
+++ trunk/Source/WebCore/dom/AnimationEvent.cpp 2016-03-30 16:25:18 UTC (rev 198837)
</span><span class="lines">@@ -38,7 +38,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> AnimationEvent::AnimationEvent(const AtomicString& type, const String& animationName, double elapsedTime)
</span><del>- : Event(type, true, true)
</del><ins>+ : Event(type, true, false)
</ins><span class="cx"> , m_animationName(animationName)
</span><span class="cx"> , m_elapsedTime(elapsedTime)
</span><span class="cx"> {
</span></span></pre>
</div>
</div>
</body>
</html>