<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198758] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198758">198758</a></dd>
<dt>Author</dt> <dd>mmaxfield@apple.com</dd>
<dt>Date</dt> <dd>2016-03-28 14:37:39 -0700 (Mon, 28 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>[RTL Scrollbars] Position:sticky can be positioned under vertical RTL scrollbar
https://bugs.webkit.org/show_bug.cgi?id=155949
Reviewed by Simon Fraser.
Source/WebCore:
When performing sticky positioning logic, we were setting the clip rect's position
equal to the scrollPosition of the layer. This computation assumes that the top
left of the scroll position is the same as the top left of the clip rect. When
using RTL scrollbars, this is not true, so this code simply needs to be made aware
of the presence of an RTL scrollbar.
Tests: fast/scrolling/rtl-scrollbars-sticky-document-2.html
fast/scrolling/rtl-scrollbars-sticky-document.html
fast/scrolling/rtl-scrollbars-sticky-iframe-2.html
fast/scrolling/rtl-scrollbars-sticky-iframe.html
fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html
fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::constrainingRectForStickyPosition):
LayoutTests:
* platform/ios-simulator/TestExpectations:
* fast/scrolling/rtl-scrollbars-sticky-document-2-expected.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-document-2.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-document-expected.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-document.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-iframe-2-expected.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-iframe-2.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-iframe-expected.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-iframe.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2-expected.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-expected.html: Added.
* fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkLayoutTestsplatformiossimulatorTestExpectations">trunk/LayoutTests/platform/ios-simulator/TestExpectations</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderBoxModelObjectcpp">trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickydocument2expectedhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickydocument2html">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickydocumentexpectedhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickydocumenthtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickyiframe2expectedhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickyiframe2html">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickyiframeexpectedhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickyiframehtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickyoverflowscroll2expectedhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickyoverflowscroll2html">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickyoverflowscrollexpectedhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-expected.html</a></li>
<li><a href="#trunkLayoutTestsfastscrollingrtlscrollbarsstickyoverflowscrollhtml">trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (198757 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-03-28 20:59:56 UTC (rev 198757)
+++ trunk/LayoutTests/ChangeLog 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -1,3 +1,24 @@
</span><ins>+2016-03-28 Myles C. Maxfield <mmaxfield@apple.com>
+
+ [RTL Scrollbars] Position:sticky can be positioned under vertical RTL scrollbar
+ https://bugs.webkit.org/show_bug.cgi?id=155949
+
+ Reviewed by Simon Fraser.
+
+ * platform/ios-simulator/TestExpectations:
+ * fast/scrolling/rtl-scrollbars-sticky-document-2-expected.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-document-2.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-document-expected.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-document.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-iframe-2-expected.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-iframe-2.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-iframe-expected.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-iframe.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2-expected.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-expected.html: Added.
+ * fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html: Added.
+
</ins><span class="cx"> 2016-03-28 Zalan Bujtas <zalan@apple.com>
</span><span class="cx">
</span><span class="cx"> Setup cloned continuation renderer properly.
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickydocument2expectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2-expected.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2-expected.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2-expected.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,15 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<div style="position: absolute; top: 100px; left: 0px; width: 2000px; height: 2000px;">
+ <div style="position: absolute; left: 850px; top: 0px; width: 100px; height: 100px; background: green;"></div>
+ <div style="position: absolute; left: 950px; top: 0px; width: 685px; height: 100px; background: blue;"></div>
+</div>
+<script>
+window.scroll(850, 0);
+</script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickydocument2html"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-2.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<div style="position: absolute; top: 100px; left: 0px; width: 2000px; height: 2000px;">
+ <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
+</div>
+<script>
+window.scroll(850, 0);
+</script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickydocumentexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-expected.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-expected.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document-expected.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,12 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<div style="position: absolute; top: 100px; left: 0px; width: 2000px; height: 2000px;">
+ <div style="position: absolute; left: 0px; top: 0px; width: 685px; height: 100px; background: blue;"></div>
+ <div style="position: absolute; left: 685px; top: 0px; width: 100px; height: 100px; background: green;"></div>
+</div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickydocumenthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-document.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,11 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<div style="position: absolute; top: 100px; left: 0px; width: 2000px; height: 2000px;">
+ <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
+</div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickyiframe2expectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2-expected.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2-expected.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2-expected.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<iframe style="position: relative; width: 600px; height: 500px; border: 0px solid black;" srcdoc="<!DOCTYPE html>
+<head>
+</head>
+<body>
+<div style='position: absolute; top: 0px; left: 0px; width: 2000px; height: 2000px'>
+ <div style='position: absolute; left: 850px; width: 100px; height: 100px; background: green;'></div>
+ <div style='position: absolute; left: 950px; width: 485px; height: 100px; background: blue;'></div>
+</div>
+<script>
+window.scroll(850, 0);
+</script>
+</body>
+</html">
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickyiframe2html"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-2.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<iframe style="position: relative; width: 600px; height: 500px; border: 0px solid black;" srcdoc="<!DOCTYPE html>
+<head>
+</head>
+<body>
+<div style='position: absolute; top: 0px; left: 0px; width: 2000px; height: 2000px'>
+ <div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div><div style='display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;'></div><div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div>
+</div>
+<script>
+window.scroll(850, 0);
+</script>
+</body>
+</html">
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickyiframeexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-expected.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-expected.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe-expected.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<iframe style="position: relative; width: 600px; height: 500px; border: 0px solid black;" srcdoc="<!DOCTYPE html>
+<head>
+</head>
+<body>
+<div style='position: absolute; top: 0px; left: 0px; width: 2000px; height: 2000px'>
+ <div style='position: absolute; width: 485px; height: 100px; background: blue;'></div>
+ <div style='position: absolute; left: 485px; width: 100px; height: 100px; background: green;'></div>
+</div>
+</body>
+</html">
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickyiframehtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-iframe.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<iframe style="position: relative; width: 600px; height: 500px; border: 0px solid black;" srcdoc="<!DOCTYPE html>
+<head>
+</head>
+<body>
+<div style='position: absolute; top: 0px; left: 0px; width: 2000px; height: 2000px'>
+ <div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div><div style='display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;'></div><div style='display: inline-block; position: static; width: 800px; height: 100px; background: blue;'></div>
+</div>
+</body>
+</html">
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickyoverflowscroll2expectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2-expected.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2-expected.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2-expected.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,18 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<div id="scrolling" style="position: relative; width: 600px; height: 500px; overflow: scroll;">
+ <div style="position: absolute; top: 0px; left: 0px; width: 2000px; height: 1px;">
+ <div style="position: absolute; left: 1000px; width: 100px; height: 100px; background: green;"></div>
+ <div style="position: absolute; left: 1100px; width: 485px; height: 100px; background: blue;"></div>
+</div>
+</div>
+<script>
+var scrollingElement = document.getElementById("scrolling");
+scrollingElement.scrollLeft = 1000;
+</script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickyoverflowscroll2html"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,17 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<div id="scrolling" style="position: relative; width: 600px; height: 500px; overflow: scroll;">
+<div style="position: absolute; top: 0px; left: 0px; width: 2000px;">
+ <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
+</div>
+</div>
+<script>
+var scrollingElement = document.getElementById("scrolling");
+scrollingElement.scrollLeft = 1000;
+</script>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickyoverflowscrollexpectedhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-expected.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-expected.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-expected.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,14 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<div style="position: relative; width: 600px; height: 500px; overflow: scroll;">
+ <div style="position: absolute; top: 0px; left: 0px; width: 2000px; height: 1px;">
+ <div style="position: absolute; width: 485px; height: 100px; background: blue;"></div>
+ <div style="position: absolute; left: 485px; width: 100px; height: 100px; background: green;"></div>
+</div>
+</div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsfastscrollingrtlscrollbarsstickyoverflowscrollhtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html (0 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html (rev 0)
+++ trunk/LayoutTests/fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -0,0 +1,13 @@
</span><ins>+<!DOCTYPE html><!-- webkit-test-runner [ rtlScrollbars=true ] -->
+<html>
+<head>
+</head>
+<body style="margin: 0px;">
+This test makes sure that position-sticky obeys RTL scrollbars when positioning.
+<div style="position: relative; width: 600px; height: 500px; overflow: scroll;">
+<div style="position: absolute; top: 0px; left: 0px; width: 2000px;">
+ <div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div><div style="display: inline-block; position: -webkit-sticky; left: 0px; right: 0px; width: 100px; height: 100px; background: green;"></div><div style="display: inline-block; position: static; width: 800px; height: 100px; background: blue;"></div>
+</div>
+</div>
+</body>
+</html>
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkLayoutTestsplatformiossimulatorTestExpectations"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (198757 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-03-28 20:59:56 UTC (rev 198757)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -3003,3 +3003,9 @@
</span><span class="cx"> webkit.org/b/94458 [ Debug ] http/tests/security/aboutBlank/window-open-self-about-blank.html [ Pass Crash ]
</span><span class="cx">
</span><span class="cx"> webkit.org/b/155565 [ Debug ] mathml/very-large-stretchy-operators.html [ Skip ]
</span><ins>+
+# RTL Scrollbars are not implemented on iOS.
+fast/scrolling/rtl-scrollbars-sticky-document-2.html [ ImageOnlyFailure ]
+fast/scrolling/rtl-scrollbars-sticky-document.html [ ImageOnlyFailure ]
+fast/scrolling/rtl-scrollbars-sticky-iframe-2.html [ ImageOnlyFailure ]
+fast/scrolling/rtl-scrollbars-sticky-iframe.html [ ImageOnlyFailure ]
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (198757 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-03-28 20:59:56 UTC (rev 198757)
+++ trunk/Source/WebCore/ChangeLog 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -1,3 +1,26 @@
</span><ins>+2016-03-28 Myles C. Maxfield <mmaxfield@apple.com>
+
+ [RTL Scrollbars] Position:sticky can be positioned under vertical RTL scrollbar
+ https://bugs.webkit.org/show_bug.cgi?id=155949
+
+ Reviewed by Simon Fraser.
+
+ When performing sticky positioning logic, we were setting the clip rect's position
+ equal to the scrollPosition of the layer. This computation assumes that the top
+ left of the scroll position is the same as the top left of the clip rect. When
+ using RTL scrollbars, this is not true, so this code simply needs to be made aware
+ of the presence of an RTL scrollbar.
+
+ Tests: fast/scrolling/rtl-scrollbars-sticky-document-2.html
+ fast/scrolling/rtl-scrollbars-sticky-document.html
+ fast/scrolling/rtl-scrollbars-sticky-iframe-2.html
+ fast/scrolling/rtl-scrollbars-sticky-iframe.html
+ fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html
+ fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html
+
+ * rendering/RenderBoxModelObject.cpp:
+ (WebCore::RenderBoxModelObject::constrainingRectForStickyPosition):
+
</ins><span class="cx"> 2016-03-28 Antonio Gomes <tonikitoo@webkit.org>
</span><span class="cx">
</span><span class="cx"> Rename PlatformWheelEvent::isEndGesture to isEndOfMomentumScroll.
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderBoxModelObjectcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (198757 => 198758)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2016-03-28 20:59:56 UTC (rev 198757)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2016-03-28 21:37:39 UTC (rev 198758)
</span><span class="lines">@@ -443,14 +443,19 @@
</span><span class="cx"> RenderLayer* enclosingClippingLayer = layer()->enclosingOverflowClipLayer(ExcludeSelf);
</span><span class="cx"> if (enclosingClippingLayer) {
</span><span class="cx"> RenderBox& enclosingClippingBox = downcast<RenderBox>(enclosingClippingLayer->renderer());
</span><del>- LayoutRect clipRect = enclosingClippingBox.overflowClipRect(LayoutPoint(), 0); // FIXME: make this work in regions.
</del><ins>+ LayoutRect clipRect = enclosingClippingBox.overflowClipRect(LayoutPoint(), nullptr); // FIXME: make this work in regions.
</ins><span class="cx"> clipRect.contract(LayoutSize(enclosingClippingBox.paddingLeft() + enclosingClippingBox.paddingRight(),
</span><span class="cx"> enclosingClippingBox.paddingTop() + enclosingClippingBox.paddingBottom()));
</span><span class="cx">
</span><span class="cx"> FloatRect constrainingRect = enclosingClippingBox.localToContainerQuad(FloatRect(clipRect), &view()).boundingBox();
</span><span class="cx">
</span><span class="cx"> FloatPoint scrollOffset = FloatPoint() + enclosingClippingLayer->scrollOffset();
</span><del>- constrainingRect.setLocation(scrollOffset);
</del><ins>+
+ float scrollbarOffset = 0;
+ if (enclosingClippingBox.hasLayer() && enclosingClippingBox.style().shouldPlaceBlockDirectionScrollbarOnLeft())
+ scrollbarOffset = enclosingClippingBox.layer()->verticalScrollbarWidth(IgnoreOverlayScrollbarSize);
+
+ constrainingRect.setLocation(FloatPoint(scrollOffset.x() + scrollbarOffset, scrollOffset.y()));
</ins><span class="cx"> return constrainingRect;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>