<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198753] trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198753">198753</a></dd>
<dt>Author</dt> <dd>zalan@apple.com</dd>
<dt>Date</dt> <dd>2016-03-28 11:39:21 -0700 (Mon, 28 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Setup cloned continuation renderer properly.
https://bugs.webkit.org/show_bug.cgi?id=155640
Reviewed by Simon Fraser.
Set the "renderer has outline ancestor" flag on the cloned inline renderer when
we split the original renderer for continuation.
It ensures that when the cloned part of the continuation requests repaint, we properly
invalidate the ancestor outline (if needed).
Source/WebCore:
Test: fast/inline/outline-with-continuation-assert.html
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clone):
LayoutTests:
* fast/inline/outline-with-continuation-assert-expected.txt: Added.
* fast/inline/outline-with-continuation-assert.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCorerenderingRenderInlinecpp">trunk/Source/WebCore/rendering/RenderInline.cpp</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkLayoutTestsfastinlineoutlinewithcontinuationassertexpectedtxt">trunk/LayoutTests/fast/inline/outline-with-continuation-assert-expected.txt</a></li>
<li><a href="#trunkLayoutTestsfastinlineoutlinewithcontinuationasserthtml">trunk/LayoutTests/fast/inline/outline-with-continuation-assert.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkLayoutTestsChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (198752 => 198753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/ChangeLog 2016-03-28 18:21:08 UTC (rev 198752)
+++ trunk/LayoutTests/ChangeLog 2016-03-28 18:39:21 UTC (rev 198753)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-03-28 Zalan Bujtas <zalan@apple.com>
+
+ Setup cloned continuation renderer properly.
+ https://bugs.webkit.org/show_bug.cgi?id=155640
+
+ Reviewed by Simon Fraser.
+
+ Set the "renderer has outline ancestor" flag on the cloned inline renderer when
+ we split the original renderer for continuation.
+ It ensures that when the cloned part of the continuation requests repaint, we properly
+ invalidate the ancestor outline (if needed).
+
+ * fast/inline/outline-with-continuation-assert-expected.txt: Added.
+ * fast/inline/outline-with-continuation-assert.html: Added.
+
</ins><span class="cx"> 2016-03-28 Ryan Haddad <ryanhaddad@apple.com>
</span><span class="cx">
</span><span class="cx"> Marking transitions/cancel-transition.html as flaky on ios-sim-wk2
</span></span></pre></div>
<a id="trunkLayoutTestsfastinlineoutlinewithcontinuationassertexpectedtxt"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/inline/outline-with-continuation-assert-expected.txt (0 => 198753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/inline/outline-with-continuation-assert-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/inline/outline-with-continuation-assert-expected.txt 2016-03-28 18:39:21 UTC (rev 198753)
</span><span class="lines">@@ -0,0 +1,2 @@
</span><ins>+PASS if no assert in Debug.
+a
</ins></span></pre></div>
<a id="trunkLayoutTestsfastinlineoutlinewithcontinuationasserthtml"></a>
<div class="addfile"><h4>Added: trunk/LayoutTests/fast/inline/outline-with-continuation-assert.html (0 => 198753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/LayoutTests/fast/inline/outline-with-continuation-assert.html (rev 0)
+++ trunk/LayoutTests/fast/inline/outline-with-continuation-assert.html 2016-03-28 18:39:21 UTC (rev 198753)
</span><span class="lines">@@ -0,0 +1,26 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<head>
+<title>This tests that inline continuation inherits outline painting properly.</title>
+</head>
+<style>
+div {
+ outline: auto
+}
+</style>
+</head>
+<body>
+PASS if no assert in Debug.
+<div>
+<span><span><span id="foo"></span>a</span></span>
+</div>
+<script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+ document.execCommand('selectAll');
+ var child = document.createElement('frame');
+ parent = document.getElementById('foo');
+ parent.appendChild(child);
+</script>
+</body>
+</html>
</ins></span></pre></div>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (198752 => 198753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-03-28 18:21:08 UTC (rev 198752)
+++ trunk/Source/WebCore/ChangeLog 2016-03-28 18:39:21 UTC (rev 198753)
</span><span class="lines">@@ -1,3 +1,20 @@
</span><ins>+2016-03-28 Zalan Bujtas <zalan@apple.com>
+
+ Setup cloned continuation renderer properly.
+ https://bugs.webkit.org/show_bug.cgi?id=155640
+
+ Reviewed by Simon Fraser.
+
+ Set the "renderer has outline ancestor" flag on the cloned inline renderer when
+ we split the original renderer for continuation.
+ It ensures that when the cloned part of the continuation requests repaint, we properly
+ invalidate the ancestor outline (if needed).
+
+ Test: fast/inline/outline-with-continuation-assert.html
+
+ * rendering/RenderInline.cpp:
+ (WebCore::RenderInline::clone):
+
</ins><span class="cx"> 2016-03-25 Simon Fraser <simon.fraser@apple.com>
</span><span class="cx">
</span><span class="cx"> Inspector Memory Timeline sometimes encounters unstoppable rAF drawing
</span></span></pre></div>
<a id="trunkSourceWebCorerenderingRenderInlinecpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (198752 => 198753)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/rendering/RenderInline.cpp 2016-03-28 18:21:08 UTC (rev 198752)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp 2016-03-28 18:39:21 UTC (rev 198753)
</span><span class="lines">@@ -416,6 +416,7 @@
</span><span class="cx"> RenderPtr<RenderInline> cloneInline = createRenderer<RenderInline>(*element(), style());
</span><span class="cx"> cloneInline->initializeStyle();
</span><span class="cx"> cloneInline->setFlowThreadState(flowThreadState());
</span><ins>+ cloneInline->setHasOutlineAutoAncestor(hasOutlineAutoAncestor());
</ins><span class="cx"> return cloneInline;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>