<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198748] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198748">198748</a></dd>
<dt>Author</dt> <dd>mattbaker@apple.com</dd>
<dt>Date</dt> <dd>2016-03-28 10:47:53 -0700 (Mon, 28 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>REGRESSION (<a href="http://trac.webkit.org/projects/webkit/changeset/195303">r195303</a>): Web Inspector: Wrong indentation in the type coverage profiler popovers
https://bugs.webkit.org/show_bug.cgi?id=155930
<rdar://problem/25377042>
Reviewed by Timothy Hatcher.
Increased specificity of TypeTreeView CSS selectors, and added new
overrides for rules made global by <a href="http://trac.webkit.org/projects/webkit/changeset/195303">r195303</a>, which don't apply to the
TypeTreeView's or its tree elements.
* UserInterface/Views/TypeTreeElement.css:
(.item.type-tree-element):
(.item.type-tree-element > .titles):
(.item.type-tree-element > .disclosure-button):
(.item.type-tree-element.parent > .disclosure-button):
(.item.type-tree-element.parent.expanded > .disclosure-button):
(.item.type-tree-element > .icon):
(.item.type-tree-element.prototype):
(.item.type-tree-element.prototype:focus):
(.item.type-tree-element.prototype + ol):
(.type-tree-element): Deleted.
(.type-tree-element > .titles): Deleted.
(.type-tree-element > .disclosure-button): Deleted.
(.type-tree-element.parent > .disclosure-button): Deleted.
(.type-tree-element.parent.expanded > .disclosure-button): Deleted.
(.type-tree-element > .icon): Deleted.
(.type-tree-element.prototype): Deleted.
(.type-tree-element.prototype:focus): Deleted.
(.type-tree-element.prototype + ol): Deleted.
* UserInterface/Views/TypeTreeView.css:
(.tree-outline.type li):
* UserInterface/Views/TypeTreeView.js:
(WebInspector.TypeTreeView):
Use custom indentation.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTypeTreeElementcss">trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTypeTreeViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTypeTreeViewjs">trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (198747 => 198748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-28 17:46:01 UTC (rev 198747)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-28 17:47:53 UTC (rev 198748)
</span><span class="lines">@@ -1,3 +1,42 @@
</span><ins>+2016-03-28 Matt Baker <mattbaker@apple.com>
+
+ REGRESSION (r195303): Web Inspector: Wrong indentation in the type coverage profiler popovers
+ https://bugs.webkit.org/show_bug.cgi?id=155930
+ <rdar://problem/25377042>
+
+ Reviewed by Timothy Hatcher.
+
+ Increased specificity of TypeTreeView CSS selectors, and added new
+ overrides for rules made global by r195303, which don't apply to the
+ TypeTreeView's or its tree elements.
+
+ * UserInterface/Views/TypeTreeElement.css:
+ (.item.type-tree-element):
+ (.item.type-tree-element > .titles):
+ (.item.type-tree-element > .disclosure-button):
+ (.item.type-tree-element.parent > .disclosure-button):
+ (.item.type-tree-element.parent.expanded > .disclosure-button):
+ (.item.type-tree-element > .icon):
+ (.item.type-tree-element.prototype):
+ (.item.type-tree-element.prototype:focus):
+ (.item.type-tree-element.prototype + ol):
+ (.type-tree-element): Deleted.
+ (.type-tree-element > .titles): Deleted.
+ (.type-tree-element > .disclosure-button): Deleted.
+ (.type-tree-element.parent > .disclosure-button): Deleted.
+ (.type-tree-element.parent.expanded > .disclosure-button): Deleted.
+ (.type-tree-element > .icon): Deleted.
+ (.type-tree-element.prototype): Deleted.
+ (.type-tree-element.prototype:focus): Deleted.
+ (.type-tree-element.prototype + ol): Deleted.
+
+ * UserInterface/Views/TypeTreeView.css:
+ (.tree-outline.type li):
+
+ * UserInterface/Views/TypeTreeView.js:
+ (WebInspector.TypeTreeView):
+ Use custom indentation.
+
</ins><span class="cx"> 2016-03-28 Nikita Vasilyev <nvasilyev@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Large repaints while typing in the console tab
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTypeTreeElementcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css (198747 => 198748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css 2016-03-28 17:46:01 UTC (rev 198747)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css 2016-03-28 17:47:53 UTC (rev 198748)
</span><span class="lines">@@ -23,12 +23,14 @@
</span><span class="cx"> * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-.type-tree-element {
</del><ins>+.item.type-tree-element {
</ins><span class="cx"> margin-top: 1px;
</span><ins>+ height: auto;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.type-tree-element > .titles {
</del><ins>+.item.type-tree-element > .titles {
</ins><span class="cx"> position: relative;
</span><ins>+ top: auto;
</ins><span class="cx"> line-height: normal;
</span><span class="cx"> padding-bottom: 1px;
</span><span class="cx"> text-overflow: ellipsis;
</span><span class="lines">@@ -38,12 +40,11 @@
</span><span class="cx"> vertical-align: top;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.type-tree-element > .disclosure-button {
</del><ins>+.item.type-tree-element > .disclosure-button {
</ins><span class="cx"> display: inline-block;
</span><span class="cx"> vertical-align: top;
</span><span class="cx">
</span><span class="cx"> width: 15px;
</span><del>- height: 16px;
</del><span class="cx">
</span><span class="cx"> margin-left: -1px;
</span><span class="cx"> border: 0;
</span><span class="lines">@@ -51,7 +52,7 @@
</span><span class="cx"> -webkit-appearance: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.type-tree-element.parent > .disclosure-button {
</del><ins>+.item.type-tree-element.parent > .disclosure-button {
</ins><span class="cx"> background-color: transparent;
</span><span class="cx"> background-image: url(../Images/DisclosureTriangles.svg#closed-normal);
</span><span class="cx"> background-repeat: no-repeat;
</span><span class="lines">@@ -59,15 +60,15 @@
</span><span class="cx"> background-size: 13px 13px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.type-tree-element.parent.expanded > .disclosure-button {
</del><ins>+.item.type-tree-element.parent.expanded > .disclosure-button {
</ins><span class="cx"> background-image: url(../Images/DisclosureTriangles.svg#open-normal);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.type-tree-element > .icon {
</del><ins>+.item.type-tree-element > .icon {
</ins><span class="cx"> display: none;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.type-tree-element.prototype {
</del><ins>+.item.type-tree-element.prototype {
</ins><span class="cx"> display: inline-block;
</span><span class="cx">
</span><span class="cx"> border: 1px solid hsla(0, 0%, 0%, 0.06);
</span><span class="lines">@@ -75,14 +76,14 @@
</span><span class="cx"> border-radius: 3px;
</span><span class="cx">
</span><span class="cx"> padding: 0 10px 1px 0;
</span><del>- margin: 3px 0 2px 0;
</del><ins>+ margin: 3px 0 2px -1px;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.type-tree-element.prototype:hover,
-.type-tree-element.prototype:focus {
</del><ins>+.item.type-tree-element.prototype:hover,
+.item.type-tree-element.prototype:focus {
</ins><span class="cx"> border-color: hsla(0, 0%, 0%, 0.1);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.type-tree-element.prototype + ol {
</del><ins>+.item.type-tree-element.prototype + ol {
</ins><span class="cx"> -webkit-padding-start: 0px;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTypeTreeViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css (198747 => 198748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css 2016-03-28 17:46:01 UTC (rev 198747)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css 2016-03-28 17:47:53 UTC (rev 198748)
</span><span class="lines">@@ -41,6 +41,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .tree-outline.type li {
</span><ins>+ padding: 0;
</ins><span class="cx"> white-space: nowrap;
</span><span class="cx"> text-overflow: ellipsis;
</span><span class="cx"> overflow: hidden;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTypeTreeViewjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.js (198747 => 198748)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.js 2016-03-28 17:46:01 UTC (rev 198747)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.js 2016-03-28 17:47:53 UTC (rev 198748)
</span><span class="lines">@@ -37,6 +37,7 @@
</span><span class="cx"> this._element.className = "type-tree";
</span><span class="cx">
</span><span class="cx"> this._outline = new WebInspector.TreeOutline;
</span><ins>+ this._outline.customIndent = true;
</ins><span class="cx"> this._outline.element.classList.add("type");
</span><span class="cx"> this._element.appendChild(this._outline.element);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>