<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198688] trunk/Source/WebInspectorUI</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198688">198688</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-03-25 13:45:35 -0700 (Fri, 25 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Unreviewed, rolling out <a href="http://trac.webkit.org/projects/webkit/changeset/198619">r198619</a>.
https://bugs.webkit.org/show_bug.cgi?id=155902
Switching to Console tab sometimes results in blank tab.
(Requested by JoePeck on #webkit).
Reverted changeset:
"Web Inspector: Large repaints while typing in the console
tab"
https://bugs.webkit.org/show_bug.cgi?id=155627
http://trac.webkit.org/changeset/198619</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebInspectorUIChangeLog">trunk/Source/WebInspectorUI/ChangeLog</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceBaseMainjs">trunk/Source/WebInspectorUI/UserInterface/Base/Main.js</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss">trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css</a></li>
<li><a href="#trunkSourceWebInspectorUIUserInterfaceViewsTabBarjs">trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebInspectorUIChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/ChangeLog (198687 => 198688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-25 20:37:49 UTC (rev 198687)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-25 20:45:35 UTC (rev 198688)
</span><span class="lines">@@ -1,3 +1,18 @@
</span><ins>+2016-03-25 Commit Queue <commit-queue@webkit.org>
+
+ Unreviewed, rolling out r198619.
+ https://bugs.webkit.org/show_bug.cgi?id=155902
+
+ Switching to Console tab sometimes results in blank tab.
+ (Requested by JoePeck on #webkit).
+
+ Reverted changeset:
+
+ "Web Inspector: Large repaints while typing in the console
+ tab"
+ https://bugs.webkit.org/show_bug.cgi?id=155627
+ http://trac.webkit.org/changeset/198619
+
</ins><span class="cx"> 2016-03-25 Matt Baker <mattbaker@apple.com>
</span><span class="cx">
</span><span class="cx"> Web Inspector: Scrolling/selection is broken in Quick Open dialog resource tree
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceBaseMainjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (198687 => 198688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2016-03-25 20:37:49 UTC (rev 198687)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2016-03-25 20:45:35 UTC (rev 198688)
</span><span class="lines">@@ -226,7 +226,6 @@
</span><span class="cx"> this.tabBar = new WebInspector.TabBar(document.getElementById("tab-bar"));
</span><span class="cx"> this.tabBar.addEventListener(WebInspector.TabBar.Event.NewTabItemClicked, this._newTabItemClicked, this);
</span><span class="cx"> this.tabBar.addEventListener(WebInspector.TabBar.Event.OpenDefaultTab, this._openDefaultTab, this);
</span><del>- this.tabBar.addEventListener(WebInspector.TabBar.Event.TabBarItemSelected, this._tabBarItemSelected, this);
</del><span class="cx">
</span><span class="cx"> this._contentElement = document.getElementById("content");
</span><span class="cx"> this._contentElement.setAttribute("role", "main");
</span><span class="lines">@@ -541,18 +540,6 @@
</span><span class="cx"> this.showNewTabTab();
</span><span class="cx"> };
</span><span class="cx">
</span><del>-WebInspector._tabBarItemSelected = function(event)
-{
- let {previouslySelectedTabIdentifier, selectedTabIdentifier} = event.data;
- const classNamePrefix = "selected-tab-";
-
- if (previouslySelectedTabIdentifier)
- document.body.classList.remove(classNamePrefix + previouslySelectedTabIdentifier);
-
- console.assert(selectedTabIdentifier);
- document.body.classList.add(classNamePrefix + selectedTabIdentifier);
-};
-
</del><span class="cx"> WebInspector._tryToRestorePendingTabs = function()
</span><span class="cx"> {
</span><span class="cx"> let stillPendingOpenTabs = [];
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsLogContentViewcss"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (198687 => 198688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2016-03-25 20:37:49 UTC (rev 198687)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2016-03-25 20:45:35 UTC (rev 198688)
</span><span class="lines">@@ -23,15 +23,6 @@
</span><span class="cx"> * THE POSSIBILITY OF SUCH DAMAGE.
</span><span class="cx"> */
</span><span class="cx">
</span><del>-body.selected-tab-console #content {
- /* FIXME: This shouldn't be necessary once https://webkit.org/b/145324 is resolved. */
- position: absolute;
- top: 0;
- bottom: 0;
- left: 0;
- right: 0;
-}
-
</del><span class="cx"> .log-scope-bar > li.unread::before {
</span><span class="cx"> content: '';
</span><span class="cx"> display: inline-block;
</span></span></pre></div>
<a id="trunkSourceWebInspectorUIUserInterfaceViewsTabBarjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js (198687 => 198688)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js 2016-03-25 20:37:49 UTC (rev 198687)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js 2016-03-25 20:45:35 UTC (rev 198688)
</span><span class="lines">@@ -363,23 +363,15 @@
</span><span class="cx"> if (this._selectedTabBarItem === tabBarItem)
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- let previouslySelectedTabIdentifier = "";
-
- if (this._selectedTabBarItem) {
</del><ins>+ if (this._selectedTabBarItem)
</ins><span class="cx"> this._selectedTabBarItem.selected = false;
</span><del>- previouslySelectedTabIdentifier = this._selectedTabBarItem.representedObject.identifier;
- }
</del><span class="cx">
</span><span class="cx"> this._selectedTabBarItem = tabBarItem || null;
</span><span class="cx">
</span><del>- let selectedTabIdentifier = "";
-
- if (this._selectedTabBarItem) {
</del><ins>+ if (this._selectedTabBarItem)
</ins><span class="cx"> this._selectedTabBarItem.selected = true;
</span><del>- selectedTabIdentifier = this._selectedTabBarItem.representedObject.identifier;
- }
</del><span class="cx">
</span><del>- this.dispatchEventToListeners(WebInspector.TabBar.Event.TabBarItemSelected, {previouslySelectedTabIdentifier, selectedTabIdentifier});
</del><ins>+ this.dispatchEventToListeners(WebInspector.TabBar.Event.TabBarItemSelected);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> get tabBarItems()
</span></span></pre>
</div>
</div>
</body>
</html>