<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198713] trunk/Source/JavaScriptCore</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198713">198713</a></dd>
<dt>Author</dt> <dd>commit-queue@webkit.org</dd>
<dt>Date</dt> <dd>2016-03-25 23:51:11 -0700 (Fri, 25 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Misc. JavaScriptCore built-ins cleanups
https://bugs.webkit.org/show_bug.cgi?id=155920
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-03-25
Reviewed by Mark Lam.
* builtins/RegExpPrototype.js:
(match):
No need for an else after an if that always returns.
* builtins/TypedArrayConstructor.js:
(of):
Fix error message to use the correct function name.
(allocateInt8Array):
(allocateInt16Array):
(allocateInt32Array):
(allocateUint32Array):
(allocateUint16Array):
(allocateUint8Array):
(allocateUint8ClampedArray):
(allocateFloat32Array):
(allocateFloat64Array):
Cleanup style to be like all the other code.
* tests/stress/typedarray-of.js:
Test the exception message.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceJavaScriptCoreChangeLog">trunk/Source/JavaScriptCore/ChangeLog</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsRegExpPrototypejs">trunk/Source/JavaScriptCore/builtins/RegExpPrototype.js</a></li>
<li><a href="#trunkSourceJavaScriptCorebuiltinsTypedArrayConstructorjs">trunk/Source/JavaScriptCore/builtins/TypedArrayConstructor.js</a></li>
<li><a href="#trunkSourceJavaScriptCoretestsstresstypedarrayofjs">trunk/Source/JavaScriptCore/tests/stress/typedarray-of.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceJavaScriptCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/ChangeLog (198712 => 198713)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/ChangeLog 2016-03-26 05:36:14 UTC (rev 198712)
+++ trunk/Source/JavaScriptCore/ChangeLog 2016-03-26 06:51:11 UTC (rev 198713)
</span><span class="lines">@@ -1,5 +1,34 @@
</span><span class="cx"> 2016-03-25 Joseph Pecoraro <pecoraro@apple.com>
</span><span class="cx">
</span><ins>+ Misc. JavaScriptCore built-ins cleanups
+ https://bugs.webkit.org/show_bug.cgi?id=155920
+
+ Reviewed by Mark Lam.
+
+ * builtins/RegExpPrototype.js:
+ (match):
+ No need for an else after an if that always returns.
+
+ * builtins/TypedArrayConstructor.js:
+ (of):
+ Fix error message to use the correct function name.
+
+ (allocateInt8Array):
+ (allocateInt16Array):
+ (allocateInt32Array):
+ (allocateUint32Array):
+ (allocateUint16Array):
+ (allocateUint8Array):
+ (allocateUint8ClampedArray):
+ (allocateFloat32Array):
+ (allocateFloat64Array):
+ Cleanup style to be like all the other code.
+
+ * tests/stress/typedarray-of.js:
+ Test the exception message.
+
+2016-03-25 Joseph Pecoraro <pecoraro@apple.com>
+
</ins><span class="cx"> Date.prototype.toLocaleDateString uses overridable Object.create
</span><span class="cx"> https://bugs.webkit.org/show_bug.cgi?id=155917
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsRegExpPrototypejs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/RegExpPrototype.js (198712 => 198713)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/RegExpPrototype.js 2016-03-26 05:36:14 UTC (rev 198712)
+++ trunk/Source/JavaScriptCore/builtins/RegExpPrototype.js 2016-03-26 06:51:11 UTC (rev 198713)
</span><span class="lines">@@ -72,7 +72,9 @@
</span><span class="cx"> if (resultList.length === 0)
</span><span class="cx"> return null;
</span><span class="cx"> return resultList;
</span><del>- } else if (!@isObject(result))
</del><ins>+ }
+
+ if (!@isObject(result))
</ins><span class="cx"> throw new @TypeError("RegExp.prototype.@@match call to RegExp.exec didn't return null or an object");
</span><span class="cx">
</span><span class="cx"> let resultString = @toString(result[0]);
</span></span></pre></div>
<a id="trunkSourceJavaScriptCorebuiltinsTypedArrayConstructorjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/builtins/TypedArrayConstructor.js (198712 => 198713)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/builtins/TypedArrayConstructor.js 2016-03-26 05:36:14 UTC (rev 198712)
+++ trunk/Source/JavaScriptCore/builtins/TypedArrayConstructor.js 2016-03-26 06:51:11 UTC (rev 198713)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> let len = arguments.length;
</span><span class="cx"> let constructFunction = this.@allocateTypedArray;
</span><span class="cx"> if (constructFunction === @undefined)
</span><del>- throw new @TypeError("TypedArray.from requires its this argument to subclass a TypedArray constructor");
</del><ins>+ throw new @TypeError("TypedArray.of requires its this argument to subclass a TypedArray constructor");
</ins><span class="cx">
</span><span class="cx"> let result = constructFunction(len);
</span><span class="cx">
</span><span class="lines">@@ -126,56 +126,47 @@
</span><span class="cx"> return result;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function allocateInt8Array(length) {
-
</del><ins>+function allocateInt8Array(length)
+{
</ins><span class="cx"> return new @Int8Array(length);
</span><del>-
</del><span class="cx"> }
</span><span class="cx">
</span><del>-function allocateInt16Array(length) {
-
- return new @Int16Array(length);
-
</del><ins>+function allocateInt16Array(length)
+{
+ return new @Int16Array(length);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-function allocateInt32Array(length) {
-
- return new @Int32Array(length);
-
</del><ins>+function allocateInt32Array(length)
+{
+ return new @Int32Array(length);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-function allocateUint32Array(length) {
-
</del><ins>+function allocateUint32Array(length)
+{
</ins><span class="cx"> return new @Uint32Array(length);
</span><del>-
</del><span class="cx"> }
</span><span class="cx">
</span><del>-function allocateUint16Array(length) {
-
- return new @Uint16Array(length);
-
</del><ins>+function allocateUint16Array(length)
+{
+ return new @Uint16Array(length);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-function allocateUint8Array(length) {
-
- return new @Uint8Array(length);
-
</del><ins>+function allocateUint8Array(length)
+{
+ return new @Uint8Array(length);
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-function allocateUint8ClampedArray(length) {
-
</del><ins>+function allocateUint8ClampedArray(length)
+{
</ins><span class="cx"> return new @Uint8ClampedArray(length);
</span><del>-
</del><span class="cx"> }
</span><span class="cx">
</span><del>-function allocateFloat32Array(length) {
-
</del><ins>+function allocateFloat32Array(length)
+{
</ins><span class="cx"> return new @Float32Array(length);
</span><del>-
</del><span class="cx"> }
</span><span class="cx">
</span><del>-function allocateFloat64Array(length) {
-
</del><ins>+function allocateFloat64Array(length)
+{
</ins><span class="cx"> return new @Float64Array(length);
</span><del>-
</del><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceJavaScriptCoretestsstresstypedarrayofjs"></a>
<div class="modfile"><h4>Modified: trunk/Source/JavaScriptCore/tests/stress/typedarray-of.js (198712 => 198713)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/JavaScriptCore/tests/stress/typedarray-of.js 2016-03-26 05:36:14 UTC (rev 198712)
+++ trunk/Source/JavaScriptCore/tests/stress/typedarray-of.js 2016-03-26 06:51:11 UTC (rev 198713)
</span><span class="lines">@@ -13,4 +13,9 @@
</span><span class="cx"> shouldBeTrue("testConstructorFunction('of', '()', [])");
</span><span class="cx"> shouldBeTrue("testConstructorFunction('of', '(1)', [1])");
</span><span class="cx"> shouldBeTrue("testConstructorFunction('of', '(1,2,3)', [1,2,3])");
</span><ins>+
+shouldThrow("testConstructorFunction('of', '.call(false)', false)", "'TypeError: TypedArray.of requires its this argument to subclass a TypedArray constructor'");
+shouldThrow("testConstructorFunction('of', '.call({})', false)", "'TypeError: TypedArray.of requires its this argument to subclass a TypedArray constructor'");
+shouldThrow("testConstructorFunction('of', '.call([])', false)", "'TypeError: TypedArray.of requires its this argument to subclass a TypedArray constructor'");
+
</ins><span class="cx"> finishJSTest();
</span></span></pre>
</div>
</div>
</body>
</html>