<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198580] trunk/Source</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198580">198580</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-03-23 01:51:59 -0700 (Wed, 23 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use Region instead of IntRect in PageClient and WebPageProxy setViewNeedsDisplay method
https://bugs.webkit.org/show_bug.cgi?id=155747
Reviewed by Darin Adler.
Source/WebCore:
Add helper function to make cairo region out of a WebCore::Region.
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::toCairoRegion):
* platform/graphics/cairo/CairoUtilities.h:
Source/WebKit2:
This way instead of calling setViewNeedsDisplay() for every
rectangle in the damage area, we can build a region and call
setViewNeedsDisplay() once. GTK+ has API to queue a redraw for a
given region, so we also avoid scheduling multiple redraws in GTK+
port.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setViewNeedsDisplay): Convert the Region
into a cairo_region_t and use gtk_widget_queue_draw_region()
instyead of gtk_widget_queue_draw_area().
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Build a Region
with the damage rectangles and call
WebPageProxy::setViewNeedsDisplay() once.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setViewNeedsDisplay):
* UIProcess/WebPageProxy.h:
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::setViewNeedsDisplay):
* UIProcess/efl/WebView.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::setViewNeedsDisplay):
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setViewNeedsDisplay):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeLog</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscairoCairoUtilitiescpp">trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp</a></li>
<li><a href="#trunkSourceWebCoreplatformgraphicscairoCairoUtilitiesh">trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.h</a></li>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkPageClientImplcpp">trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkPageClientImplh">trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessDrawingAreaProxyImplcpp">trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPageClienth">trunk/Source/WebKit2/UIProcess/PageClient.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxyh">trunk/Source/WebKit2/UIProcess/WebPageProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcesseflWebViewcpp">trunk/Source/WebKit2/UIProcess/efl/WebView.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcesseflWebViewh">trunk/Source/WebKit2/UIProcess/efl/WebView.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosPageClientImplIOSh">trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosPageClientImplIOSmm">trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacPageClientImplh">trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacPageClientImplmm">trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebCoreChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/ChangeLog 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebCore/ChangeLog 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -1,3 +1,16 @@
</span><ins>+2016-03-23 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ Use Region instead of IntRect in PageClient and WebPageProxy setViewNeedsDisplay method
+ https://bugs.webkit.org/show_bug.cgi?id=155747
+
+ Reviewed by Darin Adler.
+
+ Add helper function to make cairo region out of a WebCore::Region.
+
+ * platform/graphics/cairo/CairoUtilities.cpp:
+ (WebCore::toCairoRegion):
+ * platform/graphics/cairo/CairoUtilities.h:
+
</ins><span class="cx"> 2016-03-22 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscairoCairoUtilitiescpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -37,6 +37,7 @@
</span><span class="cx"> #include "Path.h"
</span><span class="cx"> #include "PlatformPathCairo.h"
</span><span class="cx"> #include "RefPtrCairo.h"
</span><ins>+#include "Region.h"
</ins><span class="cx"> #include <wtf/Assertions.h>
</span><span class="cx"> #include <wtf/Vector.h>
</span><span class="cx">
</span><span class="lines">@@ -308,6 +309,16 @@
</span><span class="cx"> #endif
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+RefPtr<cairo_region_t> toCairoRegion(const Region& region)
+{
+ RefPtr<cairo_region_t> cairoRegion = adoptRef(cairo_region_create());
+ for (const auto& rect : region.rects()) {
+ cairo_rectangle_int_t cairoRect = rect;
+ cairo_region_union_rectangle(cairoRegion.get(), &cairoRect);
+ }
+ return cairoRegion;
+}
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // USE(CAIRO)
</span></span></pre></div>
<a id="trunkSourceWebCoreplatformgraphicscairoCairoUtilitiesh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.h (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.h 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.h 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -44,6 +44,7 @@
</span><span class="cx"> class IntSize;
</span><span class="cx"> class IntRect;
</span><span class="cx"> class Path;
</span><ins>+class Region;
</ins><span class="cx">
</span><span class="cx"> void copyContextProperties(cairo_t* srcCr, cairo_t* dstCr);
</span><span class="cx"> void setSourceRGBAFromColor(cairo_t*, const Color&);
</span><span class="lines">@@ -65,6 +66,8 @@
</span><span class="cx"> void cairoSurfaceSetDeviceScale(cairo_surface_t*, double xScale, double yScale);
</span><span class="cx"> void cairoSurfaceGetDeviceScale(cairo_surface_t*, double& xScale, double& yScale);
</span><span class="cx">
</span><ins>+RefPtr<cairo_region_t> toCairoRegion(const Region&);
+
</ins><span class="cx"> } // namespace WebCore
</span><span class="cx">
</span><span class="cx"> #endif // USE(CAIRO)
</span></span></pre></div>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/ChangeLog 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -1,3 +1,39 @@
</span><ins>+2016-03-23 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ Use Region instead of IntRect in PageClient and WebPageProxy setViewNeedsDisplay method
+ https://bugs.webkit.org/show_bug.cgi?id=155747
+
+ Reviewed by Darin Adler.
+
+ This way instead of calling setViewNeedsDisplay() for every
+ rectangle in the damage area, we can build a region and call
+ setViewNeedsDisplay() once. GTK+ has API to queue a redraw for a
+ given region, so we also avoid scheduling multiple redraws in GTK+
+ port.
+
+ * UIProcess/API/gtk/PageClientImpl.cpp:
+ (WebKit::PageClientImpl::setViewNeedsDisplay): Convert the Region
+ into a cairo_region_t and use gtk_widget_queue_draw_region()
+ instyead of gtk_widget_queue_draw_area().
+ * UIProcess/API/gtk/PageClientImpl.h:
+ * UIProcess/DrawingAreaProxyImpl.cpp:
+ (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Build a Region
+ with the damage rectangles and call
+ WebPageProxy::setViewNeedsDisplay() once.
+ * UIProcess/PageClient.h:
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::setViewNeedsDisplay):
+ * UIProcess/WebPageProxy.h:
+ * UIProcess/efl/WebView.cpp:
+ (WebKit::WebView::setViewNeedsDisplay):
+ * UIProcess/efl/WebView.h:
+ * UIProcess/ios/PageClientImplIOS.h:
+ * UIProcess/ios/PageClientImplIOS.mm:
+ (WebKit::PageClientImpl::setViewNeedsDisplay):
+ * UIProcess/mac/PageClientImpl.h:
+ * UIProcess/mac/PageClientImpl.mm:
+ (WebKit::PageClientImpl::setViewNeedsDisplay):
+
</ins><span class="cx"> 2016-03-22 Tim Horton <timothy_horton@apple.com>
</span><span class="cx">
</span><span class="cx"> Invoking a link preview on a complex link (e.g. an image) results in an empty TextIndicator
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkPageClientImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -41,9 +41,11 @@
</span><span class="cx"> #include "WebPageProxy.h"
</span><span class="cx"> #include "WebPopupMenuProxyGtk.h"
</span><span class="cx"> #include "WebProcessPool.h"
</span><ins>+#include <WebCore/CairoUtilities.h>
</ins><span class="cx"> #include <WebCore/Cursor.h>
</span><span class="cx"> #include <WebCore/EventNames.h>
</span><span class="cx"> #include <WebCore/GtkUtilities.h>
</span><ins>+#include <WebCore/RefPtrCairo.h>
</ins><span class="cx"> #include <wtf/text/CString.h>
</span><span class="cx"> #include <wtf/text/WTFString.h>
</span><span class="cx">
</span><span class="lines">@@ -62,9 +64,10 @@
</span><span class="cx"> return std::make_unique<DrawingAreaProxyImpl>(*webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(m_viewWidget)));
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageClientImpl::setViewNeedsDisplay(const WebCore::IntRect& rect)
</del><ins>+void PageClientImpl::setViewNeedsDisplay(const WebCore::Region& region)
</ins><span class="cx"> {
</span><del>- gtk_widget_queue_draw_area(m_viewWidget, rect.x(), rect.y(), rect.width(), rect.height());
</del><ins>+ RefPtr<cairo_region_t> damageRegion = toCairoRegion(region);
+ gtk_widget_queue_draw_region(m_viewWidget, damageRegion.get());
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void PageClientImpl::requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&, bool)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkPageClientImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -55,7 +55,7 @@
</span><span class="cx"> private:
</span><span class="cx"> // PageClient
</span><span class="cx"> std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy() override;
</span><del>- void setViewNeedsDisplay(const WebCore::IntRect&) override;
</del><ins>+ void setViewNeedsDisplay(const WebCore::Region&) override;
</ins><span class="cx"> void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) override;
</span><span class="cx"> WebCore::IntSize viewSize() override;
</span><span class="cx"> bool isViewWindowActive() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessDrawingAreaProxyImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -228,11 +228,14 @@
</span><span class="cx"> m_backingStore = std::make_unique<BackingStore>(updateInfo.viewSize, updateInfo.deviceScaleFactor, m_webPageProxy);
</span><span class="cx">
</span><span class="cx"> m_backingStore->incorporateUpdate(updateInfo);
</span><ins>+
+ Region damageRegion;
</ins><span class="cx"> if (updateInfo.scrollRect.isEmpty()) {
</span><span class="cx"> for (const auto& rect : updateInfo.updateRects)
</span><del>- m_webPageProxy.setViewNeedsDisplay(rect);
</del><ins>+ damageRegion.unite(rect);
</ins><span class="cx"> } else
</span><del>- m_webPageProxy.setViewNeedsDisplay(IntRect(IntPoint(), m_webPageProxy.viewSize()));
</del><ins>+ damageRegion = IntRect(IntPoint(), m_webPageProxy.viewSize());
+ m_webPageProxy.setViewNeedsDisplay(damageRegion);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void DrawingAreaProxyImpl::backingStoreStateDidChange(RespondImmediatelyOrNot respondImmediatelyOrNot)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPageClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/PageClient.h (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/PageClient.h 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/PageClient.h 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -93,8 +93,8 @@
</span><span class="cx"> // Create a new drawing area proxy for the given page.
</span><span class="cx"> virtual std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy() = 0;
</span><span class="cx">
</span><del>- // Tell the view to invalidate the given rect. The rect is in view coordinates.
- virtual void setViewNeedsDisplay(const WebCore::IntRect&) = 0;
</del><ins>+ // Tell the view to invalidate the given region. The region is in view coordinates.
+ virtual void setViewNeedsDisplay(const WebCore::Region&) = 0;
</ins><span class="cx">
</span><span class="cx"> // Tell the view to scroll to the given position, and whether this was a programmatic scroll.
</span><span class="cx"> virtual void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) = 0;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -1319,9 +1319,9 @@
</span><span class="cx"> m_process->send(Messages::WebPage::ViewWillEndLiveResize(), m_pageID);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebPageProxy::setViewNeedsDisplay(const IntRect& rect)
</del><ins>+void WebPageProxy::setViewNeedsDisplay(const Region& region)
</ins><span class="cx"> {
</span><del>- m_pageClient.setViewNeedsDisplay(rect);
</del><ins>+ m_pageClient.setViewNeedsDisplay(region);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebPageProxy::requestScroll(const FloatPoint& scrollPosition, const IntPoint& scrollOrigin, bool isProgrammaticScroll)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -413,7 +413,7 @@
</span><span class="cx"> void clearSelection();
</span><span class="cx"> void restoreSelectionInFocusedEditableElement();
</span><span class="cx">
</span><del>- void setViewNeedsDisplay(const WebCore::IntRect&);
</del><ins>+ void setViewNeedsDisplay(const WebCore::Region&);
</ins><span class="cx"> void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll);
</span><span class="cx">
</span><span class="cx"> void setDelegatesScrolling(bool delegatesScrolling) { m_delegatesScrolling = delegatesScrolling; }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcesseflWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/efl/WebView.cpp (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/efl/WebView.cpp 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/efl/WebView.cpp 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -409,9 +409,10 @@
</span><span class="cx"> return std::make_unique<CoordinatedDrawingAreaProxy>(*m_page);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebView::setViewNeedsDisplay(const WebCore::IntRect& area)
</del><ins>+void WebView::setViewNeedsDisplay(const WebCore::Region& region)
</ins><span class="cx"> {
</span><del>- m_client.viewNeedsDisplay(this, area);
</del><ins>+ for (const auto& rect : region.rects())
+ m_client.viewNeedsDisplay(this, rect);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void WebView::requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&, bool)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcesseflWebViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/efl/WebView.h (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/efl/WebView.h 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/efl/WebView.h 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -154,7 +154,7 @@
</span><span class="cx"> // PageClient
</span><span class="cx"> std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy() override;
</span><span class="cx">
</span><del>- void setViewNeedsDisplay(const WebCore::IntRect&) override;
</del><ins>+ void setViewNeedsDisplay(const WebCore::Region&) override;
</ins><span class="cx">
</span><span class="cx"> void requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&, bool) override;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosPageClientImplIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -50,7 +50,7 @@
</span><span class="cx"> private:
</span><span class="cx"> // PageClient
</span><span class="cx"> std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy() override;
</span><del>- void setViewNeedsDisplay(const WebCore::IntRect&) override;
</del><ins>+ void setViewNeedsDisplay(const WebCore::Region&) override;
</ins><span class="cx"> void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) override;
</span><span class="cx"> WebCore::IntSize viewSize() override;
</span><span class="cx"> bool isViewWindowActive() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosPageClientImplIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -123,7 +123,7 @@
</span><span class="cx"> return [m_contentView _createDrawingAreaProxy];
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageClientImpl::setViewNeedsDisplay(const IntRect& rect)
</del><ins>+void PageClientImpl::setViewNeedsDisplay(const Region&)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacPageClientImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -62,7 +62,7 @@
</span><span class="cx"> private:
</span><span class="cx"> // PageClient
</span><span class="cx"> std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy() override;
</span><del>- void setViewNeedsDisplay(const WebCore::IntRect&) override;
</del><ins>+ void setViewNeedsDisplay(const WebCore::Region&) override;
</ins><span class="cx"> void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) override;
</span><span class="cx">
</span><span class="cx"> WebCore::IntSize viewSize() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacPageClientImplmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm (198579 => 198580)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm 2016-03-23 08:21:03 UTC (rev 198579)
+++ trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm 2016-03-23 08:51:59 UTC (rev 198580)
</span><span class="lines">@@ -115,7 +115,7 @@
</span><span class="cx"> return m_impl->createDrawingAreaProxy();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageClientImpl::setViewNeedsDisplay(const WebCore::IntRect& rect)
</del><ins>+void PageClientImpl::setViewNeedsDisplay(const WebCore::Region&)
</ins><span class="cx"> {
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>