<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198526] trunk/Source/WebKit2</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198526">198526</a></dd>
<dt>Author</dt> <dd>carlosgc@webkit.org</dd>
<dt>Date</dt> <dd>2016-03-22 06:22:37 -0700 (Tue, 22 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove unused display and scroll view methods from PageClient and WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=155744
Reviewed by Andreas Kling.
We have displayView(), canScrollView() and scrollView() that are
used by DrawingAreaProxyImpl which is only used by GTK+ port that
doesn't implement those methods.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::displayView): Deleted.
(WebKit::PageClientImpl::scrollView): Deleted.
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Update the
whole view when scrolling, or the damage area otherwise.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::displayView): Deleted.
(WebKit::WebPageProxy::canScrollView): Deleted.
(WebKit::WebPageProxy::scrollView): Deleted.
* UIProcess/WebPageProxy.h:
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::displayView): Deleted.
(WebKit::WebView::scrollView): Deleted.
* UIProcess/efl/WebView.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::displayView): Deleted.
(WebKit::PageClientImpl::canScrollView): Deleted.
(WebKit::PageClientImpl::scrollView): Deleted.
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::displayView): Deleted.
(WebKit::PageClientImpl::canScrollView): Deleted.
(WebKit::PageClientImpl::scrollView): Deleted.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkSourceWebKit2ChangeLog">trunk/Source/WebKit2/ChangeLog</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkPageClientImplcpp">trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessAPIgtkPageClientImplh">trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessDrawingAreaProxyImplcpp">trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessPageClienth">trunk/Source/WebKit2/UIProcess/PageClient.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxycpp">trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcessWebPageProxyh">trunk/Source/WebKit2/UIProcess/WebPageProxy.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcesseflWebViewcpp">trunk/Source/WebKit2/UIProcess/efl/WebView.cpp</a></li>
<li><a href="#trunkSourceWebKit2UIProcesseflWebViewh">trunk/Source/WebKit2/UIProcess/efl/WebView.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosPageClientImplIOSh">trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessiosPageClientImplIOSmm">trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacPageClientImplh">trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h</a></li>
<li><a href="#trunkSourceWebKit2UIProcessmacPageClientImplmm">trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkSourceWebKit2ChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/ChangeLog (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/ChangeLog 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/ChangeLog 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -1,3 +1,42 @@
</span><ins>+2016-03-22 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ Remove unused display and scroll view methods from PageClient and WebPageProxy
+ https://bugs.webkit.org/show_bug.cgi?id=155744
+
+ Reviewed by Andreas Kling.
+
+ We have displayView(), canScrollView() and scrollView() that are
+ used by DrawingAreaProxyImpl which is only used by GTK+ port that
+ doesn't implement those methods.
+
+ * UIProcess/API/gtk/PageClientImpl.cpp:
+ (WebKit::PageClientImpl::displayView): Deleted.
+ (WebKit::PageClientImpl::scrollView): Deleted.
+ * UIProcess/API/gtk/PageClientImpl.h:
+ * UIProcess/DrawingAreaProxyImpl.cpp:
+ (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Update the
+ whole view when scrolling, or the damage area otherwise.
+ * UIProcess/PageClient.h:
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::displayView): Deleted.
+ (WebKit::WebPageProxy::canScrollView): Deleted.
+ (WebKit::WebPageProxy::scrollView): Deleted.
+ * UIProcess/WebPageProxy.h:
+ * UIProcess/efl/WebView.cpp:
+ (WebKit::WebView::displayView): Deleted.
+ (WebKit::WebView::scrollView): Deleted.
+ * UIProcess/efl/WebView.h:
+ * UIProcess/ios/PageClientImplIOS.h:
+ * UIProcess/ios/PageClientImplIOS.mm:
+ (WebKit::PageClientImpl::displayView): Deleted.
+ (WebKit::PageClientImpl::canScrollView): Deleted.
+ (WebKit::PageClientImpl::scrollView): Deleted.
+ * UIProcess/mac/PageClientImpl.h:
+ * UIProcess/mac/PageClientImpl.mm:
+ (WebKit::PageClientImpl::displayView): Deleted.
+ (WebKit::PageClientImpl::canScrollView): Deleted.
+ (WebKit::PageClientImpl::scrollView): Deleted.
+
</ins><span class="cx"> 2016-03-22 Zan Dobersek <zdobersek@igalia.com>
</span><span class="cx">
</span><span class="cx"> [CoordinatedGraphics] Polish std::function<> usage in ThreadedCompositor, CoordinatedGraphicsScene
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkPageClientImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -67,16 +67,6 @@
</span><span class="cx"> gtk_widget_queue_draw_area(m_viewWidget, rect.x(), rect.y(), rect.width(), rect.height());
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageClientImpl::displayView()
-{
- notImplemented();
-}
-
-void PageClientImpl::scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& /* scrollOffset */)
-{
- setViewNeedsDisplay(scrollRect);
-}
-
</del><span class="cx"> void PageClientImpl::requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&, bool)
</span><span class="cx"> {
</span><span class="cx"> notImplemented();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessAPIgtkPageClientImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -56,9 +56,6 @@
</span><span class="cx"> // PageClient
</span><span class="cx"> std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy() override;
</span><span class="cx"> void setViewNeedsDisplay(const WebCore::IntRect&) override;
</span><del>- void displayView() override;
- bool canScrollView() override { return false; }
- void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset) override;
</del><span class="cx"> void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) override;
</span><span class="cx"> WebCore::IntSize viewSize() override;
</span><span class="cx"> bool isViewWindowActive() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessDrawingAreaProxyImplcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -228,21 +228,11 @@
</span><span class="cx"> m_backingStore = std::make_unique<BackingStore>(updateInfo.viewSize, updateInfo.deviceScaleFactor, m_webPageProxy);
</span><span class="cx">
</span><span class="cx"> m_backingStore->incorporateUpdate(updateInfo);
</span><del>-
- bool shouldScroll = !updateInfo.scrollRect.isEmpty();
-
- if (shouldScroll)
- m_webPageProxy.scrollView(updateInfo.scrollRect, updateInfo.scrollOffset);
-
- if (shouldScroll && !m_webPageProxy.canScrollView())
</del><ins>+ if (updateInfo.scrollRect.isEmpty()) {
+ for (const auto& rect : updateInfo.updateRects)
+ m_webPageProxy.setViewNeedsDisplay(rect);
+ } else
</ins><span class="cx"> m_webPageProxy.setViewNeedsDisplay(IntRect(IntPoint(), m_webPageProxy.viewSize()));
</span><del>- else {
- for (size_t i = 0; i < updateInfo.updateRects.size(); ++i)
- m_webPageProxy.setViewNeedsDisplay(updateInfo.updateRects[i]);
- }
-
- if (shouldScroll)
- m_webPageProxy.displayView();
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> void DrawingAreaProxyImpl::backingStoreStateDidChange(RespondImmediatelyOrNot respondImmediatelyOrNot)
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessPageClienth"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/PageClient.h (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/PageClient.h 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/PageClient.h 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -96,13 +96,6 @@
</span><span class="cx"> // Tell the view to invalidate the given rect. The rect is in view coordinates.
</span><span class="cx"> virtual void setViewNeedsDisplay(const WebCore::IntRect&) = 0;
</span><span class="cx">
</span><del>- // Tell the view to immediately display its invalid rect.
- virtual void displayView() = 0;
-
- // Return true if scrollView() can copy bits in the view.
- virtual bool canScrollView() = 0;
- // Tell the view to scroll scrollRect by scrollOffset.
- virtual void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset) = 0;
</del><span class="cx"> // Tell the view to scroll to the given position, and whether this was a programmatic scroll.
</span><span class="cx"> virtual void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) = 0;
</span><span class="cx">
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxycpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -1324,21 +1324,6 @@
</span><span class="cx"> m_pageClient.setViewNeedsDisplay(rect);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebPageProxy::displayView()
-{
- m_pageClient.displayView();
-}
-
-bool WebPageProxy::canScrollView()
-{
- return m_pageClient.canScrollView();
-}
-
-void WebPageProxy::scrollView(const IntRect& scrollRect, const IntSize& scrollOffset)
-{
- m_pageClient.scrollView(scrollRect, scrollOffset);
-}
-
</del><span class="cx"> void WebPageProxy::requestScroll(const FloatPoint& scrollPosition, const IntPoint& scrollOrigin, bool isProgrammaticScroll)
</span><span class="cx"> {
</span><span class="cx"> m_pageClient.requestScroll(scrollPosition, scrollOrigin, isProgrammaticScroll);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessWebPageProxyh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -414,9 +414,6 @@
</span><span class="cx"> void restoreSelectionInFocusedEditableElement();
</span><span class="cx">
</span><span class="cx"> void setViewNeedsDisplay(const WebCore::IntRect&);
</span><del>- void displayView();
- bool canScrollView();
- void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset); // FIXME: CoordinatedGraphics should use requestScroll().
</del><span class="cx"> void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll);
</span><span class="cx">
</span><span class="cx"> void setDelegatesScrolling(bool delegatesScrolling) { m_delegatesScrolling = delegatesScrolling; }
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcesseflWebViewcpp"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/efl/WebView.cpp (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/efl/WebView.cpp 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/efl/WebView.cpp 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -414,16 +414,6 @@
</span><span class="cx"> m_client.viewNeedsDisplay(this, area);
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void WebView::displayView()
-{
- notImplemented();
-}
-
-void WebView::scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize&)
-{
- setViewNeedsDisplay(scrollRect);
-}
-
</del><span class="cx"> void WebView::requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&, bool)
</span><span class="cx"> {
</span><span class="cx"> notImplemented();
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcesseflWebViewh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/efl/WebView.h (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/efl/WebView.h 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/efl/WebView.h 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -156,10 +156,6 @@
</span><span class="cx">
</span><span class="cx"> void setViewNeedsDisplay(const WebCore::IntRect&) override;
</span><span class="cx">
</span><del>- void displayView() override;
-
- bool canScrollView() override { return false; }
- void scrollView(const WebCore::IntRect&, const WebCore::IntSize&) override;
</del><span class="cx"> void requestScroll(const WebCore::FloatPoint&, const WebCore::IntPoint&, bool) override;
</span><span class="cx">
</span><span class="cx"> WebCore::IntSize viewSize() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosPageClientImplIOSh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.h 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -51,9 +51,6 @@
</span><span class="cx"> // PageClient
</span><span class="cx"> std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy() override;
</span><span class="cx"> void setViewNeedsDisplay(const WebCore::IntRect&) override;
</span><del>- void displayView() override;
- bool canScrollView() override;
- void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset) override;
</del><span class="cx"> void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) override;
</span><span class="cx"> WebCore::IntSize viewSize() override;
</span><span class="cx"> bool isViewWindowActive() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessiosPageClientImplIOSmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -128,22 +128,6 @@
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageClientImpl::displayView()
-{
- ASSERT_NOT_REACHED();
-}
-
-bool PageClientImpl::canScrollView()
-{
- notImplemented();
- return false;
-}
-
-void PageClientImpl::scrollView(const IntRect&, const IntSize&)
-{
- ASSERT_NOT_REACHED();
-}
-
</del><span class="cx"> void PageClientImpl::requestScroll(const FloatPoint& scrollPosition, const IntPoint& scrollOrigin, bool isProgrammaticScroll)
</span><span class="cx"> {
</span><span class="cx"> UNUSED_PARAM(isProgrammaticScroll);
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacPageClientImplh"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -63,9 +63,6 @@
</span><span class="cx"> // PageClient
</span><span class="cx"> std::unique_ptr<DrawingAreaProxy> createDrawingAreaProxy() override;
</span><span class="cx"> void setViewNeedsDisplay(const WebCore::IntRect&) override;
</span><del>- void displayView() override;
- bool canScrollView() override;
- void scrollView(const WebCore::IntRect& scrollRect, const WebCore::IntSize& scrollOffset) override;
</del><span class="cx"> void requestScroll(const WebCore::FloatPoint& scrollPosition, const WebCore::IntPoint& scrollOrigin, bool isProgrammaticScroll) override;
</span><span class="cx">
</span><span class="cx"> WebCore::IntSize viewSize() override;
</span></span></pre></div>
<a id="trunkSourceWebKit2UIProcessmacPageClientImplmm"></a>
<div class="modfile"><h4>Modified: trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm (198525 => 198526)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm 2016-03-22 09:44:47 UTC (rev 198525)
+++ trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm 2016-03-22 13:22:37 UTC (rev 198526)
</span><span class="lines">@@ -120,21 +120,6 @@
</span><span class="cx"> ASSERT_NOT_REACHED();
</span><span class="cx"> }
</span><span class="cx">
</span><del>-void PageClientImpl::displayView()
-{
- ASSERT_NOT_REACHED();
-}
-
-bool PageClientImpl::canScrollView()
-{
- return false;
-}
-
-void PageClientImpl::scrollView(const IntRect& scrollRect, const IntSize& scrollOffset)
-{
- ASSERT_NOT_REACHED();
-}
-
</del><span class="cx"> void PageClientImpl::requestScroll(const FloatPoint& scrollPosition, const IntPoint& scrollOrigin, bool isProgrammaticScroll)
</span><span class="cx"> {
</span><span class="cx"> ASSERT_NOT_REACHED();
</span></span></pre>
</div>
</div>
</body>
</html>