<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[198518] trunk/Websites/perf.webkit.org</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.webkit.org/projects/webkit/changeset/198518">198518</a></dd>
<dt>Author</dt> <dd>rniwa@webkit.org</dd>
<dt>Date</dt> <dd>2016-03-21 19:58:19 -0700 (Mon, 21 Mar 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>Commit log viewer repaints too frequently after <a href="http://trac.webkit.org/projects/webkit/changeset/198499">r198499</a>
https://bugs.webkit.org/show_bug.cgi?id=155732
Reviewed by Joseph Pecoraro.
The bug was caused by InteractiveTimeSeriesChart invoking onchange callback whenever mouse moved even
if the current point didn't change. Fixed the bug by avoiding the work if the indicator hadn't changed
and avoiding work in the commit log viewer when the requested repository and the revision range were
the same as those of the last request.
* public/v3/components/commit-log-viewer.js:
(CommitLogViewer):
(CommitLogViewer.prototype.currentRepository): Exit early when repository and the revision range are
identical to the one we already have to avoid repaints and issuing multiple network requests.
* public/v3/components/interactive-time-series-chart.js:
(InteractiveTimeSeriesChart.prototype._mouseMove): Don't invoke _notifyIndicatorChanged if the current
indicator hadn't changed.
* public/v3/pages/chart-pane.js:
(ChartPane.prototype._indicatorDidChange): Fixed the bug that unlocking the indicator wouldn't update
the URL. We need to check whether the lock state had changed. The old condition was also redundant
since _mainChartIndicatorWasLocked is always identically equal to isLocked per the prior assignment.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkWebsitesperfwebkitorgChangeLog">trunk/Websites/perf.webkit.org/ChangeLog</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3componentscommitlogviewerjs">trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3componentsinteractivetimeserieschartjs">trunk/Websites/perf.webkit.org/public/v3/components/interactive-time-series-chart.js</a></li>
<li><a href="#trunkWebsitesperfwebkitorgpublicv3pageschartpanejs">trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkWebsitesperfwebkitorgChangeLog"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/ChangeLog (198517 => 198518)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/ChangeLog 2016-03-22 01:53:50 UTC (rev 198517)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-03-22 02:58:19 UTC (rev 198518)
</span><span class="lines">@@ -1,5 +1,29 @@
</span><span class="cx"> 2016-03-21 Ryosuke Niwa <rniwa@webkit.org>
</span><span class="cx">
</span><ins>+ Commit log viewer repaints too frequently after r198499
+ https://bugs.webkit.org/show_bug.cgi?id=155732
+
+ Reviewed by Joseph Pecoraro.
+
+ The bug was caused by InteractiveTimeSeriesChart invoking onchange callback whenever mouse moved even
+ if the current point didn't change. Fixed the bug by avoiding the work if the indicator hadn't changed
+ and avoiding work in the commit log viewer when the requested repository and the revision range were
+ the same as those of the last request.
+
+ * public/v3/components/commit-log-viewer.js:
+ (CommitLogViewer):
+ (CommitLogViewer.prototype.currentRepository): Exit early when repository and the revision range are
+ identical to the one we already have to avoid repaints and issuing multiple network requests.
+ * public/v3/components/interactive-time-series-chart.js:
+ (InteractiveTimeSeriesChart.prototype._mouseMove): Don't invoke _notifyIndicatorChanged if the current
+ indicator hadn't changed.
+ * public/v3/pages/chart-pane.js:
+ (ChartPane.prototype._indicatorDidChange): Fixed the bug that unlocking the indicator wouldn't update
+ the URL. We need to check whether the lock state had changed. The old condition was also redundant
+ since _mainChartIndicatorWasLocked is always identically equal to isLocked per the prior assignment.
+
+2016-03-21 Ryosuke Niwa <rniwa@webkit.org>
+
</ins><span class="cx"> Fix A/B testing after r198503.
</span><span class="cx">
</span><span class="cx"> * public/include/build-requests-fetcher.php:
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3componentscommitlogviewerjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js (198517 => 198518)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js 2016-03-22 01:53:50 UTC (rev 198517)
+++ trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js 2016-03-22 02:58:19 UTC (rev 198518)
</span><span class="lines">@@ -7,13 +7,21 @@
</span><span class="cx"> this._repository = null;
</span><span class="cx"> this._fetchingPromise = null;
</span><span class="cx"> this._commits = null;
</span><ins>+ this._from = null;
+ this._to = null;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> currentRepository() { return this._repository; }
</span><span class="cx">
</span><span class="cx"> view(repository, from, to)
</span><span class="cx"> {
</span><ins>+ if (this._repository == repository && this._from == from && this._to == to)
+ return Promise.resolve(null);
+
</ins><span class="cx"> this._commits = null;
</span><ins>+ this._repository = repository;
+ this._from = from;
+ this._to = to;
</ins><span class="cx">
</span><span class="cx"> if (!repository) {
</span><span class="cx"> this._fetchingPromise = null;
</span><span class="lines">@@ -21,8 +29,6 @@
</span><span class="cx"> return Promise.resolve(null);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- this._repository = repository;
-
</del><span class="cx"> if (!to) {
</span><span class="cx"> this._fetchingPromise = null;
</span><span class="cx"> this.render();
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3componentsinteractivetimeserieschartjs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/components/interactive-time-series-chart.js (198517 => 198518)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/components/interactive-time-series-chart.js 2016-03-22 01:53:50 UTC (rev 198517)
+++ trunk/Websites/perf.webkit.org/public/v3/components/interactive-time-series-chart.js 2016-03-22 02:58:19 UTC (rev 198518)
</span><span class="lines">@@ -175,13 +175,21 @@
</span><span class="cx">
</span><span class="cx"> var oldIndicatorID = this._indicatorID;
</span><span class="cx">
</span><del>- this._currentAnnotation = this._findAnnotation(cursorLocation);
</del><ins>+ var newAnnotation = this._findAnnotation(cursorLocation);
+ var newIndicatorID = null;
</ins><span class="cx"> if (this._currentAnnotation)
</span><del>- this._indicatorID = null;
</del><ins>+ newIndicatorID = null;
</ins><span class="cx"> else
</span><del>- this._indicatorID = this._findClosestPoint(cursorLocation);
</del><ins>+ newIndicatorID = this._findClosestPoint(cursorLocation);
</ins><span class="cx">
</span><span class="cx"> this._forceRender = true;
</span><ins>+
+ if (this._currentAnnotation == newAnnotation && this._indicatorID == newIndicatorID)
+ return;
+
+ this._currentAnnotation = newAnnotation;
+ this._indicatorID = newIndicatorID;
+
</ins><span class="cx"> this._notifyIndicatorChanged();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkWebsitesperfwebkitorgpublicv3pageschartpanejs"></a>
<div class="modfile"><h4>Modified: trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js (198517 => 198518)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js 2016-03-22 01:53:50 UTC (rev 198517)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js 2016-03-22 02:58:19 UTC (rev 198518)
</span><span class="lines">@@ -82,8 +82,8 @@
</span><span class="cx">
</span><span class="cx"> _indicatorDidChange(indicatorID, isLocked)
</span><span class="cx"> {
</span><ins>+ this._chartsPage.mainChartIndicatorDidChange(this, isLocked != this._mainChartIndicatorWasLocked);
</ins><span class="cx"> this._mainChartIndicatorWasLocked = isLocked;
</span><del>- this._chartsPage.mainChartIndicatorDidChange(this, isLocked || this._mainChartIndicatorWasLocked);
</del><span class="cx"> super._indicatorDidChange(indicatorID, isLocked);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>